[PATCH 05/19] staging: rtl8723bs: remove DBG_871X macro definitions

remove DBG_781X macro definitions. Remove all of the DBG_871X logs as they currently do nothing as they require the code to be modified by hand in order to be turned on. This obviously has not happened since the code was merged, so just remove them as they are unused. Signed-off-by: Fabio Aiuto

[PATCH 06/19] staging: rtl8723bs: remove all if-else empty blocks left by DBG_871X removal

remove all if-else empty {} blocks left by spatch application. removed unused variables and an unused static function definition after if-else blocks removal, to suppress compiler warnings. Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_ap.c | 22 +++--- drivers

[PATCH 07/19] drivers: rtl8723bs: rewrite comparison to null

fix following post-commit hook checkpatch warnings: CHECK: Comparison to NULL could be written "!psta" 97: FILE: drivers/staging/rtl8723bs/core/rtw_ap.c:2115: + if (psta == NULL) Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_ap.c | 2 +- 1 file

[PATCH 08/19] staging: rtl8723bs: put constant on the right side in if condition

fix the following post-commit hook checkpatch warning: WARNING: Comparisons should place the constant on the right side of the test 683: FILE: drivers/staging/rtl8723bs/os_dep/ioctl_linux.c:2204: + if (_SUCCESS != rtw_set_chplan_cmd(padapter, channel_plan_req, 1, 1)) Signed-off-by: Fabio

[PATCH 09/19] staging: rtl8723bs: remove empty for cycles left by DBG_871X removal

remove empty for cycles and unused counter variables to suppress compiler warnings. Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_recv.c | 4 drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 7 --- 2 files changed, 11 deletions(-) diff --git a/drivers/staging

[PATCH 10/19] staging: rtl8723bs: remove empty tracing function dump_rx_packet

remove tracing function dump_rx_packet after DBG_871X removal. Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_recv.c | 12 1 file changed, 12 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c index

[PATCH 11/19] staging: rtl8723bs: remove empty #ifdef blocks after DBG_871X removal

remove #ifdef and blocks #if defined() blocks left empty after DBG_871X removal. Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_ap.c | 7 -- drivers/staging/rtl8723bs/core/rtw_mlme.c | 14 drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 18 - drivers

[PATCH 12/19] staging: rtl8723bs: remove unnecessary bracks on DBG_871X removal sites

remove unnecessary bracks on DBG_871X removal sites Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_ap.c | 9 +- drivers/staging/rtl8723bs/core/rtw_btcoex.c | 6 +- drivers/staging/rtl8723bs/core/rtw_cmd.c | 10 +-- .../staging/rtl8723bs/core/rtw_ieee80211.c

[PATCH 14/19] staging: rtl8723bs: add spaces around operators

3bs/core/rtw_wlan_util.c:1849: + if (i > (NUM_STA-1)) -- CHECK: spaces preferred around that '&' (ctx:VxV) 1647: FILE: drivers/staging/rtl8723bs/os_dep/ioctl_linux.c:211: + if (mcs_rate&0x8000) /* MCS15 */ Signed-off-by: Fabio Aiuto --- drivers/staging/rt

[PATCH 13/19] staging: rtl8723bs: remove unnecessary parentheses in if condition

fix following post-commit hook checkpatch issue: CHECK: Unnecessary parentheses around pcmdpriv->cmd_queue.queue 85: FILE: drivers/staging/rtl8723bs/core/rtw_cmd.c:422: + if (list_empty(&(pcmdpriv->cmd_queue.queue))) Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8

[PATCH 15/19] staging: rtl8723bs: rewrite comparison to null

if ((prxattrib->bdecrypted == true) && (brpt_micerror == true)) -- CHECK: Using comparison to true is error prone 1051: FILE: drivers/staging/rtl8723bs/core/rtw_xmit.c:1174: + if (padapter->securitypriv.binstallBIPkey != true) -- CHECK: Using comparison to false is

[PATCH 16/19] staging: rtl8723bs: remove unnecessary parentheses

fix following post-commit checkpatch issue: CHECK: Unnecessary parentheses around 'prxattrib->bdecrypted' 125: FILE: drivers/staging/rtl8723bs/core/rtw_recv.c:365: + if ((prxattrib->bdecrypted) && (brpt_micerror)) Signed-off-by: Fabio Aiu

[PATCH 17/19] staging: rtl8723bs: fix comparison in if condition

fix following post-commit checkpatch issue: WARNING: Comparisons should place the constant on the right side of the test 1833: FILE: drivers/staging/rtl8723bs/os_dep/mlme_linux.c:151: + if (NULL == buff) Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/os_dep/mlme_linux.c

[PATCH 18/19] staging: rtl8723bs: split long lines

if (pairwise_cipher != cur_network->BcnInfo.pairwise_cipher || group_cipher != cur_network->BcnInfo.group_cipher) -- WARNING: line length of 113 exceeds 100 columns 1712: FILE: drivers/staging/rtl8723bs/os_dep/ioctl_linux.c:2651: Signed-off-by: Fabio Aiuto --- drivers/staging/

[PATCH 19/19] staging: rtl8723bs: remove unnecessary parentheses

dot11AuthAlgrthm == dot11AuthAlgrthm_8021X) && + !(padapter->securitypriv.binstallGrpkey)) Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c

Re: [PATCH 0/2] staging: rtl8723bs: replace private macro with print_hex_dump_debug

On Wed, Mar 31, 2021 at 11:34:05AM +0200, Fabio Aiuto wrote: > this patchset replaces RT_PRINT_DATA private macro for dump hex values > with the kernel helper used for this pourpose. > > Fabio Aiuto (2): > staging: rtl8723bs: use print_hex_dump_debug instead of private >

[PATCH v2 1/2] staging: rtl8723bs: use print_hex_dump_debug instead of private RT_PRINT_DATA

replace private macro RT_PRINT_DATA with in-kernel helper print_hex_dump_debug Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/hal/hal_com.c | 13 --- drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c | 22 ++- .../staging/rtl8723bs/hal/rtl8723b_hal_init.c

[PATCH v2 2/2] staging: rtl8723bs: remove unused macro RT_PRINT_DATA

remove unused macro declaration: RT_PRINT_DATA Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/include/rtw_debug.h | 20 --- 1 file changed, 20 deletions(-) diff --git a/drivers/staging/rtl8723bs/include/rtw_debug.h b/drivers/staging/rtl8723bs/include/rtw_debug.h

[PATCH v2 0/2] staging: rtl8723bs: replace private macro with print_hex_dump_debug

this patchset replaces RT_PRINT_DATA private macro for dump hex values with the kernel helper used for this pourpose. - Changes in v2: - removed the do-nothing macro declaration as well Fabio Aiuto (2): staging: rtl8723bs: use print_hex_dump_debug

Re: [PATCH 03/40] staging: rtl8723bs: replace RT_TRACE with public printk wrappers in core/rtw_eeprom.c

On Wed, Mar 31, 2021 at 01:14:18PM +0200, Greg KH wrote: > On Wed, Mar 31, 2021 at 12:55:51PM +0200, Fabio Aiuto wrote: > > On Wed, Mar 31, 2021 at 12:27:20PM +0200, Greg KH wrote: > > > On Wed, Mar 31, 2021 at 11:39:31AM +0200, Fabio Aiuto wrote: > > > > replace priv

[PATCH 00/49] staging: rtl8723bs: remove all RT_TRACE usages

This patchset removes all RT_TRACE usages and declaration. The whole private tracing system is not tied to a configuration symbol and the default behaviour is _trace nothing_. It's verbose and relies on a private log level tracing doomed to be removed. Fabio Aiuto (49): staging: rtl8

[PATCH 03/49] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_security.c

remove all RT_TRACE logs in core/rtw_security.c Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_security.c | 35 --- 1 file changed, 35 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_security.c b/drivers/staging/rtl8723bs/core/rtw_security.c

[PATCH 01/49] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_xmit.c

remove all RT_TRACE logs Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 63 +-- 1 file changed, 1 insertion(+), 62 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rtl8723bs/core/rtw_xmit.c index 2daf5c461a4d

[PATCH 05/49] staging: rtl8723bs: remove all RT_TRACE logs in core/rtw_eeprom.c

remove all RT_TRACE logs Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_eeprom.c | 15 ++- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_eeprom.c b/drivers/staging/rtl8723bs/core/rtw_eeprom.c index 3cbd65dee741

[PATCH 07/49] staging: rtl8723bs: make one single if statement out of two nested ones

make one single if statement out of two nested ones Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c

[PATCH 06/49] staging: rtl8723bs: remove all RT_TRACE logs in core/rtw_pwrctrl.c

remove all RT_TRACE logs Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 44 1 file changed, 44 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c index 8bf80e6f4a11

[PATCH 09/49] staging: rtl8723bs: remove empty if-else blocks and unused variable

*pmlmepriv = &padapter->mlmepriv; Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_cmd.c | 9 - 1 file changed, 9 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c index e143f89ea39e..e6d507ed60c5 10064

[PATCH 02/49] staging: rtl8723bs: remove empty else blocks

remove empty else blocks Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rtl8723bs/core/rtw_xmit.c index 05aec2ee5a0b..d8e4e7cff377 100644 --- a/drivers

[PATCH 08/49] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_cmd.c

remove all RT_TRACE logs Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_cmd.c | 32 ++-- 1 file changed, 2 insertions(+), 30 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c index 2aaf25b48f96

[PATCH 04/49] staging: rtl8723bs: remove empty if block in core/rtw_security.c

remove an empty if block Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_security.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_security.c b/drivers/staging/rtl8723bs/core/rtw_security.c index c91a1eef40b3..acef6aa0b393 100644 --- a

[PATCH 10/49] staging: rtl8723bs: remove commented RT_TRACE calls in core/rtw_mlme.c

remove commented RT_TRACE calls in core/rtw_mlme.c Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c index 29d4b7493784

[PATCH 11/49] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_mlme.c

remove all RT_TRACE logs Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 68 +-- 1 file changed, 3 insertions(+), 65 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c index

[PATCH 13/49] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_mlme_ext.c

remove all RT_TRACE logs Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 25 --- 1 file changed, 25 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c index 8aadcf72a7ba

[PATCH 12/49] staging: rtl8723bs: remove empty if-else block in core/rtw_mlme.c

remove emtpy if else block, the condition is just a value check Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c index

[PATCH 22/49] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_sta_mgt.c

remove all RT_TRACE logs Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_sta_mgt.c | 25 1 file changed, 25 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c b/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c index f96dd0b40e04

[PATCH 18/49] staging: rtl8723bs: remove commented RT_TRACE call in core/rtw_ioctl_set.c

remove commented RT_TRACE call in core/rtw_ioctl_set.c Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_ioctl_set.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c b/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c index

[PATCH 17/49] staging: rtl8723bs: remove empty if-block in core/rtw_recv.c

remove empty if-block Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_recv.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c index 5eb9914c48fc..fdba5cb74452 100644 --- a/drivers

[PATCH 23/49] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_ieee80211.c

remove all RT_TRACE logs Signed-off-by: Fabio Aiuto --- .../staging/rtl8723bs/core/rtw_ieee80211.c| 41 --- 1 file changed, 41 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c index e931afc3ba22

[PATCH 21/49] staging: rtl8723bs: remove all RT_TRACE logs in core/rtw_wlan_util.c

remove all RT_TRACE logs Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 16 1 file changed, 16 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c index 760b0ea4e9bd

[PATCH 24/49] staging: rtl8723bs: remove empty for cycles

remove empty for cycles and related unused counters Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c b/drivers/staging/rtl8723bs/core

[PATCH 15/49] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_recv.c

remove all RT_TRACE logs Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_recv.c | 112 +- 1 file changed, 3 insertions(+), 109 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c index

[PATCH 16/49] staging: rtl8723bs: remove empty for cycle in core/rtw_recv.c

remove empty for cycle Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_recv.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c index 9bd742e22ed3..5eb9914c48fc 100644 --- a/drivers

[PATCH 20/49] staging: rtl8723bs: remove empty if-block in core/rtw_ioctl_set.c

remove empty if-block Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_ioctl_set.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c b/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c index 44bead8cb6f4..080d548fe269 100644

[PATCH 14/49] staging: rtl8723bs: remove commented RT_TRACE calls in core/rtw_recv.c

remove commented RT_TRACE calls in core/rtw_recv.c Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_recv.c | 12 1 file changed, 12 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c index 608a59286505

[PATCH 19/49] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_ioctl_set.c

remove all RT_TRACE logs Signed-off-by: Fabio Aiuto --- .../staging/rtl8723bs/core/rtw_ioctl_set.c| 69 +-- 1 file changed, 2 insertions(+), 67 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c b/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c index

[PATCH 27/49] staging: rtl8723bs: remove empty #ifdef blocks in hal/rtl8723b_hal_init.c

remove empty #ifdef blocks Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c index 20b66bf942e4

[PATCH 29/49] staging: rtl8723bs: added driver prefix in log messages

added driver prefix in log messages in hal/rtl8723b_hal_init.c Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/staging/rtl8723bs

[PATCH 26/49] staging: rtl8723bs: remove RT_TRACE logs in hal/rtl8723b_hal_init.c

remove all RT_TRACE logs Signed-off-by: Fabio Aiuto --- .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 86 --- 1 file changed, 86 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c index 0273118e70af

[PATCH 30/49] staging: rtl8723bs: remove RT_TRACE logs in hal/sdio_ops.c

remove all RT_TRACE logs Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/hal/sdio_ops.c | 31 1 file changed, 31 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/sdio_ops.c b/drivers/staging/rtl8723bs/hal/sdio_ops.c index a24a39e70454..493e752d

[PATCH 28/49] staging: rtl8723bs: remove empty if blocks in hal/rtl8723bs_hal_init.c

remove empty if blocks after RT_TRACE deletion Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c index

[PATCH 31/49] staging: rtl8723bs: remove commented code block in hal/hal_com_phycfg.c

remove commented 5G code block in hal/hal_com_phycfg.c Signed-off-by: Fabio Aiuto --- .../staging/rtl8723bs/hal/hal_com_phycfg.c| 20 --- 1 file changed, 20 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c b/drivers/staging/rtl8723bs/hal

[PATCH 32/49] staging: rtl8723bs: remove RT_TRACE logs in hal/rtl8723b_phycfg.c

remove all RT_TRACE logs Signed-off-by: Fabio Aiuto --- .../staging/rtl8723bs/hal/rtl8723b_phycfg.c | 32 ++- 1 file changed, 3 insertions(+), 29 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c b/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c index

[PATCH 25/49] staging: rtl8723bs: remove RT_TRACE logs in hal/HalPwrSeqCmd.c

remove all RT_TRACE logs Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/hal/HalPwrSeqCmd.c | 47 1 file changed, 47 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/HalPwrSeqCmd.c b/drivers/staging/rtl8723bs/hal/HalPwrSeqCmd.c index 932b31fda6ad

[PATCH 36/49] staging: rtl8723bs: remove RT_TRACE logs in hal/sdio_halinit.c

remove all RT_TRACE logs Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/hal/sdio_halinit.c | 30 1 file changed, 30 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging/rtl8723bs/hal/sdio_halinit.c index b1c4bbf29790

[PATCH 35/49] staging: rtl8723bs: remove RT_TRACE logs in hal/rtl8723bs_xmit.c

remove all RT_TRACE logs Signed-off-by: Fabio Aiuto --- .../staging/rtl8723bs/hal/rtl8723bs_xmit.c| 32 --- 1 file changed, 32 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c index 597cf3a88c51

[PATCH 39/49] staging: rtl8723bs: remove commented RT_TRACE calls in hal/rtl8723b_rf6052.c

remove commented RT_TRACE calls in hal/rtl8723b_rf6052.c Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/hal/rtl8723b_rf6052.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_rf6052.c b/drivers/staging/rtl8723bs/hal/rtl8723b_rf6052.c index

[PATCH 40/49] staging: rtl8723bs: remove commented RT_TRACE calls in os_dep/ioctl_linux.c

remove commented RT_TRACE calls in os_dep/ioctl_linux.c Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c index

[PATCH 38/49] staging: rtl8723bs: remove commented RT_TRACE calls in hal/HalPhyRf_8723B.c

remove commented RT_TRACE calls in hal/HalPhyRf_8723B.c Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c b/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c index

[PATCH 42/49] staging: rtl8723bs: remove RT_TRACE logs in os_dep/mlme_linux.c

remove all macro RT_TRACE logs Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/os_dep/mlme_linux.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/mlme_linux.c b/drivers/staging/rtl8723bs/os_dep/mlme_linux.c index ba4d3789a41e..b46c086233bb

[PATCH 43/49] staging: rtl8723bs: remove RT_TRACE logs in os_dep/ioctl_cfg80211.c

remove all RT_TRACE logs Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c index 4f6398f86b75

[PATCH 44/49] staging: rtl8723bs: remove RT_TRACE logs in os_dep/recv_linux.c

remove RT_TRACE logs Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/os_dep/recv_linux.c | 9 - 1 file changed, 9 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/recv_linux.c b/drivers/staging/rtl8723bs/os_dep/recv_linux.c index fbdbcd04d44a..a2a28803c8d9 100644

[PATCH 33/49] staging: rtl8723bs: remove empty else-blocks in hal/rtl8723b_phycfg.c

remove empty else-blocks Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c b/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c index

[PATCH 34/49] staging: rtl8723bs: remove RT_TRACE logs in hal/hal_intf.c

remove all RT_TRACE LOGS Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/hal/hal_intf.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/hal_intf.c b/drivers/staging/rtl8723bs/hal/hal_intf.c index aa4356327636..7fbac4c8f2f8 100644 --- a/drivers

[PATCH 46/49] staging: rtl8723bs: remove RT_TRACE logs in os_dep/xmit_linux.c

remove RT_TRACE logs Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/os_dep/xmit_linux.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/xmit_linux.c b/drivers/staging/rtl8723bs/os_dep/xmit_linux.c index 216b2f62eefd..1dc0787a80da 100644 --- a

[PATCH 47/49] staging: rtl8723bs: remove RT_TRACE logs in os_dep/osdep_service.c

remove all RT_TRACE logs Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/os_dep/osdep_service.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/os_dep/osdep_service.c b/drivers/staging/rtl8723bs/os_dep/osdep_service.c index 843003b91ea2..7b2aad346d20

[PATCH 49/49] staging: rtl8723bs: remove obsolete macro

remove obsolete macro RT_TRACE Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/include/rtw_debug.h | 18 -- 1 file changed, 18 deletions(-) diff --git a/drivers/staging/rtl8723bs/include/rtw_debug.h b/drivers/staging/rtl8723bs/include/rtw_debug.h index d3c77798a5eb

[PATCH 37/49] staging: rtl8723bs: remove RT_TRACE logs in hal/rtl8723bs_recv.c

remove all RT_TRACE logs Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c b/drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c index 17a3e7bf66ef..d27d56920a11 100644

[PATCH 45/49] staging: rtl8723bs: remove RT_TRACE logs in os_dep/sdio_intf.c

remove RT_TRACE logs Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 14 -- 1 file changed, 14 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c index b6be1423ef75..fecb43b870d7

[PATCH 41/49] staging: rtl8723bs: remove RT_TRACE logs in os_dep/ioctl_linux.c

remove all RT_TRACE logs Signed-off-by: Fabio Aiuto --- .../staging/rtl8723bs/os_dep/ioctl_linux.c| 51 --- 1 file changed, 51 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c index aee4932162a9

[PATCH 48/49] staging: rtl8723bs: remove RT_TRACE logs in os_dep/os_intfs.c

remove all RT_TRACE logs Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/os_dep/os_intfs.c | 45 - 1 file changed, 45 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/os_dep/os_intfs.c index 405aa95af579

Re: [PATCH 08/49] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_cmd.c

On Thu, Apr 01, 2021 at 12:50:18PM +0300, Dan Carpenter wrote: > On Thu, Apr 01, 2021 at 11:20:38AM +0200, Fabio Aiuto wrote: > > @@ -677,9 +663,8 @@ u8 rtw_createbss_cmd(struct adapter *padapter) > > u8 res = _SUCCESS; > > > > if (pmlmepriv-

Re: [PATCH 49/49] staging: rtl8723bs: remove obsolete macro

On Thu, Apr 01, 2021 at 02:57:36AM -0700, Joe Perches wrote: > On Thu, 2021-04-01 at 11:21 +0200, Fabio Aiuto wrote: > > remove obsolete macro RT_TRACE > [] > > diff --git a/drivers/staging/rtl8723bs/include/rtw_debug.h > > b/drivers/staging/rtl8723bs/include/rtw_

Re: [PATCH 08/49] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_cmd.c

On Thu, Apr 01, 2021 at 05:32:36PM +0300, Dan Carpenter wrote: > On Thu, Apr 01, 2021 at 03:55:37PM +0200, Fabio Aiuto wrote: > > > > Hi Dan, > > > > I have the following: > > > > if (rtw_createbss_cmd(adapter) != _SUCCESS) > > -

Re: [PATCH 08/49] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_cmd.c

On Thu, Apr 01, 2021 at 12:50:18PM +0300, Dan Carpenter wrote: > On Thu, Apr 01, 2021 at 11:20:38AM +0200, Fabio Aiuto wrote: > > @@ -677,9 +663,8 @@ u8 rtw_createbss_cmd(struct adapter *padapter) > > u8 res = _SUCCESS; > > > > if (pmlmepriv-

Re: [PATCH 08/49] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_cmd.c

On Thu, Apr 01, 2021 at 05:32:36PM +0300, Dan Carpenter wrote: > On Thu, Apr 01, 2021 at 03:55:37PM +0200, Fabio Aiuto wrote: > > > > Hi Dan, > > > > I have the following: > > > > if (rtw_createbss_cmd(adapter) != _SUCCESS) > > -

Re: [PATCH 08/49] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_cmd.c

On Fri, Apr 02, 2021 at 08:14:20AM +, Dan Carpenter wrote: > On Thu, Apr 01, 2021 at 11:51:15PM +0200, Fabio Aiuto wrote: > > On Thu, Apr 01, 2021 at 05:32:36PM +0300, Dan Carpenter wrote: > > > On Thu, Apr 01, 2021 at 03:55:37PM +0200, Fabio Aiuto wrote: >

[PATCH 00/16] staging: rtl8723bs: remove RT_TRACE logs in core/*

acing doomed to be removed. Fabio Aiuto (16): staging: rtl8723bs: remove RT_TRACE logs in core/rtw_xmit.c staging: rtl8723bs: remove RT_TRACE logs in core/rtw_security.c staging: rtl8723bs: remove all RT_TRACE logs in core/rtw_eeprom.c staging: rtl8723bs: remove all RT_TRACE logs in

[PATCH 02/16] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_security.c

remove all RT_TRACE logs in core/rtw_security.c Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_security.c | 41 +-- 1 file changed, 2 insertions(+), 39 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_security.c b/drivers/staging/rtl8723bs/core

[PATCH 03/16] staging: rtl8723bs: remove all RT_TRACE logs in core/rtw_eeprom.c

remove all RT_TRACE logs fix patch-related checkpatch issues Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_eeprom.c | 56 - 1 file changed, 22 insertions(+), 34 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_eeprom.c b/drivers/staging

[PATCH 01/16] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_xmit.c

remove all RT_TRACE logs fix patch-related checkpatch warning Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 82 ++- 1 file changed, 7 insertions(+), 75 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging

[PATCH 04/16] staging: rtl8723bs: remove all RT_TRACE logs in core/rtw_pwrctrl.c

remove all RT_TRACE logs Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 60 ++-- 1 file changed, 6 insertions(+), 54 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c index

[PATCH 07/16] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_mlme.c

remove all RT_TRACE logs Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 105 -- 1 file changed, 15 insertions(+), 90 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c index

[PATCH 05/16] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_cmd.c

remove all RT_TRACE logs removed a variable, left unused after RT_TRACE removal fix patch-related checkpatch issues Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_cmd.c | 53 +++- 1 file changed, 6 insertions(+), 47 deletions(-) diff --git a/drivers

[PATCH 10/16] staging: rtl8723bs: remove commented RT_TRACE calls in core/rtw_recv.c

remove commented RT_TRACE calls in core/rtw_recv.c Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_recv.c | 12 1 file changed, 12 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c index 608a59286505

[PATCH 08/16] staging: rtl8723bs: tidy up some error handling

the RT_TRACE() output is not useful so we want to delete it. In this case there is no cleanup for rtw_cleanbss_cmd() required or even possible. I've deleted the RT_TRACE() output and added a goto unlock to show that we can't continue if rtw_createbss_cmd() fails. Signed-off-by: F

[PATCH 09/16] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_mlme_ext.c

remove all RT_TRACE logs Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 39 +++ 1 file changed, 5 insertions(+), 34 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c index

[PATCH 06/16] staging: rtl8723bs: remove commented RT_TRACE calls in core/rtw_mlme.c

remove commented RT_TRACE calls in core/rtw_mlme.c Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c index 29d4b7493784

[PATCH 12/16] staging: rtl8723bs: remove commented RT_TRACE call in core/rtw_ioctl_set.c

remove commented RT_TRACE call in core/rtw_ioctl_set.c Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_ioctl_set.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c b/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c index

[PATCH 13/16] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_ioctl_set.c

remove all RT_TRACE logs fix patch-related checkpatch issues Signed-off-by: Fabio Aiuto --- .../staging/rtl8723bs/core/rtw_ioctl_set.c| 76 +-- 1 file changed, 4 insertions(+), 72 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c b/drivers/staging

[PATCH 11/16] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_recv.c

remove all RT_TRACE logs fix patch-related checkpatch issues Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_recv.c | 135 ++ 1 file changed, 7 insertions(+), 128 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging

[PATCH 15/16] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_sta_mgt.c

remove all RT_TRACE logs Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_sta_mgt.c | 25 1 file changed, 25 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c b/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c index f96dd0b40e04

[PATCH 14/16] staging: rtl8723bs: remove all RT_TRACE logs in core/rtw_wlan_util.c

remove all RT_TRACE logs fix patch-related checkpatch issues Signed-off-by: Fabio Aiuto --- .../staging/rtl8723bs/core/rtw_wlan_util.c| 26 +-- 1 file changed, 6 insertions(+), 20 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c b/drivers/staging

[PATCH 16/16] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_ieee80211.c

remove all RT_TRACE logs fix patch-related checkpatch issues Signed-off-by: Fabio Aiuto --- .../staging/rtl8723bs/core/rtw_ieee80211.c| 90 --- 1 file changed, 15 insertions(+), 75 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c b/drivers/staging

Re: [PATCH 01/16] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_xmit.c

On Fri, Apr 02, 2021 at 02:56:26PM +0300, Dan Carpenter wrote: > On Fri, Apr 02, 2021 at 12:01:21PM +0200, Fabio Aiuto wrote: > > @@ -568,20 +561,11 @@ static s32 update_attrib_sec_info(struct adapter > > *padapter, struct pkt_attrib *p > > if (pattrib->encrypt >

Re: [PATCH 14/16] staging: rtl8723bs: remove all RT_TRACE logs in core/rtw_wlan_util.c

On Fri, Apr 02, 2021 at 03:37:57AM -0700, Joe Perches wrote: > On Fri, 2021-04-02 at 12:01 +0200, Fabio Aiuto wrote: > > remove all RT_TRACE logs > > > > fix patch-related checkpatch issues > > > > Signed-off-by: Fabio Aiuto > > --- > >  .../s

Re: [PATCH 01/16] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_xmit.c

On Fri, Apr 02, 2021 at 02:47:10PM +0200, Greg KH wrote: > On Fri, Apr 02, 2021 at 02:40:46PM +0200, Fabio Aiuto wrote: > > On Fri, Apr 02, 2021 at 02:56:26PM +0300, Dan Carpenter wrote: > > > On Fri, Apr 02, 2021 at 12:01:21PM +0200, Fabio Aiuto wrote: > > > > @@

Re: [PATCH v2 1/4] fbtft: Replace custom ->reset() with generic one

Hi, 'staging:' in mail subject is missing... On Fri, Apr 16, 2021 at 05:20:41PM +0300, Andy Shevchenko wrote: > The custom ->reset() repeats the generic one, replace it. > > Note, in newer kernels the context of the function is a sleeping one, > it's fine to switch over to the sleeping functions

Re: [PATCH] media: atomisp: pci: remove unneeded variable 'err'

On Sun, Apr 18, 2021 at 08:13:23PM +0530, Saurav Girepunje wrote: > Fix the following coccicheck warning: > > drivers/staging/media/atomisp/pci/sh_css_mipi.c:39:5-8: > Unneeded variable: "err". Return "0" on line 44 > > Signed-off-by: Saurav Girepunje > --- > drivers/staging/media/atomisp/pci/s

Re: [PATCH 6/6] staging: media: atomisp: use printk with KERN facility level

Hi Deepak, On Tue, Apr 20, 2021 at 12:46:40AM +0530, Deepak R Varma wrote: > printk() without KERN_ facility is flagged by checkpatch as a > warning. It is better to use pr_info() which comes with an > inbuilt KERN_INFO level. > > Signed-off-by: Deepak R Varma > --- > drivers/staging/media/atom

Re: [PATCH 5/6] staging: media: atomisp: fix CamelCase variable naming

Hi, On Tue, Apr 20, 2021 at 12:45:57AM +0530, Deepak R Varma wrote: > Mixed case variable names are discouraged and they result in checkpatch > script "Avoid CamelCase" warnings. Replace such CamelCase variable names > by lower case strings according to the coding style guidelines. > > Signed-off

<    1   2   3   4   5   6   >