Re: [PATCH 07/19] drivers: rtl8723bs: rewrite comparison to null

On Wed, Apr 07, 2021 at 05:14:00PM +0200, Greg KH wrote: > On Wed, Apr 07, 2021 at 03:49:31PM +0200, Fabio Aiuto wrote: > > fix following post-commit hook checkpatch warnings: > > > > CHECK: Comparison to NULL could be written "!psta" > > 97: FILE: drivers

Re: [PATCH 07/19] drivers: rtl8723bs: rewrite comparison to null

On Wed, Apr 07, 2021 at 05:30:34PM +0200, Greg KH wrote: > On Wed, Apr 07, 2021 at 05:25:34PM +0200, Fabio Aiuto wrote: > > On Wed, Apr 07, 2021 at 05:14:00PM +0200, Greg KH wrote: > > > On Wed, Apr 07, 2021 at 03:49:31PM +0200, Fabio Aiuto wrote: > > > > fix followi

Re: [PATCH 00/19] staging: rtl8723bs: remove DBG_871X trace macro

On Wed, Apr 07, 2021 at 05:14:28PM +0200, Greg KH wrote: > On Wed, Apr 07, 2021 at 03:49:24PM +0200, Fabio Aiuto wrote: > > This patchset removes all DBG_871X usages and definitions. > > > > The whole private tracing system is not tied to a configuration > > symbol a

[PATCH] staging: rtl8723bs: remove unused variables

remove declared and assigned unused variables Reported-by: kernel test robot Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_cmd.c | 3 --- .../staging/rtl8723bs/include/rtw_security.h | 18 - .../staging/rtl8723bs/os_dep/ioctl_linux.c| 26

Re: [PATCH] staging: rtl8723bs: remove unused variables

On Thu, Apr 08, 2021 at 11:46:15AM +0200, Greg KH wrote: > On Thu, Apr 08, 2021 at 11:27:02AM +0200, Fabio Aiuto wrote: > > remove declared and assigned unused variables > > You need to be a lot more specific here. Shall I describe that some of these became unused after D

Re: CHECKPATCH: missing a warning soon after include files decl -c

On Sat, Mar 20, 2021 at 04:28:51AM -0700, Joe Perches wrote: > > Actually, these would seem to be better as one or multiple functions with > local statics or even as static inlines functions in the .h file > > $ git grep -w RTW_WPA_OUI drivers/staging/rtl8723bs/core > drivers/staging/rtl8723bs/co

[PATCH 1/3] staging: rtl8723bs: remove assignment in condition in core/rtw_ieee80211.c

fix the following checkpatch warning: ERROR: do not use assignment in if condition 1118: FILE: drivers/staging/rtl8723bs/core/rtw_ieee80211.c:1118: + if ((addr = of_get_property(np, "local-mac-address", &len)) && Signed-off-by: Fabio Aiuto --- drivers/

[PATCH 0/3] staging: rtl8723bs: remove assignment in conditions

remove all assignment in conditions in rtl8723bs, warned by checkpatch.pl Fabio Aiuto (3): staging: rtl8723bs: remove assignment in condition in core/rtw_ieee80211.c staging: rtl8723bs: remove assignment in condition in os_dep/ioctl_cfg80211.c staging: rtl8723bs: remove assignment

[PATCH 3/3] staging: rtl8723bs: remove assignment in condition in os_dep/ioctl_linux.c

/rtl8723bs/os_dep/ioctl_linux.c:4239: + if (!(ext = vmalloc(len))) -- ERROR: do not use assignment in if condition 4253: FILE: drivers/staging/rtl8723bs/os_dep/ioctl_linux.c:4253: + if (!(ext_dbg = vmalloc(len))) { Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/os_dep/ioctl_linux.c

[PATCH 2/3] staging: rtl8723bs: remove assignment in condition in os_dep/ioctl_cfg80211.c

NULL) { -- ERROR: do not use assignment in if condition 3335: FILE: drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:3335: + if (!(ndev = wdev_to_ndev(wdev))) Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 13 - 1 file changed, 8 insertions(+

[PATCH] staging: rtl8723bs: fix indentation broken by previous patch

fix indentation broken by patch removing conditional code blocks checked by unused CONFIG_INTERRUPT_BASED_TXBCN family defines https://lore.kernel.org/r/9157000821fd6febf25566b8c712fad1995c7c78.1615907632.git.fabioaiut...@gmail.com Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core

[PATCH v2] staging: rtl8723bs: remove unnecessary logging in os_dep/ioctl_cfg80211.c

FILE: drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:2230: + DBG_8192C("%s\n", __func__); Changes in v2: removed empty #ifdef block Signed-off-by: Fabio Aiuto --- .../staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 17 - 1 file changed, 17 deletions(-) dif

CHECKPATCH: missing a warning soon after include files decl -c

Hi, here's an issue in checkpatch.pl $ perl script/checkpatch.pl -f drivers/staging/rtl8723bs/core/rtw_ap.c I get three warning related to an extern declaration WARNING: externs should be avoided in .c files #14: FILE: drivers/staging/rtl8723bs/core/rtw_ap.c:14: +extern unsigned char WMM_OUI[];

Re: CHECKPATCH: missing a warning soon after include files decl -c

On Sat, Mar 20, 2021 at 04:28:51AM -0700, Joe Perches wrote: > On Sat, 2021-03-20 at 11:59 +0100, Greg KH wrote: > > On Sat, Mar 20, 2021 at 11:54:24AM +0100, Fabio Aiuto wrote: > > > Hi, > > > > > > here's an issue in checkpatch.pl > > > &g

Re: CHECKPATCH: missing a warning soon after include files decl -c

On Sat, Mar 20, 2021 at 11:59:44AM +0100, Greg KH wrote: > On Sat, Mar 20, 2021 at 11:54:24AM +0100, Fabio Aiuto wrote: > > Hi, > > > > here's an issue in checkpatch.pl > > > > $ perl script/checkpatch.pl -f drivers/staging/rtl8723bs/core/rtw_ap.c >

[PATCH v2 0/9] fix extern declarations checkpatch issues

Fix extern declaration issues warned by checkpatch. Changes in v2: - removal of prototypes when function can be static - move of static function defs inside file to let the code compile - split last patch in two patches (one patch for blank line removal) Fabio Aiuto (9

[PATCH v2 1/9] staging: rtl8723bs: removed function prototypes in core/rtw_efuse.c

fix the following checkpatch issues: WARNING: externs should be avoided in .c files 35: FILE: drivers/staging/rtl8723bs/core/rtw_efuse.c:35: +bool removed two function prototypes in core/rtw_efuse.c and made definition static Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core

[PATCH v2 3/9] staging: rtl8723bs: removed function prototypes and made statics in core/rtw_recv.c

static function definitions before their usage to make code compile Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_recv.c | 441 ++ 1 file changed, 207 insertions(+), 234 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging

[PATCH v2 2/9] staging: rtl8723bs: moved function prototype out of core/rtw_ioctl_set.c and core/rtw_mlme.c

: +extern u8 rtw_do_join(struct adapter *padapter); moved function prototype in include/rtw_ioctl_set.h Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_ioctl_set.c| 1 - drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 -- drivers/staging/rtl8723bs/include/rtw_ioctl_set.h | 2

[PATCH v2 4/9] staging: rtl8723bs: delete extern declarations in core/rtw_wlan_util.c

: +extern unsigned char WPA_TKIP_CIPHER[4]; Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c index bfd55a0356f5

[PATCH v2 7/9] staging: rtl8723bs: remove undefined function prototype in of os_dep/sdio_intf.c

fix the following checkpatch issue: WARNING: externs should be avoided in .c files 486: FILE: drivers/staging/rtl8723bs/os_dep/sdio_intf.c:486: +extern int pm_netdev_close(struct net_device *pnetdev, u8 bnormal); Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 1

[PATCH v2 6/9] staging: rtl8723bs: move function prototypes out of os_dep/int_fs.c

:197: +int netdev_open(struct net_device *pnetdev); moved function prototype in include/osdep_intf.h removed function prototype and made a static removed unnecessary extern declaration in os_dep/ioctl_cfg80211.c Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/include/osdep_intf.h| 2

[PATCH v2 8/9] staging: rtl8723bs: remove unnecessary extern in os_dep/sdio_intf.c

remove unnecessary extern. The function is defined static in os_dep/os_intfs.c and used only once in the same file Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b

[PATCH v2 9/9] staging: rtl8723bs: remove blank line os_dep/os_intfs.c

remove blank line Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/os_dep/os_intfs.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/os_dep/os_intfs.c index c6c5cc0a9e08..405aa95af579 100644 --- a/drivers

[PATCH v2 5/9] staging: rtl8723bs: remove function prototypes in hal/odm.c

*pDM_Odm); removed function prototypes and made staics where needed in hal/odm.c moved function definition in file to let the compiler work Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/hal/odm.c | 1717 +-- 1 file changed, 824 insertions(+), 893 deletions

Re: [PATCH 02/11] staging: rtl8723bs: moved function prototypes out of core/rtw_efuse.c

On Mon, Mar 22, 2021 at 10:29:27PM +0300, Dan Carpenter wrote: > On Mon, Mar 22, 2021 at 03:31:40PM +0100, Fabio Aiuto wrote: > > fix the following checkpatch issues: > > > > WARNING: externs should be avoided in .c files > > 35: FILE: drivers/staging/rtl8723bs/cor

[PATCH] staging: rtl8723bs: removed unused code block

Removed conditional code block checked by unused CONFIG_TX_BCAST2UNI This patch does the cleaning required in TODO file: find and remove code blocks guarded by never set CONFIG_FOO defines Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/os_dep/xmit_linux.c | 3 --- 1 file changed, 3

[PATCH 0/2] staging: rtl8723bs: replace private macro with print_hex_dump_debug

this patchset replaces RT_PRINT_DATA private macro for dump hex values with the kernel helper used for this pourpose. Fabio Aiuto (2): staging: rtl8723bs: use print_hex_dump_debug instead of private RT_PRINT_DATA staging: rtl8723bs: remove unused macro RT_PRINT_DATA drivers/staging

[PATCH 2/2] staging: rtl8723bs: remove unused macro RT_PRINT_DATA

remove unused macro declaration: RT_PRINT_DATA Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/include/rtw_debug.h | 19 --- 1 file changed, 19 deletions(-) diff --git a/drivers/staging/rtl8723bs/include/rtw_debug.h b/drivers/staging/rtl8723bs/include/rtw_debug.h

[PATCH 1/2] staging: rtl8723bs: use print_hex_dump_debug instead of private RT_PRINT_DATA

replace private macro RT_PRINT_DATA with in-kernel helper print_hex_dump_debug Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/hal/hal_com.c | 13 --- drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c | 22 ++- .../staging/rtl8723bs/hal/rtl8723b_hal_init.c

[PATCH 01/40] staging: rtl8723bs: replace RT_TRACE with public printk wrappers in core/rtw_xmit.c

replace private macro RT_TRACE for tracing with in-kernel pr_* printk wrappers Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 168 +++--- 1 file changed, 113 insertions(+), 55 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b

[PATCH 04/40] staging: rtl8723bs: replace RT_TRACE with public printk wrappers in core/rtw_pwrctrl.c

replace private macro RT_TRACE for tracing with in-kernel pr_* printk wrappers Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 62 +--- 1 file changed, 27 insertions(+), 35 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c b

[PATCH 02/40] staging: rtl8723bs: replace RT_TRACE with public printk wrappers in core/rtw_security.c

replace private macro RT_TRACE for tracing with in-kernel pr_* printk wrappers Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_security.c | 38 --- 1 file changed, 16 insertions(+), 22 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_security.c b

[PATCH 00/40] staging: rtl8723bs: replace RT_TRACE private macro

this patchset replace all RT_TRACE usages with public log functions used for this pourpose Fabio Aiuto (40): staging: rtl8723bs: replace RT_TRACE with public printk wrappers in core/rtw_xmit.c staging: rtl8723bs: replace RT_TRACE with public printk wrappers in core/rtw_security.c

[PATCH 03/40] staging: rtl8723bs: replace RT_TRACE with public printk wrappers in core/rtw_eeprom.c

replace private macro RT_TRACE for tracing with in-kernel pr_* printk wrappers Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_eeprom.c | 26 ++--- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_eeprom.c b

[PATCH 08/40] staging: rtl8723bs: replace RT_TRACE with public printk wrappers in core/rtw_mlme_ext.c

replace private macro RT_TRACE for tracing with in-kernel pr_* printk wrappers Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 39 ++- 1 file changed, 20 insertions(+), 19 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b

[PATCH 06/40] staging: rtl8723bs: remove commented RT_TRACE calls in core/rtw_mlme.c

remove commented RT_TRACE calls in core/rtw_mlme.c Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c index 29d4b7493784

[PATCH 12/40] staging: rtl8723bs: replace RT_TRACE with public printk wrappers in core/rtw_ioctl_set.c

replace private macro RT_TRACE for tracing with in-kernel pr_* printk wrappers Signed-off-by: Fabio Aiuto --- .../staging/rtl8723bs/core/rtw_ioctl_set.c| 126 ++ 1 file changed, 74 insertions(+), 52 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c b

[PATCH 09/40] staging: rtl8723bs: remove commented RT_TRACE calls in core/rtw_recv.c

remove commented RT_TRACE calls in core/rtw_recv.c Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_recv.c | 12 1 file changed, 12 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c index 608a59286505

[PATCH 16/40] staging: rtl8723bs: replace RT_TRACE with public printk wrappers in hal/HalPwrSeqCmd.c

replace private macro RT_TRACE for tracing with in-kernel pr_* printk wrappers Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/hal/HalPwrSeqCmd.c | 61 +--- 1 file changed, 16 insertions(+), 45 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/HalPwrSeqCmd.c b

[PATCH 14/40] staging: rtl8723bs: replace RT_TRACE with public printk wrappers in core/rtw_sta_mgt.c

replace private macro RT_TRACE for tracing with in-kernel pr_* printk wrappers Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_sta_mgt.c | 45 ++-- 1 file changed, 22 insertions(+), 23 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c b

[PATCH 13/40] staging: rtl8723bs: replace RT_TRACE with public printk wrappers in core/rtw_wlan_util.c

replace private macro RT_TRACE for tracing with in-kernel pr_* printk wrappers Signed-off-by: Fabio Aiuto --- .../staging/rtl8723bs/core/rtw_wlan_util.c| 28 +-- 1 file changed, 13 insertions(+), 15 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c b

[PATCH 07/40] staging: rtl8723bs: replace RT_TRACE with public printk wrappers in core/rtw_mlme.c

replace private macro RT_TRACE for tracing with in-kernel pr_* printk wrappers Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 122 +- 1 file changed, 72 insertions(+), 50 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b

[PATCH 10/40] staging: rtl8723bs: replace RT_TRACE with public printk wrappers in core/rtw_recv.c

replace private macro RT_TRACE for tracing with in-kernel pr_* printk wrappers Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_recv.c | 240 ++ 1 file changed, 157 insertions(+), 83 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b

[PATCH 05/40] staging: rtl8723bs: replace RT_TRACE with public printk wrappers in core/rtw_cmd.c

replace private macro RT_TRACE for tracing with in-kernel pr_* printk wrappers Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_cmd.c | 55 +--- 1 file changed, 31 insertions(+), 24 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b

[PATCH 11/40] staging: rtl8723bs: remove commented RT_TRACE call in core/rtw_ioctl_set.c

remove commented RT_TRACE call in core/rtw_ioctl_set.c Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_ioctl_set.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c b/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c index

[PATCH 15/40] staging: rtl8723bs: replace RT_TRACE with public printk wrappers in core/rtw_ieee80211.c

replace private macro RT_TRACE for tracing with in-kernel pr_* printk wrappers Signed-off-by: Fabio Aiuto --- .../staging/rtl8723bs/core/rtw_ieee80211.c| 116 +++--- 1 file changed, 74 insertions(+), 42 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c b

[PATCH 17/40] staging: rtl8723bs: fix constant name in hal/rtl8723b_hal_init.c

fix constant name in log message call Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c index

[PATCH 18/40] staging: rtl8723bs: added driver prefix in log messages

added driver prefix in log messages in hal/rtl8723b_hal_init.c Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/staging/rtl8723bs

[PATCH 20/40] staging: rtl8723bs: replace RT_TRACE with public printk wrappers in hal/rtl8723b_hal_init.c

replace private macro RT_TRACE for tracing with in-kernel pr_* printk wrappers Signed-off-by: Fabio Aiuto --- .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 143 +- 1 file changed, 68 insertions(+), 75 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c

[PATCH 19/40] staging: rtl8723bs: remove commented RT_TRACE call in hal/rtl8723b_hal_init.c

remove commented RT_TRACE call in hal/rtl8723b_hal_init.c Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/staging/rtl8723bs/hal

[PATCH 22/40] staging: rtl8723bs: remove commented code block in hal/hal_com_phycfg.c

remove commented 5G code block in hal/hal_com_phycfg.c Signed-off-by: Fabio Aiuto --- .../staging/rtl8723bs/hal/hal_com_phycfg.c| 20 --- 1 file changed, 20 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c b/drivers/staging/rtl8723bs/hal

[PATCH 23/40] staging: rtl8723bs: replace RT_TRACE with public printk wrappers in hal/rtl8723b_phycfg.c

replace private macro RT_TRACE for tracing with in-kernel pr_* printk wrappers Signed-off-by: Fabio Aiuto --- .../staging/rtl8723bs/hal/rtl8723b_phycfg.c | 48 +-- 1 file changed, 22 insertions(+), 26 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c

[PATCH 27/40] staging: rtl8723bs: replace RT_TRACE with public printk wrappers in hal/rtl8723bs_recv.c

replace private macro RT_TRACE for tracing with in-kernel pr_* printk wrappers Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c b/drivers/staging

[PATCH 26/40] staging: rtl8723bs: replace RT_TRACE with public printk wrappers in hal/sdio_halinit.c

replace private macro RT_TRACE for tracing with in-kernel pr_* printk wrappers Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/hal/sdio_halinit.c | 49 ++-- 1 file changed, 24 insertions(+), 25 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b

[PATCH 21/40] staging: rtl8723bs: replace RT_TRACE with public printk wrappers in hal/sdio_ops.c

replace private macro RT_TRACE for tracing with in-kernel pr_* printk wrappers Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/hal/sdio_ops.c | 42 1 file changed, 13 insertions(+), 29 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/sdio_ops.c b

[PATCH 25/40] staging: rtl8723bs: replace RT_TRACE with public printk wrappers in hal/rtl8723bs_xmit.c

replace private macro RT_TRACE for tracing with in-kernel pr_* printk wrappers Signed-off-by: Fabio Aiuto --- .../staging/rtl8723bs/hal/rtl8723bs_xmit.c| 42 ++- 1 file changed, 13 insertions(+), 29 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c b

[PATCH 29/40] staging: rtl8723bs: remove commented RT_TRACE calls in hal/rtl8723b_rf6052.c

remove commented RT_TRACE calls in hal/rtl8723b_rf6052.c Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/hal/rtl8723b_rf6052.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_rf6052.c b/drivers/staging/rtl8723bs/hal/rtl8723b_rf6052.c index

[PATCH 24/40] staging: rtl8723bs: replace RT_TRACE with public printk wrappers in hal/hal_intf.c

replace private macro RT_TRACE for tracing with in-kernel pr_* printk wrappers Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/hal/hal_intf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/hal/hal_intf.c b/drivers/staging/rtl8723bs/hal

[PATCH 30/40] staging: rtl8723bs: remove commented RT_TRACE calls in os_dep/ioctl_linux.c

remove commented RT_TRACE calls in os_dep/ioctl_linux.c Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c index

[PATCH 31/40] staging: rtl8723bs: replace RT_TRACE with public printk wrappers in os_dep/ioctl_linux.c

replace private macro RT_TRACE for tracing with in-kernel pr_* printk wrappers Signed-off-by: Fabio Aiuto --- .../staging/rtl8723bs/os_dep/ioctl_linux.c| 81 ++- 1 file changed, 44 insertions(+), 37 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c b

[PATCH 32/40] staging: rtl8723bs: replace RT_TRACE with public printk wrappers in os_dep/mlme_linux.c

replace private macro RT_TRACE for tracing with in-kernel pr_* printk wrappers Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/os_dep/mlme_linux.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/mlme_linux.c b/drivers/staging

[PATCH 35/40] staging: rtl8723bs: replace RT_TRACE with public printk wrappers in os_dep/os_intfs.c

replace private macro RT_TRACE for tracing with in-kernel pr_* printk wrappers Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/os_dep/os_intfs.c | 65 ++--- 1 file changed, 32 insertions(+), 33 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b

[PATCH 33/40] staging: rtl8723bs: fix string format in os_dep/ioctl_cfg80211.c

fix string format in log message in os_dep/ioctl_cfg80211.c Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/staging/rtl8723bs/os_dep

[PATCH 39/40] staging: rtl8723bs: replace RT_TRACE with public printk wrappers in os_dep/osdep_service.c

replace private macro RT_TRACE for tracing with in-kernel pr_* printk wrappers Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/os_dep/osdep_service.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/os_dep/osdep_service.c b/drivers/staging

[PATCH 36/40] staging: rtl8723bs: replace RT_TRACE with public printk wrappers in os_dep/recv_linux.c

replace private macro RT_TRACE for tracing with in-kernel pr_* printk wrappers Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/os_dep/recv_linux.c | 22 ++- 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/recv_linux.c b

[PATCH 40/40] staging: rtl8723bs: remove obsolete debug macro

remove obsolete debug macro RT_TRACE Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/include/rtw_debug.h | 17 - 1 file changed, 17 deletions(-) diff --git a/drivers/staging/rtl8723bs/include/rtw_debug.h b/drivers/staging/rtl8723bs/include/rtw_debug.h index

[PATCH 37/40] staging: rtl8723bs: replace RT_TRACE with public printk wrappers in os_dep/sdio_intf.c

replace private macro RT_TRACE for tracing with in-kernel pr_* printk wrappers Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b

[PATCH 38/40] staging: rtl8723bs: replace RT_TRACE with public printk wrappers in os_dep/xmit_linux.c

replace private macro RT_TRACE for tracing with in-kernel pr_* printk wrappers Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/os_dep/xmit_linux.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/xmit_linux.c b/drivers

[PATCH 34/40] staging: rtl8723bs: replace RT_TRACE with public printk wrappers in os_dep/ioctl_cfg80211.c

replace private macro RT_TRACE for tracing with in-kernel pr_* printk wrappers Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b

[PATCH 28/40] staging: rtl8723bs: remove commented RT_TRACE calls in hal/HalPhyRf_8723B.c

remove commented RT_TRACE calls in hal/HalPhyRf_8723B.c Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c b/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c index

Re: [PATCH 03/40] staging: rtl8723bs: replace RT_TRACE with public printk wrappers in core/rtw_eeprom.c

On Wed, Mar 31, 2021 at 12:27:20PM +0200, Greg KH wrote: > On Wed, Mar 31, 2021 at 11:39:31AM +0200, Fabio Aiuto wrote: > > replace private macro RT_TRACE for tracing with in-kernel > > pr_* printk wrappers > > > > Signed-off-by: Fabio Aiuto > > --- &g

Re: [PATCH 03/40] staging: rtl8723bs: replace RT_TRACE with public printk wrappers in core/rtw_eeprom.c

On Wed, Mar 31, 2021 at 12:27:20PM +0200, Greg KH wrote: > On Wed, Mar 31, 2021 at 11:39:31AM +0200, Fabio Aiuto wrote: > > replace private macro RT_TRACE for tracing with in-kernel > > pr_* printk wrappers > > > > Signed-off-by: Fabio Aiuto > > --- &g

Re: [PATCH 03/40] staging: rtl8723bs: replace RT_TRACE with public printk wrappers in core/rtw_eeprom.c

On Wed, Mar 31, 2021 at 01:14:18PM +0200, Greg KH wrote: > On Wed, Mar 31, 2021 at 12:55:51PM +0200, Fabio Aiuto wrote: > > On Wed, Mar 31, 2021 at 12:27:20PM +0200, Greg KH wrote: > > > On Wed, Mar 31, 2021 at 11:39:31AM +0200, Fabio Aiuto wrote: > > > > replace priv

Re: [PATCH 03/40] staging: rtl8723bs: replace RT_TRACE with public printk wrappers in core/rtw_eeprom.c

On Wed, Mar 31, 2021 at 12:48:20PM +0200, Greg KH wrote: > On Wed, Mar 31, 2021 at 12:36:31PM +0200, Fabio Aiuto wrote: > > On Wed, Mar 31, 2021 at 12:27:20PM +0200, Greg KH wrote: > > > On Wed, Mar 31, 2021 at 11:39:31AM +0200, Fabio Aiuto wrote: > > > > replace priv

[PATCH 01/11] staging: rtl8723bs: delete extern declarations in core/rtw_ap.c

/staging/rtl8723bs/core/rtw_ap.c:15: +extern unsigned char WPS_OUI[]; -- WARNING: externs should be avoided in .c files 16: FILE: drivers/staging/rtl8723bs/core/rtw_ap.c:16: +extern unsigned char P2P_OUI[]; Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_ap.c | 5 - 1 file

[PATCH 00/11] staging: rtl8723bs: fix extern declaration checkpatch issues

Fix extern declaration issues warned by checkpatch Fabio Aiuto (11): staging: rtl8723bs: delete extern declarations in core/rtw_ap.c staging: rtl8723bs: moved function prototypes out of core/rtw_efuse.c staging: rtl8723bs: moved function prototype out of core/rtw_ioctl_set.c and core

[PATCH 02/11] staging: rtl8723bs: moved function prototypes out of core/rtw_efuse.c

fix the following checkpatch issues: WARNING: externs should be avoided in .c files 35: FILE: drivers/staging/rtl8723bs/core/rtw_efuse.c:35: +bool moved two function prototypes in include/rtw_efuse.h Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_efuse.c| 10

[PATCH 05/11] staging: rtl8723bs: remove argument in recv_indicatepkts_pkt_loss_cnt

remove debug_priv argument so function prototype can be easily moved away Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_recv.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging

[PATCH 07/11] staging: rtl8723bs: delete extern declarations in core/rtw_wlan_util.c

: +extern unsigned char WPA_TKIP_CIPHER[4]; Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c index bfd55a0356f5

[PATCH 10/11] staging: rtl8723bs: remove undefined function prototype in of os_dep/sdio_intf.c

fix the following checkpatch issue: WARNING: externs should be avoided in .c files 486: FILE: drivers/staging/rtl8723bs/os_dep/sdio_intf.c:486: +extern int pm_netdev_close(struct net_device *pnetdev, u8 bnormal); Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 1

[PATCH 08/11] staging: rtl8723bs: move function prototypes out of hal/odm.c

*pDM_Odm); moved function prototypes in hal/odm.h Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/hal/odm.c | 68 - drivers/staging/rtl8723bs/hal/odm.h | 62 ++ 2 files changed, 62 insertions(+), 68 deletions(-) diff --git a/drivers

[PATCH 03/11] staging: rtl8723bs: moved function prototype out of core/rtw_ioctl_set.c and core/rtw_mlme.c

: +extern u8 rtw_do_join(struct adapter *padapter); moved function prototype in include/rtw_ioctl_set.h Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_ioctl_set.c| 1 - drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 -- drivers/staging/rtl8723bs/include/rtw_ioctl_set.h | 2

[PATCH 06/11] staging: rtl8723bs: move function prototype out of core/rtw_recv.c

move function prototype in include/rtw_recv.h Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_recv.c| 1 - drivers/staging/rtl8723bs/include/rtw_recv.h | 2 ++ 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b

[PATCH 09/11] staging: rtl8723bs: move function prototypes out of os_dep/int_fs.c

:197: +int netdev_open(struct net_device *pnetdev); moved function prototypes in include/osdep_intf.h Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/include/osdep_intf.h | 3 +++ drivers/staging/rtl8723bs/os_dep/os_intfs.c| 2 -- 2 files changed, 3 insertions(+), 2 deletions(-) diff

[PATCH 04/11] staging: rtl8723bs: moved function prototypes out of core/rtw_recv.c

include/rtw_recv.h Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_recv.c| 31 +--- drivers/staging/rtl8723bs/include/rtw_recv.h | 51 2 files changed, 52 insertions(+), 30 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers

[PATCH 11/11] staging: rtl8723bs: remove unnecessary extern in os_dep/sdio_intf.c

remove unnecessary extern. The function is defined static in os_dep/os_intfs.c and used only once in the same file remove also a blank line Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/os_dep/os_intfs.c | 1 - drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 2 -- 2 files changed

Re: [PATCH 05/11] staging: rtl8723bs: remove argument in recv_indicatepkts_pkt_loss_cnt

On Mon, Mar 22, 2021 at 05:11:13PM +0100, Greg KH wrote: > On Mon, Mar 22, 2021 at 03:31:43PM +0100, Fabio Aiuto wrote: > > remove debug_priv argument so function prototype can be > > easily moved away > > > > Signed-off-by: Fabio Aiuto > > --- > > drivers

Re: [PATCH 02/11] staging: rtl8723bs: moved function prototypes out of core/rtw_efuse.c

On Mon, Mar 22, 2021 at 05:07:53PM +0100, Greg KH wrote: > On Mon, Mar 22, 2021 at 03:31:40PM +0100, Fabio Aiuto wrote: > > fix the following checkpatch issues: > > > > WARNING: externs should be avoided in .c files > > 35: FILE: drivers/staging/rtl8723bs/cor

Re: [PATCH 03/11] staging: rtl8723bs: moved function prototype out of core/rtw_ioctl_set.c and core/rtw_mlme.c

On Mon, Mar 22, 2021 at 05:09:00PM +0100, Greg KH wrote: > On Mon, Mar 22, 2021 at 03:31:41PM +0100, Fabio Aiuto wrote: > > fix the following checkpatch issues: > > > > WARNING: externs should be avoided in .c files > > 40: FILE: drivers/staging/rtl8723bs/core/

Re: [PATCH 05/15] staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_PM

On Tue, Mar 16, 2021 at 12:39:19PM +0100, Greg KH wrote: > On Mon, Mar 15, 2021 at 11:15:02AM +0100, Fabio Aiuto wrote: > > remove conditional code blocks checked by unused CONFIG_PM > > > > cleaning required in TODO file: > > > > find and remove code block

[PATCH v2] staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_AP_WOWLAN

remove conditional code blocks checked by unused CONFIG_AP_WOWLAN cleaning required in TODO file: find and remove code blocks guarded by never set CONFIG_FOO defines Changes in v2: rebase of conflicting code with public tree Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs

[PATCH v2] staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_GPIO_API

remove conditional code blocks checked by unused CONFIG_GPIO_API cleaning required in TODO file: find and remove code blocks guarded by never set CONFIG_FOO defines Changes in v2: rebase of conflicting code in public staging-testing Signed-off-by: Fabio Aiuto --- .../staging

[PATCH 00/12] Remove more unused code blocks

Remove unused code clocks, as required in TODO list: find and remove code blocks guarded by never set CONFIG_FOO defines Fabio Aiuto (12): staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_CMCC_TEST staging: rtl8723bs: remove unused code blocks

[PATCH 01/12] staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_CMCC_TEST

remove conditional code blocks checked by unused CONFIG_CMCC_TEST cleaning required in TODO file: find and remove code blocks guarded by never set CONFIG_FOO defines Signed-off-by: Fabio Aiuto --- .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 19 --- 1 file changed, 19

[PATCH 03/12] staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_DISABLE_MCS13TO15

remove conditional code blocks checked by unused CONFIG_DISABLE_MCS13TO15 cleaning required in TODO file: find and remove code blocks guarded by never set CONFIG_FOO defines Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 16 +--- drivers/staging

[PATCH 02/12] staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_INTERRUPT_BASED_TXBCN*

remove conditional code blocks checked by unused CONFIG_INTERRUPT_BASED_TXBCN family defines cleaning required in TODO file: find and remove code blocks guarded by never set CONFIG_FOO defines Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_ap.c | 30

[PATCH 04/12] staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_UPDATE_INDICATE_SEQ_WHILE_PROCESS_ADDBA_REQ

remove conditional code blocks checked by unused CONFIG_UPDATE_INDICATE_SEQ_WHILE_PROCESS_ADDBA_REQ cleaning required in TODO file: find and remove code blocks guarded by never set CONFIG_FOO defines Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 8 1

[PATCH 05/12] staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_VALIDATE_SSID

remove conditional code blocks checked by unused CONFIG_VALIDATE_SSID cleaning required in TODO file: find and remove code blocks guarded by never set CONFIG_FOO defines Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_ioctl_set.c | 11 --- 1 file changed, 11

[PATCH 06/12] staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_LAYER2_ROAMING_ACTIVE

remove conditional code blocks checked by unused CONFIG_LAYER2_ROAMING_ACTIVE cleaning required in TODO file: find and remove code blocks guarded by never set CONFIG_FOO defines Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 3 --- 1 file changed, 3 deletions

  1   2   3   4   5   6   >