ough the guest
remembers that it was running, management wants to start it paused.
Here, it is important that there must not be a window of time where the
guest can run, otherwise, the results are not reproducible.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualizatio
kernel person
would have to speak up for certain, but I think it is still a problem.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
On 03/01/2013 12:36 AM, Hu Tao wrote:
> On Thu, Feb 28, 2013 at 02:12:37PM -0700, Eric Blake wrote:
>> On 02/28/2013 05:13 AM, Hu Tao wrote:
>>> This patch enables preservation of cpu runstate during save/load vm.
>>> So when a vm is restored from snapshot, the cpu ru
On 02/28/2013 05:13 AM, Hu Tao wrote:
> This event will be emited when the guest is panicked.
>
> Signed-off-by: Wen Congyang
> ---
> include/monitor/monitor.h | 1 +
> monitor.c | 1 +
> 2 files changed, 2 insertions(+)
Missing documentation in QMP/qmp
nk,
>>> and POSIX specifies that it should be allowed?
>>
>> In relation to this, Eric Blake said:
>>
>>> In today's Austin Group meeting, I was tasked to open a new bug that
>>> would state specifically how the empty symlink is resolved; the inte
oser. Meanwhile, I know
there are enough other issues in the kernel (implementing O_SEARCH, for
example) that it will be a long time before we ever get a POSIX
certification of a Linux system. And as long as Linux doesn't have
POSIX certification, corner cases like non-compliance with a requirem
ncy).
> - It works as early as serial console output does (panics before
> that should be rare).
> - It allows you to see why the guest panicked.
I think your arguments for a serial console have already been made and
refuted in earlier versions of this patch series, which is WHY this
series
uary/msg00930.html
https://bugzilla.redhat.com/show_bug.cgi?id=895141
>> --- linux-3.8-rc3/include/uapi/linux/if_bridge.h2013-01-13
>> 20:09:54.257271755 +0200
>> +++ linux-3.8-rc3.fix/include/uapi/linux/if_bridge.h2013-01-13
>> 20:15:04.153676151 +0200
>&
On 09/15/2016 06:09 AM, Alex Bligh wrote:
>
> I also wonder whether any servers that can do caching per
> connection will always share a consistent cache between
> connections. The one I'm worried about in particular here
> is qemu-nbd - Eric Blake CC'd.
>
I doubt t
ation
>> stage (it would only be one flag, e.g. 'multiple connections
>> unsafe').
>
> I suppose that's not a bad idea.
Seems like it may need to be a per-export flag, rather than a global
flag (as a given server may be able to serve multiple types of files,
where t
is about. 'git format-patch/send-email
--cover-letter' does what you want; you can even 'git config
format.coverletter=auto' to always include a decent cover letter on any
multi-patch series.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization
On 10/01/2015 10:03 AM, Eric Blake wrote:
> [meta-comment]
>
> On 10/01/2015 06:14 AM, Marc Marí wrote:
>> Implementation of the FW CFG DMA interface.
>
> The subject line is missing "v4" and "0/7". Also, the cover letter is
> missing a diffstat.
On 10/01/2015 10:17 AM, Laszlo Ersek wrote:
> On 10/01/15 18:03, Eric Blake wrote:
>> [meta-comment]
>>
>> On 10/01/2015 06:14 AM, Marc Marí wrote:
>>> Implementation of the FW CFG DMA interface.
>>
>> The subject line is missing "v4" and &q
ingle cover letter.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
to the kernel folks; nothing
qemu can do about it (a userspace socket serving NBD data should not be
able to cause the kernel NBD client to result in a subsequent kernel
crash, regardless of how bad data loss is when the socket disappears out
from under the kernel).
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
['qtest', 'tcg', 'kvm', 'xen' ] }
Unusual spacing (0 spaces after '[' but 2 spaces before closing ']'?),
but not necessarily wrong.
> +##
> +# @CpuModelInfo:
> +#
> +# Virtual CPU model definition.
> +#
> +# @name: the name of the CPU model definition
> +#
> +# @accel: AccelId (name) of this cpu models accelerator
s/models/model's/
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
e of that optional
parameter? Without introspection, a new command is easier to query than
learning about whether an optional parameter exists (then again, we're
hoping to get introspection into 2.4, so it may be a moot question).
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
t;
> ##
> # @query-cpu-definitions:
> #
> # Return a list of supported virtual CPU definitions
> #
> +# @machine: #optional machine type (since 2.4)
> +#
> +# @accel: #optional accelerator id (since 2.4)
Maybe mention that these two fields are for filtering results.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
he new parameters are provided to an old QEMU version
> that doesn't accept them? It looks like we need an introspection
> mechanism or a new command name.
Providing an optional parameter that a new qemu understands to an older
qemu gracefully errors out about an unknown parameter. Bu
ice, will update
> as per concensus.
>
> [1] https://marc.info/?l=qemu-devel&m=152450249319168&w=2
Then let's spell that in a way that patchew understands (since patchew
does not know how to turn marc.info references into Message-IDs):
Based-on: <20180423165126.15441-1
gt; +##
> +{ 'struct': 'VirtioPMemDeviceInfo',
> +'data': { '*id': 'str',
> + 'start': 'size',
> + 'size': 'size',
TAB damage.
> + 'memdev': 'str'
> + }
> +}
> +
h to
know whether anyone will care about type separate from ga. But if
someone DOES care, then the QMP command should return the parts already
split, as in { "type": 2827, "ga": 2 }, or even as convenience provide
both split and combined forms: { "name": "2827-ga2", "type": 2827, "ga": 2 }
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
series.
The cover letter is a great place to point out how v4 differs from v3,
but also to point out which patches are unchanged from v3, to save
reviewer's time. So if all you did was add new patches, a cover-letter
mention of which patches remain unchanged might be helpful.
--
Eric Blake
ace to use for parsing integers
- it has undefined behavior if the input text would trigger integer
overflow, making it safe to use ONLY on text that you control and can
guarantee won't overflow. By the time you've figured out if untrusted
text meets the requirement for safe parsing via sscanf(), you've
practically already parsed it via safer strtol() and friends.]
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
async page faults in the guest
> +scheduler so those guest processes that aren't waiting for userfaults
> +can keep running in the guest vcpus).
> +
> +The primary ioctl to resolve userfaults is UFFDIO_COPY. That
> +atomically copies a page into the userfault registered range and wakes
> +up the blocked userfaults (unless uffdio_copy.mode &
> +UFFDIO_COPY_MODE_DONTWAKE is set). Other ioctl works similarly to
> +UFFDIO_COPY.
>
>
>
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
CPU model
s/to/the/
> +#
> +# Returns: CpuModelInfo
> +#
> +# Since: 2.3.0
We aren't very consistent on '2.3' vs. '2.3.0', so I won't complain
about that.
> +##
> +{ 'command': 'query-cpu-model', 'returns': 'CpuModelInfo' }
Seems reasonable from the interface point of view; I have not closely
reviewed the implementation.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
+#
> +# Accelerator specific CPU model data
> +#
> +# @id: the accelerator id
> +#
There is no 'id' field below, did you mean 'name'?
> +# @default: cpu model for 'host'
> +#
> +# @runnable: cpu model can be activated on hosting machine
> +#
> +# Since: 2.3.0
> +#
> +##
> +{ 'type': 'AccelCpuModelInfo',
> + 'data': { 'name': 'AccelId', 'default': 'bool', 'runnable': 'bool' } }
> +
> +##
> # @CpuDefinitionInfo:
> #
> # Virtual CPU definition.
> #
> # @name: the name of the CPU definition
> #
> +# @accelerators: #optional cpu model offered per accelerator (since 2.3.0)
> +#
Must the field be optional, or will we always provide it? Since this is
an output-only field, it is okay for back-compat to make the new field
unconditional.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
> 4 files changed, 23 insertions(+), 7 deletions(-)
>
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
they don't have PCI vendor IDs.
...to just what you are replying to.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
qemu-trivial are definitely cases where we have separate lists, but
where posters are reminded to include qemu-devel in cc if they want a
patch applied.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
On 11/22/2016 01:41 PM, Paolo Bonzini wrote:
>
>
> On 22/11/2016 19:54, Eric Blake wrote:
>>>>>> DRM DRIVER FOR BOCHS VIRTUAL GPU
>>>>>> M: Gerd Hoffmann
>>>>>> -S: Odd Fixes
>>>>>> +L: qemu-de
until the last user
> closes the block device. This offers the possibility as well to open a
> new socket to be used while the filesystems are mounted.
>
> Signed-off-by: Pranay Kr. Srivastava
>
> [mpa: Keep the blockdevice open until all users left]
> Signed-off-by: Markus Parg
; Signed-off-by: Pranay Kr. Srivastava
> ---
> drivers/block/nbd.c | 124
> ++++----
> 1 file changed, 96 insertions(+), 28 deletions(-)
>
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
fchownat(int dfd, const char __user *filename, uid_t
> user,
>gid_t group, int flag);
Is the indentation off here?
Reviewed-by: Eric Blake
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
correctly
> in vi and emacs (I've simply copied the sys_fchmodat() declaration).
Sorry for the noise; I see that it is correct now, since fchmodat2 is
one bye longer than fchmodat or fchownat. Sometimes, I wish I could
convince my mailer to display leading tabs as exactly 8 spaces rather
tha
f servers that also support the
baseline - but not all servers are up to that baseline yet.
So, this becomes a question of how much are you reinventing baseline
portability handshake concerns in the kernel, vs. in initramfs.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
On 6/13/19 8:02 AM, Eric Blake wrote:
> On 6/12/19 11:31 AM, roman.stratiie...@globallogic.com wrote:
>> From: Roman Stratiienko
>>
>> Adding support to nbd to use it as a root device. This code essentially
>> provides a minimal nbd-client implementation within the k
On 04/11/2017 12:52 PM, Colin Walters wrote:
>
>
> On Tue, Feb 28, 2017, at 02:23 PM, Eric Blake wrote:
>
>> Might also be worth mentioning that this patch is required in order to
>> solve CVE-2016-9602, per discussion at
>> https://lists.gnu.org/archive/html/qe
On 04/11/2017 12:55 PM, Eric Blake wrote:
> On 04/11/2017 12:52 PM, Colin Walters wrote:
>>
>>
>> On Tue, Feb 28, 2017, at 02:23 PM, Eric Blake wrote:
>>
>>> Might also be worth mentioning that this patch is required in order to
>>> solve CVE-2016-9602
On 04/11/2017 01:07 PM, Eric Blake wrote:
>
> But even if using open(O_PATH)/fchmod() works, it is not immediately
> obvious whether it can catch all the same cases that chmodat(O_NOFOLLOW)
Typo; I obviously meant fchmodat(AT_SYMLINK_NOFOLLOW)
> would cover, as there are cases wh
40 matches
Mail list logo
