[PATCH libdrm 1/2] Return an -ENODEV from drmGetDevice() when no device was found.

2016-10-21 Thread Eric Anholt
From: Rob Herring Fixes crashes in Mesa on platform device, which expected *device to have a device when 0 was returned. (code from a paste by Rob, commit message by anholt) Signed-off-by: Eric Anholt --- xf86drm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/xf86drm.c b/xf86drm.c

[PATCH libdrm 2/2] Silence runtime complaints on platform devices

2016-10-21 Thread Eric Anholt
glxgears was spamming this 12 times at startup because of Mesa's probing of the DRM device code, which doesn't support platform devices. Signed-off-by: Eric Anholt --- xf86drm.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/xf86drm.c b/xf86drm.c index 9b52889e4cef..52add5e44

Re: [PATCH v3] ARM: bcm2835: Add names for the Raspberry Pi GPIO lines

2016-11-11 Thread Eric Anholt
Stephen Warren writes: > On 10/27/2016 10:52 AM, Eric Anholt wrote: >> From: Linus Walleij >> >> The idea is to give useful names to GPIO lines that an implementer >> will be using from userspace, e.g. for maker type projects. These are >> user-visible using t

[PATCH] ARM64: dts: bcm2837-rpi-3-b: remove incorrect pwr LED

2016-11-11 Thread Eric Anholt
From: Andrea Merello We are incorrectly defining the pwr LED, attaching it to a gpio line that is wired to the Wi-Fi SDIO module (which fails due to this). The actual power LED is connected to the GPIO expander, which we don't expose currently. Thanks-to: Eric Anholt [for clarifying we

[PATCH] drm/vc4: Add threading support

2016-11-12 Thread Eric Anholt
instructions do not interfere. (Original patch by Jonas, changes by anholt for style cleanup, removing validation the kernel doesn't need to do, and adding the flag for userspace). Signed-off-by: Jonas Pfeil Signed-off-by: Eric Anholt --- drivers/gpu/drm/vc4/vc4_drv.c | 1 + driver

[PATCH] drm/vc4: Fix race between page flip completion event and clean-up

2016-11-28 Thread Eric Anholt
From: Derek Foreman There was a small window where a userspace program could submit a pageflip after receiving a pageflip completion event yet still receive EBUSY. Signed-off-by: Derek Foreman Signed-off-by: Eric Anholt Reviewed-by: Eric Anholt --- drivers/gpu/drm/vc4/vc4_crtc.c | 8

Re: [PATCH v3] ARM: bcm2835: Add names for the Raspberry Pi GPIO lines

2016-10-31 Thread Eric Anholt
Stefan Wahren writes: > Hi Eric, > >> Eric Anholt hat am 27. Oktober 2016 um 18:52 geschrieben: >> >> >> From: Linus Walleij >> >> The idea is to give useful names to GPIO lines that an implementer >> will be using from userspace, e.g. for

Re: [PATCH v2] irqchip/bcm2836: Prevent spurious interrupts

2016-10-31 Thread Eric Anholt
Thomas Gleixner writes: > On Fri, 28 Oct 2016, Eric Anholt wrote: > >> Thomas Gleixner writes: >> > This is missing a fixes tag. I have no idea when that problem was >> > introduced, so I have no way to decide whether this needs to be tagged >> > stable

Re: [PATCH] staging: vc04_services: call sg_init_table to init scatterlist

2016-10-31 Thread Eric Anholt
the magic cookie > + * is filled if debugging is enabled > + */ > + sg_init_table(scatterlist, num_pages); > + /* Now set the pages for each scatterlist */ I feel like the comments don't add much, but either way: Acked-by: Eric Anholt > for (i = 0; i <

Re: [PATCH] staging: vc04_services: setup DMA and coherent mask

2016-10-31 Thread Eric Anholt
Michael Zoran writes: > Setting the DMA mask is optional on 32 bit but > is mandatory on 64 bit. Set the DMA mask and coherent > to force all DMA to be in the 32 bit address space. > > This is considered a "good practice" and most drivers > already do this. > > Signed-off-by: Michael Zoran > --

Re: [PATCH v3] ARM: bcm2835: Add names for the Raspberry Pi GPIO lines

2016-11-01 Thread Eric Anholt
Stefan Wahren writes: >> Eric Anholt hat am 31. Oktober 2016 um 18:53 geschrieben: >> >> >> Stefan Wahren writes: >> >> > Hi Eric, >> > >> >> Eric Anholt hat am 27. Oktober 2016 um 18:52 >> >> geschrieben: >>

Re: [PATCH] staging: vc04_services: parse_rx_slots() - Fix compiler warning

2016-11-01 Thread Eric Anholt
t is expected that a human debugging > the kernel interpret it. > > This change adds a cast to long before the original cast > to int to silence the warning. > > Signed-off-by: Michael Zoran Thanks for sorting this out. Reviewed-by: Eric Anholt signature.asc Description: PGP signature

Re: [PATCH] staging: vc04_services: Fix bracing on single statement blocks

2016-12-19 Thread Eric Anholt
Aaron Moore writes: > Fix coding style issue caught by checkpatch.pl relating to braces on > single statement blocks. This issue was corrected in 3 locations. > > Signed-off-by: Aaron Moore Reviewed-by: Eric Anholt signature.asc Description: PGP signature

Re: [PATCH 02/11] clk: bcm2835: Register the DSI0/DSI1 pixel clocks.

2016-12-21 Thread Eric Anholt
Stephen Boyd writes: > On 12/14, Eric Anholt wrote: >> >> /* the gates */ >> >> @@ -1890,8 +1976,18 @@ static int bcm2835_clk_probe(struct platform_device >> *pdev) >> if (IS_ERR(cprman->regs)) >> return PTR_

Re: [PATCH libdrm 2/2] Silence runtime complaints on platform devices

2016-10-24 Thread Eric Anholt
Emil Velikov writes: > On 21 October 2016 at 18:12, Eric Anholt wrote: >> glxgears was spamming this 12 times at startup because of Mesa's >> probing of the DRM device code, which doesn't support platform >> devices. >> > Better option is to add support f

Re: [PATCH 2/2] staging: vc04_services: Replace dmac_map_area with dmac_map_sg

2016-10-24 Thread Eric Anholt
Greg KH writes: > On Sun, Oct 23, 2016 at 10:29:32PM -0700, mzo...@crowfest.net wrote: >> From: Michael Zoran >> >> The original arm implementation uses dmac_map_area which is not >> portable. Replace it with an architecture neutral version >> which uses dma_map_sg. >> >> As you can see that

Re: [PATCH 2/2] staging: vc04_services: Replace dmac_map_area with dmac_map_sg

2016-10-24 Thread Eric Anholt
mzo...@crowfest.net writes: > From: Michael Zoran > > The original arm implementation uses dmac_map_area which is not > portable. Replace it with an architecture neutral version > which uses dma_map_sg. > > As you can see that for larger page sizes, the dma_map_sg > implementation is faster then

Re: [PATCH] ARM64: dts: bcm2835: Fix bcm2837 compatible string

2016-10-24 Thread Eric Anholt
e<#secure method=pgpmime mode=sign> Andreas Färber writes: > bcm2837-rpi-3-b.dts, its only in-tree user, was overriding it as > "brcm,bcm2837" already. Pulled to bcm2835-dt-64-next. Thanks!

Re: [PATCH 3/5] staging/vchi: Fix some pointer math for 64-bit.

2016-10-25 Thread Eric Anholt
Greg Kroah-Hartman writes: > On Mon, Oct 17, 2016 at 12:44:04PM -0700, Eric Anholt wrote: >> These were throwing warnings on aarch64, and all are trivially >> converted to longs. >> >> Signed-off-by: Eric Anholt >> --- >> drivers/staging/vc04_services/i

Re: [PATCH 2/2] staging: vc04_services: Replace dmac_map_area with dmac_map_sg

2016-10-25 Thread Eric Anholt
Michael Zoran writes: > On Tue, 2016-10-25 at 08:00 -0700, Michael Zoran wrote: >> On Mon, 2016-10-24 at 10:31 -0700, Eric Anholt wrote: >> > mzo...@crowfest.net writes: >> > >> > >  */ >> > >   >> > >  static int >>

Re: [PATCH 0/6] staging: vchiq_arm: Fine-tuning for some function implementations

2017-01-03 Thread Eric Anholt
SF Markus Elfring writes: > From: Markus Elfring > Date: Sat, 31 Dec 2016 22:42:34 +0100 > > Some update suggestions were taken into account > from static source code analysis. This series is: Reviewed-by: Eric Anholt signature.asc Description: PGP signature

Re: [PATCH] watchdog: bcm2835_wdt: set WDOG_HW_RUNNING bit when appropriate

2016-12-12 Thread Eric Anholt
bootloaders (the closed firmware or u-boot) set up the watchdog, but this seems reasonable since they might want to later. Acked-by: Eric Anholt signature.asc Description: PGP signature

[PATCH 00/11] drm/vc4: DSI panel support + Raspberry Pi touchscreen

2016-12-14 Thread Eric Anholt
x27;re not triggering our IRQ handler anyway. Note that patch #11 is not intended to be pushed, it's just a demo. Eric Anholt (11): clk: bcm2835: Don't rate change PLLs on behalf of DSI PLL dividers. clk: bcm2835: Register the DSI0/DSI1 pixel clocks. clk: bcm2835: Add leaf clock measu

[PATCH 04/11] drm/vc4: Set up SCALER_DISPCTRL at boot.

2016-12-14 Thread Eric Anholt
We want the HVS on, obviously, and we also want DSP3 (PV1's source) to be muxed from HVS channel 2 like we expect in vc4_crtc.c. The firmware wasn't setting the DSP3 mux up when both the LCD and HDMI were disabled. Signed-off-by: Eric Anholt --- drivers/gpu/drm/vc4/vc4_h

[PATCH 01/11] clk: bcm2835: Don't rate change PLLs on behalf of DSI PLL dividers.

2016-12-14 Thread Eric Anholt
. We *do* want PLLH to change so that PLLH_AUX can be exactly the value we want, though. Thus, we need to have a per-divider policy of whether to pass rate changes up. Signed-off-by: Eric Anholt --- drivers/clk/bcm/clk-bcm2835.c | 42 -- 1 file changed, 28

[PATCH 11/11] ARM: bcm2835: Enable the Raspberry Pi touchscreen panel.

2016-12-14 Thread Eric Anholt
This commit is not intended to be merged. Instead we will use overlays to enable the panel, and this commit is just a demo of how things get wired up. Signed-off-by: Eric Anholt --- arch/arm/boot/dts/bcm283x.dtsi | 30 +- 1 file changed, 29 insertions(+), 1 deletion

[PATCH 06/11] dt-bindings: Document the VC4 DSI module nodes.

2016-12-14 Thread Eric Anholt
These are part of the vc4 display pipeline. Signed-off-by: Eric Anholt --- .../devicetree/bindings/display/brcm,bcm-vc4.txt | 35 ++ 1 file changed, 35 insertions(+) diff --git a/Documentation/devicetree/bindings/display/brcm,bcm-vc4.txt b/Documentation/devicetree

[PATCH 05/11] drm/vc4: Add support for feeding DSI encoders from the pixel valve.

2016-12-14 Thread Eric Anholt
We have to set a different pixel format, which tells the hardware to use the pix_width field that's fed in sideband from the DSI encoder to divide the "pixel" clock. Signed-off-by: Eric Anholt --- drivers/gpu/drm/vc4/vc4_crtc.c | 33 +++-- driv

[PATCH 09/11] drm/panel: Add support for the Raspberry Pi 7" Touchscreen.

2016-12-14 Thread Eric Anholt
: disable_touchscreen=1 ignore_lcd=2 mask_gpu_interrupt1=0x1000 This means that the firmware won't power on the panel at boot time (no rainbow) and the touchscreen input won't work. The native input driver for the touchscreen still needs to be written. Signed-off-by: Eric Anholt --- drive

[PATCH 03/11] clk: bcm2835: Add leaf clock measurement support, disabled by default

2016-12-14 Thread Eric Anholt
This proved incredibly useful during debugging of the DSI driver, to see if our clocks were running at rate we requested. Let's leave it here for the next person interacting with clocks on the platform (and so that hopefully we can just hook it up to debugfs some day). Signed-off-by: Eric A

[PATCH 08/11] dt-bindings: Document the Raspberry Pi Touchscreen nodes.

2016-12-14 Thread Eric Anholt
This doesn't yet cover input, but the driver does get the display working when the firmware is disabled from talking to our I2C lines. Signed-off-by: Eric Anholt --- .../display/panel/raspberrypi,touchscreen.txt | 45 ++ 1 file changed, 45 insertions(+) create

[PATCH 07/11] drm/vc4: Add DSI driver

2016-12-14 Thread Eric Anholt
st, but it does put a lot of the register definitions and code in place. Signed-off-by: Eric Anholt --- drivers/gpu/drm/vc4/Kconfig |2 + drivers/gpu/drm/vc4/Makefile |1 + drivers/gpu/drm/vc4/vc4_debugfs.c |1 + drivers/gpu/drm/vc4/vc4_drv.c |1 + drivers/gpu/drm/vc4

[PATCH 10/11] ARM: bcm2835: dt: Add the DSI module nodes and clocks.

2016-12-14 Thread Eric Anholt
The modules stay disabled by default, and if you want to enable DSI you'll need an overlay that connects a panel to it. Signed-off-by: Eric Anholt --- arch/arm/boot/dts/bcm2835-rpi.dtsi | 8 +++ arch/arm/boot/dts/bcm283x.dtsi | 49 +++--- 2 files ch

[PATCH 02/11] clk: bcm2835: Register the DSI0/DSI1 pixel clocks.

2016-12-14 Thread Eric Anholt
The DSI pixel clocks are muxed from clocks generated in the analog phy by the DSI driver. In order to set them as parents, we need to do the same name lookup dance on them as we do for our root oscillator. Signed-off-by: Eric Anholt --- .../bindings/clock/brcm,bcm2835-cprman.txt | 15

[PATCH] mm: Drop "PFNs busy" printk in an expected path.

2016-12-28 Thread Eric Anholt
times per second. Signed-off-by: Eric Anholt Cc: linux-stable --- mm/page_alloc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 6de9440e3ae2..bea7204c14a5 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -7289,8 +7289,6 @@ int alloc_contig_

Re: [PATCH] mm: Drop "PFNs busy" printk in an expected path.

2016-12-29 Thread Eric Anholt
Michal Hocko writes: > This has been already brought up > http://lkml.kernel.org/r/20161130092239.gd18...@dhcp22.suse.cz and there > was a proposed patch for that which ratelimited the output > http://lkml.kernel.org/r/20161130132848.gg18...@dhcp22.suse.cz resp. > http://lkml.kernel.org/r/robbat2

Re: [PATCH] mm: Drop "PFNs busy" printk in an expected path.

2016-12-29 Thread Eric Anholt
Michal Nazarewicz writes: > On Thu, Dec 29 2016, Eric Anholt wrote: >> Michal Hocko writes: >> >>> This has been already brought up >>> http://lkml.kernel.org/r/20161130092239.gd18...@dhcp22.suse.cz and there >>> was a proposed patch for

Re: [PATCH] mm: Drop "PFNs busy" printk in an expected path.

2016-12-30 Thread Eric Anholt
Michal Nazarewicz writes: > On Thu, Dec 29 2016, Eric Anholt wrote: >> Michal Nazarewicz writes: >> >>> On Thu, Dec 29 2016, Eric Anholt wrote: >>>> Michal Hocko writes: >>>> >>>>> This has been already brought up >>>>

[PATCH 3/6] drm/vc4: Add support for the VEC (Video Encoder) IP

2016-11-29 Thread Eric Anholt
From: Boris Brezillon The VEC IP is a TV DAC, providing support for PAL and NTSC standards. Signed-off-by: Boris Brezillon Signed-off-by: Eric Anholt --- drivers/gpu/drm/vc4/Makefile | 1 + drivers/gpu/drm/vc4/vc4_debugfs.c | 1 + drivers/gpu/drm/vc4/vc4_drv.c | 1 + drivers

[PATCH 5/6] ARM: bcm/dt: Add VEC node in bcm283x.dtsi

2016-11-29 Thread Eric Anholt
From: Boris Brezillon Add the VEC (Video EnCoder) node definition in bcm283x.dtsi. Signed-off-by: Boris Brezillon Signed-off-by: Eric Anholt --- arch/arm/boot/dts/bcm283x.dtsi | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm/boot/dts/bcm283x.dtsi b/arch/arm/boot/dts

[PATCH 2/6] drm: Add TV connector states to drm_connector_state

2016-11-29 Thread Eric Anholt
the connector state accordingly. Each driver is then responsible for checking and applying the new config in its ->atomic_mode_{check,set}() operations. Signed-off-by: Boris Brezillon Signed-off-by: Eric Anholt --- drivers/gpu/drm/drm_atomic.c |

[PATCH 4/6] drm/vc4: Document VEC DT binding

2016-11-29 Thread Eric Anholt
From: Boris Brezillon Document the DT binding for the VEC (Video EnCoder) IP. Signed-off-by: Boris Brezillon Signed-off-by: Eric Anholt --- Documentation/devicetree/bindings/display/brcm,bcm-vc4.txt | 14 ++ 1 file changed, 14 insertions(+) diff --git a/Documentation/devicetree

[PATCH 6/6] ARM: bcm/dt: Enable the VEC IP on all RaspberryPi boards

2016-11-29 Thread Eric Anholt
From: Boris Brezillon Enable the VEC IP on all RaspberryPi boards. Signed-off-by: Boris Brezillon Signed-off-by: Eric Anholt --- arch/arm/boot/dts/bcm2835-rpi.dtsi | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm/boot/dts/bcm2835-rpi.dtsi b/arch/arm/boot/dts/bcm2835

[PATCH 1/6] drm/vc4: Fix ->clock_select setting for the VEC encoder

2016-11-29 Thread Eric Anholt
From: Boris Brezillon PV_CONTROL_CLK_SELECT_VEC is actually 2 and not 0. Fix the definition and rework the vc4_set_crtc_possible_masks() to cover the full range of the PV_CONTROL_CLK_SELECT field. Signed-off-by: Boris Brezillon Signed-off-by: Eric Anholt --- drivers/gpu/drm/vc4/vc4_crtc.c

[PATCH 0/6] drm/vc4: VEC (SDTV) output support

2016-11-29 Thread Eric Anholt
Here's a series from Boris for enabling SDTV output on VC4. There are two other patches to the clk subsystem necessary to get it working, which I'm in the process of reviewing. I've tested it on composite input of a monitor I had laying around, and it's basically working. Booting with the firmwa

[GIT PULL 3/4] bcm2835-defconfig-next-2016-11-18

2016-11-18 Thread Eric Anholt
Linux 4.9-rc1 (2016-10-15 12:17:50 -0700) are available in the git repository at: https://github.com/anholt/linux tags/bcm2835-defconfig-next-2016-11-18 for you to fetch changes up to bab0cb90550467c71f4e1b73da406a2280c4f418: ARM: bcm2835: add thermal driver to default config (2016-11-11

[GIT PULL 2/4] bcm2835-dt-64-next-2016-11-18

2016-11-18 Thread Eric Anholt
ranch. Andrea Merello (1): ARM64: dts: bcm2837-rpi-3-b: remove incorrect pwr LED Andreas Färber (1): ARM64: dts: bcm2835: Fix bcm2837 compatible string Eric Anholt (2): ARM: dts: bcm283x: Define standard pinctrl groups i

[GIT PULL 1/4] bcm2835-dt-next-2016-11-18

2016-11-18 Thread Eric Anholt
:36 -0800) This pull request brings in DT changes for BCM2835: pinctrl setup cleanups, GPIO line naming, and the node for the new thermal driver. Eric Anholt (1

[GIT PULL 4/4] bcm2835-defconfig-64-next-2016-11-18

2016-11-18 Thread Eric Anholt
Linux 4.9-rc1 (2016-10-15 12:17:50 -0700) are available in the git repository at: https://github.com/anholt/linux tags/bcm2835-defconfig-64-next-2016-11-18 for you to fetch changes up to ac178e4280e65f4d0d14b13a7bfec3a43ff90e66: ARM64: bcm2835: add thermal driver to default config (2016-1

Re: [PATCH 1/1] dri: vc4: set error code on failure

2016-12-09 Thread Eric Anholt
Pan Bian writes: > Function vc4_cl_lookup_bos() does not set the error code when > drm_malloc_ab() returns a NULL pointer, and will return 0 (indicates > success). This patch fixes the bug, assigning "-ENOMEM" to the return > variable ret on the path that memory allocation fails. > > Bugzilla: ht

[GIT PULL] drm-vc4-next-2016-12-09

2016-12-09 Thread Eric Anholt
I just got the ack on the DT bindings for VEC, so I'd like to get it pulled if we can. If it's too late for 4.10, I'm fine waiting. Adding VEC support should have a low chance of regressions because it doesn't get a mode configured by default. This is due to it reporting unknown connector state

Re: Eric Anholt offically announces support of VC4 without access to expander on the RPI 3

2017-03-21 Thread Eric Anholt
Michael Zoran writes: > On Mon, 2017-03-20 at 10:22 -0700, Eric Anholt wrote: >> Michael Zoran writes: >> >> > > > Since the API is completely documented, I see no reason we or >> > > > anybody >> > > > couldn't essentially re

[GIT PULL 1/4] bcm2835 arm64 defconfig updates for 4.12

2017-03-21 Thread Eric Anholt
Linux 4.11-rc1 (2017-03-05 12:59:56 -0800) are available in the git repository at: git://github.com/anholt/linux tags/bcm2835-defconfig-64-next-2017-03-21 for you to fetch changes up to 3c9d36192802d60fca73c85c7096221371c36be7: arm64: set CONFIG_MMC_BCM2835=y in defconfig (2017-03-17 17:0

Re: [PATCH v3 2/3] drm/pl111: Initial drm/kms driver for pl111

2017-03-21 Thread Eric Anholt
Russell King - ARM Linux writes: > On Mon, Mar 20, 2017 at 04:36:14PM -0700, Eric Anholt wrote: >> +static struct amba_driver pl111_amba_driver = { >> +.drv = { >> +.name = "clcd-pl11x", > > either: > > .name = "clc

[GIT PULL 4/4] bcm2835 MAINTAINERS updates for 4.12

2017-03-21 Thread Eric Anholt
:28 -0800) This pull request updates the MAINTAINERS file for BCM283x for 4.12. Eric Anholt (1): MAINTAINERS: Add Stefan Wahren to bcm2835. Stephen Warren (1

[GIT PULL 2/4] bcm2835 arm defconfig updates for 4.12

2017-03-21 Thread Eric Anholt
Linux 4.11-rc1 (2017-03-05 12:59:56 -0800) are available in the git repository at: git://github.com/anholt/linux tags/bcm2835-defconfig-next-2017-03-21 for you to fetch changes up to 51a08de0fd3d1d25d28f99ef992cb429cced56a5: arm: set CONFIG_MMC_BCM2835=y in bcm2835_defconfig and multi_v7_

[GIT PULL 1/4] bcm2835 arm DT updates for 4.12

2017-03-21 Thread Eric Anholt
). Boris Brezillon (1): ARM: dts: bcm283x: Add HDMI audio related properties Eric Anholt (1): ARM: dts: bcm2835: Add the DSI module nodes and clocks. Gerd Hoffmann (1): ARM: dts: bcm2835: add sdhost controller to devicetree arch/arm/boot/dts/bcm2835

Re: Eric Anholt offically announces support of VC4 without access to expander on the RPI 3

2017-03-21 Thread Eric Anholt
Michael Zoran writes: > On Tue, 2017-03-21 at 10:34 -0700, Eric Anholt wrote: >> Michael Zoran writes: >> >> > On Mon, 2017-03-20 at 10:22 -0700, Eric Anholt wrote: >> > > Michael Zoran writes: >> > > >> > > > > > Since

[PATCH 2/2] drm/vc4: Fix misleading name of the continuous flag.

2017-03-17 Thread Eric Anholt
The logic was all right in the end, the name was just backwards. Signed-off-by: Eric Anholt --- drivers/gpu/drm/vc4/vc4_dsi.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_dsi.c b/drivers/gpu/drm/vc4/vc4_dsi.c index 3bad8bad32a2

Re: [PATCH] drm: vc4: remove redundant check of plane being non-null

2017-03-17 Thread Eric Anholt
Colin King writes: > From: Colin Ian King > > The pointer plane is always null on the error path at label 'fail' > hence the check if it is non-null is redundant. We can therefore > remove the check and the destruction of plane as well as the fail > error path and instead just return an -ENOMEM

[PATCH 1/2] drm/vc4: Fix DSI T_INIT timing.

2017-03-17 Thread Eric Anholt
The DPHY spec requires a much larger T_INIT than I was specifying before. In the absence of clear specs from the slave of what their timing is, just use the value that the firmware was using. Signed-off-by: Eric Anholt --- drivers/gpu/drm/vc4/vc4_dsi.c | 12 +++- 1 file changed, 11

Re: [PATCH v4 5/7] arm64: set CONFIG_MMC_BCM2835=y in defconfig

2017-03-17 Thread Eric Anholt
Gerd Hoffmann writes: > We need to enable this controller so that we can switch the SD card's > pinmux over to it by default, which will improve storage performance. > > Read access (dd with 64k blocks on rpi2): > CONFIG_MMC_SDHCI_IPROC: 11-12 MB/s > CONFIG_MMC_BCM2835: 19-20 MB/s > > Dif

Re: [PATCH 0/6] staging: BCM2835 MMAL V4L2 camera driver

2017-03-17 Thread Eric Anholt
Mauro Carvalho Chehab writes: > Em Wed, 15 Mar 2017 18:46:24 -0700 > Michael Zoran escreveu: > >> On Wed, 2017-03-15 at 22:08 -0300, Mauro Carvalho Chehab wrote: >> >> > No, I didn't. Thanks! Applied it but, unfortunately, didn't work. >> > Perhaps I'm missing some other patch. I'm compiling it

[PATCH 1/2] video: ARM CLCD: Move registers to a separate header.

2017-03-17 Thread Eric Anholt
We'd like to reuse these register definitions for the DRM CLCD driver, but there's a bunch of fbdev-specific code in the current header. Signed-off-by: Eric Anholt --- include/linux/amba/clcd-regs.h | 76 ++ include/linux/amba/clcd.h

[PATCH 0/2] ARM CLCD DRM driver

2017-03-17 Thread Eric Anholt
e drm-misc tree once it's ready. For anyone interested in looking through the history of what I changed from Tom's v1 patch, https://github.com/anholt/linux/tree/bcm11360-clcd has it (and all the rest of the platform bits I've needed). Eric Anholt (1): video: ARM CLCD: Move r

[PATCH 2/2] drm/pl111: Initial drm/kms driver for pl111

2017-03-17 Thread Eric Anholt
existing devicetree binding, while not using quite as many of its properties as the fbdev driver does (those are left for future work). v2: Nearly complete rewrite by anholt, cutting 2/3 of the code thanks to DRM core's excellent new helpers. Signed-off-by: Tom Cooksey Signed-off-by: Eric A

Re: [PATCH 2/2] drm/pl111: Initial drm/kms driver for pl111

2017-03-17 Thread Eric Anholt
Russell King - ARM Linux writes: > On Fri, Mar 17, 2017 at 03:47:42PM -0700, Eric Anholt wrote: >> This is a modesetting driver for the pl111 CLCD display controller >> found on various ARM platforms such as the Versatile Express. The >> driver has only been tested on

Re: [PATCH 2/2] drm/pl111: Initial drm/kms driver for pl111

2017-03-20 Thread Eric Anholt
Daniel Vetter writes: > On Fri, Mar 17, 2017 at 03:47:42PM -0700, Eric Anholt wrote: >> From: Tom Cooksey >> >> This is a modesetting driver for the pl111 CLCD display controller >> found on various ARM platforms such as the Versatile Express. The >> d

[PATCH v3 1/3] video: ARM CLCD: Move registers to a separate header.

2017-03-20 Thread Eric Anholt
We'd like to reuse these register definitions for the DRM CLCD driver, but there's a bunch of fbdev-specific code in the current header. Signed-off-by: Eric Anholt --- include/linux/amba/clcd-regs.h | 76 ++ include/linux/amba/clcd.h

[PATCH v3 2/3] drm/pl111: Initial drm/kms driver for pl111

2017-03-20 Thread Eric Anholt
ach if we don't have a DRM panel, use DRM_GEM_CMA_FOPS, update MAINTAINERS, use the simple display helper, use drm_gem_cma_dumb_create (same as our wrapper). Signed-off-by: Tom Cooksey Signed-off-by: Eric Anholt --- Documentation/gpu/index.rst | 1 + Documen

[PATCH v3 3/3] drm: Clarify the role of plane_state argument to drm_simple update().

2017-03-20 Thread Eric Anholt
Like the atomic update hook it's wrapping, the plane_state is the old one, and the new one is in plane->state. Both msxfb and tinydrm use it correctly, but I mistook it for the new state in pl111 due to its naming. Signed-off-by: Eric Anholt --- drivers/gpu/drm/drm_simple_kms_help

[PATCH] drm/vc4: Allow using more than 256MB of CMA memory.

2017-03-27 Thread Eric Anholt
till contiguous, of course). Signed-off-by: Eric Anholt --- drivers/gpu/drm/vc4/vc4_drv.h | 28 +-- drivers/gpu/drm/vc4/vc4_gem.c | 12 ++- drivers/gpu/drm/vc4/vc4_irq.c | 61 +++ drivers/gpu/drm/vc4/vc4_render_cl.c | 3 +- drivers/gpu/drm/vc4/vc4_v3

Re: [PATCH 0/6] staging: BCM2835 MMAL V4L2 camera driver

2017-03-15 Thread Eric Anholt
Mauro Carvalho Chehab writes: > Em Fri, 27 Jan 2017 13:54:57 -0800 > Eric Anholt escreveu: > >> Here's my first pass at importing the camera driver. There's a bunch >> of TODO left to it, most of which is documented, and the rest being >> standard checkpat

Re: [PATCH v2 2/3] drm/vc4: Add HDMI audio support

2017-03-16 Thread Eric Anholt
Eric Anholt writes: > The HDMI encoder IP embeds all needed blocks to output audio, with a > custom DAI called MAI moving audio between the two parts of the HDMI > core. This driver now exposes a sound card to let users stream audio > to their display. > > Using the hdmi-cod

Re: [PATCH v4 0/7] mmc: bcm2835: Add new driver for the sdhost controller

2017-03-16 Thread Eric Anholt
Gerd Hoffmann writes: > Hi, > > Next version if the bcm2835 sdhost patch series. Still waiting for the subsystem maintainer to merge the driver before merging the platform side. signature.asc Description: PGP signature

[PATCH 1/2] drm/vc4: Fix termination of the initial scan for branch targets.

2016-11-04 Thread Eric Anholt
ld be that a valid shader is rejected because some undefined memory after the PROG_END slots is parsed as a branch and the rest of its setup is illegal. I haven't seen this in the wild, but valgrind was complaining when about this up in the userland simulator mode. Signed-off-by: Eric Anhol

[PATCH 2/2] drm/vc4: Add support for rendering with ETC1 textures.

2016-11-04 Thread Eric Anholt
nvert to RGBA8) Signed-off-by: Eric Anholt --- drivers/gpu/drm/vc4/vc4_drv.c | 1 + drivers/gpu/drm/vc4/vc4_validate.c | 7 +++ include/uapi/drm/vc4_drm.h | 1 + 3 files changed, 9 insertions(+) diff --git a/drivers/gpu/drm/vc4/vc4_drv.c b/drivers/gpu/drm/vc4/vc4_drv.c

[PATCH] drm/vc4: Use runtime autosuspend to avoid thrashing V3D power state.

2016-11-04 Thread Eric Anholt
g and readback (as may happen in X rendering). By keeping the device on until we've been idle for a couple of frames, we drop the overhead of runtime PM down to sub-.1%. Signed-off-by: Eric Anholt --- drivers/gpu/drm/vc4/vc4_drv.c | 9 ++--- drivers/gpu/drm/vc4/vc4_gem.c | 6 -- drive

Re: [PATCH 0/4] vc4 RST documentation

2017-02-28 Thread Eric Anholt
Daniel Vetter writes: > On Mon, Feb 27, 2017 at 12:11:40PM -0800, Eric Anholt wrote: >> danvet asked me a while ago to try generating documentation with the >> new RST-based infrastructure. I had a couple of hours to do some >> editing, so here it is. >> >

Re: [PATCH v3 2/7] mmc: bcm2835: Add new driver for the sdhost controller.

2017-03-01 Thread Eric Anholt
Gerd Hoffmann writes: > From: Eric Anholt > > The 2835 has two SD controllers: The Arasan sdhci controller (supported > by the iproc driver) and a custom sdhost controller. This patch adds a > driver for the latter. > > The sdhci controller supports both sdcard

[PATCH 1/2 RESEND] drm/vc4: Fulfill user BO creation requests from the kernel BO cache.

2017-03-01 Thread Eric Anholt
o be other system noise) Note that there's an intel-gpu-tools test to check for the proper zeroing behavior here, which we continue to pass. Signed-off-by: Eric Anholt --- drivers/gpu/drm/vc4/vc4_bo.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/driv

[PATCH 2/2 RESEND] drm/vc4: Fix OOPSes from trying to cache a partially constructed BO.

2017-03-01 Thread Eric Anholt
If a CMA allocation failed, the partially constructed BO would be unreferenced through the normal path, and we might choose to put it in the BO cache. If we then reused it before it expired from the cache, the kernel would OOPS. Signed-off-by: Eric Anholt Fixes: c826a6e10644 ("drm/vc4: Add

Re: [PATCH v3 2/7] mmc: bcm2835: Add new driver for the sdhost controller.

2017-03-01 Thread Eric Anholt
Stefan Wahren writes: >> Eric Anholt hat am 1. März 2017 um 19:00 geschrieben: >> >> >> Gerd Hoffmann writes: >> >> > From: Eric Anholt >> > >> > The 2835 has two SD controllers: The Arasan sdhci controller (supported >> >

[PATCH 2/2] MAINTAINERS: Remove Lee Jones from bcm2835.

2017-02-23 Thread Eric Anholt
Lee has been inactive on the linux-rpi-kernel mailing list for the last year. My thanks go to Lee for his past work in patch merging. Signed-off-by: Eric Anholt --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index acb0b002f925..af4f0099f20e 100644

[PATCH 1/2] MAINTAINERS: Add Stefan Wahren to bcm2835.

2017-02-23 Thread Eric Anholt
Stefan has been active on the platform since 2015, helping to polish drivers for upstreaming and providing review feedback to other contributors, along with doing new development. Signed-off-by: Eric Anholt --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b

Re: [PATCH] drm/vc4: Drop debug print at boot with DPI enabled.

2017-02-15 Thread Eric Anholt
Daniel Vetter writes: > On Wed, Feb 08, 2017 at 12:47:01PM -0800, Eric Anholt wrote: >> Unlike the other encoders in the driver, I've also dropped the debug >> dump function. There's only really one register to this device, and >> we have the debugfs reg entry st

[PATCH v2 1/3] dt-bindings: Document the dmas and dma-names properties for VC4 HDMI

2017-02-27 Thread Eric Anholt
From: Boris Brezillon These are optional, but necessary for HDMI audio support. Signed-off-by: Boris Brezillon Signed-off-by: Eric Anholt Acked-by: Rob Herring --- v2: no changes Documentation/devicetree/bindings/display/brcm,bcm-vc4.txt | 3 +++ 1 file changed, 3 insertions(+) diff

[PATCH v2 2/3] drm/vc4: Add HDMI audio support

2017-02-27 Thread Eric Anholt
having to significantly rework hdmi-codec, and it would have left little shared code with the I2S mode anyway. The encoder requires that the audio be SPDIF-formatted frames only, which alsalib will format-convert for us. This patch is the combined work of Eric Anholt (initial register setup with a

[PATCH v2 3/3] ARM: dts: bcm283x: Add HDMI audio related properties

2017-02-27 Thread Eric Anholt
From: Boris Brezillon Add the dmas and dma-names properties to support HDMI audio. Signed-off-by: Boris Brezillon Signed-off-by: Eric Anholt --- v2: no changes arch/arm/boot/dts/bcm283x.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/boot/dts/bcm283x.dtsi b/arch/arm

[PATCH 4/4] drm/vc4: Add a paragraph at the top of vc4 docs introducing what it is.

2017-02-27 Thread Eric Anholt
This makes for more sensible documentation of the whole module than jumping straight into the details of display. Signed-off-by: Eric Anholt --- Documentation/gpu/vc4.rst | 3 +++ drivers/gpu/drm/vc4/vc4_drv.c | 16 2 files changed, 19 insertions(+) diff --git a

[PATCH 1/4] drm/vc4: Convert existing documentation to actual kerneldoc.

2017-02-27 Thread Eric Anholt
I'm going to hook vc4 up to the sphinx build, so clean up its comments to not generate warnings when we do. Signed-off-by: Eric Anholt --- drivers/gpu/drm/vc4/vc4_bo.c | 5 - drivers/gpu/drm/vc4/vc4_dsi.c | 5 +++-- drivers/gpu/drm/vc4/vc4_gem.c

[PATCH 0/4] vc4 RST documentation

2017-02-27 Thread Eric Anholt
l to start including the current ones in the output. Eric Anholt (4): drm/vc4: Convert existing documentation to actual kerneldoc. drm/vc4: Add RST to bring together vc4 kerneldoc. drm/vc4: Extend and edit documentation for output from the RST drm/vc4: Add a paragraph at the top of vc4 docs i

[PATCH 3/4] drm/vc4: Extend and edit documentation for output from the RST

2017-02-27 Thread Eric Anholt
that I've taken this opportunity to extend. Signed-off-by: Eric Anholt --- drivers/gpu/drm/vc4/vc4_crtc.c | 7 --- drivers/gpu/drm/vc4/vc4_dpi.c | 3 ++- drivers/gpu/drm/vc4/vc4_hdmi.c | 23 --- drivers/gpu/drm/vc4/vc4_hvs.c

[PATCH 2/4] drm/vc4: Add RST to bring together vc4 kerneldoc.

2017-02-27 Thread Eric Anholt
This doesn't yet produce coherent documentation of the module, but at least gets the kerneldoc built and somewhat glued together. Signed-off-by: Eric Anholt --- Documentation/gpu/index.rst | 1 + Documentation/gpu/vc4.rst | 86 + 2 files ch

Re: [PATCH] staging: vc04_services: remove unused functions

2017-02-07 Thread Eric Anholt
Dan Carpenter writes: > There is a bunch of vc04_services that we're still looking to merge in > the near future. Please hold off deleting these until we are further > along on that. Checking the downstream tree, these are actually dead. signature.asc Description: PGP signature

[PATCH 1/3] dt-bindings: Document the dmas and dma-names properties for VC4 HDMI

2017-02-07 Thread Eric Anholt
From: Boris Brezillon These are optional, but necessary for HDMI audio support. Signed-off-by: Boris Brezillon Signed-off-by: Eric Anholt --- Documentation/devicetree/bindings/display/brcm,bcm-vc4.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devicetree/bindings

[PATCH 3/3] ARM: dts: bcm283x: Add HDMI audio related properties

2017-02-07 Thread Eric Anholt
From: Boris Brezillon Add the dmas and dma-names properties to support HDMI audio. Signed-off-by: Boris Brezillon Signed-off-by: Eric Anholt --- arch/arm/boot/dts/bcm283x.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/boot/dts/bcm283x.dtsi b/arch/arm/boot/dts

[PATCH 2/3] drm/vc4: Add HDMI audio support

2017-02-07 Thread Eric Anholt
having to significantly rework hdmi-codec, and it would have left little shared code with the I2S mode anyway. The encoder requires that the audio be SPDIF-formatted frames only, which alsalib will format-convert for us. This patch is the combined work of Eric Anholt (initial register setup with a

Re: [PATCH] drm/vc4: simplify exit path of a failed allocation of dsi_connector

2017-02-07 Thread Eric Anholt
Colin King writes: > From: Colin Ian King > > If dsi_connector fails to allocate, the exit path via label 'fail' > checks if connector is null, which it always is, so the cleanup > that destroys connector is never going to be called. Hence the > failure path can be more optimally performed by r

Re: [PATCH 3/5] drm: convert drivers to use of_graph_get_remote_node

2017-02-08 Thread Eric Anholt
us messages. Plus the kernel is not a > DT validator. For vc4, Tested-by: Eric Anholt Thanks for making this easier. signature.asc Description: PGP signature

<    4   5   6   7   8   9   10   11   12   13   >