Don't mix reiserfs and RAID5 in linux-2.4.1-pre8, severe corruption

2001-01-19 Thread Edward
Reiserfs in linux-2.4.1-pre8 does not properly with the RAID5 code that is in that kernel. It is easy to get corrupted filesystem on device in less than 1 minute. Please, do not use it (reiserfs) on RAID5 devices. We are trying to figure out what is wrong. Edward - To unsubscribe from this

Re: [PATCH] - filesystem corruption on soft RAID5 in 2.4.0+

2001-01-22 Thread Edward
ully functional one. Nevertheless this patch fixed reiserfs corruption.. Thanks. Edward. > > In any case, please apply, and let me know of any further problems. > > --- ./drivers/md/raid5.c2001/01/21 04:01:57 1.1 > +++ ./drivers/md/raid5.c

editing for that you need

2018-07-30 Thread Edward
Retouching Wedding Photo Editing Real Estate Photo Editing Photo Restoration We provide trials to evaluate our service quality to new clients. Thanks, Edward

Re: need help on a DEADLOCK problem related to function try_one_irq()

2012-11-27 Thread Edward Donovan
Yes, I will try to do that in the next couple days. Thanks - Ed On Mon, Nov 26, 2012 at 3:09 AM, Wang, Warner wrote: > Hi Thomas and Edward, > > This patch works fine for our problems, but I'm not sure if it works for the > recent submit "genirq: fix regressio

Re: need help on a DEADLOCK problem related to function try_one_irq()

2012-12-05 Thread Edward Donovan
I would happily ship one of these computers, with a reliably spurious interrupt, to Thomas in Germany. if that would help for testing. Thanks all - Ed On Mon, Nov 26, 2012 at 3:09 AM, Wang, Warner wrote: > Hi Thomas and Edward, > > This patch works fine for our problems, but I'm not

[PATCH] Trivial fix for ath9k dmesg typo.

2013-04-01 Thread Edward O'Callaghan
Signed-off-by: Edward O'Callaghan --- drivers/net/wireless/ath/ath9k/hw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath9k/hw.c b/drivers/net/wireless/ath/ath9k/hw.c index 07e2526..76da544 100644 --- a/drivers/net/wireless/ath/ath9k/hw.c

[PATCH] Build fix for ARM. The UAPI changes split kernel API and userspace API content onto two separate header files and assumed a full linux build. This trips up embedded builds.

2013-04-01 Thread Edward O'Callaghan
Signed-off-by: Edward O'Callaghan --- include/uapi/drm/drm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/uapi/drm/drm.h b/include/uapi/drm/drm.h index 8d1e2bb..73a99e4 100644 --- a/include/uapi/drm/drm.h +++ b/include/uapi/drm/drm.h @@ -36,7 +36,7 @@ #i

[Panic] skb problems in 2.4.5-pre3 (repeatable)

2001-05-18 Thread Tomlinson, Edward
Hi, This does not seem to be making it to the from my sympatico account... Is lkml blocking sympatico.ca? Hopefully outlook does not scramble it too badly. > I have had this happen three times. It seems to get trigged when > forwarding > from my internal networks to the internet via a pppoe

Re: how to use compression with reiser4

2005-07-08 Thread Edward Shishkin
special kind of regular files - so called cryptcompress objects. Unfortunately this is not for product using for a while, but benchmarks really show a speed gain for some conditions (if cpu is powerful, compression algorithm is fast, and data is compressible). Thanks, Edward. - To unsubscribe from

Re: [PATCH linux-2.6.13-rc3] SATA: rewritten sil24 driver

2005-08-02 Thread Edward Falk
Hi Tejun; I'm the guy at Google working on SATA drivers (port multipliers right now). As soon as I can (next week perhaps, I'll start looking at the driver you wrote. From what I can see, it looks quite good. + +static u8 sil24_check_status(struct ata_port *ap) +{ + return ATA_DRDY;

Re: [PATCH linux-2.6.13-rc3] SATA: rewritten sil24 driver

2005-08-04 Thread Edward Falk
I agree that above code should clear both. Just wanna verify. Have you tested it and/or do you have any information confirming this? If we don't have any further info, I think we should read PORT_SLOT_STAT before clearing PORT_IRQ_STAT to be on the safe side. I've implemented the clear_irq

Re: [RFC] [PATCH -mm] reiser4: replace uid==0 check with capability

2007-12-12 Thread Edward Shishkin
blocks. Replace the uid==0 check, which is not safe in the face of user namespaces, with a CAP_SYS_RESOURCE check, which seems appropriate. Agreed. Thanks, Edward. The per-uid and per-guid reservations appear unimplemented so I'm ignoring them. Signed-off-by: Serge Hallyn <[EMAIL PROT

[patch] reiser4: do not allocate struct file on stack

2007-10-04 Thread Edward Shishkin
Edward Shishkin wrote: Dave Hansen wrote: ... I think that stack allocation is a pretty nasty trick for a structure that's supposed to be pretty persistent and dynamically allocated, and is certainly something that needs to get fixed up in a proper way. agreed. This works aroun

[patch] reiserfs: do not repair wrong journal params

2007-10-04 Thread Edward Shishkin
fixes this badness. Thanks, Edward. When mounting a file system with wrong journal params do not try to repair them, suggest fsck instead. Signed-off-by: Edward Shishkin <[EMAIL PROTECTED]> --- linux-2.6.23-rc8-mm2/fs/reiserfs/journal.c | 100 - 1 files chang

Re: REISER4: Attention Edward Shishkin (reiser4progs-1.0.6)

2007-12-27 Thread Edward Shishkin
[EMAIL PROTECTED] wrote: REISER4: Attention Edward Shishkin (reiser4progs-1.0.6) - - Hi Edward, it has been pointed out that you CHANGED reiser4progs-1.0.6 in your version http://chichkin_i.zelnet.ru/namesys

Re: [patch 2/2] reiser4: new export ops

2007-11-28 Thread Edward Shishkin
these other files related to the export operations changes? So we have to define an "if" branch for wire_read_common() (plugin/file_plugin_common.c). The best place to do it is kassign.c (as we actually pack/extract key components). Plus a small change in dscale.c where a packing taxon

[patch 2/2] reiser4: new export ops

2007-11-27 Thread Edward Shishkin
s.c:284: error: unknown field 'get_dentry' specified in initializer fs/reiser4/export_ops.c:285: warning: excess elements in struct initializer fs/reiser4/export_ops.c:285: warning: (near initialization for 'reiser4_export_operations') help! done Thanks, Edward. Adjust

Re: 2.6.11-rc5-mm1

2005-03-01 Thread Edward Shishkin
athieu Segaud <[EMAIL PROTECTED]> Thanks for catching this. Edward. --- fs/reiser4/plugin/item/ctail.c 2005-03-01 14:57:52.756014040 +0100 +++ fs/reiser4/plugin/item/ctail.c.new 2005-03-01 14:57:19.791025480 +0100 @@

HPT370 driver problems

2001-06-23 Thread Edward Tandi
People, I have an IWill IDE Raid card with the Highpoint HPT370 Chip. I am running this on a Dual Processor board (800MHz PIIIs) with a Mandrake 8.0 Disrtibution (2.4.3 Kernel). 200MB of RAM and all slots filled with lots of cards. I was glad to see that Linux auto-detected the IDE/Raid card.

forestalling GNU incompatibility - proposal for binary relative dynamic linking

2005-01-24 Thread Edward Peschko
hey all, Forgive the crosspost in advance, but I had an idea that touched many areas, and would need input from multiple groups associated with the gnu build chain, and perhaps the kernel itself. After spending *two weeks* on various ways of building glibc, I'm convinced that the gnu/linux too

Re: forestalling GNU incompatibility - proposal for binary relative dynamic linking

2005-01-24 Thread Edward Peschko
On Mon, Jan 24, 2005 at 03:10:47PM -0800, Richard Henderson wrote: > On Mon, Jan 24, 2005 at 02:24:49PM -0800, Edward Peschko wrote: > > What I'd like to do is be able to set up my LD_LIBRARY_PATH > > so that I can reference it from the point of view of the > > *execut

Re: forestalling GNU incompatibility - proposal for binary relative dynamic linking

2005-01-24 Thread Edward Peschko
( ps - just to forestall a particular objection that was pointed out to me - simply use chroot - I don't want a chroot environment. I want to use both old binaries and new binaries seamlessly. Ed ) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

Re: forestalling GNU incompatibility - proposal for binary relative dynamic linking

2005-01-24 Thread Edward Peschko
On Mon, Jan 24, 2005 at 03:38:49PM -0800, Richard Henderson wrote: > On Mon, Jan 24, 2005 at 03:16:36PM -0800, Edward Peschko wrote: > > cool.. any chance for some syntactic sugar so me (and other > > users/vendors) wouldn't need to change any of their build scripts > >

Re: forestalling GNU incompatibility - proposal for binary relative dynamic linking

2005-01-24 Thread Edward Peschko
On Mon, Jan 24, 2005 at 06:08:52PM -0500, Mike Frysinger wrote: > On Monday 24 January 2005 05:24 pm, Edward Peschko wrote: > > After spending *two weeks* on various ways of building glibc, > > I'm convinced that the gnu/linux toolchain is in great danger of > &g

Re: 2.6.23-rc1-mm1: reiser4 <-> lzo compile error

2007-07-25 Thread Edward Shishkin
Adrian Bunk wrote: <-- snip --> ... LD .tmp_vmlinux1 lib/built-in.o: In function `lzo1x_1_compress': (.text+0x13eae): multiple definition of `lzo1x_1_compress' fs/built-in.o:(.text+0x117075): first defined here make[1]: *** [.tmp_vmlinux1] Error 1 <-- snip --> AFAIR, we once had a p

Re: 2.6.23-rc1-mm1: reiser4 <-> lzo compile error

2007-07-27 Thread Edward Shishkin
K, both, @m and @m_pos should be in [wrkmem, wrkmem + 64K); I have attached trace.txt with their actual values. Not ready to migrate to this library. Any ideas? Thanks, Edward. P.S. kernel: 2.6.23-rc1-mm1 box: x86 #include #include #include #include #include MODULE_LICENSE("GPL");

Removing the prism54 module

2007-07-28 Thread Edward Ando
n" before rmmod, but this does not help. If you have any hints or answers as to what I should do, that would be great. I think I have subscribed successfully to this mailing list, but any CCs to this address are also welcome. Thanks in advance, Yours, Edward Ando - To unsubscribe from this

Re: [PATCH] Reiser4: Drop 'size' argument from bio_endio and bi_end_io

2007-10-14 Thread Edward Shishkin
ze' argument is now redundant. Remove it. Now there is no need for bio_endio to subtract the size completed from bi_size. So don't do that either. While we are at it, change bi_end_io to return void. Please review. Thanks! Signed-Off-By: Edward Shishkin <

Re: linux-2.6.20-rc4-mm1 Reiser4 filesystem freeze and corruption

2007-01-19 Thread Edward Shishkin
Zan Lynx wrote: I have been running 2.6.20-rc2-mm1 without problems, but both rc3-mm1 and rc4-mm1 have been giving me these freezes. I didn't investigate it in details yet, other file systems also freeze for me: http://marc.theaimsgroup.com/?l=linux-kernel&m=116809282829254&w=2 They were

[PATCH 2.6.20] r8169.c: support RTL8169SC/8110SC

2007-02-08 Thread Edward Hsu
This patch is for /driver/net/r8169.c to support RTL8169SC/8110SC, which is a new Realtek Gigabit PCI Ethernet Controller. RTL8110SC's PCI DID is 0x8167, while RTL8110S and RTL8110SB share 0x8169. Signed-off-by: Edward Hsu <[EMAIL P

Re: linux-2.6.20-rc4-mm1 Reiser4 filesystem freeze and corruption

2007-02-01 Thread Edward Shishkin
] do_fsync+0x3d/0xe0 [ 3138.456930] [] sys_msync+0x143/0x1f0 [ 3138.456945] [] system_call+0x7e/0x83 This is waiting for IO completion, and no success because of new plugging policy introduced by block layer folks. The attached patch should help. Andrew, please apply. Thanks, Edward. Sig

Re: 2.6.20-rc3-mm1: umount reiser4 FS stuck in D state

2007-02-01 Thread Edward Shishkin
/sdb7). There is no md here, only dm. I applied the above patch on top of 2.6.20-rc4-mm1, but the problem still happens with the two devices. thanks Laurent, would you please try 2.6.20-rc6-mm3 + this patch: http://lkml.org/lkml/diff/2007/2/1/195/1 Thanks, Edward. - To unsubscribe from this list:

Re: 2.6.20-rc3-mm1: umount reiser4 FS stuck in D state

2007-02-01 Thread Edward Shishkin
Laurent Riffard wrote: Le 01.02.2007 21:04, Edward Shishkin a écrit : Laurent Riffard wrote: Le 23.01.2007 16:46, Jens Axboe a écrit : On Tue, Jan 23 2007, Vladimir V. Saveliev wrote: Hello On Saturday 13 January 2007 01:56, Laurent Riffard wrote: Le 06.01.2007 19:58, Vladimir V

Re: [PATCH] Introduce block I/O performance histograms

2006-11-16 Thread Edward Falk
Jens Axboe wrote: I don't see the point at all for including this piece of code in the kernel. You can do the same from user space. Your help entry said it even grows the kernel size about 21k, that's pretty nasty. How would you do this from user space? Also, the 21k increase is only in effe

Re: 2.6.22-rc6-mm1 reiser4_tree_by_page NULL pointer

2007-07-11 Thread Edward Shishkin
I have found the bug, which kills data when booting after crash, power loss, etc. The patch is attached. Please, ping me, if it doesn't help.. Thanks, Edward. Zan Lynx wrote: This bug is annoying enough that I mostly stopped using rc6-mm1, which is why it took this long to make a r

Re: [PATCH -mm] reiser4: remove lzo compression security hole

2007-05-28 Thread Edward Shishkin
0 +0100 +++ linux-2.6.21/fs/reiser4/plugin/compress/compress.c 2007-05-24 23:43:28.0 +0100 @@ -319,7 +319,7 @@ lzo1_decompress(coa_t coa, __u8 * src_fi assert("edward-851", coa == NULL); assert("edward-852", src_len != 0); - result = lzo1x_decompres

[patch 0/3] reiser4 fixups

2007-07-16 Thread Edward Shishkin
[] vfs_read+0xc5/0x180 [] sys_read+0x53/0x90 [] system_call+0x7e/0x83 This is bug in Zam's new file_read: unlocked page was reclaimed, then reiser4_tree_by_page() looks at page->mapping->host. The patch #3 fixes this problem. Andrew, please apply the following series. Thanks, Edw

[patch 1/3] reiser4: fix extent2tail

2007-07-16 Thread Edward Shishkin
Fixed bug in extent2tail conversion. Bug description: when converting partially converted file (with flag REISER4_PART_MIXED installed) reiser4_cut_tree() starts to cut old metatada from wrong offset. Result is data corruption. Signed-off-by: Edward Shishkin <[EMAIL PROTECTED]> ---

[patch 2/3] reiser4: fix read_tail

2007-07-16 Thread Edward Shishkin
Update hint when reading tails Signed-off-by: Edward Shishkin <[EMAIL PROTECTED]> --- linux-2.6.22-rc6-mm1/fs/reiser4/plugin/item/tail.c |2 +- 1 files changed, 1 insertion(+), 1 deletion(-) --- linux-2.6.22-rc6-mm1/fs/reiser4/plugin/item/tail.c.orig +++ linux-2.6.22-rc6-mm1/fs/r

[patch 3/3] reiser4: fix unix-file readpages filler

2007-07-16 Thread Edward Shishkin
Protect page (via incrementing page count) from being reclaimed when looking for extent pointer in unix-file specific readpages filler. Signed-off-by: Edward Shishkin <[EMAIL PROTECTED]> --- linux-2.6.22-rc6-mm1/fs/reiser4/plugin/file/file.c | 32 +++-- 1 files chang

Re: 2.6.22-rc3-mm1 reiser4 bug

2007-06-05 Thread Edward Shishkin
Hello. I looked at your long attachment. It seems, you have problems with hardware. Would you please check your root drive (sde) by badblocks program? Thanks, Edward. Berck E. Nash wrote: All appears to work fine, until I try to boot a kernel with a Reiser4 / partition. Then I get endless

Re: 2.6.22-rc1-mm1

2007-05-18 Thread Edward Shishkin
7;m not sure whether thats acceptable in filesystem code, I'd suspect not? Ok, we will consider safe decompression, moreover, as I remember, it doesn't lead to sensible performance drop.. Thanks for this point, Edward. Fixing it is a case of s/lzo1x_decompress(/lzo1x_decompress_

Reiser4: Transparent compression support. Further development and compatibility.

2007-03-14 Thread Edward Shishkin
l. Reiserfs team. Appendix D. Devoted to resolving backward compatibility problems in Reiser4. Directed to file system developers and anyone with an interest in Reiser4 and plugin architecture. Reiser4 file system: development, versions and compatibility. Edward Sh

Re: 2.6.21-rc4-mm1

2007-03-21 Thread Edward Shishkin
Andrew Morton wrote: On Tue, 20 Mar 2007 17:23:54 -0600 Zan Lynx <[EMAIL PROTECTED]> wrote: On Mon, 2007-03-19 at 20:56 -0800, Andrew Morton wrote: Temporarily at http://userweb.kernel.org/~akpm/2.6.21-rc4-mm1/ Will appear later at ftp://ftp.kernel.org/pub/linux/kernel/people/ak

Re: REISER4: fix for reiser4_write_extent

2007-04-07 Thread Edward Shishkin
patch by Edward Shishkin that should address that issue, but it is missing from -mm tree. Please check. Max This patch was added to -mm tree the 14 Dec 2006 (see http://www.mail-archive.com/mm-commits@vger.kernel.org/msg05338.html). It was then dropped from -mm tree the 05 Mar 2007 (see

Re: HDIO_* ioctls

2007-04-11 Thread Edward Falk
Uytterhoeven, Geert wrote: Hi, Documentation/ioctl/hdio.txt says: | This document attempts to describe the ioctl(2) calls supported by | the HD/IDE layer. These are by-and-large implemented (as of Linux 2.6) | in drivers/ide/ide.c and drivers/block/scsi_ioctl.c However, drivers/block/s

Re: Question about Reiser4

2007-04-24 Thread Edward Shishkin
g tail's support (which makes things complicated) as special incremental update available on our website). Thanks, Edward. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: Question about Reiser4

2007-04-25 Thread Edward Shishkin
ce. Well, gentlemen, so we'll address other items (except #26, 27) and resume this discussion. Thanks, Edward. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/maj

Re: Question about Reiser4

2007-04-25 Thread Edward Shishkin
.. Would you please change direction of your activity to stressing instead of benchmarking? Caught oopses would have great value.. OK? Regards, Edward. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo inf

Re: [Fwd: reiser4 bugs in 2.6.21-rc4]

2007-03-27 Thread Edward Shishkin
codes are vs-1426 and nikita-2688. A patch was posted on namesys list to address this problem, but it didn't help. Kernel: 2.6.21-rc4 with manually applied reiser4 patches from -mm. Arch: x86-64 We are working on this. Thanks for reports, Edward. - To unsubscribe from this list: send

[PATCH] staging: sm750fb: Fix block comment style

2016-07-23 Thread Edward Lipinsky
This patch fixes the checkpatch.pl warning: WARNING: Block comments use * on subsequent lines Signed-off-by: Edward Lipinsky --- drivers/staging/sm750fb/ddk750_dvi.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_dvi.c b/drivers

Re: [PATCH] ptp_clock: future-proofing drivers against PTP subsystem becoming optional

2016-09-21 Thread Edward Cree
; + INIT_WORK(&ptp->pps_work, efx_ptp_pps_worker); > + ptp->pps_workwq = > create_singlethread_workqueue("sfc_pps"); > + if (!ptp->pps_workwq) { > + rc = -ENOMEM; > + goto fail4; > + } > } > } > ptp->nic_ts_enabled = false; For the sfc change: Acked-by: Edward Cree

Re: [PATCH 1/4] drm/amd/powerplay: mark symbols static where possible

2016-09-25 Thread Edward O'Callaghan
This series is, Reviewed-by: Edward O'Callaghan On 09/25/2016 06:19 PM, Baoyou Xie wrote: > We get a few warnings when building kernel with W=1: > drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/cz_hwmgr.c:69:10: warning: no > previous prototype for 'cz_get_eclk_level

[PATCH] staging: vt6656: Fix block comment style

2016-07-30 Thread Edward Lipinsky
This patch fixes the checkpatch.pl warnings: WARNING: Block comments use * on subsequent lines WARNING: Block comments use a trailing */ on a separate line Signed-off-by: Edward Lipinsky --- drivers/staging/vt6656/card.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git

Re: [PATCH v8 00/15] Introduce support for Dell SMBIOS over WMI

2017-10-15 Thread Edward O'Callaghan
I like how this series turned out and I think it puts us in a exceedingly better position than the dcdbas path. This series is, Reviewed-by: Edward O'Callaghan On Sat, Oct 14, 2017 at 4:32 PM, Mario Limonciello wrote: > The existing way that the dell-smbios helper module and associated

Re: [PATCH v11 14/15] platform/x86: dell-smbios-wmi: introduce userspace interface

2017-10-31 Thread Edward O'Callaghan
ens are now shared out to userspace so > applications don't need to define them in their own headers. > > Signed-off-by: Mario Limonciello > Reviewed-by: Edward O'Callaghan > --- > Documentation/ABI/testing/dell-smbios-wmi | 41 > driver

Re: [PATCH v12 01/16] platform/x86: dell-smbios: Prefix class/select with cmd_

2017-11-01 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan On Thu, Nov 2, 2017 at 6:25 AM, Mario Limonciello wrote: > Later on these structures will be brought up to userspace. > the word "class" is a reserved word in c++ and this will prevent > uapi headers from being included directly in c++ pr

Re: [PATCH v12 14/16] platform/x86: wmi: create userspace interface for drivers

2017-11-01 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan On Thu, Nov 2, 2017 at 6:25 AM, Mario Limonciello wrote: > For WMI operations that are only Set or Query readable and writable sysfs > attributes created by WMI vendor drivers or the bus driver makes sense. > > For other WMI operations that

Re: [PATCH v9 17/17] tools/wmi: add a sample for dell smbios communication over WMI

2017-10-17 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan On Wed, Oct 18, 2017 at 5:22 AM, Mario Limonciello wrote: > This application uses the character device /dev/wmi/dell-smbios > to perform SMBIOS communications from userspace. > > It offers demonstrations of a few simple tasks: > - Running a

Re: [PATCH v9 17/17] tools/wmi: add a sample for dell smbios communication over WMI

2017-10-18 Thread Edward O'Callaghan
Just my 2c, I like this simplification Mario. Reviewed-by: Edward O'Callaghan On Thu, Oct 19, 2017 at 9:27 AM, wrote: >> -Original Message- >> From: Limonciello, Mario >> Sent: Wednesday, October 18, 2017 8:56 AM >> To: 'Pali Rohár' ; Greg KH ; A

Re: [PATCH net-next 1/2] docs: Add rest label the_canonical_path_format

2018-07-25 Thread Edward Cree
On 25/07/18 03:50, Tobin C. Harding wrote: > In preparation to convert Documentation/network/netdev-FAQ.rst to > restructured text format we would like to be able to reference 'the > canonical patch format' section. > > Add rest label: 'the_canonical_path_format'. Here and in the Subject, 'patch' i

Re: [PATCH] bpf, doc: Correct one wrong value in "Register value tracking"

2018-01-24 Thread Edward Cree
ed by conditional > branches. For instance, if a SCALAR_VALUE is compared > 8, in the 'true' > branch Acked-by: Edward Cree

Re: [RFC PATCH net-next] sfc: efx_default_channel_want_txqs() can be static

2018-01-26 Thread Edward Cree
On 26/01/18 01:03, kbuild test robot wrote: > Fixes: 2935e3c38228 ("sfc: on 8000 series use TX queues for TX timestamps") > Signed-off-by: Fengguang Wu Acked-by: Edward Cree Dave, can you take this directly or do you need it reposted without RFC tags?  I'm not sure what

[PATCH net-next] sfc: mark some unexported symbols as static

2018-01-26 Thread Edward Cree
t;) Signed-off-by: Fengguang Wu [ec...@solarflare.com: rewrote commit message] Signed-off-by: Edward Cree --- drivers/net/ethernet/sfc/efx.c | 2 +- drivers/net/ethernet/sfc/ptp.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/sfc/efx.c b/drivers/ne

Re: [PATCH] kernel:bpf Remove structure passing and assignment to save stack and no coping structures

2018-01-16 Thread Edward Cree
On 13/01/18 22:03, Karim Eshapa wrote: > Use pointers to structure as arguments to function instead of coping > structures and less stack size. Also transfer TNUM(_v, _m) to > tnum.h file to be used in differnet files for creating anonymous structures > statically. > > Signed-off-by: Karim Eshapa

Re: [PATCH net-next] modules: allow modprobe load regular elf binaries

2018-03-12 Thread Edward Cree
On 09/03/18 18:58, Alexei Starovoitov wrote: > It's not waiting for the whole thing, because once bpfilter starts it > stays running/sleeping because it's stateful. So, this has been bugging me a bit. If bpfilter takes a signal and crashes, all that state goes away. Does that mean your iptables/net

[PATCH] usb: serial: option: add HP LT4220 support

2018-04-10 Thread Edward Chang
This patch adds support for HP LT4220 Signed-off-by: Edward Chang --- drivers/usb/serial/option.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c index c3f2522..d866cc0 100644 --- a/drivers/usb/serial/option.c +++ b/drivers/usb

[PATCH bpf] bpf: fix off-by-one error in adjust_subprog_starts

2018-11-16 Thread Edward Cree
e syz reproducer). Fixes: cc8b0b92a169 ("bpf: introduce function calls (function boundaries)") Reported-by: syzbot+4fc427c7af994b094...@syzkaller.appspotmail.com Signed-off-by: Edward Cree --- I'm assuming I don't need to get a Signed-off-by from syzkaller to use its reproducer

Re: [PATCH v2 0/4] Static calls

2018-12-07 Thread Edward Cree
Sorry if this has been pointed out before (it's a very long thread), but in the out-of-line implementation, it appears that static_call_update() never alters key->func. Am I right in thinking that this should be fixed by adding 'WRITE_ONCE(key->func, func);' just after the call to arch_static_

Re: [PATCH v2 0/4] Static calls

2018-12-07 Thread Edward Cree
On 07/12/18 16:06, Edward Cree wrote: > Sorry if this has been pointed out before (it's a very long thread), but > in the out-of-line implementation, it appears that static_call_update() > never alters key->func. Am I right in thinking that this should be > fixed by ad

Re: [PATCH v2 0/4] Static calls

2018-12-12 Thread Edward Cree
On 12/12/18 05:59, Nadav Amit wrote: > Thanks for cc’ing me. (I didn’t know about the other patch-sets.) Well in my case, that's because I haven't posted any yet.  (Will follow up  shortly with what I currently have, though it's not pretty.) Looking at your patches, it seems you've got a much more

[RFC/WIP PATCH 0/2] dynamic calls

2018-12-12 Thread Edward Cree
saw was with dynamic calls present). Edward Cree (2): static_call: fix out-of-line static call implementation net: core: rather hacky PoC implementation of dynamic calls include/linux/static_call.h | 6 +- net/core/dev.c | 222 +++- 2 fi

[RFC PATCH 1/2] static_call: fix out-of-line static call implementation

2018-12-12 Thread Edward Cree
Actually call __static_call_update() from static_call_update(), and fix the former so it can actually compile. Also make it update key.func. Signed-off-by: Edward Cree --- include/linux/static_call.h | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/include/linux

[RFC PATCH 2/2] net: core: rather hacky PoC implementation of dynamic calls

2018-12-12 Thread Edward Cree
t it right; this is sad. It's also full of printk()s right now to display what it's doing for debugging purposes; obviously those wouldn't be quite the same in a finished version. Signed-off-by: Edward Cree --- net/core/dev.c | 222

Re: [PATCH v2 0/4] Static calls

2018-12-12 Thread Edward Cree
On 12/12/18 18:14, Nadav Amit wrote: > Second, (2i) is not very intuitive for me. Using the out-of-line static > calls seems to me as less performant than the inline (potentially, I didn’t > check). > > Anyhow, the use of out-of-line static calls seems to me as > counter-intuitive. I think (didn’t

Re: [PATCH 6/7] selftest/bpf: remove redundant parenthesis

2018-12-12 Thread Edward Cree
On 12/12/18 19:04, Jakub Kicinski wrote: > On Tue, 11 Dec 2018 20:56:06 +0900, Alice Ferrazzi wrote: >> Signed-off-by: Alice Ferrazzi >> --- >> tools/testing/selftests/bpf/test_offload.py | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/tools/testing/selftests/bpf/test_

Re: [PATCH v2 0/4] Static calls

2018-12-12 Thread Edward Cree
On 12/12/18 21:15, Nadav Amit wrote: >> On Dec 12, 2018, at 10:33 AM, Edward Cree wrote: >> >> AIUI the outline version uses a tail-call (i.e. jmpq *target) rather than an >> additional call and ret. So I wouldn't expect it to be too expensive. >> More to the

Re: Business Proposal

2018-10-29 Thread Edward Yuan
Dear Friend, My name is Mr. Edward Yuan, a consultant/broker. I know you might be a bit apprehensive because you do not know me. Nevertheless, I have a proposal on behalf of a client, a lucrative business that might be of mutual benefit to you. If interested in this proposition please

Re: Reiser4 Linux 4.17.19-1 hangs in Google cloud VM, too.

2018-10-22 Thread Edward Shishkin
a look at this.. Thanks, Edward. That link you referenced is just my hack for the corresponding Debian kernel packaging (wrapper) to build 'Reiser4 the Debian Way', i.e, generating reiser4 module & kernel -- suitable for installation media -- in addition to Debian's. Er...

[PATCH RESEND] selftests/futex: Order calls in futex_requeue

2024-09-03 Thread Edward Liaw
0 not ok 3 futex_requeue many returned: 0 not ok 4 futex_requeue many returned: 0 Instead, replace the sleep with barriers to make the sequencing explicit. Fixes: 7cb5dd8e2c8c ("selftests: futex: Add futex compare requeue test") Reviewed-by: Muhammad Usama Anjum Signed-off-by: Edward Liaw

Re: [reiser4 SFRN 5.1.3] kernel [5.10.x] read not supported for file /test-exec \(pid: 10094 comm: debootstrap\)

2021-02-16 Thread Edward Shishkin
On 02/16/2021 04:56 PM, Jose R Rodriguez wrote: On Mon, 2021-02-08 at 17:03 +0100, Edward Shishkin wrote: On 02/08/2021 01:54 PM, Metztli Information Technology wrote: On Wed, Dec 23, 2020 at 3:40 PM Edward Shishkin < edward.shish...@gmail.com> wrote: On 12/23/2020 05:01 PM, M

Re: 2.6.23-rc8-mm2 NULL dereference in __mnt_is_readonly in ftruncate

2007-09-28 Thread Edward Shishkin
581,7 @@ static int truncate_file_body(struct ino file.private_data = NULL; file.f_pos = new_size; file.private_data = NULL; + file.f_vfsmnt = NULL; uf_info = unix_file_inode_data(inode); result = find_file_state(i

[PATCH] Staging: rtl8723au: hal: Remove trailing whitespace in odm.c

2015-04-18 Thread Edward Lipinsky
This patch fixes the checkpatch.pl error: ERROR: trailing whitespace Signed-off-by: Edward Lipinsky --- drivers/staging/rtl8723au/hal/odm.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723au/hal/odm.c b/drivers/staging/rtl8723au/hal/odm.c index

Re: [PATCH] ethernet/sfc: mark state UNINIT after unregister

2015-06-15 Thread Edward Cree
On 12/06/15 19:51, Jarod Wilson wrote: > Without this change, modprobe -r sfc hits the BUG_ON() in > efx_pci_remove_main(). Best as I can tell, this was just an oversight, > efx->state gets set to STATE_UNINIT in the error path of > efx_register_netdev() just after unregister_netdevice(), and the s

Re: [PATCH] net: vxge: fix spelling mistake in macro VXGE_HW_ERR_PRIVILAGED_OPEARATION

2018-05-22 Thread Edward Cree
On 22/05/18 16:36, Colin King wrote: > From: Colin Ian King > > Rename VXGE_HW_ERR_PRIVILAGED_OPEARATION to VXGE_HW_ERR_PRIVILAGED_OPERATION > to fix spelling mistake. > > Signed-off-by: Colin Ian King "Privilaged" doesn't look right either, maybe fix both at once?  -> VXGE_HW_PRIVILEGED_OPERATIO

Travelers List

2018-05-22 Thread Edward Hanks
unlimited multi-channel marketing. Let me know if you'd be interested in hearing more about it. Waiting for your valuable and sincere reply. Best Regards, Edward Hanks Business Development & Data Specialist

Re: [PATCH] ethtool: fix a potential missing-check bug

2018-04-30 Thread Edward Cree
On 30/04/18 02:31, Wenwen Wang wrote: > In ethtool_get_rxnfc(), the object "info" is firstly copied from > user-space. If the FLOW_RSS flag is set in the member field flow_type of > "info" (and cmd is ETHTOOL_GRXFH), info needs to be copied again from > user-space because FLOW_RSS is newer and has

Re: [PATCH] drivers: net: ethernet: sun: Fix couple of spells in the file sunhme.c

2021-02-08 Thread Edward Cree
On 05/02/2021 12:47, Bhaskar Chowdhury wrote: > > > s/fuck/mess/ > s/fucking/s/ > > Signed-off-by: Bhaskar Chowdhury Right or wrong, these are not "spelling fixes". Please do not misrepresent your patch in your Subject: line. (Also, subsystem prefix should probably just be "net: sunhme:".)

Re: [reiser4 SFRN 5.1.3] kernel [5.10.x] read not supported for file /test-exec \(pid: 10094 comm: debootstrap\)

2021-02-08 Thread Edward Shishkin
On 02/08/2021 01:54 PM, Metztli Information Technology wrote: On Wed, Dec 23, 2020 at 3:40 PM Edward Shishkin wrote: On 12/23/2020 05:01 PM, Metztli Information Technology wrote: Niltze [Ð—Ð´Ñ€Ð°Ð²Ñ Ñ‚Ð²ÑƒÐ¹Ñ‚Ðµ : Hello], Ed- I built Linux kernel 5.10.1-1 within the 'Debian way&#

REPLY ME URGENTLY

2021-02-08 Thread Elizabeth Edward
final wish before I die. I am Mrs. Elizabeth Edward, 63 years, from USA, I am childless and I am suffering from a pro-long critical cancer, my doctors confirmed I may not live beyond two months from now as my ill health has defiled all forms of medical treatment. Since my days are numbered, I have

Re: [ANNOUNCE] Reiser5: Data Tiering. Burst Buffers. Speedup synchronous modifications

2020-05-31 Thread Edward Shishkin
On 05/30/2020 02:32 PM, jose@metztli.com wrote: On Mon, May 25, 2020 at 6:08 PM Edward Shishkin wrote: Reiser5: Data Tiering. Burst Buffers Speedup synchronous modifications Dumping peaks of IO load to a proxy device Now you can

Re: [ANNOUNCE] Reiser5: Data Tiering. Burst Buffers. Speedup synchronous modifications

2020-05-31 Thread Edward Shishkin
*/ ... Currently it works as if all files are "cold" (i.e. migrates everything). Once I find the current stuff more-or-less stable I'll add temperature support and send the patch. Thanks, Edward.

Re: [linux-next:master 13398/13940] drivers/net/ethernet/sfc/ef100_nic.c:610: undefined reference to `__umoddi3'

2020-08-11 Thread Edward Cree
On 10/08/2020 16:51, Guenter Roeck wrote: > On Thu, Aug 06, 2020 at 07:17:43PM +0100, Edward Cree wrote: >> Maybe I should add a >> >> static inline u32 mod_u64(u64 dividend, u32 divisor) >> { >>     return do_div(dividend, divisor); >> } > Your

Re: PROBLEM: IO lockup on reiserfs FS.

2020-08-05 Thread Edward Shishkin
If any problems (including partition check/repair) - send a message to reiserfs-devel mailing list. (*) https://reiser4.wiki.kernel.org/index.php/Reiser4_Howto https://sourceforge.net/projects/reiser4/files/ (**) https://sourceforge.net/projects/reiser4/files/reiser4-utils/ (***) https://marc.info/?l=reiserfs-devel&m=158086248927420&w=2 Thanks, Edward.

Re: [linux-next:master 13398/13940] drivers/net/ethernet/sfc/ef100_nic.c:610: undefined reference to `__umoddi3'

2020-08-06 Thread Edward Cree
On 06/08/2020 00:48, kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git > master > head: d15fe4ec043588beee823781602ddb51d0bc84c8 > commit: adcfc3482813fa2c34e5902005853f79c2aa [13398/13940] sfc_ef100: > read Design Parameters at probe tim

Re: [PATCH net-next 0/5] skbuff: introduce skbuff_heads bulking and reusing

2021-01-12 Thread Edward Cree
Without wishing to weigh in on whether this caching is a good idea... Wouldn't it be simpler, rather than having two separate "alloc" and "flush" caches, to have a single larger cache, such that whenever it becomes full we bulk flush the top half, and when it's empty we bulk alloc the bottom hal

Re: [reiser4 SFRN 5.1.3] kernel [5.10.x] read not supported for file /test-exec \(pid: 10094 comm: debootstrap\)

2020-12-23 Thread Edward Shishkin
00] sdb: sdb1 sdb2 sdb3 [ 511.973360] sdb: sdb1 sdb2 sdb3 [ 627.525371] Adding 9765884k swap on /dev/sda3. Priority:-2 extents:1 across:9765884k FS [ 636.240812] reiser4[mount(9430)]: reiser4_register_subvol (fs/reiser4/init_volume.c:222)[edward-1932]: [ 636.240812] NOTICE: brick /dev/sda6 h

Re: [PATCH 10/11] pragma once: delete few backslashes

2021-03-04 Thread Edward Cree
On 28/02/2021 17:05, Alexey Dobriyan wrote: > From 251ca5673886b5bb0a42004944290b9d2b267a4a Mon Sep 17 00:00:00 2001 > From: Alexey Dobriyan > Date: Fri, 19 Feb 2021 13:37:24 +0300 > Subject: [PATCH 10/11] pragma once: delete few backslashes > > Some macros contain one backslash too many and end

Re: [PATCH v2] block: fix trace completion for chained bio

2021-03-16 Thread Edward Hsieh
Hi Jens and Neil, Is there any feedback on this patch? Thank you, Edward Hsieh On 3/3/2021 11:22 AM, Edward Hsieh wrote: From: Edward Hsieh For chained bio, trace_block_bio_complete in bio_endio is currently called only by the parent bio once upon all chained bio completed. However, the

REPLY ME URGENTLY

2021-04-01 Thread Elizabeth Edward
final wish before I die. I am Mrs. Elizabeth Edward, 63 years, from USA, I am childless and I am suffering from a pro-long critical cancer, my doctors confirmed I may not live beyond two months from now as my ill health has defiled all forms of medical treatment. Since my days are numbered, I’ve

  1   2   3   4   >