Re: [PATCH] thermal: ti-soc-thermal: remove dead code

2018-07-04 Thread Eduardo Valentin
On Tue, Jul 03, 2018 at 10:40:25AM +0530, Keerthy wrote: > > > On Monday 02 July 2018 10:00 PM, Eduardo Valentin wrote: > > Keerthy, > > > > On Fri, Jun 29, 2018 at 06:10:26PM +0200, Bartlomiej Zolnierkiewicz wrote: > >> > >> Hi, > >>

[GIT PULL] Thermal-SoC management updates for v4.19-rc1

2018-08-16 Thread Eduardo Valentin
-kernelci/kernel/v4.18-rc3-34-g84b64de597bc/ BR, Eduardo Valentin Amit Kucheria (8): thermal: tsens: Get rid of unused fields in structure dt: thermal: tsens: Document the fallback DT property for v2 of TSENS IP

Re: [PATCH] thermal: armada: fix incorrect check for drvdata allocation failure

2018-08-20 Thread Eduardo Valentin
hello Colin, On Mon, Jul 30, 2018 at 01:27:16PM +0100, Colin King wrote: > From: Colin Ian King > > Currently the drvdata allocation failure is being incorrectly checked by > checking priv and not drvdata. Fix this and also free priv to fix a > memory leak. > > Detected by Coverity Scan, CID#1

[GIT PULL] Thermal-SoC management fixes for v4.20-rc7

2018-12-13 Thread Eduardo Valentin
Hello Linus, Consider pulling the following changes since commit 40e020c129cfc991e8ab4736d2665351ffd1468d: Linux 4.20-rc6 (2018-12-09 15:31:00 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/evalenti/linux-soc-thermal fixes for you to fetch cha

Re: [PATCH v6 0/4] Fixes for Tegra soctherm

2018-12-18 Thread Eduardo Valentin
On Tue, Dec 18, 2018 at 11:35:54AM +0800, Zhang Rui wrote: > On 五, 2018-12-14 at 17:54 +0800, Wei Ni wrote: > > Hi Rui, > > I moved get_trend() patch https://lkml.org/lkml/2018/11/20/643 in > > this > > serial. > > Since no more comments on these patches, will you take them? > > > I think Eduardo

Re: [PATCH v6 3/4] thermal: tegra: parse sensor id before sensor register

2018-12-18 Thread Eduardo Valentin
On Fri, Dec 14, 2018 at 05:49:52PM +0800, Wei Ni wrote: > Since different platforms may not support all 4 > sensors, so the sensor registration may be failed. > Add codes to parse dt to find sensor id which > need to be registered. So that the registration > can be successful on all platform. > >

Re: [PATCH v6 3/4] thermal: tegra: parse sensor id before sensor register

2018-12-19 Thread Eduardo Valentin
On Wed, Dec 19, 2018 at 11:00:10AM +0800, Wei Ni wrote: > > > On 19/12/2018 9:24 AM, Eduardo Valentin wrote: > > On Fri, Dec 14, 2018 at 05:49:52PM +0800, Wei Ni wrote: > >> Since different platforms may not support all 4 > >> sensors, so the sensor registration

Re: [PATCH] thermal: stm32: read factory settings inside stm_thermal_prepare

2018-12-14 Thread Eduardo Valentin
On Thu, Dec 06, 2018 at 01:23:32PM +, David HERNANDEZ SANCHEZ wrote: > Calling stm_thermal_read_factory_settings before clocking > internal peripheral causes bad register values and makes > temperature computation wrong. > > Calling stm_thermal_read_factory_settings inside > stm_thermal_prep

Re: [PATCH 2/3] arm64: tegra: Add thermal zones on Tegra194

2018-12-15 Thread Eduardo Valentin
On Fri, Nov 23, 2018 at 01:18:38PM +0100, Thierry Reding wrote: > From: Thierry Reding > > The NVIDIA Tegra194 SoC defines six thermal zones. Define all of them in > device tree. > > Signed-off-by: Thierry Reding Acked-by: Eduardo Valentin The patch 1 I added i

Re: [PATCH 3/3] arm64: tegra: p2972: Enable the CPU, GPU and AUX thermal zones

2018-12-15 Thread Eduardo Valentin
On Fri, Nov 23, 2018 at 01:18:39PM +0100, Thierry Reding wrote: > From: Thierry Reding > > Enable these thermal zones to be able to monitor their temperatures and > control the fan to cool down the system if necessary. > > Signed-off-by: Thierry Reding Acked-by: Edu

[GIT PULL] Thermal-SoC management updates for v4.21-rc1

2019-01-01 Thread Eduardo Valentin
Hello Linus, Please consider pulling from git://git.kernel.org/pub/scm/linux/kernel/git/evalenti/linux-soc-thermal linus to receive Thermal-SoC Management updates for v4.21-rc1 with top-most 055ddb633a35845f106fb732a07c90862e0a43e5: thermal: generic-adc: Fix adc to temp interpolation (2018

Re: [PATCH v5 0/3] Stingray thermal driver support

2019-01-01 Thread Eduardo Valentin
On Tue, Jan 01, 2019 at 10:04:39PM +0800, Zhang Rui wrote: > On 一, 2018-12-31 at 14:15 -0800, Florian Fainelli wrote: > > > > On 04/12/2018 19:17, Srinath Mannam wrote: > > > > > > Hi, > > > > > > Could you please provide your feedback to this patch series? > > Rui or Eduardo can we get either o

Re: [GIT PULL] Thermal-SoC management updates for v4.21-rc1

2019-01-01 Thread Eduardo Valentin
On Tue, Jan 01, 2019 at 01:35:36PM -0800, Linus Torvalds wrote: > On Tue, Jan 1, 2019 at 8:05 AM Eduardo Valentin wrote: > > > > Please consider pulling from > > > > git://git.kernel.org/pub/scm/linux/kernel/git/evalenti/linux-soc-thermal > > linus >

Re: [GIT PULL] Thermal-SoC management updates for v4.21-rc1

2019-01-01 Thread Eduardo Valentin
On Tue, Jan 01, 2019 at 03:32:50PM -0800, Linus Torvalds wrote: > On Tue, Jan 1, 2019 at 3:16 PM Eduardo Valentin wrote: > > > > > It doesn't even build cleanly. > > > > > > > Do you still have have a copy of the build error? > > A plain "ma

Re: [PATCH v2 2/2] mmc: sdhci-omap: Workaround errata regarding SDR104/HS200 tuning failures (i929)

2019-01-02 Thread Eduardo Valentin
On Wed, Jan 02, 2019 at 10:29:31AM -0800, Olof Johansson wrote: > Hi, > > > On Wed, Dec 12, 2018 at 1:20 AM Ulf Hansson wrote: > > > > + Thermal maintainers > > > > On Tue, 11 Dec 2018 at 15:20, Faiz Abbas wrote: > > > > > > Errata i929 in certain OMAP5/DRA7XX/AM57XX silicon revisions > > > (SP

Re: [PATCH v5 2/3] thermal: broadcom: Add Stingray thermal driver

2019-01-02 Thread Eduardo Valentin
On Tue, Oct 16, 2018 at 08:41:19PM +0530, Srinath Mannam wrote: > From: Pramod Kumar > > Stingray SoC has six temperature sensor and those are > configured, controlled and accessed to read temperature > and update in DDR memory using m0 firmware. > All six sensors has been given 4 bytes of memory

[GIT PULL v2] Thermal-SoC management updates for v4.21-rc1

2019-01-02 Thread Eduardo Valentin
dc to temp interpolation Eduardo Valentin (1): thermal: hwmon: inline helpers when CONFIG_THERMAL_HWMON is not set Fabrizio Castro (2): dt-bindings: thermal: rcar-thermal: add R8A774C0 support thermal: rcar_thermal: add R8A774C0 support Geert Uytterhoeven (1): dt-bindings: thermal:

Re: [PATCH V5 2/4] thermal: imx_sc: add i.MX system controller thermal support

2018-12-25 Thread Eduardo Valentin
On Thu, Dec 20, 2018 at 09:08:32AM +, Anson Huang wrote: > i.MX8QXP is an ARMv8 SoC which has a Cortex-M4 system controller > inside, the system controller is in charge of controlling power, > clock and thermal sensors etc.. > > This patch adds i.MX system controller thermal driver support, >

Re: [PATCH v2 00/17] thermal: enable+check sensor after its setup is finished

2018-11-05 Thread Eduardo Valentin
Hey, On Mon, Nov 05, 2018 at 05:35:55PM +0100, Bartlomiej Zolnierkiewicz wrote: > > On 11/05/2018 04:04 AM, Zhang Rui wrote: > > Hi, Bartlomiej, > > Hi Rui, > > > Interesting, I'm about to bring this issue to Linux Plumber Conference > > this year for discussion, and I'm also proposing a soluti

[GIT PULL] Thermal-SoC management updates for v4.20-rc1

2018-10-26 Thread Eduardo Valentin
, da9062/61 Bot results: Full Boot Summary: https://kernelci.org/boot/all/job/evalenti/branch/for-kernelci/kernel/v4.18-10762-g760eea43f8c6/ Full Build Summary: https://kernelci.org/build/evalenti/branch/for-kernelci/kernel/v4.18-10762-g760eea43f8c6/ BR, Eduardo Valentin

Re: [PATCH v3 1/5] thermal: of: Extend of-thermal.c to provide number of trip points

2014-12-08 Thread Eduardo Valentin
On Mon, Dec 08, 2014 at 06:04:17PM +0100, Lukasz Majewski wrote: > This patch extends the of-thermal.c to provide information about number of > available trip points. > > Signed-off-by: Lukasz Majewski > --- > Changes for v3: > - Exporting of_thermal_get_ntrips symbol as a GPL > - Fix build error

Re: [PATCH v3 0/5] thermal: of: of-thermal.c API extensions

2014-12-08 Thread Eduardo Valentin
On Mon, Dec 08, 2014 at 06:04:16PM +0100, Lukasz Majewski wrote: > Provided patch series extend of-thermal.c file API. It is necessary > for ongoing Exynos TMU rework. > > First version of this code can be found at: > http://www.spinics.net/lists/linux-samsung-soc/msg37719.html > > Second versio

[GIT PULL] thermal-soc management updates for v3.19 #3

2014-12-09 Thread Eduardo Valentin
kml/2014/12/8/704 BR, ---- Eduardo Valentin (1): thermal: cpu_cooling: check for the readiness of cpufreq layer Lukasz Majewski (1): thermal:core:fix: Check return code of the ->get_max_state() callback Viresh Kumar (25

[GIT PULL] thermal-soc management updates for v3.19 #2

2014-12-09 Thread Eduardo Valentin
already implemented in thermal core. BR, Eduardo Valentin Lukasz Majewski (5): thermal: of: Extend of-thermal.c to provide number of trip points thermal: of: Extend of-thermal.c to provide check if trip point is valid

Re: [RFC PATCH v6 6/9] thermal: cpu_cooling: implement the power cooling device API

2015-01-02 Thread Eduardo Valentin
Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello Javi, Looks like the charset seams to be scrambled. Anyways, I will attempt to send a couple of feedback here.. On Tue, Dec 09, 2014 at 11:00:43AM +, Javi Merino wrote: >

Re: [RFC PATCH v6 7/9] thermal: introduce the Power Allocator governor

2015-01-02 Thread Eduardo Valentin
o > control. It decides how much power to give each cooling device based > on the performance they are requesting. The PID controller ensures > that the total power budget does not exceed the control temperature. > > Cc: Zhang Rui > Cc: Eduardo Valentin > Signed-off-by: Pu

Re: [RFC PATCH v6 7/9] thermal: introduce the Power Allocator governor

2015-01-02 Thread Eduardo Valentin
Forgot to mention On Fri, Dec 05, 2014 at 07:04:18PM +, Javi Merino wrote: > + > +If you are using device tree, do add it as a property of the > +thermal-zone. For example: > + > + thermal-zones { > + soc_thermal { > + polling-delay = <1000>; > +

Re: [RFC PATCH v6 9/9] of: thermal: Introduce sustainable power for a thermal zone

2015-01-02 Thread Eduardo Valentin
d associated with the thermal > zone via the thermal zone parameters. > > Cc: Zhang Rui > Cc: Eduardo Valentin > Signed-off-by: Punit Agrawal > --- > Documentation/devicetree/bindings/thermal/thermal.txt | 4 > drivers/thermal/of-thermal.c

Re: [PATCH v2 2/8] thermal: Provide stub for thermal_cdev_update() function

2015-01-02 Thread Eduardo Valentin
On Mon, Dec 22, 2014 at 05:27:42PM +0100, Lukasz Majewski wrote: > Odroid U3 fan can work without being registered as OF cooling device > (with CONFIG_THERMAL_OF disabled). > In this situation it can be controlled via PWM entry at > /sys/class/hwmon/hwmon0/pwm1. > > Therefore, the thermal_cdev_upd

Re: [PATCH v2 3/8] hwmon: dts: Doc: Add DTS doc to explain how to use PWM FAN as a cooling device

2015-01-02 Thread Eduardo Valentin
On Mon, Dec 22, 2014 at 05:27:43PM +0100, Lukasz Majewski wrote: > Several new properties to allow PWM fan working as a cooling device have been > combined into this single commit. > Patch prefix should look something like 'dt-bindings: ...', or better 'Documentation: devicetree: ...', or 'Docume

Re: [PATCH v2 1/8] thermal: Provide stub for thermal_of_cooling_device_register() function

2015-01-02 Thread Eduardo Valentin
gt; Therefore, the thermal_of_cooling_device_register() function needs a stub > to allow clean compilation. > > Signed-off-by: Lukasz Majewski Acked-by: Eduardo Valentin > --- > Changes for v2: > - None > --- > include/linux/thermal.h | 14 +++--- > 1 file changed, 11 in

Re: [PATCH v2 5/8] hwmon: thermal: dts: Add properties to use pwm-fan device as a cooling device in Odroid U3

2015-01-02 Thread Eduardo Valentin
Patch subject should use a prefix like: 'arm: dts:' On Mon, Dec 22, 2014 at 05:27:45PM +0100, Lukasz Majewski wrote: > With those bindings it is possible to use pwm-fan device available in > Odroid U3 as a cooling device. > > Signed-off-by: Lukasz Majewski > --- > Changes for v2: > - Rename

Re: [PATCH v2 1/8] thermal: Provide stub for thermal_of_cooling_device_register() function

2015-01-02 Thread Eduardo Valentin
On Fri, Jan 02, 2015 at 02:54:28PM -0400, Eduardo Valentin wrote: > On Mon, Dec 22, 2014 at 05:27:41PM +0100, Lukasz Majewski wrote: > > Odroid U3 fan can work without being registered as OF cooling device > > (with CONFIG_THERMAL_OF disabled). > > In this situation it can

Re: [PATCH] ti-soc-thermal: implement eocz bit to make driver useful on omap3

2015-01-03 Thread Eduardo Valentin
On Sat, Jan 03, 2015 at 12:46:32PM +0100, Pavel Machek wrote: > For omap3, proper implementation of eocz bit is needed. It was > actually a TODO in the driver. > > When periodic mode is not enabled, it is neccessary to force reads. > > Signed-off-by: Pavel Machek > > diff --git a/drivers/therma

Re: [PATCH] thermal: add omap3 support

2015-01-03 Thread Eduardo Valentin
Hello Pavel, Thanks for sending your code. On Sat, Jan 03, 2015 at 12:11:46PM +0100, Pavel Machek wrote: > Add support for omap3430 sensor. Tested on Nokia N900. To my understanding, and as already mentioned by Nishanth Menon (currently TIer), TI has intentionally avoided adding this support. T

Re: [PATCH] Thermal: imx: add clk disable/enable for suspend/resume

2015-01-05 Thread Eduardo Valentin
Hello, On Mon, Jan 05, 2015 at 10:34:11PM +0530, Pankaj Jangra wrote: > Hi Anson, > > On Mon, Jan 5, 2015 at 7:59 PM, Anson Huang wrote: > > > Thermal sensor's clk is from pll3_usb_otg, per hardware > > design requirement, need to make sure pll3_usb_otg is disabled > > before STOP mode is enter

Re: [PATCH] thermal: of: Remove bogus type qualifier for of_thermal_get_trip_points()

2015-01-05 Thread Eduardo Valentin
On Sat, Jan 03, 2015 at 10:56:56PM +0100, Geert Uytterhoeven wrote: > With gcc 4.1.2, 4.2, and 4.2.4 (4.4 and later are OK): > > drivers/thermal/thermal_core.h:110: warning: type qualifiers ignored on > function return type > > Signed-off-by: Geert Uytterhoeven > Fixes: ce8be7785922de0e ("therm

Re: [RFC PATCH v6 6/9] thermal: cpu_cooling: implement the power cooling device API

2015-01-05 Thread Eduardo Valentin
Javi, On Mon, Jan 05, 2015 at 04:53:40PM +, Javi Merino wrote: > On Fri, Jan 02, 2015 at 02:37:23PM +0000, Eduardo Valentin wrote: > > Content-Type: text/plain; charset=us-ascii > > Content-Disposition: inline > > Content-Transfer-Encoding: quoted-printable > > >

Re: [RFC PATCH v6 5/9] thermal: extend the cooling device API to include power information

2015-01-05 Thread Eduardo Valentin
Javi, On Mon, Jan 05, 2015 at 03:37:10PM +, Javi Merino wrote: > On Tue, Dec 23, 2014 at 03:14:11PM +0000, Eduardo Valentin wrote: > > Hi Javi > > > > On Fri, Dec 05, 2014 at 07:04:16PM +, Javi Merino wrote: > > > Add three optional callbacks to the coo

Re: [PATCH] thermal: ti-soc-thermal: ti-bandgap.c: Remove unused function

2015-01-05 Thread Eduardo Valentin
On Wed, Dec 24, 2014 at 08:57:14AM -0600, Nishanth Menon wrote: > On 12/21/2014 11:43 AM, Rickard Strandqvist wrote: > > Remove the function ti_bandgap_write_thot() that is not used anywhere. > > > > This was partially found by using a static code analysis program called > > cppcheck. > > > > Si

Re: [PATCH] ti-soc-thermal: implement eocz bit to make driver useful on omap3

2015-01-05 Thread Eduardo Valentin
On Sat, Jan 03, 2015 at 05:22:42PM +0100, Pavel Machek wrote: > Hi! > > > > When periodic mode is not enabled, it is neccessary to force reads. > > > > > > Signed-off-by: Pavel Machek > > > > > > > --- a/drivers/thermal/ti-soc-thermal/ti-bandgap.c > > > +++ b/drivers/thermal/ti-soc-thermal/ti-

Re: [PATCH] thermal: add omap3 support

2015-01-05 Thread Eduardo Valentin
On Sat, Jan 03, 2015 at 11:02:19PM +0100, Pavel Machek wrote: > Hi! > > > Thanks for sending your code. > > You are welcome. > > > > Add support for omap3430 sensor. Tested on Nokia N900. > > > > To my understanding, and as already mentioned by Nishanth Menon > > (currently TIer), TI has intent

Re: [PATCH] MAINTAINERS: Add linux-omap to list of reviewers for TI Thermal

2015-01-05 Thread Eduardo Valentin
diff --git a/MAINTAINERS b/MAINTAINERS > index ddb9ac8..dc9efd5 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -9533,6 +9533,7 @@ F: drivers/platform/x86/thinkpad_acpi.c > TI BANDGAP AND THERMAL DRIVER > M: Eduardo Valentin > L: linux...@vger.kernel.org > +L:

Re: [PATCH] MAINTAINERS: Add linux-omap to list of reviewers for TI Thermal

2015-01-05 Thread Eduardo Valentin
On Mon, Jan 05, 2015 at 05:44:38PM -0400, Eduardo Valentin wrote: > On Sat, Jan 03, 2015 at 01:13:30PM -0600, Nishanth Menon wrote: > > Add linux-omap mailing list to the TI THERMAL list for wider review. > > > > Reported-by: Pavel Machek > > Si

Re: [RFC PATCH v6 5/9] thermal: extend the cooling device API to include power information

2015-01-06 Thread Eduardo Valentin
On Tue, Jan 06, 2015 at 10:34:31AM +, Javi Merino wrote: > Hi Eduardo, > > On Mon, Jan 05, 2015 at 09:04:09PM +, Eduardo Valentin wrote: > > On Mon, Jan 05, 2015 at 03:37:10PM +, Javi Merino wrote: > > > On Tue, Dec 23, 2014 at 03:14:11PM +, Eduardo Valenti

Re: [RFC PATCH v6 9/9] of: thermal: Introduce sustainable power for a thermal zone

2015-01-06 Thread Eduardo Valentin
On Tue, Jan 06, 2015 at 09:42:15AM +, Javi Merino wrote: > On Fri, Jan 02, 2015 at 03:53:00PM +0000, Eduardo Valentin wrote: > > On Fri, Dec 05, 2014 at 07:04:20PM +, Javi Merino wrote: > > > From: Punit Agrawal > > > > > > Introduce an optional prope

Re: [PATCH 2/4] ARM: tegra: Move out nyan-generic parts out from the nyan-big DT

2015-01-06 Thread Eduardo Valentin
On Tue, Jan 06, 2015 at 11:37:27AM +0100, Tomeu Vizoso wrote: > In preparation for adding the DT for the nyan-blaze board. > > Signed-off-by: Tomeu Vizoso For the (small part of the) thermal sensor: Acked-by: Eduardo Valentin > --- > arch/arm/boot/dts/tegra124-nyan

Re: [PATCH V2] Thermal: imx: add clk disable/enable for suspend/resume

2015-01-06 Thread Eduardo Valentin
On Tue, Jan 06, 2015 at 06:50:22PM +0800, Anson Huang wrote: > Thermal sensor's clk is from pll3_usb_otg, per hardware > design requirement, need to make sure pll3_usb_otg is disabled > before STOP mode is entered, otherwise, all PFDs under it may > enter incorrect state, this patch disables pll3_u

Re: [RFC PATCH v6 7/9] thermal: introduce the Power Allocator governor

2015-01-06 Thread Eduardo Valentin
On Tue, Jan 06, 2015 at 01:23:42PM +, Javi Merino wrote: > Hi Eduardo, > > On Fri, Jan 02, 2015 at 03:46:24PM +, Eduardo Valentin wrote: > > On Fri, Dec 05, 2014 at 07:04:18PM +, Javi Merino wrote: > > > The power allocator governor is a thermal governor that c

Re: [PATCH V2 01/26] thermal: cpu_cooling: check for the readiness of cpufreq layer

2014-12-04 Thread Eduardo Valentin
On Thu, Dec 04, 2014 at 09:41:43AM +0530, Viresh Kumar wrote: > From: Eduardo Valentin > > In this patch, the cpu_cooling code checks for the usability of cpufreq > layer before proceeding with the CPU cooling device registration. The > main reason is: CPU cooling device i

Re: [RFC PATCH v6 5/9] thermal: extend the cooling device API to include power information

2014-12-23 Thread Eduardo Valentin
. > > Cc: Zhang Rui > Cc: Eduardo Valentin > Signed-off-by: Javi Merino > --- > Documentation/thermal/power_allocator.txt | 27 ++ > drivers/thermal/thermal_core.c| 38 > +++ > include/linux/thermal.h

Re: [PATCH v2 2/8] thermal: Provide stub for thermal_cdev_update() function

2015-01-14 Thread Eduardo Valentin
ERMAL subsystem (and such configuration is perfectly > valid). OK. Now I understand. Then, please resend this one using CONFIG_THERMAL. Thanks, Eduardo Valentin > > > > > > > > > Signed-off-by: Lukasz Majewski > > > --- > > > Changes for v2: &

Re: [PATCH v2 1/8] thermal: Provide stub for thermal_of_cooling_device_register() function

2015-01-14 Thread Eduardo Valentin
On Wed, Jan 14, 2015 at 04:01:06PM +0100, Lukasz Majewski wrote: > Hi Eduardo, > > > On Fri, Jan 02, 2015 at 02:54:28PM -0400, Eduardo Valentin wrote: > > > On Mon, Dec 22, 2014 at 05:27:41PM +0100, Lukasz Majewski wrote: > > > > Odroid U3 fan can work witho

Re: [PATCH V2] (gpio-fan): Add thermal control hooks

2015-01-09 Thread Eduardo Valentin
Nishanth Menon For the thermal part: Acked-by: Eduardo Valentin > --- > > Changes since v1: > - review comments incorporated (hopefully correct) > - checkpatch verified > - retested :). > > V1: https://patchwork.kernel.org/patch/5587061/ &g

Re: [PATCH] thermal: Fix examples in DT documentation

2015-01-27 Thread Eduardo Valentin
Hello Srinivas, On Tue, Jan 27, 2015 at 10:50:47AM +, Srinivas Kandagatla wrote: > There are various issues with the examples in this documentation, some > of the DT labels are invalid and one of the macro THERMAL_NO_LIMITS > referenced is not available as well. > > As Its highly likely that

Re: [PATCH v1 3/7] thermal: cpu_cooling: implement the power cooling device API

2015-01-28 Thread Eduardo Valentin
d their OPPs using the OPP library. > > Cc: Zhang Rui > Cc: Eduardo Valentin > Signed-off-by: Punit Agrawal > Signed-off-by: Javi Merino > --- > Documentation/thermal/cpu-cooling-api.txt | 156 +- > drivers/thermal/cpu_cooling.c | 480 >

Re: [PATCH v4 1/2] dts: Documentation: Add documentation for Exynos7 SoC thermal bindings

2015-01-28 Thread Eduardo Valentin
On Wed, Jan 28, 2015 at 04:21:49PM +0530, Abhilash Kesavan wrote: > Hi Eduardo, > > On Tue, Jan 27, 2015 at 11:18 AM, Abhilash Kesavan > wrote: > > Add documentation for exynos7 thermal bindings including compatible > > name and special clock properties. > > > > Signed-off-by: Abhilash Kesavan >

Re: [RFC PATCH v6 6/9] thermal: cpu_cooling: implement the power cooling device API

2015-01-28 Thread Eduardo Valentin
must have > registered their OPPs using the OPP library. > > Cc: Zhang Rui > Cc: Eduardo Valentin > Signed-off-by: Punit Agrawal > Signed-off-by: Javi Merino > + > +/** > + * get_load() - get load for a cpu since last updated > + * @cpufreq_device: &struct cpu

Re: [PATCH 3/3] ARM: dts: am57xx-beagle-x15: Add thermal map

2015-03-20 Thread Eduardo Valentin
> Signed-off-by: Nishanth Menon Acked-by: Eduardo Valentin > --- > arch/arm/boot/dts/am57xx-beagle-x15.dts | 49 > +++ > 1 file changed, 49 insertions(+) > > diff --git a/arch/arm/boot/dts/am57xx-beagle-x15.dts > b/arch/arm/boot/dts

Re: [PATCH 2/3] ARM: dts: DRA7: Add bandgap and related thermal nodes

2015-03-20 Thread Eduardo Valentin
by: Keerthy > Signed-off-by: Nishanth Menon Acked-by: Eduardo Valentin > --- > arch/arm/boot/dts/dra7.dtsi | 12 > arch/arm/boot/dts/dra72x.dtsi |9 + > arch/arm/boot/dts/dra74x.dtsi |9 + > 3 files changed, 30 insertions(+) > &g

Re: [PATCH 1/3] ARM: dts: OMAP5+: separate the cpu thermal zone definition from omap4

2015-03-20 Thread Eduardo Valentin
On Fri, Mar 20, 2015 at 02:47:39PM -0500, Nishanth Menon wrote: > From: Tero Kristo > > OMAP4 has a finer counter granularity, which allows for a delay of 1000ms > in the thermal zone polling intervals. OMAP5/DRA7 have different counter > mechanism, which allows at maximum a 500ms timer. Adjust t

Re: [PATCH 01/13] thermal: Make temperatures consistently unsigned long

2015-04-06 Thread Eduardo Valentin
On Thu, Mar 26, 2015 at 04:53:48PM +0100, Sascha Hauer wrote: > The thermal framework uses int, long and unsigned long for temperatures > in millicelsius. The majority of functions uses unsigned long, so change > the remaining functions to use this type aswell. I believe it make sense to change al

Re: [PATCH 01/13] thermal: Make temperatures consistently unsigned long

2015-04-06 Thread Eduardo Valentin
On Fri, Mar 27, 2015 at 08:07:50PM +0100, Sascha Hauer wrote: > On Fri, Mar 27, 2015 at 10:18:14AM +, Punit Agrawal wrote: > > Hi Sascha, > > > > Sascha Hauer writes: > > > > > The thermal framework uses int, long and unsigned long for temperatures > > > in millicelsius. The majority of func

Re: [PATCH 02/13] thermal: trivial: fix typo in comment

2015-04-06 Thread Eduardo Valentin
On Thu, Mar 26, 2015 at 04:53:49PM +0100, Sascha Hauer wrote: > Signed-off-by: Sascha Hauer Acked-by: Eduardo Valentin > --- > drivers/thermal/thermal_core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/thermal/thermal_core.c

Re: [PATCH 04/13] thermal: Fix not emulating critical temperatures

2015-04-06 Thread Eduardo Valentin
On Fri, Mar 27, 2015 at 06:23:18AM +0100, Sascha Hauer wrote: > Hi Amit, > > On Fri, Mar 27, 2015 at 08:35:50AM +0530, amit daniel kachhap wrote: > > Hi Sascha, > > > > > -#ifdef CONFIG_THERMAL_EMULATION > > > - if (!tz->emul_temperature) > > > - goto skip_emul; > > > - > > >

Re: [PATCH 05/13] thermal: inline only once used function

2015-04-06 Thread Eduardo Valentin
On Thu, Mar 26, 2015 at 04:53:52PM +0100, Sascha Hauer wrote: > Inline update_temperature into its only caller to make the code > more readable. I am not sure I understand how this is improving readability, can you please elaborate? The way it is now it is more modular at least. > > Signed-off-

Re: [PATCH 07/13] thermal: of: streamline .get_temp callbacks

2015-04-06 Thread Eduardo Valentin
On Thu, Mar 26, 2015 at 04:53:54PM +0100, Sascha Hauer wrote: > In the thermal framework it was decided that temperatures can't > be negative, so let the .get_temp callback in struct > thermal_zone_of_device_ops take an unsigned long pointer for > the temperature like the .get_temp callback in > st

Re: [PATCH 12/13] thermal: Add support for hardware-tracked trip points

2015-04-06 Thread Eduardo Valentin
On Thu, Mar 26, 2015 at 04:53:59PM +0100, Sascha Hauer wrote: > This adds support for hardware-tracked trip points to the device tree > thermal sensor framework. > > The framework supports an arbitrary number of trip points. Whenever > the current temperature is updated, the trip points immediatel

Re: [PATCH 13/13] thermal: of: implement .set_trips for device tree thermal zones

2015-04-06 Thread Eduardo Valentin
On Thu, Mar 26, 2015 at 04:54:00PM +0100, Sascha Hauer wrote: > Signed-off-by: Sascha Hauer > --- > drivers/thermal/of-thermal.c | 12 > include/linux/thermal.h | 1 + > 2 files changed, 13 insertions(+) Can you please include at least one user of this call back in your patch

Re: [PATCH 03/13] thermal: remove useless call to thermal_zone_device_set_polling

2015-04-06 Thread Eduardo Valentin
;t been scheduled this > is a no-op. Remove it. > > Signed-off-by: Sascha Hauer This seams reasonable to me: Acked-by: Eduardo Valentin > --- > drivers/thermal/thermal_core.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/thermal/thermal_core.c

Re: [PATCH 06/13] thermal: streamline get_trend callbacks

2015-04-06 Thread Eduardo Valentin
On Thu, Mar 26, 2015 at 04:53:53PM +0100, Sascha Hauer wrote: > The .get_trend callback in struct thermal_zone_device_ops has the prototype: > > int (*get_trend) (struct thermal_zone_device *, int, > enum thermal_trend *); > > whereas the .get_trend callback in struc

Re: [PATCH 09/13] thermal: of: always set sensor related callbacks

2015-04-06 Thread Eduardo Valentin
On Thu, Mar 26, 2015 at 04:53:56PM +0100, Sascha Hauer wrote: > Now that the thermal core treats -ENOSYS like the callbacks were > not present at all we no longer have to overwrite the ops during > runtime but instead can always set them and return -ENOSYS if no > sensor is registered. > > Signed-

Re: [PATCH 11/13] thermal: of: make of_thermal_ops const

2015-04-06 Thread Eduardo Valentin
On Thu, Mar 26, 2015 at 04:53:58PM +0100, Sascha Hauer wrote: > Now that we no longer modify the ops they can be const again. Also > we no longer have to duplicate them. > > Signed-off-by: Sascha Hauer Should this one be merged to patch 09/13? > --- > drivers/thermal/of-thermal.c | 18 +++-

Re: [PATCH 10/13] thermal: Make struct thermal_zone_device_ops const

2015-04-06 Thread Eduardo Valentin
On Thu, Mar 26, 2015 at 04:53:57PM +0100, Sascha Hauer wrote: > Now that the of thermal support no longer changes the > thermal_zone_device_ops it can be const again. > > Signed-off-by: Sascha Hauer > --- > drivers/thermal/thermal_core.c | 2 +- > include/linux/thermal.h| 6 +++--- I bel

Re: [PATCH v2 1/2] dt-bindings: Document the hi6220 thermal sensor bindings

2015-04-06 Thread Eduardo Valentin
On Tue, Apr 07, 2015 at 11:46:22AM +0800, Xinwei Kong wrote: > > > On 2015/4/6 22:03, Matt Porter wrote: > > On Tue, Mar 31, 2015 at 02:59:21PM +0800, Xinwei Kong wrote: > >> From: kongxinwei > >> > >> This adds documentation of device tree bindings for the > >> thermal sensor controller of hi62

Re: [GIT PULL] Thermal-SoC management updates for v4.1-rc1

2015-04-27 Thread Eduardo Valentin
Javi, On Mon, Apr 27, 2015 at 09:35:36AM +0100, Javi Merino wrote: > On Wed, Apr 15, 2015 at 06:48:20AM +0100, Eduardo Valentin wrote: > > Hello Rui, > > > > Please pull from > > > > git://git.kernel.org/pub/scm/linux/kernel/git/evalenti/linux-soc-therm

Re: [PATCHv2] ti-soc-thermal: implement omap3 support

2015-04-07 Thread Eduardo Valentin
On Thu, Apr 02, 2015 at 04:49:07PM +0200, Pavel Machek wrote: > > > This adds support for OMAP3 chips to ti-soc-thermal. As requested by > TI people, it is marked unreliable and warning is printed. > > Signed-off-by: Pavel Machek > > --- > > Patch is against thermal linus tree, please apply s

Re: [PATCHv2] ti-soc-thermal: implement omap3 support

2015-04-07 Thread Eduardo Valentin
Hi Pavel, On Thu, Apr 02, 2015 at 04:49:07PM +0200, Pavel Machek wrote: > > > This adds support for OMAP3 chips to ti-soc-thermal. As requested by > TI people, it is marked unreliable and warning is printed. > > Signed-off-by: Pavel Machek > > --- > > Patch is against thermal linus tree, ple

[PATCH 1/1] drivers: thermal: st: remove several sparse warnings

2015-04-07 Thread Eduardo Valentin
Signed-off-by: Eduardo Valentin --- drivers/thermal/st/st_thermal.c| 2 +- drivers/thermal/st/st_thermal_memmap.c | 8 drivers/thermal/st/st_thermal_syscfg.c | 12 ++-- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/thermal/st/st_thermal.c b

Re: [RFP] LPC thermal track

2015-04-28 Thread Eduardo Valentin
Hello all, On Tue, Apr 28, 2015 at 10:24:15PM -0700, Eduardo Valentin wrote: > Hello folks, > > On Thu, Mar 26, 2015 at 08:02:49PM -0400, Eduardo Valentin wrote: > > Hello all, > > > > I've created a proposal for a thermal microconference track on the LPC > &

Re: [GIT PULL] Samsung Thermal for v4.1 merge window

2015-04-09 Thread Eduardo Valentin
Lukasz, On Thu, Apr 09, 2015 at 06:09:17PM +0200, Lukasz Majewski wrote: > Dear Eduardo, > > Please find my pull request for Samsung Thermal targeting v4.1 merge > window. > > The following changes since commit > 96d927aa14deb1c4bf6bfd758776ad942463865d: > > thermal: cpu_cooling: Fix power ca

[GIT PULL] Last minutes thermal-SoC management updates for v4.0

2015-04-11 Thread Eduardo Valentin
er returns -EAGAIN. Note: I am sending this pull on Rui's behalf while he fixes issues in his Linux box. BR, Eduardo Valentin -------- Eduardo Valentin (1): drivers: thermal: st: remove several sparse warnings Fabian Frederick (1)

[GIT PULL] Thermal-SoC management updates for v4.2-rc1

2015-06-09 Thread Eduardo Valentin
. BR, Eduardo Valentin Chanwoo Choi (1): thermal: exynos: Add the support for Exynos5433 TMU Eduardo Valentin (2): thermal: support slope and offset coefficients thermal: of-thermal: add support for reading

Re: [GIT PULL] Thermal management updates for v4.17-rc2

2018-04-26 Thread Eduardo Valentin
Hey Rui, On Tue, Apr 24, 2018 at 09:25:45PM +0800, Zhang Rui wrote: > Hi, Eduardo, > > On 五, 2018-04-20 at 09:18 -0700, Eduardo Valentin wrote: > > Hello Linus, > > > > Here are a couple of fixes on thermal subsystem. > > Please consider pulling from > &

Re: [PATCH 1/3] thermal: armada_thermal: Replace mdelay with usleep_range in armada370_init_sensor

2018-04-26 Thread Eduardo Valentin
Hey Jia-Ju, On Tue, Apr 10, 2018 at 04:13:02PM +0800, Jia-Ju Bai wrote: > armada370_init_sensor() is never called in atomic context. > > armada370_init_sensor() is set as ".init_sensor" in > struct armada_thermal_data. > ".init_sensor" is called armada_thermal_probe(). > armada_thermal_probe() i

Re: [PATCH 2/3] thermal: armada_thermal: Replace mdelay with msleep in armada375_init_sensor

2018-04-26 Thread Eduardo Valentin
On Tue, Apr 10, 2018 at 04:13:16PM +0800, Jia-Ju Bai wrote: > armada375_init_sensor() is never called in atomic context. > > armada375_init_sensor() is set as ".init_sensor" in > struct armada_thermal_data. > ".init_sensor" is called armada_thermal_probe(). > armada_thermal_probe() is set as ".pro

Re: [PATCH 3/3] thermal: armada_thermal: Replace mdelay with usleep_range in armada380_init_sensor

2018-04-26 Thread Eduardo Valentin
On Tue, Apr 10, 2018 at 04:13:28PM +0800, Jia-Ju Bai wrote: > armada380_init_sensor() is never called in atomic context. > > armada380_init_sensor() is set as ".init_sensor" in > struct armada_thermal_data. > ".init_sensor" is called armada_thermal_probe(). > armada_thermal_probe() is set as ".pro

[GIT PULL] Thermal SoC management updates for v4.17-rc3

2018-04-27 Thread Eduardo Valentin
Hello Rui, Please consider pulling these fixes on Thermal SoC management for v4.17-rc3. This has only a couple of fixes on exynos driver that were causing emergency shutdown. Here is what kernelci has to say about it: Full Boot Summary: https://kernelci.org/boot/all/job/evalenti/branch/for-ker

Re: [PATCH V5 2/4] thermal: imx_sc: add i.MX system controller thermal support

2019-02-05 Thread Eduardo Valentin
On Tue, Jan 22, 2019 at 06:54:30AM +, Anson Huang wrote: > Hi, Eduardo > > Best Regards! > Anson Huang Taking a look > > > -Original Message- > > From: Anson Huang > > Sent: 2019年1月10日 17:28 > > To: 'Eduardo Valentin' >

Re: [PATCH V5 2/4] thermal: imx_sc: add i.MX system controller thermal support

2019-02-05 Thread Eduardo Valentin
On Tue, Jan 22, 2019 at 06:54:30AM +, Anson Huang wrote: > Hi, Eduardo > > Best Regards! > Anson Huang > > > -Original Message- > > From: Anson Huang > > Sent: 2019年1月10日 17:28 > > To: 'Eduardo Valentin' > > Cc: 'robh

Re: [PATCH v1 0/2] thermal: trivial fixes to error messages

2019-02-05 Thread Eduardo Valentin
On Mon, Jan 21, 2019 at 03:12:21PM +0530, Amit Kucheria wrote: > Fix up a couple of error messages > > Amit Kucheria (2): > thermal: of-thermal: Print name of device node with error > thermal: cpu_cooling: Clarify error message > > drivers/thermal/cpu_cooling.c | 2 +- > drivers/thermal/of-t

Re: [PATCH v6 0/3] Stingray thermal driver support

2019-02-05 Thread Eduardo Valentin
; These patches adds the stingray thermal driver and its > > corresponding DT nodes with documentation. > > > > Changes from v5 > > - Addressed Eduardo Valentin comments. > > > > Changes from v4 > > - Addressed Rob Herring comments on DT parameter

Re: [PATCH v3 1/1] arm64: dts: sdm845: wireup the thermal trip points to cpufreq

2019-02-05 Thread Eduardo Valentin
tle clusters. > > We throttle lightly at the first trip point, just removing the boost > frequency. At the next trip point we allow ourselves to be throttled to > any extent. > >From OF thermal descriptor, this patch looks fine to me: Acked-by: Eduardo Valentin > Signed-off

Re: [PATCH 3/7] thermal: mediatek: add calibration item

2019-02-05 Thread Eduardo Valentin
On Mon, Feb 04, 2019 at 06:31:41PM +0100, Matthias Brugger wrote: > > > On 01/02/2019 08:38, michael@mediatek.com wrote: > > From: Michael Kao > > > > Add calibration item in thermal_data to support > > the project with different calibration coefficient. > > > > Signed-off-by: Michael Kao

Re: [PATCH 4/7] thermal: mediatek: add thermal controller offset

2019-02-05 Thread Eduardo Valentin
On Fri, Feb 01, 2019 at 03:38:10PM +0800, michael@mediatek.com wrote: > From: Michael Kao > > One thermal controller can read four sensors at most, > so we need to add controller_offset for the project with > more than four sensors to reuse the same register settings. > > Signed-off-by: Mich

[PATCHv2 3/7] arm: dts: dra7: add bandgap entry

2013-11-06 Thread Eduardo Valentin
This patch adds bandgap IP entry on DRA7 dtsi device tree file. Signed-off-by: Eduardo Valentin --- arch/arm/boot/dts/dra7.dtsi | 12 1 file changed, 12 insertions(+) --- Hi all, Difference from V1: now the BG node belongs to OCP. Tero, this is the patch you were asking for

Re: [PATCHv9 02/20] thermal: introduce device tree parser

2014-01-07 Thread Eduardo Valentin
ote: >> On 11/13/2013 03:46 AM, Eduardo Valentin wrote: >>> This patch introduces a device tree bindings for >>> describing the hardware thermal behavior and limits. >>> Also a parser to read and interpret the data and feed >>> it in the thermal framework is

Re: [PATCH] hwmon/sensors: fix SENSORS_LM75 dependencies

2014-01-07 Thread Eduardo Valentin
.orig/drivers/hwmon/Kconfig >> +++ linux-next-20140106/drivers/hwmon/Kconfig >> @@ -650,6 +650,8 @@ config SENSORS_LM73 >> config SENSORS_LM75 >> tristate "National Semiconductor LM75 and compatibles" >> depends on I2C >> +depends on THERMAL >> +depends on THERMAL_OF >> help >> If you say yes here you get support for one common type of >> temperature sensor chip, with models including: >> >> > NACK. The driver does not and must not depend on THERMAL. This needs to > be addressed > in the thermal code, for example with dummy declarations if THERMAL=m but > SENSORS_LM75=y. The functions are already declared as dummies if > THERMAL_OF=n. What do you mean by that? The code of an API provider needs to keep track of all its users? > > Guenter > > > -- You have got to be excited about what you are doing. (L. Lamport) Eduardo Valentin signature.asc Description: OpenPGP digital signature

Re: [PATCH] hwmon/sensors: fix SENSORS_LM75 dependencies

2014-01-07 Thread Eduardo Valentin
t can't see how this > can be a problem at link time. Can anyone enlighten me? > I believe the problem is more in the fact that THERMAL_OF is a bool, but the way it is in thermal Kconfig, it will link to the thermal module, in case CONFIG_THERMAL=m. Thus I am proposing the following, w

[PATCH 1/1] thermal: fix compilation issue on CONFIG_THERMAL_OF dependencies

2014-01-07 Thread Eduardo Valentin
port, otherwise, the thermal API will provide stubs. Cc: Zhang Rui Cc: Jean Delvare Cc: Guenter Roeck Cc: linux...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Reported-by: Randy Dunlap Signed-off-by: Eduardo Valentin --- drivers/thermal/Kconfig | 29 - 1 file ch

<    3   4   5   6   7   8   9   10   11   12   >