Re: [PATCH v5 2/2] pinctrl: pinmux: Add pinmux-select debugfs file

2021-02-15 Thread Drew Fustini
On Mon, Feb 15, 2021 at 09:04:20PM +0200, Andy Shevchenko wrote: > On Sat, Feb 13, 2021 at 12:30 AM Drew Fustini wrote: > > > > Add "pinmux-select" to debugfs which will activate a function and group > > when "" are written to the file. The write > >

[PATCH v6 2/3] pinctrl: pinmux: Add pinmux-select debugfs file

2021-02-16 Thread Drew Fustini
-i2c0-pins ] function: pinmux-i2c1, groups = [ pinmux-i2c1-pins ] function: pinmux-spi1, groups = [ pinmux-spi1-pins ] To activate function pinmux-i2c1 and group pinmux-i2c1-pins: echo "pinmux-i2c1 pinmux-i2c1-pins" > pinmux-select Signed-off-by:

[PATCH v6 0/3] pinctrl: pinmux: Add pinmux-select debugfs file

2021-02-16 Thread Drew Fustini
7602-1-d...@beagleboard.org/ [2] https://lore.kernel.org/linux-gpio/20210126050817.GA187797@x1/ [3] https://lore.kernel.org/linux-gpio/20210123064909.466225-1-d...@beagleboard.org/ Drew Fustini (3): pinctrl: use to octal permissions for debugfs files pinctrl: pinmux: Add pinmux-select

[PATCH v6 3/3] docs/pinctrl: document debugfs files

2021-02-16 Thread Drew Fustini
Document debugfs directories and files created for pinctrl subsystem. Suggested-by: Andy Shevchenko Signed-off-by: Drew Fustini --- Documentation/driver-api/pinctl.rst | 37 + 1 file changed, 37 insertions(+) diff --git a/Documentation/driver-api/pinctl.rst b

[PATCH v6 1/3] pinctrl: use to octal permissions for debugfs files

2021-02-16 Thread Drew Fustini
fs/debugfs/inode.c Suggested-by: Joe Perches Suggested-by: Andy Shevchenko Reviewed-by: Andy Shevchenko Reviewed-by: Geert Uytterhoeven Signed-off-by: Drew Fustini --- drivers/pinctrl/core.c| 12 ++-- drivers/pinctrl/pinconf.c | 4 ++-- drivers/pinctrl/pinmux.c | 4 ++-- 3 files c

Re: [PATCH v4 2/2] pinctrl: pinmux: Add pinmux-select debugfs file

2021-02-11 Thread Drew Fustini
On Thu, Feb 11, 2021 at 10:39:38AM +0300, Dan Carpenter wrote: > On Wed, Feb 10, 2021 at 11:24:23PM -0800, Joe Perches wrote: > > On Thu, 2021-02-11 at 10:11 +0300, Dan Carpenter wrote: > > > On Wed, Feb 10, 2021 at 02:28:54PM -0800, Drew Fustini wrote: > > > > +

Re: [PATCH v4 2/2] pinctrl: pinmux: Add pinmux-select debugfs file

2021-02-11 Thread Drew Fustini
On Thu, Feb 11, 2021 at 09:09:03AM +0100, Geert Uytterhoeven wrote: > Hi Drew, > > On Wed, Feb 10, 2021 at 11:33 PM Drew Fustini wrote: > > Add "pinmux-select" to debugfs which will activate a function and group > > when "" are written to the file. The wr

Re: [PATCH v4 2/2] pinctrl: pinmux: Add pinmux-select debugfs file

2021-02-11 Thread Drew Fustini
On Thu, Feb 11, 2021 at 11:53:24AM +0200, Andy Shevchenko wrote: > On Thu, Feb 11, 2021 at 10:09 AM Geert Uytterhoeven > wrote: > > On Wed, Feb 10, 2021 at 11:33 PM Drew Fustini wrote: > > > > > +#define PINMUX_MAX_NAME 64 > > > >

Re: [PATCH v4 2/2] pinctrl: pinmux: Add pinmux-select debugfs file

2021-02-11 Thread Drew Fustini
On Thu, Feb 11, 2021 at 03:00:51PM +0300, Dan Carpenter wrote: > On Wed, Feb 10, 2021 at 02:28:54PM -0800, Drew Fustini wrote: > > Add "pinmux-select" to debugfs which will activate a function and group > > when "" are written to the file. The write > >

Re: [PATCH] pinctrl: use to octal permissions for debugfs files

2021-02-12 Thread Drew Fustini
On Fri, Feb 12, 2021 at 08:58:58AM +0100, Linus Walleij wrote: > On Tue, Jan 26, 2021 at 5:55 AM Drew Fustini wrote: > > > Switch over pinctrl debugfs files to use octal permissions as they are > > preferred over symbolic permissions. Refer to commit f90774e1fd27 > >

[PATCH v5 0/2] pinctrl: pinmux: Add pinmux-select debugfs file

2021-02-12 Thread Drew Fustini
_from_user() - switch from pr_warn() to dev_err() [1] https://lore.kernel.org/linux-gpio/20210126044742.87602-1-d...@beagleboard.org/ [2] https://lore.kernel.org/linux-gpio/20210126050817.GA187797@x1/ [3] https://lore.kernel.org/linux-gpio/20210123064909.466225-1-d...@beagleboard.org/ Drew Fustini (2): pinctr

[PATCH v5 1/2] pinctrl: use to octal permissions for debugfs files

2021-02-12 Thread Drew Fustini
fs/debugfs/inode.c Suggested-by: Andy Shevchenko Signed-off-by: Drew Fustini --- drivers/pinctrl/core.c| 12 ++-- drivers/pinctrl/pinconf.c | 4 ++-- drivers/pinctrl/pinmux.c | 4 ++-- 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/pinctrl/core.c b/drivers/pinc

[PATCH v5 2/2] pinctrl: pinmux: Add pinmux-select debugfs file

2021-02-12 Thread Drew Fustini
i2c0-pins ] function: pinmux-i2c1, groups = [ pinmux-i2c1-pins ] function: pinmux-spi1, groups = [ pinmux-spi1-pins ] To activate function pinmux-i2c1 and group pinmux-i2c1-pins: echo "pinmux-i2c1 pinmux-i2c1-pins" > pinmux-select Signed-off-by: Dr

[PATCH v2 0/2] pinctrl: pinmux: Add pinmux-select debugfs file

2021-02-09 Thread Drew Fustini
10126044742.87602-1-d...@beagleboard.org/ [2] https://lore.kernel.org/linux-gpio/20210126050817.GA187797@x1/ [3] https://lore.kernel.org/linux-gpio/20210123064909.466225-1-d...@beagleboard.org/ Drew Fustini (2): pinctrl: use to octal permissions for debugfs files pinctrl: pinmux: Add pinmux-select deb

[PATCH v2 1/2] pinctrl: use to octal permissions for debugfs files

2021-02-09 Thread Drew Fustini
Switch over pinctrl debugfs files to use octal permissions as they are preferred over symbolic permissions. Refer to commit f90774e1fd27 ("checkpatch: look for symbolic permissions and suggest octal instead"). Signed-off-by: Drew Fustini --- drivers/pinctrl/core.c| 6 +++--- drive

[PATCH v2 2/2] pinctrl: pinmux: Add pinmux-select debugfs file

2021-02-09 Thread Drew Fustini
nmux-i2c0-pins ] function: pinmux-i2c1, groups = [ pinmux-i2c1-pins ] function: pinmux-spi1, groups = [ pinmux-spi1-pins ] To activate function pinmux-i2c1 (fsel 4) and group pinmux-i2c1-pins (gsel 4): echo '4 4' > pinmux-select Signed-off-by: Dre

Re: [PATCH v2 2/2] pinctrl: pinmux: Add pinmux-select debugfs file

2021-02-10 Thread Drew Fustini
On Wed, Feb 10, 2021 at 11:56:49AM +0200, Andy Shevchenko wrote: > On Wed, Feb 10, 2021 at 9:50 AM Drew Fustini wrote: > > > > Add "pinmux-select" to debugfs which will activate a function and group > > when 2 integers " " are written to > > the fi

Re: [PATCH v2 2/2] pinctrl: pinmux: Add pinmux-select debugfs file

2021-02-10 Thread Drew Fustini
On Wed, Feb 10, 2021 at 09:20:44PM +0300, Dan Carpenter wrote: > Hi Drew, > > url: > https://github.com/0day-ci/linux/commits/Drew-Fustini/pinctrl-pinmux-Add-pinmux-select-debugfs-file/20210210-160108 > base: > https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux

Re: [PATCH v2 2/2] pinctrl: pinmux: Add pinmux-select debugfs file

2021-02-10 Thread Drew Fustini
On Wed, Feb 10, 2021 at 10:05:29PM +0300, Dan Carpenter wrote: > On Wed, Feb 10, 2021 at 07:39:16PM +0100, Geert Uytterhoeven wrote: > > Hi Dan, > > > > On Wed, Feb 10, 2021 at 7:21 PM Dan Carpenter > > wrote: > > > 99b2f99aa41aa7 Drew Fustini 2021-02-

Re: [PATCH v2 1/2] pinctrl: use to octal permissions for debugfs files

2021-02-10 Thread Drew Fustini
On Wed, Feb 10, 2021 at 04:36:00AM -0800, Joe Perches wrote: > On Wed, 2021-02-10 at 12:18 +0200, Andy Shevchenko wrote: > > On Wed, Feb 10, 2021 at 10:30 AM Joe Perches wrote: > > > On Tue, 2021-02-09 at 23:49 -0800, Drew Fustini wrote: > > > > > > -

[PATCH v3 2/2] pinctrl: pinmux: Add pinmux-select debugfs file

2021-02-10 Thread Drew Fustini
nmux-i2c0-pins ] function: pinmux-i2c1, groups = [ pinmux-i2c1-pins ] function: pinmux-spi1, groups = [ pinmux-spi1-pins ] To activate function pinmux-i2c1 and group pinmux-i2c1-pins: echo pinmux-i2c1 pinmux-i2c1-pins > mux-select Signed-off-by: Drew Fustini

[PATCH v3 0/2] pinctrl: pinmux: Add pinmux-select debugfs file

2021-02-10 Thread Drew Fustini
m pr_warn() to dev_err() [1] https://lore.kernel.org/linux-gpio/20210126044742.87602-1-d...@beagleboard.org/ [2] https://lore.kernel.org/linux-gpio/20210126050817.GA187797@x1/ [3] https://lore.kernel.org/linux-gpio/20210123064909.466225-1-d...@beagleboard.org/ Drew Fustini (2): pinctrl: us

[PATCH v3 1/2] pinctrl: use to octal permissions for debugfs files

2021-02-10 Thread Drew Fustini
fs/debugfs/inode.c Thank you, Drew Suggested-by: Andy Shevchenko Signed-off-by: Drew Fustini --- drivers/pinctrl/core.c| 6 +++--- drivers/pinctrl/pinconf.c | 4 ++-- drivers/pinctrl/pinmux.c | 4 ++-- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/pinctrl/core.c b/drive

[PATCH v4 0/2] pinctrl: pinmux: Add pinmux-select debugfs file

2021-02-10 Thread Drew Fustini
10126050817.GA187797@x1/ [3] https://lore.kernel.org/linux-gpio/20210123064909.466225-1-d...@beagleboard.org/ Drew Fustini (2): pinctrl: use to octal permissions for debugfs files pinctrl: pinmux: Add pinmux-select debugfs file drivers/pinctrl/core.c| 6 +-- drivers/pinctrl/pinconf.c | 4 +- dr

[PATCH v4 2/2] pinctrl: pinmux: Add pinmux-select debugfs file

2021-02-10 Thread Drew Fustini
i2c0-pins ] function: pinmux-i2c1, groups = [ pinmux-i2c1-pins ] function: pinmux-spi1, groups = [ pinmux-spi1-pins ] To activate function pinmux-i2c1 and group pinmux-i2c1-pins: echo "pinmux-i2c1 pinmux-i2c1-pins" > pinmux-select Signed-off-by: Dre

[PATCH v4 1/2] pinctrl: use to octal permissions for debugfs files

2021-02-10 Thread Drew Fustini
fs/debugfs/inode.c Suggested-by: Andy Shevchenko Signed-off-by: Drew Fustini --- drivers/pinctrl/core.c| 6 +++--- drivers/pinctrl/pinconf.c | 4 ++-- drivers/pinctrl/pinmux.c | 4 ++-- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/co

Re: [PATCH v4 1/2] pinctrl: use to octal permissions for debugfs files

2021-02-10 Thread Drew Fustini
On Wed, Feb 10, 2021 at 11:36:39PM -0800, Joe Perches wrote: > On Wed, 2021-02-10 at 14:28 -0800, Drew Fustini wrote: > > Switch over pinctrl debugfs files to use octal permissions as they are > > preferred over symbolic permissions. Refer to commit f90774e1fd27 > > ("che

[PATCH v7 0/3] pinctrl: pinmux: Add pinmux-select debugfs file

2021-02-17 Thread Drew Fustini
1-d...@beagleboard.org/ [2] https://lore.kernel.org/linux-gpio/20210126050817.GA187797@x1/ [3] https://lore.kernel.org/linux-gpio/20210123064909.466225-1-d...@beagleboard.org/ Drew Fustini (3): pinctrl: use to octal permissions for debugfs files pinctrl: pinmux: Add pinmux-select debugf

[PATCH v7 2/3] pinctrl: pinmux: Add pinmux-select debugfs file

2021-02-17 Thread Drew Fustini
-i2c0-pins ] function: pinmux-i2c1, groups = [ pinmux-i2c1-pins ] function: pinmux-spi1, groups = [ pinmux-spi1-pins ] To activate function pinmux-i2c1 and group pinmux-i2c1-pins: echo "pinmux-i2c1 pinmux-i2c1-pins" > pinmux-select Reviewed-by: Andy Shevchenko Review

[PATCH v7 3/3] docs/pinctrl: document debugfs files

2021-02-17 Thread Drew Fustini
Document debugfs directories and files created for pinctrl subsystem. Suggested-by: Andy Shevchenko Reviewed-by: Andy Shevchenko Reviewed-by: Tony Lindgren Signed-off-by: Drew Fustini --- Documentation/driver-api/pinctl.rst | 37 + 1 file changed, 37 insertions

[PATCH v7 1/3] pinctrl: use to octal permissions for debugfs files

2021-02-17 Thread Drew Fustini
fs/debugfs/inode.c Suggested-by: Joe Perches Suggested-by: Andy Shevchenko Reviewed-by: Andy Shevchenko Reviewed-by: Geert Uytterhoeven Reviewed-by: Tony Lindgren Signed-off-by: Drew Fustini --- drivers/pinctrl/core.c| 12 ++-- drivers/pinctrl/pinconf.c | 4 ++-- drivers/pinctrl/pinm

Re: [PATCH 1/2] ARM: dts: am335x-pocketbeagle: unique gpio-line-names

2021-02-03 Thread Drew Fustini
On Thu, Feb 04, 2021 at 08:58:20AM +0200, Tony Lindgren wrote: > * Drew Fustini [210127 02:04]: > > Based on linux-gpio discussion [1], it is best practice to make the > > gpio-line-names unique. Generic names like "[ethernet]" are replaced > > with the name of the

Re: [PATCH v8 0/3] pinctrl: pinmux: Add pinmux-select debugfs file

2021-02-26 Thread Drew Fustini
On Sat, Feb 20, 2021 at 12:27:47PM -0800, Drew Fustini wrote: > This series first converts the debugfs files in the pinctrl subsystem to > octal permissions and then adds a new debugfs file "pinmux-select". > > Group name and function name can be written to "pinmux-sel

[PATCH] pinctrl-single: fix pcs_parse_pinconf() return val

2020-05-31 Thread Drew Fustini
pinctrl_entry() will know that no map was added. [0] https://lore.kernel.org/linux-omap/20200529175544.GA3766151@x1/ Signed-off-by: Drew Fustini --- drivers/pinctrl/pinctrl-single.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctr

Re: [PATCH] pinctrl-single: fix pcs_parse_pinconf() return val

2020-06-01 Thread Drew Fustini
On Mon, Jun 01, 2020 at 09:18:51AM -0700, Tony Lindgren wrote: > * Drew Fustini [200531 20:42]: > > This patch causes pcs_parse_pinconf() to return an error when no > > pinctrl_map is added. The current behavior is to return 0 when > > !PCS_HAS_PINC

[PATCH v2] arm: dts: am33xx-bone-common: add gpio-line-names

2020-05-20 Thread Drew Fustini
sed input active-high line 15: "P9_29 [spi1_d0]" unused input active-high line 16: "P9_30 [spi1_d1]" unused input active-high line 17: "P9_28 [spi1_cs0]" unused input active-high line 18: "P9_42B [ecappwm0]" unused input

Re: [PATCH] arm: dts: am33xx-bone-common: add gpio-line-names

2020-05-20 Thread Drew Fustini
On Mon, May 18, 2020 at 04:18:43PM +0200, Drew Fustini wrote: > On Mon, May 18, 2020 at 09:11:07AM +0200, Linus Walleij wrote: > > On Fri, May 8, 2020 at 6:57 PM Drew Fustini wrote: > > > > > Add gpio-line-names properties to the gpio controller nodes. > > >

Re: [PATCH v2] arm: dts: am33xx-bone-common: add gpio-line-names

2020-05-21 Thread Drew Fustini
On Thu, May 21, 2020 at 08:26:42PM +0300, Grygorii Strashko wrote: > > > On 21/05/2020 17:41, Robert Nelson wrote: > > > Not sure if it should be in am335x-bone-common.dtsi. > > > > > > For example: > > > am335x-boneblack.dts > > >#include "am335x-bone-common.dtsi" > > >#include "am335x-

[PATCH] arm: dts: am335x-boneblack: add gpio-line-names

2020-05-21 Thread Drew Fustini
to a GPIO line. The output of gpioinfo on a BeagleBone Black would be: [0] https://git.io/JfgOd [1] https://beagleboard.org/capes [1] https://beagleboard.org/Support/bone101 [2] https://beagleboard.org/static/images/cape-headers.png Reviewed-by: Jason Kridner Reviewed-by: Robert Nelson Signed-

[PATCH v2] arm: dts: am335x-boneblack: add gpio-line-names

2020-05-21 Thread Drew Fustini
pi1_sclk]" unused input active-high line 15: "P9_29 [spi1_d0]" unused input active-high line 16: "P9_30 [spi1_d1]" unused input active-high line 17: "P9_28 [spi1_cs0]" unused input active-high line 18: "P9_42B [ecappwm0]"

Re: [PATCH] gpio: omap: improve coding style for pin config flags

2020-08-19 Thread Drew Fustini
On Wed, Aug 19, 2020 at 09:31:27AM +0300, Tony Lindgren wrote: > Hi, > > * Drew Fustini [200722 12:09]: > > Change the handling of pin config flags from if/else to switch > > statement to make the code more readable and cleaner. > > > > Suggested-by: Gustavo A.

[PATCH] ARM: dts: am33xx: add ocp label

2020-08-09 Thread Drew Fustini
Add label to the ocp node in the AM33xx SoC include so that it can be referenced in board-level files like am335x-pocketbeagle.dts Signed-off-by: Drew Fustini --- arch/arm/boot/dts/am33xx.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/am33xx.dtsi b

[RFC PATCH] pinctrl: add helper to expose pinctrl state in debugfs

2020-12-10 Thread Drew Fustini
tem-Reference-Manual#section-7-1 [5] https://github.com/beagleboard/bb.org-overlays/blob/master/tools/beaglebone-universal-io/config-pin [6] https://beagleboard.org/Support/bone101/#headers Cc: Pantelis Antoniou Cc: Linus Walleij Cc: Tony Lindgren Signed-off-by: Drew Fustini --- driver

Re: [RFC PATCH] pinctrl: add helper to expose pinctrl state in debugfs

2020-12-11 Thread Drew Fustini
On Fri, Dec 11, 2020 at 11:15:21PM +0200, Andy Shevchenko wrote: > On Fri, Dec 11, 2020 at 1:54 PM Drew Fustini wrote: > > > > BeagleBoard.org [0] currently uses an out-of-tree driver called > > bone-pinmux-helper [1] developed by Pantelis Antoniou [2] back in 2013. >

Re: [RFC PATCH v2] pinctrl: add helper to expose pinctrl state in debugfs

2021-01-08 Thread Drew Fustini
On Sat, Jan 09, 2021 at 02:22:07AM +0100, Linus Walleij wrote: > Hi Drew, > > sorry for belated review. The approach is so uncommon so it had me > confused. > > On Thu, Dec 24, 2020 at 9:36 PM Drew Fustini wrote: > > > > > I used the compatible string

Re: [RFC PATCH v2] pinctrl: add helper to expose pinctrl state in debugfs

2020-12-24 Thread Drew Fustini
On Fri, Dec 18, 2020 at 06:01:25PM +0200, Andy Shevchenko wrote: > On Fri, Dec 18, 2020 at 6:52 AM Drew Fustini wrote: > > > > BeagleBoard.org [0] currently uses an out-of-tree driver called > > bone-pinmux-helper [1] developed by Pantelis Antoniou [2] back in 2013. > &g

[PATCH] ARM: dts: am335x-boneblack.dts: unique gpio-line-names

2021-03-24 Thread Drew Fustini
C" name to represent "not connected". [1] https://lore.kernel.org/linux-gpio/20201216195357.GA2583366@x1/ Signed-off-by: Drew Fustini --- Tony - I have fixed the conflict so this now applies against mainline. arch/arm/boot/dts/am335x-boneblack.dts | 132 ---

Re: [PATCH 1/2] ARM: dts: am335x-pocketbeagle: unique gpio-line-names

2021-03-24 Thread Drew Fustini
On Wed, Mar 24, 2021 at 02:00:52PM +0200, Tony Lindgren wrote: > Hi, > > * Drew Fustini [210127 02:04]: > > Based on linux-gpio discussion [1], it is best practice to make the > > gpio-line-names unique. Generic names like "[ethernet]" are replaced > > with

[PATCH] clocksource/drivers: fix typo in timer-pistachio

2021-03-05 Thread Drew Fustini
Fix trivial typo, rename local variable from 'overflw' to 'overflow' in pistachio_clocksource_read_cycles(). Reported-by: Gustavo A. R. Silva Signed-off-by: Drew Fustini --- drivers/clocksource/timer-pistachio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[PATCH] scripts/spelling.txt: add "overflw"

2021-03-05 Thread Drew Fustini
Add typo "overflw" for "overflow". This typo was found and fixed in drivers/clocksource/timer-pistachio.c. Link: https://lore.kernel.org/lkml/20210305090315.384547-1-d...@beagleboard.org/ Suggested-by: Gustavo A. R. Silva Signed-off-by: Drew Fustini --- scripts/spelli

[PATCH] net: sctp: trivial: fix typo in comment

2021-03-03 Thread Drew Fustini
Fix typo of 'overflow' for comment in sctp_tsnmap_check(). Reported-by: Gustavo A. R. Silva Signed-off-by: Drew Fustini --- net/sctp/tsnmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sctp/tsnmap.c b/net/sctp/tsnmap.c index a9c6af5795d8..5ba456727f63 10

[PATCH] scripts/spelling.txt: add "overlfow"

2021-03-03 Thread Drew Fustini
Add typo "overlfow" for "overflow". This typo was found and fixed in net/sctp/tsnmap.c. Link: https://lore.kernel.org/netdev/20210304055548.56829-1-d...@beagleboard.org/ Suggested-by: Kees Cook Signed-off-by: Drew Fustini --- scripts/spelling.txt | 1 + 1 file changed,

Re: [PATCH v4 0/3] Fix pinctrl-single pcs_pin_dbg_show()

2021-03-21 Thread Drew Fustini
12) 0:? 44e10830 0037 pinctrl-single pin 140 (PIN140) 0:? 44e10a30 0028 pinctrl-single pin 141 (PIN141) 13:gpio-64-95 44e10a34 0020 pinctrl-single Reviewed-by: Drew Fustini Thanks, Drew

Re: [PATCH v1 1/1] pinctrl: core: Show pin numbers for the controllers with base = 0

2021-04-19 Thread Drew Fustini
On Mon, Apr 19, 2021 at 3:04 AM Andy Shevchenko wrote: > > On Thu, Apr 15, 2021 at 4:07 PM Andy Shevchenko > wrote: > > > > The commit f1b206cf7c57 ("pinctrl: core: print gpio in pins debugfs file") > > enabled GPIO pin number and label in debugfs for pin controller. However, > > it limited that

Re: [PATCH v1 1/1] pinctrl: core: Show pin numbers for the controllers with base = 0

2021-04-20 Thread Drew Fustini
number. This, > in particular, excluded chips where base is 0 for the historical or backward > compatibility reasons. Refactor the code to include the latter as well. > > Fixes: f1b206cf7c57 ("pinctrl: core: print gpio in pins debugfs file") > Cc: Drew Fustini > S

Re: [PATCH v7 2/3] pinctrl: pinmux: Add pinmux-select debugfs file

2021-02-20 Thread Drew Fustini
On Fri, Feb 19, 2021 at 10:06:51AM +0100, Geert Uytterhoeven wrote: > Hi Drew, > > On Wed, Feb 17, 2021 at 11:15 PM Drew Fustini wrote: > > Add "pinmux-select" to debugfs which will activate a function and group: > > > > echo "" > pinmu

[PATCH v8 0/3] pinctrl: pinmux: Add pinmux-select debugfs file

2021-02-20 Thread Drew Fustini
pinctrl debugfs files is added. Notes for RFC v2 [3]: - rename debugfs file "pinmux-set" to "pinmux-select" - renmae pinmux_set_write() to pinmux_select() - switch from memdup_user_nul() to strncpy_from_user() - switch from pr_warn() to dev_err() [1] https://lore.kernel.org/linu

[PATCH v8 1/3] pinctrl: use to octal permissions for debugfs files

2021-02-20 Thread Drew Fustini
fs/debugfs/inode.c Suggested-by: Joe Perches Suggested-by: Andy Shevchenko Reviewed-by: Andy Shevchenko Reviewed-by: Geert Uytterhoeven Reviewed-by: Tony Lindgren Signed-off-by: Drew Fustini --- drivers/pinctrl/core.c| 12 ++-- drivers/pinctrl/pinconf.c | 4 ++-- drivers/pinctrl/pinm

[PATCH v8 3/3] docs/pinctrl: document debugfs files

2021-02-20 Thread Drew Fustini
Document debugfs directories and files created for pinctrl subsystem. Suggested-by: Andy Shevchenko Reviewed-by: Andy Shevchenko Reviewed-by: Tony Lindgren Signed-off-by: Drew Fustini --- Documentation/driver-api/pinctl.rst | 37 + 1 file changed, 37 insertions

[PATCH v8 2/3] pinctrl: pinmux: Add pinmux-select debugfs file

2021-02-20 Thread Drew Fustini
o Reviewed-by: Tony Lindgren Reviewed-by: Geert Uytterhoeven Tested-by: Geert Uytterhoeven Signed-off-by: Drew Fustini --- drivers/pinctrl/pinmux.c | 102 +++ 1 file changed, 102 insertions(+) diff --git a/drivers/pinctrl/pinmux.c b/drivers/pinctrl/pinmux.c inde

Re: [PATCH] pinctrl: core: Fix unused variable build warnings

2020-11-23 Thread Drew Fustini
On Mon, Nov 23, 2020 at 02:33:33PM -0800, Pawan Gupta wrote: > A recent commit f1b206cf7c57 ("pinctrl: core: print gpio in pins debugfs > file") added build warnings when CONFIG_GPIOLIB=n. Offcourse the kernel > fails to build when warnings are treated as errors. Below is the error > message: > >

Re: [PATCH] pinctrl: core: Fix unused variable build warnings

2020-11-25 Thread Drew Fustini
On Mon, Nov 23, 2020 at 11:51:29PM -0800, Pawan Gupta wrote: > On Mon, Nov 23, 2020 at 09:06:18PM -0800, Drew Fustini wrote: > > On Mon, Nov 23, 2020 at 02:33:33PM -0800, Pawan Gupta wrote: > > > A recent commit f1b206cf7c57 ("pinctrl: core: print gpio in pins debugfs &

[RFC PATCH v2] pinctrl: add helper to expose pinctrl state in debugfs

2020-12-17 Thread Drew Fustini
si#L2084 [4] https://github.com/beagleboard/beaglebone-black/wiki/System-Reference-Manual#section-7-1 [5] https://github.com/beagleboard/bb.org-overlays/blob/master/tools/beaglebone-universal-io/config-pin [6] https://beagleboard.org/Support/bone101/#headers Cc: Pantelis Antoniou Cc: Pantelis A

Re: [RFC PATCH] pinctrl: add helper to expose pinctrl state in debugfs

2020-12-19 Thread Drew Fustini
On Fri, Dec 18, 2020 at 06:00:49PM +0200, Andy Shevchenko wrote: > On Wed, Dec 16, 2020 at 12:42 AM Drew Fustini wrote: > > On Tue, Dec 15, 2020 at 09:39:18PM +0200, Andy Shevchenko wrote: > > > On Tue, Dec 15, 2020 at 9:36 PM Andy Shevchenko > > > wrote: > > >

Re: [PATCH v9 2/4] pinctrl: pinmux: Add pinmux-select debugfs file

2021-03-13 Thread Drew Fustini
On Fri, Mar 12, 2021 at 02:57:54PM +0100, Enrico Weigelt, metux IT consult wrote: > On 02.03.21 06:30, Drew Fustini wrote: > > Hi folks, > > > Add "pinmux-select" to debugfs which will activate a pin function for a > > given pin group: > > > >

[PATCH] pinctrl: clarify #pinctrl-cells for pinctrl-single,pins

2021-01-19 Thread Drew Fustini
y Lindgren Signed-off-by: Drew Fustini --- Documentation/devicetree/bindings/pinctrl/pinctrl-single.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-single.txt b/Documentation/devicetree/bindings/pinctrl/pinctrl-single

Re: [RFC PATCH v2] pinctrl: add helper to expose pinctrl state in debugfs

2021-01-20 Thread Drew Fustini
On Mon, Jan 11, 2021 at 12:03:18PM +0200, Tony Lindgren wrote: > Hi, > > * Linus Walleij [210109 21:14]: > > On Sat, Jan 9, 2021 at 3:55 AM Drew Fustini wrote: > > > > > I discussed my use case and this patch on #armlinux earlier this week > > > and Ale

[PATCH v9 2/4] pinctrl: pinmux: Add pinmux-select debugfs file

2021-03-02 Thread Drew Fustini
o Reviewed-by: Tony Lindgren Reviewed-by: Geert Uytterhoeven Tested-by: Geert Uytterhoeven Signed-off-by: Drew Fustini --- drivers/pinctrl/pinmux.c | 102 +++ 1 file changed, 102 insertions(+) diff --git a/drivers/pinctrl/pinmux.c b/drivers/pinctrl/pinmux.c inde

[PATCH v9 4/4] docs/pinctrl: document debugfs files

2021-03-02 Thread Drew Fustini
Document debugfs directories and files created for pinctrl subsystem. Suggested-by: Andy Shevchenko Reviewed-by: Andy Shevchenko Reviewed-by: Tony Lindgren Signed-off-by: Drew Fustini --- Documentation/driver-api/pin-control.rst | 37 1 file changed, 37 insertions

[PATCH v9 3/4] Documentation: rename pinctl to pin-control

2021-03-02 Thread Drew Fustini
pinctl is not ideal as pinctrl (with an 'r') is much more common. Linus state that pin-control.rst would be the best name for the documentation. Link: https://lore.kernel.org/linux-gpio/20210126050817.GA187797@x1/#t Suggested-by: Linus Walleij Signed-off-by: Drew Fustini --- Doc

[PATCH v9 0/4] pinctrl: pinmux: Add pinmux-select debugfs file

2021-03-02 Thread Drew Fustini
et_write() to pinmux_select() - switch from memdup_user_nul() to strncpy_from_user() - switch from pr_warn() to dev_err() [1] https://lore.kernel.org/linux-gpio/20210126044742.87602-1-d...@beagleboard.org/ [2] https://lore.kernel.org/linux-gpio/20210126050817.GA187797@x1/ [3] https://lore.kern

[PATCH v9 1/4] pinctrl: use to octal permissions for debugfs files

2021-03-02 Thread Drew Fustini
fs/debugfs/inode.c Suggested-by: Joe Perches Suggested-by: Andy Shevchenko Reviewed-by: Andy Shevchenko Reviewed-by: Geert Uytterhoeven Reviewed-by: Tony Lindgren Signed-off-by: Drew Fustini --- drivers/pinctrl/core.c| 12 ++-- drivers/pinctrl/pinconf.c | 4 ++-- drivers/pinctrl/pinm

Re: [PATCH v5 1/2] pinctrl: use to octal permissions for debugfs files

2021-03-02 Thread Drew Fustini
On Tue, Mar 02, 2021 at 05:22:37PM +0100, Linus Walleij wrote: > On Tue, Mar 2, 2021 at 11:23 AM Andy Shevchenko > wrote: > > On Tue, Mar 2, 2021 at 10:36 AM Linus Walleij > > wrote: > > > > Patch applied, thanks for fixing this! > > > > I guess we are at v9 of this. > > Yeah I took it out aga

[PATCH] pinctrl: use to octal permissions for debugfs files

2021-01-26 Thread Drew Fustini
Switch over pinctrl debugfs files to use octal permissions as they are preferred over symbolic permissions. Refer to commit f90774e1fd27 ("checkpatch: look for symbolic permissions and suggest octal instead"). Signed-off-by: Drew Fustini --- Patch note: - I learned about this preferenc

pinctl.rst instead of pinctrl.rst?

2021-01-26 Thread Drew Fustini
I was having trouble finding the pinctrl rst documentation until I realized it is named pinctl with no 'r': Documentation/driver-api/pinctl.rst Is there a reason for this? Is it worth me submitting a patch to rename and change tree-wide references? Thanks, Drew

[PATCH 1/2] ARM: dts: am335x-pocketbeagle: unique gpio-line-names

2021-01-26 Thread Drew Fustini
C" name to represent "not connected". [1] https://lore.kernel.org/linux-gpio/20201216195357.GA2583366@x1/ Signed-off-by: Drew Fustini --- arch/arm/boot/dts/am335x-pocketbeagle.dts | 140 +++--- 1 file changed, 70 insertions(+), 70 deletions(-) diff --git a/arch/arm/

[PATCH 2/2] ARM: dts: am335x-boneblack.dts: unique gpio-line-names

2021-01-26 Thread Drew Fustini
C" name to represent "not connected". [1] https://lore.kernel.org/linux-gpio/20201216195357.GA2583366@x1/ Signed-off-by: Drew Fustini --- arch/arm/boot/dts/am335x-boneblack.dts | 130 - 1 file changed, 65 insertions(+), 65 deletions(-) diff --git a/arch/arm/b

Re: [RFC PATCH v2] pinctrl: add helper to expose pinctrl state in debugfs

2021-01-03 Thread Drew Fustini
On Thu, Dec 24, 2020 at 02:36:03PM -0600, Drew Fustini wrote: > On Fri, Dec 18, 2020 at 06:01:25PM +0200, Andy Shevchenko wrote: > > On Fri, Dec 18, 2020 at 6:52 AM Drew Fustini wrote: > > > > > > BeagleBoard.org [0] currently uses an out-of-tree driver called

Re: [PATCH v4 2/2] ARM: dts: am33xx-l4: change #pinctrl-cells from 1 to 2

2021-01-15 Thread Drew Fustini
On Fri, Jan 15, 2021 at 07:02:01PM +0100, Emmanuel Vadot wrote: > > Hello Drew, > > On Wed, 1 Jul 2020 03:33:20 +0200 > Drew Fustini wrote: > > > Increase #pinctrl-cells to 2 so that mux and conf be kept separate. This > > requires the AM33XX_PADCONF macro in

Re: [RFC PATCH] pinctrl: add helper to expose pinctrl state in debugfs

2020-12-15 Thread Drew Fustini
On Tue, Dec 15, 2020 at 09:36:33PM +0200, Andy Shevchenko wrote: > On Mon, Dec 14, 2020 at 11:44 PM Drew Fustini wrote: > > On Mon, Dec 14, 2020 at 07:55:12PM +0200, Andy Shevchenko wrote: > > > On Sat, Dec 12, 2020 at 1:43 AM Drew Fustini wrote: > > > > On Fri, De

Re: [RFC PATCH] pinctrl: add helper to expose pinctrl state in debugfs

2020-12-15 Thread Drew Fustini
On Tue, Dec 15, 2020 at 09:39:18PM +0200, Andy Shevchenko wrote: > On Tue, Dec 15, 2020 at 9:36 PM Andy Shevchenko > wrote: > > On Mon, Dec 14, 2020 at 11:44 PM Drew Fustini wrote: > > > On Mon, Dec 14, 2020 at 07:55:12PM +0200, Andy Shevchenko wrote: > > ... >

Re: [PATCH] gpiolib: Allow name duplicates of "" and "NC"

2020-12-16 Thread Drew Fustini
On Tue, Dec 15, 2020 at 09:03:08AM -0800, Bjorn Andersson wrote: > Not all GPIO pins are exposed to the world and this is typically > described by not giving these lines particular names, commonly "" or > "NC". > > With the recent introduction of '2cd64ae98f35 ("gpiolib: Disallow > identical line

Re: [RFC PATCH] pinctrl: add helper to expose pinctrl state in debugfs

2020-12-14 Thread Drew Fustini
On Mon, Dec 14, 2020 at 07:55:12PM +0200, Andy Shevchenko wrote: > On Sat, Dec 12, 2020 at 1:43 AM Drew Fustini wrote: > > On Fri, Dec 11, 2020 at 11:15:21PM +0200, Andy Shevchenko wrote: > > > On Fri, Dec 11, 2020 at 1:54 PM Drew Fustini wrote: > > > > > > &g

[PATCH] Staging: fbtft: move externs to header file

2015-03-03 Thread Drew Fustini
Move extern declartions from fbtft-core.c to fbtft header file. This resovles the warning from checkpatch.pl that "externs should be avoided in .c files". Signed-off-by: Drew Fustini --- drivers/staging/fbtft/fbtft-core.c | 5 - drivers/staging/fbtft/fbtft.h | 7 ++

Re: [PATCH] Staging: fbtft: move externs to header file

2015-03-03 Thread Drew Fustini
On Tue, Mar 03, 2015 at 04:33:01PM +0530, Sudip Mukherjee wrote: > but now it adds 6 additional warning in checkpatch --strict > "extern prototypes should be avoided in .h files" Thanks, Sudip. I did not realize that was an option for checkpatch. I see now that there are additional warnings as yo

[PATCH] Staging: fbtft: add header for internal functions

2015-03-04 Thread Drew Fustini
also advised fbtft.h file will eventually live in include/linux/fbtft.h Suggested-by: Noralf Trønnes Signed-off-by: Drew Fustini --- drivers/staging/fbtft/fbtft-core.c | 7 +-- drivers/staging/fbtft/internal.h | 25 + 2 files changed, 26 insertions(+), 6 delet

Re: [PATCH] Staging: fbtft: move externs to header file

2015-03-04 Thread Drew Fustini
On Tue, Mar 03, 2015 at 08:04:10PM +0100, Noralf Trønnes wrote: > These functions are defined in fbtft-sysfs.c and internal to the > fbtft module. > I think it's better to put them in an 'internal.h' file. > The fbtft.h file will eventually live in include/linux/fbtft.h or > something like that. T

Re: [PATCH] arm: dts: am33xx-l4: add gpio-line-names to gpio controllers

2020-04-29 Thread Drew Fustini
On Tue, Apr 28, 2020 at 10:37:43AM +0300, Grygorii Strashko wrote: > > > On 28/04/2020 02:31, Drew Fustini wrote: > > Add gpio-line-names properties to the gpio controller nodes. The names > > correspond to the AM335x pin names which are also the muxmode 0 signal > >

Re: [RFC PATCH 3/3] staging: remove fbtft

2016-11-23 Thread Drew Fustini
On Wed, Nov 23, 2016 at 2:03 AM, Tomi Valkeinen wrote: > Since the fbdev framework is in maintenance mode and all new display > drivers should be made with the DRM framework, remove fbtft from > staging. > > Signed-off-by: Tomi Valkeinen I'd request that fbtft please be kept in staging until a s

[PATCH V2] ARM: dts: am33xx-l4: add gpio-ranges

2020-06-10 Thread Drew Fustini
] http://www.ti.com/lit/ds/symlink/am3358.pdf [2] https://gist.github.com/pdp7/6ffaddc8867973c1c3e8612cfaf72020 [3] http://www.ti.com/processors/sitara-arm/am335x-cortex-a8/overview.html Signed-off-by: Drew Fustini --- V2 changes: - clarify that these gpio-ranges are valid for all SoCs including th

Re: [PATCH v2 3/4] drm: bridge: add it66121 driver

2020-06-11 Thread Drew Fustini
On Wed, Mar 11, 2020 at 01:51:34PM +0100, Phong LE wrote: > This commit is a simple driver for bridge HMDI it66121. > The input format is RBG and there is no color conversion. > Audio, HDCP and CEC are not supported yet. > > Signed-off-by: Phong LE > --- > drivers/gpu/drm/bridge/Kconfig |

[PATCH] ARM: dts: am5729: beaglebone-ai: fix rgmii phy-mode

2020-06-11 Thread Drew Fustini
ii Strashko made a similar phy-mode fix in 820f8a870f65 for other AM5729 boards. [0] https://github.com/beagleboard/beaglebone-ai/blob/master/BeagleBone-AI_sch.pdf Cc: Vinod Koul Cc: Grygorii Strashko Fixes: cd28d1d6e52e ("net: phy: at803x: Disable phy delay for RGMII mode") Signed-of

Re: [PATCH v3 0/3] pinctrl: single: support #pinctrl-cells = 2

2020-06-29 Thread Drew Fustini
On Mon, Jun 22, 2020 at 07:29:48PM +0200, Drew Fustini wrote: > Currently, pinctrl-single only allows #pinctrl-cells = 1. > > This series will allow pinctrl-single to also support #pinctrl-cells = 2 > > If "pinctrl-single,pins" has 3 arguments

Re: [PATCH v2] ARM: dts: am335x-pocketbeagle: set default mux for gpio pins

2020-06-29 Thread Drew Fustini
On Mon, Jun 29, 2020 at 10:03:58AM -0700, Tony Lindgren wrote: > Hi, > > * Drew Fustini [200628 08:26]: > > v2 changes: > > - change default mux from output to input. Input is safer as it does > > not drive the line. If the user wants output, they will need to

Re: [PATCH v4 0/2] pinctrl: single: support #pinctrl-cells = 2

2020-07-07 Thread Drew Fustini
On Tue, Jul 7, 2020 at 1:01 PM Linus Walleij wrote: > > On Wed, Jul 1, 2020 at 3:33 AM Drew Fustini wrote: > > > Currently, pinctrl-single only allows #pinctrl-cells = 1. > > > > This series will allow pinctrl-single to also support #pinctrl-cells = 2 > > &

[PATCH 0/3] pinctrl: single: support #pinctrl-cells = 2

2020-06-18 Thread Drew Fustini
e register. To take advantage of #pinctrl-cells = 2, the AM33XX_PADCONF macro in omap.h is modified to keep pin conf and pin mux values separate. Drew Fustini (3): ARM: dts: change AM33XX_PADCONF macro separate conf and mux ARM: dts: am33xx-l4: change #pinctrl-cells from 1 to 2 pinctrl: sin

[PATCH 3/3] pinctrl: single: parse #pinctrl-cells = 2

2020-06-18 Thread Drew Fustini
If "pinctrl-single,pins" has 3 arguments (offset, conf, mux) then pcs_parse_one_pinctrl_entry() does an OR operation on to get the value to store in the register. Signed-off-by: Drew Fustini --- drivers/pinctrl/pinctrl-single.c | 11 +-- 1 file changed, 9 insertions(+), 2

[PATCH 1/3] ARM: dts: change AM33XX_PADCONF macro separate conf and mux

2020-06-18 Thread Drew Fustini
AM33XX_PADCONF macro is modified to keep pin conf and pin mux separate. This requires #pinctrl-cells = 2 in am33xx-l4.dtsi pinctrl-single.c but also be changed to support "pinctrl-single,pins" with 3 arguments (offset, conf, mux) Signed-off-by: Drew Fustini --- include/dt-bindin

[PATCH 2/3] ARM: dts: am33xx-l4: change #pinctrl-cells from 1 to 2

2020-06-18 Thread Drew Fustini
This requires AM33XX_PADCONF macro in omap.h to be modified to keep pin conf and pin mux values separate. pinctrl-single.c must also be changed to support "pinctrl-single,pins" with 3 arguments (offset, conf, mux). Signed-off-by: Drew Fustini --- arch/arm/boot/dts/am33xx-l4.dtsi | 2

Re: [PATCH] arm: dts: am335x-pocketbeagle: add gpio-line-names

2020-06-18 Thread Drew Fustini
On Thu, Jun 18, 2020 at 10:03:45AM -0700, Tony Lindgren wrote: > * Drew Fustini [200617 17:10]: > > Tony - does this look ok for 5.9? > > Yes looks OK to me. > > Just wondering, are the line with "NA" not used internally either? > If the "NA" lines

  1   2   >