[PATCH] ARM: EXYNOS: Avoid early use of of_machine_is_compatible()

2012-11-27 Thread Doug Anderson
m [<8060a754>] (start_kernel+0x1e0/0x3c8) [<8060a754>] (start_kernel+0x1e0/0x3c8) from [<40008078>] (0x40008078) Signed-off-by: Doug Anderson --- arch/arm/mach-exynos/common.c |5 - arch/arm/mach-exynos/mach-exynos5-dt.c |4 +++- 2 files changed, 7 insertions

Re: [PATCH] ARM: EXYNOS: Avoid early use of of_machine_is_compatible()

2012-11-28 Thread Doug Anderson
sson wrote: >> > >> >> > >> On Tue, Nov 27, 2012 at 11:53 AM, Doug Anderson >> > >> wrote: >> > >>> >> > >>> The recent commit "ARM: EXYNOS: add support for EXYNOS5440 SoC" broke >> > >>> su

Re: [PATCH v2 1/2] mmc: dw_mmc: exynos: Stop claiming wp-gpio

2012-11-28 Thread Doug Anderson
I have some suggestion below. > Could you check it? > > On Friday, November 23, 2012, Doug Anderson wrote: >> The exynos code claimed wp-gpio with devm_gpio_request() but never did >> anything with it. That meant that anyone using a write protect GPIO >> would effectively be

[PATCH v3 1/4] mmc: dw_mmc: Add "disable-wp" device tree property

2012-11-29 Thread Doug Anderson
l in needing to specify "disable-wp" because the lack of a "wp-gpios" property means to use the special purpose write protect line. On some other mmc devices the lack of "wp-gpios" means that write protect should be disabled. Signed-off-by: Doug Anderson --- Changes in v

[PATCH v3 3/4] mmc: dw_mmc: exynos: Remove code for wp-gpios

2012-11-29 Thread Doug Anderson
-off-by: Doug Anderson --- Changes in v3: - Totally removed wp-gpios handling from exynos code. Changes in v2: None drivers/mmc/host/dw_mmc-exynos.c | 10 -- 1 files changed, 0 insertions(+), 10 deletions(-) diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c

Re: [PATCH v2 1/2] mmc: dw_mmc: exynos: Stop claiming wp-gpio

2012-11-29 Thread Doug Anderson
Seungwon, On Wed, Nov 28, 2012 at 11:46 PM, Seungwon Jeon wrote: > Hi Doug, > > On Thursday, November 29, 2012, Doug Anderson wrote: >> Seungwon, >> >> Thanks for the review. See below for comments. If you'd like me to >> respin then please let me know.

[PATCH v3 4/4] mmc: dw_mmc: Handle wp-gpios from device tree

2012-11-29 Thread Doug Anderson
-off-by: Doug Anderson --- Changes in v3: None Changes in v2: - Fixed return type from u32 to int - Return -EINVAL instead of -1 drivers/mmc/host/dw_mmc.c | 34 ++ 1 files changed, 34 insertions(+), 0 deletions(-) diff --git a/drivers/mmc/host/dw_mmc.c b/drivers

[PATCH v3 2/4] ARM: dts: Add disable-wp for sd card slot on smdk5250

2012-11-29 Thread Doug Anderson
The next change will remove the code from the dw_mmc-exynos that added the DW_MCI_QUIRK_NO_WRITE_PROTECT. Keep existing functionality of having no write protect pin on smdk5250 by adding the disable-wp property. Signed-off-by: Doug Anderson --- Changes in v3: - New for this version of the patch

[PATCH 0/2] These two patches to s3c_pm_arch_prepare_irqs() were part of the work

2013-03-19 Thread Doug Anderson
to make suspend/resume reliable on the ARM Chromebook (exynos5250-snow). A few more details: - The first patch is not strictly needed but was a nice cleanup. Our understanding was that EINT0 was originally turned on for exynos evt0 silicon and not needed for evt1. - The second patch is more i

[PATCH 2/2] arm: exynos: Clear ENABLE_WAKEUP_SW bit when entering suspend

2013-03-19 Thread Doug Anderson
: Doug Anderson Reviewed-by: Doug Anderson --- arch/arm/mach-exynos/include/mach/pm-core.h | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/arch/arm/mach-exynos/include/mach/pm-core.h b/arch/arm/mach-exynos/include/mach/pm-core.h index 9d8da51e3..7dbbfec 100644 --- a/arch

[PATCH 1/2] arm: exynos: Remove hardcode wakeup unmask for EINT_0

2013-03-19 Thread Doug Anderson
From: Jonathan Kliegman For legacy reasons EINT_0 was being forced on for all exynos systems as a wake interrupt. For boards that need EINT_0 they should probably enable it with enable_irq_wake Signed-off-by: Jonathan Kliegman Signed-off-by: Doug Anderson Reviewed-by: Doug Anderson Reviewed

[PATCH v3 1/2] i2c-core: dt: Pick i2c bus number from i2c alias if present

2013-02-11 Thread Doug Anderson
{ i2c0 = &i2c_0; i2c1 = &i2c_1; }; Signed-off-by: Doug Anderson --- Changes in v3: - Addressed Wolfram's feedback; rebased atop idr-cleanup series. Changes in v2: None drivers/i2c/i2c-core.c | 54 +- 1 file changed, 40 inse

[PATCH v3 2/2] i2c: pxa: Use i2c-core to get bus number now

2013-02-11 Thread Doug Anderson
The commit: "i2c-core: dt: Pick i2c bus number from i2c alias if present" adds support for automatically picking the bus number based on the alias ID. Remove the now unnecessary code from i2c-pxa that did the same thing. Signed-off-by: Doug Anderson --- Changes in v3: None Changes i

Re: [PATCH v2 1/2] i2c-core: dt: Pick i2c bus number from i2c alias if present

2013-02-11 Thread Doug Anderson
Wolfram, Thanks for the review. New patch was just sent. :) On Sun, Feb 10, 2013 at 4:19 AM, Wolfram Sang wrote: >> +static int i2c_get_number_from_dt(struct i2c_adapter *adap) > > i2c_get_id_from_dt()? Done. >> + if (!dev->of_node) >> + return -1; > > -ESOMETHING? Function

[PATCH v3 0/2] Add automatic bus number support for i2c busses with device tree

2013-02-11 Thread Doug Anderson
;t make sense with dynamically (or automatically) allocated IDs. - Use dev_name(&dev->dev) to register for the IRQ; this matches what the i2c-s3c2410.c does and handles dynamically allocated IDs. - This change was only compile-tested (corgi_defconfig), since I don't have access to a boar

Re: [RFC: PATCH 2/2] iio: adc: exynos_adc: Handle timeout and race conditions

2013-04-03 Thread Doug Anderson
Lars, On Sat, Mar 16, 2013 at 7:41 AM, Lars-Peter Clausen wrote: > I think you still need the mutex for serialization, otherwise the requests > would just cancel each other out. Btw. what happens if you start a conversion > while another is still in progress? Is it possible to abort a conversion?

Re: [PATCH 0/2] These two patches to s3c_pm_arch_prepare_irqs() were part of the work

2013-04-03 Thread Doug Anderson
Kukjin, On Tue, Apr 2, 2013 at 7:16 PM, Kukjin Kim wrote: >> Applied with 1st one, BTW, do you want to send this for stable tree? I don't have any need for it to be in stable tree. The ARM Chromebook hasn't reached critical functionality on any released/upstram Linux versions so it doesn't make

Re: [RFC: PATCH 2/2] iio: adc: exynos_adc: Handle timeout and race conditions

2013-04-05 Thread Doug Anderson
Lars, On Fri, Apr 5, 2013 at 1:53 AM, Lars-Peter Clausen wrote: > Since we sleep inside the protected section we need to use a mutex. Ah, good point. > It's not the timeout case I'm worried about, but the case where the transfer > is interrupted by the user. Even though it is rather unlikely fo

Re: [PATCH] iio: adc: add exynos5 adc driver under iio framwork

2013-01-24 Thread Doug Anderson
Lars, Thank you for your comments / thoughts... On Thu, Jan 24, 2013 at 1:54 AM, Lars-Peter Clausen wrote: > adc: adc@12D1 { > > #io-channel-cells = <1>; > io-channel-output-names = "adc1", "adc2", ...; > > ncp15wb473@0 { > compatible = "ntc,ncp15wb47

Re: [PATCH v3 0/2] Add automatic bus number support for i2c busses with device tree

2013-02-26 Thread Doug Anderson
Wolfram, On Mon, Feb 11, 2013 at 4:48 PM, Doug Anderson wrote: > This was suggested by Mark Brown in response to a patch for adding > this functionality only for the s3c2410 bus: > https://lkml.org/lkml/2012/11/20/681 > > I have also modified the i2c-pxa driver to use this ne

Re: [PATCH v3 0/2] Add automatic bus number support for i2c busses with device tree

2013-02-28 Thread Doug Anderson
Wolfram, On Thu, Feb 28, 2013 at 3:25 PM, Wolfram Sang wrote: > > Regarding patch 1, I was waiting for the idr changes to hit mainline. > They are mainline now, but since the removal of MAX_IDR_MASK your patch > doesn't apply anymore :( Can you rebase and retest, please? I'd like to > get it into

Re: [PATCH v2] iio: adc: exynos5_adc: fix compilation warnings

2013-03-12 Thread Doug Anderson
Naveen, On Wed, Mar 6, 2013 at 7:09 PM, Naveen Krishna Chatradhi wrote: > - unsigned intversion; > + unsigned intversion; Given that you've changed exynos_adc_get_version() to return an int, shouldn't this be an int too (not unsigned)? > -static inline unsig

[PATCH 4/4] ARM: dts: Add adc and thermistors for exynos5250-snow

2013-03-12 Thread Doug Anderson
Hook up the exynos5250-snow thermistors via the device tree now that there's a driver available to use them. Signed-off-by: Doug Anderson --- arch/arm/boot/dts/cros5250-common.dtsi | 4 arch/arm/boot/dts/exynos5250-snow.dts | 31 +++ 2 files change

[PATCH 2/4] iio: adc: Add dt support for turning on the phy in exynos-adc

2013-03-12 Thread Doug Anderson
Without this change the exynos adc controller needed to have its phy enabled in some out-of-driver C code. Add support for specifying the phy enable register by listing it in the reg list. Signed-off-by: Doug Anderson --- .../devicetree/bindings/arm/samsung/exynos-adc.txt | 4

[PATCH 3/4] ARM: dts: Add adc to exynos5250 device tree file

2013-03-12 Thread Doug Anderson
Add the device tree entry for the device-tree enabled ADC driver that recently landed in the iio tree. Signed-off-by: Doug Anderson --- arch/arm/boot/dts/exynos5250.dtsi | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts

[PATCH 1/4] iio: adc: Document the regulator/clocks for exynos-adc

2013-03-12 Thread Doug Anderson
The exynos ADC won't work without a regulator called "vdd" and a clock called "adc". Document this fact in the device tree bindings. Signed-off-by: Doug Anderson --- Documentation/devicetree/bindings/arm/samsung/exynos-adc.txt | 8 1 file changed, 8 in

[PATCH 0/4] Get exynos adc driver running on on exynos5250-snow

2013-03-12 Thread Doug Anderson
.plus Naveen's recent ADC cleanup and NTC thermistor patch. Doug Anderson (4): iio: adc: Document the regulator/clocks for exynos-adc iio: adc: Add dt support for turning on the phy in exynos-adc ARM: dts: Add adc to exynos5250 device tree file ARM: dts: Add adc and thermistors for exyno

Re: [PATCH v2] hwmon: ntc: Add DT with IIO support to NTC thermistor driver

2013-03-12 Thread Doug Anderson
Hi, On Tue, Mar 12, 2013 at 6:45 AM, Guenter Roeck wrote: > On Tue, Mar 12, 2013 at 02:09:26PM +0530, Naveen Krishna Chatradhi wrote: >> This patch adds DT support to NTC driver to parse the >> platform data. >> >> Also adds the support to work as an iio device. >> >> During the probe ntc driver

Re: [PATCH v3 2/3] ARM: dts: Add i2c-arbitrator bus for exynos5250-snow

2013-03-13 Thread Doug Anderson
Kukjin, On Wed, Mar 13, 2013 at 12:30 AM, Kukjin Kim wrote: > BTW, Doug, I think, this should be re-worked to use pinctrl. Can you? Yes, I've already got this locally. I hadn't sent it up yet since I wasn't sure whether pinctrl would land before or after this. I'll send it up today against my

[PATCH v4 3/3] ARM: dts: Add sbs-battery for exynos5250-snow

2013-03-13 Thread Doug Anderson
Now that we have i2c-arbitrator in place on bus 4 we can add the sbs-battery driver. Future devices will be added onto bus 4 once drivers are in good shape. Signed-off-by: Doug Anderson Tested-by: Naveen Krishna Chatradhi --- Changes in v4: None Changes in v3: None Changes in v2: None arch

[PATCH v4 2/3] ARM: dts: Add i2c-arbitrator bus for exynos5250-snow

2013-03-13 Thread Doug Anderson
Signed-off-by: Doug Anderson Tested-by: Naveen Krishna Chatradhi --- Changes in v4: - Changed mux gpio syntax to work atop Thomas's "ARM: dts: add pin state information in client nodes for Exynos5 platforms"; avoid adding gpios property to i2c@12CA for the same reason. Chang

[PATCH v4 1/3] i2c: mux: Add i2c-arbitrator-cros-ec 'mux' driver

2013-03-13 Thread Doug Anderson
ry. Signed-off-by: Doug Anderson Signed-off-by: Simon Glass Signed-off-by: Naveen Krishna Chatradhi Reviewed-by: Stephen Warren Tested-by: Naveen Krishna Chatradhi --- Changes in v4: None Changes in v3: - Handle of_find_i2c_adapter_by_node() failure more properly by changing init order. - Do

Re: [PATCH v4 1/3] i2c: mux: Add i2c-arbitrator-cros-ec 'mux' driver

2013-03-13 Thread Doug Anderson
Stephen, On Wed, Mar 13, 2013 at 9:53 AM, Stephen Warren wrote: >> Changes in v4: None > > Isn't this 'PATCH V3 REPOST' then? In this case part 2 in the patch series changes but not parts 1 and 3. I could have just reposted part 2 with a higher version, but that makes it a little harder to piec

[PATCH] ARM: dts: add usb 2.0 clock references to device tree

2013-03-13 Thread Doug Anderson
This is a fixup to two device tree nodes that have already landed but without clock nodes since the transition to common clock happened at the same time. Signed-off-by: Doug Anderson --- arch/arm/boot/dts/exynos5250.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/boot

[PATCH] ARM: dts: add usb 2.0 clock references to exynos5250 device tree

2013-03-13 Thread Doug Anderson
This is a fixup to two device tree nodes that have already landed but without clock nodes since the transition to common clock happened at the same time. Signed-off-by: Doug Anderson --- arch/arm/boot/dts/exynos5250.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/boot

Re: [PATCH] ARM: dts: add usb 2.0 clock references to device tree

2013-03-13 Thread Doug Anderson
Argh... On Wed, Mar 13, 2013 at 10:17 AM, Doug Anderson wrote: > This is a fixup to two device tree nodes that have already landed but > without clock nodes since the transition to common clock happened at > the same time. > > Signed-off-by: Doug Anderson Please forgive my fat

Re: [PATCH] USB: ehci-s5p: Fix phy reset

2013-03-13 Thread Doug Anderson
Alexander, On Tue, Mar 12, 2013 at 6:09 PM, Alexander Graf wrote: > - err = gpio_request_one(gpio, GPIOF_OUT_INIT_HIGH, "ehci_vbus_gpio"); > - if (err) > + /* reset pulls the line down, then up again */ > + err = gpio_request_one(gpio, GPIOF_OUT_INIT_LOW, "ehci_vbus_gpio")

Re: [PATCH] USB: ehci-s5p: Fix phy reset

2013-03-13 Thread Doug Anderson
Alexander, On Wed, Mar 13, 2013 at 10:45 AM, Alexander Graf wrote: > >>> + gpio_free(gpio); >> >> Freeing the gpio is a little on the iffy side since you actually care >> about keeping the value. Perhaps you can change this to >> devm_gpio_request_one() and avoid the free? I was about to

Re: [PATCH v3] iio: adc: exynos5_adc: fix compilation warnings

2013-03-13 Thread Doug Anderson
Naveen, On Tue, Mar 12, 2013 at 9:48 PM, Naveen Krishna Chatradhi wrote: > Doug, There was a comment from Lars regarding the match not > being NULL, if driver depends on CONFIG_OF. So, i've removed > the NULL check in v2 of this patch. > https://patchwork.kernel.org/patch/841/ > > I'm

[REPOST PATCH] spi: Unlock a spinlock before calling into the controller driver.

2013-03-13 Thread Doug Anderson
it to hold queue_lock to protect the 'busy' flag, then release it to call unprepare_transfer_hardware(). Signed-off-by: Bryan Freed Reviewed-by: Doug Anderson Signed-off-by: Doug Anderson Acked-by: Linus Walleij --- During a rebase we noticed that this old patch never actually landed anywh

Re: [PATCH v3] iio: adc: exynos5_adc: fix compilation warnings

2013-03-13 Thread Doug Anderson
Lars, On Wed, Mar 13, 2013 at 11:11 AM, Lars-Peter Clausen wrote: > Agreed. Adding the dependency on OF in Kconfig should be all that is needed. I think changing the timeout from 'unsigned long' to 'long' is also legit (to match the actual type returned) and a good idea. -Doug -- To unsubscribe

Re: [PATCH v3] iio: adc: exynos5_adc: fix compilation warnings

2013-03-13 Thread Doug Anderson
Lars, On Wed, Mar 13, 2013 at 11:40 AM, Lars-Peter Clausen wrote: >> Yes, but that's a different issue and to be honest I didn't even realize >> that the patch was trying to fix this as well. In my opinion it's best to >> split this up into two patches one which fixes the OF dependency. The other

[PATCH v2 2/4] iio: adc: Add dt support for turning on the phy in exynos-adc

2013-03-13 Thread Doug Anderson
Without this change the exynos adc controller needed to have its phy enabled in some out-of-driver C code. Add support for specifying the phy enable register by listing it in the reg list. Signed-off-by: Doug Anderson --- Changes in v2: None .../devicetree/bindings/arm/samsung/exynos-adc.txt

[PATCH v2 1/4] iio: adc: Document the regulator/clocks for exynos-adc

2013-03-13 Thread Doug Anderson
The exynos ADC won't work without a regulator called "vdd" and a clock called "adc". Document this fact in the device tree bindings. Signed-off-by: Doug Anderson --- Changes in v2: None Documentation/devicetree/bindings/arm/samsung/exynos-adc.txt | 8 1 f

[PATCH v2 3/4] ARM: dts: Add adc to exynos5250 device tree file

2013-03-13 Thread Doug Anderson
Add the device tree entry for the device-tree enabled ADC driver that recently landed in the iio tree. Signed-off-by: Doug Anderson --- Changes in v2: None arch/arm/boot/dts/exynos5250.dtsi | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/arm/boot/dts/exynos5250.dtsi b

[PATCH v2 4/4] ARM: dts: Add adc and thermistors for exynos5250-snow

2013-03-13 Thread Doug Anderson
Hook up the exynos5250-snow thermistors via the device tree now that there's a driver available to use them. Signed-off-by: Doug Anderson --- Changes in v2: - Match 'uV' -> 'uv' change in Naveen's bindings. arch/arm/boot/dts/cros5250-common.dtsi | 4 arch

[PATCH v2 0/4] This set of patches is based on Naveen Krishna Chatradhi's recent work

2013-03-13 Thread Doug Anderson
exynos adc driver under iio framwork 298489f iio:common: Use spi_sync_transfer() in STMicroelectronics ... 1d9a4cb IIO ADC support for AD7923 9a282b0 iio: Add OF support 3d277fc3 staging:iio: Remove adt7410 driver Changes in v2: - Match 'uV' -> 'uv' change in Naveen

Re: [PATCH v4] hwmon: ntc: Add DT with IIO support to NTC thermistor driver

2013-03-13 Thread Doug Anderson
p1_input /sys/class/hwmon/hwmon0/device/temp1_input:37890 /sys/class/hwmon/hwmon1/device/temp1_input:38393 /sys/class/hwmon/hwmon2/device/temp1_input:37148 /sys/class/hwmon/hwmon3/device/temp1_input:38059 Tested-by: Doug Anderson -- To unsubscribe from this list: send the line "unsubscribe l

Re: [PATCH v2] USB: ehci-s5p: Fix phy reset

2013-03-13 Thread Doug Anderson
t; This patch implements the above logic, making EHCI and OHCI work on > Arndale systems for me. > > Signed-off-by: Alexander Graf > CC: Vivek Gautam > CC: Jingoo Han > CC: Alan Stern > CC: Kukjin Kim > CC: Felipe Balbi > CC: Greg Kroah-Hartman > CC: Doug Anders

Re: [PATCH v2] USB: ehci-s5p: Fix phy reset

2013-03-14 Thread Doug Anderson
Hi, On Thu, Mar 14, 2013 at 7:58 AM, Thomas Abraham wrote: >> I can see your point, but as I mentioned earlier there seems to be some >> timing issue here. By simply doing the reset a few ms earlier (in the first >> probe, before the driver detects that it needs to defer probing), I already >>

[PATCH] usb: Document clocks in samsung,exynos4210-ehci/ohci bindings

2013-03-14 Thread Doug Anderson
The exynox4210-ehci and exynos4210-ohci nodes need a clock specified using the common clock framework. Document it. Signed-off-by: Doug Anderson --- Documentation/devicetree/bindings/usb/exynos-usb.txt | 10 ++ 1 file changed, 10 insertions(+) diff --git a/Documentation/devicetree

Re: [PATCH] ARM: dts: add usb 2.0 clock references to exynos5250 device tree

2013-03-14 Thread Doug Anderson
Vivek, On Wed, Mar 13, 2013 at 11:22 PM, Vivek Gautam wrote: > It will be nice if you can please update relevant information > alongwith this, in the bindings doc for "exynos-usb". Sure. It always feels like device tree additions ought to be separate patches from bindings patches, so I'll just

[PATCH] usb: ehci-s5p: Use devm for requesting ehci_vbus_gpio

2013-03-14 Thread Doug Anderson
The ehci_vbus_gpio is requested but never freed. This can cause problems with deferred probes and would cause problems if s5p_ehci_remove was ever called. Use devm to fix this. Signed-off-by: Doug Anderson --- drivers/usb/host/ehci-s5p.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion

[PATCH v2] usb: Document clocks in samsung,exynos4210-ehci/ohci bindings

2013-03-14 Thread Doug Anderson
The exynox4210-ehci and exynos4210-ohci nodes need a clock specified using the common clock framework. Document it. Signed-off-by: Doug Anderson --- Changes in v2: - Fixed embarrassing typo adc=>usb. Thanks Jingoo! Documentation/devicetree/bindings/usb/exynos-usb.txt | 10 ++ 1 f

Re: [PATCH] usb: ehci-s5p: Use devm for requesting ehci_vbus_gpio

2013-03-14 Thread Doug Anderson
Jingoo, On Thu, Mar 14, 2013 at 5:30 PM, Jingoo Han wrote: > Would you replace other '&pdev->dev' with 'dev' in s5p_setup_vbus_gpio() > as below? It seems to be better for readability. Yes, of course. That was silly of me not to add the "dev" local and not update the other places... Thanks for

[PATCH v2] usb: ehci-s5p: Use devm for requesting ehci_vbus_gpio

2013-03-14 Thread Doug Anderson
The ehci_vbus_gpio is requested but never freed. This can cause problems with deferred probes and would cause problems if s5p_ehci_remove was ever called. Use devm to fix this. Signed-off-by: Doug Anderson --- Changes in v2: - &pdev->dev => dev elsewhere in s5p_setup_vbus_gpio() d

Re: [PATCH 1/2] iio: adc: Kconfig: exynos_adc depends on CONFIG_OF

2013-03-15 Thread Doug Anderson
Carpenter > Cc: Doug Anderson > Cc: Lars-Peter Clausen > --- > Discussion thread for this patch can be found at > http://www.gossamer-threads.com/lists/linux/kernel/1693284?page=last > > drivers/iio/adc/Kconfig |1 + > 1 file changed, 1 insertion(+) Reviewed-by: Doug And

[PATCH] RFC: mmc: dw_mmc: Always go to STATE_DATA_BUSY from STATE_DATA_ERROR

2013-03-15 Thread Doug Anderson
t at the end of dw_mci_interrupt() to show the result of the "mci_readl(host, IDSTS)" and saw 0xa000 in the case of the above CRC error. A proposed fix for this is to ignore (but still clear) the EVENT_XFER_COMPLETE in STATE_DATA_ERROR in the tasklet. Reported-by: Bing Zhao Signed-off

[PATCH] RFC: mmc: dw_mmc: Don't clear errors we aren't handling

2013-03-15 Thread Doug Anderson
Although there are no known cases of this being a problem (and it may be technically impossible for the hardware to report more errors once already in the error state), it seems unwise for us to be clearing error interrupts that we didn't actually read. Signed-off-by: Doug Anderson --- dr

Re: [RFC: PATCH 2/2] iio: adc: exynos_adc: Handle timeout and race conditions

2013-03-15 Thread Doug Anderson
On Fri, Mar 15, 2013 at 2:53 PM, Lars-Peter Clausen wrote: > What exactly is the spinlock protecting against here? Concurrent runs of > exynos_adc_isr? This is probably not issue in the first place. > > What you want to protect against is that completion is completed between the > call to INIT_COM

[PATCH] serial: samsung: Add poll_get_char & poll_put_char

2012-09-21 Thread Doug Anderson
From: Julien Pichon The following patch allows users to use KGDB over serial console on board based on Samsung SOC. It has been tested on a board using exynos5. Signed-off-by: Julien Pichon Signed-off-by: Doug Anderson (dianders changed poll to return NO_POLL_CHAR, which appears to fix '

Re: [PATCH v6 2/3] mmc: dw_mmc: Honor requests to set the clock to 0 (turn off clock)

2013-08-25 Thread Doug Anderson
Jaehoon, On Sun, Aug 25, 2013 at 6:31 PM, Jaehoon Chung wrote: > Hi Doug, > > On 08/24/2013 05:40 AM, Doug Anderson wrote: >> Jaehoon, >> >> On Fri, Aug 23, 2013 at 6:21 AM, Jaehoon Chung >> wrote: >>> Hi Doug, >>> >>> If the clock

Re: [PATCH v6 2/3] mmc: dw_mmc: Honor requests to set the clock to 0 (turn off clock)

2013-08-26 Thread Doug Anderson
Jaehoon / Seungwon, On Mon, Aug 26, 2013 at 2:06 AM, Jaehoon Chung wrote: > On 08/26/2013 01:34 PM, Seungwon Jeon wrote: >> On Fri, August 23, 2013, Doug Anderson wrote: >>> Previously the dw_mmc driver would ignore any requests to disable the >>> card's clock

Re: [PATCH] iio: exynos_adc: fix wrong structure extration in suspend and resume

2013-08-28 Thread Doug Anderson
Naveen On Tue, Aug 27, 2013 at 10:33 PM, Naveen Krishna Ch wrote: >> I would like to know any comments on >> >> https://patchwork.kernel.org/patch/2513361/ >> >> Its been pending for a while now. >> >> Thanks, >> Naveen > Ping > Any comments please I assume you're asking for a ping for the _othe

Re: [PATCH v6 2/3] mmc: dw_mmc: Honor requests to set the clock to 0 (turn off clock)

2013-08-29 Thread Doug Anderson
Seungwon, On Thu, Aug 29, 2013 at 12:04 AM, Seungwon Jeon wrote: >> I'd really still rather honor the MMC subsystem's request. It >> shouldn't _hurt_ to turn the clock off when the subsystem requests it, > Even though turning off by clock programming doesn't hurt, > it is costly behavior when co

[PATCH v7 3/3] mmc: dw_mmc: Set timeout to max upon resume

2013-08-29 Thread Doug Anderson
after suspend cleaner. Signed-off-by: Doug Anderson Acked-by: Seungwon Jeon Reviewed-by: Tomasz Figa --- Changes in v7: None Changes in v6: None Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: None drivers/mmc/host/dw_mmc.c | 3 +++ 1 file changed, 3 insertions(+) diff --

[PATCH v7 0/3] mmc: dw_mmc: fixes for suspend/resume on exynos

2013-08-29 Thread Doug Anderson
es in v4: - Take Seungwon's suggestion and don't add any dw_mmc-pltfm code. Changes in v3: - Add freeze/thaw and poweroff/restore noirq entries. Changes in v2: - Use suspend_noirq as per James Hogan. Doug Anderson (3): mmc: dw_mmc: Add exynos resume_noirq callback to clear WAKEUP_IN

[PATCH v7 2/3] mmc: dw_mmc: Honor requests to set the clock to 0 (turn off clock)

2013-08-29 Thread Doug Anderson
the slot and we do a suspend/resume cycle, we _do_ still end up with differences in a dw_mmc register dump, but the differences are clock related and we've got the clock disabled both before and after, so this should be OK. Signed-off-by: Doug Anderson --- Changes in v7: - Avoid printing the

[PATCH v7 1/3] mmc: dw_mmc: Add exynos resume_noirq callback to clear WAKEUP_INT

2013-08-29 Thread Doug Anderson
If the WAKEUP_INT is asserted at wakeup and not cleared, we'll end up looping around forever. This has been seen to happen on exynos5420 silicon despite the fact that we haven't enabled any wakeup events due to a silicon errata. It is safe to do on all exynos variants. Signed-of

[PATCH 2/5] mmc: dw_mmc: Add suspend/resume callbacks; disable irq during suspend

2013-07-09 Thread Doug Anderson
w the WAKEUP_INT interrupt firing upon resume and needed to add some code to handle this. Signed-off-by: Doug Anderson --- drivers/mmc/host/dw_mmc.c | 12 drivers/mmc/host/dw_mmc.h | 4 2 files changed, 16 insertions(+) diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc

[PATCH 4/5] mmc: dw_mmc: Always setup the bus after suspend/resume

2013-07-09 Thread Doug Anderson
) After this patch, only TMOUT was different. I have a separate patch for that. Signed-off-by: Doug Anderson --- drivers/mmc/host/dw_mmc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c index 2aaa93f..a0a07df 1006

[PATCH 3/5] mmc: dw_mmc: Add exynos resume callback to clear WAKEUP_INT

2013-07-09 Thread Doug Anderson
If the WAKEUP_INT is asserted at wakeup and not cleared, we'll end up looping around forever. Signed-off-by: Doug Anderson --- drivers/mmc/host/dw_mmc-exynos.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/d

[PATCH 5/5] mmc: dw_mmc: Set timeout to max upon resume

2013-07-09 Thread Doug Anderson
after suspend clean. Signed-off-by: Doug Anderson --- drivers/mmc/host/dw_mmc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c index a0a07df..eedb517 100644 --- a/drivers/mmc/host/dw_mmc.c +++ b/drivers/mmc/host/dw_mmc.c @@ -2494,6 +2494,9 @

[PATCH 1/5] mmc: dw_mmc: Invalidate cache of current_speed after suspend/resume

2013-07-09 Thread Doug Anderson
s that we don't need to call: dw_mci_setup_bus(slot, true); ...to force an update of the clock in the case when the slot was left powered. Signed-off-by: Doug Anderson --- drivers/mmc/host/dw_mmc.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/host/dw_mmc.c

[PATCH 0/5] mmc: dw_mmc: fixes for suspend/resume on exynos

2013-07-09 Thread Doug Anderson
usage (and compiling, honest!) against ToT Linux. Doug Anderson (5): mmc: dw_mmc: Invalidate cache of current_speed after suspend/resume mmc: dw_mmc: Add suspend/resume callbacks; disable irq during suspend mmc: dw_mmc: Add exynos resume callback to clear WAKEUP_INT mmc: dw_mmc: Always setup

Re: [PATCH 3/5] mmc: dw_mmc: Add exynos resume callback to clear WAKEUP_INT

2013-07-09 Thread Doug Anderson
Hi, On Tue, Jul 9, 2013 at 10:31 AM, Doug Anderson wrote: > If the WAKEUP_INT is asserted at wakeup and not cleared, we'll end up > looping around forever. > > Signed-off-by: Doug Anderson > --- > drivers/mmc/host/dw_mmc-exynos.c | 23 +++ > 1 f

[PATCH] mmc: dw_mmc: Handle DW_MCI_QUIRK_IDMAC_DTO properly

2013-07-09 Thread Doug Anderson
In (1fb5f68 mmc: dw_mmc: Don't loop when handling an interrupt), the code for handling DW_MCI_QUIRK_IDMAC_DTO became dead code. Move it to where it ought to live. Found by code inspection and compile-tested only--I don't know of any boards that need DW_MCI_QUIRK_IDMAC_DTO. Signed-of

Re: [PATCH 2/5] mmc: dw_mmc: Add suspend/resume callbacks; disable irq during suspend

2013-07-09 Thread Doug Anderson
James, On Tue, Jul 9, 2013 at 2:17 PM, James Hogan wrote: > Hi Doug, > > On 9 July 2013 18:31, Doug Anderson wrote: >> On some platforms (like exynos5420) the dw_mmc controller may be in a >> strange state after we wake up from sleep. Add callbacks to allow for >>

[PATCH v2 5/5] mmc: dw_mmc: Set timeout to max upon resume

2013-07-09 Thread Doug Anderson
after suspend clean. Signed-off-by: Doug Anderson --- Changes in v2: None drivers/mmc/host/dw_mmc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c index be095b7..d2c5db3 100644 --- a/drivers/mmc/host/dw_mmc.c +++ b/drivers/mmc/host/dw_

[PATCH v2 1/5] mmc: dw_mmc: Invalidate cache of current_speed after suspend/resume

2013-07-09 Thread Doug Anderson
s that we don't need to call: dw_mci_setup_bus(slot, true); ...to force an update of the clock in the case when the slot was left powered. Signed-off-by: Doug Anderson --- Changes in v2: - Fix typo (some -> come) - Use ~0 instead of 0x; add comment about value drivers/mmc/host/dw_mmc.c | 8 ++

[PATCH v2 3/5] mmc: dw_mmc: Add exynos resume_noirq callback to clear WAKEUP_INT

2013-07-09 Thread Doug Anderson
If the WAKEUP_INT is asserted at wakeup and not cleared, we'll end up looping around forever. This has been seen to happen on exynos5420 silicon despite the fact that we haven't enabled any wakeup events. Signed-off-by: Doug Anderson --- Changes in v2: - Use suspend_noirq as per J

[PATCH v2 4/5] mmc: dw_mmc: Always setup the bus after suspend/resume

2013-07-09 Thread Doug Anderson
) After this patch, only TMOUT was different. I have a separate patch for that. Signed-off-by: Doug Anderson --- Changes in v2: None drivers/mmc/host/dw_mmc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c index 7a5c

[PATCH v2 0/5] mmc: dw_mmc: fixes for suspend/resume on exynos

2013-07-09 Thread Doug Anderson
usage (and compiling, honest!) against ToT Linux. Changes in v2: - Fix typo (some -> come) - Use ~0 instead of 0x; add comment about value - Use suspend_noirq as per James Hogan. Doug Anderson (5): mmc: dw_mmc: Invalidate cache of current_speed after suspend/resume mmc: dw_mmc:

[PATCH v2 2/5] mmc: dw_mmc: Add suspend_noirq/resume_noirq callbacks for dw_mmc-pltfm

2013-07-09 Thread Doug Anderson
ned-off-by: Doug Anderson --- Changes in v2: - Use suspend_noirq as per James Hogan. drivers/mmc/host/dw_mmc-pltfm.c | 37 ++--- drivers/mmc/host/dw_mmc.h | 4 2 files changed, 38 insertions(+), 3 deletions(-) diff --git a/drivers/mmc/host/dw_mmc-pltfm.c

Re: [PATCH v2 3/5] mmc: dw_mmc: Add exynos resume_noirq callback to clear WAKEUP_INT

2013-07-10 Thread Doug Anderson
Seungwon, On Wed, Jul 10, 2013 at 7:54 AM, Seungwon Jeon wrote: > On Wed, July 10, 2013, Doug Anderson wrote: >> If the WAKEUP_INT is asserted at wakeup and not cleared, we'll end up >> looping around forever. This has been seen to happen on exynos5420 >> silico

Re: [PATCH v2 2/5] mmc: dw_mmc: Add suspend_noirq/resume_noirq callbacks for dw_mmc-pltfm

2013-07-10 Thread Doug Anderson
James, On Wed, Jul 10, 2013 at 1:37 AM, James Hogan wrote: >> -SIMPLE_DEV_PM_OPS(dw_mci_pltfm_pmops, dw_mci_pltfm_suspend, >> dw_mci_pltfm_resume); >> +const struct dev_pm_ops dw_mci_pltfm_pmops = { >> + SET_SYSTEM_SLEEP_PM_OPS(dw_mci_pltfm_suspend, dw_mci_pltfm_resume) >> + .suspend_noi

[PATCH v3 1/5] mmc: dw_mmc: Invalidate cache of current_speed after suspend/resume

2013-07-10 Thread Doug Anderson
s that we don't need to call: dw_mci_setup_bus(slot, true); ...to force an update of the clock in the case when the slot was left powered. Signed-off-by: Doug Anderson --- Changes in v3: None Changes in v2: - Fix typo (some -> come) - Use ~0 instead of 0x; add comment about value drivers/mm

[PATCH v3 4/5] mmc: dw_mmc: Always setup the bus after suspend/resume

2013-07-10 Thread Doug Anderson
) After this patch, only TMOUT was different. I have a separate patch for that. Signed-off-by: Doug Anderson --- Changes in v3: None Changes in v2: None drivers/mmc/host/dw_mmc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/ho

[PATCH v3 5/5] mmc: dw_mmc: Set timeout to max upon resume

2013-07-10 Thread Doug Anderson
after suspend clean. Signed-off-by: Doug Anderson Acked-by: Seungwon Jeon --- Changes in v3: None Changes in v2: None drivers/mmc/host/dw_mmc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c index be095b7..d2c5db3 100644 --- a/drivers/mmc

[PATCH v3 2/5] mmc: dw_mmc: Add suspend_noirq/resume_noirq callbacks for dw_mmc-pltfm

2013-07-10 Thread Doug Anderson
ned-off-by: Doug Anderson Reviewed-by: James Hogan --- Changes in v3: - Add freeze/thaw and poweroff/restore noirq entries. Changes in v2: - Use suspend_noirq as per James Hogan. drivers/mmc/host/dw_mmc-pltfm.c | 41 ++--- drivers/mmc/host/dw_mmc.h |

[PATCH v3 3/5] mmc: dw_mmc: Add exynos resume_noirq callback to clear WAKEUP_INT

2013-07-10 Thread Doug Anderson
If the WAKEUP_INT is asserted at wakeup and not cleared, we'll end up looping around forever. This has been seen to happen on exynos5420 silicon despite the fact that we haven't enabled any wakeup events. Signed-off-by: Doug Anderson --- Changes in v3: None Changes in v2: - Use suspen

[PATCH v3 0/5] mmc: dw_mmc: fixes for suspend/resume on exynos

2013-07-10 Thread Doug Anderson
usage (and compiling, honest!) against ToT Linux. Changes in v3: - Add freeze/thaw and poweroff/restore noirq entries. Changes in v2: - Fix typo (some -> come) - Use ~0 instead of 0x; add comment about value - Use suspend_noirq as per James Hogan. Doug Anderson (5): mmc: dw_mmc: Invalid

Re: [PATCH] Input: gpio_keys - wakeup_trigger

2013-09-13 Thread Doug Anderson
if the gpio is for a Lid Switch. > > Signed-off-by: Benson Leung As discussed out of band, I'd tend to put the masking/error checking in gpio_keys_get_devtree_pdata() then just rely on non-DT users not to pass in nonsense, but I don't feel that strongly about it, so: Revie

Re: Regression parsing GPT (EFI) partition tables

2013-10-10 Thread Doug Anderson
Hi, Just ran into this same problem and tracked it down to the same commit. Luckily Sean found this thread. :) On Wed, Oct 9, 2013 at 5:37 PM, Davidlohr Bueso wrote: > Hi Josh, > > On Wed, 2013-10-09 at 16:26 -0700, Josh Triplett wrote: >> When testing ChromeOS with a 3.12 kernel from git, I e

Re: Regression parsing GPT (EFI) partition tables

2013-10-10 Thread Doug Anderson
Hi, On Thu, Oct 10, 2013 at 2:26 PM, Davidlohr Bueso wrote: > On Thu, 2013-10-10 at 13:15 -0700, Doug Anderson wrote: >> Hi, >> >> Just ran into this same problem and tracked it down to the same >> commit. Luckily Sean found this thread. :) >> >> On Wed,

[PATCH] partitions/efi: treat size mismatch as a warning, not an error

2013-10-10 Thread Doug Anderson
igger disk. Since this case used to work (even without using force_gpt), keep it working and treat the size mismatch as a warning instead of an error. Reported-by: Josh Triplett Reported-by: Sean Paul Signed-off-by: Doug Anderson --- block/partitions/efi.c | 6 +- 1 file changed, 5 insert

Re: Regression parsing GPT (EFI) partition tables

2013-10-10 Thread Doug Anderson
Davidlohr, On Thu, Oct 10, 2013 at 3:31 PM, Davidlohr Bueso wrote: > Then you should *really* use the force_gpt option, which is there to > bypass any MBR checks, and you can avoid issues like this :) > > Anyway, this is still a regression and I believe we can go ahead and > just warn the user ab

Re: [PATCH] ARM: EXYNOS: no duplicate mask/unmask in eint0_15

2012-09-06 Thread Doug Anderson
k(&desc->irq_data); > - > generic_handle_irq(*irq_data); > - > - chip->irq_unmask(&desc->irq_data); > chained_irq_exit(chip, desc); > } > > -- > 1.7.7.3 > Acked-by: Doug Anderson -- To unsubscribe from this list: send the li

Re: [RFC PATCH 3/3] dt: Document: Add optional MAX77686 operating mode bindings

2012-12-10 Thread Doug Anderson
Abhilash, Thanks for posting up these patches. Just going to do my commenting directly on the documentation patch since they are high-level comments. On Sun, Dec 9, 2012 at 10:26 PM, Abhilash Kesavan wrote: > Add documenatation for various operating mode capabilities of > the MAX77686 PMIC. > >

Re: [PATCH] [RFC] cpufreq: can't raise max frequency with cpu_thermal

2012-12-18 Thread Doug Anderson
limits(policy, 0, max_freq); > > -- > 1.7.7.3 > Sonny's change matches what the "ACPI version" of this code (drivers/acpi/processor_thermal.c) does as well. I would certainly be interested to know why the code was added here in the first place. Amit: do you know? Re

  1   2   3   4   5   6   7   8   9   10   >