RE: [PATCH 14/19] scsi: Change variable type to bool

2013-09-23 Thread Dorau, Lukasz
On Sunday, September 22, 2013 12:28 AM Peter Senna Tschudin wrote: > > The variable success is only assigned the values true and false. > Change its type to bool. > > The simplified semantic patch that find this problem is as > follows (http://coccinelle.lip6.fr/): > > @exists@ > type T; > ide

RE: [PATCH v2 10/23] isci: Use pci_enable_msix_exact() instead of pci_enable_msix()

2014-03-03 Thread Dorau, Lukasz
On Monday, February 24, 2014 9:02 AM Alexander Gordeev wrote: > As result of deprecation of MSI-X/MSI enablement functions > pci_enable_msix() and pci_enable_msi_block() all drivers > using these two interfaces need to be updated to use the > new pci_enable_msi_range() or pci_enable_msi_exact()

RE: [PATCH] isci: update version to 1.2

2014-01-23 Thread Dorau, Lukasz
On Thursday, January 23, 2014 10:39 AM Lukasz Dorau wrote: > The version of isci driver has not been updated for 2 years. > It was 83 isci commits ago. Suspend/resume support has been implemented > and many bugs have been fixed since 1.1. Now update the version to 1.2. > > Signed-off-by: Lukasz

RE: [PATCH] for_each macros correctness

2014-01-27 Thread Dorau, Lukasz
On Sunday, January 26, 2014 11:54 AM Jose Alonso wrote: > I observed that there are for_each macros that do an extra memory access > beyond the defined area. > Normally this does not cause problems. > But, this can cause exceptions. For example: if the area is allocated at > the end of a page and

RE: [PATCH 2] libahci: fix turning on LEDs in ahci_start_port()

2013-10-16 Thread Dorau, Lukasz
On Tuesday, October 15, 2013 3:41 PM Tejun Heo wrote: > On Mon, Oct 14, 2013 at 06:18:53PM +0200, Lukasz Dorau wrote: > > If EM Transmit bit is busy during init ata_msleep() is called. > > It is wrong - msleep() should be used instead of ata_msleep(), because > > if EM Transmit bit is busy for one

RE: [PATCH] md: Fix skipping recovery for read-only arrays.

2013-10-16 Thread Dorau, Lukasz
On Wednesday, October 16, 2013 5:50 AM NeilBrown wrote: > On Mon, 07 Oct 2013 16:25:51 +0200 Lukasz Dorau > wrote: > > > Since: > > commit 7ceb17e87bde79d285a8b988cfed9eaeebe60b86 > > md: Allow devices to be re-added to a read-only array. > > > > spares are activated on a read-on

RE: [PATCH] libahci: fix turning on LEDs in ahci_start_port()

2013-10-14 Thread Dorau, Lukasz
On Monday, October 14, 2013 3:21 PM Tejun Heo wrote: > On Mon, Oct 14, 2013 at 02:58:19PM +0200, Lukasz Dorau wrote: > > If EM Transmit bit is busy during init ata_msleep() is called. > > It is wrong - msleep() should be used instead of ata_msleep(), because > > if EM Transmit bit is busy for one

RE: [PATCH] libahci: correct a misleading comment

2014-01-17 Thread Dorau, Lukasz
On Friday, January 17, 2014 1:00 PM Tejun Heo wrote: > On Fri, Jan 17, 2014 at 12:43:20PM +0100, Lukasz Dorau wrote: > > There is an error in a comment introduced by: > > commit fa070ee6dc70bcc19737a2406d741b089b3149d5 > > libahci: fix turning on LEDs in ahci_start_port() > > > > Correct i

Why is (2 < 2) true? Is it a gcc bug?

2014-01-17 Thread Dorau, Lukasz
Hi My story is very simply... I applied the following patch: diff --git a/drivers/scsi/isci/init.c b/drivers/scsi/isci/init.c --- a/drivers/scsi/isci/init.c +++ b/drivers/scsi/isci/init.c @@ -698,8 +698,11 @@ static int isci_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)

RE: Why is (2 < 2) true? Is it a gcc bug?

2014-01-17 Thread Dorau, Lukasz
On Friday, January 17, 2014 2:37 PM Dorau, Lukasz wrote: > > Hi > > My story is very simply... > I applied the following patch: > > diff --git a/drivers/scsi/isci/init.c b/drivers/scsi/isci/init.c > --- a/drivers/scsi/isci/init.c > +++ b/drivers/scsi/isci/init.c &g

RE: Why is (2 < 2) true? Is it a gcc bug?

2014-01-17 Thread Dorau, Lukasz
On Friday, January 17, 2014 2:58 PM Richard Weinberger wrote: > > Can you reproduce this using a standalone test? > I.e: > #include > > int main() > { > assert(2 < 2 != 1); > > return 0; > } > No, I can't of course. Lukasz -- To unsubscribe from this list: send the line "u

RE: Why is (2 < 2) true? Is it a gcc bug?

2014-01-17 Thread Dorau, Lukasz
On Friday, January 17, 2014 5:40 PM Sebastian Riemer wrote: > On 17.01.2014 14:55, Dorau, Lukasz wrote: > > > > Some additional information: > > > > The loop 'for' in macro ' for_each_isci_host ' defined as > (drivers/scsi/isci/host.h:313):

RE: Why is (2 < 2) true? Is it a gcc bug?

2014-01-18 Thread Dorau, Lukasz
;> > On Fri, Jan 17, 2014 at 5:37 AM, Dorau, Lukasz > wrote: > >> >> Hi > >> >> > >> >> My story is very simply... > >> >> I applied the following patch: > >> >> > >> >> diff --git a/drivers/scsi

RE: [PATCH] isci: reformulate for_each_isci_host macro to fix an oops

2014-01-20 Thread Dorau, Lukasz
On Thursday, January 16, 2014 2:16 PM Lukasz Dorau wrote: > > The loop 'for' in macro 'for_each_isci_host' (drivers/scsi/isci/init.c:717) > is executed more times than it can be. Regardless the condition: >'id < ARRAY_SIZE(to_pci_info(pdev)->hosts)' (drivers/scsi/isci/host.h:315) > it is exe

RE: [PATCH] isci: correct erroneous for_each_isci_host macro

2014-01-21 Thread Dorau, Lukasz
On Monday, January 20, 2014 7:26 PM Dan Williams wrote: > On Mon, Jan 20, 2014 at 8:54 AM, Lukasz Dorau wrote: > > In the first place, the loop 'for' in the macro 'for_each_isci_host' > > (drivers/scsi/isci/host.h:314) is incorrect, because it accesses > > the 3rd element of 2 element array. Aft

RE: [PATCH 19/55] scsi: Mark function as static in isci/phy.c

2014-03-31 Thread Dorau, Lukasz
On Saturday, March 29, 2014 7:04 PM Rashika Kheria wrote: > > Mark function as static in isci/phy.c because it is not used outside > this file. > > This eliminates the following warning in isci/phy.c: > drivers/scsi/isci/phy.c:672:6: warning: no previous prototype for > ‘scu_link_layer_set_txco

RE: [PATCH 21/55] scsi: Mark function as static in isci/port.c

2014-03-31 Thread Dorau, Lukasz
On Saturday, March 29, 2014 7:07 PM Rashika Kheria wrote: > Mark function as static in isci/port.c because they are not used outside > this file. > > This eliminates the following warning in isci/port.c: > drivers/scsi/isci/port.c:65:13: warning: no previous prototype for > ‘port_state_name’ [-W

RE: [PATCH 20/55] scsi: Mark function as static in isci/remote_device.c

2014-03-31 Thread Dorau, Lukasz
On Saturday, March 29, 2014 7:05 PM Rashika Kheria wrote: > Mark function as static in isci/remote_device.c because it is not used > outside this file. > > This eliminates the following warning in isci/remote_device.c: > drivers/scsi/isci/remote_device.c:1387:6: warning: no previous prototype fo

RE: [PATCH 19/55] scsi: Mark function as static in isci/phy.c

2014-03-31 Thread Dorau, Lukasz
On Monday, March 31, 2014 11:36 AM Josh Triplett wrote: > On Mon, Mar 31, 2014 at 08:54:49AM +0000, Dorau, Lukasz wrote: > > On Saturday, March 29, 2014 7:04 PM Rashika Kheria > wrote: > > > > > > Mark function as static in isci/phy.c because it is no

RE: [PATCH 10/22] isci: Use pci_enable_msix_range()

2014-02-06 Thread Dorau, Lukasz
On Tuesday, February 04, 2014 12:17 PM Alexander Gordeev wrote: > As result of deprecation of MSI-X/MSI enablement functions > pci_enable_msix() and pci_enable_msi_block() all drivers > using these two interfaces need to be updated to use the > new pci_enable_msi_range() and pci_enable_msix_range

Cannot attach BPF to tracepoints

2017-03-10 Thread Dorau, Lukasz
Hi, I cannot attach BPF to tracepoints. I used bcc's (https://github.com/iovisor/bcc) trace.py tool: https://github.com/iovisor/bcc/blob/master/tools/trace.py to test this issue: # /usr/share/bcc/tools/trace t:syscalls:sys_enter_open ioctl(PERF_EVENT_IOC_SET_BPF): Invalid argument Failed to atta