[PATCH 0/2] mmc: core: add a new property

2021-02-16 Thread DooHyun Hwang
Add an optional property to not retry multiple block read error with several single block reads. DooHyun Hwang (2): dt-bindings: mmc: Add no-single-read-retry property mmc: core: Add no single read retries Documentation/devicetree/bindings/mmc/mmc-controller.yaml | 6 ++ drivers/mmc

[PATCH 2/2] mmc: core: Add no single read retries

2021-02-16 Thread DooHyun Hwang
read operations as I/O error as much as retrying single block reads. Signed-off-by: DooHyun Hwang --- drivers/mmc/core/block.c | 3 ++- drivers/mmc/core/host.c | 6 ++ include/linux/mmc/host.h | 3 +++ 3 files changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/core/block.c b

[PATCH 1/2] dt-bindings: mmc: Add no-single-read-retry property

2021-02-16 Thread DooHyun Hwang
Add an optional property to not retry multiple block read error with several single block reads. This property makes to handle read errors faster by not retrying multiple block read errors with single block reads. Signed-off-by: DooHyun Hwang --- Documentation/devicetree/bindings/mmc/mmc

[PATCH 0/2] mmc: core: add a new property

2021-02-16 Thread DooHyun Hwang
Add an optional property to not retry multiple block read error with several single block reads. DooHyun Hwang (2): dt-bindings: mmc: Add no-single-read-retry property mmc: core: Add no single read retries Documentation/devicetree/bindings/mmc/mmc-controller.yaml | 6 ++ drivers/mmc

[PATCH 1/2] dt-bindings: mmc: Add no-single-read-retry property

2021-02-16 Thread DooHyun Hwang
Add an optional property to not retry multiple block read error with several single block reads. This property makes to handle read errors faster by not retrying multiple block read errors with single block reads. Signed-off-by: DooHyun Hwang --- Documentation/devicetree/bindings/mmc/mmc

[PATCH 2/2] mmc: core: Add no single read retries

2021-02-16 Thread DooHyun Hwang
read operations as I/O error as much as retrying single block reads. Signed-off-by: DooHyun Hwang --- drivers/mmc/core/block.c | 3 ++- drivers/mmc/core/host.c | 6 ++ include/linux/mmc/host.h | 3 +++ 3 files changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/core/block.c b

RE: [PATCH] mmc: core: add a power cycle when CMD11 fails

2021-02-24 Thread DooHyun Hwang
Dear Maintainers and commiters. Please review this patch for updating. Thanks and regards. DooHyun Hwang. On 17/02/10 4:59 am, DooHyun Hwang wrote: >Subject: [PATCH] mmc: core: add a power cycle when CMD11 fails > >A power cycle is required if CMD11 fails. >CMD11 failure should be h

[PATCH] mmc: core: add a power cycle when CMD11 fails

2021-02-09 Thread DooHyun Hwang
Card, CMD11 may fail but the card may have already invoked the voltage switch sequence. In this case, it is necessary to retry without voltage switching after power cycle. Signed-off-by: DooHyun Hwang --- drivers/mmc/core/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

RE: [PATCH 2/2] mmc: core: Add no single read retries

2021-02-17 Thread DooHyun Hwang
On 17/02/21 8:00 am, Adrian Hunter wrote: >On 17/02/21 7:46 am, Adrian Hunter wrote: >> On 17/02/21 7:22 am, DooHyun Hwang wrote: >>> This makes to handle read errors faster by not retrying multiple >>> block read(CMD18) errors with single block reads(CMD17). >&g

[PATCH] scsi: ufs: Add total count for each error history

2021-02-02 Thread DooHyun Hwang
Since the total error history count is unknown because the error history records only the number of UFS_EVENT_HIST_LENGTH, add a member to count each error history. Signed-off-by: DooHyun Hwang --- drivers/scsi/ufs/ufshcd.c | 3 +++ drivers/scsi/ufs/ufshcd.h | 1 + 2 files changed, 4 insertions

RE: [PATCH] scsi: ufs: Add total count for each error history

2021-02-03 Thread DooHyun Hwang
Hi Thank you for your review and I found the below commit in linux-next. So, I'll reject this patch. >On 3/02/21 8:53 am, DooHyun Hwang wrote: >> Since the total error history count is unknown because the error >> history records only the number of UFS_EVENT_HIST_LENGTH, add

[PATCH] scsi: ufs: print the counter of each event history

2021-02-03 Thread DooHyun Hwang
Since only print the recorded event history list, add to print the counter value. Signed-off-by: DooHyun Hwang --- drivers/scsi/ufs/ufshcd.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index 721f55db181f..1ea920aeb701 100644 --- a

[PATCH 1/3] scsi: ufs: retry link startup if that fails and device state is not active

2021-02-04 Thread DooHyun Hwang
Remove unnecessary link startup command if it was completed. UniPro stack is reset and enabled when ufshc is enabled. The link startup command is issued after enabling ufshc, if link startup is completed, there is no needed to issue again. Signed-off-by: DooHyun Hwang --- drivers/scsi/ufs

[PATCH 3/3] scsi: ufs: reset the ufs device before link startup retry

2021-02-04 Thread DooHyun Hwang
If the link startup command fails, trigger hardware reset to reset the UFS device before link startup retry. Signed-off-by: DooHyun Hwang --- drivers/scsi/ufs/ufshcd.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index

[PATCH 2/3] scsi: ufs: set device state to power-off before 1st link startup

2021-02-04 Thread DooHyun Hwang
In the ufshcd init sequence, device state should be power-off bacause the UFS device is not active. Signed-off-by: DooHyun Hwang --- drivers/scsi/ufs/ufshcd.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index

RE: [PATCH] scsi: ufs: print the counter of each event history

2021-02-05 Thread DooHyun Hwang
>> >> Since only print the recorded event history list, add to print the >> counter value. >> >> Signed-off-by: DooHyun Hwang >Reviewed-by: Avri Altman > >Btw, You have the counter now in ufs-debugfs as well. > >Thanks, >Avri Thank you for yo

RE: [PATCH] mmc: core: add a power cycle when CMD11 fails

2021-03-03 Thread DooHyun Hwang
On Tue, 2 Mar 2021 at 10:38, Ulf Hansson wrote: >On Wed, 10 Feb 2021 at 06:12, DooHyun Hwang >wrote: >> >> A power cycle is required if CMD11 fails. >> CMD11 failure should be handled as no response. >> >> If there is a timeout error that means no response to

RE: [PATCH] mmc: core: add a power cycle when CMD11 fails

2021-03-03 Thread DooHyun Hwang
On Tue, 2 Mar 2021 at 10:38, Ulf Hansson wrote: >On Wed, 10 Feb 2021 at 06:12, DooHyun Hwang >wrote: >> >> A power cycle is required if CMD11 fails. >> CMD11 failure should be handled as no response. >> >> If there is a timeout error that means no respo

RE: [PATCH] mmc: core: add a power cycle when CMD11 fails

2021-03-03 Thread DooHyun Hwang
On Wed, 3 Mar 2021 at 12:00, Ulf Hansson wrote: > >On Wed, 3 Mar 2021 at 07:30, DooHyun Hwang wrote: >> >> On Tue, 2 Mar 2021 at 10:38, Ulf Hansson wrote: >> >On Wed, 10 Feb 2021 at 06:12, DooHyun Hwang >> > >> >wrote: >> >> >> &