Re: [PATCH v6 1/2] selftests: Rename sigaltstack to generic signal

2024-09-03 Thread Dev Jain
On 9/4/24 03:14, Shuah Khan wrote: On 8/30/24 10:29, Dev Jain wrote: On 8/27/24 17:16, Dev Jain wrote: On 8/27/24 17:14, Shuah Khan wrote: On 8/22/24 06:14, Dev Jain wrote: Rename sigaltstack to generic signal directory, to allow adding more signal tests in the future. Sorry - I think

Re: [PATCH v6 1/2] selftests: Rename sigaltstack to generic signal

2024-09-04 Thread Dev Jain
On 9/4/24 22:35, Shuah Khan wrote: On 9/3/24 22:52, Dev Jain wrote: On 9/4/24 03:14, Shuah Khan wrote: On 8/30/24 10:29, Dev Jain wrote: On 8/27/24 17:16, Dev Jain wrote: On 8/27/24 17:14, Shuah Khan wrote: On 8/22/24 06:14, Dev Jain wrote: Rename sigaltstack to generic signal

Re: [PATCH v6 1/2] selftests: Rename sigaltstack to generic signal

2024-09-08 Thread Dev Jain
On 9/7/24 01:29, Shuah Khan wrote: On 9/4/24 23:56, Dev Jain wrote: On 9/4/24 22:35, Shuah Khan wrote: On 9/3/24 22:52, Dev Jain wrote: On 9/4/24 03:14, Shuah Khan wrote: On 8/30/24 10:29, Dev Jain wrote: On 8/27/24 17:16, Dev Jain wrote: On 8/27/24 17:14, Shuah Khan wrote: On 8/22

Re: [PATCH v6 1/2] selftests: Rename sigaltstack to generic signal

2024-09-15 Thread Dev Jain
On 9/9/24 23:24, Shuah Khan wrote: On 9/8/24 23:16, Dev Jain wrote: On 9/7/24 01:29, Shuah Khan wrote: On 9/4/24 23:56, Dev Jain wrote: On 9/4/24 22:35, Shuah Khan wrote: On 9/3/24 22:52, Dev Jain wrote: On 9/4/24 03:14, Shuah Khan wrote: On 8/30/24 10:29, Dev Jain wrote: On 8/27/24

[RESEND] [PATCH v6 0/2] Add test to distinguish between thread's signal mask and ucontext_t

2024-10-08 Thread Dev Jain
functions/syscalls - Mention tests in Makefile and .gitignore in alphabetical order v1: - https://lore.kernel.org/all/20240607122319.768640-1-dev.j...@arm.com/ Dev Jain (2): selftests: Rename sigaltstack to generic signal selftests: Add a test mangling with uc_sigmask tools/testing/selfte

[RESEND] [PATCH v6 1/2] selftests: Rename sigaltstack to generic signal

2024-10-08 Thread Dev Jain
Rename sigaltstack to generic signal directory, to allow adding more signal tests in the future. Signed-off-by: Dev Jain Reviewed-by: Mark Brown Acked-by: Shuah Khan --- tools/testing/selftests/Makefile| 2 +- tools/testing/selftests/{sigaltstack => sig

[RESEND] [PATCH v6 2/2] selftests: Add a test mangling with uc_sigmask

2024-10-08 Thread Dev Jain
signal, delivered signal, and ucontext. The ucontext is mangled with, by adding a signal mask to it; on return from the handler, the thread must block the corresponding signal. In the test description, I have also described signal delivery and blockage, for ease of understanding what the test does

Re: [PATCH v6 1/2] selftests: Rename sigaltstack to generic signal

2024-10-06 Thread Dev Jain
On 9/16/24 09:28, Dev Jain wrote: On 9/9/24 23:24, Shuah Khan wrote: On 9/8/24 23:16, Dev Jain wrote: On 9/7/24 01:29, Shuah Khan wrote: On 9/4/24 23:56, Dev Jain wrote: On 9/4/24 22:35, Shuah Khan wrote: On 9/3/24 22:52, Dev Jain wrote: On 9/4/24 03:14, Shuah Khan wrote: On 8/30/24

[RESEND] [PATCH v6 0/2] Add test to distinguish between thread's signal mask and ucontext_t

2024-10-28 Thread Dev Jain
Pingplease pull this

Re: [PATCH v2] selftests/damon/access_memory_even: remove unused variables

2024-09-23 Thread Dev Jain
On 9/24/24 07:44, Ba Jing wrote: By reading the code, I found these variables are never referenced in the code. Just remove them. Signed-off-by: Ba Jing Reviewed-by: Dev Jain

Re: [PATCH 1/3] selftests/mm: virtual_address_range: Fix error when CommitLimit < 1GiB

2025-01-07 Thread Dev Jain
On 07/01/25 8:44 pm, Thomas Weißschuh wrote: If not enough physical memory is available the kernel may fail mmap(); see __vm_enough_memory() and vm_commit_limit(). In that case the logic in validate_complete_va_space() does not make sense and will even incorrectly fail. Instead skip the test if

Re: [PATCH] selftests/mm: Fix thuge-gen test name uniqueness

2025-02-04 Thread Dev Jain
print the size in bytes which is confusing. Otherwise: Reviewed-by: Dev Jain

Re: [PATCH] selftests/mm: Added new test cases to the migration test

2024-12-19 Thread Dev Jain
passed. # Totals: pass:6 fail:0 xfail:0 xpass:0 skip:0 error:0 # Signed-off-by: Donet Tom --- Reviewed-by: Dev Jain

Re: [PATCH 3/3] selftests/mm: virtual_address_range: Dump to /dev/null

2025-01-08 Thread Dev Jain
On 08/01/25 7:00 pm, David Hildenbrand wrote: On 08.01.25 07:09, Dev Jain wrote: On 07/01/25 8:44 pm, Thomas Weißschuh wrote: During the execution of validate_complete_va_space() a lot of memory is on the VM subsystem. When running on a low memory subsystem an OOM may be triggered, when

Re: [PATCH 1/3] selftests/mm: virtual_address_range: Fix error when CommitLimit < 1GiB

2025-01-08 Thread Dev Jain
On 08/01/25 9:43 pm, Thomas Weißschuh wrote: On Wed, Jan 08, 2025 at 02:36:57PM +0100, David Hildenbrand wrote: On 08.01.25 09:05, Thomas Weißschuh wrote: On Wed, Jan 08, 2025 at 11:46:19AM +0530, Dev Jain wrote: On 07/01/25 8:44 pm, Thomas Weißschuh wrote: If not enough physical memory is

Re: [PATCH v2] selftests/mm/cow: Modify the incorrect checking parameters

2025-01-12 Thread Dev Jain
onymous pages") Signed-off-by: Hao Ge --- You should also CC the person whose code you are changing, in this case, David Hildenbrand. Reviewed-by: Dev Jain

Re: [PATCH v3 1/4] selftests/mm: virtual_address_range: mmap() without PROT_WRITE

2025-01-13 Thread Dev Jain
failure. As the mappings are never written to anyways, the flag can be removed. Fixes: 010409649885 ("selftests/mm: confirm VA exhaustion without reliance on correctness of mmap()") Signed-off-by: Thomas Weißschuh Acked-by: David Hildenbrand Acked-by: Dev Jain --- tools/testing/se

Re: [PATCH v2 1/3] selftests/mm: virtual_address_range: mmap() without PROT_WRITE

2025-01-10 Thread Dev Jain
failure. As the mappings are never written to anyways, the flag can be removed. Fixes: 010409649885 ("selftests/mm: confirm VA exhaustion without reliance on correctness of mmap()") Signed-off-by: Thomas Weißschuh Thanks! FWIW: Acked-by: Dev Jain

Re: [PATCH v3 01/10] selftests/mm: Report errno when things fail in gup_longterm

2025-02-28 Thread Dev Jain
On 28/02/25 10:24 pm, Brendan Jackman wrote: Just reporting failure doesn't tell you what went wrong. This can fail in different ways so report errno to help the reader get started debugging. Signed-off-by: Brendan Jackman Reviewed-by: Dev Jain

Re: [PATCH v3 05/10] selftests/mm: Print some details when uffd-stress gets bad params

2025-02-28 Thread Dev Jain
On 28/02/25 10:24 pm, Brendan Jackman wrote: So this can be debugged more easily. Signed-off-by: Brendan Jackman Reviewed-by: Dev Jain

Re: [PATCH v3 02/10] selftests/mm: Skip uffd-stress if userfaultfd not available

2025-03-02 Thread Dev Jain
On 28/02/25 10:24 pm, Brendan Jackman wrote: It's pretty obvious that the test wouldn't work if you don't have the feature enabled. But, it's still useful to SKIP instead of failing so the reader can immediately tell that this is the reason why. Signed-off-by: Brendan Jackman --- tools/tes

Re: [PATCH v3 03/10] selftests/mm: Skip uffd-wp-mremap if userfaultfd not available

2025-03-03 Thread Dev Jain
+ Muhammad, I guess he has been working on selftests, maybe he can chime in. On 03/03/25 4:18 pm, Brendan Jackman wrote: On Fri, Feb 28, 2025 at 10:55:00PM +0530, Dev Jain wrote: On 28/02/25 10:24 pm, Brendan Jackman wrote: It's obvious that this should fail in that case, but still,

Re: [PATCH v3 04/10] selftests/mm/uffd: Rename nr_cpus -> nr_threads

2025-03-03 Thread Dev Jain
On 03/03/25 4:04 pm, Brendan Jackman wrote: On Mon, Mar 03, 2025 at 03:48:38PM +0530, Dev Jain wrote: On 03/03/25 3:17 pm, Brendan Jackman wrote: On Fri, Feb 28, 2025 at 11:06:35PM +0530, Dev Jain wrote: Taking a cursory look at the test, it creates three threads for each cpu. The

Re: [PATCH v3 04/10] selftests/mm/uffd: Rename nr_cpus -> nr_threads

2025-03-03 Thread Dev Jain
On 03/03/25 3:17 pm, Brendan Jackman wrote: On Fri, Feb 28, 2025 at 11:06:35PM +0530, Dev Jain wrote: Taking a cursory look at the test, it creates three threads for each cpu. The bounding of the variable is fine but that being the reason to rename the variable is not making sense to me

Re: [PATCH] selftests/mm/cow: Fix the incorrect error handling

2025-03-10 Thread Dev Jain
On 11/03/25 8:07 am, Cyan Yang wrote: There are two error handlings did not check the correct return value. This patch will fix them. Fixes: f4b5fd6946e244cdedc3bbb9a1f24c8133b2077a ("selftests/vm: anon_cow: THP tests") Signed-off-by: Cyan Yang --- tools/testing/selftests/mm/cow.c | 4 ++-

Re: [PATCH v3 04/10] selftests/mm/uffd: Rename nr_cpus -> nr_threads

2025-02-28 Thread Dev Jain
On 28/02/25 10:24 pm, Brendan Jackman wrote: A later commit will bound this variable so it no longer necessarily matches the number of CPUs. Rename it appropriately. Signed-off-by: Brendan Jackman --- tools/testing/selftests/mm/uffd-common.c | 8 tools/testing/selftests/mm/u

Re: [PATCH v3 06/10] selftests/mm: Don't fail uffd-stress if too many CPUs

2025-02-28 Thread Dev Jain
Signed-off-by: Brendan Jackman --- Reviewed-by: Dev Jain

Re: [PATCH v3 03/10] selftests/mm: Skip uffd-wp-mremap if userfaultfd not available

2025-02-28 Thread Dev Jain
On 28/02/25 10:24 pm, Brendan Jackman wrote: It's obvious that this should fail in that case, but still, save the reader the effort of figuring out that they've run into this by just SKIPping Signed-off-by: Brendan Jackman --- tools/testing/selftests/mm/uffd-wp-mremap.c | 5 - 1 file

Re: [PATCH v3 09/10] selftests/mm: Drop unnecessary sudo usage

2025-02-28 Thread Dev Jain
ff-by: Brendan Jackman Reviewed-by: Dev Jain

Re: [PATCH v2] selftests/mm/cow: Fix the incorrect error handling

2025-03-11 Thread Dev Jain
On 12/03/25 10:08 am, Cyan Yang wrote: There is an error handling did not check the correct return value. This patch will fix it. Fixes: f4b5fd6946e244cdedc3bbb9a1f24c8133b2077a ("selftests/vm: anon_cow: THP tests") Signed-off-by: Cyan Yang Reviewed-by: Dev Jain

Re: [PATCH 1/6] selftests/mm: Report errno when things fail

2025-02-20 Thread Dev Jain
On 20/02/25 8:33 pm, Brendan Jackman wrote: Just reporting failure doesn't tell you what went wrong. This can fail in different ways so report errno to help the reader get started debugging. IMHO it would be even better if we reported strerror(errno). Signed-off-by: Brendan Jackman ---

Re: [PATCH 6/6] selftests/mm: Don't fail uffd-stress if too many CPUs

2025-02-20 Thread Dev Jain
On 20/02/25 8:33 pm, Brendan Jackman wrote: This calculation divides a fixed parameter by an environment-dependent parameter i.e. the number of CPUs. The simple way to avoid machine-specific failures here is to just put a cap on the max value of the latter. I haven't read the test, but if n

Re: [PATCH 3/6] selftests/mm: Skip uffd-stress if userfaultfd not available

2025-02-20 Thread Dev Jain
On 20/02/25 8:33 pm, Brendan Jackman wrote: It's pretty obvious that the test wouldn't work if you don't have the feature enabled. But, it's still useful to SKIP instead of failing so the reader can immediately tell that this is the reason why. Signed-off-by: Brendan Jackman --- tools/test

Re: [PATCH v1] selftests/mm: add simple VM_PFNMAP tests based on mmap'ing /dev/mem

2025-05-08 Thread Dev Jain
On 09/05/25 3:50 am, David Hildenbrand wrote: Let's test some basic functionality using /dev/mem. These tests will implicitly cover some PAT (Page Attribute Handling) handling on x86. These tests will only run when /dev/mem access to the first two pages in physical address space is possible a

Re: [PATCH 1/3] kselftest/arm64: Fix check for setting new VLs in sve-ptrace

2025-05-26 Thread Dev Jain
or the SVE ptrace interface") Signed-off-by: Mark Brown Acked-by: Dev Jain

Re: [PATCH] selftests/mm: Deduplicate test logging in test_mlock_lock()

2025-05-15 Thread Dev Jain
nc__); munmap(map, 2 * page_size); } Acked-by: Dev Jain --- base-commit: 82f2b0b97b36ee3fcddf0f0780a9a0825d52fec3 change-id: 20250514-selftest-mm-mlock2-dup-277d586bb29d Best regards,

Re: [PATCH] selftests/mm: Fix test result reporting in gup_longterm

2025-05-15 Thread Dev Jain
On 15/05/25 2:27 pm, Mark Brown wrote: The kselftest framework uses the string logged when a test result is reported as the unique identifier for a test, using it to track test results between runs. The gup_longterm test completely fails to follow this pattern, it runs a single test function r

Re: [PATCH] selftests/mm: Fix test result reporting in gup_longterm

2025-05-15 Thread Dev Jain
On 15/05/25 3:11 pm, Mark Brown wrote: On Thu, May 15, 2025 at 03:05:07PM +0530, Dev Jain wrote: On 15/05/25 2:27 pm, Mark Brown wrote: @@ -189,7 +214,10 @@ static void do_test(int fd, size_t size, enum test_type type, bool shared) * some previously unsupported

Re: [PATCH] selftests/mm: Deduplicate default page size test results in thuge-gen

2025-05-15 Thread Dev Jain
size, add the flags to the test name that is logged to deduplicate. Signed-off-by: Mark Brown Acked-by: Dev Jain

Re: [PATCH 1/6] mm/selftests: Fix virtual_address_range test issues.

2025-06-18 Thread Dev Jain
On 18/06/25 7:37 pm, Lorenzo Stoakes wrote: On Wed, Jun 18, 2025 at 07:28:16PM +0530, Dev Jain wrote: On 18/06/25 5:27 pm, Lorenzo Stoakes wrote: On Wed, Jun 18, 2025 at 05:15:50PM +0530, Dev Jain wrote: Are you accounting for sys.max_map_count? If not, then you'll be hitting that

Re: [PATCH 1/6] mm/selftests: Fix virtual_address_range test issues.

2025-06-18 Thread Dev Jain
On 18/06/25 8:05 pm, Lorenzo Stoakes wrote: On Wed, Jun 18, 2025 at 07:47:18PM +0530, Dev Jain wrote: On 18/06/25 7:37 pm, Lorenzo Stoakes wrote: On Wed, Jun 18, 2025 at 07:28:16PM +0530, Dev Jain wrote: On 18/06/25 5:27 pm, Lorenzo Stoakes wrote: On Wed, Jun 18, 2025 at 05:15:50PM +0530

Re: [PATCH 1/6] mm/selftests: Fix virtual_address_range test issues.

2025-06-18 Thread Dev Jain
On 18/06/25 3:36 pm, Donet Tom wrote: On Mon, Jun 16, 2025 at 09:57:10PM +0530, Dev Jain wrote: Hi Dev On 16/06/25 9:36 pm, Aboorva Devarajan wrote: From: Donet Tom In this patch, we are fixing three issues in the virtual_address_range test. 1. validate_addr() checks if the allocated

Re: [PATCH 1/6] mm/selftests: Fix virtual_address_range test issues.

2025-06-18 Thread Dev Jain
On 18/06/25 4:52 pm, Lorenzo Stoakes wrote: On Mon, Jun 16, 2025 at 09:57:10PM +0530, Dev Jain wrote: On 16/06/25 9:36 pm, Aboorva Devarajan wrote: From: Donet Tom 3./proc/self/maps may not always have gaps smaller than MAP_CHUNK_SIZE. The gap between the first high address mapping and the

Re: [PATCH 1/6] mm/selftests: Fix virtual_address_range test issues.

2025-06-18 Thread Dev Jain
On 18/06/25 5:07 pm, Lorenzo Stoakes wrote: On Wed, Jun 18, 2025 at 04:58:56PM +0530, Dev Jain wrote: MAP_CHUNK_SIZE was chosen randomly. Good to see it translates into something logical : ) So I guess I am correct, if we can find two VMAs (except at the edge of the high addr boundary

Re: [PATCH 1/6] mm/selftests: Fix virtual_address_range test issues.

2025-06-18 Thread Dev Jain
On 18/06/25 5:27 pm, Lorenzo Stoakes wrote: On Wed, Jun 18, 2025 at 05:15:50PM +0530, Dev Jain wrote: On 18/06/25 5:07 pm, Lorenzo Stoakes wrote: On Wed, Jun 18, 2025 at 04:58:56PM +0530, Dev Jain wrote: MAP_CHUNK_SIZE was chosen randomly. Good to see it translates into something logical

Re: [PATCH 1/6] mm/selftests: Fix virtual_address_range test issues.

2025-06-19 Thread Dev Jain
On 19/06/25 9:01 pm, Donet Tom wrote: eOn Thu, Jun 19, 2025 at 02:32:19PM +0530, Dev Jain wrote: On 19/06/25 1:53 pm, Donet Tom wrote: On Wed, Jun 18, 2025 at 08:13:54PM +0530, Dev Jain wrote: On 18/06/25 8:05 pm, Lorenzo Stoakes wrote: On Wed, Jun 18, 2025 at 07:47:18PM +0530, Dev Jain

Re: [PATCH 1/6] mm/selftests: Fix virtual_address_range test issues.

2025-06-19 Thread Dev Jain
On 19/06/25 1:53 pm, Donet Tom wrote: On Wed, Jun 18, 2025 at 08:13:54PM +0530, Dev Jain wrote: On 18/06/25 8:05 pm, Lorenzo Stoakes wrote: On Wed, Jun 18, 2025 at 07:47:18PM +0530, Dev Jain wrote: On 18/06/25 7:37 pm, Lorenzo Stoakes wrote: On Wed, Jun 18, 2025 at 07:28:16PM +0530, Dev

[PATCH] selftests/mm: Fix validate_addr helper

2025-06-20 Thread Dev Jain
; addr will be >= HIGH_ADDR_MARK always, we will fall down to "if (addr < HIGH_ADDR_MARK)" and return failure. Fix this. Fixes: d1d86ce28d0f ("selftests/mm: virtual_address_range: conform to TAP format output") Signed-off-by: Dev Jain --- tools/testing/selftests/mm/v

Re: [PATCH] selftests/mm: Fix validate_addr helper

2025-06-20 Thread Dev Jain
On 20/06/25 4:41 pm, Dev Jain wrote: validate_addr() function checks whether the address returned by mmap() lies in the low or high VA space, according to whether a high addr hint was passed or not. The fix commit mentioned below changed the code in such a way that this function will always

Re: [PATCH 1/6] mm/selftests: Fix virtual_address_range test issues.

2025-06-20 Thread Dev Jain
On 19/06/25 1:53 pm, Donet Tom wrote: On Wed, Jun 18, 2025 at 08:13:54PM +0530, Dev Jain wrote: On 18/06/25 8:05 pm, Lorenzo Stoakes wrote: On Wed, Jun 18, 2025 at 07:47:18PM +0530, Dev Jain wrote: On 18/06/25 7:37 pm, Lorenzo Stoakes wrote: On Wed, Jun 18, 2025 at 07:28:16PM +0530, Dev

Re: [PATCH 1/6] mm/selftests: Fix virtual_address_range test issues.

2025-06-22 Thread Dev Jain
On 23/06/25 10:23 am, Dev Jain wrote: On 21/06/25 11:25 pm, Donet Tom wrote: On Fri, Jun 20, 2025 at 08:15:25PM +0530, Dev Jain wrote: On 19/06/25 1:53 pm, Donet Tom wrote: On Wed, Jun 18, 2025 at 08:13:54PM +0530, Dev Jain wrote: On 18/06/25 8:05 pm, Lorenzo Stoakes wrote: On Wed, Jun

Re: [PATCH 1/6] mm/selftests: Fix virtual_address_range test issues.

2025-06-23 Thread Dev Jain
On 21/06/25 11:25 pm, Donet Tom wrote: On Fri, Jun 20, 2025 at 08:15:25PM +0530, Dev Jain wrote: On 19/06/25 1:53 pm, Donet Tom wrote: On Wed, Jun 18, 2025 at 08:13:54PM +0530, Dev Jain wrote: On 18/06/25 8:05 pm, Lorenzo Stoakes wrote: On Wed, Jun 18, 2025 at 07:47:18PM +0530, Dev Jain

Re: [PATCH 1/6] mm/selftests: Fix virtual_address_range test issues.

2025-06-25 Thread Dev Jain
On 25/06/25 3:06 pm, Donet Tom wrote: eOn Tue, Jun 24, 2025 at 11:45:09AM +0530, Dev Jain wrote: On 23/06/25 11:02 pm, Donet Tom wrote: On Mon, Jun 23, 2025 at 10:23:02AM +0530, Dev Jain wrote: On 21/06/25 11:25 pm, Donet Tom wrote: On Fri, Jun 20, 2025 at 08:15:25PM +0530, Dev Jain wrote

Re: [PATCH 1/6] mm/selftests: Fix virtual_address_range test issues.

2025-06-25 Thread Dev Jain
On 19/06/25 1:53 pm, Donet Tom wrote: On Wed, Jun 18, 2025 at 08:13:54PM +0530, Dev Jain wrote: On 18/06/25 8:05 pm, Lorenzo Stoakes wrote: On Wed, Jun 18, 2025 at 07:47:18PM +0530, Dev Jain wrote: On 18/06/25 7:37 pm, Lorenzo Stoakes wrote: On Wed, Jun 18, 2025 at 07:28:16PM +0530, Dev

Re: [PATCH 1/6] mm/selftests: Fix virtual_address_range test issues.

2025-06-16 Thread Dev Jain
On 16/06/25 9:36 pm, Aboorva Devarajan wrote: From: Donet Tom In this patch, we are fixing three issues in the virtual_address_range test. 1. validate_addr() checks if the allocated address is within the range. In the current implementation, if addr is greater than HIGH_ADDR_MARK, the test f

Re: [PATCH 3/6] selftests/mm : fix test_prctl_fork_exec failure

2025-06-16 Thread Dev Jain
On 16/06/25 9:36 pm, Aboorva Devarajan wrote: From: Donet Tom execv argument is an array of pointers to null-terminated strings. In this patch we added NULL in the execv argument to fix the test failure. Just a comment, how did this test suddenly start failing now? Also is a fixes tag requi

Re: [PATCH v2 1/2] selftests: khugepaged: fix the shmem collapse failure

2025-06-12 Thread Dev Jain
HPs are disabled by the hw/process/vma") Reviewed-by: Zi Yan Signed-off-by: Baolin Wang --- The test converts from fail to pass for me, for the aforementioned failures. Reviewed-by: Dev Jain Tested-by: Dev Jain

Re: [PATCH] selftests/mm: remove duplicate .gitignore entries

2025-06-25 Thread Dev Jain
... Reviewed-by: Dev Jain

Re: [PATCH 1/6] mm/selftests: Fix virtual_address_range test issues.

2025-06-25 Thread Dev Jain
On 25/06/25 10:47 pm, Donet Tom wrote: On Wed, Jun 25, 2025 at 06:22:53PM +0530, Dev Jain wrote: On 19/06/25 1:53 pm, Donet Tom wrote: On Wed, Jun 18, 2025 at 08:13:54PM +0530, Dev Jain wrote: On 18/06/25 8:05 pm, Lorenzo Stoakes wrote: On Wed, Jun 18, 2025 at 07:47:18PM +0530, Dev Jain

Re: [PATCH 1/6] mm/selftests: Fix virtual_address_range test issues.

2025-06-25 Thread Dev Jain
On 26/06/25 11:12 am, Donet Tom wrote: On Thu, Jun 26, 2025 at 09:27:30AM +0530, Dev Jain wrote: On 25/06/25 10:47 pm, Donet Tom wrote: On Wed, Jun 25, 2025 at 06:22:53PM +0530, Dev Jain wrote: On 19/06/25 1:53 pm, Donet Tom wrote: On Wed, Jun 18, 2025 at 08:13:54PM +0530, Dev Jain wrote

Re: [PATCH 1/6] mm/selftests: Fix virtual_address_range test issues.

2025-06-25 Thread Dev Jain
On 26/06/25 11:12 am, Donet Tom wrote: On Thu, Jun 26, 2025 at 09:27:30AM +0530, Dev Jain wrote: On 25/06/25 10:47 pm, Donet Tom wrote: On Wed, Jun 25, 2025 at 06:22:53PM +0530, Dev Jain wrote: On 19/06/25 1:53 pm, Donet Tom wrote: On Wed, Jun 18, 2025 at 08:13:54PM +0530, Dev Jain wrote

Re: [PATCH 2/2] selftests: mm: add shmem collpase as a default test item

2025-06-11 Thread Dev Jain
="thp" run_test ./khugepaged CATEGORY="thp" run_test ./khugepaged -s 2 +CATEGORY="thp" run_test ./khugepaged all:shmem + +CATEGORY="thp" run_test ./khugepaged -s 4 all:shmem + CATEGORY="thp" run_test ./transhuge-stress -d 20 # Try to

Re: [PATCH 1/2] selftests: khugepaged: fix the shmem collapse failure

2025-06-11 Thread Dev Jain
On 12/06/25 9:24 am, Baolin Wang wrote: When running the khugepaged selftest for shmem (./khugepaged all:shmem), I encountered the following test failures: " Run test: collapse_full (khugepaged:shmem) Collapse multiple fully populated PTE table Fail ... Run test: collapse_single_pte_entry (

Re: [PATCH v2 2/7] selftests/mm: Add support to test 4PB VA on PPC64

2025-07-03 Thread Dev Jain
some knowledge on VMA allocation stuff : ) Reviewed-by: Dev Jain

Re: [PATCH v2 2/7] selftests/mm: Add support to test 4PB VA on PPC64

2025-07-03 Thread Dev Jain
On 03/07/25 8:11 pm, Zi Yan wrote: On 3 Jul 2025, at 2:06, Aboorva Devarajan wrote: From: Donet Tom PowerPC64 supports a 4PB virtual address space, but this test was previously limited to 512TB. This patch extends the coverage up to the full 4PB VA range on PowerPC64. Memory from 0 to 128T

Re: [PATCH v2 6/7] selftests/mm: Skip thuge-gen if shmmax is too small or no 1G huge pages

2025-07-03 Thread Dev Jain
his test. ~ ~ Please run the following command to increase shmmax: ~ ~ echo 262144 > /proc/sys/kernel/shmmax ~ 1..0 ~ SKIP Test skipped due to insufficient shmmax value. ~ [SKIP] ok 29 thuge-gen ~ SKIP Signed-off-by: Aboorva Devarajan --- LGTM Reviewed-by: Dev Jain

Re: [PATCH v2 4/7] mm/selftests: Fix split_huge_page_test failure on systems with 64KB page size

2025-07-03 Thread Dev Jain
tests now run successfully on both 64KB and 4KB page size systems. Fixes: fa6c02315f745 ("mm: huge_memory: a new debugfs interface for splitting THP tests") Signed-off-by: Donet Tom Signed-off-by: Aboorva Devarajan --- LGTM Reviewed-by: Dev Jain

Re: [PATCH v2 1/7] mm/selftests: Fix incorrect pointer being passed to mark_range()

2025-07-03 Thread Dev Jain
MAP_FAILED) break; - mark_range(ptr[i], MAP_CHUNK_SIZE); + mark_range(hptr[i], MAP_CHUNK_SIZE); validate_addr(hptr[i], 1); } hchunks = i; Makes sense. Reviewed-by: Dev Jain

Re: [PATCH] mm: Replace (20 - PAGE_SHIFT) with common macros for pages<->MB conversion

2025-07-18 Thread Dev Jain
On 18/07/25 8:11 am, Ye Liu wrote: From: Ye Liu Replace repeated (20 - PAGE_SHIFT) calculations with standard macros: - MB_TO_PAGES(mb)converts MB to page count - PAGES_TO_MB(pages) converts pages to MB No functional change. Signed-off-by: Ye Liu --- sh and x86 have their own page

Re: [PATCH] mm: Replace (20 - PAGE_SHIFT) with common macros for pages<->MB conversion

2025-07-18 Thread Dev Jain
On 18/07/25 8:11 am, Ye Liu wrote: From: Ye Liu Replace repeated (20 - PAGE_SHIFT) calculations with standard macros: - MB_TO_PAGES(mb)converts MB to page count - PAGES_TO_MB(pages) converts pages to MB No functional change. Signed-off-by: Ye Liu --- Reviewed-by: Dev Jain

Re: [PATCH][next] tools/testing/selftests: Fix spelling mistake "unnmap" -> "unmap"

2025-07-23 Thread Dev Jain
On 23/07/25 3:20 pm, Colin Ian King wrote: There is a spelling mistake in ksft_test_result_fail messages. Fix them. Signed-off-by: Colin Ian King --- Reviewed-by: Dev Jain