On 1/13/2024 5:55 AM, Michal Koutný wrote:
Add bounds check on values read from shared memory in the tx path. In
cases where the VM is misbehaving, the transport should exit and print a
warning when bogus values may cause out of bounds to be read.
Link:
https://git.codelinaro.org/clo/la/kern
On 1/29/2024 10:03 PM, Michal Koutný wrote:
On Mon, Jan 29, 2024 at 04:18:36PM +0530, Deepak Kumar Singh
wrote:
There is already a patch posted for similar problem -
https://lore.kernel.org/all/20231201110631.669085-1-quic_dee...@quicinc.com/
I was not aware, thanks for the pointer.
Do
: 9607 [#1] PREEMPT SMP
pc : __memcpy_fromio+0x34/0xb4
lr : glink_smem_rx_peak+0x68/0x94
__memcpy_fromio+0x34/0xb4
glink_smem_rx_peak+0x68/0x94
qcom_glink_native_intr+0x90/0x888
Signed-off-by: Deepak Kumar Singh
---
drivers/rpmsg/qcom_glink_smem.c | 21 ++---
1 file changed, 18
wakeup irq. Remove
IRQF_NO_SUSPEND flag as it is no longer required.
Signed-off-by: Deepak Kumar Singh
---
drivers/rpmsg/qcom_glink_smem.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/rpmsg/qcom_glink_smem.c b/drivers/rpmsg/qcom_glink_smem.c
index 7a982c60a8dd
On 6/12/2024 4:35 AM, Chris Lew wrote:
On 6/11/2024 5:33 AM, Sudeepgoud Patil wrote:
This commit introduces tracepoint support for smp2p,
enabling logging of communication between local and remote processors.
The tracepoints include information about the remote processor ID,
remote subsyste
On 6/3/2024 3:07 PM, Caleb Connolly wrote:
Hi Deepak,
On 03/06/2024 09:36, Deepak Kumar Singh wrote:
There are certain usecases which require glink interrupt to be
wakeup capable. For example if handset is in sleep state and
usb charger is plugged in, dsp wakes up and sends glink interrupt
notifications, and ssr activity. These logs are useful for
debugging issues between subsystems.
Signed-off-by: Sudeepgoud Patil
Reviewed-by: Deepak Kumar Singh
---
drivers/soc/qcom/Makefile | 1 +
drivers/soc/qcom/smp2p.c | 9
drivers/soc/qcom/trace-smp2p.h | 98
Change from V1
Addressesed all review comments in previous set.
Deepak Kumar Singh (2):
soc: qcom: aoss: Expose send for generic usecase
soc: qcom: aoss: Add debugfs entry
drivers/soc/qcom/qcom_aoss.c | 91 +-
include/linux/soc/qcom/qcom_aoss.h | 33
From: Deepak Kumar Singh
Not all upcoming usecases will have an interface to allow the aoss
driver to hook onto. Expose the send api and create a get function to
enable drivers to send their own messages to aoss.
Signed-off-by: Chris Lew
Signed-off-by: Deepak Kumar Singh
---
drivers/soc/qcom
It can be useful to control the different power states of various
parts of hardware for device testing. Add a debugfs node for qmp so
messages can be sent to aoss for debugging and testing purposes.
Signed-off-by: Chris Lew
Signed-off-by: Deepak Kumar Singh
---
drivers/soc/qcom/qcom_aoss.c
sending second glink close command.
Signed-off-by: Konstantin Dorfman
Signed-off-by: Deepak Kumar Singh
---
drivers/rpmsg/qcom_glink_native.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/rpmsg/qcom_glink_native.c
b/drivers/rpmsg/qcom_glink_native.c
index 1995f5b..2668c66
Includes fixes for -
Few race conditions while channel release and close
Proper unregistration of rpmsg device to avoid use of stale device
Send notify command to remote when glink fifo is full
Handling packet size larger that 16K
Arun Kumar Neelakantam (3):
rpmsg: glink: Add TX_DATA_CONT comman
-off-by: Deepak Kumar Singh
---
drivers/rpmsg/qcom_glink_native.c | 38 ++
1 file changed, 34 insertions(+), 4 deletions(-)
diff --git a/drivers/rpmsg/qcom_glink_native.c
b/drivers/rpmsg/qcom_glink_native.c
index df3c608..ac179b1 100644
--- a/drivers/rpmsg
sending IRQ.
Signed-off-by: Deepak Kumar Singh
Signed-off-by: Arun Kumar Neelakantam
---
drivers/rpmsg/qcom_glink_native.c | 36 +++-
1 file changed, 35 insertions(+), 1 deletion(-)
diff --git a/drivers/rpmsg/qcom_glink_native.c
b/drivers/rpmsg
that should only happen from the close commands.
Signed-off-by: Chris Lew
Signed-off-by: Deepak Kumar Singh
---
drivers/rpmsg/qcom_glink_native.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/rpmsg/qcom_glink_native.c
b/drivers/rpmsg/qcom_glink_native.c
index 031bc1d..efaf32d 100644
.
In order to prevent intent build up, deny intent requests that can be
fulfilled by default intents that are reusable.
Signed-off-by: Chris Lew
Signed-off-by: Deepak Kumar Singh
---
drivers/rpmsg/qcom_glink_native.c | 17 -
1 file changed, 16 insertions(+), 1 deletion(-)
diff
From: Arun Kumar Neelakantam
Un-register and register of rpmsg driver is sending invalid open_ack
on closed channel.
To avoid sending invalid open_ack case unregister the rpmsg device
after receiving the local_close_ack from remote side.
Signed-off-by: Deepak Kumar Singh
signed-off-by: Arun
SMP2P interrupts are expected to wake the processor from suspend.
Use enable_irq_wake to mark it wakeup capable from suspend.
Signed-off-by: Chris Lew
Signed-off-by: Deepak Kumar Singh
---
drivers/soc/qcom/smp2p.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/soc/qcom/smp2p.c b
[Change from V0]
Update qmp_get to parse qmp handle with binding qcom,qmp
Deepak Kumar Singh (2):
soc: qcom: aoss: Expose send for generic usecase
soc: qcom: aoss: Add debugfs entry
drivers/soc/qcom/qcom_aoss.c | 77 +++-
1 file changed, 76 insertions
Not all upcoming usecases will have an interface to allow the aoss
driver to hook onto. Expose the send api and create a get function to
enable drivers to send their own messages to aoss.
Signed-off-by: Chris Lew
Signed-off-by: Deepak Kumar Singh
---
drivers/soc/qcom/qcom_aoss.c | 36
It can be useful to control the different power states of various
parts of hardware for device testing. Add a debugfs node for qmp so
messages can be sent to aoss for debugging and testing purposes.
Signed-off-by: Chris Lew
Signed-off-by: Deepak Kumar Singh
---
drivers/soc/qcom/qcom_aoss.c
RPMSG provides a char device interface to userspace. Probe the rpmsg
chrdev channel to enable the rpmsg_ctrl device creation on glink
transports.
Signed-off-by: Chris Lew
Signed-off-by: Deepak Kumar Singh
Signed-off-by: Arun Kumar Neelakantam
---
drivers/rpmsg/qcom_glink_native.c | 38
Kumar Singh
Signed-off-by: Arun Kumar Neelakantam
---
drivers/rpmsg/rpmsg_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/rpmsg/rpmsg_core.c b/drivers/rpmsg/rpmsg_core.c
index a6361ca..91de940 100644
--- a/drivers/rpmsg/rpmsg_core.c
+++ b/drivers/rpmsg/rpmsg_core.c
From: Chris Lew
Expose the name field as an attr so clients listening to uevents for
rpmsg can identify the edge the events correspond to.
Signed-off-by: Chris Lew
Signed-off-by: Deepak Kumar Singh
Signed-off-by: Arun Kumar Neelakantam
---
drivers/rpmsg/qcom_glink_native.c | 26
From: Chris Lew
The open_req and open_ack completion variables are the state variables
to represet a remote channel as open. Use complete_all so there are no
races with waiters and using completion_done.
Signed-off-by: Chris Lew
Signed-off-by: Deepak Kumar Singh
Signed-off-by: Arun Kumar
From: Arun Kumar Neelakantam
Add TICOMGET and TIOCMSET ioctl support for rpmsg char device nodes
to get/set the low level transport signals.
Signed-off-by: Deepak Kumar Singh
Signed-off-by: Arun Kumar Neelakantam
---
drivers/rpmsg/rpmsg_char.c | 54
From: Arun Kumar Neelakantam
Register a callback to get the signal notifications from rpmsg and
send POLLPRI mask to indicate the signal change in POLL system call.
Signed-off-by: Deepak Kumar Singh
Signed-off-by: Arun Kumar Neelakantam
---
drivers/rpmsg/rpmsg_char.c | 22
.
Signed-off-by: Chris Lew
Signed-off-by: Deepak Kumar Singh
Signed-off-by: Arun Kumar Neelakantam
---
drivers/rpmsg/rpmsg_core.c | 40
drivers/rpmsg/rpmsg_internal.h | 5 +
include/linux/rpmsg.h | 27 +++
3
Kumar Singh
Signed-off-by: Arun Kumar Neelakantam
---
drivers/rpmsg/qcom_glink_native.c | 125 ++
1 file changed, 125 insertions(+)
diff --git a/drivers/rpmsg/qcom_glink_native.c
b/drivers/rpmsg/qcom_glink_native.c
index 0e8a28c0..1bf3235 100644
--- a/drivers
.
Signed-off-by: Chris Lew
Signed-off-by: Deepak Kumar Singh
Signed-off-by: Arun Kumar Neelakantam
---
drivers/rpmsg/rpmsg_core.c | 40
drivers/rpmsg/rpmsg_internal.h | 5 +
include/linux/rpmsg.h | 27 +++
3
Kumar Singh
Signed-off-by: Arun Kumar Neelakantam
---
drivers/rpmsg/qcom_glink_native.c | 125 ++
1 file changed, 125 insertions(+)
diff --git a/drivers/rpmsg/qcom_glink_native.c
b/drivers/rpmsg/qcom_glink_native.c
index 0e8a28c0..1bf3235 100644
--- a/drivers
From: Arun Kumar Neelakantam
Register a callback to get the signal notifications from rpmsg and
send POLLPRI mask to indicate the signal change in POLL system call.
Signed-off-by: Deepak Kumar Singh
Signed-off-by: Arun Kumar Neelakantam
---
drivers/rpmsg/rpmsg_char.c | 22
From: Arun Kumar Neelakantam
Add TICOMGET and TIOCMSET ioctl support for rpmsg char device nodes
to get/set the low level transport signals.
Signed-off-by: Deepak Kumar Singh
Signed-off-by: Arun Kumar Neelakantam
---
drivers/rpmsg/rpmsg_char.c | 54
to and from native signal as done in patch V4,2/4
is intentional.
Arun Kumar Neelakantam (3):
rpmsg: glink: Add support to handle signals command
rpmsg: char: Add TIOCMGET/TIOCMSET ioctl support
rpmsg: char: Add signal callback and POLLPRI support
Deepak Kumar Singh (1):
rpmsg: core:
tch V4,2/4
is intentional.
Arun Kumar Neelakantam (3):
rpmsg: glink: Add support to handle signals command
rpmsg: char: Add TIOCMGET/TIOCMSET ioctl support
rpmsg: char: Add signal callback and POLLPRI support
Deepak Kumar Singh (1):
rpmsg: core: Add signal API support
drivers/rp
Kumar Singh
Signed-off-by: Arun Kumar Neelakantam
---
drivers/rpmsg/qcom_glink_native.c | 125 ++
1 file changed, 125 insertions(+)
diff --git a/drivers/rpmsg/qcom_glink_native.c
b/drivers/rpmsg/qcom_glink_native.c
index f40312b..499381a 100644
--- a/drivers
.
Signed-off-by: Chris Lew
Signed-off-by: Deepak Kumar Singh
Signed-off-by: Arun Kumar Neelakantam
---
drivers/rpmsg/rpmsg_core.c | 40
drivers/rpmsg/rpmsg_internal.h | 5 +
include/linux/rpmsg.h | 27 +++
3
From: Arun Kumar Neelakantam
Register a callback to get the signal notifications from rpmsg and
send POLLPRI mask to indicate the signal change in POLL system call.
Signed-off-by: Deepak Kumar Singh
Signed-off-by: Arun Kumar Neelakantam
---
drivers/rpmsg/rpmsg_char.c | 22
From: Arun Kumar Neelakantam
Add TICOMGET and TIOCMSET ioctl support for rpmsg char device nodes
to get/set the low level transport signals.
Signed-off-by: Deepak Kumar Singh
Signed-off-by: Arun Kumar Neelakantam
---
drivers/rpmsg/rpmsg_char.c | 54
On 7/6/2020 11:34 PM, Mathieu Poirier wrote:
Hi Deepak,
On Fri, Jun 26, 2020 at 08:16:55PM +0530, Deepak Kumar Singh wrote:
Change from version 5
[V5,4/4] rpmsg: char: Add signal callback and POLLPRI support
Updated for sparse warning. Replaced POLLPRI => EPOLLPRI to fix
warning.
Cha
From: Chris Lew
There is a race for clients that open sockets before the control port
is bound. If a client gets an idr that was allocated before the control
port is bound, there is a chance the previous address owner sent lookup
packets to the control port. The new address owner will get residua
Arun Kumar Neelakantam (1):
net: qrtr: Check function pointer before calling
Chris Lew (3):
net: qrtr: Do not send packets before hello negotiation
net: qrtr: Add socket mode optimization
net: qrtr: Change port allocation to use cyclic idr
net/qrtr/qrtr.c | 93 +++
From: Chris Lew
A remote endpoint should not need to know when a client socket is freed
if the socket never established commnication with the endpoint. Add a
mode to keep track of which endpoints a socket communicates with.
There are three modes a socket can be in:
INIT - Socket has no
From: Arun Kumar Neelakantam
sk_error_report callback function called without validating cause the NULL
pointer dereference.
Validate function pointer before using for error report.
---
net/qrtr/qrtr.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/qrtr/qrtr.c b/net/q
From: Chris Lew
There is a race where broadcast packets can be sent to a node that has
not sent the hello message to the remote processor. This breaks the
protocol expectation. Add a status variable to track when the hello
packet has been sent.
An alternative solution attempted was to remove the
Structures in shared memory that can be modified by remote
processors may have untrusted values, they should be validated
before use.
Adding proper validation before using fields of shared
structures.
Signed-off-by: Deepak Kumar Singh
---
drivers/soc/qcom/smem.c | 194
SMEM driver is IO mapping complete region and CPU is doing a speculative
read into a partition where local HOST does not have permission resulting
in a NOC error.
Map only those partitions which are accessibly to local HOST.
Signed-off-by: Deepak Kumar Singh
---
drivers/soc/qcom/smem.c | 226
lag check in intent wait, to abort intent wait from
qcom_glink_native_remove.
Fixes: c05dfce0b89e ("rpmsg: glink: Wait for intent, not just request ack")
Cc: sta...@vger.kernel.org
Signed-off-by: Sarannya S
Signed-off-by: Deepak Kumar Singh
---
drivers/rpmsg/qcom_glink_native.c | 6 +
48 matches
Mail list logo
