On Mon, Feb 04, 2013 at 09:55:50PM +, Arnd Bergmann wrote:
> On Saturday 02 February 2013, Chris Mason wrote:
>
> I've done a full backup of all data now, without any further Ooops messages,
> but
> I did get these:
>
> [66155.429029] btrfs no csum found for inode 1212139 start 23707648
The
On Sat, Jan 26, 2013 at 02:50:43PM +0900, Kyungsik Lee wrote:
> This patchset is for supporting LZ4 compressed kernel and initial ramdisk on
> the x86 and ARM architectures.
Have you considered the 'high compression' mode of lz4?
http://code.google.com/p/lz4/source/browse/trunk/lz4hc.c
The compre
On Fri, Feb 22, 2013 at 08:32:10AM +0800, Zhi Yong Wu wrote:
> ping? any comments?
Sorry, I don't have as much time as I'd like to continue with this
patchset.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majo
On Tue, Feb 26, 2013 at 03:24:27PM +0900, Kyungsik Lee wrote:
> This patch adds support for LZ4 decompression in the Linux Kernel.
> LZ4 Decompression APIs for kernel are based on LZ4 implementation
> by Yann Collet.
>
> LZ4 homepage : http://fastcompression.blogspot.com/p/lz4.html
> LZ4 source re
On Tue, Feb 26, 2013 at 03:24:28PM +0900, Kyungsik Lee wrote:
> +config KERNEL_LZ4
> + bool "LZ4"
> + depends on HAVE_KERNEL_LZ4
> + help
> + Its compression ratio is worse than LZO. The size of the kernel
> + is about 8% bigger than LZO. But the decompression speed is
> +
On Mon, Feb 18, 2013 at 04:56:04PM +0900, Kyungsik Lee wrote:
> @@ -55,8 +55,9 @@ static struct list_head *lzo_alloc_workspace(void)
> return ERR_PTR(-ENOMEM);
>
> workspace->mem = vmalloc(LZO1X_MEM_COMPRESS);
> - workspace->buf = vmalloc(PAGE_CACHE_SIZE);
> - workspac
Hi,
> > +/* DCR bits */
> > +#define DCR_RXDONE ((unsigned short) 0x1)
> > +#define DCR_TXDONE ((unsigned short) 0x2)
> > +#define DCR_RXRESET ((unsigned short) 0x4)
> > +#define DCR_TXRESET ((unsigned short) 0x8)
>
> Are those casts neccessary?
No, removed.
> > +/* I/O ports a
> @@ -207,16 +266,23 @@ EXPORT_SYMBOL(ulist_add);
> * end is reached. No guarantee is made with respect to the order in which
> * the elements are returned. They might neither be returned in order of
> * addition nor in ascending order.
> - * It is allowed to call ulist_add during an enumerat
coccinelle.lip6.fr/)
>
> //
> @@
> expression list es;
> @@
>
> -printk(
> +WARN(1,
> es);
> -WARN_ON(1);
> //
>
> Signed-off-by: Julia Lawall
Reviewed-by: David Sterba
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of
coccinelle.lip6.fr/)
>
> //
> @@
> expression e;
> @@
> - if (e) WARN_ON(1);
> + WARN_ON(e);
> //
>
> Signed-off-by: Julia Lawall
Reviewed-by: David Sterba
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger
On Sun, Nov 04, 2012 at 09:25:53PM +0100, Julia Lawall wrote:
> It looks like these patches were not a good idea, because in each case the
> printk provides an error level, and WARN then provides another one.
I think this is not a problem within btrfs at the place where this has
changed.
david
--
On Mon, Sep 24, 2012 at 12:38:07PM +0800, Wang Sheng-Hui wrote:
> Check range early to avoid further check/compute in case
> of range error.
>
> Signed-off-by: Wang Sheng-Hui
> ---
> fs/btrfs/extent_io.c | 16
> 1 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git
On Tue, Sep 25, 2012 at 10:02:15AM +0800, zwu.ker...@gmail.com wrote:
> From: Zhi Yong Wu
>
> Need to close fd on exit.
Strictly you don't need to, kernel will do that at exit() time.
david
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
On Tue, Sep 25, 2012 at 10:02:16AM +0800, zwu.ker...@gmail.com wrote:
> From: Zhi Yong Wu
>
> Some code pathes forget to free memory on exit.
Same as with the fd's, kernel will free all memory for us at exit().
If there's lots of memory allocated, it may be even faster to leave the
unallocati
23510561&w=2)
>
> The name of these two functions is cumbersome, so rename them to
> try_to_writeback_inodes_sb(_nr).
>
> This idea came from Christoph Hellwig.
> Some code is from the patch of Kamal Mostafa.
>
> Signed-off-by: Miao Xie
Tested-by: David Sterba
>
On Thu, Sep 06, 2012 at 02:40:41PM +0800, Wang Sheng-Hui wrote:
> The memory allocation failure is BUG_ON in add_excluded_extent (following
> the code path) and btrfs_rmap_block. No need to BUG_ON -ENOMEM inside
> exclude_super_stripes itself.
No please.
> Its return value is always 0, and useles
On Thu, Sep 06, 2012 at 02:41:02PM +0800, Wang Sheng-Hui wrote:
> The memory allocation failure is BUG_ON in add_excluded_extent
> (following the code path). No need to BUG_ON -ENOMEM inside
> btrfs_alloc_logged_file_extent.
This indirectly calls __set_extent_bit that does BUG_ON on memory
allocat
On Fri, Oct 05, 2012 at 08:56:44PM +0900, ? wrote:
> +struct node_footer {
> + __le32 nid; /* node id */
> + __le32 ino; /* inode nunmber */
> + __le32 cold:1; /* cold mark */
> + __le32 fsync:1; /* fsync mark */
> + __le32 dentry
On Fri, Oct 05, 2012 at 08:57:46PM +0900, ? wrote:
> +struct f2fs_nm_info {
> + block_t nat_blkaddr;/* base disk address of NAT */
> + unsigned int nat_segs; /* the number of nat segments */
> + unsigned int nat_blocks;/* the number of nat blocks of
On Wed, Jan 25, 2012 at 02:36:18AM +0100, Andi Kleen wrote:
> I ran benchmarks on the new miniLZO and LZ4 on 64bit. LZ4 is generally slower
> than snappy/lzo in the micro benchmarks.
And the reason why you measured worse speed for LZ4 although (AFAICT)
everybody else's measurements claim the oppo
On Wed, Sep 05, 2012 at 05:54:04PM +0200, David Sterba wrote:
> > Many users who use btrfs met the deadlock problem caused by
> > writeback_inodes_sb(_nr)_if_idle(),
> > so I send this patch again and hope it will be received as soon as possible
> > if nobody objects.
>
On Tue, Oct 09, 2012 at 02:13:29PM +0900, Chul Lee wrote:
> > > + block_t data_blkaddr;
> > > +};
> > > +
> > > +struct f2fs_sb_info {
> > > + struct super_block *sb; /* Pointer to VFS super
> > block */
> > > + int s_dirty;
> >
> > Is s_dirty actually used? I can see it only set a
On Wed, Oct 10, 2012 at 06:07:24PM +0800, zwu.ker...@gmail.com wrote:
> +void hot_track_init(struct super_block *sb)
> +{
...
> +}
> +void hot_track_exit(struct super_block *sb)
> +{
> + hot_cache_exit();
> +}
Needs to be exported if btrfs is built as a module, otherwise does not
link
LDS
On Wed, Oct 10, 2012 at 06:07:34PM +0800, zwu.ker...@gmail.com wrote:
> +static int hot_debugfs_log_init(struct debugfs_vol_data *data)
> +{
> + int err = 0;
> + struct lstring *debugfs_log = data->debugfs_log;
> +
> + spin_lock(&data->log_lock);
> + debugfs_log->str = vmalloc(INIT_
Hi,
On Wed, Oct 10, 2012 at 06:07:23PM +0800, zwu.ker...@gmail.com wrote:
> --- a/fs/btrfs/ctree.h
> +++ b/fs/btrfs/ctree.h
> @@ -1726,6 +1726,7 @@ struct btrfs_ioctl_defrag_range_args {
> #define BTRFS_MOUNT_CHECK_INTEGRITY (1 << 20)
> #define BTRFS_MOUNT_CHECK_INTEGRITY_INCLUDING_EXTENT_DATA
On Wed, Oct 10, 2012 at 06:07:34PM +0800, zwu.ker...@gmail.com wrote:
> +static int hot_debugfs_copy(struct debugfs_vol_data *data, char *msg, int
> len)
> +{
> + struct lstring *debugfs_log = data->debugfs_log;
> + uint new_log_alloc_size;
> + char *new_log;
> + static char err_ms
On Mon, Oct 29, 2012 at 12:30:44PM +0800, zwu.ker...@gmail.com wrote:
> +/* Frees the entire hot_range_tree. */
> +static void hot_inode_item_free(struct kref *kref)
> +{
> + struct hot_comm_item *comm_item = container_of(kref,
> + struct hot_comm_item, refs);
> + struct
On Mon, Oct 29, 2012 at 12:30:45PM +0800, zwu.ker...@gmail.com wrote:
> --- a/fs/hot_tracking.c
> +++ b/fs/hot_tracking.c
> +struct hot_inode_item
> +*hot_inode_item_find(struct hot_info *root, u64 ino)
> +{
> + struct hot_inode_item *he;
> + int ret;
> +
> +again:
> + spin_lock(&root->
On Mon, Oct 29, 2012 at 12:30:47PM +0800, zwu.ker...@gmail.com wrote:
> --- a/mm/readahead.c
> +++ b/mm/readahead.c
> @@ -19,6 +19,7 @@
> #include
> #include
> #include
> +#include
>
> /*
> * Initialise a struct file's readahead state. Assumes that the caller has
> @@ -138,6 +139,11 @@
On Mon, Oct 29, 2012 at 12:30:52PM +0800, zwu.ker...@gmail.com wrote:
> +static struct hot_func_type *hot_func_get(const char *name)
> +{
> + struct hot_func_type *f, *h = &hot_func_def;
> +
> + spin_lock(&hot_func_list_lock);
> + list_for_each_entry(f, &hot_func_list, list) {
> +
On Mon, Oct 29, 2012 at 12:30:54PM +0800, zwu.ker...@gmail.com wrote:
> +static int ioctl_heat_info(struct file *file, void __user *argp)
> +{
> + struct inode *inode = file->f_dentry->d_inode;
> + struct hot_heat_info *heat_info;
> + struct hot_inode_item *he;
> + int ret = 0;
> +
On Mon, Oct 29, 2012 at 12:30:56PM +0800, zwu.ker...@gmail.com wrote:
> +static int hot_range_seq_show(struct seq_file *seq, void *v)
> +{
> + struct hot_range_item *hr = v;
> + struct hot_inode_item *he = hr->hot_inode;
> + struct hot_freq_data *freq_data = &hr->hot_range.hot_freq_data
mount -o nouser,hot_track,loop
>mount -o hot_track,nouser
>
> Signed-off-by: Zhi Yong Wu
Reviewed-by: David Sterba
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http:
On Wed, Jun 05, 2013 at 08:53:50AM +0200, Arne Jansen wrote:
> On 05.06.2013 04:09, Jörn Engel wrote:
> > On Tue, 4 June 2013 14:44:35 -0400, Jörn Engel wrote:
> >>
> >> Or while_list_drain?
>
> I'm fine with while_list_drain, although a name starting with list_
> like all other list macros would
On Tue, Jun 04, 2013 at 10:03:41PM -0400, Jörn Engel wrote:
> I have seen a lot of boilerplate code that either follows the pattern of
> while (!list_empty(head)) {
> pos = list_entry(head->next, struct foo, list);
> list_del(pos->list);
> ...
>
On Sat, Jun 08, 2013 at 07:19:04PM -0700, Kent Overstreet wrote:
> --- a/include/linux/blkdev.h
> +++ b/include/linux/blkdev.h
> @@ -467,6 +468,7 @@ struct request_queue {
> #define QUEUE_FLAG_SECDISCARD 17/* supports SECDISCARD */
> #define QUEUE_FLAG_SAME_FORCE 18/* force complete on
On Thu, Aug 08, 2013 at 09:33:14AM +0200, Arne Jansen wrote:
> On 07.08.2013 23:43, Sergei Trofimovich wrote:
> > From: Sergei Trofimovich
> >
> > Found by uselex.rb:
> >> btrfs_reada_detach: [R]: exported from: fs/btrfs/btrfs.o
> >> fs/btrfs/built-in.o fs/btrfs/reada.o
>
> even though the func
On Thu, Aug 08, 2013 at 12:43:20AM +0300, Sergei Trofimovich wrote:
> From: Sergei Trofimovich
>
> Found by uselex.rb:
> > btrfs_start_transaction_lflush: [R]: exported from: fs/btrfs/btrfs.o
> > fs/btrfs/transaction.o fs/btrfs/built-in.o
http://www.mail-archive.com/linux-btrfs@vger.kernel.org/
On Thu, Aug 08, 2013 at 12:43:19AM +0300, Sergei Trofimovich wrote:
> From: Sergei Trofimovich
>
> Found by uselex.rb:
> > btrfs_write_and_wait_marked_extents: [R]: exported from: fs/btrfs/btrfs.o
> > fs/btrfs/transaction.o fs/btrfs/built-in.o
>
> Signed-off-by: Sergei Trofimovich
> ---
> fs/
rofimovich
Safe to remove.
Reviewed-by: David Sterba
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
On Thu, Aug 08, 2013 at 09:11:01PM +0200, Arne Jansen wrote:
> On 08/08/13 19:46, Zach Brown wrote:
> >>> even though the function is currently unused, I'm hesitating to remove it
> >>> as it's part of the reada-API and might be handy for anyone going to use
> >>> the API in the future.
> >>
> >> I
lock_groups.
>
> The current code uses integer literals to index
> btrfs_space_info->block_groups[] array. Instead use corresponding
> enums from 'enum btrfs_raid_types'.
>
> Signed-off-by: chandan
Reviewed-by: David Sterba
--
To unsubscribe from this list: send
On Thu, Aug 23, 2012 at 05:06:19PM +0900, Namjae Jeon wrote:
> 2012/8/19, Fengguang Wu :
> > On Sat, Aug 18, 2012 at 05:48:29AM -0400, Namjae Jeon wrote:
> >> There is no reason nr_pages_dirtied is argument anymore.
> >> because nr_pages_dirtied value from caller is not used in
> >> balance_dirty_p
Hi,
> > +irqreturn_t ipwireless_interrupt(int irq, void *dev_id, struct pt_regs
> > *regs) +{
> > + struct ipw_hardware *hw = dev_id;
> > +
> > + if (hw->hw_version == HW_VERSION_1)
> > + return ipwireless_handle_v1_interrupt(irq, hw);
> > + else
> > + return ipwireless_h
On Thu, Feb 14, 2013 at 06:12:19PM +0900, Kyungsik Lee wrote:
> lzo1x_1_compress() is unnecessarily used for allocating decompress buffer.
>
> --- a/fs/btrfs/lzo.c
> +++ b/fs/btrfs/lzo.c
> @@ -55,7 +55,7 @@ static struct list_head *lzo_alloc_workspace(void)
> return ERR_PTR(-ENOMEM);
On Fri, Feb 15, 2013 at 10:08:21PM +0900, Kyungsik Lee wrote:
> The size of de/compress buffer and LZO1X_MEM_COMPRESS is small enough.
Unfortunatelly it is not.
include/linux/lzo.h:
#define LZO1X_MEM_COMPRESS (16384 * sizeof(unsigned char *))
128k with 8 byte pointers
> @@ -54,9 +53,10 @@
On Thu, Oct 11, 2012 at 10:35:28PM +0800, Zhi Yong Wu wrote:
> >> --- a/fs/btrfs/super.c
> >> +++ b/fs/btrfs/super.c
> >> @@ -303,7 +304,7 @@ enum {
> >> Opt_notreelog, Opt_ratio, Opt_flushoncommit, Opt_discard,
> >> Opt_space_cache, Opt_clear_cache, Opt_user_subvol_rm_allowed,
> >>
On Fri, Jan 11, 2013 at 03:38:31PM +0800, Zhi Yong Wu wrote:
> On Thu, Jan 10, 2013 at 8:51 AM, David Sterba wrote:
> > On Thu, Dec 20, 2012 at 10:43:22PM +0800, zwu.ker...@gmail.com wrote:
> >> --- a/fs/hot_tracking.c
> >> +++ b/fs/hot_tracking.c
> >&g
On Thu, Dec 20, 2012 at 10:43:20PM +0800, zwu.ker...@gmail.com wrote:
> --- /dev/null
> +++ b/fs/hot_tracking.c
> @@ -0,0 +1,109 @@
> +/*
> + * fs/hot_tracking.c
>From what I've undrestood the file name written here is not wanted, so
please drop it (and from .h too)
> + *
> + * Copyright (C) 2012
On Thu, Dec 20, 2012 at 10:43:21PM +0800, zwu.ker...@gmail.com wrote:
> From: Zhi Yong Wu
> --- a/fs/hot_tracking.c
> +++ b/fs/hot_tracking.c
> @@ -107,3 +189,38 @@ err:
> kmem_cache_destroy(hot_inode_item_cachep);
> }
> EXPORT_SYMBOL_GPL(hot_cache_init);
> +
> +/*
> + * Initialize the dat
On Thu, Dec 20, 2012 at 10:43:22PM +0800, zwu.ker...@gmail.com wrote:
> --- a/fs/hot_tracking.c
> +++ b/fs/hot_tracking.c
> @@ -164,6 +164,135 @@ static void hot_inode_tree_exit(struct hot_info *root)
> spin_unlock(&root->lock);
> }
>
> +struct hot_inode_item
> +*hot_inode_item_lookup(stru
On Thu, Dec 20, 2012 at 10:43:23PM +0800, zwu.ker...@gmail.com wrote:
> --- a/fs/hot_tracking.c
> +++ b/fs/hot_tracking.c
> +/* Free inode and range map info */
> +static void hot_map_exit(struct hot_info *root)
> +{
> + int i;
> + for (i = 0; i < HEAT_MAP_SIZE; i++) {
> + spin_
On Thu, Dec 20, 2012 at 10:43:24PM +0800, zwu.ker...@gmail.com wrote:
> --- a/fs/direct-io.c
> +++ b/fs/direct-io.c
> @@ -37,6 +37,7 @@
> #include
> #include
> #include
> +#include "hot_tracking.h"
>
> /*
> * How many user pages to map in one call to get_user_pages(). This
> determines
On Thu, Dec 20, 2012 at 10:43:25PM +0800, zwu.ker...@gmail.com wrote:
> --- a/fs/hot_tracking.c
> +++ b/fs/hot_tracking.c
> @@ -25,6 +25,14 @@
> static struct kmem_cache *hot_inode_item_cachep __read_mostly;
> static struct kmem_cache *hot_range_item_cachep __read_mostly;
>
> +static u64 hot_ra
Hi,
> can we please drop the stupid "_cs" stuff. It is an old habit to have
> the shortcut for "Card Services" in the driver name, but that goes back
> to the time when the PCMCIA subsystem and its drivers were an external
> package. Especially in cases where only a PCMCIA card exists, it makes
>
Hi,
> might it not make more sense to put all of that into a new
> subdirectory, say, /drivers/char/pcmcia/ipwireless_cs? that way, it's
> more modular and it will keep that higher-level directory from
> potentially getting cluttered with even more drivers. and it would
> let you drop the pointl
bonding: Fix time comparison
Use macros for comparing jiffies. Jiffies' wrap caused missed events and hangs.
Module reinsert was needed to make bonding work again.
Signed-off-by: David Sterba <[EMAIL PROTECTED]>
---
drivers/net/bonding/bond_main.c | 25 +--
On Tuesday 29 of January 2008 00:18:03 Jiri Slaby wrote:
> On 01/28/2008 07:08 PM, Randy Dunlap wrote:
> >> +/*
> >> + * @return 1 if something has been received from hw
> >
> > What's with the '@'?
>
> ...
>
> >> +
> >> +/*!
> >
> > and the '!' ?
> >
> >> + * @return true if the card is physically
On Monday 28 of January 2008 19:08:54 Randy Dunlap wrote:
> > +/* Number of bytes in NL packet header (can not do
>
> cannot
Fixed.
>
> > + * sizeof(nl_packet_header) since it's a bitfield) */
> > +#define NL_FOLLOWING_PACKET_HEADER_SIZE1
> > +
> > +struct nl_first_paket_header {
>
>
Hi,
On Tue, Jan 29, 2008 at 02:49:24PM +0100, David Sterba wrote:
> ---
> From: David Sterba <[EMAIL PROTECTED]>
>
> ipwireless_cs: driver for PC Card, 3G internet connection
>
> The driver is manufactured by IPWireless.
Sorry this ^^^ is not correct, should be
"
(patch against 2.6.21-rc1)
Fix several typos in help text in Kconfig* files.
Signed-off-by: David Sterba <[EMAIL PROTECTED]>
---
arch/cris/arch-v32/drivers/Kconfig |2 +-
arch/h8300/Kconfig.debug |4 ++--
arch/i386/Kconfig.cpu |4 ++--
arch/ia64/K
On Tue, Sep 13, 2016 at 04:35:52AM +0900, Masahiro Yamada wrote:
> Remove unneeded variables and assignments.
>
> Signed-off-by: Masahiro Yamada
Reviewed-by: David Sterba
are used for vfs inode times as well. These can be
> transitioned to using timespec64 when btrfs internally
> changes to use timespec64 as well.
>
> Signed-off-by: Deepa Dinamani
> Cc: Chris Mason
> Cc: Josef Bacik
Acked-by: David Sterba
rfs_debug should consume fs_info when DEBUG is
> not defined")
> Signed-off-by: Arnd Bergmann
Reviewed-by: David Sterba
er the if-block
> hence the check is redundant and can be removed.
>
> Detected by CoverityScan, CID#1021040 ("Logically dead code")
>
> Signed-off-by: Colin Ian King
Reviewed-by: David Sterba
tch description for clarity. Cosmetic
> indentation updates.
>
> Signed-off-by: Nikolay Borisov
> Signed-off-by: Tejun Heo
> Cc: Chris Mason
> Cc: Josef Bacik
> Cc: David Sterba
Acked-by: David Sterba
On Tue, Oct 17, 2017 at 11:00:04AM +0200, Arnd Bergmann wrote:
> > 2 fs/btrfs/tree-checker.c:186:4: warning: format '%lu' expects argument of
> > type 'long unsigned int', but argument 6 has type 'unsigned int' [-Wformat=]
> > 1 fs/btrfs/tree-checker.c:186:70: warning: format '%lu' expects argumen
On Thu, May 25, 2017 at 02:27:21PM -0700, Omar Sandoval wrote:
> On Thu, May 25, 2017 at 12:18:02PM -0700, Vinnie Magro wrote:
> > Replace alloc_bitmap with call to kvzalloc. kvzalloc preserves the
> > same fallback heuristic.
>
> Looks good, thanks.
>
> Reviewed-by: Omar Sandoval
Added to queu
btrfs: avoid null pointer dereference on fs_info when calling btrfs_crit
btrfs: make array types static const, reduces object code size
David Sterba (4):
btrfs: scrub: get rid of sector_t
btrfs: rename page offset parameter in submit_extent_page
btrfs: get rid of secto
On Tue, Nov 14, 2017 at 07:39:11AM +0800, Qu Wenruo wrote:
> > - extend mount options to specify zlib compression level, -o compress=zlib:9
>
> However the support for it has a big problem, it will cause wild memory
> access for "-o compress" mount option.
>
> Kernel ASAN can detect it easily and
On Mon, Nov 06, 2017 at 09:04:37AM +0100, SF Markus Elfring wrote:
>
> * Adjust jump targets so that a call of the function "mutex_unlock"
> can be better reused for error cases at the end of this function.
>
> * Replace three calls by goto statements.
>
> This issue was detected by using the
On Sun, Oct 04, 2015 at 05:05:32PM +0800, Geliang Tang wrote:
> Just fix a typo in the code comment.
For this kind of changes please CC the 'trivial' tree triv...@kernel.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel
erformance gain is arguable but the generated code should be
smaller, which counts.
Reviewed-by: David Sterba
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/maj
On Sun, Sep 06, 2015 at 12:25:27PM +, Alexandru Moise wrote:
> Use memset() to null out the btrfs_delayed_ref_root of
> btrfs_transaction instead of setting all the members to 0 by hand.
>
> Signed-off-by: Alexandru Moise <00moses.alexande...@gmail.com>
> ---
> fs/btrfs/transaction.c | 10 +--
So, updated patches should mention that in the subject eg:
[PATCH v2] btrfs: memset cur_trans->delayed_refs to zero
On Mon, Sep 07, 2015 at 04:45:02PM +0300, Alexandru Moise wrote:
> Use memset() to null out the btrfs_delayed_ref_root of
> btrfs_transaction instead of setting all the members to 0
On Tue, Sep 22, 2015 at 08:02:25PM +, Alexandru Moise wrote:
> Improve readability by generalizing the profile validity checks.
>
> Signed-off-by: Alexandru Moise <00moses.alexande...@gmail.com>
Reviewed-by: David Sterba
--
To unsubscribe from this list: send the line &qu
On Mon, Sep 21, 2015 at 11:40:57AM +0800, Shan Hai wrote:
> From: Shan Hai
>
> The commit b37392ea86761 ("Btrfs: cleanup unnecessary parameter
> and variant of prepare_pages()") makes it redundant.
>
> Signed-off-by: Shan Hai
Reviewed-by: David Sterba
--
To unsu
On Sun, Oct 25, 2015 at 07:35:44PM +, Alexandru Moise wrote:
> Signed-off-by: Alexandru Moise <00moses.alexande...@gmail.com>
Reviewed-by: David Sterba
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@v
On Sun, Jul 29, 2018 at 11:03:17PM +0100, Al Viro wrote:
> A bunch of filesystems switched to discard_new_inode() (btrfs, ufs, udf, ext2,
> jfs)
> new primitive: discard_new_inode()
> btrfs: switch to discard_new_inode()
> ufs: switch to discard_new_inode()
> udf: switch to
On Sun, Jul 29, 2018 at 11:04:41PM +0100, Al Viro wrote:
> From: Al Viro
>
> Make sure that no partially set up inodes can be returned by
> open-by-handle.
>
> Signed-off-by: Al Viro
Acked-by: David Sterba
On Wed, Jul 11, 2018 at 06:49:46AM +0100, Mark Rutland wrote:
> > > Dave pointed out that it would be useful to be able to opt-in to full
> > > checks
> > > regardless of CONFIG_REFCOUNT_FULL, so that we can simplify callsites
> > > where we
> > > always want checks. I've spotted a few of these i
Hi,
please consider pulling the fix to 4.15. It's been reported recently
that readdir can list stale entries under some conditions. As it is a
user visible bug I'd like to get it fix despite we're in the late rc.
Thanks.
The following changes since commit ec35e48b286959991cdbb886f1bdeda4575c80b4:
On Tue, May 09, 2017 at 04:50:48AM +0800, kernel test robot wrote:
>
> FYI, we noticed the following commit:
>
> commit: cc8385b59e17d489814d54d6a846aba7051fdea5 ("btrfs: preallocate radix
> tree node for readahead")
> https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git master
For
On Wed, Jan 17, 2018 at 12:20:24PM -0800, Matthew Wilcox wrote:
> From: Matthew Wilcox
>
> This version of the XArray has no known bugs.
I've booted this patchset on 2 boxes, both had random problems during
boot. On one I was not able to diagnose what went wrong. On the other
one the system boot
On Thu, Jan 18, 2018 at 08:48:43AM -0800, Matthew Wilcox wrote:
> Thank you! I shall attempt to debug. Was this with a btrfs root
> filesystem? I'm most suspicious of those patches right now, since they've
> received next to no testing. I'm going to put together a smaller patchset
> which just
Hi,
we have two more fixes for 4.15, aimed for stable. The leak fix is
obvious, the second patch fixes a bug revealed by the refcount API, when
it behaves differently than previous atomic_t and reports refs going
from 0 to 1 in one case.
No merge conflicts. Please pull, thanks.
The following cha
The cross-release lockdep functionality has been removed in
e966eaeeb623f0997 ("locking/lockdep: Remove the cross-release locking
checks"), leaving the kernel parameter docs behind. The code handling
the parameter does not exist so this is a plain documentation change.
Signed-off-by: Da
On Mon, Jan 29, 2018 at 02:50:10AM +0800, kbuild test robot wrote:
> From: Fengguang Wu
>
> fs/btrfs/volumes.c:742:10-17: WARNING: ERR_CAST can be used with fs_devices
>
>
> Use ERR_CAST inlined function instead of ERR_PTR(PTR_ERR(...))
>
> Generated by: scripts/coccinelle/api/err_cast.cocci
list_add()
btrfs: drop devid as device_list_add() arg
Arnd Bergmann (1):
btrfs: tree-checker: use %zu format string for size_t
Colin Ian King (1):
btrfs: make function update_share_count static
David Sterba (46):
btrfs: rename device free rcu helper to free_device_rcu
On Wed, Jan 17, 2018 at 12:21:49PM -0800, Matthew Wilcox wrote:
> From: Matthew Wilcox
>
> The reada_lock in struct btrfs_device was only initialised, and not
> actually used. That's good because there's another lock also called
> reada_lock in the btrfs_fs_info that was quite heavily used. Rem
On Fri, Dec 22, 2017 at 07:05:43AM -0500, Jeff Layton wrote:
> From: Jeff Layton
>
> Signed-off-by: Jeff Layton
Acked-by: David Sterba
de dirty if that actually
> occurred or if one of the times was updated.
>
> Signed-off-by: Jeff Layton
Acked-by: David Sterba
th));
> + strncpy(di_args->path, name->str, sizeof(di_args->path) - 1);
> rcu_read_unlock();
> di_args->path[sizeof(di_args->path) - 1] = 0;
Reviewed-by: David Sterba
On Tue, Mar 06, 2018 at 11:23:16AM -0800, Matthew Wilcox wrote:
> From: Matthew Wilcox
>
> The current implementation of btrfs_page_exists_in_range() gives the
> wrong answer if the workingset code has stored a shadow entry in the
> page cache. The filemap_range_has_page() function does not have
On Tue, Mar 06, 2018 at 11:24:05AM -0800, Matthew Wilcox wrote:
> From: Matthew Wilcox
>
> Signed-off-by: Matthew Wilcox
Acked-by: David Sterba
e replaced with GFP_KERNEL,
> which can sleep and improve the possibility of sucessful allocation.
>
> This is found by a static analysis tool named DCNS written by myself.
> And I also manually check it.
>
> Signed-off-by: Jia-Ju Bai
Reviewed-by: David Sterba
We don't h
On Sat, Mar 17, 2018 at 06:27:15PM +0100, Christoph Biedl wrote:
> Greg Kroah-Hartman wrote...
>
> > On Thu, Mar 15, 2018 at 07:55:42PM +0100, Christoph Biedl wrote:
>
> > > > commit 3c181c12c431fe33b669410d663beb9cceefcd1b upstream.
>
> > > On big-endian systems, this change intruduces severe c
On Sat, Mar 10, 2018 at 10:19:04AM -0800, Andiry Xu wrote:
> From: Andiry Xu
>
> Sysfs support allows user to get/post information of running NOVA instance.
> After mount, NOVA creates four entries under proc directory
> /proc/fs/nova/pmem#/:
>
> timing_stats IO_statsallocator gc
On Mon, Apr 09, 2018 at 03:52:15PM +0200, Michal Hocko wrote:
> On Mon 09-04-18 06:41:14, Matthew Wilcox wrote:
> > On Mon, Apr 09, 2018 at 02:48:52PM +0200, Michal Hocko wrote:
> > > On Mon 09-04-18 20:25:06, Chao Yu wrote:
> > > [...]
> > > > diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c
> > > >
rg/lkml/2018/3/7/621
>
> Signed-off-by: Kees Cook
Acked-by: David Sterba
for whatever name you decide for the max macro.
1 - 100 of 698 matches
Mail list logo
