Rusty Russell wrote:
> > > CC arch/x86/um/../kernel/module.o
> > > arch/x86/um/../kernel/module.c:96:5: error: redefinition of
> > > 'apply_relocate_add'
> > > include/linux/moduleloader.h:64:19: note: previous definition of
> > > 'apply_relocate_add' was here
> > > make[2]: *** [arch/x
Richard Weinberger wrote:
> Is there no way to get this information from the UML subarch?
> Which is currently X86_32 or X86_64.
Or ppc or ia64? Or are those defunct?
I can certainly try pasting the lines from x86/Kconfig to uml/Kconfig.common
to switch the REL/RELA bits, but it would be nice
David Howells wrote:
> I can certainly try pasting the lines from x86/Kconfig to uml/Kconfig.common
> to switch the REL/RELA bits, but it would be nice to get this from the actual
> arch if possible to reduce redundancy.
The attached patch works.
David
---
diff --git a/arch/um/Kconfig
Richard Weinberger wrote:
> I think arch/x86/um/Kconfig makes more sense.
warthog>ls arch/um
defconfig Kconfig.common Kconfig.um Makefile-os-Linux scripts/
drivers/ Kconfig.debug kernel/Makefile-ppc sys-ia64/
include/ Kconfig.net Makefile Makefile-sk
David Howells wrote:
> > I think arch/x86/um/Kconfig makes more sense.
> ...
> It doesn't exist. Should I create it?
Bah. Helps if I read your message more closely.
David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the
How about this then?
David
---
diff --git a/arch/x86/um/Kconfig b/arch/x86/um/Kconfig
index 9926e11..a4b0c10 100644
--- a/arch/x86/um/Kconfig
+++ b/arch/x86/um/Kconfig
@@ -21,9 +21,11 @@ config 64BIT
config X86_32
def_bool !64BIT
select HAVE_AOUT
+ select MODULES_USE_ELF_RE
Ralf Baechle wrote:
> +extern int apply_r_mips_none(struct module *me, u32 *location, Elf_Addr v);
This needs to be in a header file, not a .c file.
David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majord
Oliver Hartkopp wrote:
> The defines are relevant for upcoming tools and drivers (for hardware that
> will become available in Q4/2012). So we're currently not breaking any
> Userspace API. After it turned out that one of the bits was misleading i
> wanted to fix the bits ASAP, so that the final
Rusty Russell wrote:
> For a build fix
Linux hasn't pulled the asm-generic cleanup patch yet - you missed the merge
window, I think. Jonas detected the problem in linux-next.
David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord
Hi Rusty,
I've posted new versions of my module signing patches to my GIT trees.
The patches with (approximately) your preferred way of attaching the signature
can be found here and I've followed this message with them:
http://git.kernel.org/?p=linux/kernel/git/dhowells/linux-modsign.g
Create a key type that can be used for general cryptographic operations, such
as encryption, decryption, signature generation and signature verification.
The key type is "crypto" and can provide access to a variety of cryptographic
algorithms.
Signed-off-by: David Howells
---
Doc
indicate that the verification failed and 0 will indicate success.
Other errors are also possible.
(4) void verify_sig_cancel(struct crypto_key_verify_context *ctx);
Cancel the verification process.
Signed-off-by: David Howells
---
Documentation/security/keys-crypto.txt | 100
Add a subtype for supporting asymmetric public-key encryption algorithms such
as DSA (FIPS-186) and RSA (PKCS#1 / RFC1337).
Signed-off-by: David Howells
---
security/keys/crypto/Kconfig | 10 +++
security/keys/crypto/Makefile |3 +
security/keys/crypto/public_key.c | 82
Implement RSA public key cryptography [PKCS#1 / RFC3447]. At this time, only
the signature verification algorithm is supported. This uses the asymmetric
public key subtype to hold its key data.
Signed-off-by: David Howells
---
security/keys/crypto/Kconfig |7 +
security/keys/crypto
code.
Thanks to Tomas Mraz and Miloslav Trmac for help.
Signed-off-by: Milan Broz
Signed-off-by: David Howells
---
security/keys/crypto/crypto_rsa.c | 14 +++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/security/keys/crypto/crypto_rsa.c
b/security/keys/crypto
,
struct pgp_parse_context *ctx);
This is configured on with CONFIG_PGP_LIBRARY.
Signed-off-by: David Howells
---
include/linux/pgplib.h | 47 ++
security/keys/crypto/Kconfig |6 +
security/keys/crypto/Makefile |1
security/keys/crypto
function to parse out basic signature parameters from any PGP signature
such that the algorithms and public key can be selected:
int pgp_parse_sig_params(const u8 **_data, size_t *_datalen,
struct pgp_sig_parameters *p);
Signed-off-by: David Howells
set up a public_key subtype payload with
appropriate handler routines (DSA or RSA) and attach it to the key.
Thanks to Tetsuo Handa for pointing out
some errors.
Signed-off-by: David Howells
---
security/keys/crypto/Kconfig | 12 +
security/keys/crypto/Makefile |4
to process.
This requires glue logic putting on top to make use of it - something the next
patch provides.
Signed-off-by: David Howells
---
security/keys/crypto/Makefile |3
security/keys/crypto/pgp_parser.h |6 +
security/keys/crypto/pgp_sig_verify.c | 325
Implement a signature parser that will attempt to parse a signature blob as a
PGP packet format message. If it can, it will find an appropriate crypto key
and set the public-key algorithm according to the data in the signature.
Signed-off-by: David Howells
---
security/keys/crypto/Makefile
Provide a facility to autogenerate the name of PGP keys from the contents of
the payload. If add_key() is given a blank description, a description is
constructed from the last user ID packet in the payload data plus the last 8
hex digits of the key ID. For instance:
keyctl padd crypto ""
oaded:
24460d1c I- 1 perm 3f01 0 0 cryptomodsign.0: dsa
5acc2142 []
3ca85723 I- 1 perm 1f01 0 0 keyring .module_sign: 1/4
Thanks to Tetsuo Handa for some pointing
out some errors.
Signed-off-by: David Howells
---
Documentation/security/keys-crypto.txt |
Provide gitignore and make clean rules for extra files to hide and clean up the
extra files produced by module signing stuff once it is added. Also add a
clean up rule for the module content extractor program used to extract the data
to be signed.
Signed-off-by: David Howells
---
.gitignore
be signed with a key compiled into
the kernel. All other modules are rejected with EKEYREJECTED.
Signed-off-by: David Howells
---
Documentation/module-signing.txt | 183 ++
include/linux/modsign.h | 27 ++
init/Kconfig
build)
and initramfs composition tools.
Note that I do not agree with this method of attaching signatures to modules.
Signed-off-by: David Howells
---
scripts/Makefile.modpost | 99 ++
1 file changed, 98 insertions(+), 1 deletion(-)
diff --git a/script
further modules from being loaded with that key.
Signed-off-by: David Howells
---
kernel/Makefile |3 ++
kernel/modsign-pubkey.c | 74 +++
kernel/module-verify.h | 14 +
3 files changed, 91 insertions(+)
create mode 100644
s there is no debug information directly available for the
module.
The original unstripped binary for the foo.ko module can be found as
foo.ko.unsigned in the build tree. It may be possible to use this as the debug
info source.
Signed-off-by: David Howells
---
include/linux/module.h |3
ring files to modsign.pub and modsign.sec so
that they are then a more obvious what they're about and add a dependency for
the signing rules on the keyring files so that the signatures get regenerated
if the keyrings change.
Signed-off-by: David Howells
---
kernel/
If module signing fails when the kernel is running with FIPS enabled then the
kernel should panic lest the crypto layer be compromised. Possibly a panic
shouldn't happen on cases like ENOMEM.
Reported-by: Stephan Mueller
Signed-off-by: David Howells
---
kernel/module-verify.c |5 +++
unknown key to load in cases
where we are not enforcing and not in FIPS mode.
Signed-off-by: Josh Boyer
Signed-off-by: David Howells
---
kernel/module-verify.c |7 +++
1 file changed, 7 insertions(+)
diff --git a/kernel/module-verify.c b/kernel/module-verify.c
index 070d730..c02d2e5
jwboyer's previous commit changes the behavior of module signing when
there's a valid signature but we don't know the public key and are in
permissive mode. This updates the documentation to match.
Signed-off-by: Peter Jones
Acked-by: Josh Boyer
Signed-off-by
ed in
using it.
Signed-off-by: David Howells
Cc: David S. Miller
Cc: Dmitry Kasatkin
Cc: Arnd Bergmann
---
include/asm-generic/bitops/count_zeros.h | 57
lib/mpi/longlong.h | 138 --
lib/mpi/mpi-bit.c|
Provide some useful PGP definitions from RFC 4880. These describe details of
public key crypto as used by crypto keys for things like signature
verification.
Signed-off-by: David Howells
---
include/linux/pgp.h | 206 +++
1 file changed, 206
Reinstate and export mpi_cmp() and mpi_cmp_ui() from the MPI library for use by
RSA signature verification as per RFC3447 section 5.2.2 step 1.
Signed-off-by: David Howells
---
lib/mpi/Makefile |1 +
lib/mpi/mpi-cmp.c | 70 +
2 files
passed in *prep, whether or not it was preparsed.
Signed-off-by: David Howells
---
Documentation/security/keys.txt | 50 ++
fs/cifs/cifs_spnego.c|6 +-
fs/cifs/cifsacl.c|8 +-
include/keys/user-type.h
Chuck Lever <[EMAIL PROTECTED]> wrote:
> > @@ -95,12 +100,25 @@ struct nfs_server {
> > unsigned intacdirmin;
> > unsigned intacdirmax;
> > unsigned intnamelen;
> > + unsigned intoptions;/* extra options enabled by
> > mount */
-off-by: David Howells <[EMAIL PROTECTED]>
---
include/linux/pagemap.h |5 +
mm/filemap.c| 18 ++
2 files changed, 23 insertions(+), 0 deletions(-)
diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h
index d22e975..eb08fb8 100644
--- a/i
make the checks for both
PG_private and PG_private_2 at the same time.
Signed-off-by: David Howells <[EMAIL PROTECTED]>
---
fs/splice.c|2 +-
include/linux/page-flags.h | 39 +--
include/linux/pagemap.h| 11 +++
mm/fil
These patches add local caching for network filesystems such as NFS.
The patches can roughly be broken down into a number of sets:
(*) 01-keys-inc-payload.diff
(*) 02-keys-search-keyring.diff
(*) 03-keys-callout-blob.diff
Three patches to the keyring code made to help the CIFS peop
is given and
2) check whether that top-level keyring is the thing being searched for
Signed-off-by: Kevin Coffman <[EMAIL PROTECTED]>
Signed-off-by: David Howells <[EMAIL PROTECTED]>
---
security/keys/keyring.c | 35 +++
1 files changed, 31 insert
must have view permission on the key for this function to be
successful.
Signed-off-by: David Howells <[EMAIL PROTECTED]>
Acked-by: Stephen Smalley <[EMAIL PROTECTED]>
---
Documentation/keys.txt | 21 +++
include/linux/keyctl.h |1 +
include/linux/security.h |
.
Supply a generic implementation for this that uses the write_begin() and
write_end() address_space operations to bind a copy directly into the page
cache.
Hook the Ext2 and Ext3 operations to the generic implementation.
Signed-off-by: David Howells <[EMAIL PROTECTED]>
---
fs/ext2/inode.c
Provide an add_wait_queue_tail() function to add a waiter to the back of a
wait queue instead of the front.
Signed-off-by: David Howells <[EMAIL PROTECTED]>
---
include/linux/pagemap.h |7 +--
include/linux/wait.h|2 ++
kernel/wait.c | 18
do the honours.
Signed-off-by: David Howells <[EMAIL PROTECTED]>
---
mm/readahead.c | 39 +--
1 files changed, 37 insertions(+), 2 deletions(-)
diff --git a/mm/readahead.c b/mm/readahead.c
index c9c50ca..75aa6b6 100644
--- a/mm/readahead.c
++
ropriately (see set_security_override[_from_ctx]()).
NOTE! This patch must be rolled in to one of the earlier security patches to
make it compile fully.
Signed-off-by: David Howells <[EMAIL PROTECTED]>
---
fs/nfsd/auth.c| 37 +++-
fs/nfsd/nfs4
must have view permission on the key for this function to be
successful.
Signed-off-by: David Howells <[EMAIL PROTECTED]>
Acked-by: Stephen Smalley <[EMAIL PROTECTED]>
---
Documentation/keys.txt | 21 +++
include/linux/keyctl.h |1 +
include/linux/security.h |
/linux/cred.h
new file mode 100644
index 000..497af5b
--- /dev/null
+++ b/include/linux/cred.h
@@ -0,0 +1,23 @@
+/* Credential management
+ *
+ * Copyright (C) 2007 Red Hat, Inc. All Rights Reserved.
+ * Written by David Howells ([EMAIL PROTECTED])
+ *
+ * This program is free software; y
. The cachefilesd
daemon will nominate the security ID to be used.
The second vector is used to grant a process the right to nominate a file
creation label for a kernel service to use.
Signed-off-by: David Howells <[EMAIL PROTECTED]>
---
security/selinux/include/av_perm_to_string.h
This one-line patch fixes the missing export of copy_page introduced
by the cachefile patches. This patch is not yet upstream, but is required
for cachefile on ia64. It will be pushed upstream when cachefile goes
upstream.
Signed-off-by: Prarit Bhargava <[EMAIL PROTECTED]>
Signed-off-by:
key blob is of variable length, depending on the length of (4).
The server object is given no coherency data to carry in the auxiliary data
permitted by the cache.
Signed-off-by: David Howells <[EMAIL PROTECTED]>
---
fs/nfs/Makefile |2 +
fs/nfs/client.c |5 +++
f
Add comment banners to some NFS functions so that they can be modified by the
NFS fscache patches for further information.
Signed-off-by: David Howells <[EMAIL PROTECTED]>
---
fs/nfs/file.c | 26 ++
1 files changed, 26 insertions(+), 0 deletions(-)
diff --gi
nfs_readpage_async() needs to be non-static so that it can be used as a
fallback for the local on-disk caching should an EIO crop up when reading the
cache.
Signed-off-by: David Howells <[EMAIL PROTECTED]>
---
fs/nfs/read.c |4 ++--
include/linux/nfs_fs.h |2 ++
2 files c
Add read context retention so that FS-Cache can call back into NFS when a read
operation on the cache fails EIO rather than reading data. This permits NFS to
then fetch the data from the server instead using the appropriate security
context.
Signed-off-by: David Howells <[EMAIL PROTEC
Store pages from an NFS inode into the cache data storage object associated
with that inode.
Signed-off-by: David Howells <[EMAIL PROTECTED]>
---
fs/nfs/fscache.c | 26 ++
fs/nfs/fscache.h | 16
fs/nfs/read.c|5 +
3 files chang
Bind data storage objects in the local cache to NFS inodes.
Signed-off-by: David Howells <[EMAIL PROTECTED]>
---
fs/nfs/fscache.c | 131
fs/nfs/fscache.h | 19 +++
fs/nfs/inode.c | 39 --
include
Display the local caching state in /proc/fs/nfsfs/volumes.
Signed-off-by: David Howells <[EMAIL PROTECTED]>
---
fs/nfs/client.c |7 ---
fs/nfs/fscache.h | 15 +++
2 files changed, 19 insertions(+), 3 deletions(-)
diff --git a/fs/nfs/client.c b/fs/nfs/client.c
Change current->fs[ug]id to current_fs[ug]id() so that fsgid and fsuid can be
separated from the task_struct.
Signed-off-by: David Howells <[EMAIL PROTECTED]>
---
arch/ia64/kernel/perfmon.c|4 ++--
arch/powerpc/platforms/cell/spufs/inode.c |4 ++--
drivers/
hen made use of by
the generic hook in the next patch, which is used by CacheFiles to write
pages to a file without setting up a file struct.
Signed-off-by: David Howells <[EMAIL PROTECTED]>
---
fs/ext3/inode.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff -
Export a number of functions for CacheFiles's use.
Signed-off-by: David Howells <[EMAIL PROTECTED]>
---
fs/super.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/fs/super.c b/fs/super.c
index ceaf2e3..cd199ae 100644
--- a/fs/super.c
+++ b/fs/super.c
@@ -2
Register NFS for caching and retrieve the top-level cache index object cookie.
Signed-off-by: David Howells <[EMAIL PROTECTED]>
---
fs/nfs/Makefile|1 +
fs/nfs/fscache-index.c | 53
fs/nfs/fscache.h
checked when a new
NFS in-memory inode is set up that matches an already existing data storage
object in the cache. If the coherency data is the same, the on-disk object is
retained and used; if not, it is scrapped and a new one created.
Signed-off-by: David Howells <[EMAIL PROTECTED]>
---
Permit local filesystem caching to be enabled for NFS in the kernel
configuration.
Signed-off-by: David Howells <[EMAIL PROTECTED]>
---
fs/Kconfig |8
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/fs/Kconfig b/fs/Kconfig
index c42ec50..fa8e978 100644
--
Read pages from an FS-Cache data storage object representing an inode into an
NFS inode.
Signed-off-by: David Howells <[EMAIL PROTECTED]>
---
fs/nfs/fscache.c | 112 ++
fs/nfs/fscache.h | 47 +++
fs/nfs/read.c
Add some new NFS I/O event counters for FS-Cache events. They have to be
added as byte counters because I may need to be able to increase the numbers
by more than 1 at a time.
Signed-off-by: David Howells <[EMAIL PROTECTED]>
---
fs/nfs/iostat.h |7 +++
1 files changed, 7 inse
Invalidate the FsCache page flags on the pages belonging to an inode when the
cache backing that NFS inode is removed.
This allows a live cache to be withdrawn.
Signed-off-by: David Howells <[EMAIL PROTECTED]>
---
fs/nfs/fscache-index.c | 40
1
Add FS-Cache option bit to nfs_server struct. This is set to indicate local
on-disk caching is enabled for a particular superblock.
Also add debug bit for local caching operations.
Signed-off-by: David Howells <[EMAIL PROTECTED]>
---
include/linux/nfs_fs.h|1 +
include
cache", won't end up
trying to share the on-disk cache. It will be possible to manually provide a
uniquifier through a mount option with a later patch to avoid the error
otherwise produced.
Signed-off-by: David Howells <[EMAIL PROTECTED]>
---
fs/nfs/fscache-index.c|
FS-Cache page management for NFS. This includes hooking the releasing and
invalidation of pages marked with PG_fscache (aka PG_private_2) and waiting for
completion of the write-to-cache flag (PG_fscache_write aka PG_owner_priv_2).
Signed-off-by: David Howells <[EMAIL PROTECTED]>
---
ng and give
a warning into the kernel log.
Signed-off-by: David Howells <[EMAIL PROTECTED]>
---
fs/nfs/client.c |2 ++
fs/nfs/internal.h |1 +
fs/nfs/super.c| 25 +
3 files changed, 28 insertions(+), 0 deletions(-)
diff --git a/fs/nfs/client.c
igned-off-by: David Howells <[EMAIL PROTECTED]>
---
security/keys/keyctl.c | 38 ++
1 files changed, 30 insertions(+), 8 deletions(-)
diff --git a/security/keys/keyctl.c b/security/keys/keyctl.c
index d9ca15c..8ec8432 100644
--- a/security/keys/key
()
request_key_async()
request_key_async_with_auxdata()
Signed-off-by: David Howells <[EMAIL PROTECTED]>
---
Documentation/keys-request-key.txt | 11 +---
Documentation/keys.txt | 14 +++---
include/linux/key.h|9 ---
security/keys/inte
is given and
2) check whether that top-level keyring is the thing being searched for
Signed-off-by: Kevin Coffman <[EMAIL PROTECTED]>
Signed-off-by: David Howells <[EMAIL PROTECTED]>
---
security/keys/keyring.c | 35 +++
1 files changed, 31 insert
igned-off-by: David Howells <[EMAIL PROTECTED]>
---
security/keys/keyctl.c | 38 ++
1 files changed, 30 insertions(+), 8 deletions(-)
diff --git a/security/keys/keyctl.c b/security/keys/keyctl.c
index d9ca15c..8ec8432 100644
--- a/security/keys/key
()
request_key_async()
request_key_async_with_auxdata()
Signed-off-by: David Howells <[EMAIL PROTECTED]>
---
Documentation/keys-request-key.txt | 11 +---
Documentation/keys.txt | 14 +++---
include/linux/key.h|9 ---
security/keys/inte
Only refer to the DRM UAPI headers (drm.h, drm_mode.h and drm_sarea.h) from
within drmP.h and drm_crtc.h, and use #include <...> to refer to them so that
when the UAPI split happens they can still be accessed.
Signed-off-by: David Howells
Acked-by: Dave Airlie
---
include/drm/
clude_next and move the uapi/ directories out of
the include/ directories:
include/uapi/ -> uapi/
arch/foo/include/uapi/ -> arch/foo/uapi/
as it seems cleaner, especially as there's then no need to #include
anywhere - but various people object to the
from the core
headers, after the UAPI split, the DRM C sources cannot find these UAPI headers
because the DRM code relies on specific -I flags to make #include "..." work
on headers in include/drm/ - but that does not work after the UAPI split without
adding more -I flags.
Signed-off
USERINCLUDE set.
Then use USERINCLUDE in building the x86 boot code.
Signed-off-by: David Howells
---
Makefile | 18 ++
arch/cris/Makefile|4 +++-
arch/x86/boot/Makefile|4 ++--
arch/x86/boot/mkcpustr.c |2
Set up empty UAPI Kbuild files to be populated by the header splitter.
Signed-off-by: David Howells
---
arch/alpha/include/uapi/asm/Kbuild |3 +++
arch/arm/include/uapi/asm/Kbuild|3 +++
arch/avr32/include/uapi/asm/Kbuild |3 +++
arch/blackfin/include
elect.h:78:5: note: previous declaration of 'fd_set' was here
and
/data/fs/linux-2.6-hdr/include/linux/string.h:42:12: error: expected identifier
or '(' before '__extension__'
Signed-off-by: David Howells
---
arch/x86/tools/Makefile |2 +-
1 file changed, 1 i
ifier
or '(' before '__extension__'
/data/fs/linux-2.6-hdr/include/linux/string.h:86:15: error: expected identifier
or '(' before ')' token
/data/fs/linux-2.6-hdr/include/linux/string.h:89:24: error: expected identifier
or '(' before '__extens
name
simultaneously.
The dynamic detection of mandatory files can be undone later.
Signed-off-by: David Howells
---
include/asm-generic/Kbuild.asm | 46 +
include/uapi/asm-generic/Kbuild.asm | 49 +++
2 files change
Move include/linux/version.h to the include/generated/ header directory.
A later patch will move it to include/uapi/generated/.
This allows us to get rid of the objhdr-y list.
Signed-off-by: David Howells
---
Makefile | 13 +++--
include/linux/Kbuild |2 +-
2 files
Remove the objhdr-y export list as it is no longer used. genhdr-y should be
used instead.
Signed-off-by: David Howells
---
Documentation/kbuild/makefiles.txt |8
scripts/Makefile.headersinst |7 ++-
2 files changed, 6 insertions(+), 9 deletions(-)
diff --git a
this path.
Signed-off-by: David Howells
---
arch/x86/syscalls/Makefile | 17 ++---
1 file changed, 10 insertions(+), 7 deletions(-)
diff --git a/arch/x86/syscalls/Makefile b/arch/x86/syscalls/Makefile
index 3236aeb..174b032 100644
--- a/arch/x86/syscalls/Makefile
+++ b/arch/x86
.../include/generated/foo/
The non-UAPI paths will be dropped later.
Signed-off-by: David Howells
---
Makefile| 14 +--
arch/x86/include/asm/Kbuild |4 ---
arch/x86/syscalls/Makefile |2 +-
include/linux/Kbuild
David Howells wrote:
> + -Iinclude/uapi \
This needs prefacing with $(srctree)/. I got it right in the commit message
but not in the patch. Thanks to Fengguang Wu for finding it with his kernel
cruncher.
David
--
To unsubscribe from this list: send the line "unsubscri
And thanks to Al for pointing out that the UM arch needed fixing. The
attached patch should do the trick.
David
---
diff --git a/arch/um/Makefile b/arch/um/Makefile
index 0970910..133f7de 100644
--- a/arch/um/Makefile
+++ b/arch/um/Makefile
@@ -66,7 +66,9 @@ USER_CFLAGS = $(patsubst $(KERNEL_DEF
Michael Kerrisk wrote:
> In the uapi-split branch, there are now 44 empty Kbuild files. Was
> that intended? Or, should these files rather be removed by your
> patches?
To be removed by a later patch, I think. Getting rid of some of them isn't
trivial - ones in arch/x/include/asm/Kbuild for exa
Michael Kerrisk wrote:
> A few other points that I noticed now...
>
> 1. GIT HISTORY COULD BE RETAINED IN SOME CASES
> ...
> But, as currently scripted the "new" uapi header file does not carry
> over the git history of the old "kapi" header, even though it is an
> exact duplicate of that file.
Michael Kerrisk wrote:
> >> 2. EMPTY UAPI HEADERS
> >>
> >> Some of the resulting uapi header files are empty:
> >> ...
> >> I imagine this should be reasonably easy to fix.
> >
> > Fix how? The Kbuild files say these headers must exist in UAPI space, but
> > the __KERNEL__ guards therein don't
Michael Kerrisk wrote:
> >> 4. DISINTEGRATE MARKERS LEFT OVER (?)
> >>
> >> Some of the DISINTEGRATE markers that you create during the scripting
> >> process are left in the final uapi files. Was this intentional?
> >
> > Ummm... no, there shouldn't be any.
> >
> > Certainly the marker has worke
David Howells wrote:
> Okay... Dealt with that in the script. The following command:
>
> git diff uapi-post-split-20120724
>
> shows the attached.
See tag removed-left-over-markers in my GIT tree.
David
--
To unsubscribe from this list: send the line "unsubscribe
David Howells wrote:
> > >> 3. HEADER COMMENTS NOT RETAINED IN KAPI FILES
>
> How about the attached changes? This is a delta to the disintegrate markers
> diff I sent earlier.
See the duplicated-important-banners tag in my GIT tree.
David
--
To unsubscribe from thi
Hi Linus,
Linus Torvalds wrote:
> So, due to travels, the -rc2 release was two weeks instead of the
> usual one. But it's out there now.
Are you still considering my UAPI header patches and Nicholas's tcm_vhost
merge as you mentioned in the -rc1 announcement? Or are these now in the
category
The declaration of arch_release_thread_info() needs a semicolon.
Signed-off-by: David Howells
---
arch/mn10300/include/asm/thread_info.h |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mn10300/include/asm/thread_info.h
b/arch/mn10300/include/asm/thread_info.h
index
Randy Dunlap wrote:
> > Changes since 20130117:
> >
>
> on x86_64:
>
> make[2]: *** No rule to make target `signing_key.x509', needed by
> `kernel/x509_certificate_list'. Stop.
>
>
> Full randconfig file is attached.
Works for me. It's likely that the changes I made on the 18th aren't in
Kyle McMartin wrote:
> Commit 1d0059f3a added a test to check if the system is booted in fips
> mode, and if so, panic the system if an unsigned module is loaded.
> However the wording of the changelog "in signature enforcing mode" leads
> one to assume that sig_enforce should be set for the pani
Vineet Gupta wrote:
> I generated this patch using the scripts you provided. If these look OK to
> you, can you please ACK.
You need to take a look at uapi/asm/setup.h. It's created as an empty file -
which will get discarded by patch. Do you actually need a UAPI instance of
that?
David
--
To
Lee, Chun-Yi wrote:
> Signed-off-by: Lee, Chun-Yi
Without the comma, please.
> + /* Short Form length */
> + if (vlen <= 127) {
> +
> + if (v[1] != vlen - 2 ||
There's an unnecessary blank line there. I would also move the comment inside
the if-bod
601 - 700 of 7895 matches
Mail list logo