Re: Is spin_is_locked() safe to use with BUG_ON()/WARN_ON()?

2013-05-23 Thread David Howells
Linus Torvalds wrote: > We do *not* want to add some crazy "spin_is_nt_locked". We just want > to get rid of these idiotic debug tests. Generally, I think you are right, though there are also some checks in deallocation routines that check that a spinlock is not currently held before releasing t

[PATCH 1/4] MN10300: Fix ret_from_kernel_thread

2013-05-28 Thread David Howells
Date: Thu Oct 11 17:32:41 2012 -0400 Subject: mn10300: switch to saner kernel_execve() semantics Reported-by: Ken Cox Signed-off-by: David Howells Acked-by: Ken Cox Acked-by: Al Viro --- arch/mn10300/kernel/entry.S |1 + 1 file changed, 1 insertion(+) diff --git a/arch

[PATCH 2/4] MN10300: Enable IRQs more in system call exit work path

2013-05-28 Thread David Howells
5a8>] task_work_run+0x64/0x78 [<9010bda7>] ? sys_connect+0x5b/0x80 [<90002399>] do_notify_resume+0x53d/0x544 [<90067dc6>] ? fput+0xce/0xd4 [<90065117>] ? filp_close+0x5f/0x68 [<9007bba0>] ? __close_fd+0x7c/0xb0 [<900026c6>] work_notifysig+0xa/0xc Signed

[PATCH 3/4] MN10300: ASB2305's PCI code needs the definition of XIRQ1

2013-05-28 Thread David Howells
mn10300/unit-asb2305/pci.c:481: error: (Each undeclared identifier is reported only once arch/mn10300/unit-asb2305/pci.c:481: error: for each function it appears in.) Signed-off-by: David Howells Acked-by: Ken Cox --- arch/mn10300/unit-asb2305/pci.c |1 + 1 file changed, 1 insertion(+)

[PATCH 4/4] MN10300: Need pci_iomap() and __pci_ioport_map() defining

2013-05-28 Thread David Howells
.c: In function 'reset_ivb_igd': drivers/pci/quirks.c:3133: warning: assignment makes pointer from integer without a cast Signed-off-by: David Howells Acked-by: Ken Cox --- arch/mn10300/include/asm/pci.h |2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/mn10300/includ

[PATCH 1/4] MN10300: Fix ret_from_kernel_thread

2013-05-28 Thread David Howells
Date: Thu Oct 11 17:32:41 2012 -0400 Subject: mn10300: switch to saner kernel_execve() semantics Reported-by: Ken Cox Signed-off-by: David Howells Acked-by: Ken Cox Acked-by: Al Viro --- arch/mn10300/kernel/entry.S |1 + 1 file changed, 1 insertion(+) diff --git a/arch

[PATCH 2/4] MN10300: Enable IRQs more in system call exit work path

2013-05-28 Thread David Howells
5a8>] task_work_run+0x64/0x78 [<9010bda7>] ? sys_connect+0x5b/0x80 [<90002399>] do_notify_resume+0x53d/0x544 [<90067dc6>] ? fput+0xce/0xd4 [<90065117>] ? filp_close+0x5f/0x68 [<9007bba0>] ? __close_fd+0x7c/0xb0 [<900026c6>] work_notifysig+0xa/0xc Signed

[PATCH 3/4] MN10300: ASB2305's PCI code needs the definition of XIRQ1

2013-05-28 Thread David Howells
mn10300/unit-asb2305/pci.c:481: error: (Each undeclared identifier is reported only once arch/mn10300/unit-asb2305/pci.c:481: error: for each function it appears in.) Signed-off-by: David Howells Acked-by: Ken Cox --- arch/mn10300/unit-asb2305/pci.c |1 + 1 file changed, 1 insertion(+)

[PATCH 4/4] MN10300: Need pci_iomap() and __pci_ioport_map() defining

2013-05-28 Thread David Howells
.c: In function 'reset_ivb_igd': drivers/pci/quirks.c:3133: warning: assignment makes pointer from integer without a cast Signed-off-by: David Howells Acked-by: Ken Cox --- arch/mn10300/include/asm/pci.h |2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/mn10300/includ

Re: [PATCH 1/4] MN10300: Fix ret_from_kernel_thread

2013-05-28 Thread David Howells
Linus Torvalds wrote: > What kernel version are these patches against? > > You explicitly mention commit ddf23e87a804, but the patch contains > ret_from_kernel_execve that was *removed* by that commit. > > So the whole thing seems very confused. I'm dropping this series. Sorry about that. It

[PATCH 1/4] MN10300: Fix ret_from_kernel_thread [ver #2]

2013-05-28 Thread David Howells
Date: Thu Oct 11 17:32:41 2012 -0400 Subject: mn10300: switch to saner kernel_execve() semantics Reported-by: Ken Cox Signed-off-by: David Howells Acked-by: Ken Cox Acked-by: Al Viro --- arch/mn10300/kernel/entry.S |1 + 1 file changed, 1 insertion(+) diff --git a/arch

[PATCH 2/4] MN10300: Enable IRQs more in system call exit work path [ver #2]

2013-05-28 Thread David Howells
5a8>] task_work_run+0x64/0x78 [<9010bda7>] ? sys_connect+0x5b/0x80 [<90002399>] do_notify_resume+0x53d/0x544 [<90067dc6>] ? fput+0xce/0xd4 [<90065117>] ? filp_close+0x5f/0x68 [<9007bba0>] ? __close_fd+0x7c/0xb0 [<900026c6>] work_notifysig+0xa/0xc Signed

[PATCH 3/4] MN10300: ASB2305's PCI code needs the definition of XIRQ1 [ver #2]

2013-05-28 Thread David Howells
mn10300/unit-asb2305/pci.c:481: error: (Each undeclared identifier is reported only once arch/mn10300/unit-asb2305/pci.c:481: error: for each function it appears in.) Signed-off-by: David Howells Acked-by: Ken Cox --- arch/mn10300/unit-asb2305/pci.c |1 + 1 file changed, 1 insertion(+)

[PATCH 4/4] MN10300: Need pci_iomap() and __pci_ioport_map() defining [ver #2]

2013-05-28 Thread David Howells
.c: In function 'reset_ivb_igd': drivers/pci/quirks.c:3133: warning: assignment makes pointer from integer without a cast Signed-off-by: David Howells Acked-by: Ken Cox --- arch/mn10300/include/asm/pci.h |2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/mn10300/includ

Re: [PATCH] UAPI: Remove empty Kbuild files

2013-03-26 Thread David Howells
Andrew Morton wrote: > > Remove empty Kbuild files as they cause problems with the patch program > > which removes files that become empty. > > > > Should I also remove include/Kbuild as that now does nothing? Or should > > it be left as an anchor just in case we want it in future? > > I think

Re: [PATCH] UAPI: Remove empty Kbuild files

2013-03-26 Thread David Howells
Andrew Morton wrote: > Obviously, I thought you were referring to build-time operations. I want to know whether I should extend my patch to remove include/Kbuild and any refs to it. > > so I don't see the problem. > > Well damn. I tested this a few days ago and a `make mrproper' didn't > remov

Re: [PATCH] UAPI: Remove empty Kbuild files

2013-03-26 Thread David Howells
Michal Marek wrote: > > I want to know whether I should extend my patch to remove include/Kbuild and > > any refs to it. > > make headers_install starts at include/uapi, so include/Kbuild is not > needed. And new exported headers end up in inclde/uapi, so there will > probably not be need for in

Re: [PATCH] UAPI: Remove empty Kbuild files

2013-03-26 Thread David Howells
Michal Marek wrote: > >>> I want to know whether I should extend my patch to remove include/Kbuild > >>> and any refs to it. > >> > >> make headers_install starts at include/uapi, so include/Kbuild is not > >> needed. And new exported headers end up in inclde/uapi, so there will > >> probably not

Re: [PATCH] MODSIGN: Discard previous signature when signing modules

2013-03-26 Thread David Howells
Michal Marek wrote: > The format only supports one signature, so discard any previous > signature before signing the module. That's not totally true. The format does not preclude multiple signatures. You can just add another signature block on the end that signs everything inside of that, inclu

[PATCH 1/2] xhci: Use ilog2() rather than __ffs() for calculating SEGMENT_SHIFT

2013-03-28 Thread David Howells
Use ilog2() rather than __ffs() for calculating SEGMENT_SHIFT as ilog2() can be worked out at compile time, whereas __ffs() must be calculated at runtime. Signed-off-by: David Howells cc: Sarah Sharp cc: Greg Kroah-Hartman cc: linux-...@vger.kernel.org --- drivers/usb/host/xhci.h |2

[PATCH 2/2] xhci: Rename SEGMENT_SIZE and SEGMENT_SHIFT as the former is used in a.out.h

2013-03-28 Thread David Howells
Rename SEGMENT_SIZE and SEGMENT_SHIFT as the former is used in a.out.h. Signed-off-by: David Howells cc: Sarah Sharp cc: Greg Kroah-Hartman cc: linux-...@vger.kernel.org --- drivers/usb/host/xhci-mem.c | 16 drivers/usb/host/xhci.h |4 ++-- 2 files changed, 10

Re: [PATCH 2/2] xhci: Rename SEGMENT_SIZE and SEGMENT_SHIFT as the former is used in a.out.h

2013-03-28 Thread David Howells
Sarah Sharp wrote: > I'm a little bit confused about your description for the second one. > Did you need to change the #defines names because they could conflict > with other drivers when the xHCI driver is built in? Or is there some > other point I'm missing? Sorry, I should say. I'm trying t

Byteorder conditional compilation problems

2013-03-06 Thread David Howells
Hi Linus, Looking at commit 13da9e200fe4740b02cd51e07ab454627e228920, I suspect the answer will be no, but can we please revisit the use of __BYTE_ORDER in the kernel? The reason for this is that I've noticed a number of places in the UAPI headers where __LITTLE_ENDIAN and __BIG_ENDIAN are assu

[RFC][PATCH 0/4] UAPI: Fix up endianness conditionals

2013-03-06 Thread David Howells
changing the actual userspace API. David --- David Howells (4): UAPI: Fix endianness conditionals in linux/aio_abi.h UAPI: Fix endianness conditionals in linux/acct.h UAPI: Fix endianness conditionals in linux/raid/md_p.h UAPI: Fix endianness conditionals in M32R's asm/stat.h

[PATCH 1/4] UAPI: Fix endianness conditionals in linux/aio_abi.h

2013-03-06 Thread David Howells
e little-endian variant on big-endian machines - depending on header inclusion order. [!!!] NOTE [!!!] This patch may adversely change the userspace API. It might be better to fix the ordering of aio_key and aio_reserved1 in struct iocb. Signed-off-by: David Howells cc: Benjamin LaHaise cc: linu

[PATCH 2/4] UAPI: Fix endianness conditionals in linux/acct.h

2013-03-06 Thread David Howells
- depending on header inclusion order. [!!!] NOTE [!!!] This patch may adversely change the userspace API. It might be better to fix the value of ACCT_BYTEORDER. Signed-off-by: David Howells --- include/uapi/linux/acct.h |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff

[PATCH 4/4] UAPI: Fix endianness conditionals in M32R's asm/stat.h

2013-03-06 Thread David Howells
ttle-endian machines - depending on header inclusion order. [!!!] NOTE [!!!] This patch may adversely change the userspace API. It might be better to fix the ordering of st_blocks and __pad4 in struct stat64. Signed-off-by: David Howells cc: Hirokazu Takata cc: linux-m...@ml.linux-m32r.org cc: li

[PATCH 3/4] UAPI: Fix endianness conditionals in linux/raid/md_p.h

2013-03-06 Thread David Howells
an variant on a little-endian machines - depending on header inclusion order. [!!!] NOTE [!!!] This patch may adversely change the userspace API. It might be better to fix the ordering of events_hi, events_lo, cp_events_hi and cp_events_lo in struct mdp_superblock_s / typedef mdp_super_t. Signe

[PATCH] KEYS: Fix race with concurrent install_user_keyrings()

2013-03-06 Thread David Howells
eciding whether to return. Alternatively, the test could be done away with entirely as it is checked inside the mutex - but since the mutex is global, that may not be the best way. Reported-by: Mateusz Guzik Signed-off-by: David Howells --- security/keys/process_keys.c |2 +- 1 fi

Re: [PATCH] VSOCK: Split vm_sockets.h into kernel/uapi

2013-03-07 Thread David Howells
ets application. > > Reported-by: David Howells > Acked-by: Dmitry Torokhov > Signed-off-by: Andy King Acked-by: David Howells -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH] VSOCK: Split vm_sockets.h into kernel/uapi

2013-03-07 Thread David Howells
Greg KH wrote: > David, is there any rush to get stuff like this into 3.9 for any > uapi-type changes, or can it just wait for 3.10? Not especially. It won't appear in userspace due to the __KERNEL__ guards. David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in th

Re: [PATCH] MODSIGN: Fix documentation of signed-nokey behavior when not enforcing.

2012-08-02 Thread David Howells
Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 00/25] Crypto keys and module signing

2012-08-22 Thread David Howells
Rusty Russell wrote: > > I've posted new versions of my module signing patches to my GIT trees. > > Now I get to punt this discussion to KS. :-) See you there! Dmitry, Mimi: We should discuss if there's any way to integrate our two approaches. Are you going to the security summit? David --

Re: [PATCH] Smack: setprocattr memory leak fix

2012-08-23 Thread David Howells
and > never freed. The duplicate code is removed from > smack_setprocattr. > > Targeted for git://git.gitorious.org/smack-next/kernel.git > > Signed-off-by: Casey Schaufler Acked-by: David Howells Note that I do have a patch to make Smack share rule lists - I've p

Re: [PATCH 14/16] X.509: Add an ASN.1 decoder

2012-09-18 Thread David Howells
Alan Cox wrote: > Why do this in the kernel.That appears to be completely insane. A number of reasons: (1) The UEFI signature/key database may contain ASN.1 X.509 certificates and we may need to use those very early in the boot process, during initrd. (2) Even if userspace is available,

Re: [PATCH 14/16] X.509: Add an ASN.1 decoder

2012-09-18 Thread David Howells
David Howells wrote: > > has it been fuzz tested extensively ? Also, here's a generator of random binary ASN.1. I think it should mostly produce valid X.509, but invalid ASN.1 is okay too. Run with something like: while :; do ./asn1random.pl | keyctl padd asymmetric vl

Re: [PATCH 14/16] X.509: Add an ASN.1 decoder

2012-09-18 Thread David Howells
David Howells wrote: > Also, here's a generator of random binary ASN.1. I think it should mostly > produce valid X.509, but invalid ASN.1 is okay too. > ... > $len = 4; # With this line removed, obviously... David -- To unsubscribe from this li

Re: [PATCH 14/16] X.509: Add an ASN.1 decoder

2012-09-19 Thread David Howells
David Howells wrote: > > has it been fuzz tested extensively ? Here's a perl script to generate validly structured X.509 certificates with random data in them. It can be run as follows: while :; do ./x509random.pl | keyctl padd asymmetric vlad @s; done and it can also

Re: [PATCH 14/16] X.509: Add an ASN.1 decoder

2012-09-20 Thread David Howells
James Morris wrote: > I'd like to see some serious effort at code review and testing before this > code is merged. With regard to testing, I've run multiple simultaneous instances of a number of test scripts against it continuously for the best part of a day: (1) A script to generate complete

Re: [PATCH 1/3] Fix Unlikely(x) == y

2008-02-18 Thread David Howells
Geert Uytterhoeven <[EMAIL PROTECTED]> wrote: > Hence shouldn't we ask the gcc people what's the purpose of > __builtin_expect(), if it doesn't live up to its promise? __builtin_expect() is useful on FRV where you _have_ to give each branch and conditional branch instruction a measure of probabil

[PATCH 1/4] MN10300: Call update_process_times() outside of the xtime_lock

2008-02-19 Thread David Howells
Call update_process_times() outside of the xtime_lock. Somewhere somewhere inside one of the functions called by that, xtime_lock is readlocked, which ends up in a deadlock situation. Signed-off-by: David Howells <[EMAIL PROTECTED]> --- arch/mn10300/kernel/time.c |4 +++- 1 files c

[PATCH 2/4] MN10300: Introduce barriers to replace removed volatiles in gdbstub

2008-02-19 Thread David Howells
Introduce into the MN10300 gdbstub a couple of barrier() calls to replace the removed volatility of the input/output index variables for the Rx ring buffer. Signed-off-by: David Howells <[EMAIL PROTECTED]> --- arch/mn10300/kernel/gdb-io-ttysm.c |2 ++ 1 files changed, 2 insertions

[PATCH 3/4] MN10300: Make the kernel jump into gdbstub on a BUG

2008-02-19 Thread David Howells
rts a SIGABRT to the compiler and reports the program counter at the original BUG, allowing the execution state at the time of the BUG to be examined with GDB. Signed-off-by: David Howells <[EMAIL PROTECTED]> --- arch/mn10300/kernel/traps.c |2 +- 1 files changed, 1 insertions(+),

[PATCH 4/4] MN10300: Update asb2303_defconfig

2008-02-19 Thread David Howells
Update the ASB2303 default configuration. Signed-off-by: David Howells <[EMAIL PROTECTED]> --- arch/mn10300/configs/asb2303_defconfig | 33 +++- 1 files changed, 24 insertions(+), 9 deletions(-) diff --git a/arch/mn10300/configs/asb2303_defconfig b/arch/m

Re: [QUESTION] FRV: linking error?

2008-02-20 Thread David Howells
Cyrill Gorcunov <[EMAIL PROTECTED]> wrote: > being see over vmlinux.lds for FRV architecture I found the string: > > . = ALIGN(4096); > .data.page_aligned : { *(.data.idt) } > > though the PAGE_SIZE is 16K. Can't figure out why is that... > Do you have a few spare minutes to explain,

[PATCH 00/37] Permit filesystem local caching

2008-02-20 Thread David Howells
These patches add local caching for network filesystems such as NFS. The patches can roughly be broken down into a number of sets: (*) 01-keys-inc-payload.diff (*) 02-keys-search-keyring.diff (*) 03-keys-callout-blob.diff Three patches to the keyring code made to help the CIFS peop

[PATCH 03/37] KEYS: Allow the callout data to be passed as a blob rather than a string

2008-02-20 Thread David Howells
() request_key_async() request_key_async_with_auxdata() Signed-off-by: David Howells <[EMAIL PROTECTED]> --- Documentation/keys-request-key.txt | 11 +--- Documentation/keys.txt | 14 +++--- include/linux/key.h|9 --- security/keys/inte

[PATCH 10/37] Security: Make NFSD work with detached security

2008-02-20 Thread David Howells
ropriately (see set_security_override[_from_ctx]()). NOTE! This patch must be rolled in to one of the earlier security patches to make it compile fully. Signed-off-by: David Howells <[EMAIL PROTECTED]> --- fs/nfsd/auth.c| 37 +++- fs/nfsd/nfs4

[PATCH 13/37] FS-Cache: Provide an add_wait_queue_tail() function

2008-02-20 Thread David Howells
Provide an add_wait_queue_tail() function to add a waiter to the back of a wait queue instead of the front. Signed-off-by: David Howells <[EMAIL PROTECTED]> --- include/linux/pagemap.h |7 +-- include/linux/wait.h|1 + kernel/wait.c | 18

[PATCH 05/37] Security: Change current->fs[ug]id to current_fs[ug]id()

2008-02-20 Thread David Howells
Change current->fs[ug]id to current_fs[ug]id() so that fsgid and fsuid can be separated from the task_struct. Signed-off-by: David Howells <[EMAIL PROTECTED]> --- arch/ia64/kernel/perfmon.c|4 ++-- arch/powerpc/platforms/cell/spufs/inode.c |4 ++-- drivers/

[PATCH 09/37] Security: Allow kernel services to override LSM settings for task actions

2008-02-20 Thread David Howells
S != 2 */ diff --git a/include/linux/cred.h b/include/linux/cred.h new file mode 100644 index 000..497af5b --- /dev/null +++ b/include/linux/cred.h @@ -0,0 +1,23 @@ +/* Credential management + * + * Copyright (C) 2007 Red Hat, Inc. All Rights Reserved. + * Written by David Howells ([EMAIL PRO

[PATCH 02/37] KEYS: Check starting keyring as part of search

2008-02-20 Thread David Howells
is given and 2) check whether that top-level keyring is the thing being searched for Signed-off-by: Kevin Coffman <[EMAIL PROTECTED]> Signed-off-by: David Howells <[EMAIL PROTECTED]> --- security/keys/keyring.c | 35 +++ 1 files changed, 31 insert

[PATCH 23/37] NFS: Permit local filesystem caching to be enabled for NFS

2008-02-20 Thread David Howells
Permit local filesystem caching to be enabled for NFS in the kernel configuration. Signed-off-by: David Howells <[EMAIL PROTECTED]> --- fs/Kconfig |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/fs/Kconfig b/fs/Kconfig index c42ec50..fa8e978 100644 --

[PATCH 27/37] NFS: Define and create inode-level cache objects

2008-02-20 Thread David Howells
checked when a new NFS in-memory inode is set up that matches an already existing data storage object in the cache. If the coherency data is the same, the on-disk object is retained and used; if not, it is scrapped and a new one created. Signed-off-by: David Howells <[EMAIL PROTECTED]> ---

[PATCH 08/37] Security: Add a kernel_service object class to SELinux

2008-02-20 Thread David Howells
. The cachefilesd daemon will nominate the security ID to be used. The second vector is used to grant a process the right to nominate a file creation label for a kernel service to use. Signed-off-by: David Howells <[EMAIL PROTECTED]> --- security/selinux/include/av_perm_to_string.h

[PATCH 11/37] FS-Cache: Release page->private after failed readahead

2008-02-20 Thread David Howells
do the honours. Signed-off-by: David Howells <[EMAIL PROTECTED]> --- mm/readahead.c | 39 +-- 1 files changed, 37 insertions(+), 2 deletions(-) diff --git a/mm/readahead.c b/mm/readahead.c index c9c50ca..75aa6b6 100644 --- a/mm/readahead.c ++

[PATCH 01/37] KEYS: Increase the payload size when instantiating a key

2008-02-20 Thread David Howells
igned-off-by: David Howells <[EMAIL PROTECTED]> --- security/keys/keyctl.c | 38 ++ 1 files changed, 30 insertions(+), 8 deletions(-) diff --git a/security/keys/keyctl.c b/security/keys/keyctl.c index d9ca15c..8ec8432 100644 --- a/security/keys/key

[PATCH 28/37] NFS: Use local disk inode cache

2008-02-20 Thread David Howells
Bind data storage objects in the local cache to NFS inodes. Signed-off-by: David Howells <[EMAIL PROTECTED]> --- fs/nfs/fscache.c | 131 fs/nfs/fscache.h | 19 +++ fs/nfs/inode.c | 39 -- include

[PATCH 04/37] KEYS: Add keyctl function to get a security label

2008-02-20 Thread David Howells
must have view permission on the key for this function to be successful. Signed-off-by: David Howells <[EMAIL PROTECTED]> Acked-by: Stephen Smalley <[EMAIL PROTECTED]> --- Documentation/keys.txt | 21 +++ include/linux/keyctl.h |1 + include/linux/security.h |

[PATCH 26/37] NFS: Define and create superblock-level objects

2008-02-20 Thread David Howells
cache", won't end up trying to share the on-disk cache. It will be possible to manually provide a uniquifier through a mount option with a later patch to avoid the error otherwise produced. Signed-off-by: David Howells <[EMAIL PROTECTED]> --- fs/nfs/fscache-index.c|

[PATCH 22/37] NFS: Add FS-Cache option bit and debug bit

2008-02-20 Thread David Howells
Add FS-Cache option bit to nfs_server struct. This is set to indicate local on-disk caching is enabled for a particular superblock. Also add debug bit for local caching operations. Signed-off-by: David Howells <[EMAIL PROTECTED]> --- include/linux/nfs_fs.h|1 + include

[PATCH 16/37] CacheFiles: Be consistent about the use of mapping vs file->f_mapping in Ext3

2008-02-20 Thread David Howells
hen made use of by the generic hook in the next patch, which is used by CacheFiles to write pages to a file without setting up a file struct. Signed-off-by: David Howells <[EMAIL PROTECTED]> --- fs/ext3/inode.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff -

[PATCH 12/37] FS-Cache: Recruit a couple of page flags for cache management

2008-02-20 Thread David Howells
make the checks for both PG_private and PG_private_2 at the same time. Signed-off-by: David Howells <[EMAIL PROTECTED]> --- fs/splice.c|2 +- include/linux/page-flags.h | 39 +-- include/linux/pagemap.h| 11 +++ mm/fil

[PATCH 29/37] NFS: Invalidate FsCache page flags when cache removed

2008-02-20 Thread David Howells
Invalidate the FsCache page flags on the pages belonging to an inode when the cache backing that NFS inode is removed. This allows a live cache to be withdrawn. Signed-off-by: David Howells <[EMAIL PROTECTED]> --- fs/nfs/fscache-index.c | 40 1

[PATCH 25/37] NFS: Define and create server-level objects

2008-02-20 Thread David Howells
key blob is of variable length, depending on the length of (4). The server object is given no coherency data to carry in the auxiliary data permitted by the cache. Signed-off-by: David Howells <[EMAIL PROTECTED]> --- fs/nfs/Makefile |2 + fs/nfs/client.c |5 +++ f

[PATCH 33/37] NFS: nfs_readpage_async() needs to be accessible as a fallback for local caching

2008-02-20 Thread David Howells
nfs_readpage_async() needs to be non-static so that it can be used as a fallback for the local on-disk caching should an EIO crop up when reading the cache. Signed-off-by: David Howells <[EMAIL PROTECTED]> --- fs/nfs/read.c |4 ++-- include/linux/nfs_fs.h |2 ++ 2 files c

[PATCH 36/37] NFS: Display local caching state

2008-02-20 Thread David Howells
Display the local caching state in /proc/fs/nfsfs/volumes. Signed-off-by: David Howells <[EMAIL PROTECTED]> --- fs/nfs/client.c |7 --- fs/nfs/fscache.h | 15 +++ 2 files changed, 19 insertions(+), 3 deletions(-) diff --git a/fs/nfs/client.c b/fs/nfs/client.c

[PATCH 34/37] NFS: Read pages from FS-Cache into an NFS inode

2008-02-20 Thread David Howells
Read pages from an FS-Cache data storage object representing an inode into an NFS inode. Signed-off-by: David Howells <[EMAIL PROTECTED]> --- fs/nfs/fscache.c | 112 ++ fs/nfs/fscache.h | 47 +++ fs/nfs/read.c

[PATCH 18/37] CacheFiles: Permit the page lock state to be monitored

2008-02-20 Thread David Howells
-off-by: David Howells <[EMAIL PROTECTED]> --- include/linux/pagemap.h |5 + mm/filemap.c| 18 ++ 2 files changed, 23 insertions(+), 0 deletions(-) diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h index c8bd762..76b5307 100644 --- a/i

[PATCH 35/37] NFS: Store pages from an NFS inode into a local cache

2008-02-20 Thread David Howells
Store pages from an NFS inode into the cache data storage object associated with that inode. Signed-off-by: David Howells <[EMAIL PROTECTED]> --- fs/nfs/fscache.c | 26 ++ fs/nfs/fscache.h | 16 fs/nfs/read.c|5 + 3 files chang

[PATCH 17/37] CacheFiles: Add a hook to write a single page of data to an inode

2008-02-20 Thread David Howells
. Supply a generic implementation for this that uses the write_begin() and write_end() address_space operations to bind a copy directly into the page cache. Hook the Ext2 and Ext3 operations to the generic implementation. Signed-off-by: David Howells <[EMAIL PROTECTED]> --- fs/ext2/inode.c

[PATCH 31/37] NFS: FS-Cache page management

2008-02-20 Thread David Howells
FS-Cache page management for NFS. This includes hooking the releasing and invalidation of pages marked with PG_fscache (aka PG_private_2) and waiting for completion of the write-to-cache flag (PG_fscache_write aka PG_owner_priv_2). Signed-off-by: David Howells <[EMAIL PROTECTED]> ---

[PATCH 30/37] NFS: Add some new I/O event counters for FS-Cache events

2008-02-20 Thread David Howells
Add some new NFS I/O event counters for FS-Cache events. They have to be added as byte counters because I may need to be able to increase the numbers by more than 1 at a time. Signed-off-by: David Howells <[EMAIL PROTECTED]> --- fs/nfs/iostat.h |7 +++ 1 files changed, 7 inse

[PATCH 32/37] NFS: Add read context retention for FS-Cache to call back with

2008-02-20 Thread David Howells
Add read context retention so that FS-Cache can call back into NFS when a read operation on the cache fails EIO rather than reading data. This permits NFS to then fetch the data from the server instead using the appropriate security context. Signed-off-by: David Howells <[EMAIL PROTEC

[PATCH 15/37] CacheFiles: Add missing copy_page export for ia64

2008-02-20 Thread David Howells
This one-line patch fixes the missing export of copy_page introduced by the cachefile patches. This patch is not yet upstream, but is required for cachefile on ia64. It will be pushed upstream when cachefile goes upstream. Signed-off-by: Prarit Bhargava <[EMAIL PROTECTED]> Signed-off-by:

[PATCH 37/37] NFS: Add mount options to enable local caching on NFS

2008-02-20 Thread David Howells
ng and give a warning into the kernel log. Signed-off-by: David Howells <[EMAIL PROTECTED]> --- fs/nfs/client.c |2 ++ fs/nfs/internal.h |1 + fs/nfs/super.c| 25 + 3 files changed, 28 insertions(+), 0 deletions(-) diff --git a/fs/nfs/client.c

[PATCH 24/37] NFS: Register NFS for caching and retrieve the top-level index

2008-02-20 Thread David Howells
Register NFS for caching and retrieve the top-level cache index object cookie. Signed-off-by: David Howells <[EMAIL PROTECTED]> --- fs/nfs/Makefile|1 + fs/nfs/fscache-index.c | 53 fs/nfs/fscache.h

[PATCH 21/37] NFS: Add comment banners to some NFS functions

2008-02-20 Thread David Howells
Add comment banners to some NFS functions so that they can be modified by the NFS fscache patches for further information. Signed-off-by: David Howells <[EMAIL PROTECTED]> --- fs/nfs/file.c | 26 ++ 1 files changed, 26 insertions(+), 0 deletions(-) diff --gi

[PATCH 19/37] CacheFiles: Export things for CacheFiles

2008-02-20 Thread David Howells
Export a number of functions for CacheFiles's use. Signed-off-by: David Howells <[EMAIL PROTECTED]> --- fs/super.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/fs/super.c b/fs/super.c index 88811f6..1133b43 100644 --- a/fs/super.c +++ b/fs/super.c @@ -2

[PATCH 1/2] FRV: Drop the .data.idt section for FRV

2008-02-20 Thread David Howells
From: David Howells <[EMAIL PROTECTED]> There is no .data.idt section for FRV, so drop it from the linker script. Signed-off-by: David Howells <[EMAIL PROTECTED]> --- arch/frv/kernel/vmlinux.lds.S |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/arc

Re: [QUESTION] FRV: linking error?

2008-02-20 Thread David Howells
Cyrill Gorcunov <[EMAIL PROTECTED]> wrote: > Sam, maybe we should just eliminate this section at least for FRV? You should have a patch in your inbox to do just that. David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Mo

[PATCH 1/2] FRV: Drop the .data.idt section for FRV

2008-02-20 Thread David Howells
From: David Howells <[EMAIL PROTECTED]> There is no .data.idt section for FRV, so drop it from the linker script. Signed-off-by: David Howells <[EMAIL PROTECTED]> --- arch/frv/kernel/vmlinux.lds.S |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/arc

[PATCH 2/2] FRV: Change the timerfd syscalls to be the same as i386

2008-02-20 Thread David Howells
From: David Howells <[EMAIL PROTECTED]> Change the FRV timerfd syscalls to be the same as i386 timerfd syscalls. Signed-off-by: David Howells <[EMAIL PROTECTED]> --- arch/frv/kernel/entry.S |4 +++- include/asm-frv/unistd.h |4 +++- 2 files changed, 6 insertions(+),

[PATCH 2/2] FRV: Change the timerfd syscalls to be the same as i386

2008-02-20 Thread David Howells
From: David Howells <[EMAIL PROTECTED]> Change the FRV timerfd syscalls to be the same as i386 timerfd syscalls. Signed-off-by: David Howells <[EMAIL PROTECTED]> --- arch/frv/kernel/entry.S |4 +++- include/asm-frv/unistd.h |4 +++- 2 files changed, 6 insertions(+),

Re: [PATCH 00/37] Permit filesystem local caching

2008-02-20 Thread David Howells
Serge E. Hallyn <[EMAIL PROTECTED]> wrote: > Seems *really* weird that every time you send this, patch 6 doesn't seem > to reach me in any of my mailboxes... (did get it from the url > you listed) It's the largest of the patches, so that's not entirely surprising. Hence why I included the URL t

[patch 2/3] mn10300: cleanup - drop .data.idt section in vmlinux.lds script

2008-02-21 Thread David Howells
The section .data.idt is not used at all - so drop it. Signed-off-by: Cyrill Gorcunov <[EMAIL PROTECTED]> Acked-by: Sam Ravnborg <[EMAIL PROTECTED]> Acked-by: David Howells <[EMAIL PROTECTED]> --- vmlinux.lds.S |3 --- 1 file changed, 3 deletions(-) Index: linux-2.

Re: [PATCH 00/37] Permit filesystem local caching

2008-02-21 Thread David Howells
Daniel Phillips <[EMAIL PROTECTED]> wrote: > > These patches add local caching for network filesystems such as NFS. > > Have you got before/after benchmark results? I need to get a new hard drive for my test machine before I can go and get some more up to date benchmark results. It does seem, h

Re: [PATCH 00/37] Permit filesystem local caching

2008-02-21 Thread David Howells
Daniel Phillips <[EMAIL PROTECTED]> wrote: > Have you got before/after benchmark results? See attached. These show a couple of things: (1) Dealing with lots of metadata slows things down a lot. Note the result of looking and reading lots of small files with tar (the last result). The

[PATCH] Make the kernel NTP code hand 64-bit *unsigned* values to do_div()

2008-02-21 Thread David Howells
From: David Howells <[EMAIL PROTECTED]> The kernel NTP code shouldn't hand 64-bit *signed* values to do_div(). Make it instead hand 64-bit unsigned values. This gets rid of a couple of warnings. Signed-off-by: David Howells <[EMAIL PROTECTED]> --- kernel/time/ntp.c |8

[PATCH] NOMMU: is_vmalloc_addr() won't compile if !MMU

2008-02-21 Thread David Howells
From: David Howells <[EMAIL PROTECTED]> Make is_vmalloc_addr() contingent on CONFIG_MMU=y, as it won't compile in !MMU mode (commit 9e2779fa281cfda13ac060753d674bbcaa23367e). Signed-off-by: David Howells <[EMAIL PROTECTED]> --- include/linux/mm.h |2 ++ 1 files changed, 2

[PATCH] MM: Fix macro argument substitution in PageHead() and PageTail()

2008-02-21 Thread David Howells
From: David Howells <[EMAIL PROTECTED]> Fix macro argument substitution in PageHead() and PageTail() - 'page' should have brackets surrounding it (commit 6d7779538f765963ced45a3fa4bed7ba8d2c277d). Signed-off-by: David Howells <[EMAIL PROTECTED]> --- include/linux/page-

[PATCH] Make the kernel NTP code hand 64-bit *unsigned* values to do_div() [try #2]

2008-02-21 Thread David Howells
From: David Howells <[EMAIL PROTECTED]> The kernel NTP code shouldn't hand 64-bit *signed* values to do_div(). Make it instead hand 64-bit unsigned values. This gets rid of a couple of warnings. Signed-off-by: David Howells <[EMAIL PROTECTED]> --- kernel/time/ntp.c |8

[PATCH] Make the kernel NTP code hand 64-bit *unsigned* values to do_div() [try #3]

2008-02-21 Thread David Howells
From: David Howells <[EMAIL PROTECTED]> The kernel NTP code shouldn't hand 64-bit *signed* values to do_div(). Make it instead hand 64-bit unsigned values. This gets rid of a couple of warnings. Signed-off-by: David Howells <[EMAIL PROTECTED]> --- kernel/time/ntp.c | 1

Re: [PATCH] Make the kernel NTP code hand 64-bit *unsigned* values to do_div() [try #2]

2008-02-21 Thread David Howells
David Howells <[EMAIL PROTECTED]> wrote: > Subject: [PATCH] Make the kernel NTP code hand 64-bit *unsigned* values to > do_div() [try #2] Ignore try #2. I forgot to commit the changes before mailing. David -- To unsubscribe from this list: send the line "unsubscribe lin

Re: [PATCH] Make the kernel NTP code hand 64-bit *unsigned* values to do_div()

2008-02-21 Thread David Howells
Andreas Schwab <[EMAIL PROTECTED]> wrote: > do_div previously modified temp64 by side effect, now it no longer does > that. Good point. David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vg

Re: [PATCH 00/37] Permit filesystem local caching

2008-02-21 Thread David Howells
Daniel Phillips <[EMAIL PROTECTED]> wrote: > When you say Ext3 cache vs NFS cache is the first on the server and the > second on the client? The filesystem on the server is pretty much irrelevant as long as (a) it doesn't change, and (b) all the data is in memory on the server anyway. The way t

Re: [PATCH 00/37] Permit filesystem local caching

2008-02-22 Thread David Howells
Daniel Phillips <[EMAIL PROTECTED]> wrote: > > The way the client works is like this: > > Thanks for the excellent ascii art, that cleared up the confusion right > away. You know what they say about pictures... :-) > > What are you trying to do exactly? Are you actually playing with it, or > >

Re: [PATCH 14/14] workqueue: use mod_delayed_work() instead of cancel + queue

2012-08-13 Thread David Howells
y could be calling it > from irq context and if that happens while delayed_work_timer_fn() > is running, it could deadlock. __cancel_delayed_work() users are > dropped. > > Signed-off-by: Tejun Heo > Acked-by: Henrique de Moraes Holschuh > Acked-by: Dmitry

Re: [PATCH] MIPS: fix module.c build for 32 bit

2012-08-13 Thread David Howells
Hi Rusty, I've fixed up my patch for ARM and pulled Jonas's patch on top of that. Do you want me to merge them together? David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.ker

Re: [PATCH] MIPS: fix module.c build for 32 bit

2012-08-14 Thread David Howells
Rusty Russell wrote: > Yep, thanks. And might as well sent them straight to Linus; since > linux-next didn't catch this, there's little point baking them there if > we have some acks. > > If he misses it, I'll grab them. It might have to wait for the next merge window. David -- To unsubscribe

<    1   2   3   4   5   6   7   8   9   10   >