[PATCH] UAPI: Remove empty Kbuild files

2013-03-26 Thread David Howells
Remove empty Kbuild files as they cause problems with the patch program which removes files that become empty. Should I also remove include/Kbuild as that now does nothing? Or should it be left as an anchor just in case we want it in future? Signed-off-by: David Howells --- include/Kbuild

memory barriers in flock (Re: [PATCH v3] locks: close potential race between setlease and open)

2013-08-15 Thread David Howells
Bruce Fields wrote: (Adding Paul McKenney who's good at this stuff) > > v2: > > - fix potential double-free of lease if second check finds conflict > > - add smp_mb's to ensure that other CPUs see i_flock changes > > > > v3: > > - remove smp_mb calls. Partial ordering is unlikely to help here.

Re: [Ksummit-2013-discuss] [ATTEND] How to act on LKML (was: [ 00/19] 3.10.1-stable review)

2013-07-16 Thread David Howells
Linus Torvalds wrote: > A small panel discussion with a few people (fiveish?) that have very > different viewpoints, along with baskets of rotten fruit set out on > the tables? That could be fun. And I'm serious, although we might want > to limit the size of the fruit to smaller berries ;) I thi

[RFC][PATCH 00/10] Associative array & Massive expansion of keyring capacity

2013-07-17 Thread David Howells
objects amongst other things. The keyutils testsuite has been run successfully against a kernel with these patches applied, though the testsuite did need some tweaks: (a) previously keys added to a keyring with no removals appeared to be ordered and (b) some of the errors have changed. David --

[PATCH 09/10] KEYS: Drop the permissions argument from __keyring_search_one()

2013-07-17 Thread David Howells
Drop the permissions argument from __keyring_search_one() as the only caller passes 0 here - which causes all checks to be skipped. Signed-off-by: David Howells --- security/keys/internal.h |3 +-- security/keys/key.c |2 +- security/keys/keyring.c |9 +++-- 3 files

[PATCH 04/10] KEYS: key_is_dead() should take a const key pointer argument

2013-07-17 Thread David Howells
key_is_dead() should take a const key pointer argument as it doesn't modify what it points to. Signed-off-by: David Howells --- security/keys/internal.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/security/keys/internal.h b/security/keys/internal.h index df

[PATCH 08/10] KEYS: Define a __key_get() wrapper to use rather than atomic_inc()

2013-07-17 Thread David Howells
Define a __key_get() wrapper to use rather than atomic_inc() on the key usage count as this makes it easier to hook in refcount error debugging. Signed-off-by: David Howells --- Documentation/security/keys.txt | 13 - include/linux/key.h | 10 +++--- security

[PATCH 06/10] KEYS: Introduce a search context structure

2013-07-17 Thread David Howells
match function is separated from the description pointer in the search context. This makes it clear which is being supplied. Signed-off-by: David Howells --- include/linux/key-type.h |5 ++ security/keys/internal.h | 40 - security/keys/keyring.c |

[PATCH 07/10] KEYS: Search for auth-key by name rather than targt key ID

2013-07-17 Thread David Howells
Search for auth-key by name rather than by target key ID as, in a future patch, we'll by searching directly by index key in preference to iteration over all keys. Signed-off-by: David Howells --- security/keys/request_key_auth.c | 21 +++-- 1 file changed, 7 insertions(+

[PATCH 05/10] KEYS: Consolidate the concept of an 'index key' for key access

2013-07-17 Thread David Howells
ray rather than just a pointer block. Signed-off-by: David Howells --- include/linux/key.h | 21 ++--- security/keys/internal.h|8 ++--- security/keys/key.c | 72 ++- security/keys/keyring.c

[PATCH 03/10] KEYS: Use bool in make_key_ref() and is_key_possessed()

2013-07-17 Thread David Howells
Make make_key_ref() take a bool possession parameter and make is_key_possessed() return a bool. Signed-off-by: David Howells --- Documentation/security/keys.txt |7 +++ include/linux/key.h |4 ++-- security/keys/keyring.c |5 +++-- 3 files changed, 8

[PATCH 01/10] KEYS: Skip key state checks when checking for possession

2013-07-17 Thread David Howells
es to revoked and expired keys being given EACCES instead of EKEYREVOKED or EKEYEXPIRED. Signed-off-by: David Howells --- security/keys/internal.h |1 + security/keys/process_keys.c |8 +--- security/keys/request_key.c |6 -- security/keys/request_key_auth.c |

Re: [PATCH 02/10] Add a generic associative array implementation.

2013-07-17 Thread David Howells
Joe Perches wrote: > bool type makes me queasy. :-) I've no particular objection to naming it something else - but what? 'Mark' maybe? David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH 0/8] include/net: next set of extern removals

2013-08-01 Thread David Howells
Joe Perches wrote: > Standardize on no extern use on function prototypes Ugh. Can we please standardise on _having_ externs on function prototypes? David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majord

Re: [PATCH] checkpatch: Warn when using extern with function prototypes in .h files

2013-08-01 Thread David Howells
Joe Perches wrote: > Using the extern keyword on function prototypes is superfluous > visual noise so suggest removing it. > > Using extern can cause unnecessary line wrapping at 80 columns > and unnecessarily long multi-line function prototypes. > > Suggested-by: Hannes Frederic Sowa > Signed

[PATCH 1/2] KEYS: Implement a big key type that can save to tmpfs

2013-08-01 Thread David Howells
Implement a big key type that can save its contents to tmpfs and thus swapspace when memory is tight. This is useful for Kerberos ticket caches. Signed-off-by: David Howells --- include/keys/big_key-type.h | 27 ++ include/linux/key.h |1 security/keys/Kconfig | 11

[PATCH 2/2] KEYS: Add per-user_namespace registers for persistent per-UID kerberos caches

2013-08-01 Thread David Howells
e cache keyrings are added to it. This means that standard key search and garbage collection facilities are available. The user_namespace struct's register goes away when it does and anything left in it is then automatically gc'd. Signed-off-by: David Howells cc: Serge E. Hallyn cc:

[RFC][PATCH 0/2] KEYS: Kerberos caching support

2013-08-01 Thread David Howells
r_namespace's register goes away when it does. Note that these patches were constructed on top of my keyring capacity expansion patches - but there shouldn't be much to change to apply them on top of the vanilla kernel. David --- David Howells (2): KEYS: Implement a big key type th

Re: [PATCH 2/2] KEYS: Add per-user_namespace registers for persistent per-UID kerberos caches

2013-08-02 Thread David Howells
Jeff Layton wrote: > > + /* -1 indicates the current user */ > > + if (_uid == (uid_t)-1) { > > + uid = current_uid(); > > Isn't it possible to have a valid uid of (unsigned int)-1? I know that > at least some sites use that for "nobody". Why not just require passing > in the correc

Re: [PATCH 2/2] KEYS: Add per-user_namespace registers for persistent per-UID kerberos caches

2013-08-02 Thread David Howells
Eric W. Biederman wrote: > > Add support for per-user_namespace registers of persistent per-UID kerberos > > caches held within the kernel. > > Out of curiosity is this cache per user namspace because the key lookup > is per user namespace? Yes. You can't see keys in another namespace. I occa

Re: [PATCH 2/2] KEYS: Add per-user_namespace registers for persistent per-UID kerberos caches

2013-08-02 Thread David Howells
Simo Sorce wrote: > > Simo: I believe the problem you have with the user keyring is that it's not > > persistent beyond the life of the processes of that UID, right? > > Correct. In which case, pinning the user keyring in this fashion should make this work without the need to add another keyct

Re: [PATCH 2/2] KEYS: Add per-user_namespace registers for persistent per-UID kerberos caches

2013-08-02 Thread David Howells
Eric W. Biederman wrote: > > The cache returned is a keyring named "_krb." that the possessor can > > read, search, clear, invalidate, unlink from and add links to. SELinux > > and co. get a say as to whether this call will succeed as the caller must > > have LINK permission on the cache keyring

Re: [PATCH 2/2] KEYS: Add per-user_namespace registers for persistent per-UID kerberos caches

2013-08-02 Thread David Howells
Daniel Kahn Gillmor wrote: > > The uid is -1 or the user's own UID for the user's own cache or the uid of > > some other user's cache (requires CAP_SETUID). This permits rpc.gssd or > > whatever to mess with the cache. > > Is the goal here eventually to be able to avoid the upcall to rpc.gssd >

Re: [PATCH 2/2] KEYS: Add per-user_namespace registers for persistent per-UID kerberos caches

2013-08-02 Thread David Howells
Daniel Kahn Gillmor wrote: > I guess this raises the question from a different perspective: if the > kernel already supports arbitrary shm segments, filesystem locations, > etc, which can be used for storing/passing opaque bytestrings between > different parts of userspace, what advantages do we

Re: [PATCH 1/2] KEYS: Implement a big key type that can save to tmpfs

2013-08-08 Thread David Howells
Nico Williams wrote: > b) how to create tmpfs locations in which to store credentials (which > can be unbounded in size, so storing them in the kernel is silly; Ummm... tmpfs stores them in the kernel too - though it can page them out to swap. I have altered my big-key implementation to just s

[PATCH] Assoc_array: Drop leaf-type concept

2013-07-18 Thread David Howells
Hi Joe, George, How about the attached changes? I've dropped support for multiple leaf types in the assoc_array API (leaving that to the caller). The array still uses bit 0 of the object pointer to mark an internal metadata pointer if set (and then uses bit 1 to specify the subtype internally).

Re: [PATCH] Assoc_array: Drop leaf-type concept

2013-07-19 Thread David Howells
George Spelvin wrote: > Looks cleaner. Thanks! > The larger issues that bother me: > > 1) The fact that the abstract daya type "index key" provides access to >a byte string "index key" is a bit confusing. I'd describe it as >follows: (Based on my current understanding.) > > >Ea

[PATCH] Fix __wait_on_atomic_t() to call the action func if the counter != 0

2013-07-23 Thread David Howells
clean up after a netfs cookie is withdrawn. Reported-by: Yacine Belkadi Signed-off-by: David Howells cc: Yacine Belkadi cc: Milosz Tanski cc: Jeff Layton --- kernel/wait.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/kernel/wait.c b/kernel/wait.c index ce0daa3

Re: [PATCH] Fix __wait_on_atomic_t() to call the action func if the counter != 0

2013-07-23 Thread David Howells
Jeff Layton wrote: > > @@ -333,7 +333,8 @@ int __wait_on_atomic_t(wait_queue_head_t *wq, struct > > wait_bit_queue *q, > > prepare_to_wait(wq, &q->wait, mode); > > val = q->key.flags; > > if (atomic_read(val) == 0) > > - ret = (*action)(val);

UAPI: The end is nigh!

2013-03-03 Thread David Howells
tion 2012-12-20 -------- David Howells (1): UAPI: (Scripted) Disintegrate include/video include/uapi/video/Kbuild| 3 + include/uapi/video/edid.h| 9 ++ include/uapi/video/sisfb.h | 209 +++ include/uapi/

Re: [PATCH 12/14] MAINTAINERS: adjust for UAPI (part 2)

2013-03-04 Thread David Howells
Cesar Eduardo Barros wrote: > F: include/linux/*aio*.h > +F: include/uapi/linux/*aio*.h I wonder if we can infer things like this in the scripts rather than needing to make it explicit. David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a messag

[PATCH 1/8] Add wait_on_atomic_t() and wake_up_atomic_t() [ver #2]

2013-05-10 Thread David Howells
eed on a per-cookie basis, but sometimes I have a huge flood of the cookies to deal with. I also don't want to add a whole new set of global waitqueue tables specifically for the dec-to-0 event if I can reuse the bit tables. Signed-off-by: David Howells --- include/linux/wait.h | 2

[PATCH 2/8] fs/fscache: remove spin_lock() from the condition in while() [ver #2]

2013-05-10 Thread David Howells
double condition. Signed-off-by: Sebastian Andrzej Siewior Signed-off-by: David Howells --- fs/fscache/page.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/fs/fscache/page.c b/fs/fscache/page.c index ff000e5..4882c80 100644 --- a/fs/fscache/page.c +++ b/fs

[PATCH 4/8] FS-Cache: Don't sleep in page release if __GFP_FS is not set [ver #2]

2013-05-10 Thread David Howells
ave to do this. However, we really need to know how strapped the allocator is before deciding to do that. Signed-off-by: David Howells --- fs/fscache/page.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/fscache/page.c b/fs/fscache/page.c index 4882c80..42f8f2d 1006

[PATCH 5/8] FS-Cache: Uninline fscache_object_init() [ver #2]

2013-05-10 Thread David Howells
Uninline fscache_object_init() so as not to expose some of the FS-Cache internals to the cache backend. Signed-off-by: David Howells --- fs/fscache/object.c | 40 ++-- include/linux/fscache-cache.h | 38 ++ 2

[PATCH 6/8] FS-Cache: Wrap checks on object state [ver #2]

2013-05-10 Thread David Howells
Wrap checks on object state (mostly outside of fs/fscache/object.c) with inline functions so that the mechanism can be replaced. Some of the state checks within object.c are left as-is as they will be replaced. Signed-off-by: David Howells --- fs/cachefiles/namei.c |4 ++-- fs

[PATCH 8/8] FS-Cache: Simplify cookie retention for fscache_objects, fixing access problems [ver #2]

2013-05-10 Thread David Howells
6/0xa0 [] child_rip+0xa/0x20 [] ? kthread+0x0/0xa0 [] ? child_rip+0x0/0x20 The parameter to fscache_invalidate_writes() was object->cookie which is NULL. Signed-off-by: David Howells --- fs/cachefiles/interface.c | 11 ++ fs/cachefiles/xattr.c |6 - fs/fscache/cookie.c

[PATCH 0/8] Fix assorted FS-Cache issues [ver #2]

2013-05-10 Thread David Howells
e (cleanup). (7) Simplify the object state machine (need #5 and #6). (8) Simplify cookie retention by objects (oops fix, need #1 and #7). David --- David Howells (6): Add wait_on_atomic_t() and wake_up_atomic_t() FS-Cache: Don't sleep in page release if __GFP_FS is not set

[PATCH 3/8] CacheFiles: name i_mutex lock class explicitly [ver #2]

2013-05-10 Thread David Howells
From: J. Bruce Fields Just some cleanup. (And note the caller of this function may, for example, call vfs_unlink on a child, so the "1" (I_MUTEX_PARENT) really was what was intended here.) Signed-off-by: J. Bruce Fields Signed-off-by: David Howells --- fs/cachefiles/namei.c |

Re: [PATCH 1/8] Add wait_on_atomic_t() and wake_up_atomic_t() [ver #2]

2013-05-10 Thread David Howells
Fengguang's kbuild bot found a compile error on one arch with this patch, so I've pushed a new version to the git tree. David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel

Re: [PATCH v6, part3 14/16] mm: concentrate modification of totalram_pages into the mm core

2013-05-13 Thread David Howells
t; free_bootmem_late(), free_all_bootmem(), free_all_bootmem_node(), > adjust_managed_page_count(). > > With this patch applied, it will be much more easier for us to keep > totalram_pages and zone->managed_pages in consistence. I like it. Acked-by: David Howells -- To unsubscribe from this lis

Re: [PATCH v6, part3 16/16] AVR32: fix building warnings caused by redifinitions of HZ

2013-05-13 Thread David Howells
Jiang Liu wrote: > -#ifndef HZ > +#ifndef __KERNEL__ > + /* > +* Technically, this is wrong, but some old apps still refer to it. > +* The proper way to get the HZ value is via sysconf(_SC_CLK_TCK). > +*/ > # define HZ 100 > #endif Better still, use asm-generic/param.h a

Re: [PATCH v6, part3 02/16] mm: enhance free_reserved_area() to support poisoning memory with zero

2013-05-13 Thread David Howells
Jiang Liu wrote: > + free_reserved_area((void *)start, (void *)end, -1, "initrd"); Do you mean -1 or ULONG_MAX? David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.o

Re: [PATCH v6, part3 02/16] mm: enhance free_reserved_area() to support poisoning memory with zero

2013-05-13 Thread David Howells
David Howells wrote: > Jiang Liu wrote: > > > + free_reserved_area((void *)start, (void *)end, -1, "initrd"); > > Do you mean -1 or ULONG_MAX? No matter... It's a poison value, not an address. David -- To unsubscribe from this list: send the line "un

Re: [PATCH] cachefiles: remove unused macro list_to_page()

2013-05-16 Thread David Howells
Haicheng Li wrote: > Signed-off-by: Haicheng Li Applied, thanks. David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at htt

Re: [PATCH v2] MODSIGN: do not send garbage to stderr when enabling modules signature

2013-04-10 Thread David Howells
Signed-off-by: David Cohen > Reviewed-by: mark gross > Signed-off-by: Rusty Russell Acked-by: David Howells -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] wait: fix false timeouts when using wait_event_timeout()

2013-05-02 Thread David Howells
Imre Deak wrote: > Many callers of the wait_event_timeout() and > wait_event_interruptible_timeout() expect that the return value will be > positive if the specified condition becomes true before the timeout > elapses. However, at the moment this isn't guaranteed. If the wake-up > handler is dela

Re: [PATCH] wait: fix false timeouts when using wait_event_timeout()

2013-05-02 Thread David Howells
Jens Axboe wrote: > IMHO, the change definitely makes sense. Yeah... I think I agree. David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please

Re: [PATCH] wait: fix false timeouts when using wait_event_timeout()

2013-05-02 Thread David Howells
> semantic is in line with what wait_for_condition_timeout() does; see > commit bb10ed09 - "sched: fix wait_for_completion_timeout() spurious > failure under heavy load". > > Signed-off-by: Imre Deak Acked-by: David Howells -- To unsubscribe from this list: send the line &quo

[PATCH 0/8] Fix assorted FS-Cache issues

2013-05-02 Thread David Howells
nup). (5) Wrap checks on object state (cleanup). (6) Provide a system wait_on_atomic_t() and wake_up_atomic_t() (enhancement). (7) Simplify the object state machine (need #4 and #5). (8) Simplify cookie retention by objects (oops fix, need #6 and #7). David --- David Howells (6): FS-Ca

[PATCH 1/8] fs/fscache: remove spin_lock() from the condition in while()

2013-05-02 Thread David Howells
double condition. Signed-off-by: Sebastian Andrzej Siewior Signed-off-by: David Howells --- fs/fscache/page.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/fs/fscache/page.c b/fs/fscache/page.c index ff000e5..4882c80 100644 --- a/fs/fscache/page.c +++ b/fs

[PATCH 2/8] CacheFiles: name i_mutex lock class explicitly

2013-05-02 Thread David Howells
From: J. Bruce Fields Just some cleanup. (And note the caller of this function may, for example, call vfs_unlink on a child, so the "1" (I_MUTEX_PARENT) really was what was intended here.) Signed-off-by: J. Bruce Fields Signed-off-by: David Howells --- fs/cachefiles/namei.c |

[PATCH 4/8] FS-Cache: Uninline fscache_object_init()

2013-05-02 Thread David Howells
Uninline fscache_object_init() so as not to expose some of the FS-Cache internals to the cache backend. Signed-off-by: David Howells --- fs/fscache/object.c | 40 ++-- include/linux/fscache-cache.h | 38 ++ 2

[PATCH 5/8] FS-Cache: Wrap checks on object state

2013-05-02 Thread David Howells
Wrap checks on object state (mostly outside of fs/fscache/object.c) with inline functions so that the mechanism can be replaced. Some of the state checks within object.c are left as-is as they will be replaced. Signed-off-by: David Howells --- fs/cachefiles/namei.c |4 ++-- fs

[PATCH 6/8] Add wait_on_atomic_t() and wake_up_atomic_t()

2013-05-02 Thread David Howells
Add wait_on_atomic_t() and wake_up_atomic_t() to indicate became-zero events on atomic_t types. This uses the bit-wake waitqueue table. Signed-off-by: David Howells --- include/linux/wait.h | 29 - kernel/wait.c| 85

[PATCH 8/8] FS-Cache: Simplify cookie retention for fscache_objects, fixing access problems

2013-05-02 Thread David Howells
6/0xa0 [] child_rip+0xa/0x20 [] ? kthread+0x0/0xa0 [] ? child_rip+0x0/0x20 The parameter to fscache_invalidate_writes() was object->cookie which is NULL. Signed-off-by: David Howells --- fs/cachefiles/interface.c | 11 ++ fs/cachefiles/xattr.c |6 - fs/fscache/cookie.c

[PATCH 3/8] FS-Cache: Don't sleep in page release if __GFP_FS is not set

2013-05-02 Thread David Howells
ave to do this. However, we really need to know how strapped the allocator is before deciding to do that. Signed-off-by: David Howells --- fs/fscache/page.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/fscache/page.c b/fs/fscache/page.c index 4882c80..42f8f2d 1006

[PATCH] Give the OID registry file module info to avoid kernel tainting

2013-05-03 Thread David Howells
Give the OID registry file module information so that it doesn't taint the kernel when compiled as a module and loaded. Reported-by: Dros Adamson Signed-off-by: David Howells cc: Trond Myklebust cc: sta...@vger.kernel.org cc: linux-...@vger.kernel.org --- lib/oid_registry.c |5 +++

Re: [PATCH] nubus: Kill nubus_proc_detach_device()

2013-05-03 Thread David Howells
vers/nubus/proc.c:156: error: dereferencing pointer to incomplete type > drivers/nubus/proc.c:158: error: dereferencing pointer to incomplete type > > Fortunately nubus_proc_detach_device() is unused, and appears to have never > been used, so just remove it. > > Signed-off-by: Geert Uytte

[PATCH] Give the OID registry file module info to avoid kernel tainting

2013-05-04 Thread David Howells
Give the OID registry file module information so that it doesn't taint the kernel when compiled as a module and loaded. Reported-by: Dros Adamson Signed-off-by: David Howells cc: Trond Myklebust cc: sta...@vger.kernel.org cc: linux-...@vger.kernel.org --- lib/oid_registry.c |5 +++

[PATCH] Give the OID registry file module info to avoid kernel tainting

2013-05-04 Thread David Howells
Give the OID registry file module information so that it doesn't taint the kernel when compiled as a module and loaded. Reported-by: Dros Adamson Signed-off-by: David Howells cc: Trond Myklebust cc: sta...@vger.kernel.org cc: linux-...@vger.kernel.org --- lib/oid_registry.c |5 +++

Re: [PATCH] proc: Use PDE attribute setting accessor functions

2013-05-07 Thread David Howells
: > arch/cris/kernel/profile.c:79:8: error: dereferencing pointer to incomplete > type > > Use proc_set_size(), cfr. commit 271a15eabe094538d958dc68ccfc9c36b699247a > ("proc: Supply PDE attribute setting accessor functions") > > Signed-off-by: Geert Uytterhoeven A

Re: [PATCH] fscache: extended "dying" check before emitting EV_INVALIDATE

2013-04-23 Thread David Howells
Max Kellermann wrote: > + (object->events & > (FSCACHE_OBJECT_EV_RETIRE|FSCACHE_OBJECT_EV_RELEASE)) == 0) You can't do it like this. EV_RETIRE and EV_RELEASE are bit numbers, so need to be shifted into place. David -- To unsubscribe from this list: send the line "unsub

Re: [PATCH] fscache: extended "dying" check before emitting EV_INVALIDATE

2013-04-23 Thread David Howells
Max Kellermann wrote: > Before emitting an FSCACHE_OBJECT_EV_INVALIDATE event, the function > __fscache_invalidate() checks whether the fscache_object is currently > "dying". This checks only the current state, not the queued events > that will very soon lead to the object's death. This should

[PATCH 00/26] Eliminate create_proc_read_entry() [RFC]

2013-04-11 Thread David Howells
nux-fs.git/log/?h=vfs-experimental David --- David Howells (26): procfs: Mark create_proc_read_entry deprecated rtl8192u: Don't use create_proc_read_entry() rtl8187se: Don't use create_proc_read_entry() ft1000: Don't use create_proc_read_entry(

[PATCH 01/26] procfs: Mark create_proc_read_entry deprecated [RFC]

2013-04-11 Thread David Howells
Mark create_proc_read_entry deprecated. proc_create[_data]() should be used instead. Signed-off-by: David Howells --- include/linux/proc_fs.h |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/include/linux/proc_fs.h b/include/linux/proc_fs.h index 2781e49..8175b49

[PATCH 02/26] rtl8192u: Don't use create_proc_read_entry() [RFC]

2013-04-11 Thread David Howells
upon reading? Signed-off-by: David Howells cc: Jerry Chuang cc: Mauro Carvalho Chehab cc: Greg Kroah-Hartman cc: linux-wirel...@vger.kernel.org cc: de...@driverdev.osuosl.org --- drivers/staging/rtl8192u/r8192U_core.c | 215 ++-- 1 file changed, 92 insertions(+),

[PATCH 05/26] comedi: Don't use create_proc_read_entry() [RFC]

2013-04-11 Thread David Howells
Don't use create_proc_read_entry() as that is deprecated, but rather use proc_create_data() and seq_file instead. Signed-off-by: David Howells cc: David Schleef cc: Ian Abbott cc: Mori Hess cc: Greg Kroah-Hartman cc: H Hartley Sweeten cc: de...@driverdev.osuosl.org --- drivers/st

[PATCH 07/26] cxt1e1: Don't use create_proc_read_entry() [RFC]

2013-04-11 Thread David Howells
Don't use create_proc_read_entry() as that is deprecated, but rather use proc_create_data() and seq_file instead. Signed-off-by: David Howells cc: Bob Beers cc: Greg Kroah-Hartman cc: de...@driverdev.osuosl.org --- drivers/staging/cxt1e1/Makefile |3 drivers/staging/cxt1e1/sbep

[PATCH 06/26] csr: Don't use create_proc_read_entry() [RFC]

2013-04-11 Thread David Howells
Don't use create_proc_read_entry() as that is deprecated, but rather use proc_create_data() and seq_file instead. Signed-off-by: David Howells cc: Greg Kroah-Hartman cc: Randy Dunlap cc: Priit Laes cc: de...@driverdev.osuosl.org cc: Mikko Virkkilä cc: Lauri Hintsala cc: Riku Mettäl

[PATCH 09/26] goku_udc: Don't use create_proc_read_entry() [RFC]

2013-04-11 Thread David Howells
Don't use create_proc_read_entry() as that is deprecated, but rather use proc_create_data() and seq_file instead. Signed-off-by: David Howells cc: Felipe Balbi cc: Greg Kroah-Hartman cc: linux-...@vger.kernel.org --- drivers/usb/gadget/goku_udc.c |

[PATCH 10/26] fsl_udc: Don't use create_proc_read_entry() [RFC]

2013-04-11 Thread David Howells
Don't use create_proc_read_entry() as that is deprecated, but rather use proc_create_data() and seq_file instead. Signed-off-by: David Howells cc: Li Yang cc: Felipe Balbi cc: Greg Kroah-Hartman cc: linux-...@vger.kernel.org cc: linuxppc-...@lists.ozlabs.org --- drivers/usb/g

[PATCH 13/26] genrtc: Don't use create_proc_read_entry() [RFC]

2013-04-11 Thread David Howells
Don't use create_proc_read_entry() as that is deprecated, but rather use proc_create_data() and seq_file instead. Signed-off-by: David Howells cc: Arnd Bergmann cc: Greg Kroah-Hartman --- drivers/char/genrtc.c | 48 +++- 1 file change

[PATCH 14/26] efirtc: Don't use create_proc_read_entry() [RFC]

2013-04-11 Thread David Howells
Don't use create_proc_read_entry() as that is deprecated, but rather use proc_create_data() and seq_file instead. Signed-off-by: David Howells cc: Arnd Bergmann cc: Greg Kroah-Hartman --- drivers/char/efirtc.c | 83 - 1 file change

[PATCH 12/26] hp_sdc_rtc: Don't use create_proc_read_entry() [RFC]

2013-04-11 Thread David Howells
Don't use create_proc_read_entry() as that is deprecated, but rather use proc_create_data() and seq_file instead. Signed-off-by: David Howells cc: Brian S. Julin cc: Helge Deller cc: linux-m...@lists.linux-m68k.org --- drivers/input/misc/hp_sdc_rtc.c |

[PATCH 16/26] atmel: Don't use create_proc_read_entry() [RFC]

2013-04-11 Thread David Howells
Don't use create_proc_read_entry() as that is deprecated, but rather use proc_create_data() and seq_file instead. Signed-off-by: David Howells cc: Simon Kelley cc: John W. Linville cc: linux-wirel...@vger.kernel.org cc: net...@vger.kernel.org --- drivers/net/wireless/atmel.c |

[PATCH 21/26] mips: Don't use create_proc_read_entry() [RFC]

2013-04-11 Thread David Howells
Don't use create_proc_read_entry() as that is deprecated, but rather use proc_create_data() and seq_file instead. Signed-off-by: David Howells cc: Ralf Baechle cc: linux-m...@linux-mips.org --- arch/mips/kernel/smtc-proc.c | 64 +- arch/mips/pci/ops-pmc

[PATCH 23/26] h8300: Don't use create_proc_read_entry() [RFC]

2013-04-11 Thread David Howells
Don't use create_proc_read_entry() as that is deprecated, but rather use proc_create_data() and seq_file instead. Signed-off-by: David Howells cc: Yoshinori Sato --- arch/h8300/kernel/gpio.c | 34 -- 1 file changed, 20 insertions(+), 14 deletions(-)

[PATCH 24/26] cris: Don't use create_proc_read_entry() [RFC]

2013-04-11 Thread David Howells
Don't use create_proc_read_entry() as that is deprecated, but rather use proc_create_data() and seq_file instead. Signed-off-by: David Howells cc: Mikael Starvik cc: Jesper Nilsson cc: linux-cris-ker...@axis.com --- arch/cris/arch-v10/kernel/fasttimer.c |

[PATCH 26/26] proc: Delete create_proc_read_entry() [RFC]

2013-04-11 Thread David Howells
Delete create_proc_read_entry() as it no longer has any users. Also delete read_proc_t, write_proc_t, the read_proc member of the proc_dir_entry struct and the support functions that use them. This saves a pointer for every PDE allocated. Signed-off-by: David Howells --- fs/proc/generic.c

[PATCH 25/26] arm: Don't use create_proc_read_entry() [RFC]

2013-04-11 Thread David Howells
Don't use create_proc_read_entry() as that is deprecated, but rather use proc_create_data() and seq_file instead. Signed-off-by: David Howells cc: Russell King cc: Kevin Hilman cc: Tony Lindgren cc: linux-arm-ker...@lists.infradead.org cc: linux-o...@vger.kernel.org --- arch/arm/k

[PATCH 11/26] nubus: Don't use create_proc_read_entry() [RFC]

2013-04-11 Thread David Howells
Don't use create_proc_read_entry() as that is deprecated, but rather use proc_create_data() and seq_file instead. Signed-off-by: David Howells cc: linux-m...@lists.linux-m68k.org --- drivers/nubus/nubus.c | 55 - drivers/nubus/proc.c |

[PATCH 15/26] ds1620: Don't use create_proc_read_entry() [RFC]

2013-04-11 Thread David Howells
Don't use create_proc_read_entry() as that is deprecated, but rather use proc_create_data() and seq_file instead. Signed-off-by: David Howells cc: Arnd Bergmann cc: Greg Kroah-Hartman --- drivers/char/ds1620.c | 33 +++-- 1 file changed, 19 insertions(+

[PATCH 20/26] parisc: Don't use create_proc_read_entry() [RFC]

2013-04-11 Thread David Howells
Don't use create_proc_read_entry() as that is deprecated, but rather use proc_create_data() and seq_file instead. Signed-off-by: David Howells cc: "James E.J. Bottomley" cc: Helge Deller cc: linux-par...@vger.kernel.org --- arch/parisc/kernel/pdc_c

[PATCH 22/26] ia64: Don't use create_proc_read_entry() [RFC]

2013-04-11 Thread David Howells
Don't use create_proc_read_entry() as that is deprecated, but rather use proc_create_data() and seq_file instead. Signed-off-by: David Howells cc: Tony Luck cc: Fenghua Yu cc: linux-i...@vger.kernel.org --- arch/ia64/kernel/palinfo.c | 502 +++

[PATCH 08/26] wlags49_h2: Don't use create_proc_read_entry() [RFC]

2013-04-11 Thread David Howells
Don't use create_proc_read_entry() as that is deprecated, but rather use proc_create_data() and seq_file instead. Signed-off-by: David Howells cc: Henk de Groot cc: Bartlomiej Zolnierkiewicz cc: Greg Kroah-Hartman cc: linux-wirel...@vger.kernel.org --- drivers/staging/wlags49_h2/wl_m

[PATCH 03/26] rtl8187se: Don't use create_proc_read_entry() [RFC]

2013-04-11 Thread David Howells
ng? If so, locking will be required. Signed-off-by: David Howells cc: Greg Kroah-Hartman cc: Maxim Mikityanskiy cc: YAMANE Toshiaki cc: Bill Pemberton cc: Andrea Merello cc: linux-wirel...@vger.kernel.org cc: de...@driverdev.osuosl.org --- drivers/staging/rtl8187se/r8180_cor

[PATCH 04/26] ft1000: Don't use create_proc_read_entry() [RFC]

2013-04-11 Thread David Howells
Don't use create_proc_read_entry() as that is deprecated, but rather use proc_create_data() and seq_file instead. Signed-off-by: David Howells cc: Marek Belisko cc: Greg Kroah-Hartman cc: Ondrej Zary cc: de...@driverdev.osuosl.org --- drivers/staging/ft1000/ft1000-pcmcia/ft1000_p

[PATCH 18/26] megaraid: Don't use create_proc_read_entry() [RFC]

2013-04-11 Thread David Howells
Don't use create_proc_read_entry() as that is deprecated, but rather use proc_create_data() and seq_file instead. Signed-off-by: David Howells cc: Neela Syam Kolli cc: James E.J. Bottomley cc: linux-s...@vger.kernel.org --- drivers/scsi/megaraid.c |

[PATCH 19/26] sh: Don't use create_proc_read_entry() [RFC]

2013-04-11 Thread David Howells
Don't use create_proc_read_entry() as that is deprecated, but rather use proc_create_data() and seq_file instead. Signed-off-by: David Howells cc: Paul Mundt cc: linux...@vger.kernel.org --- arch/sh/drivers/dma/dma-api.c | 28 +++- 1 file changed, 19 insertions(

Re: [PATCH 05/26] comedi: Don't use create_proc_read_entry() [RFC]

2013-04-11 Thread David Howells
Ian Abbott wrote: > > Don't use create_proc_read_entry() as that is deprecated, but rather use > > proc_create_data() and seq_file instead. > > It seems to work okay and is simpler than I thought it would be! You changed > the mode of the file to 0644 for some reason though. Please change it b

Re: [PATCH 25/26] arm: Don't use create_proc_read_entry() [RFC]

2013-04-11 Thread David Howells
Tony Lindgren wrote: > Looks like the mach-omap1/pm.c part we can make into > a debugfs entry as it only contains PM debug data. But > that we can do after this patch. If you have a patch to do that, I can substitute it for this one. David -- To unsubscribe from this list: send the line "unsubs

Re: [PATCH 00/26] Eliminate create_proc_read_entry() [RFC]

2013-04-11 Thread David Howells
Greg KH wrote: > The ones I've been cc:ed on, with the exception of the hostap patch, I > will be glad to take though my trees now, unless you want to take them > yourself? If Al is happy with it, he might want to take it through his tree since it's sat on top of his experimental branch - especi

[PATCH 02/28] Include missing linux/magic.h inclusions [RFC]

2013-04-16 Thread David Howells
Include missing linux/magic.h inclusions where the source file is currently expecting to get magic numbers through linux/proc_fs.h. Signed-off-by: David Howells cc: linux-...@vger.kernel.org --- drivers/firmware/efivars.c |1 + fs/proc/inode.c|1 + 2 files changed, 2

[PATCH 01/28] Include missing linux/slab.h inclusions [RFC]

2013-04-16 Thread David Howells
Include missing linux/slab.h inclusions where the source file is currently expecting to get kmalloc() and co. through linux/proc_fs.h. Signed-off-by: David Howells cc: linux-s...@vger.kernel.org cc: sparcli...@vger.kernel.org cc: linux-...@vger.kernel.org cc: linux-...@lists.infradead.org cc: de

[PATCH 05/28] proc: Uninline pid_delete_dentry() [RFC]

2013-04-16 Thread David Howells
Uninline pid_delete_dentry() as it's only used by three function pointers. Signed-off-by: David Howells --- fs/proc/base.c |9 + fs/proc/internal.h | 14 +- 2 files changed, 14 insertions(+), 9 deletions(-) diff --git a/fs/proc/base.c b/fs/proc/base.c

Re: [PATCH] virtio_pci: fix macro exported in uapi

2013-05-17 Thread David Howells
Rusty Russell wrote: > Macro still isn't usable, because userspace can't know whether it's the > new or old. > > We need to either remove it from UAPI, or rename it to > VIRTIO_PCI_CONFIG_OFF. Surely, if userspace is using it as is, you can't remove it, rename it or alter it? David -- To unsub

Re: [PATCH] virtio_pci: fix macro exported in uapi

2013-05-20 Thread David Howells
Rusty Russell wrote: > The point of the patch is that it's unusable: > > #define VIRTIO_PCI_CONFIG(dev)((dev)->msix_enabled ? 24 : 20) > > ie. it's accessing a member of the kernel's virtio_pci_dev structure. Ah, okay. In that case, zap it and see if anyone complains. David -

Re: [PATCH] lib/mpi/mpicoder.c: looping issue, need stop when equal to zero, found by 'EXTRA_FLAGS=-W'.

2013-05-20 Thread David Howells
ison of unsigned expression >= 0 is > always true [-Wtype-limits] Acked-by: David Howells -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Is spin_is_locked() safe to use with BUG_ON()/WARN_ON()?

2013-05-23 Thread David Howells
We are using spin_is_locked() in a few places to give a warning or an oops if either a spinlock is not held or if it is held. I'm not sure all of these are safe. Take uas_try_complete() in drivers/usb/storage/uas.c which does: WARN_ON(!spin_is_locked(&devinfo->lock)); or fscache_start_

<    1   2   3   4   5   6   7   8   9   10   >