Re: [PATCH] pci: do not try to assign irq 255

2013-02-26 Thread David Härdeman
>dev_warn(&dev->dev, "PCI INT %c: no GSI\n", > pin_name(pin)); >+ dev->irq = 0; >} >return 0; >} > >Which probably is a better solution,

Re: [PATCH] pci: do not try to assign irq 255

2013-02-18 Thread David Härdeman
operly. Just tested and it works for me. Thank you. Tested-by: David Härdeman >Cc: Frederik Himpe >Cc: Oliver Neukum >Cc: David Haerdeman >Cc: linux-...@vger.kernel.org >Cc: linux-...@vger.kernel.org >Signed-off-by: Hannes Reinecke > >diff --git a/drivers/pci/probe.c

Re: linux-next: build failure after merge of the v4l-dvb tree

2012-10-29 Thread David Härdeman
On Mon, 29 Oct 2012 11:14:03 +1100, Stephen Rothwell wrote: > Hi Mauro, > > After merging the v4l-dvb tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > drivers/hid/hid-picolcd_cir.c: In function 'picolcd_init_cir': > drivers/hid/hid-picolcd_cir.c:119:27: error: 'RC_TYP

[PATCH] hid-picolcd_cir: fix compilation

2012-10-31 Thread David Härdeman
Commit c003ab1bedf0 ("[media] rc-core: add separate defines for protocol bitmaps and numbers") overlooked hid-picolcd. This patch (against git.linuxtv.org/media_tree.git, branch staging/for_v3.8) fixes the compilation breakage. Signed-off-by: David Härdeman --- drivers/hid/hid-pic

Re: [PATCH] rc-core: don't return from store_protocols without releasing device mutex

2012-12-25 Thread David Härdeman
gt; >Doing that would cause infinite hangs waiting on device mutex next time >around. > >Signed-off-by: Sasha Levin Acked-by: David Härdeman >--- > drivers/media/rc/rc-main.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/drivers/media/rc/rc-main.c

Re: [PATCH] usb: correctly enable interrupts for xhci

2013-03-01 Thread David Härdeman
On Fri, Mar 01, 2013 at 09:52:54AM +0100, Hannes Reinecke wrote: >xhci might run with MSI/MSI-X only, with no support for legacy >interrupts. On these devices the request_irq() call in usb_add_hcd() >will fail, causing the entire device to fail. >For xhci this is especially painful as the driver wi

Re: [PATCH][v2] xhci: correctly enable interrupts

2013-03-04 Thread David Härdeman
; >Cc: Bjorn Helgaas >Cc: Oliver Neukum >Cc: Thomas Renninger >Cc: Yinghai Lu >Cc: Frederik Himpe >Cc: David Haerdeman >Cc: Alan Stern >Signed-off-by: Hannes Reinecke No idea if it's the "right" solution but it works for me. Tested-by: David Härdeman &g

Re: xhci module fails when booting in UEFI mode

2013-02-16 Thread David Härdeman
me problem (HP Elitebook 8570p in my case). This thread seems related: https://lkml.org/lkml/2012/2/13/453 No idea what happened to the patches in that thread though... -- David Härdeman -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message

Hard crash when trying to use PCI parallel port card

2000-12-08 Thread David Härdeman
t. Looking at 2.2.18-pre25 I couldn't see that the patch had been included though and as far as I could understand (with my limited knowledge of C) the patch only added the PCI id's to the kernel. Now, what can I do to solve this problem? (If any info is missing, please just

Problems with SCSI on 2.4.X

2001-03-14 Thread David Härdeman
Hi, I'm having some problems using SCSI-generic (sg loaded as module) to access my scanner on linux 2.4 (using SANE). I've been using 2.2.0 - 2.2.19pre17 without any problems, but when I changed to 2.4 the problems started. 2.4.1 gave the following entries in my kernel log file (id 7 = scsi card

Re: [-mm PATCH] set enable bit instead of lock bit of Watchdog Timer in Intel 6300 chipset

2005-08-15 Thread David Härdeman
On Mon, Aug 15, 2005 at 02:21:05PM -0700, Naveen Gupta wrote: This patch sets the WDT_ENABLE bit of the Lock Register to enable the watchdog and WDT_LOCK bit only if nowayout is set. The old code always sets the WDT_LOCK bit of watchdog timer for Intel 6300ESB chipset. So, we end up locking the

Re: [-mm PATCH] set correct bit in reload register of Watchdog Timer for Intel 6300 chipset

2005-08-15 Thread David Härdeman
On Mon, Aug 15, 2005 at 02:02:19PM -0700, Naveen Gupta wrote: This patch writes into bit 8 of the reload register to perform the correct 'Reload Sequence' instead of writing into bit 4 of Watchdog for Intel 6300ESB chipset. Signed-off-by: Naveen Gupta <[EMAIL PROTECTED]>

Re: [-mm PATCH] set enable bit instead of lock bit of Watchdog Timer in Intel 6300 chipset

2005-08-15 Thread David Härdeman
watchdog instead of enabling it. Signed-off-by: Naveen Gupta <[EMAIL PROTECTED]> Acked-by: David Härdeman <[EMAIL PROTECTED]> Thanks Naveen. //David - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED]

Re: [-mm PATCH] remove use of pci_find_device in watchdog driver for Intel 6300ESB chipset

2005-08-15 Thread David Härdeman
On Mon, Aug 15, 2005 at 02:30:15PM -0700, Naveen Gupta wrote: [...} -while ((dev = pci_find_device(PCI_ANY_ID, PCI_ANY_ID, dev)) != NULL) { -if (pci_match_id(esb_pci_tbl, dev)) { -esb_pci = dev; -break; -} -

[PATCH] Use sg_init_one where appropriate

2005-08-26 Thread David Härdeman
The same code as in sg_init_one can be found in a number of places, this patch changes them to call the function instead. Signed-off-by: David Härdeman <[EMAIL PROTECTED]> --- crypto/hmac.c | 23 ++- crypto/tcrypt.c

Re: [PATCH] Use sg_init_one where appropriate

2005-08-27 Thread David Härdeman
ay, using sg_init_one more and changing it to be a regular function seems like orthogonal issues to me. Regards, David Härdeman [1] http://www.ussg.iu.edu/hypermail/linux/kernel/0409.1/0257.html This patch uses sg_init_one in some places where it was duplicated. Signed-off-by: Da

LSM root_plug module questions

2005-08-30 Thread David Härdeman
Hi, I'm currently playing around with the security/root_plug.c LSM module and I have two questions: 1) What's the recommended way of telling that someone is logging in to the computer (via ssh, virtual console, serial console, X, whatever) with LSM? Look for open() on /dev/pts? 2) root_plu

Re: LSM root_plug module questions

2005-08-31 Thread David Härdeman
Chris Wright ([EMAIL PROTECTED]) wrote: > * David Härdeman ([EMAIL PROTECTED]) wrote: > > I'm currently playing around with the security/root_plug.c LSM module > you'll have better luck on the lsm list Thanks for the pointer > > 1) What's the recommended way of t

Consolidate dprintk and friends?

2005-09-01 Thread David Härdeman
A case-insensitive grep through the 2.6.13 tree for "define printk" yields 378 hits ("define dbg": 736, "define warn": 50, "define info": 65). Maybe it would be a good idea to create include/linux/debug.h as included inline below (or to add the content in include/linux/kernel.h where pr_debug

Re: IBM Thinkpad G41 PCMCIA problems

2005-02-20 Thread David Härdeman
Steven Rostedt wrote: I have a IBM Thinkpad G41 with a pentium4M with Hyperthreading. I can't get the PCMCIA working at all. I've tried turning off hyperthreading, I've tried with and without preempt, I've even added pci=noacpi. I've added Len's ACPI patches, but nothing works. I see the same pr

Re: IBM Thinkpad G41 PCMCIA problems

2005-02-20 Thread David Härdeman
On Sun, Feb 20, 2005 at 09:26:59AM +, Russell King wrote: On Sun, Feb 20, 2005 at 10:22:09AM +0100, David Härdeman wrote: I see the same problem with an IBM Thinkpad G40, and only when there is 1Gb of memory or more in the machine. Check to see if your e820 map has a hole in it, and whether

Re: IBM Thinkpad G41 PCMCIA problems

2005-02-20 Thread David Härdeman
On Sun, Feb 20, 2005 at 10:19:02AM +, Russell King wrote: On Sun, Feb 20, 2005 at 10:52:12AM +0100, David Härdeman wrote: Is the hole between 0x36f6fa000 and 0x3f70? Looks like it. And what would be the proper way of fixing it (assuming that IBM won't issue a fixed BIOS)? Try pa

6300ESB watchdog driver

2005-02-20 Thread David Härdeman
tation on http://developer.intel.com.) + * 6300ESB chip : document number 300641-003 + * + * 2004YYZZ Ross Biro + * Initial version 0.01 + * 2004YYZZ Ross Biro + * Version 0.02 + * 20050210 David Härdeman <[EMAIL PROTECTED]> + * Ported driver to kernel 2.6 + */ +

Re: IBM Thinkpad G41 PCMCIA problems [Was: Yenta TI: ... no PCI

2005-02-20 Thread David Härdeman
On Sun, 20 Feb 2005, Linus Torvalds wrote: Russell, what do your eagle-eyes think of a patch like this? Steven, does this fix it without the need for any kernel command line (or any other patches, for that matter - ie revert all the transparency- changing ones)? Linus I tried the patch on my G40

Re: 2.4.29, e100 and a WOL packet causes keventd going mad

2005-01-30 Thread David Härdeman
Hi, I experience the same problems as reported by Michael Gernoth when sending a WOL-packet to computer with a e100 NIC which is already powered on. In my case, it's running kernel 2.6.8.1 and the NIC is identified by lspci as: :02:08.0 Ethernet controller: Intel Corp. 82562EZ 10/100 Ethern

Non transparent Intel 82801 PCI Bridge fix in mainline kernel?

2005-01-30 Thread David Härdeman
* needed). So lots of newer IBM Thinkpads with 1Gb RAM or more are unsupported with a vanilla kernel. Now, the question is, is there any probability of a more specific fix being merged into the kernel and is there anyone with the code-fu to create such a patch? Kind regards, David Härdeman Not

IPMI smbus and Intel 6300ESB Watchdog drivers

2005-01-30 Thread David Härdeman
I missing something? Thanks in advance for any enlightenment. Regards, David Härdeman Not subscribed...please CC me on any replies... - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.

Re: IPMI smbus and Intel 6300ESB Watchdog drivers

2005-01-31 Thread David Härdeman
On Sun, Jan 30, 2005 at 10:13:09PM +0100, Peter Lundkvist wrote: On Sun, Jan 30, 2005 at 07:44:01PM +0100, David Härdeman wrote: 1) On the mainboard is a 6300ESB Watchdog Timer (pci id 8086:25ab), but there seems to be no driver available for it. Does anyone know if there is any such driver in

Re: IPMI smbus and Intel 6300ESB Watchdog drivers

2005-01-31 Thread David Härdeman
On Sun, Jan 30, 2005 at 02:26:03PM -0800, Bukie Mabayoje wrote: David Härdeman wrote: 1) On the mainboard is a 6300ESB Watchdog Timer (pci id 8086:25ab), but there seems to be no driver available for it. 6300ESB is not a Watchdog Timer. It is an I/O Controller hub that includes a watch dog timer

Re: 2.4.29, e100 and a WOL packet causes keventd going mad

2005-01-31 Thread David Härdeman
On Mon, Jan 31, 2005 at 01:24:31PM -0200, Marcelo Tosatti wrote: On Sun, Jan 30, 2005 at 08:23:47PM -0800, Bukie Mabayoje wrote: Scott Feldman wrote: David, would you give this patch a try? Make sure the system still wakes from a magic packet if suspended or shut down, and doesn't cause kacpid to

splice question

2007-08-12 Thread David Härdeman
a lot of extra syscalls. -- David Härdeman - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: splice question

2007-08-12 Thread David Härdeman
the socket could (I imagine) realize immediately that the socket does not have enough buffer space and return EWOULDBLOCK and avoid at least one copy? -- David Härdeman - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PRO

Changing the number of keys supported by the input subsystem

2007-10-24 Thread David Härdeman
So my question is whether it would be possible to extend that and/or make the size of the keymap (the keybit member of struct input_dev) dynamic? -- David Härdeman - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More ma

Re: [PATCH] ata: ahci: Enable enclosure management via LED (resend)

2007-10-25 Thread David Härdeman
usage need of this. I think the idea is that if mdadm (for example) kicks out a faulty disk from an array, it could also activate a LED (usually a different LED than the "disk activity" LED) on the corresponding enclosure so that the admin knows when standing in front of the storage

Re: [PATCH] general: convert "kernel" subdirectory to UTF-8

2007-04-18 Thread David Härdeman
it > would be better option. The comment says "(The) same in swedish" -- David Härdeman - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: RFC: A revised timerfd API

2007-10-01 Thread David Härdeman
stderr */ fd = open("/dev/null", flags); dup(fd); dup(fd); Unless timer_create does some magic to avoid using the lowest available fd, this would suddenly break as the timerfd would be fd 0. -- David Härdeman - To unsubscribe from this list: send the line "unsubsc

Re: RFC: A revised timerfd API

2007-09-18 Thread David Härdeman
if the timerfd is close():d, does that remove the underlying timer (invalidate the timerid) as well? -- David Härdeman - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: RFC: A revised timerfd API

2007-09-18 Thread David Härdeman
e descriptors with flags looks ugly, is there any other syscall which does that? -- David Härdeman (sorry Thomas for the dupe, I missed replying to all on the first msg). - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTE

Re: mceusb: sysfs: cannot create duplicate filename '/class/rc/rc0' (race condition between multiple RC_CORE devices)

2015-03-30 Thread David Härdeman
On 2015-03-30 17:30, Stefan Lippers-Hollmann wrote: Hi This is a follow-up for: http://lkml.kernel.org/r/<201412181916.18051.s@gmx.de> http://lkml.kernel.org/r/<201412302211.40801.s@gmx.de> I can't swear that it's the case but I'm guessing this might be fixed by the p

Re: mceusb: sysfs: cannot create duplicate filename '/class/rc/rc0' (race condition between multiple RC_CORE devices)

2015-03-30 Thread David Härdeman
On 2015-03-30 22:21, Stefan Lippers-Hollmann wrote: On 2015-03-30, David Härdeman wrote: On 2015-03-30 17:30, Stefan Lippers-Hollmann wrote: > This is a follow-up for: >http://lkml.kernel.org/r/<201412181916.18051.s@gmx.de> >http://lkml.kernel.org/r/<201412302211.

Re: [GIT PULL for v3.15-rc1] media updates

2014-04-03 Thread David Härdeman
ave overlooked that discussion...or have I missed something? -- David Härdeman -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] [media] winbond-cir: remove deprecated IRQF_DISABLED

2013-10-14 Thread David Härdeman
On 2013-10-13 08:11, Michael Opdenacker wrote: This patch proposes to remove the use of the IRQF_DISABLED flag It's a NOOP since 2.6.35 and it will be removed one day. Signed-off-by: Michael Opdenacker Acked-by: David Härdeman --- drivers/media/rc/winbond-cir.c | 2 +- 1 file chang

Re: [PATCH v7 2/3] [media] rc: add sunxi-ir driver

2014-05-19 Thread David Härdeman
On Thu, May 15, 2014 at 03:56:41AM +0600, Alexander Bersenev wrote: >This patch adds driver for sunxi IR controller. >It is based on Alexsey Shestacov's work based on the original driver >supplied by Allwinner. > ... >+static irqreturn_t sunxi_ir_irq(int irqno, void *dev_id) >+{ >+ unsigned

Logitech Unifying Receiver - power button not being reported?

2014-05-26 Thread David Härdeman
e no event seems to be generated). Is this a known limitation? Something that can be fixed? Is there something I've overlooked? -- David Härdeman -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org Mor

Re: [PATCH v2 1/2] [media] rc-core: fix protocol_change regression in ir_raw_event_register

2014-10-28 Thread David Härdeman
On 2014-10-26 20:33, Tomas Melin wrote: On Sat, Oct 25, 2014 at 12:03 PM, David Härdeman wrote: Wouldn't something like this be a simpler way of achieving the same result? (untested): The idea was to remove the empty change_protocol function that had been added in the breaking commit.

Re: [PATCH v3] [media] rc-core: fix protocol_change regression in ir_raw_event_register

2014-10-28 Thread David Härdeman
ignals anymore. > >Enable lirc protocol by default for ir raw decoders to restore original >behaviour. > >Signed-off-by: Tomas Melin Acked-by: David Härdeman >--- > drivers/media/rc/rc-ir-raw.c |1 - > drivers/media/rc/rc-main.c |2 ++ > 2 files changed, 2 insert

Re: [PATCH v2 1/2] [media] rc-core: fix protocol_change regression in ir_raw_event_register

2014-10-25 Thread David Härdeman
On Tue, Oct 21, 2014 at 09:30:17PM +0300, Tomas Melin wrote: >IR reciever using nuvoton-cir and lirc required additional configuration >steps after upgrade from kernel 3.16 to 3.17-rcX. >Bisected regression to commit da6e162d6a4607362f8478c715c797d84d449f8b >("[media] rc-core: simplify sysfs code")

Re: [PATCH] Fix RC5 decoding with Fintek CIR chipset

2016-05-23 Thread David Härdeman
lowing for a previous space in the >received remote command). > >Signed-off-by: Jonathan McDowell Signed-off-by: David Härdeman >Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=117221 >Cc: sta...@vger.kernel.org > >- >diff --git a/drivers/media/rc/ir-rc5-dec

Re: [PATCH resend] [media] rc-core: fix protocol_change regression in ir_raw_event_register

2014-10-16 Thread David Härdeman
On Thu, Oct 09, 2014 at 09:30:36PM +0300, Tomas Melin wrote: >IR reciever using nuvoton-cir and lirc was not working anymore after >upgrade from kernel 3.16 to 3.17-rcX. >Bisected regression to commit da6e162d6a4607362f8478c715c797d84d449f8b >("[media] rc-core: simplify sysfs code"). > >The regress

Re: [PATCH 1/2] [media] rc-core: fix protocol_change regression in ir_raw_event_register

2014-10-20 Thread David Härdeman
On 2014-10-19 12:21, Tomas Melin wrote: IR reciever using nuvoton-cir and lirc was not working anymore after upgrade from kernel 3.16 to 3.17-rcX. Bisected regression to commit da6e162d6a4607362f8478c715c797d84d449f8b ("[media] rc-core: simplify sysfs code"). FWIW, I think "not working" is slig

Re: [PATCH 2/2] [media] rc-core: change enabled_protocol default setting

2014-10-20 Thread David Härdeman
On 2014-10-19 12:21, Tomas Melin wrote: Change default setting for enabled protocols. Instead of enabling all protocols, disable all except lirc during registration. Reduces overhead since all protocols not handled by default. Protocol to use will be enabled when keycode table is written by us

Re: [PATCH v2 5/7] [media] ir-lirc-codec: don't wait any transmitting time for tx only devices

2016-10-31 Thread David Härdeman
October 27, 2016 4:36 PM, "Sean Young" wrote: > Since we have to be able to switch between waiting and not waiting, > we need some sort of ABI for this. I think this warrants a new ioctl; > I'm not sure how else it can be done. I'll be sending out a patch > shortly. Hi Sean, have you considered

Re: [PATCH 3/5] [media] winbond-cir: Move assignments for three variables in wbcir_shutdown()

2016-10-19 Thread David Härdeman
October 14, 2016 1:43 PM, "SF Markus Elfring" wrote: > From: Markus Elfring > Date: Fri, 14 Oct 2016 10:40:12 +0200 > > Move the setting for the local variables "mask", "match" and "rc6_csl" > behind the source code for a condition check by this function > at the beginning. Again, I can't see

Re: [media] winbond-cir: Move a variable assignment in wbcir_tx()

2016-10-19 Thread David Härdeman
October 19, 2016 3:32 PM, "SF Markus Elfring" wrote: >>> Move the assignment for the local variable "data" behind the source code >>> for a memory allocation by this function. >> >> Sorry, I can't see what the point is? > > * How do you think about to avoid a variable assignment in case > that

Re: [PATCH 4/5] [media] winbond-cir: One variable and its check less in wbcir_shutdown() after error detection

2016-10-19 Thread David Härdeman
October 15, 2016 6:42 PM, "SF Markus Elfring" wrote: >>> + /* Set CEIR_EN */ >>> + wbcir_set_bits(data->wbase + WBCIR_REG_WCEIR_CTL, 0x01, 0x01); >>> +set_irqmask: >>> /* >>> * ACPI will set the HW disable bit for SP3 which means that the >>> * output signals are left in an undefined state which

Re: [PATCH 4/5] [media] winbond-cir: One variable and its check less in wbcir_shutdown() after error detection

2016-10-19 Thread David Härdeman
October 15, 2016 3:30 PM, "Sean Young" wrote: > On Fri, Oct 14, 2016 at 01:44:02PM +0200, SF Markus Elfring wrote: > >> From: Markus Elfring >> Date: Fri, 14 Oct 2016 12:48:41 +0200 >> >> The local variable "do_wake" was set to "false" after an invalid system >> setting was detected so that a b

Re: [PATCH 5/5] [media] winbond-cir: Move a variable assignment in two functions

2016-10-19 Thread David Härdeman
October 14, 2016 1:45 PM, "SF Markus Elfring" wrote: > From: Markus Elfring > Date: Fri, 14 Oct 2016 13:13:11 +0200 > > Move the assignment for the local variable "data" behind the source code > for condition checks by these functions. Why? > Signed-off-by: Markus Elfring > --- > drivers/med

Re: [PATCH 1/5] [media] winbond-cir: Use kmalloc_array() in wbcir_tx()

2016-10-19 Thread David Härdeman
e the corresponding function "kmalloc_array". > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Sure...why not... Signed-off-by: David Härdeman > --- > drivers/media/rc/winbond-cir.c | 2 +- > 1 file changed, 1 insertion(+

Re: [PATCH 2/5] [media] winbond-cir: Move a variable assignment in wbcir_tx()

2016-10-19 Thread David Härdeman
October 14, 2016 1:42 PM, "SF Markus Elfring" wrote: > From: Markus Elfring > Date: Fri, 14 Oct 2016 07:34:46 +0200 > > Move the assignment for the local variable "data" behind the source code > for a memory allocation by this function. Sorry, I can't see what the point is? > Signed-off-by:

Re: [media] winbond-cir: Move assignments for three variables in wbcir_shutdown()

2016-10-19 Thread David Härdeman
October 19, 2016 3:38 PM, "SF Markus Elfring" wrote: >>> Move the setting for the local variables "mask", "match" and "rc6_csl" >>> behind the source code for a condition check by this function >>> at the beginning. >> >> Again, I can't see what the point is? > > * How do you think about to set