: https://lore.kernel.org/lkml/20240827160631.67e12...@canb.auug.org.au/
Fixes: f2c6dbd22017 ("kunit: Device wrappers should also manage driver name")
Signed-off-by: David Gow
---
include/kunit/test.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/kunit/test.h b/include/kunit/test.h
d list.
> 5. The old list is empty.
>
> Signed-off-by: Zhen Lei
> ---
Thanks very much for the detailed test. It's great to see these kept up-to-date!
Reviewed-by: David Gow
Cheers,
-- David
> lib/list-test.c | 51 +
> 1 file
linux-kernel-vscode
>
> Signed-off-by: Brendan Jackman
> ---
Sorry for missing this earlier.
I'm happy with this. Having the compile_commands.json be in the .kunit
directory is annoying, but it actually ends up being less annoying for
the case where you have lots of out-of-tree
out with all the different combinations I could think of,
and it works well.
Reviewed-by: David Gow
Cheers,
-- David
> lib/kunit/.kunitconfig | 3 +++
> tools/testing/kunit/kunit.py | 4 +++-
> tools/testing/kunit/kunit_kernel.py| 2 ++
> tools/testing/k
The first argument to namedtuple() should match the name of the type,
which wasn't the case for KconfigEntryBase.
Fixing this is enough to make mypy show no python typing errors again.
Fixes 97752c39bd ("kunit: kunit_tool: Allow .kunitconfig to disable config
items")
Signed-of
On Wed, Feb 10, 2021 at 6:14 AM Daniel Latypov wrote:
>
> From: Uriel Guajardo
>
> Add a kunit_fail_current_test() function to fail the currently running
> test, if any, with an error message.
>
> This is largely intended for dynamic analysis tools like UBSAN and for
> fakes.
> E.g. say I had a f
with literals look like:
# example_simple_test: EXPECTATION FAILED at lib/kunit/kunit-example-test.c:31
Expected "abc" == "abd", but
"abc" == abc
"abd" == abd
# example_simple_test: EXPECTATION FAILED at lib/kunit/kunit-example-test.c:33
Expected 0x124 == 0x1234, but
0x124 == 0124
0x1234 == 1234
Either way, though, this is:
Tested-by: David Gow
Cheers,
-- David
On Sat, Jan 23, 2021 at 8:17 AM Daniel Latypov wrote:
>
> Currently running tests via KUnit tool means tweaking a .kunitconfig
> file, which you'd keep around locally and never commit.
> This changes makes it so users can pass in a path to a kunitconfig.
>
> One of the imagined use cases is having
cking down the real root cause,
but since this is breaking KUnit's --alltests feature, it's worth
disabling there in the meantime so the kernel can boot to the point
where tests can actually run.
Fixes: f289041ed4 ("mm, page_poison: remove CONFIG_PAGE_POISONING_ZERO")
Signed-of
From: Patricia Alfonso
In order to integrate debugging tools like KASAN into the KUnit
framework, add KUnit struct to the current task to keep track of the
current KUnit test.
Signed-off-by: Patricia Alfonso
Reviewed-by: Brendan Higgins
Signed-off-by: David Gow
---
include/linux/sched.h | 4
ot
enabled, KUnit will print a statement to let the user know this test
was not run with KASAN_STACK enabled.
copy_user_test cannot be run in KUnit so there is a separate test file
for those tests, which can be run as before as a module.
Signed-off-by: Patricia Alfonso
Signed-off-by: David Gow
resenting if a KASAN report is expected and if a
KASAN report is found
[1]
(https://lore.kernel.org/linux-kselftest/1583251361-12748-1-git-send-email-alan.magu...@oracle.com/T/#t)
Signed-off-by: Patricia Alfonso
Signed-off-by: David Gow
Reviewed-by: Andrey Konovalov
Reviewed-by: Dmi
kernel.org/linux-kselftest/20200620054944.167330-1-david...@google.com/
David Gow (1):
mm: kasan: Do not panic if both panic_on_warn and kasan_multishot set
Patricia Alfonso (4):
Add KUnit Struct to Current Task
KUnit: KASAN Integration
KASAN: Port KASAN Tests to KUnit
KASAN: Testing Docum
From: Patricia Alfonso
Include documentation on how to test KASAN using CONFIG_TEST_KASAN_KUNIT
and CONFIG_TEST_KASAN_MODULE.
Signed-off-by: Patricia Alfonso
Signed-off-by: David Gow
Reviewed-by: Andrey Konovalov
Reviewed-by: Dmitry Vyukov
Acked-by: Brendan Higgins
---
Documentation/dev
KASAN warnings show up).
Signed-off-by: David Gow
Reviewed-by: Andrey Konovalov
Reviewed-by: Brendan Higgins
---
mm/kasan/report.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/kasan/report.c b/mm/kasan/report.c
index 90a1348c8b81..c83d6fde9ee4 100644
--- a/mm/kasan/report.c
On Sat, Aug 8, 2020 at 4:51 PM Brendan Higgins
wrote:
>
> On Fri, Aug 7, 2020 at 10:45 PM David Gow wrote:
> >
> > On Sat, Aug 8, 2020 at 9:17 AM Brendan Higgins
> > wrote:
> > >
> > > Currently kunit_tool does not work correctly when executed from a
selftest/8d43e88e-1356-cd63-9152-209b81b16...@linuxfoundation.org/T/#u
David Gow (2):
kasan: test: Make KASAN KUnit test comply with naming guidelines
mm: kasan: Do not panic if both panic_on_warn and kasan_multishot set
Patricia Alfonso (4):
Add KUnit Struct to Current Task
KUnit:
From: Patricia Alfonso
In order to integrate debugging tools like KASAN into the KUnit
framework, add KUnit struct to the current task to keep track of the
current KUnit test.
Signed-off-by: Patricia Alfonso
Reviewed-by: Brendan Higgins
Tested-by: Andrey Konovalov
Signed-off-by: David Gow
resenting if a KASAN report is expected and if a
KASAN report is found
[1]
(https://lore.kernel.org/linux-kselftest/1583251361-12748-1-git-send-email-alan.magu...@oracle.com/T/#t)
Signed-off-by: Patricia Alfonso
Signed-off-by: David Gow
Reviewed-by: Andrey Konovalov
Reviewed-by: Dmi
ot
enabled, KUnit will print a statement to let the user know this test
was not run with KASAN_STACK enabled.
copy_user_test and kasan_rcu_uaf cannot be run in KUnit so there is a
separate test file for those tests, which can be run as before as a
module.
Signed-off-by: Patricia Alfonso
Signed-
/20200702071416.1780522-1-david...@google.com/
Signed-off-by: David Gow
Tested-by: Andrey Konovalov
---
lib/Makefile| 6 +++---
lib/{test_kasan.c => kasan_kunit.c} | 0
2 files changed, 3 insertions(+), 3 deletions(-)
rename lib/{test_kasan.c => kasan_kunit.c} (100%)
diff -
KASAN warnings show up).
Signed-off-by: David Gow
Reviewed-by: Andrey Konovalov
Reviewed-by: Brendan Higgins
Tested-by: Andrey Konovalov
---
mm/kasan/report.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/kasan/report.c b/mm/kasan/report.c
index e2c14b10bc81..00a53f1355ae 1
From: Patricia Alfonso
Include documentation on how to test KASAN using CONFIG_TEST_KASAN_KUNIT
and CONFIG_TEST_KASAN_MODULE.
Signed-off-by: Patricia Alfonso
Signed-off-by: David Gow
Reviewed-by: Andrey Konovalov
Reviewed-by: Dmitry Vyukov
Acked-by: Brendan Higgins
Tested-by: Andrey
e8f5958d8997cf47a820afc
[5] https://bugzilla.kernel.org/show_bug.cgi?id=206337
[6]
https://lore.kernel.org/linux-kselftest/20200620054944.167330-1-david...@google.com/
[7] https://lkml.org/lkml/2020/7/31/571
David Gow (1):
mm: kasan: Do not panic if both panic_on_warn and kasan_multishot set
Patricia
resenting if a KASAN report is expected and if a
KASAN report is found
[1]
(https://lore.kernel.org/linux-kselftest/1583251361-12748-1-git-send-email-alan.magu...@oracle.com/T/#t)
Signed-off-by: Patricia Alfonso
Signed-off-by: David Gow
Reviewed-by: Andrey Konovalov
Reviewed-by: Dmi
From: Patricia Alfonso
In order to integrate debugging tools like KASAN into the KUnit
framework, add KUnit struct to the current task to keep track of the
current KUnit test.
Signed-off-by: Patricia Alfonso
Reviewed-by: Brendan Higgins
Signed-off-by: David Gow
---
include/linux/sched.h | 4
ot
enabled, KUnit will print a statement to let the user know this test
was not run with KASAN_STACK enabled.
copy_user_test and kasan_rcu_uaf cannot be run in KUnit so there is a
separate test file for those tests, which can be run as before as a
module.
Signed-off-by: Patricia Alfonso
Signed-
From: Patricia Alfonso
Include documentation on how to test KASAN using CONFIG_TEST_KASAN_KUNIT
and CONFIG_TEST_KASAN_MODULE.
Signed-off-by: Patricia Alfonso
Signed-off-by: David Gow
Reviewed-by: Andrey Konovalov
Reviewed-by: Dmitry Vyukov
Acked-by: Brendan Higgins
---
Documentation/dev
KASAN warnings show up).
Signed-off-by: David Gow
Reviewed-by: Andrey Konovalov
Reviewed-by: Brendan Higgins
---
mm/kasan/report.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/kasan/report.c b/mm/kasan/report.c
index e2c14b10bc81..00a53f1355ae 100644
--- a/mm/kasan/report.c
On Fri, Jul 31, 2020 at 9:25 PM 'Andrey Konovalov' via kasan-dev
wrote:
>
> On Fri, Jul 31, 2020 at 6:43 AM David Gow wrote:
> >
> > This patchset contains everything needed to integrate KASAN and KUnit.
> >
> > KUnit will be able to:
> > (1) Fa
On Thu, Aug 6, 2020 at 5:53 PM Andy Shevchenko
wrote:
>
> On Thu, Aug 6, 2020 at 12:48 PM Arpitha Raghunandan <98.a...@gmail.com> wrote:
> >
> > Converts test lib/test_hexdump.c to KUnit.
> > More information about KUnit can be found at
> > https://www.kernel.org/doc/html/latest/dev-tools/kunit/in
On Fri, Aug 7, 2020 at 9:15 PM 'Andrey Konovalov' via kasan-dev
wrote:
>
> On Wed, Aug 5, 2020 at 6:29 AM David Gow wrote:
> >
> > This patchset contains everything needed to integrate KASAN and KUnit.
> >
> > KUnit will be able to:
> > (1) Fail test
On Sat, Aug 8, 2020 at 9:17 AM Brendan Higgins
wrote:
>
> Currently kunit_tool does not work correctly when executed from a path
> outside of the kernel tree, so make sure that the current working
> directory is correct and the kunit_dir is properly initialized before
> running.
>
> Signed-off-by:
iagnostic lines, so that
these statistics do not prevent the result from parsing.
Signed-off-by: David Gow
---
This is largely a follow-up to the discussion here:
https://lore.kernel.org/linux-kselftest/CABVgOSmy4n_LGwDS7yWfoLftcQzxv6S+iXx9Y=opcgg2gu0...@mail.gmail.com/T/#t
Does this seem lik
Various helper functions were misspelling "diagnostic" in their names.
It finally got annoying, so fix it.
Signed-off-by: David Gow
---
tools/testing/kunit/kunit_parser.py | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/tools/tes
ned-off-by: David Gow
Fixes: 757055ae8ded ("init/console: Use ttynull as a fallback when there is no
console")
---
tools/testing/kunit/kunit_kernel.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/kunit/kunit_kernel.py
b/tools/testing/kunit/k
problem having both: this page is supposed to be a
bit more of a reference, rather than a list of useful tips, so the fact
that they both describe the same features isn't a problem.
Signed-off-by: David Gow
---
Documentation/dev-tools/kunit/kunit-tool.rst | 132 ++-
1 file chan
t/torvalds/linux.git/tree/fs/ext4/inode-test.c
Signed-off-by: David Gow
Acked-by: OGAWA Hirofumi
---
It's been a while, but this hopefully is a final version of the FAT KUnit
patchset. It has a number of changes to keep it up-to-date with current
KUnit standards, notably the use of paramete
problem having both: this page is supposed to be a
bit more of a reference, rather than a list of useful tips, so the fact
that they both describe the same features isn't a problem.
Signed-off-by: David Gow
Reviewed-by: Daniel Latypov
---
Adopted the changes from Daniel.
Changes since v1
cover edge cases should be easy
> * looking at code coverage, we hit all the branches in the .c files
>
> Signed-off-by: Daniel Latypov
> Reviewed-by: David Gow
> ---
Thanks: I've tested this version, and am happy with it. A part of me
still kind-of would like there to be na
Hi Matt,
> Like patch 1/6, I can apply it in MPTCP tree and send it later to
> net-next with other patches.
> Except if you guys prefer to apply it in KUnit tree and send it to
> linux-next?
Given 1/6 is going to net-next, it makes sense to send this out that
way too, then, IMHO.
The only slight
esting/kunit/kunit.py run '*exec*'
>
> Signed-off-by: Daniel Latypov
I really like this test, thanks.
A few small notes below, including what I think is a missing
kfree_at_end() call.
Assuming that one issue is fixed (or I'm mistaken):
Reviewed-by: David Gow
-- David
>
cover edge cases should be easy
> * looking at code coverage, we hit all the branches in the .c files
>
> Signed-off-by: Daniel Latypov
This looks good to me. A few comments/observations below, but nothing
that I think should actually block this.
Reviewed-by: David Gow
-- David
ons
are addressed. I'm particularly excited to have code coverage
documented somewhere.
Assuming Brendan's happy with the TODOs being there, I think this is
ready to go.
I also built this with Sphinx and gave it a quick look, and it all
looks good there as well.
Therefore, this is:
Reviewed-by: David Gow
Cheers,
-- David
entation later.
Signed-off-by: David Gow
---
Thanks, everyone, for the comments on the doc. I've made a few of the
suggested changes. Please let me know what you think!
-- David
Changes since v1:
https://lore.kernel.org/linux-kselftest/20210410070529.4113432-1-david...@google.com/
- Note KUnit&
On Thu, Apr 15, 2021 at 12:30 AM Daniel Latypov wrote:
>
> On Wed, Apr 14, 2021 at 1:15 AM David Gow wrote:
> >
> > The kernel now has a number of testing and debugging tools, and we've
> > seen a bit of confusion about what the differences between them are.
>
entation later.
Signed-off-by: David Gow
Reviewed-by: Marco Elver
Reviewed-by: Daniel Latypov
---
Thanks again. Assuming no-one has any objections, I think this is good
to go.
-- David
Changes since v2:
https://lore.kernel.org/linux-kselftest/20210414081428.337494-1-david...@google.com/
- A
;S' on the end isn't a huge problem if you
have a good reason to particularly want to keep it, though: as long as
you don't have something like _K_UNIT_VERIFICATION or something
equally silly that'd break grepping for '_KUNIT_TEST', it's fine be
me.
So, since it matches my prejudices, this patch is:
Reviewed-by: David Gow
Thanks,
-- David
Thanks for writing this: it's good to have these things documented at last!
There are definitely a few things this document points out which still
need deciding, which does make this document lean a bit into "design
discussion" territory in a few of the notes. This doesn't bother me --
it's an acc
entation later.
Signed-off-by: David Gow
---
Documentation/dev-tools/index.rst| 3 +
Documentation/dev-tools/testing-overview.rst | 102 +++
2 files changed, 105 insertions(+)
create mode 100644 Documentation/dev-tools/testing-overview.rst
diff --git a/Docume
from the
> list for _every_ outer iteration.
>
> Signed-off-by: Daniel Latypov
> ---
Thanks! This works great here: I didn't time it to see how much faster
it is, but it's clearly an improvement.
Reviewed-by: David Gow
Cheers,
-- David
Because dfl.c uses the 'devm_ioremap', 'devm_iounmap',
'devm_ioremap_resource', and 'devm_platform_ioremap_resource'
functions, it should depend on HAS_IOMEM.
This fixes make allyesconfig under UML (ARCH=um), which doesn't provide
HAS_IOMEM.
Signed
]:
- MFD_HI6421_SPMI [=y] && STAGING [=y] && OF [=y] && SPMI [=y]
By specifying HAS_IOMEM as a dependency for MFD_HI6421_SPMI (as
SPMI_HISI3670 already dows), this issue is resolved, and no such warning
appears when building on architectures without HAS_IOMEM.
Signed-off-by: David G
UTPUT= in tools/scripts/Makefile.include.
Signed-off-by: David Gow
---
Hi all,
I'm not 100% sure this is the correct fix here -- it seems to work for
me, and makes some sense, but let me know if there's a better way.
One other thing worth noting is that I've been hitting this with
On Fri, Nov 20, 2020 at 2:27 PM Moritz Fischer wrote:
>
> Hi David,
>
> On Thu, Nov 19, 2020 at 12:22:09AM -0800, David Gow wrote:
> > Because dfl.c uses the 'devm_ioremap', 'devm_iounmap',
> > 'devm_ioremap_resource', and 'devm_pl
typov
> ---
I won't pretend to be an expert on Python, but this seems good to me.
I tested it on my machine and it works fine.
So,
Reviewed-by: David Gow
-- Davkd
> tools/testing/kunit/kunit_tool_test.py | 14 ++
> 1 file changed, 6 insertions(+), 8 deletions(-)
&
brain does understand the older code a
touch more easily.
In any case,
Reviewed-by: David Gow
-- David
On Tue, Dec 1, 2020 at 7:33 AM Daniel Latypov wrote:
>
> get_absolute_path() makes an attempt to allow for this.
> But that doesn't work as soon as os.chdir() gets called.
Can we explain why this doesn't work? It's because the test_data/
files are accessed with relative paths, so chdir breaks acc
On Tue, Dec 1, 2020 at 7:33 AM Daniel Latypov wrote:
>
> 1. the name is a lie. It gives relative paths, e.g. if I run from the
> same dir as the test file, it gives './test_data/'
>
> 2. it's only used for generating paths to tools/testing/kunit/test_data/
> So we can tersen things by making it le
seems pretty sensible from my rudimentary
python knowledge.
Reviewed-by: David Gow
Cheers,
-- David
On Mon, Nov 23, 2020 at 9:08 PM Marco Elver wrote:
>
> On Tue, 17 Nov 2020 at 08:21, David Gow wrote:
> > On Mon, Nov 16, 2020 at 1:41 PM Arpitha Raghunandan <98.a...@gmail.com>
> > wrote:
> > >
> > > Implementation of support for parameterized testing
On Fri, Dec 4, 2020 at 3:41 AM Daniel Latypov wrote:
>
> LinuxSourceTree will unceremoniously crash if the user doesn't call
> read_kunitconfig() first in a number of functions.
This patch seems to partly be reverting the changes here, right:
https://git.kernel.org/pub/scm/linux/kernel/git/shuah/
s the precedent in commit 3fc48259d525 ("kunit: Don't
> fail test suites if one of them is empty").
>
> Also slightly simplify the code and add type annotations.
>
> Signed-off-by: Daniel Latypov
> ---
Otherwise, the actual code changes all seem sensible, and it worked
fine when I tested it, so:
Reviewed-by: David Gow
-- David
ov
> ---
This looks good to me: I gave it some quick testing, and reading
through it, all of the changes seem sensible.
I wasn't able to get pytype running here, but mypy worked fine.
Reviewed-by: David Gow
-- David
On Sat, Dec 5, 2020 at 2:18 AM Daniel Latypov wrote:
>
> On Thu, Dec 3, 2020 at 7:57 PM David Gow wrote:
> >
> > On Fri, Dec 4, 2020 at 3:41 AM Daniel Latypov wrote:
> > >
> > > LinuxSourceTree will unceremoniously crash if the user doesn't call
>
On Wed, Dec 2, 2020 at 3:00 AM Daniel Latypov wrote:
>
> On Mon, Nov 30, 2020 at 11:33 PM David Gow wrote:
> >
> > On Tue, Dec 1, 2020 at 7:33 AM Daniel Latypov wrote:
> > >
> > > get_absolute_path() makes an attempt to allow for this.
> > > But
On Wed, Dec 2, 2020 at 6:06 PM Andy Shevchenko
wrote:
>
> On Wed, Dec 02, 2020 at 09:51:19AM +0530, Arpitha Raghunandan wrote:
> > On 01/12/20 4:36 pm, Andy Shevchenko wrote:
> > > On Tue, Dec 1, 2020 at 9:21 AM Arpitha Raghunandan <98.a...@gmail.com>
> > > wrote:
>
> ...
>
> > >> I ran both the
On Wed, Dec 2, 2020 at 8:21 PM Andy Shevchenko
wrote:
>
> On Wed, Dec 2, 2020 at 1:57 PM David Gow wrote:
> > On Wed, Dec 2, 2020 at 6:06 PM Andy Shevchenko
> > wrote:
> > > On Wed, Dec 02, 2020 at 09:51:19AM +0530, Arpitha Raghunandan wrote:
>
> ...
>
> &
ov
> ---
This patch hasn't changed since v1, right?
It's still:
Reviewed-by: David Gow
Cheers,
-- David
utside.
>
> Do so to make the code more Pythonic.
>
> Signed-off-by: Daniel Latypov
> ---
Reviewed-by: David Gow
Cheers,
-- David
cabvgosnh0gz7z5jhrcgyg1wg0zddbtlosucob-gwmexlgvt...@mail.gmail.com/
>
> Fixes: 5578d008d9e0 ("kunit: tool: fix running kunit_tool from outside kernel
> tree")
> Signed-off-by: Daniel Latypov
> ---
Thanks: I much prefer this to v1. Having it work the same way as
test_tmpdir is a bonus.
Reviewed-by: David Gow
Cheers,
-- David
t check of exception types. self.assertRaises does this.
> * s/kall/call. There's no reason to name it this way.
> * This is probably a misunderstanding from the docs which uses it
> since `mock.call` is in scope as `call`.
>
> Signed-off-by: Daniel Latypov
> ---
Looks good, thanks!
Reviewed-by: David Gow
-- David
gt; 2. Rename suite name 'kcsan-test' to 'kcsan'.
>
> 3. Rename CONFIG_KCSAN_TEST to CONFIG_KCSAN_KUNIT_TEST and
>default to KUNIT_ALL_TESTS.
>
> Cc: David Gow
> Signed-off-by: Marco Elver
Thanks very much -- it's great t
IOMEM, the driver will not be enabled on
architectures which don't support it.
Fixes: 22447a99c97e ("drivers/soc/litex: add LiteX SoC Controller driver")
Signed-off-by: David Gow
---
drivers/soc/litex/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/soc/litex/K
river will not be enabled on
architectures which don't support it.
Fixes: 9ad9a52cce28 ("i3c/master: introduce the mipi-i3c-hci driver")
Signed-off-by: David Gow
---
drivers/i3c/master/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/i3c/master/Kconfig b/driver
, the driver will not be enabled on
architectures which don't support it.
Fixes: 09ef18bcd5ac ("rtc: use devm_platform_ioremap_resource() to simplify
code")
Signed-off-by: David Gow
---
drivers/rtc/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/d
> workaround (hack).
>
> At the same time, we can increase the maximum number of threads used,
> because on systems with too few CPUs, KUnit allows us to now stop at the
> maximum useful threads and not unnecessarily execute redundant test
> cases with (the same) limited threads a
On Wed, Jan 27, 2021 at 8:27 PM Stafford Horne wrote:
>
> On Tue, Jan 26, 2021 at 07:36:04PM -0800, David Gow wrote:
> > The LiteX SOC controller driver makes use of IOMEM functions like
> > devm_platform_ioremap_resource(), which are only available if
> > CON
> >>>> On 12/22/20 4:11 AM, Andy Shevchenko wrote:
> >>>>> On Mon, Dec 21, 2020 at 11:39:00PM -0800, David Gow wrote:
> >>>>>> kunit_tool relies on the UML console outputting printk() output to the
> >>>>>> tty in or
de
> guidance for testing many inputs") to show a minimal example of the new
> feature.
>
> Signed-off-by: Daniel Latypov
> ---
This looks good to me. Thanks!
Reviewed-by: David Gow
-- David
smime.p7s
Description: S/MIME Cryptographic Signature
On Wed, Dec 16, 2020 at 10:53 PM Quentin Monnet wrote:
>
> 2020-11-21 17:48 UTC+0800 ~ David Gow
> > On Sat, Nov 21, 2020 at 3:38 PM Andrii Nakryiko
> > wrote:
> >>
> >> On Thu, Nov 19, 2020 at 12:51 AM David Gow wrote:
> >>>
> >>
s: 89eb35e810a8 ("fpga: dfl: map feature mmio resources in their own
feature drivers")
Signed-off-by: David Gow
---
Changes since v1:
(
https://lore.kernel.org/linux-fpga/20201119082209.3598354-1-david...@google.com/
)
- Add Fixes tag
drivers/fpga/Kconfig | 1 +
1 file changed, 1 inserti
On Sat, Nov 21, 2020 at 3:38 PM Andrii Nakryiko
wrote:
>
> On Thu, Nov 19, 2020 at 12:51 AM David Gow wrote:
> >
> > If BPF_PRELOAD is enabled, and an out-of-tree build is requested with
> > make O=, compilation seems to fail with:
> >
> > tools/scripts/Makef
).
This change depends on KUnit, so should be merged via the 'test' branch:
https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git/log/?h=test
Signed-off-by: David Gow
---
lib/Kconfig.debug | 12 +
lib/Makefile | 3 +
lib/list-test
On Mon, Oct 7, 2019 at 6:03 PM Kees Cook wrote:
(...)
> > +
> > +static void list_init_test(struct kunit *test)
> > +{
> > + /* Test the different ways of initialising a list. */
> > + struct list_head list1 = LIST_HEAD_INIT(list1);
> > + struct list_head list2;
> > + LIST_HEAD(lis
On Sat, May 2, 2020 at 4:31 AM Brendan Higgins
wrote:
>
> On Fri, May 1, 2020 at 1:35 AM Anders Roxell wrote:
> >
> > Make it easier to enable all KUnit fragments. This is needed for kernel
> > test-systems, so its easy to get all KUnit tests enabled and if new gets
> > added they will be enable
results.
- 'parse': Parses test results from a file or stdin
The 'run' command continues to behave as before.
Signed-off-by: David Gow
Reviewed-by: Brendan Higgins
---
Changes since the RFC[1]:
- Rebased on top of kselftest/kunit, adding support for --alltests and
--make
ST enabled and
disabled.
Note that, at present, it only tests the list_ types (not the
singly-linked hlist_), and does not yet test all of the
list_for_each_entry* macros (and some related things like
list_prepare_entry).
Signed-off-by: David Gow
---
v5 replaces the use of KUNIT_ASSERT_NOT_E
On Sat, Oct 19, 2019 at 1:27 AM Dan Carpenter wrote:
>
> On Fri, Oct 18, 2019 at 02:55:49PM -0700, David Gow wrote:
> > + list4 = kzalloc(sizeof(*list4), GFP_KERNEL);
> > + KUNIT_ASSERT_NOT_ERR_OR_NULL(test, list4);
>
> Why not just use GFP_KERNEL | GFP_NOFAIL and
ST enabled and
disabled.
Note that, at present, it only tests the list_ types (not the
singly-linked hlist_), and does not yet test all of the
list_for_each_entry* macros (and some related things like
list_prepare_entry).
Signed-off-by: David Gow
---
Addressed the various comments on v1. The bigg
PM Andrew Morton wrote:
>
> On Thu, 10 Oct 2019 11:56:31 -0700 David Gow wrote:
>
> > Reply-To: 20191007213633.92565-1-david...@google.com
>
> That's a bit irksome. Deliberate?
Whoops, this was supposed to be In-Reply-To. Please ignore it.
On Fri, Oct 11, 2019 at 2
On Tue, Apr 14, 2020 at 7:46 PM Vaittinen, Matti
wrote:
>
> Hello Stephen & All,
>
> Prologue:
>
> I have been traumatized in the past - by unit tests :) Thus I am always
> a bit jumpy when I see people adding UTs. I always see the inertia UTs
> add to development - when people change anything the
On Fri, Oct 11, 2019 at 2:55 PM Andrew Morton wrote:
>
> On Fri, 11 Oct 2019 14:37:25 -0700 David Gow wrote:
>
> > On Fri, Oct 11, 2019 at 2:05 PM Andrew Morton
> > wrote:
> > >
> > >
> > >
> > > Given that everything runs at late_initca
ST enabled and
disabled.
Note that, at present, it only tests the list_ types (not the
singly-linked hlist_), and does not yet test all of the
list_for_each_entry* macros (and some related things like
list_prepare_entry).
Signed-off-by: David Gow
---
Note: v2 can be found here:
https://lkml.org
ST enabled and
disabled.
Note that, at present, it only tests the list_ types (not the
singly-linked hlist_), and does not yet test all of the
list_for_each_entry* macros (and some related things like
list_prepare_entry).
Signed-off-by: David Gow
---
The changes from v3 are mostly to do with nam
On Sat, May 23, 2020 at 6:30 AM shuah wrote:
>
> On 5/3/20 4:09 AM, Alan Maguire wrote:
> > On Thu, 23 Apr 2020, David Gow wrote:
> >
> >> This patchset contains everything needed to integrate KASAN and KUnit.
> >>
> >> KUnit will be able to:
>
/202006141005.BA19A9D3@keescook/t/#u
Signed-off-by: David Gow
Reviewed-by: Kees Cook
---
This is a follow-up v1 to the RFC patch here:
https://lore.kernel.org/linux-kselftest/20200620054944.167330-1-david...@google.com/T/#u
There weren't any fundamental objections to the naming guidelines
thems
-by: David Gow
---
drivers/clk/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
index 69934c0c3dd8..326f91b2dda9 100644
--- a/drivers/clk/Kconfig
+++ b/drivers/clk/Kconfig
@@ -50,6 +50,7 @@ source "drivers/clk/versatile/Kconfig"
confi
on CONFIG_IOMEM.
Signed-off-by: David Gow
---
drivers/staging/clocking-wizard/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/clocking-wizard/Kconfig
b/drivers/staging/clocking-wizard/Kconfig
index 04be22dca9b6..69cf51445f08 100644
--- a/drivers
CONFIG_IOMEM.
Signed-off-by: David Gow
---
drivers/iio/adc/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
index ff3569635ce0..f5009b61b80c 100644
--- a/drivers/iio/adc/Kconfig
+++ b/drivers/iio/adc/Kconfig
@@ -263,6 +263,7 @@ config AD9467
1 - 100 of 313 matches
Mail list logo
