Re: [PATCH 1/2] vfio powerpc: implemented IOMMU driver for VFIO

2012-11-26 Thread David Gibson
platform dependent part includes IOMMU initialization > >>>>and handling. This patch implements an IOMMU driver for VFIO > >>>>which does mapping/unmapping pages for the guest IO and > >>>>provides information about DMA window (required by a POWERPC &g

Re: [PATCH] vfio powerpc: implement IOMMU driver for VFIO

2013-03-20 Thread David Gibson
dow (required by a POWERPC > > guest). > > > > The counterpart in QEMU is required to support this functionality. > > > > Changelog: > > * documentation updated > > * containter enable/disable ioctls added > > * request_module(spapr_iommu)

Re: [PATCH 6/6] OF: Introduce DT overlay support.

2013-01-24 Thread David Gibson
On Wed, Jan 23, 2013 at 01:01:58PM +0200, Pantelis Antoniou wrote: > On Jan 23, 2013, at 7:12 AM, David Gibson wrote: > > On Tue, Jan 22, 2013 at 01:08:04PM +0200, Pantelis Antoniou wrote: > >> Hi > >> > >> On Jan 22, 2013, at 5:50 AM, David Gibson wrote: >

Re: [PATCH] iommu: making IOMMU sysfs nodes API public

2013-02-24 Thread David Gibson
On Thu, Feb 21, 2013 at 09:11:13PM -0700, Alex Williamson wrote: > On Fri, 2013-02-22 at 11:04 +1100, David Gibson wrote: > > On Tue, Feb 19, 2013 at 01:11:51PM -0700, Alex Williamson wrote: > > > On Tue, 2013-02-19 at 18:38 +1100, David Gibson wrote: > > > > On M

orderly_poweroff() is no longer safe in atomic context

2013-02-26 Thread David Gibson
Specifically I can't make sense of: | The bug here is, step 1 is always successful with param | UMH_NO_WAIT, which obey the design goal of orderly_poweroff. And without understanding the original bug, I'm not sure what the correct fix is. -- David Gibson| I

Re: [PATCH] iommu: making IOMMU sysfs nodes API public

2013-02-18 Thread David Gibson
guest can use H_PUT_TCE directly, so that might be another place we could do the lock. > It also > has a flags field that could augment the behavior to trigger page > locking. I don't see how the flags help us - we can't have userspace choose to skip the locked memory account

Re: [PATCH] iommu: making IOMMU sysfs nodes API public

2013-02-21 Thread David Gibson
On Tue, Feb 19, 2013 at 01:11:51PM -0700, Alex Williamson wrote: > On Tue, 2013-02-19 at 18:38 +1100, David Gibson wrote: > > On Mon, Feb 18, 2013 at 10:24:00PM -0700, Alex Williamson wrote: > > > On Mon, 2013-02-18 at 17:15 +1100, Alexey Kardashevskiy wrote: [snip] > > &

Re: [PATCH v2 19/20] mm, hugetlb: retry if failed to allocate and there is concurrent user

2013-09-16 Thread David Gibson
On Thu, Sep 05, 2013 at 02:43:57PM +0900, Joonsoo Kim wrote: > Hello, David. > > First of all, thanks for review! > > On Thu, Sep 05, 2013 at 11:15:53AM +1000, David Gibson wrote: > > On Fri, Aug 09, 2013 at 06:26:37PM +0900, Joonsoo Kim wrote: > > > If parall

Re: "memory" binding issues

2013-09-17 Thread David Gibson
ut path names. > > 2.2.1.1 is talking about node names. > > 2.2.1.1 _does_ require the unit address in the node name, 2.2.3 does not > remove that requirement. Certainly the recommendation I've been giving from the early days of ePAPR has been that a node should have a unit add

Re: "memory" binding issues

2013-09-18 Thread David Gibson
; *FAIL:58 > * Bad configuration:136 > * Strange test result:0 > ** > > That's just in dtc itself, and not any of the *.dts in the kernel or > U-Boot source trees... Uh.. yeah. The trees in the dtc testsuite are rather contrived

Re: [dtc PATCH] Ensure all tests have matching reg and unit address

2013-09-19 Thread David Gibson
tic exercises without really considering dt content conventions. Fixing them up is arguably unnnecessary, but certainly doesn't hurt and makes them better as examples. Applied and pushed. -- David Gibson| I'll have my music baroque, and my code david AT gibson.dropbe

Re: [dtc RFC PATCH] Enforce node name unit-address presence/absence

2013-09-19 Thread David Gibson
bus type... Yeah, I think that's the wrong approach. Instead I think we need a table of bus type -> unit address validation functions. That way we can start with the common ones - plain memory address, PCI, USB and I2C, then add more as we need them. I actually started

Re: [dtc RFC PATCH] Enforce node name unit-address presence/absence

2013-09-19 Thread David Gibson
node_name_chars); I'd prefer to see this implemented as a new check, rather than extending node_name_format. It will be a bit more verbose, but it keeps the low-level syntactic check seperate from the higher-level semantic / linting check. It also allows it to be configured as a warning seperat

Re: [dtc RFC PATCH] Enforce node name unit-address presence/absence

2013-09-19 Thread David Gibson
uilt specifically to allow linting inside the compiler - I just never had time to implement many checks beyond the basics. > Anyway, I think it'd be better to produce warnings than errors for > this. That way we could also merge it now while the trees are f

Re: [dtc PATCH] Ensure all tests have matching reg and unit address

2013-09-19 Thread David Gibson
On Thu, Sep 19, 2013 at 11:49:41AM -0600, Stephen Warren wrote: > On 09/19/2013 06:18 AM, David Gibson wrote: > > On Wed, Sep 18, 2013 at 02:23:02PM -0600, Stephen Warren wrote: > >> From: Stephen Warren > >> > >> ePAPR 1.1 section 2.2.1.1 "Node Name R

Re: [PATCH v2 19/20] mm, hugetlb: retry if failed to allocate and there is concurrent user

2013-09-04 Thread David Gibson
u already thought about the various race condition, > so I think that you are the most appropriate reviewer to this patch. :) Yeah, sorry, I meant to get to it but kept forgetting. I've sent a review now. -- David Gibson| I'll have my music baroque, and my c

Re: [PATCH v2 19/20] mm, hugetlb: retry if failed to allocate and there is concurrent user

2013-09-04 Thread David Gibson
spin_lock(&inode->i_lock); > inode->i_blocks += blocks_per_huge_page(h); > spin_unlock(&inode->i_lock); > } else { > lock_page(page); > + anon_rmap = 1; > if (unlikely(anon_

Re: [PATCH v10 2/3] DMA: Freescale: Add new 8-channel DMA engine device tree nodes

2013-09-25 Thread David Gibson
gt; definition of the reg property, and overly specific because it makes > assumptions about how the parent node's ranges are set up (sometimes we > want to be that specific, but usually not). To look at it another way, the format of the 'reg' property

Re: [dtc PATCH V2] Warn on node name unit-address presence/absence mismatch

2013-09-26 Thread David Gibson
rget that in real OFW land, the unit address is something > that's somewhat bus specific ... for example, PCI uses "dev,fn" rather > than the full 96-bit number of the "reg" entry :-) > > Another option which would more strictly conform to ePAPR

Re: dtc: import latest upstream dtc

2012-10-10 Thread David Gibson
ly suggest just using comments instead for C code. > > .h files include both structs and defines, which are fine for > ordinary C code, but problematic in this context. Right, cpp should be invoked with similar options to the way it's done for asm files which have the same problem. I&

Re: dtc: import latest upstream dtc

2012-10-10 Thread David Gibson
operation. > > Oh right. Well, the patch I proposed to the kernel was basically: > > %.dtb: %.dtsp > cpp -E $< | dtc -o $@ - > > A developer could run the same cpp -E command to find that out, or that > build rule could instead save

Re: dtc: import latest upstream dtc

2012-10-10 Thread David Gibson
On Wed, Oct 10, 2012 at 08:41:45AM -0600, Warner Losh wrote: > On Oct 10, 2012, at 1:24 AM, David Gibson wrote: > > On Tue, Oct 09, 2012 at 10:43:50PM -0600, Warner Losh wrote: [snip] > >> .h files include both structs and defines, which are fine for > >> ordinary C co

Re: dtc: import latest upstream dtc

2012-10-10 Thread David Gibson
programmers". That said, there are a number of number of dtc extensions that would make cpp-ability more useful. The integer expression support that has already gone in was a start on that, but richer expressions (particularly strings and bytestrings) would

Re: dtc: import latest upstream dtc

2012-10-10 Thread David Gibson
On Wed, Oct 10, 2012 at 10:33:31AM -0500, Rob Herring wrote: > On 10/10/2012 10:16 AM, Stephen Warren wrote: > > On 10/10/2012 01:24 AM, David Gibson wrote: > >> On Tue, Oct 09, 2012 at 10:43:50PM -0600, Warner Losh wrote: > >>> On Oct 9, 2012, at 6:04 PM, Scott

Re: dtc: import latest upstream dtc

2012-10-10 Thread David Gibson
id avoid C constructs. That can be done, but > I've personally experienced a lot of headaches when trying to share .h > files between different languages. Yes, but we already deal with that for asm files. And the sorts of defines we use in asm files are often the same ones we&

Re: dtc: import latest upstream dtc

2012-10-10 Thread David Gibson
On Wed, Oct 10, 2012 at 09:16:34AM -0600, Stephen Warren wrote: > On 10/10/2012 01:24 AM, David Gibson wrote: > > On Tue, Oct 09, 2012 at 10:43:50PM -0600, Warner Losh wrote: [snip] > >> .h files include both structs and defines, which are fine for > >> ordinary C co

Re: [RFC] Device Tree Overlays Proposal (Was Re: capebus moving omap_devices to mach-omap2)

2012-11-12 Thread David Gibson
On Fri, Nov 09, 2012 at 09:08:14PM +, Grant Likely wrote: > On Fri, Nov 9, 2012 at 2:26 AM, David Gibson > wrote: > >> Summary points: > >> - Create an FDT overlay data format and usage model > >> - SHALL reliable resolve or validate of phandles betwee

Re: [RFC] Device Tree Overlays Proposal (Was Re: capebus moving omap_devices to mach-omap2)

2012-11-12 Thread David Gibson
bubble up to this socket node where the > > interrupt-map will send them to the right places. > > > > I don't recall the gpio bindings off hand, but as I recall we based > > them off the irq tree bindings so we ought to be able to do the same > > thing

Re: [RFC] Device Tree Overlays Proposal (Was Re: capebus moving omap_devices to mach-omap2)

2012-11-12 Thread David Gibson
On Fri, Nov 09, 2012 at 09:42:37PM +, Grant Likely wrote: > On Fri, Nov 9, 2012 at 2:26 AM, David Gibson > wrote: > > (3) Resolving phandle references from the subtree to the main tree. > > > > So, I think this can actually be avoided, at least in cases where what >

Re: [RFC] Device Tree Overlays Proposal (Was Re: capebus moving omap_devices to mach-omap2)

2012-11-12 Thread David Gibson
>> affect nodes in dtb being moved around since they will still have the > >> same index value. the problem being adding or removing nodes Changes > >> the offsets of all other nodes in the string block as well.. Hmm. > >> > > > > This is pretty radical cha

Re: [RFC] Device Tree Overlays Proposal (Was Re: capebus moving omap_devices to mach-omap2)

2012-11-12 Thread David Gibson
erlays from there... Well, it does mean we'd need dtc in the initrd. But dtc has no library dependencies except libc, so that really shouldn't be too bad. In return we entirely avoid inventing a new phandle resolution protocol. -- David Gibson| I'll have

Re: [RFC] Device Tree Overlays Proposal (Was Re: capebus moving omap_devices to mach-omap2)

2012-11-12 Thread David Gibson
On Mon, Nov 12, 2012 at 10:22:07PM -0700, Stephen Warren wrote: > On 11/12/2012 06:05 PM, David Gibson wrote: > > On Fri, Nov 09, 2012 at 09:42:37PM +, Grant Likely wrote: > ... > > 2) graft bundle > > > > The base tree has something like this: &g

Re: [RFC] Device Tree Overlays Proposal (Was Re: capebus moving omap_devices to mach-omap2)

2012-11-13 Thread David Gibson
On Tue, Nov 13, 2012 at 10:09:28AM +0200, Pantelis Antoniou wrote: > Hi David, > > On Nov 13, 2012, at 9:25 AM, David Gibson wrote: > > > On Mon, Nov 12, 2012 at 09:52:32AM -0700, Stephen Warren wrote: > >> On 11/12/2012 05:10 AM, Pantelis Antoniou wrote: > > [s

Re: [RFC] Device Tree Overlays Proposal (Was Re: capebus moving omap_devices to mach-omap2)

2012-11-14 Thread David Gibson
es should be described explicitly - using existing OF mechanisms like interrupt-map where possible, rather than having a very general, but very low-level interface to make arbitrary changes to the DT. -- David Gibson| I'll have my music baroque, and my code david AT gibson.d

Re: [RFC] Device Tree Overlays Proposal (Was Re: capebus moving omap_devices to mach-omap2)

2012-11-08 Thread David Gibson
bindings off hand, but as I recall we based them off the irq tree bindings so we ought to be able to do the same thing for them. Likewise, if there are several interchangeable expansion sockets that have some address bits hard wired to distinguish them, we can just use socket local mmio address

Re: [RFC] Device Tree Overlays Proposal (Was Re: capebus moving omap_devices to mach-omap2)

2012-11-09 Thread David Gibson
any case only property names use the strings block, not node names. > and store phandle as index of the node name > referenced relative to the starting of the strong block. This will not > affect nodes in dtb being moved around since they will still have th

Re: fdtdump: properly handle multi-string properties

2013-01-04 Thread David Gibson
On Fri, Jan 04, 2013 at 09:12:46PM +0200, Pantelis Antoniou wrote: > Device tree can store multiple strings in a single property. > We didn't handle that case properly. > > Signed-off-by: Pantelis Antoniou Acked-by: David Gibson -- David Gibson| I'll

Re: Fix util_is_printable_string

2013-01-05 Thread David Gibson
sure it's doing the right thing, but if you're not already familiar with the OF multi-string convention, it would be easy to get confused by the code. Other than that Acked-by: David Gibson -- David Gibson| I'll have my music baroque, and my code david AT g

Re: [PATCH 3/4] KVM: PPC: Add support for IOMMU in-kernel handling

2013-06-19 Thread David Gibson
return -EINVAL; > > > > > > if (!atomic_inc_not_zero(&group->container_users)) > > return -EINVAL; > > > > return 0; > > } > > > > void vfio_group_del_external_user(struct file *filep) > > { > > struct v

Re: [PATCH V2] dtc: ensure #line directives don't consume data from the next line

2013-05-31 Thread David Gibson
stances should be > irrelevant for any well-formed #line directive. This is done for > consistency and ultimate safety. > > Reported-by: Ian Campbell > Signed-off-by: Stephen Warren Nice catch. Acked-by: David Gibson I'll pull it into my github tree. Jon

Re: [PATCH 3/4] KVM: PPC: Add support for IOMMU in-kernel handling

2013-06-22 Thread David Gibson
On Thu, Jun 20, 2013 at 08:55:13AM -0600, Alex Williamson wrote: > On Thu, 2013-06-20 at 18:48 +1000, Alexey Kardashevskiy wrote: > > On 06/20/2013 05:47 PM, Benjamin Herrenschmidt wrote: > > > On Thu, 2013-06-20 at 15:28 +1000, David Gibson wrote: > > >>>

Re: [PATCH 3/4] KVM: PPC: Add support for IOMMU in-kernel handling

2013-06-23 Thread David Gibson
On Sun, Jun 23, 2013 at 09:28:13AM +1000, Benjamin Herrenschmidt wrote: > On Sat, 2013-06-22 at 22:03 +1000, David Gibson wrote: > > I think the interface should not take the group fd, but the container > > fd. Holding a reference to *that* would keep the necessary things > >

Re: [PATCH 3/4] KVM: PPC: Add support for IOMMU in-kernel handling

2013-06-23 Thread David Gibson
On Sat, Jun 22, 2013 at 08:28:06AM -0600, Alex Williamson wrote: > On Sat, 2013-06-22 at 22:03 +1000, David Gibson wrote: > > On Thu, Jun 20, 2013 at 08:55:13AM -0600, Alex Williamson wrote: > > > On Thu, 2013-06-20 at 18:48 +1000, Alexey Kardashevskiy wrote: > > &g

Re: [PATCH 3/4] KVM: PPC: Add support for IOMMU in-kernel handling

2013-06-27 Thread David Gibson
On Sun, Jun 23, 2013 at 10:41:24PM -0600, Alex Williamson wrote: > On Mon, 2013-06-24 at 13:52 +1000, David Gibson wrote: > > On Sat, Jun 22, 2013 at 08:28:06AM -0600, Alex Williamson wrote: > > > On Sat, 2013-06-22 at 22:03 +1000, David Gibson wrote: > > > > On T

Re: [PATCH] vfio powerpc: implement IOMMU driver for VFIO

2013-03-24 Thread David Gibson
On Wed, Mar 20, 2013 at 09:16:24PM -0600, Alex Williamson wrote: > On Thu, 2013-03-21 at 12:55 +1100, David Gibson wrote: > > On Wed, Mar 20, 2013 at 02:45:24PM -0600, Alex Williamson wrote: > > > On Tue, 2013-03-19 at 18:08 +1100, Alexey Kardashevskiy wrote: > > >

Re: [PATCH] mm/hugetlb: per-vma instantiation mutexes

2013-07-15 Thread David Gibson
On Sun, Jul 14, 2013 at 08:16:44PM -0700, Davidlohr Bueso wrote: > On Fri, 2013-07-12 at 17:54 -0700, Hugh Dickins wrote: > > Adding the essential David Gibson to the Cc list. > > > > On Fri, 12 Jul 2013, Davidlohr Bueso wrote: > > > > > The hugetlb_ins

Re: [PATCH] mm/hugetlb: per-vma instantiation mutexes

2013-07-16 Thread David Gibson
On Mon, Jul 15, 2013 at 05:12:31PM -0700, Davidlohr Bueso wrote: > On Mon, 2013-07-15 at 16:08 -0700, Andrew Morton wrote: > > On Mon, 15 Jul 2013 17:24:32 +1000 David Gibson > > wrote: > > > > > I have previously proposed a correct method of improving scalabil

Re: [PATCH] mm/hugetlb: per-vma instantiation mutexes

2013-07-16 Thread David Gibson
On Mon, Jul 15, 2013 at 09:51:21PM -0400, Rik van Riel wrote: > On 07/15/2013 03:24 AM, David Gibson wrote: > >On Sun, Jul 14, 2013 at 08:16:44PM -0700, Davidlohr Bueso wrote: > > >>>Reading the existing comment, this change looks very suspicious to me. > >>>

Re: [PATCH] mm/hugetlb: per-vma instantiation mutexes

2013-07-16 Thread David Gibson
On Tue, Jul 16, 2013 at 02:34:24PM +0900, Joonsoo Kim wrote: > On Mon, Jul 15, 2013 at 09:51:21PM -0400, Rik van Riel wrote: > > On 07/15/2013 03:24 AM, David Gibson wrote: > > >On Sun, Jul 14, 2013 at 08:16:44PM -0700, Davidlohr Bueso wrote: > > > > >>>Re

Re: [Ksummit-2013-discuss] DT bindings as ABI [was: Do we have people interested in device tree janitoring / cleanup?]

2013-07-27 Thread David Gibson
ng "schemas" as such for bindings), simply because no-one's implemented it yet. > That way, if you want to make changes such as that above, you need to > get it past not only kernel people but also past dtc maintainers - > which increases the chances

Re: [Ksummit-2013-discuss] DT bindings as ABI [was: Do we have people interested in device tree janitoring / cleanup?]

2013-07-27 Thread David Gibson
as it's possible to support old, badly-thought out syscalls with a compat shim over newer implementations, we can in many cases localize handling of bad device tree bindings to early boot code, so that old bad ideas don't have to infect every part of every driver. It would probably be a goo

Re: [Ksummit-2013-discuss] DT bindings as ABI [was: Do we have people interested in device tree janitoring / cleanup?]

2013-07-28 Thread David Gibson
when there is a good one available. I think it's more likely that people will create, and get right, a well localized bit of quirk code, than they will get backwards compat code correct for every place in which a driver wants info from the device tree. -- David Gibson

Re: [PATCH 17/18] mm, hugetlb: retry if we fail to allocate a hugepage with use_reserve

2013-07-29 Thread David Gibson
IS_ERR(page)) { > - ret = VM_FAULT_SIGBUS; > + if (use_reserve) > + ret = 0; > + else > + ret = VM_FAULT_SIGBUS; > goto out; >

Re: [Ksummit-2013-discuss] DT bindings as ABI [was: Do we have people interested in device tree janitoring / cleanup?]

2013-07-29 Thread David Gibson
d kernel, while full featured firmware should > keep them seperate. IMHO that should be the clear message to people > implementing this stuff. > > After enough time the DT for 'a' should become stable and churn free, > but expecting/demanding that f

Re: [Ksummit-2013-discuss] Defining schemas for Device Tree

2013-07-29 Thread David Gibson
gt; can read. After all, C requires functions to be declared before use, > even though the compiler could figure it out. It's not necessarily possible to encode device initialization order in flattened tree order. Suppose you have bus A with devices A1 and A2, and bus B with devices B1 a

Re: [PATCH v3 6/9] mm, hugetlb: do not use a page in page cache for cow optimization

2013-07-29 Thread David Gibson
tdout, "AFTER STEAL PRIVATE WRITE: %c\n", p[0]); > munmap(p, size); > > We can see that "AFTER STEAL PRIVATE WRITE: c", not "AFTER STEAL > PRIVATE WRITE: s". If we turn off this optimization to a page > in page cache, the problem is disappeared.

Re: [Ksummit-2013-discuss] Defining schemas for Device Tree

2013-07-29 Thread David Gibson
On Mon, Jul 29, 2013 at 06:48:40PM -0400, Jason Cooper wrote: > On Tue, Jul 30, 2013 at 08:29:20AM +1000, David Gibson wrote: > > On Mon, Jul 29, 2013 at 01:23:39PM -0400, Jason Cooper wrote: > > > On Mon, Jul 29, 2013 at 05:49:05PM +0100, Dave Martin wrote: > > > >

Re: [Ksummit-2013-discuss] DT bindings as ABI [was: Do we have people interested in device tree janitoring / cleanup?]

2013-07-29 Thread David Gibson
On Mon, Jul 29, 2013 at 05:14:25PM -0600, Jason Gunthorpe wrote: > On Tue, Jul 30, 2013 at 08:20:39AM +1000, David Gibson wrote: > > > > Clearly general purpose systems (eg servers, workstations, etc) with > > > *full featured firmware* fall into category b. Linux alr

Re: [Ksummit-2013-discuss] DT bindings as ABI [was: Do we have people interested in device tree janitoring / cleanup?]

2013-07-29 Thread David Gibson
a more convenient schema language (just as we wanted dts, rather than manually constructing FDTs as C structures). But I absolutely do think, that the schema handling should be handled as plugins to the checks mechanism - basically we'd have a validate_schemas() check function.

Re: [Ksummit-2013-discuss] Defining schemas for Device Tree

2013-07-29 Thread David Gibson
order as the original .dts file. > > That's why I raised the point. If people think encoding initialization > order in the DT is a good idea, then we should change the dtc so it > compiles/decompiles in the same order. I'm not actually sure what you mean by this. dtc alread

Re: [Ksummit-2013-discuss] DT bindings as ABI [was: Do we have people interested in device tree janitoring / cleanup?]

2013-07-29 Thread David Gibson
On Mon, Jul 29, 2013 at 10:15:12PM -0400, jonsm...@gmail.com wrote: > On Mon, Jul 29, 2013 at 9:44 PM, David Gibson > wrote: > > On Sat, Jul 27, 2013 at 10:11:16PM -0700, James Bottomley wrote: > >> On Sat, 2013-07-27 at 21:28 -0600, Grant Likely wrote: > >> >

Re: [Ksummit-2013-discuss] DT bindings as ABI [was: Do we have people interested in device tree janitoring / cleanup?]

2013-08-01 Thread David Gibson
le to get > rid of the board specific code. But x86 doesn't have any of it, why > should ARM? Sure x86 has board specific code. It's just that x86 basically only has one board - PC. -- David Gibson| I'll have my music baroque, and my code david AT gibson.

Re: [PATCH 17/18] mm, hugetlb: retry if we fail to allocate a hugepage with use_reserve

2013-08-04 Thread David Gibson
On Wed, Jul 31, 2013 at 02:37:53PM +0900, Joonsoo Kim wrote: > Hello, David. > > On Mon, Jul 29, 2013 at 05:28:23PM +1000, David Gibson wrote: > > On Mon, Jul 29, 2013 at 02:32:08PM +0900, Joonsoo Kim wrote: > > > If parallel fault occur, we can fail to allocate a huge

Re: [PATCH 17/18] mm, hugetlb: retry if we fail to allocate a hugepage with use_reserve

2013-08-06 Thread David Gibson
ain there aren't a few edge cases which can lead to even reserved mappings failing, and if that happens the patches will lead to livelock. Getting rid of the instantiation mutex is a lot harder than it appears. -- David Gibson| I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson pgpPMVwQ7MQlq.pgp Description: PGP signature

Re: [PATCH 17/18] mm, hugetlb: retry if we fail to allocate a hugepage with use_reserve

2013-08-08 Thread David Gibson
On Wed, Aug 07, 2013 at 06:18:32PM +0900, Joonsoo Kim wrote: > On Tue, Aug 06, 2013 at 06:38:49PM -0700, Davidlohr Bueso wrote: > > On Wed, 2013-08-07 at 11:03 +1000, David Gibson wrote: > > > On Tue, Aug 06, 2013 at 05:18:44PM -0700, Davidlohr Bueso wrote: > > > &g

Re: [PATCH] hugepage: allow parallelization of the hugepage fault path

2013-07-19 Thread David Gibson
On Thu, Jul 18, 2013 at 05:42:35PM +0900, Joonsoo Kim wrote: > On Wed, Jul 17, 2013 at 12:50:25PM -0700, Davidlohr Bueso wrote: > > From: David Gibson > > > > At present, the page fault path for hugepages is serialized by a > > single mutex. This is used to a

Re: The future of DT binding maintainership

2013-07-21 Thread David Gibson
ly linked and that all that matters is that a specific dts works with its corresponding kernel and vice versa, rather than fdts being the general description they're supposed to be. Not that I have much in the way of better ideas. -- David Gibson| I'll have my music b

Re: [PATCH 3/3] MAINTAINERS: Refactor device tree maintainership

2013-07-21 Thread David Gibson
ps it is time to also place the official repo > of the Device Tree Compiler on git,kernel.org as well? Sounds good to me. Now that I'm no longer at IBM, and don't have the associated complications with their Legal department, I'd rather like to resume having direct commit access to the

Re: [PATCH 3/4] KVM: PPC: Add support for IOMMU in-kernel handling

2013-05-24 Thread David Gibson
CE_ATTR _IOW(KVMIO, 0xe3, struct > >kvm_device_attr) > > > >+/* ioctl for SPAPR TCE IOMMU */ > >+#define KVM_CREATE_SPAPR_TCE_IOMMU _IOW(KVMIO, 0xe4, struct > >kvm_create_spapr_tce_iommu) > > Shouldn't this go under the vm ioctl section? > > -Scott > __

Re: [PATCH 5/6] OF: Introduce Device Tree resolve support.

2013-01-20 Thread David Gibson
> + __func__, (char *)rprop->value); > + kfree(propval); > + err = -ENOENT; > + goto err_fail; > + } > + > + /* now f

Re: [PATCH 6/6] OF: Introduce DT overlay support.

2013-01-21 Thread David Gibson
is loaded the device will be created as expected. Hrm. This all seems rather complicated. Maybe it needs to be, but I'm not entirely convinced yet. One other point - both of these patches are assuming that the overlay is in the "live tree" format, but it still needs a bunch of extra mangling. Would it simplify things to just go straight from the overlay in flat tree form to modifications to the system-wide live tree. -- David Gibson| I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson signature.asc Description: Digital signature

Re: [PATCH 5/6] OF: Introduce Device Tree resolve support.

2013-01-21 Thread David Gibson
On Mon, Jan 21, 2013 at 12:59:15PM +0200, Pantelis Antoniou wrote: > Hi David > > On Jan 21, 2013, at 6:48 AM, David Gibson wrote: > > > On Fri, Jan 04, 2013 at 09:31:09PM +0200, Pantelis Antoniou wrote: > >> Introduce support for dynamic device tree resolution. >

Re: [PATCH 5/6] OF: Introduce Device Tree resolve support.

2013-01-22 Thread David Gibson
On Tue, Jan 22, 2013 at 01:06:09PM +0200, Pantelis Antoniou wrote: > Hi > > On Jan 22, 2013, at 6:05 AM, David Gibson wrote: > > > On Mon, Jan 21, 2013 at 12:59:15PM +0200, Pantelis Antoniou wrote: > >> Hi David > >> > >> On Jan 21, 2013, at 6:48 AM

Re: [PATCH 6/6] OF: Introduce DT overlay support.

2013-01-22 Thread David Gibson
On Tue, Jan 22, 2013 at 01:08:04PM +0200, Pantelis Antoniou wrote: > Hi > > On Jan 22, 2013, at 5:50 AM, David Gibson wrote: > > > On Fri, Jan 04, 2013 at 09:31:10PM +0200, Pantelis Antoniou wrote: > >> Introduce DT overlay support. > >> Using this functio

Re: dtc: import latest upstream dtc

2012-10-10 Thread David Gibson
On Wed, Oct 10, 2012 at 03:42:33PM -1000, Mitch Bradley wrote: > On 10/10/2012 1:16 PM, David Gibson wrote: > > On Wed, Oct 10, 2012 at 10:33:31AM -0500, Rob Herring wrote: > >> On 10/10/2012 10:16 AM, Stephen Warren wrote: > >>> On 10/10/2012 01:24 AM, David Gibso

Re: dtc: import latest upstream dtc

2012-10-12 Thread David Gibson
On Fri, Oct 12, 2012 at 11:24:43AM -0600, Stephen Warren wrote: > On 10/10/2012 05:18 PM, David Gibson wrote: > ... > > And as stated elsewhere, cpp should be invoked with similar options to > > the way it's done for asm files. A -D__DTS__ or something like that > >

Re: dtc: import latest upstream dtc

2012-10-14 Thread David Gibson
7;t think > this is exactly what matters for DTS, or does it ever happen that > you have a # preceded only by whitespace? Uh.. pretty much whenever you define a #address-cells or #size-cells property. At least until Stephen's patch to allow escaping that. > The # and ##

Re: Fix test relying in wrong behavior of is_printable

2013-01-05 Thread David Gibson
dName MyBoardFamilyName" -t s $dtb / compatible > run_fdtget_test 32768 $dtb /cpus/PowerPC,970@1 d-cache-size > run_fdtget_test 8000 -tx $dtb /cpus/PowerPC,970@1 d-cache-size -- David Gibson| I'll have my music baroque, and my code david AT gibson.d

Re: Fix test relying in wrong behavior of is_printable

2013-01-08 Thread David Gibson
On Sun, Jan 06, 2013 at 01:41:56PM +0200, Pantelis Antoniou wrote: > Hi David > > Από το iPhone μου > > 6 Ιαν 2013, 5:58, ο/η David Gibson έγραψε: > > > On Fri, Jan 04, 2013 at 09:16:08PM +0200, Pantelis Antoniou wrote: > >> After fixing the is_printable bug

Alternative driver for Lucent 802.11 cards

2001-02-27 Thread David Gibson
care.com.au/dgibson/dldwd/ How to build and install the driver is left as an exercise to the reader. -- David Gibson, Technical Support Engineer, Linuxcare, Inc. +61 2 6262 8990 [EMAIL PROTECTED] http://www.linuxcare.com/ Linuxcare. Putting open source to work. - To unsubscribe from this list: se

ramfs limits (again)

2000-11-21 Thread David Gibson
c). As a result, it now works with recent kernels (tested, although not exhaustively, against test11). There still seems to be a problem where sometimes the ramfs gets into a state where it can't be unmounted (EBUSY). I have no idea what triggers this as yet.. -- David Gibson, Techni

Compile bugfix for ramfs limits

2000-11-19 Thread David Gibson
Oops.. not . The patch below implements resource limits for ramfs, and unlike the previous version actually compiles. -- David Gibson, Technical Support Engineer, Linuxcare, Inc. +61 2 6262 8990 [EMAIL PROTECTED], http://www.linuxcare.com/ Linuxcare. Support for the revolution. diff -uNr

Re: RAMFS ressource limits

2000-10-09 Thread David Gibson
bout it ;-) That would be mine: http://www.linuxcare.com.au/dgibson/dwg-ramfs.patch I haven't really tested it since test8, but it applies cleanly to test9 and test10-pre1, and I haven't noticed anything that would break it. -- David Gibson, Technical Support Engineer, Linuxcare, I

Re: RFC: Hugepage COW

2005-07-14 Thread David Gibson
On Thu, Jul 14, 2005 at 10:24:33AM -0700, Christoph Lameter wrote: > On Thu, 7 Jul 2005, David Gibson wrote: > > > Now that the hugepage code has been consolidated across the > > architectures, it becomes much easier to implement copy-on-write. > > Hugepage COW is of l

Re: RFC: Hugepage COW

2005-07-14 Thread David Gibson
On Thu, Jul 14, 2005 at 07:00:11PM -0700, Christoph Lameter wrote: > On Fri, 15 Jul 2005, David Gibson wrote: > > > Well, the COW patch implements a fault handler, obviously. What > > specifically where you thinking about? > > About a fault handler of course and about

[PPC64] Dynamically allocate segment tables

2005-07-21 Thread David Gibson
RS64 iSeries, POWER3 pSeries, and POWER5. Signed-off-by: David Gibson <[EMAIL PROTECTED]> Index: working-2.6/arch/ppc64/kernel/head.S === --- working-2.6.orig/arch/ppc64/kernel/head.S 2005-07-14 10:57:49.0 +1000 +++

[PPC64] Remove another fixed address constraint

2005-07-24 Thread David Gibson
whole the result is cleaner than before. Signed-off-by: David Gibson <[EMAIL PROTECTED]> Index: working-2.6/include/asm-ppc64/iSeries/LparMap.h === --- working-2.6.orig/include/asm-ppc64/iSeries/LparMap.h2005-0

[PATCH] Fix hugepage crash on failing mmap()

2005-08-05 Thread David Gibson
clean up any partial mapping. Depending on the hugepage configuration, this crash can be triggered by an unpriveleged user. Signed-off-by: David Gibson <[EMAIL PROTECTED]> Index: working-2.6/mm/hugetlb.c === --- working-2.6.o

[PATCH] Fix function/macro name collision on i386 oprofile

2005-08-09 Thread David Gibson
ectly) adds a #include of hardirq.h to oprofile. Regardless, the name collision is probably not a good idea, so this patch fixes it, renaming the oprofile function to op_nmi_exit(). It also renames the nmi_init() and nmi_timer_init() functions similarly, for consistency. Signed-off-by: David G

RFC: Hugepage COW

2005-07-06 Thread David Gibson
g-2.6.orig/fs/hugetlbfs/inode.c 2005-06-23 10:10:30.0 +1000 +++ working-2.6/fs/hugetlbfs/inode.c2005-06-23 11:28:54.0 +1000 @@ -52,9 +52,6 @@ loff_t len, vma_len; int ret; - if ((vma->vm_flags & (VM_MAYSHARE | VM_WRITE)) == VM_WRITE) -

Re: RFC: Hugepage COW

2005-07-07 Thread David Gibson
On Thu, Jul 07, 2005 at 09:49:27AM +0300, Avi Kivity wrote: > On Thu, 2005-07-07 at 15:55 +1000, David Gibson wrote: > > > MAP_PRIVATE|MAP_WRITE mappings of hugetlbfs. Because the pool of > > hugepages is limited, a write to a MAP_PRIVATE hugepage region may > > resu

Re: RFC: Hugepage COW

2005-07-07 Thread David Gibson
On Thu, Jul 07, 2005 at 10:53:25PM +1000, Stephen Rothwell wrote: > On Thu, 7 Jul 2005 19:24:25 +1000 David Gibson <[EMAIL PROTECTED]> wrote: > > > > That's not necessarily possible. On some archs - ppc64 for one - > > the mmu has to be set up for hugepages on a

[PPC64] Kill bitfields in ppc64 hash code

2005-07-07 Thread David Gibson
Andrew, please apply: This patch removes the use of bitfield types from the ppc64 hash table manipulation code. Signed-off-by: David Gibson <[EMAIL PROTECTED]> arch/ppc64/kernel/iSeries_htab.c | 50 + arch/ppc64/kernel/pSeries_lpar.c | 49 arch/pp

Re: [PPC64] Kill bitfields in ppc64 hash code

2005-07-07 Thread David Gibson
On Fri, Jul 08, 2005 at 02:46:54PM +1000, David Gibson wrote: > Andrew, please apply: Ahem. Or perhaps the version which builds on iSeries too. This patch removes the use of bitfield types from the ppc64 hash table manipulation code. Signed-off-by: David Gibson <[EMAIL PROTECTED]&g

[PPC64] Remove nested feature sections

2005-07-26 Thread David Gibson
using to someone reading the code. This patch removes the nested ifset and ifclr feature sections, replacing them with a single feature section in the full mask/value form. Signed-off-by: David Gibson <[EMAIL PROTECTED]> Index: working-2.6/arch/ppc64/mm

Re: [PPC64] Remove another fixed address constraint

2005-07-31 Thread David Gibson
On Mon, Aug 01, 2005 at 08:29:29AM +0200, Olaf Hering wrote: > On Mon, Jul 25, David Gibson wrote: > > > Presently the LparMap, one of the structures the kernel shares with > > the legacy iSeries hypervisor has a fixed offset address in head.S. > > This patch changes

Re: [PPC64] Remove another fixed address constraint

2005-08-01 Thread David Gibson
On Mon, Aug 01, 2005 at 08:45:02AM +0200, Olaf Hering wrote: > On Mon, Aug 01, David Gibson wrote: > > > Hrm.. definitely works here. Is this with any other patches? Can you > > send the .s file? That might help be debug it. > > It works with SLES9 gcc3, only gcc4 (or

Re: [Perfctr-devel] new perfmon2 kernel patch available

2005-09-05 Thread David Gibson
xt + .llong .sys_pfm_create_context /* 281 */ + .llong .sys_pfm_write_pmcs + .llong .sys_pfm_write_pmds + .llong .sys_pfm_read_pmds + .llong .sys_pfm_load_context/* 285 * + .llong .sys_pfm_start + .llong .sys_pfm_stop +

Re: [PATCHv3] powerpc: DBox2 Board Support

2008-01-03 Thread David Gibson
or creating a > backup of everything. OpenWRT also uses overlapping partitions BTW > (and also for flashing updates). Heh. Wow. Safely? i.e. if you access one partition then later an overlapping partition, is mtd guaranteed to get the necessary synchronization right? -- David Gibson

Re: [PATCHv3] powerpc: DBox2 Board Support

2008-01-02 Thread David Gibson
ill not be pretty... > + label = "Flash without bootloader"; > + reg = <2 7e>; > + }; > + [EMAIL PROTECTED] { > + label = "Complete Flash&qu

  1   2   3   4   5   >