On Thu, Nov 22, 2012 at 10:12:40AM +0100, Jan Kara wrote:
> On Wed 21-11-12 17:47:55, Darrick J. Wong wrote:
> > On Thu, Nov 22, 2012 at 08:47:13AM +1100, NeilBrown wrote:
> > > On Wed, 21 Nov 2012 22:33:33 +0100 Jan Kara wrote:
> > >
> > > > On Wed 2
he rest of the DIF setup.
Right now, the SCSI layer "promotes" a DIF type 0 disk into a DIF type 1 disk,
which seems incorrect.
Signed-off-by: Darrick J. Wong
---
drivers/scsi/sd_dif.c |4
1 file changed, 4 insertions(+)
diff --git a/drivers/scsi/sd_dif.c b/drivers/scsi/sd
On Mon, Mar 18, 2013 at 06:41:34PM +0100, Jan Kara wrote:
> On Fri 15-03-13 16:28:16, Darrick J. Wong wrote:
> > Walking a bio's page mappings has proved problematic, so create a new bio
> > flag
> > to indicate that a bio's data needs to be snapshotted in orde
ed without
PG_writeback set, and set BIO_SNAP_STABLE there. We must also flag journal
"metadata" bios for stable writeout, since file data can be written through the
journal. Finally, the MS_SNAP_STABLE mount flag (only used by ext3) is now
superfluous, so get rid of it.
Signed-off
On Mon, Feb 04, 2013 at 02:40:17PM +, thorn...@redhat.com wrote:
> On Fri, Feb 01, 2013 at 04:44:59PM -0800, Darrick J. Wong wrote:
> > I will start reviewing the code as soon as this patch posts. Be warned
> > that I
> > haven't even compile tested this yet.
tream for 3.9... except this piece. Are you
interested in having this piece in 3.9 also? Or is 3.10 good enough for
everyone?
--D
Mon, Mar 18, 2013 at 04:02:59PM -0700, Darrick J. Wong wrote:
> Walking a bio's page mappings has proved problematic, so create a new bio flag
> to indic
On Mon, Jan 28, 2013 at 03:27:38PM -0800, David Lang wrote:
> On Mon, 28 Jan 2013, Theodore Ts'o wrote:
>
> >On Sun, Jan 27, 2013 at 10:13:37PM -0800, Daniel Phillips wrote:
> >>>The thing that jumps out at me with this is the question of how you will
> >>>avoid the 'filesystem image in a file' di
ther comments we'll have about the source code.
> On Fri, Feb 1, 2013 at 5:23 PM, Kent Overstreet
> wrote:
> > On Fri, Feb 1, 2013 at 4:57 PM, Michel Lespinasse wrote:
> >> On Fri, Feb 1, 2013 at 4:44 PM, Darrick J. Wong
> >> wrote:
> >>> This is a
On Sat, Jan 26, 2013 at 01:39:46PM +0100, Sedat Dilek wrote:
> Hi Darrick,
>
> can you tell me why you do not put your help text where it normally
> belongs ("help" Kconfig item)?
Sure -- the non-ISA bounce pool is only used by a small number of specific
parts of the kernel that require it. If t
On Mon, Feb 18, 2013 at 05:42:38PM +0800, Sanoj Unnikrishnan wrote:
> > -Original Message-
> > From: Darrick J. Wong [mailto:darrick.w...@oracle.com]
> > Sent: Saturday, February 16, 2013 2:02 AM
> > To: OS Engineering
> > Cc: Greg Kroah-Hartman; LKML; Jens
On Wed, Jan 23, 2013 at 01:43:12PM -0800, Andrew Morton wrote:
> On Fri, 18 Jan 2013 17:13:16 -0800
> "Darrick J. Wong" wrote:
>
> > When stable pages are required, we have to wait if the page is just
> > going to disk and we want to modify it. Add proper callba
On Thu, Feb 21, 2013 at 02:32:43PM -0800, Andrew Morton wrote:
> On Wed, 20 Feb 2013 19:48:34 -0800
> "Darrick J. Wong" wrote:
>
> > > I grabbed the patches. They should appear in linux-next tomorrow if I
> > > can get the current pooppile to build.
>
ge that can tell us
MS_SNAP_STABLE is set, since we probably won't need the bounce buffer anyway.
How does something like this look? (+ the patch above)
--D
Subject: [PATCH] mm: Don't blow up on slab pages being written to disk
Don't assume that all pages attached to a bio
On Wed, Mar 13, 2013 at 09:50:21AM +0100, Jan Kara wrote:
> On Tue 12-03-13 18:10:20, Darrick J. Wong wrote:
> > On Tue, Mar 12, 2013 at 03:32:21PM -0700, Andrew Morton wrote:
> > > On Fri, 08 Mar 2013 20:37:36 +0800 Shuge wrote:
> > >
> > > > The bounce
On Wed, Mar 13, 2013 at 10:02:16PM +0100, Jan Kara wrote:
> On Wed 13-03-13 12:44:29, Darrick J. Wong wrote:
> > On Wed, Mar 13, 2013 at 09:50:21AM +0100, Jan Kara wrote:
> > > On Tue 12-03-13 18:10:20, Darrick J. Wong wrote:
> > > > On Tue, Mar 12, 2013 at 03:32:2
On Thu, Mar 14, 2013 at 03:46:51PM -0700, Andrew Morton wrote:
> On Wed, 13 Mar 2013 22:02:16 +0100 Jan Kara wrote:
>
> > > > ... remembering why we need to get to sb and why ext3 needs this ... So
> > > > maybe a better solution would be to have a bio flag meaning that pages
> > > > need
> > >
On Fri, Mar 15, 2013 at 11:01:05AM +0100, Jan Kara wrote:
> On Thu 14-03-13 15:42:43, Darrick J. Wong wrote:
> > On Wed, Mar 13, 2013 at 10:02:16PM +0100, Jan Kara wrote:
> > > On Wed 13-03-13 12:44:29, Darrick J. Wong wrote:
> > > > On Wed, Mar 13, 2013 at 09
ed without
PG_writeback set, and set BIO_SNAP_STABLE there. We must also flag journal
"metadata" bios for stable writeout if data=journal, since file data is written
through the journal. Finally, the MS_SNAP_STABLE mount flag (only used by
ext3) is now superfluous, so get rid of it.
Sign
Fix up the filesystems that provide their own ->page_mkwrite handlers to
provide stable page writes if necessary.
Signed-off-by: Darrick J. Wong
---
fs/9p/vfs_file.c |1 +
fs/afs/write.c |4 ++--
fs/ceph/addr.c |1 +
fs/cifs/file.c |1 +
fs/ocfs2/mmap.c |1 +
fs/ub
This creates a per-backing-device counter that tracks the number of users which
require pages to be held immutable during writeout. Eventually it will be used
to waive wait_for_page_writeback() if nobody requires stable pages.
Signed-off-by: Darrick J. Wong
---
Documentation/ABI/testing/sysfs
filesystems,
while eliminating unnecessary waiting for devices that don't require the
feature.
Signed-off-by: Darrick J. Wong
---
fs/buffer.c |2 +-
fs/ext4/inode.c |2 +-
include/linux/pagemap.h |1 +
mm/filemap.c|3 ++-
mm/page-writeback.c |
Hi all,
This patchset makes some key modifications to the original 'stable page writes'
patchset. First, it provides users (devices and filesystems) of a
backing_dev_info the ability to declare whether or not it is necessary to
ensure that page contents cannot change during writeout, whereas the
On Thu, Nov 01, 2012 at 11:21:22AM -0700, Boaz Harrosh wrote:
> On 11/01/2012 12:58 AM, Darrick J. Wong wrote:
> > This creates a per-backing-device counter that tracks the number of users
> > which
> > require pages to be held immutable during writeout. Eventually it wil
On Thu, Nov 01, 2012 at 04:22:54PM -0400, Jeff Layton wrote:
> On Thu, 1 Nov 2012 11:43:26 -0700
> Boaz Harrosh wrote:
>
> > On 11/01/2012 12:58 AM, Darrick J. Wong wrote:
> > > Fix up the filesystems that provide their own ->page_mkwrite handlers to
> > > pro
On Sun, Oct 28, 2012 at 10:30:34PM -0400, Theodore Ts'o wrote:
> On Sat, Oct 27, 2012 at 11:23:57PM -0500, Eric Sandeen wrote:
> > A little more going on here to try to properly handle error
> > cases & moving to the next group; despite
> > ext4_handle_release_buffer being a no-op, I've tried
> > t
On Thu, Sep 19, 2013 at 10:40:30AM +0100, Mel Gorman wrote:
> On Thu, Sep 19, 2013 at 10:32:50AM +0100, Mel Gorman wrote:
> > Commit ffecfd1a (block: optionally snapshot page contents to provide
> > stable pages during write) uses bounce buffers for stable page writes in
> > jbd and ext3. Simplisti
: Refactor
__blk_queue_bounce to not use bi_io_vec)
Reported-by: Mel Gorman
Signed-off-by: Darrick J. Wong
---
mm/bounce.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/mm/bounce.c b/mm/bounce.c
index c9f0a43..5a7d58f 100644
--- a/mm/bounce.c
+++ b/mm/bounce.c
@@ -204,6 +204,8 @@ s
On Fri, Sep 20, 2013 at 09:28:07AM +0100, Mel Gorman wrote:
> On Fri, Sep 20, 2013 at 09:06:37AM +0100, Mel Gorman wrote:
> > On Thu, Sep 19, 2013 at 08:06:02PM -0700, Darrick J. Wong wrote:
> > > The "force" parameter in __blk_queue_bounce was being ignored, which
&
On Wed, Dec 05, 2012 at 01:12:28PM +0100, Jan Kara wrote:
> On Mon 26-11-12 18:17:40, Darrick J. Wong wrote:
> > On Thu, Nov 22, 2012 at 10:12:40AM +0100, Jan Kara wrote:
> > > On Wed 21-11-12 17:47:55, Darrick J. Wong wrote:
> > > > On Thu, Nov 22, 2012 at 08:
On Mon, Oct 29, 2012 at 12:30:45PM +0800, zwu.ker...@gmail.com wrote:
> From: Zhi Yong Wu
>
> Add some util helpers to update access frequencies
> for one file or its range.
>
> Signed-off-by: Zhi Yong Wu
> ---
> fs/hot_tracking.c| 179
>
On Mon, Oct 29, 2012 at 12:30:52PM +0800, zwu.ker...@gmail.com wrote:
> From: Zhi Yong Wu
>
> Introduce one framwork to enable that specific FS
> can register its own hot tracking functions.
>
> Signed-off-by: Zhi Yong Wu
> ---
> fs/hot_tracking.c| 78
> +++
On Wed, Nov 07, 2012 at 04:27:05PM +0800, Zhi Yong Wu wrote:
> On Wed, Nov 7, 2012 at 6:45 AM, Darrick J. Wong
> wrote:
> > On Mon, Oct 29, 2012 at 12:30:45PM +0800, zwu.ker...@gmail.com wrote:
> >> From: Zhi Yong Wu
> >>
> >> Add some util helpers to
On Wed, Nov 07, 2012 at 04:34:35PM +0800, Zhi Yong Wu wrote:
> On Wed, Nov 7, 2012 at 7:30 AM, Darrick J. Wong
> wrote:
> > On Mon, Oct 29, 2012 at 12:30:52PM +0800, zwu.ker...@gmail.com wrote:
> >> From: Zhi Yong Wu
> >>
> >> Introduce one framw
Hi all,
With the upcoming U.S. holiday, are you worried that there won't be much work
going on for a few days? Or perhaps you have kids who need a babysitter while
mom and dad hack code for a few hours? Maybe you've gotten tired of
fast-forwarding^W^W^Wwatching commercials on TV?
This is not th
On Fri, Dec 28, 2012 at 04:14:49AM +0900, OGAWA Hirofumi wrote:
> "Darrick J. Wong" writes:
>
> > diff --git a/include/uapi/linux/fs.h b/include/uapi/linux/fs.h
> > index 780d4c6..0144fbb 100644
> > --- a/include/uapi/linux/fs.h
> > +++ b/include/uapi
On Fri, Dec 14, 2012 at 06:06:50PM -0800, Andy Lutomirski wrote:
> On Fri, Dec 14, 2012 at 6:01 PM, Darrick J. Wong
> wrote:
> > On Fri, Dec 14, 2012 at 05:12:37PM -0800, Andy Lutomirski wrote:
> >> It survived. I hit at least one mm bug, but I really don't think it&
On Mon, Dec 17, 2012 at 12:13:36AM +0800, Zheng Liu wrote:
> On Thu, Dec 13, 2012 at 12:08:11AM -0800, Darrick J. Wong wrote:
> > diff --git a/mm/bounce.c b/mm/bounce.c
> > index 0420867..fa11935 100644
> > --- a/mm/bounce.c
> > +++ b/mm/bounce.c
> >
On Mon, Dec 17, 2012 at 11:23:59AM +0100, Jan Kara wrote:
> On Thu 13-12-12 00:08:11, Darrick J. Wong wrote:
> > Several complaints have been received regarding long file write latencies
> > when
> > memory pages must be held stable during writeback. Since it might not be
&g
Hi everybody,
On March 29th, Jeff Moyer posted to lkml a patchset with this note:
> Currently, AIO+DIO+O_SYNC writes are not actually sync'd (for xfs), or they
> are sync'd before the I/O is actually issued (everybody else). The following
> patch series fixes this in two parts. First, for the f
Hi,
Fsyncing is tricky business, so factor out the bits of the xfs_file_fsync
function that can be used from the I/O post-processing path.
From: Jeff Moyer
Signed-off-by: Jeff Moyer
---
fs/xfs/xfs_file.c | 44 +---
fs/xfs/xfs_inode.h |1 +
2 files
ext4 reorganization]
Signed-off-by: Darrick J. Wong
---
fs/ext4/ext4.h|9 +
fs/ext4/file.c|2 +
fs/ext4/inode.c |6 +++
fs/ext4/page-io.c | 92 +
fs/ext4/super.c | 13 +++
5 files changed, 106 insertions(+), 16
ll filesystems using blockdev_direct_IO() need O_SYNC aio dio handling
and the generic suffices for them, make blockdev_direct_IO() pass the new
DIO_SYNC_WRITES flag.
From: Jan Kara
Signed-off-by: Jan Kara
Signed-off-by: Jeff Moyer
[darrick.w...@oracle.com: Minor style and changelog fixes]
Signed-off
done.
From: Jeff Moyer
Signed-off-by: Jeff Moyer
[darrick.w...@oracle.com: Rework patch to use per-mount workqueues]
Signed-off-by: Darrick J. Wong
---
fs/xfs/xfs_aops.c | 52 +++-
fs/xfs/xfs_aops.h |1 +
fs/xfs/xfs_mount.h |1 +
fs/xfs
Use generic handlers to queue fsync() when AIO DIO is completed for O_SYNC
file.
From: Jan Kara
Signed-off-by: Jan Kara
Signed-off-by: Jeff Moyer
---
fs/gfs2/aops.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/gfs2/aops.c b/fs/gfs2/aops.c
index 01c4975..8b1d0f7 10
hat we need
for proper O_SYNC AIO DIO handling.
From: Jan Kara
Signed-off-by: Jan Kara
Signed-off-by: Jeff Moyer
[darrick.w...@oracle.com: Don't issue flush if aio is queued]
Signed-off-by: Darrick J. Wong
---
fs/btrfs/file.c |2 +-
fs/btrfs/inode.c |2 +-
2 files changed, 2
Use generic handlers to queue fsync() when AIO DIO is completed for O_SYNC
file.
From: Jan Kara
Signed-off-by: Jan Kara
Signed-off-by: Jeff Moyer
---
fs/ocfs2/aops.c |6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/fs/ocfs2/aops.c b/fs/ocfs2/aops.c
index 6577432..6
Hi,
As it stands, generic_file_aio_write will call into generic_write_sync
when -EIOCBQUEUED is returned from __generic_file_aio_write. EIOCBQUEUED
indicates that an I/O was submitted but NOT completed. Thus, we will
flush the disk cache, potentially before the write(s) even make it to
the disk!
the filesystem
that the device node happens to reside in. This means that unlike regular
files, iocb->ki_filp->f_mapping->host->i_sb != inode->i_sb. Therefore, adjust
Jeff's earlier patch to keep the pointer use consistent and avoid a NULL deref.
Signed-off-by: Darrick J. Wong
Apologies for the garbage emails. The corporate email server lost its mind,
and I'm well on my way to losing mine
They at least were so garbled that they're not attached to this thread.
--D
> Hi everybody,
>
> On March 29th, Jeff Moyer posted to lkml a patchset with this note:
>
> > Cur
On Tue, Nov 20, 2012 at 09:23:18AM -0500, Jeff Moyer wrote:
> "Darrick J. Wong" writes:
>
> > Hi everybody,
> >
> > On March 29th, Jeff Moyer posted to lkml a patchset with this note:
> >
> >> Currently, AIO+DIO+O_SYNC writes are not actually syn
On Thu, Mar 21, 2013 at 02:26:26AM +, Alasdair G Kergon wrote:
> Please pull from:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/agk/linux-dm tags/dm-3.9-fixes
>
> to get the following device-mapper fixes for 3.9.
>
> Thanks,
> Alasdair
>
>
). This fixes the
problem where someone writes a block through the cache, but a subsequent reread
(from the cache) returns old contents.
Signed-off-by: Darrick J. Wong
---
drivers/md/dm-cache-target.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/drivers/md/dm-cache-target.c b
On Fri, Mar 22, 2013 at 11:53:26AM -0700, Darrick J. Wong wrote:
> On Thu, Mar 21, 2013 at 02:26:26AM +, Alasdair G Kergon wrote:
> > Please pull from:
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/agk/linux-dm
> > tags/dm-3.9-fixes
> >
> > t
On Fri, Mar 22, 2013 at 08:21:56PM +, Ben Hutchings wrote:
> On Fri, 2013-03-22 at 13:11 -0700, Darrick J. Wong wrote:
> > The new writethrough strategy for dm-cache issues a bio to the origin
> > device,
> > remaps the bio to the cache device, and issues the bi
On Fri, Mar 22, 2013 at 06:34:28PM -0400, Mike Snitzer wrote:
> On Fri, Mar 22 2013 at 4:11pm -0400,
> Darrick J. Wong wrote:
>
> > The new writethrough strategy for dm-cache issues a bio to the origin
> > device,
> > remaps the bio to the cache device, and issues
On Fri, Mar 22, 2013 at 11:27:16PM -0400, Mike Snitzer wrote:
> On Fri, Mar 22 2013 at 7:16pm -0400,
> Darrick J. Wong wrote:
>
> > On Fri, Mar 22, 2013 at 06:34:28PM -0400, Mike Snitzer wrote:
> > > On Fri, Mar 22 2013 at 4:11pm -0400,
> > > Darrick J. Wo
re has the same
> problem in ext3. So if this patch is fine, I will generate a patch for
> ext3 file system.
Seems to fix the bug for me, both with your test case and also with trinity
runs, so...
Tested-by: Darrick J. Wong
--D
>
> Thanks,
>
tty_port_init() zeroes out the tty port, which means that we have to set the
ops pointer /after/, not before this call. Otherwise, tty_port_open will crash
when it tries to deref ops, which is now a NULL pointer.
Signed-off-by: Darrick J. Wong
---
drivers/char/ttyprintk.c |2 +-
1 file
uot; and not in a shipping
e2fsprogs, so there should be few users affected by this.
v2: Eliminate unnecessary variables and make it clear(er) which values are 32
bits wide.
Reported-by: Al Viro
Signed-off-by: Darrick J. Wong
---
fs/jbd2/commit.c | 12 ++--
fs/jbd2/recovery.c | 11
Add a few missing calls to jbd2_superblock_csum_set just prior to calling
jbd2_write_superblock. This fixes complaints about corrupt journals if
metadata checksumming and journal checksumming are both enabled.
Signed-off-by: Darrick J. Wong
---
fs/jbd2/journal.c |2 ++
1 file changed, 2
On Mon, May 13, 2013 at 02:04:08PM +0200, Peter Rajnoha wrote:
> On 11.05.2013 17:25, Mike Snitzer wrote:> On Fri, May 10 2013 at 1:51pm
> -0400,
> > Darrick J. Wong wrote:
> >
> ...
> >> afaict, there isn't anything in the initscripts that tears down dm
&
On Wed, Apr 03, 2013 at 04:42:44PM +0200, Jan Kara wrote:
> On Wed 03-04-13 15:20:19, Mel Gorman wrote:
> > On Tue, Apr 02, 2013 at 10:01:43AM -0700, Darrick J. Wong wrote:
> > > Hi,
> > >
> > > A couple of weeks have gone by without further comments ab
documentation in jbd for why we're doing this, and clean up
some code.
Signed-off-by: Darrick J. Wong
[darrick.w...@oracle.com: Fold in a couple of small cleanups from akpm]
Signed-off-by: Andrew Morton
---
fs/buffer.c |9 -
fs/ext3/super.c
On Mon, May 06, 2013 at 12:51:15AM +0400, Alexey Khoroshilov wrote:
> If memory allocation in ext4_mb_new_group_pa() is failed,
> it returns error code, ext4_mb_new_preallocation() propages it,
> but ext4_mb_new_blocks() ignores it.
>
> An observed result was:
> - allocation fail means ext4_mb_new
pdate at least the hit/miss counters, so take care of everything.
Signed-off-by: Darrick J. Wong
---
drivers/md/dm-cache-target.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/md/dm-cache-target.c b/drivers/md/dm-cache-target.c
index 1074409..f476ada 100644
---
On Wed, May 08, 2013 at 06:05:26PM -0400, Mike Snitzer wrote:
> On Wed, May 08 2013 at 5:48pm -0400,
> Darrick J. Wong wrote:
>
> > Hi,
> >
> > So I've been watching the hit/miss counters in dmcache and I've noticed a
> > couple of things that look l
On Wed, May 08, 2013 at 06:05:26PM -0400, Mike Snitzer wrote:
> On Wed, May 08 2013 at 5:48pm -0400,
> Darrick J. Wong wrote:
>
> > Hi,
> >
> > So I've been watching the hit/miss counters in dmcache and I've noticed a
> > couple of things that look l
When userspace queries dmcache for stats info, we should ensure that all the
metadata gets flushed out of memory to disk. The current code neglects to
update the disk copy of the hit/miss counters.
Signed-off-by: Darrick J. Wong
---
drivers/md/dm-cache-target.c |1 +
1 file changed, 1
an't umount and therefore
can't tear down the cache device, but want to save the cache metadata anyway.
The command syntax is as follows:
# dmsetup message mycache 0 flush now
Signed-off-by: Darrick J. Wong
---
drivers/md/dm-cache-target.c |4
1 file changed, 4 insertions(+)
diff --
On Fri, May 10, 2013 at 11:22:24AM +0100, Joe Thornber wrote:
> On Thu, May 09, 2013 at 01:47:51PM -0700, Darrick J. Wong wrote:
> > Create a new 'flush' message that causes the dmcache to write all of its
> > metadata out to disk. This enables us to ensure that the dis
Hi all,
Lately I've been having some fun playing with bcache, dmcache, and enhanceio.
I've an fio config[1] that thinks it simulates a certain kind of workload
by randomly reading and writing 8k blocks to 8x 1GB files. Since the
storage summit is in a week, I thought I might get the party starte
On Sun, Feb 17, 2008 at 03:02:50PM -0500, Mark M. Hoffman wrote:
> Documentation/hwmon/adt7473 would be nice.
Ok, I'll generate one.
> That should be const.
Applied.
> > + BUG();
>
> Given ADT7473_PWM_BHVR_SHIFT is 5, this BUG() is obviously impossible.
> But I guess it's not obvious to GCC
adt7473: New driver for Analog Devices ADT7473 sensor chip
This driver reports voltage, temperature and fan sensor readings
on an ADT7473 chip.
Signed-off-by: Darrick J. Wong <[EMAIL PROTECTED]>
---
Documentation/hwmon/adt7473 | 79 +++
drivers/hwmon/Kconfig | 10
drivers
Hi all,
This patchset ("stable page writes, part 2") makes some key modifications to
the kernel's strategy to keep page contents intact during writeback. First, it
provides users (devices and filesystems) of a backing_dev_info the ability to
declare whether or not it is necessary to ensure that p
This creates a per-backing-device counter that tracks the number of users which
require pages to be held immutable during writeout. Eventually it will be used
to waive wait_for_page_writeback() if nobody requires stable pages.
Signed-off-by: Darrick J. Wong
---
Documentation/ABI/testing/sysfs
filesystems,
while eliminating unnecessary waiting for devices that don't require the
feature.
Signed-off-by: Darrick J. Wong
---
fs/buffer.c |2 +-
fs/ext4/inode.c |2 +-
include/linux/pagemap.h |1 +
mm/filemap.c|3 ++-
mm/page-writeback.c |
ext3 doesn't properly isolate pages from changes during writeback. Since the
recommended fix is to use ext4, for now we'll just print a warning if the user
tries to mount in write mode.
Signed-off-by: Darrick J. Wong
---
fs/ext3/super.c |8
1 file changed, 8 insertions
Fix up the ->page_mkwrite handler to provide stable page writes if necessary.
Signed-off-by: Darrick J. Wong
---
fs/9p/vfs_file.c |1 +
1 file changed, 1 insertion(+)
diff --git a/fs/9p/vfs_file.c b/fs/9p/vfs_file.c
index c2483e9..a2d3e2f 100644
--- a/fs/9p/vfs_file.c
+++ b/fs
On Wed, Nov 21, 2012 at 03:15:43AM +0100, Jan Kara wrote:
> On Tue 20-11-12 18:00:56, Darrick J. Wong wrote:
> > ext3 doesn't properly isolate pages from changes during writeback. Since
> > the
> > recommended fix is to use ext4, for now we'll just print a warnin
ed to waive
wait_for_page_writeback() if nobody requires stable pages.
Signed-off-by: Darrick J. Wong
---
Documentation/ABI/testing/sysfs-class-bdi |5 +
block/blk-integrity.c |4
include/linux/backing-dev.h |6 ++
mm/backing-
This patch adds yet another page flag, PG_stable, to indicate that the page's
contents must not be changed because the page is undergoing some sort of
integrity operation (checksumming, digest calculation, etc.) This change
should enable us to reduce page write latency in userspace apps, particula
When writing buffers out to disk ahead of committing a transaction, set the
Stable bit on the page to prevent others from wandering in and modifying the
page.
Signed-off-by: Darrick J. Wong
---
fs/jbd/commit.c | 18 +-
1 file changed, 17 insertions(+), 1 deletion(-)
diff
On Thu, Nov 22, 2012 at 08:47:13AM +1100, NeilBrown wrote:
> On Wed, 21 Nov 2012 22:33:33 +0100 Jan Kara wrote:
>
> > On Wed 21-11-12 13:13:19, Darrick J. Wong wrote:
> > > On Wed, Nov 21, 2012 at 03:15:43AM +0100, Jan Kara wrote:
> > > > On Tue 20-11-1
Ok, I'll update the description a bit.
On Wed, Nov 21, 2012 at 05:56:24AM -0500, Christoph Hellwig wrote:
> > +static inline void bdi_require_stable_pages(struct backing_dev_info *bdi)
> > +{
> > + bdi->capabilities |= BDI_CAP_STABLE_WRITES;
> > +}
> > +
> > +static inline void bdi_unrequire_sta
filesystems,
while eliminating unnecessary waiting for devices that don't require the
feature.
Signed-off-by: Darrick J. Wong
---
fs/buffer.c |2 +-
fs/ext4/inode.c |2 +-
fs/gfs2/file.c |2 +-
fs/nilfs2/file.c|2 +-
include/linux/pagemap.h |
When stable pages are required, we have to wait if the page is just
going to disk and we want to modify it. Add proper callback to
ocfs2_grab_pages_for_write().
CC: ocfs2-de...@oss.oracle.com
CC: Joel Becker
CC: Mark Fasheh
From: Jan Kara
Signed-off-by: Jan Kara
---
fs/ocfs2/aops.c |1 +
Hi all,
This patchset ("stable page writes, part 2") makes some key modifications to
the original 'stable page writes' patchset. First, it provides creators
(devices and filesystems) of a backing_dev_info a flag that declares whether or
not it is necessary to ensure that page contents cannot chan
This creates a per-backing-device flag that tracks whether or not pages must be
held immutable during writeout. Eventually it will be used to waive
wait_for_page_writeback() if nothing requires stable pages.
Reviewed-by: Jan Kara
Signed-off-by: Darrick J. Wong
---
Documentation/ABI/testing
Fix up the ->page_mkwrite handler to provide stable page writes if necessary.
Signed-off-by: Darrick J. Wong
---
fs/9p/vfs_file.c |1 +
1 file changed, 1 insertion(+)
diff --git a/fs/9p/vfs_file.c b/fs/9p/vfs_file.c
index c2483e9..357260b 100644
--- a/fs/9p/vfs_file.c
+++ b/fs
When stable pages are required, we have to wait if the page is just
going to disk and we want to modify it. Add proper callback to
ubifs_vm_page_mkwrite().
CC: Artem Bityutskiy
From: Jan Kara
CC: Adrian Hunter
CC: linux-...@lists.infradead.org
Signed-off-by: Jan Kara
---
fs/ubifs/file.c |
, the complaints about high latency will
likely return. We might as well centralize their page snapshotting thing to
one place.
Tested-by: Andy Lutomirski
Signed-off-by: Darrick J. Wong
---
arch/tile/Kconfig |6 --
block/blk-core.c|8 +---
fs/ext3/super.c |
7.65 seconds (2.54 MB/s)
> > delete kernel-12 in 38.58 seconds
> > stat dir kernel-2 in 17.48 seconds
> > patch dir kernel-70151 109MB in 79.82 seconds (1.37 MB/s)
> > stat dir kernel-7 in 25.76 seconds
> > stat dir kernel-78184 in 20.30 seconds
> > compile dir ke
Hi all,
This patchset ("stable page writes, part 2") makes some key modifications to
the original 'stable page writes' patchset. First, it provides creators
(devices and filesystems) of a backing_dev_info a flag that declares whether or
not it is necessary to ensure that page contents cannot chan
filesystems,
while eliminating unnecessary waiting for devices that don't require the
feature.
Signed-off-by: Darrick J. Wong
---
fs/buffer.c |2 +-
fs/ext4/inode.c |2 +-
include/linux/pagemap.h |1 +
mm/filemap.c|3 ++-
mm/page-writeback.c |
27;re going to migrate iscsi
and raid to use stable page writes, the complaints about high latency will
likely return. We might as well centralize their page snapshotting thing to
one place.
Signed-off-by: Darrick J. Wong
---
arch/tile/Kconfig |6 --
block/blk-core.c|
Fix up the ->page_mkwrite handler to provide stable page writes if necessary.
Signed-off-by: Darrick J. Wong
---
fs/9p/vfs_file.c |1 +
1 file changed, 1 insertion(+)
diff --git a/fs/9p/vfs_file.c b/fs/9p/vfs_file.c
index c2483e9..357260b 100644
--- a/fs/9p/vfs_file.c
+++ b/fs
This creates a per-backing-device flag that tracks whether or not pages must be
held immutable during writeout. Eventually it will be used to waive
wait_for_page_writeback() if nobody requires stable pages.
Signed-off-by: Darrick J. Wong
---
Documentation/ABI/testing/sysfs-class-bdi |5
On Thu, Dec 13, 2012 at 05:48:06PM -0800, Andy Lutomirski wrote:
> On 12/13/2012 12:08 AM, Darrick J. Wong wrote:
> > Several complaints have been received regarding long file write latencies
> > when
> > memory pages must be held stable during writeback. Since it might not
On Thu, Dec 13, 2012 at 08:17:26PM +0800, Zhi Yong Wu wrote:
> On Thu, Dec 13, 2012 at 3:50 AM, Darrick J. Wong
> wrote:
> > On Mon, Dec 10, 2012 at 11:30:03AM +0800, Zhi Yong Wu wrote:
> >> HI, all guys.
> >>
> >> any comments or suggestions?
> >
&g
On Fri, Dec 14, 2012 at 02:33:34PM +1100, Dave Chinner wrote:
> On Thu, Dec 13, 2012 at 06:10:49PM -0800, Darrick J. Wong wrote:
> > On Thu, Dec 13, 2012 at 05:48:06PM -0800, Andy Lutomirski wrote:
> > > On 12/13/2012 12:08 AM, Darrick J. Wong wrote:
> > > > Several
1 - 100 of 1089 matches
Mail list logo
