[PATCH v2] net: ec_bhf: remove excessive debug messages

2014-08-24 Thread Dariusz Marcinkiewicz
This cuts down the number of debug information spit out by the driver. Signed-off-by: Dariusz Marcinkiewicz --- Changes since v1: * as suggested by Dave Miller, I am simply ditching all debugfs stuff drivers/net/ethernet/ec_bhf.c | 101

[PATCH 1/2] net: ec_bhf: remove excessive debug messages

2014-08-15 Thread Dariusz Marcinkiewicz
This cuts down on the number of debug information spit out by the driver. Some of the potentially useful debug info gets exposed by debugfs. Signed-off-by: Dariusz Marcinkiewicz --- drivers/net/ethernet/ec_bhf.c | 185 ++--- 1 file changed, 99 insertions

[PATCH 2/2] MAINTAINERS: add entry for ec_bhf driver

2014-08-15 Thread Dariusz Marcinkiewicz
Added entry for ec_bhf driver. Signed-off-by: Dariusz Marcinkiewicz --- MAINTAINERS |6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 7e2eb4c..b5416f8 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1835,6 +1835,12 @@ S: Orphan F

[PATCH v7.1 5/9] drm: tda998x: use cec_notifier_conn_(un)register

2019-08-19 Thread Dariusz Marcinkiewicz
comes visible to the irq thread once it is fully constructed. Signed-off-by: Dariusz Marcinkiewicz --- drivers/gpu/drm/i2c/tda998x_drv.c | 36 +-- 1 file changed, 25 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c b/drivers/gpu/dr

[PATCH v7 1/3] media: cec: expose HDMI connector to CEC dev mapping

2019-05-21 Thread Dariusz Marcinkiewicz
ted commit message Changes since v1:  - removed the unnecessary event,  - extended cec_connctor_info to allow for various types of connectors. Signed-off-by: Dariusz Marcinkiewicz --- Documentation/media/kapi/cec-core.rst | 7 +- Documentation/media/uapi/cec/cec-funcs.rst| 1 + ..

[PATCH v7 3/3] drm/i2c: tda9950: pass HDMI connector info to CEC adapter

2019-05-21 Thread Dariusz Marcinkiewicz
With that change tda998x provides a connector info to the CEC adapter. In order to be able to that it delays creation of respective CEC device until the DRM connector is initialized. Requires testing. Signed-off-by: Dariusz Marcinkiewicz --- drivers/gpu/drm/i2c/tda9950.c | 13

[PATCH v7 2/3] drm/bridge: dw-hdmi: pass connector info to the CEC adapter

2019-05-21 Thread Dariusz Marcinkiewicz
platform device initialization Signed-off-by: Dariusz Marcinkiewicz --- drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c | 13 ++- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 103 ++ 2 files changed, 66 insertions(+), 50 deletions(-) diff --git a/drivers/gpu/drm/bridge

Re: [PATCH v6 2/3] drm/bridge: dw-hdmi: pass connector info to the CEC adapter

2019-05-21 Thread Dariusz Marcinkiewicz
On Mon, May 20, 2019 at 1:30 PM Hans Verkuil wrote: > > On 5/17/19 5:42 PM, Dariusz Marcinkiewicz wrote: > > This patch makes dw-hdmi pass DRM connector info to a respective > > CEC adapter. In order to be able to do that it delays creation of > > the dw-hdmi-cec p

Re: [PATCH v6 1/3] media: cec: expose HDMI connector to CEC dev mapping

2019-05-21 Thread Dariusz Marcinkiewicz
On Mon, May 20, 2019 at 12:25 PM Hans Verkuil wrote: > > It's a bit unusual since it uses the Synopsys bridge, but not the Synopsys > CEC driver (it has its own meson cec driver). > > The first thing I noticed is that I did not get any connector info. > I think that the root cause of that is that

[RFC PATCH] media: cec: DRM connector to CEC dev mapping

2019-04-04 Thread Dariusz Marcinkiewicz
-by: Dariusz Marcinkiewicz --- Notes: Sending the patch in its current form the get feedback if that is considered a right approach or if some other way of learning the mapping in userland is preferred. .../display/amdgpu_dm/amdgpu_dm_mst_types.c | 2 +- drivers/gpu/drm

[PATCH v7 2/9] drm/i915/intel_hdmi: use cec_notifier_conn_(un)register

2019-08-14 Thread Dariusz Marcinkiewicz
Use the new cec_notifier_conn_(un)register() functions to (un)register the notifier for the HDMI connector, and fill in the cec_connector_info. Signed-off-by: Dariusz Marcinkiewicz Signed-off-by: Hans Verkuil Tested-by: Hans Verkuil --- drivers/gpu/drm/i915/display/intel_hdmi.c | 13

[PATCH v7 0/9] drm: cec: convert DRM drivers to the new notifier API

2019-08-14 Thread Dariusz Marcinkiewicz
barrier to make sure IRQ threads see the notifier once it is created (replacing the WRITE_ONCE I put in v1). The best thing to do here, I believe, would be not to have any synchronization and make sure that an IRQ only gets enabled after the notifier is created. Dariusz Marcin

Re: [PATCH v6 4/8] drm: tda998x: use cec_notifier_conn_(un)register

2019-08-14 Thread Dariusz Marcinkiewicz
Hello. On Tue, Aug 13, 2019 at 1:20 PM Russell King - ARM Linux admin wrote: > > This also doesn't make sense: tda998x_destroy() is the opposite of > tda998x_create(). However, tda998x_connector_destroy() is the > opposite of tda998x_connector_create(). > > By moving the CEC creation code into t

Re: [PATCH v7 1/3] media: cec: expose HDMI connector to CEC dev mapping

2019-06-19 Thread Dariusz Marcinkiewicz
Hi Hans. I would like to come back to this thread. On Fri, May 24, 2019 at 11:21 AM Hans Verkuil wrote: > > Hi Dariusz, > > I did some more testing with the Khadas VIM2 and found another problem, > something that will, unfortunately, require some redesign. > > See my comments below... > ... > >

Re: [PATCH RESEND] media: cros-ec-cec: do not bail on device_init_wakeup failure

2020-06-24 Thread Dariusz Marcinkiewicz
Hi. On Wed, Jun 24, 2020 at 4:45 PM Guenter Roeck wrote: > > On Mon, Jun 22, 2020 at 12:23 PM Hans Verkuil > > wrote: > > > > > > > Signed-off-by: Dariusz Marcinkiewicz > > > > > > This can be CCed to stable, I guess? > > > > &g

[PATCH v3] media: cros-ec-cec: do not bail on device_init_wakeup failure

2020-06-26 Thread Dariusz Marcinkiewicz
7;ing stable - description fixed Changes since v1: - added Fixes tag Fixes: cd70de2d356ee ("media: platform: Add ChromeOS EC CEC driver") Cc: sta...@vger.kernel.org Signed-off-by: Dariusz Marcinkiewicz --- drivers/media/cec/platform/cros-ec/cros-ec-cec.c | 10 -- 1 file change

[PATCH v2] media: cros-ec-cec: do not bail on device_init_wakeup failure

2020-06-22 Thread Dariusz Marcinkiewicz
again. This goal of the patch is to fix the above cases. Overwhelming majority of the drivers do not check device_init_wakeup return code. v2: add Fixes tags Fixes: cd70de2d356ee ("media: platform: Add ChromeOS EC CEC driver") Signed-off-by: Dariusz Marcinkiewicz --- drivers/media/ce

[PATCH] media: cros-ec-cec: disable the device wakeup on remove

2020-07-06 Thread Dariusz Marcinkiewicz
The device is enabled for wake up while the driver is loaded. For symmetry, disable wakeup when it is removed. Signed-off-by: Dariusz Marcinkiewicz --- drivers/media/cec/platform/cros-ec/cros-ec-cec.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/media/cec

Re: [PATCH] media: cros-ec-cec: disable the device wakeup on remove

2020-07-07 Thread Dariusz Marcinkiewicz
On Mon, Jul 6, 2020 at 11:00 AM Alexandre Belloni wrote: > > On 06/07/2020 10:52:38+0200, Dariusz Marcinkiewicz wrote: > > The device is enabled for wake up while the driver is loaded. > > For symmetry, disable wakeup when it is removed. > > > > This is not necessar

Re: [PATCH v7 1/3] media: cec: expose HDMI connector to CEC dev mapping

2019-05-28 Thread Dariusz Marcinkiewicz
On Fri, May 24, 2019 at 11:21 AM Hans Verkuil wrote: > > Hi Dariusz, > > I did some more testing with the Khadas VIM2 and found another problem, > something that will, unfortunately, require some redesign. > ... > > The other problem is in the CEC driver: it creates the CEC device as > soon as the

[PATCH v5 2/3] drm/bridge: dw-hdmi: pass connector info to the CEC adapter

2019-05-16 Thread Dariusz Marcinkiewicz
This patch makes dw-hdmi pass DRM connector info to a respective CEC adapter. In order to be able to do that it delays creation of the dw-hdmi-cec platform device until DRM connector is initialized. Requires testing. Signed-off-by: Dariusz Marcinkiewicz --- drivers/gpu/drm/bridge/synopsys/dw

[PATCH v5 1/3] media: cec: expose HDMI connector to CEC dev mapping

2019-05-16 Thread Dariusz Marcinkiewicz
conn takes connector_info as argument Changes since v2: - cec_s_connector_info removed, the connector info is now passed to cec_allocate_adapter - updated commit message Changes since v1:  - removed the unnecessary event,  - extended cec_connctor_info to allow for various types of connectors. Signed-off-b

[PATCH v5 3/3] drm/i2c: tda9950: pass HDMI connector info to CEC adapter

2019-05-16 Thread Dariusz Marcinkiewicz
With that change tda998x provides a connector info to the CEC adapter. In order to be able to that it delays creation of respective CEC device until the DRM connector is initialized. Requires testing. Signed-off-by: Dariusz Marcinkiewicz --- drivers/gpu/drm/i2c/tda9950.c | 7

Re: [RFC PATCH v2] media: cec: expose HDMI connector to CEC dev mapping

2019-05-16 Thread Dariusz Marcinkiewicz
Hi Hans. From: Hans Verkuil Date: Thu, May 9, 2019 at 11:31 AM To: Dariusz Marcinkiewicz Cc: , , > On 5/9/19 9:52 AM, Dariusz Marcinkiewicz wrote: > > Hi Hans. > > > > On Wed, Apr 24, 2019 at 2:09 PM Hans Verkuil wrote: > >> > >> Hi Dariusz, > >>

[PATCH v6 2/3] drm/bridge: dw-hdmi: pass connector info to the CEC adapter

2019-05-17 Thread Dariusz Marcinkiewicz
This patch makes dw-hdmi pass DRM connector info to a respective CEC adapter. In order to be able to do that it delays creation of the dw-hdmi-cec platform device until DRM connector is initialized. Requires testing. Signed-off-by: Dariusz Marcinkiewicz --- drivers/gpu/drm/bridge/synopsys/dw

[PATCH v6 1/3] media: cec: expose HDMI connector to CEC dev mapping

2019-05-17 Thread Dariusz Marcinkiewicz
sary event,  - extended cec_connctor_info to allow for various types of connectors. Signed-off-by: Dariusz Marcinkiewicz --- Documentation/media/kapi/cec-core.rst | 7 +- Documentation/media/uapi/cec/cec-funcs.rst| 1 + .../uapi/cec/cec-ioc-adap-g-conn-info.rst

[PATCH v6 3/3] drm/i2c: tda9950: pass HDMI connector info to CEC adapter

2019-05-17 Thread Dariusz Marcinkiewicz
With that change tda998x provides a connector info to the CEC adapter. In order to be able to that it delays creation of respective CEC device until the DRM connector is initialized. Requires testing. Signed-off-by: Dariusz Marcinkiewicz --- drivers/gpu/drm/i2c/tda9950.c | 7

[PATCH RESEND] media: cros-ec-cec: do not bail on device_init_wakeup failure

2020-06-22 Thread Dariusz Marcinkiewicz
again. This goal of the patch is to fix the above cases. Overwhelming majority of the drivers do not check device_init_wakeup return value. Signed-off-by: Dariusz Marcinkiewicz --- drivers/media/cec/platform/cros-ec/cros-ec-cec.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff

Re: [PATCH RESEND] media: cros-ec-cec: do not bail on device_init_wakeup failure

2020-06-24 Thread Dariusz Marcinkiewicz
Hello. I realized that I sent the previous answer using HTML, and as a consequence it was blocked from mailing lists. Sending it again (apologies for double posting). On Mon, Jun 22, 2020 at 12:23 PM Hans Verkuil wrote: > > On 22/06/2020 12:05, Dariusz Marcinkiewicz wrote: > >