Re: [PATCH v15 04/10] arm64: Kprobes with single stepping support

2016-07-29 Thread Daniel Thompson
On 28/07/16 15:40, Catalin Marinas wrote: On Wed, Jul 27, 2016 at 06:13:37PM -0400, David Long wrote: On 07/27/2016 07:50 AM, Daniel Thompson wrote: On 25/07/16 23:27, David Long wrote: On 07/25/2016 01:13 PM, Catalin Marinas wrote: The problem is that the original design was done on x86 for

Re: [PATCH] tools: spi: enable CROSS_COMPILE in Makefile

2016-09-07 Thread Daniel Thompson
On 07/09/16 15:28, Jorge Ramirez-Ortiz wrote: Signed-off-by: Jorge Ramirez-Ortiz --- tools/spi/Makefile | 4 1 file changed, 4 insertions(+) diff --git a/tools/spi/Makefile b/tools/spi/Makefile index cd0db62..d1845b0 100644 --- a/tools/spi/Makefile +++ b/tools/spi/Makefile @@ -1,4 +1,8 @@

Re: [RESEND PATCH] arm64: kgdb: fix single stepping

2016-09-15 Thread Daniel Thompson
On 15/09/16 08:56, AKASHI Takahiro wrote: On Wed, Sep 14, 2016 at 03:58:51PM +0100, Will Deacon wrote: Hi Akashi, On Tue, Apr 21, 2015 at 02:13:13AM +0100, AKASHI Takahiro wrote: Could you please review my patch below? See also arm64 maintainer's comment: http://lists.infradead.org/pipermail/l

Re: [PATCH v15 04/10] arm64: Kprobes with single stepping support

2016-08-08 Thread Daniel Thompson
On 04/08/16 05:47, David Long wrote: From b451caa1adaf1d03e08a44b5dad3fca31cebd97a Mon Sep 17 00:00:00 2001 From: "David A. Long" Date: Thu, 4 Aug 2016 00:35:33 -0400 Subject: [PATCH] arm64: Remove stack duplicating code from jprobes Because the arm64 calling standard allows stacked function ar

Re: [PATCH] clk: Hi6220: enable stub clock driver for ARCH_HISI

2016-08-08 Thread Daniel Thompson
On 08/08/16 15:42, Amit Kucheria wrote: On Mon, Aug 8, 2016 at 12:12 PM, Leo Yan wrote: Hi Amit, On Mon, Aug 08, 2016 at 11:23:31AM +0530, Amit Kucheria wrote: On Mon, Aug 8, 2016 at 9:07 AM, Leo Yan wrote: In current kernel config 'CONFIG_STUB_CLK_HI6220' is disabled by default, as result

Re: [PATCH] clk: Hi6220: enable stub clock driver for ARCH_HISI

2016-08-08 Thread Daniel Thompson
On 08/08/16 19:02, Amit Kucheria wrote: This patch is to enable stub clock driver in config for ARCH_HISI. Reported-by: Dietmar Eggemann Signed-off-by: Leo Yan --- drivers/clk/hisilicon/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clk/hisilicon/Kconfig b/drivers/clk/his

Re: [RFC PATCH v3 6/7] arm64: irqflags: Use ICC sysregs to implement IRQ masking

2016-08-25 Thread Daniel Thompson
On 22/08/16 16:06, Marc Zyngier wrote: diff --git a/arch/arm64/include/asm/arch_gicv3.h b/arch/arm64/include/asm/arch_gicv3.h index fc2a0cb47b2c..a4ad69e2831b 100644 --- a/arch/arm64/include/asm/arch_gicv3.h +++ b/arch/arm64/include/asm/arch_gicv3.h @@ -80,6 +80,9 @@ #include #include +/* O

Re: [PATCH] backlight: pwm_bl: make of_device_ids const

2017-06-20 Thread Daniel Thompson
On 20/06/17 08:52, Arvind Yadav wrote: of_device_ids are not supposed to change at runtime. All functions working with of_device_ids provided by work with const of_device_ids. So mark the non-const structs as const. Signed-off-by: Arvind Yadav Acked-by: Daniel Thompson --- drivers

Re: [PATCH v2] backlight: lm3630a: bump REG_MAX value to 0x50 instead of 0x1F

2017-06-21 Thread Daniel Thompson
On 21/06/17 06:31, Bhushan Shah wrote: In the lm3630a_chip_init we try to write to 0x50 register, which is higher value then the max_register value, this resulted in regmap_write return -EIO. Fix this by bumping REG_MAX value to 0x50. > Signed-off-by: Bhushan Shah Suggested-by: Bjorn Andersson

Re: [project-aspen-dev] [PATCH 3/5] phy: add inno-usb2-phy driver for hi3798cv200 SoC

2017-06-21 Thread Daniel Thompson
On 21/06/17 10:00, Jiancheng Xue wrote: From: Pengcheng Li Add inno-usb2-phy driver for hi3798cv200 SoC. Signed-off-by: Pengcheng Li Signed-off-by: Jiancheng Xue --- drivers/phy/Kconfig | 10 ++ drivers/phy/Makefile | 1 + drivers/phy/phy-hisi-inno-usb2.c | 28

Re: [PATCH v2] backlight: lm3630a: bump REG_MAX value to 0x50 instead of 0x1F

2017-06-21 Thread Daniel Thompson
On 21/06/17 11:52, Bhushan Shah wrote: On Wed, Jun 21, 2017 at 10:37:43AM +0100, Daniel Thompson wrote: On 21/06/17 06:31, Bhushan Shah wrote: In the lm3630a_chip_init we try to write to 0x50 register, which is higher value then the max_register value, this resulted in regmap_write return -EIO

Re: [PATCH 3/3] backlight: tps65217_bl: fix device-tree node lookup

2017-11-13 Thread Daniel Thompson
named "backlight" elsewhere in the tree. Fixes: eebfdc17cc6c ("backlight: Add TPS65217 WLED driver") Cc: stable # 3.7 Cc: Matthias Kaehlcke Signed-off-by: Johan Hovold Acked-by: Daniel Thompson --- drivers/video/backlight/tps65217_bl.c | 4 ++-- 1 file changed

Re: [PATCH 2/3] backlight: max8925_bl: fix device-tree node lookup

2017-11-13 Thread Daniel Thompson
backlight node was leaked. Fixes: 47ec340cb8e2 ("mfd: max8925: Support dt for backlight") Cc: stable # 3.9 Cc: Qing Xu Cc: Haojian Zhuang Signed-off-by: Johan Hovold Acked-by: Daniel Thompson --- drivers/video/backlight/max8925_bl.c | 4 +++- 1 file changed, 3 insertions(+),

Re: [PATCH 1/3] backlight: as3711_bl: fix device-tree node lookup

2017-11-13 Thread Daniel Thompson
On 13/11/17 10:20, Johan Hovold wrote: Fix child-node lookup during probe, which ended up searching the whole device tree depth-first starting at the parent rather than just matching on its children. To make things worse, the parent mfd node was also prematurely freed. Note that the nodes ret

Re: [PATCH 1/3] backlight: as3711_bl: fix device-tree node lookup

2017-11-14 Thread Daniel Thompson
On 14/11/17 18:05, Johan Hovold wrote: On Mon, Nov 13, 2017 at 02:16:09PM +, Daniel Thompson wrote: On 13/11/17 10:20, Johan Hovold wrote: Fix child-node lookup during probe, which ended up searching the whole device tree depth-first starting at the parent rather than just matching on its

Re: [PATCH] backlight: ili922x: remove redundant variable len

2017-11-06 Thread Daniel Thompson
n Ian King Acked-by: Daniel Thompson --- drivers/video/backlight/ili922x.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/video/backlight/ili922x.c b/drivers/video/backlight/ili922x.c index a9e9cef..2b6c6aa 100644 --- a/drivers/video/backlight/ili922x.c +++

Re: [PATCH] platform/x86: dell-uart-backlight: new backlight driver for DELL AIO

2017-10-27 Thread Daniel Thompson
On 26/10/17 16:54, mario.limoncie...@dell.com wrote: +static int dell_uart_bl_add(struct acpi_device *dev) +{ + struct dell_uart_backlight *dell_pdata; + struct backlight_properties props; + struct backlight_device *dell_uart_bd; + + dell_pdata = kzalloc(sizeof(struct dell

Re: [PATCH v2 5/7] hwrng: st: Add support for ST's HW Random Number Generator

2015-10-05 Thread Daniel Thompson
Hi Lee Late but... On 17/09/15 14:45, Lee Jones wrote: diff --git a/drivers/char/hw_random/Makefile b/drivers/char/hw_random/Makefile index 055bb01..8bcfb45 100644 --- a/drivers/char/hw_random/Makefile +++ b/drivers/char/hw_random/Makefile @@ -30,4 +30,5 @@ obj-$(CONFIG_HW_RANDOM_TPM) += tpm-rn

Re: [PATCH v2 5/7] hwrng: st: Add support for ST's HW Random Number Generator

2015-10-05 Thread Daniel Thompson
On 05/10/15 13:11, Lee Jones wrote: On Mon, 05 Oct 2015, Daniel Thompson wrote: Late but... That's okay. Fixup patches can always be submitted. We have forever. :) On 17/09/15 14:45, Lee Jones wrote: diff --git a/drivers/char/hw_random/Makefile b/drivers/char/hw_random/Makefile

Re: [PATCH 2/3] hwrng: st: Report correct FIFO size

2015-10-06 Thread Daniel Thompson
read word. This means only 4 of the 8 available values are being read during each invocation of .read(). This change increased the device bandwidth by a factor of 2. Reported-by: Daniel Thompson Signed-off-by: Lee Jones --- drivers/char/hw_random/st-rng.c | 3 ++- 1 file changed, 2 insert

[PATCH 0/3] hwrng: stm32 - add support for STM32 HW RNG

2015-10-12 Thread Daniel Thompson
devm_hwrng_register. Daniel Thompson (3): dt-bindings: Document the STM32 HW RNG bindings hwrng: stm32 - add support for STM32 HW RNG ARM: dts: stm32f429: Adopt STM32 RNG driver .../devicetree/bindings/rng/st,stm32-rng.txt | 21 +++ arch/arm/boot/dts/stm32f429.dtsi

[PATCH 3/3] ARM: dts: stm32f429: Adopt STM32 RNG driver

2015-10-12 Thread Daniel Thompson
New bindings and driver have been created for STM32 series parts. This patch integrates this changes. Signed-off-by: Daniel Thompson Acked-by: Maxime Coquelin --- arch/arm/boot/dts/stm32f429.dtsi | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm/boot/dts/stm32f429.dtsi b/arch

[PATCH 2/3] hwrng: stm32 - add support for STM32 HW RNG

2015-10-12 Thread Daniel Thompson
Add support for STMicroelectronics STM32 random number generator. The config value defaults to N, reflecting the fact that STM32 is a very low resource microcontroller platform and unlikely to be targeted by any "grown up" defconfigs. Signed-off-by: Daniel Thompson --- drivers/char

[PATCH 1/3] dt-bindings: Document the STM32 HW RNG bindings

2015-10-12 Thread Daniel Thompson
This adds documentation of device tree bindings for the STM32 hardware random number generator. Signed-off-by: Daniel Thompson Acked-by: Maxime Coquelin Acked-by: Rob Herring --- .../devicetree/bindings/rng/st,stm32-rng.txt| 21 + 1 file changed, 21 insertions

Re: [PATCH v2 2/4] dmaengine: Add STM32 DMA driver

2015-10-13 Thread Daniel Thompson
On 13/10/15 15:05, M'boumba Cedric Madianga wrote: This patch adds support for the STM32 DMA controller. Signed-off-by: M'boumba Cedric Madianga --- drivers/dma/Kconfig | 12 + drivers/dma/Makefile|1 + drivers/dma/stm32-dma.c | 1175 +++

Re: [PATCH v2 2/4] dmaengine: Add STM32 DMA driver

2015-10-14 Thread Daniel Thompson
On 14/10/15 08:54, M'boumba Cedric Madianga wrote: +static int stm32_dma_alloc_chan_resources(struct dma_chan *c) +{ + struct stm32_dma_chan *chan = to_stm32_dma_chan(c); + struct stm32_dma_device *dmadev = stm32_dma_chan_get_dev(chan); + int ret; + + chan->config_init = f

Re: [PATCH v2 2/4] dmaengine: Add STM32 DMA driver

2015-10-14 Thread Daniel Thompson
On 14/10/15 14:17, M'boumba Cedric Madianga wrote: Hi Daniel, + +static int stm32_dma_remove(struct platform_device *pdev) +{ + struct stm32_dma_device *dmadev = platform_get_drvdata(pdev); + + of_dma_controller_free(pdev->dev.of_node); + + dma_async_device_unregister(&dmadev-

Re: [PATCH v2 2/4] dmaengine: Add STM32 DMA driver

2015-10-14 Thread Daniel Thompson
On 14/10/15 14:41, M'boumba Cedric Madianga wrote: 2015-10-14 15:29 GMT+02:00 Daniel Thompson : On 14/10/15 14:17, M'boumba Cedric Madianga wrote: Hi Daniel, + +static int stm32_dma_remove(struct platform_device *pdev) +{ + struct stm32_dma_device *dmadev = platform_get_dr

Re: [PATCH v2 2/4] dmaengine: Add STM32 DMA driver

2015-10-14 Thread Daniel Thompson
On 14/10/15 16:26, M'boumba Cedric Madianga wrote: 2015-10-14 16:24 GMT+02:00 Daniel Thompson : Hmnnn... The dmaengine framework will WARN_ONCE() if an dmaengine is removed whilst it is active and also works hard to ensure dmaengine modules are not removed whilst there are active dr

[PATCH v3 0/3] hwrng: stm32 - add support for STM32 HW RNG

2015-10-14 Thread Daniel Thompson
(Linus Walleij, Maxime Coquelin). * Only WARN_ONCE() when hardware failure mechanisms trigger (Maxime Coquelin). * Simplify end of probe function after cocci warning (Fengguang Wu). * Switch to devm_hwrng_register. Daniel Thompson (3): dt-bindings: Document the STM32 HW RNG bindings

[PATCH v3 1/3] dt-bindings: Document the STM32 HW RNG bindings

2015-10-14 Thread Daniel Thompson
This adds documentation of device tree bindings for the STM32 hardware random number generator. Signed-off-by: Daniel Thompson Acked-by: Maxime Coquelin Acked-by: Rob Herring --- .../devicetree/bindings/rng/st,stm32-rng.txt| 21 + 1 file changed, 21 insertions

[PATCH v3 3/3] ARM: dts: stm32f429: Adopt STM32 RNG driver

2015-10-14 Thread Daniel Thompson
New bindings and driver have been created for STM32 series parts. This patch integrates this changes. Signed-off-by: Daniel Thompson Acked-by: Maxime Coquelin --- arch/arm/boot/dts/stm32f429.dtsi | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm/boot/dts/stm32f429.dtsi b/arch

[PATCH v3 2/3] hwrng: stm32 - add support for STM32 HW RNG

2015-10-14 Thread Daniel Thompson
Add support for STMicroelectronics STM32 random number generator. The config value defaults to N, reflecting the fact that STM32 is a very low resource microcontroller platform and unlikely to be targeted by any "grown up" defconfigs. Signed-off-by: Daniel Thompson Reviewed-by: Lin

[PATCH] hwrng: stm32 - Fix build with CONFIG_PM

2015-10-14 Thread Daniel Thompson
Commit c6a97c42e399 ("hwrng: stm32 - add support for STM32 HW RNG") was inadequately tested (actually it was tested quite hard so incompetent would be a better description that inadequate) and does not compile on platforms with CONFIG_PM set. Fix this. Signed-off-by: Daniel Thompson

Re: [PATCH 2/7] includes: dt-bindings: Add STM32F429 pinctrl DT bindings

2015-10-15 Thread Daniel Thompson
On 14/10/15 21:07, Maxime Coquelin wrote: Signed-off-by: Maxime Coquelin --- include/dt-bindings/pinctrl/pinctrl-stm32.h | 12 + include/dt-bindings/pinctrl/stm32f429-pinfunc.h | 1241 +++ 2 files changed, 1253 insertions(+) create mode 100644 include/dt-bindings/

Re: [PATCH 2/7] includes: dt-bindings: Add STM32F429 pinctrl DT bindings

2015-10-15 Thread Daniel Thompson
On 15/10/15 12:29, Maxime Coquelin wrote: 2015-10-15 13:14 GMT+02:00 Daniel Thompson : On 14/10/15 21:07, Maxime Coquelin wrote: Signed-off-by: Maxime Coquelin --- include/dt-bindings/pinctrl/pinctrl-stm32.h | 12 + include/dt-bindings/pinctrl/stm32f429-pinfunc.h | 1241

[PATCH] hwrng: exynos - Fix unbalanced PM runtime get/puts

2015-10-16 Thread Daniel Thompson
Currently this driver calls pm_runtime_get_sync() rampantly but never puts anything back. This makes it impossible for the device to autosuspend properly; it will remain fully active after the first use. Fix in the obvious way. Signed-off-by: Daniel Thompson Cc: Kukjin Kim Cc: Krzysztof

Re: [PATCH v2 3/9] includes: dt-bindings: Add STM32F429 pinctrl DT bindings

2015-10-20 Thread Daniel Thompson
On 17/10/15 18:23, Maxime Coquelin wrote: Signed-off-by: Maxime Coquelin --- include/dt-bindings/pinctrl/pinctrl-stm32.h | 12 + include/dt-bindings/pinctrl/stm32f429-pinfunc.h | 1241 +++ 2 files changed, 1253 insertions(+) create mode 100644 include/dt-bindings/

Re: [PATCH v9 4/5] xhci: mediatek: support MTK xHCI host controller

2015-10-01 Thread Daniel Thompson
: Chunfeng Yun I've done some basic soak tests, both with a directly attached USB3 HDD and, given the extra code to manage isochronous xfer, also with a hub, disc and two audio interfaces. Tested-by: Daniel Thompson diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c

[PATCH 0/3] hwrng: stm32 - add support for STM32 HW RNG

2015-10-03 Thread Daniel Thompson
This patchset introduces a driver for the STM32 hardware random number generator. Daniel Thompson (3): dt-bindings: Document the STM32 HW RNG bindings hwrng: stm32 - add support for STM32 HW RNG ARM: dts: stm32f429: Adopt STM32 RNG driver .../devicetree/bindings/hwrng/stm32-rng.txt

[PATCH 1/3] dt-bindings: Document the STM32 HW RNG bindings

2015-10-03 Thread Daniel Thompson
This adds documenttaion of device tree binds for the STM32 hardware random number generator. Signed-off-by: Daniel Thompson --- .../devicetree/bindings/hwrng/stm32-rng.txt | 21 + 1 file changed, 21 insertions(+) create mode 100644 Documentation/devicetree/bindings

[PATCH 3/3] ARM: dts: stm32f429: Adopt STM32 RNG driver

2015-10-03 Thread Daniel Thompson
New bindings and driver have been created for STM32 series parts. This patch integrates this changes. Signed-off-by: Daniel Thompson --- arch/arm/boot/dts/stm32f429.dtsi | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm/boot/dts/stm32f429.dtsi b/arch/arm/boot/dts/stm32f429

[PATCH 2/3] hwrng: stm32 - add support for STM32 HW RNG

2015-10-03 Thread Daniel Thompson
Add support for STMicroelectronics STM32 random number generator. The config value defaults to N, reflecting the fact that STM32 is a very low resource microcontroller platform and unlikely to be targeted by any "grown up" defconfigs. Signed-off-by: Daniel Thompson --- drivers/char

Re: [PATCH 2/3] hwrng: stm32 - add support for STM32 HW RNG

2015-10-05 Thread Daniel Thompson
On 4 October 2015 at 11:32, Linus Walleij wrote: > On Sat, Oct 3, 2015 at 10:35 PM, Daniel Thompson > wrote: > >> Add support for STMicroelectronics STM32 random number generator. >> >> The config value defaults to N, reflecting the fact that STM32 is a >>

Re: [PATCH 2/3] hwrng: stm32 - add support for STM32 HW RNG

2015-10-05 Thread Daniel Thompson
On 4 October 2015 at 09:52, Maxime Coquelin wrote: > Hi Daniel, > > On 10/03/2015 10:35 PM, Daniel Thompson wrote: >> >> Add support for STMicroelectronics STM32 random number generator. >> >> The config value defaults to N, reflecting the fact that STM32 is a >

Re: [PATCH v5 00/27] arm64: provide pseudo NMI with GICv3

2018-08-29 Thread Daniel Thompson
rd priority instead so NMIs can still be raised. Some > corner cases though still require to actually mask all interrupts > effectively disabling the NMI. > > Daniel Thompson ran some benchmarks [3] on the previous version showing a > small (<1%) performance drop when using interr

Re: [Regression] usb: xhci: Add XHCI_TRUST_TX_LENGTH for Renesas uPD720201

2018-08-14 Thread Daniel Thompson
On Fri, Aug 10, 2018 at 12:13:53PM -0400, Joseph Salisbury wrote: > Hi Daniel, > > A kernel bug report was opened against Ubuntu [0].  It was found the > following patch introduced the regression: > > da9970668948 ("usb: xhci: Add XHCI_TRUST_TX_LENGTH for Renesas uPD720201") I can see nothing in

Re: [PATCH v4 00/26] arm64: provide pseudo NMI with GICv3

2018-07-20 Thread Daniel Thompson
ally slower than using the I-bit. It varies with the parrallel-ness of the build slightly but the slowdown on this platform is between 0.2% and 0.6% [1]. This delta was sufficiently small that I was willing to leave the PMR masking in place for a fair amount of my day to day work. On that basis these p

[PATCH v4] backlight: pwm_bl: Fix uninitialized variable

2018-07-25 Thread Daniel Thompson
l Ziswiler Signed-off-by: Daniel Thompson Tested-by: Marcel Ziswiler Reviewed-by: Douglas Anderson Acked-by: Lee Jones --- Notes: v4: - Remove line break from Fixes: and update the *-by:s v3: - Switch to the simplest fix and zero the uninitialized variable. git grep

Re: REGRESSION: [RESEND PATCH v3 1/4] backlight: pwm_bl: linear interpolation between brightness-levels

2018-07-15 Thread Daniel Thompson
&num_steps); ... this is not guaranteed to initialized num_steps ... > > + > > + /* > > +* Make sure that there is at least two entries in > > the > > +* brightness-levels table, otherwise we can't > > interpolate > > +*

Re: [PATCH v18 01/10] video: backlight: Add helpers to enable and disable backlight

2018-01-23 Thread Daniel Thompson
o to enforce a uniform and consistent > way to enable/disable a backlight device. > > Signed-off-by: Meghana Madhyastha > --- > Acked-by: Daniel Thompson > Reviewed-by: Noralf Trønnes > Reviewed-by: Sean Paul Just in case there's another spin... the additional

Re: [PATCH 4/8] thermal/drivers/Kconfig: Convert the CPU cooling device to a choice

2018-01-24 Thread Daniel Thompson
On Tue, Jan 23, 2018 at 04:34:27PM +0100, Daniel Lezcano wrote: > The next changes will add new way to cool down a CPU. In order to > sanitize and make the overall cpu cooling code consistent and robust > we must prevent the cpu cooling devices to co-exists with the same > purpose at the same time

Re: [PATCH 4/8] thermal/drivers/Kconfig: Convert the CPU cooling device to a choice

2018-01-25 Thread Daniel Thompson
On Wed, Jan 24, 2018 at 05:59:09PM +0100, Daniel Lezcano wrote: > On 24/01/2018 17:34, Daniel Thompson wrote: > > On Tue, Jan 23, 2018 at 04:34:27PM +0100, Daniel Lezcano wrote: > >> The next changes will add new way to cool down a CPU. In order to > >> sanitize and m

Re: [PATCH v19 10/10] drm/omapdrm: Use of_find_backlight helper

2018-01-25 Thread Daniel Thompson
On Wed, Jan 24, 2018 at 02:26:48PM -0500, Sean Paul wrote: > So, > > Reviewed-by: Sean Paul > > I think every other patch has R-b, so if no one objects in the next day or so, > I'll apply this to drm-misc-next No problems on my side... but please make sure Lee J. gets a PR. Daniel.

Re: [PATCH] kdb: Change timespec to use timespec64

2018-01-25 Thread Daniel Thompson
On Thu, Jan 25, 2018 at 05:18:54PM +0800, Baolin Wang wrote: > On 25 January 2018 at 16:55, Arnd Bergmann wrote: > > On Thu, Jan 25, 2018 at 9:05 AM, Baolin Wang wrote: > >> @@ -2554,7 +2554,7 @@ static int kdb_summary(int argc, const char **argv) > >> kdb_printf("domainname %s\n", init_u

Re: [PATCH v4] backlight: report error on failure

2017-05-15 Thread Daniel Thompson
one or not. backlight_update_status() returns the error code if it fails. Pass that to the userspace client who is trying to update the power so that the client knows that the operation failed. Signed-off-by: Sudip Mukherjee Acked-by: Daniel Thompson --- v4: ABI comment removed from commit

Re: [PATCH 3/4] backlight: pwm_bl: compute brightness of LED linearly to human eye.

2018-01-12 Thread Daniel Thompson
On Fri, Jan 12, 2018 at 11:14:54AM +0100, Enric Balletbo Serra wrote: > > @@ -441,6 +544,26 @@ static int pwm_backlight_probe(struct platform_device > > *pdev) > > > > dev_dbg(&pdev->dev, "got pwm for backlight\n"); > > > > + if (!data->levels) { > > + /* Get the PWM pe

Re: [PATCH v2] kdb: use ktime_get_mono_fast_ns() instead of ktime_get_ts()

2018-01-30 Thread Daniel Thompson
h we entered the debugger. > > Thus we can use the ktime_get_mono_fast_ns() to get the monotonic > time, which is NMI safe access to clock monotonic. Moreover we can > remove the 'struct timespec', which is not y2038 safe. > > Signed-off-by: Baolin Wang Reviewed-by: Dan

Re: [PATCH 4/8] thermal/drivers/Kconfig: Convert the CPU cooling device to a choice

2018-01-31 Thread Daniel Thompson
On Fri, Jan 26, 2018 at 02:25:58PM +0100, Daniel Lezcano wrote: > > Perhaps I should have distinguished more between runtime-meaning-boot-time > > and runtime-meaning-full-system-operation. To be clear none of my > > comments are about being able to enable/disable idle injection on a > > fully runn

Re: [PATCH 1/5] backlight: lp8788: document sysfs attributes

2018-01-31 Thread Daniel Thompson
On Fri, Jan 26, 2018 at 08:20:08PM +0530, Aishwarya Pant wrote: > Add documentation for sysfs interfaces of lp8788 backlight driver by > looking through the code and the git commit history. > > Signed-off-by: Aishwarya Pant > --- > Documentation/ABI/testing/sysfs-class-backlight-lp8788 | 10

Re: [PATCH 3/5] backlight: lm3639: document sysfs attributes

2018-01-31 Thread Daniel Thompson
nstruments lm3639 backlight + flash led driver > chip > +-- > + > +What:/sys/class/backlight//bled_mode > +Date:Oct, 2012 > +KernelVersion: v3.10 > +Contact: Lee Jones , > + Daniel Thompson , > + Jingoo

Re: [PATCH 2/5] backlight: lp855x: document sysfs attributes

2018-02-01 Thread Daniel Thompson
On Fri, Jan 26, 2018 at 08:23:00PM +0530, Aishwarya Pant wrote: > Add documentation for sysfs interface of Texas Instruments lp855x > backlight driver by reading code and looking through git commit logs. > > Signed-off-by: Aishwarya Pant > --- > .../ABI/testing/sysfs-class-backlight-lp855x

Re: [PATCH 1/5] backlight: lp8788: document sysfs attributes

2018-02-01 Thread Daniel Thompson
On Wed, Jan 31, 2018 at 01:51:21PM +0200, Jani Nikula wrote: > On Wed, 31 Jan 2018, Daniel Thompson wrote: > > On Fri, Jan 26, 2018 at 08:20:08PM +0530, Aishwarya Pant wrote: > >> Add documentation for sysfs interfaces of lp8788 backlight driver by > >> looking through

Re: [PATCH v17 01/10] video: backlight: Add helpers to enable and disable backlight

2018-01-19 Thread Daniel Thompson
o to enforce a uniform and consistent > way to enable/disable a backlight device. > > Signed-off-by: Meghana Madhyastha Acked-by: Daniel Thompson BTW Lee J. looks PRs and merges for the backlight tree, I'll leave it to Lee and whoevers-DRM-tree-this-would-naturally-land-in

Re: [PATCH v17 03/10] video: backlight: Add of_find_backlight helper in backlight.c

2018-01-19 Thread Daniel Thompson
On Fri, Jan 19, 2018 at 10:42:15AM +, Meghana Madhyastha wrote: > Add of_find_backlight, a helper function which is a generic version > of tinydrm_of_find_backlight that can be used by other drivers to avoid > repetition of code and simplify things. > > Signed-off-by: Meghana Madhyastha Didn

Re: [PATCH v17 05/10] video: backlight: Add devres versions of of_find_backlight

2018-01-19 Thread Daniel Thompson
On Fri, Jan 19, 2018 at 10:44:33AM +, Meghana Madhyastha wrote: > Add devm_of_find_backlight and the corresponding release > function because some drivers use devres versions of functions > for acquiring device resources. > > Signed-off-by: Meghana Madhyastha Acked-by:

Re: [PATCH v17 00/10] Add backlight helper functions

2018-01-19 Thread Daniel Thompson
On Fri, Jan 19, 2018 at 10:37:58AM +, Meghana Madhyastha wrote: > Move drm helper functions from tinydrm-helpers to linux/backlight for > ease of use by callers in other drivers. > > changes in v17: > -set fb_blank along with clearing the BL_CORE_FBBLANK bit > -rebase with drm-misc-next > -fi

Re: [PATCH 2/4] dt-bindings: pwm-backlight: add a num-interpolation-steps property.

2018-01-22 Thread Daniel Thompson
On Fri, Jan 19, 2018 at 02:52:49PM -0600, Rob Herring wrote: > On Wed, Jan 10, 2018 at 11:30:44PM +0100, Enric Balletbo i Serra wrote: > > The num-interpolated-steps property specifies the number of > > interpolated steps between each value of brightness-level table. This is > > useful for high res

Re: [PATCH v2 1/6] arm64: cpufeature: Allow early detect of specific features

2018-01-22 Thread Daniel Thompson
On Mon, Jan 22, 2018 at 12:21:55PM +, Julien Thierry wrote: > On 22/01/18 12:05, Suzuki K Poulose wrote: > > On 17/01/18 11:54, Julien Thierry wrote: > > > From: Daniel Thompson > > > > > > Currently it is not possible to detect features of the boot CPU

Re: [PATCH] make RUNTIME_TESTS a menuconfig to ease disabling it all

2018-01-05 Thread Daniel Thompson
On 09/12/17 16:27, Vincent Legoll wrote: No need to get into the submenu to disable all related config entries. This makes it easier to disable all RUNTIME_TESTS config options without entering the submenu. It will also enable one to see that en/dis-abled state from the outside menu. This is

Re: [PATCH 4/8] thermal/drivers/Kconfig: Convert the CPU cooling device to a choice

2018-01-26 Thread Daniel Thompson
On Thu, Jan 25, 2018 at 02:36:12PM +0100, Daniel Lezcano wrote: > On 25/01/2018 11:57, Daniel Thompson wrote: > > On Wed, Jan 24, 2018 at 05:59:09PM +0100, Daniel Lezcano wrote: > >> On 24/01/2018 17:34, Daniel Thompson wrote: > >> However, we are talking about distr

Re: [PATCH] kdb: use ktime_get_seconds() instead of ktime_get_ts()

2018-01-26 Thread Daniel Thompson
On Fri, Jan 26, 2018 at 10:21:58AM +0100, Arnd Bergmann wrote: > On Fri, Jan 26, 2018 at 4:03 AM, Baolin Wang wrote: > > The kdb code will print the monotonic time by ktime_get_ts(), but > > the ktime_get_ts() will be protected by a sequence lock, that will > > introduce one deadlock risk if the l

Re: [PATCH 1/6] backlight: Nuke unused backlight.props.state states

2018-01-17 Thread Daniel Thompson
technical reason to have the intermediate fbdev power states for backlights (those really only can be either off or on). Cleanup motivated by Meghana's questions about all this. Cc: Lee Jones Cc: Daniel Thompson Cc: Jingoo Han Cc: Meghana Madhyastha Signed-off-by: Daniel Vetter Ack

Re: [PATCH 2/6] backlight/generic-bl: remove DRIVER1 state

2018-01-17 Thread Daniel Thompson
On 17/01/18 14:36, Emil Velikov wrote: On 17 January 2018 at 14:01, Daniel Vetter wrote: Nothing in the entire tree ever sets this, which means this is dead code. Remove it. Cc: Lee Jones Cc: Daniel Thompson Cc: Jingoo Han Signed-off-by: Daniel Vetter --- drivers/video/backlight

Re: [PATCH 2/6] backlight/generic-bl: remove DRIVER1 state

2018-01-17 Thread Daniel Thompson
On 17/01/18 14:01, Daniel Vetter wrote: Nothing in the entire tree ever sets this, which means this is dead code. Remove it. Cc: Lee Jones Cc: Daniel Thompson Cc: Jingoo Han Signed-off-by: Daniel Vetter Not sure whether to ack this one or not. There is nothing wrong with the change but

Re: [PATCH 3/6] backlight/pandora: Stop using BL_CORE_DRIVER1

2018-01-17 Thread Daniel Thompson
On 17/01/18 14:01, Daniel Vetter wrote: Leaking driver internal tracking into the already massively confusing backlight power tracking is really confusing. Stop that by allocating a tiny driver private data structure instead. Cc: Lee Jones Cc: Daniel Thompson Cc: Jingoo Han Signed-off-by

Re: [PATCH 4/6] staging/fbtft: Stop using BL_CORE_DRIVER1

2018-01-17 Thread Daniel Thompson
On 17/01/18 14:01, Daniel Vetter wrote: Leaking driver internal tracking into the already massively confusing backlight power tracking is really confusing. Luckily we have already a drvdata structure, so fixing this is really easy. Cc: Lee Jones Cc: Daniel Thompson Cc: Jingoo Han Cc: Thomas

Re: [PATCH 5/6] backlight: Also nuke BL_CORE_DRIVER1

2018-01-17 Thread Daniel Thompson
Thompson Cc: Jingoo Han Signed-off-by: Daniel Vetter Acked-by: Daniel Thompson --- include/linux/backlight.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/linux/backlight.h b/include/linux/backlight.h index 9776edb0ff06..b6f7c99d1c8e 100644 --- a/include/linux/backlight.h +++ b

Re: [PATCH 6/6] MAINTAINERS: add dri-devel for backlight subsystem patches

2018-01-17 Thread Daniel Thompson
light subsystem is miniscule compared to drm overall. Cc: Lee Jones Cc: Daniel Thompson Cc: Jingoo Han Signed-off-by: Daniel Vetter Acked-by: Daniel Thompson --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 7691e1025708..6534517f53b6 100644

Re: [PATCH v16 01/10] video: backlight: Add helpers to enable and disable backlight

2018-01-17 Thread Daniel Thompson
On 16/01/18 10:31, Meghana Madhyastha wrote: Add helper functions backlight_enable and backlight_disable to enable/disable a backlight device. These helper functions can then be used by different drm and tinydrm drivers to avoid repetition of code and also to enforce a uniform and consistent wa

Re: [PATCH v16 03/10] video: backlight: Add of_find_backlight helper in backlight.c

2018-01-17 Thread Daniel Thompson
On 16/01/18 10:33, Meghana Madhyastha wrote: Add of_find_backlight, a helper function which is a generic version of tinydrm_of_find_backlight that can be used by other drivers to avoid repetition of code and simplify things. Signed-off-by: Meghana Madhyastha Acked-by: Daniel Thompson

Re: [PATCH v16 05/10] video: backlight: Add devres versions of of_find_backlight

2018-01-17 Thread Daniel Thompson
On 16/01/18 10:34, Meghana Madhyastha wrote: Add devm_of_find_backlight and the corresponding release function because some drivers use devres versions of functions for acquiring device resources. Signed-off-by: Meghana Madhyastha --- drivers/video/backlight/backlight.c | 29 +

Re: [PATCH 2/6] backlight/generic-bl: remove DRIVER1 state

2018-01-18 Thread Daniel Thompson
On 17/01/18 17:13, Daniel Vetter wrote: On Wed, Jan 17, 2018 at 04:44:00PM +, Daniel Thompson wrote: On 17/01/18 14:01, Daniel Vetter wrote: Nothing in the entire tree ever sets this, which means this is dead code. Remove it. Cc: Lee Jones Cc: Daniel Thompson Cc: Jingoo Han Signed

Re: [PATCH 3/6] backlight/pandora: Stop using BL_CORE_DRIVER1

2018-01-18 Thread Daniel Thompson
On 17/01/18 21:38, Daniel Vetter wrote: Thanks a lot for your comments. On Wed, Jan 17, 2018 at 04:47:41PM +, Daniel Thompson wrote: On 17/01/18 14:01, Daniel Vetter wrote: Leaking driver internal tracking into the already massively confusing backlight power tracking is really confusing

Re: [PATCH v16 05/10] video: backlight: Add devres versions of of_find_backlight

2018-01-18 Thread Daniel Thompson
On Thu, Jan 18, 2018 at 04:32:26PM +0530, Meghana Madhyastha wrote: > On Wed, Jan 17, 2018 at 05:09:57PM +0000, Daniel Thompson wrote: > > On 16/01/18 10:34, Meghana Madhyastha wrote: > > >Add devm_of_find_backlight and the corresponding release > > >function beca

Re: [PATCH v16 01/10] video: backlight: Add helpers to enable and disable backlight

2018-01-18 Thread Daniel Thompson
On Thu, Jan 18, 2018 at 04:29:23PM +0530, Meghana Madhyastha wrote: > On Wed, Jan 17, 2018 at 11:03:24PM +0100, Noralf Trønnes wrote: > > > > Den 17.01.2018 18.00, skrev Daniel Thompson: > > > > > > > > >On 16/01/18 10:31, Meghana Madhyastha wrote: >

Re: [PATCH 3/3] backlight: pwm_bl: don't use GPIOF_* with gpiod_get_direction

2018-01-15 Thread Daniel Thompson
ystem-wide solution is in place). Signed-off-by: Wolfram Sang Acked-by: Daniel Thompson --- Only build tested! drivers/video/backlight/pwm_bl.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_

Re: [PATCH] Documentation/locking: Document the semantics of spin_is_locked()

2018-03-07 Thread Daniel Thompson
On Wed, Mar 07, 2018 at 02:13:41PM +0100, Andrea Parri wrote: > On Wed, Feb 28, 2018 at 01:15:23PM +0100, Andrea Parri wrote: > > On Wed, Feb 28, 2018 at 11:34:56AM +, Will Deacon wrote: > > [...] > > >> only if there's some evidence that you've looked at the callsites > >> and determined tha

Re: [RFC PATCH] irqchip: arm-gic: take gic_lock when updating irq type

2018-03-26 Thread Daniel Thompson
On Thu, Mar 22, 2018 at 12:19:15PM +, Marc Zyngier wrote: > On 22/03/18 10:28, Aniruddha Banerjee wrote: > [a PGP-encrypted email] > > Given that you're cc-ing various mailing lists, please resend this email > unencrypted. I am very puzzled about what is going on here. I could read the origi

Re: [PATCH v6 2/5] dt-bindings: pwm-backlight: add PWM delay proprieties.

2018-03-26 Thread Daniel Thompson
ing > the backlight using GPIO and setting PWM value to 0. The pwm-off-delay-ms > is this delay in milli seconds. > > Signed-off-by: Enric Balletbo i Serra > Acked-by: Pavel Machek > Acked-by: Thierry Reding Acked-by: Daniel Thompson > --- > Based on the original Hu

Re: [PATCH v6 1/5] pwm-backlight: enable/disable the PWM before/after LCD enable toggle.

2018-03-26 Thread Daniel Thompson
On Mon, Mar 26, 2018 at 04:40:21PM +0200, Enric Balletbo Serra wrote: > Hi Pavel, > > 2018-03-26 12:42 GMT+02:00 Pavel Machek : > > On Mon 2018-03-26 11:52:09, Enric Balletbo i Serra wrote: > >> Before this patch the enable signal was set before the PWM signal and > >> vice-versa on power off. Thi

Re: [PATCH] arm: kgdb: fix NUMREGBYTES so that gdb_regs[] is the correct size

2018-04-06 Thread Daniel Thompson
On 06/04/18 14:25, Daniel Thompson wrote: On Thu, Apr 05, 2018 at 04:09:16PM -0400, David Rivshin wrote: From: David Rivshin NUMREGBYTES (which is used as the size for gdb_regs[]) is incorrectly based on DBG_MAX_REG_NUM instead of GDB_MAX_REGS. DBG_MAX_REG_NUM is the number of total registers

Re: [PATCH] arm: kgdb: fix NUMREGBYTES so that gdb_regs[] is the correct size

2018-04-06 Thread Daniel Thompson
hin I pointed some trivial autotests at both gdb-7.12 and gdb-8.0. Results look good to me! Tested-by: Daniel Thompson > --- > arch/arm/include/asm/kgdb.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/include/asm/kgdb.h b/arch/arm/include/asm

Re: [PATCH v3 1/4] backlight: pwm_bl: linear interpolation between brightness-levels

2018-04-06 Thread Daniel Thompson
tness-levels = <0 4096 65535>; > num-interpolated-steps = <1024>; > default-brightness-level = <512>; > > This will create a brightness-levels table with the following values: > > <0 4 8 12 16 20 ... 4096 4156 4216 4276 ... 65535> > > Signed-of

Re: [PATCH v3 3/4] backlight: pwm_bl: compute brightness of LED linearly to human eye.

2018-04-06 Thread Daniel Thompson
x27; propriety in your > device tree. > > Signed-off-by: Enric Balletbo i Serra Acked-by: Daniel Thompson > --- > Changes since v2: > - None > Changes since v1: > - Fix an horrible and unjustifiable mistake a missing { fortuna

Re: [PATCH v3 0/4] backlight: pwm_bl: support linear interpolation and brightness to human eye

2018-04-06 Thread Daniel Thompson
On Tue, Mar 20, 2018 at 01:13:20PM +0100, Enric Balletbo Serra wrote: > Hi Daniel, > > > 2018-03-20 12:22 GMT+01:00 Daniel Thompson : > > On Mon, Mar 19, 2018 at 05:04:31PM +0100, Enric Balletbo Serra wrote: > >> Hi Daniel, > >> > >> Gentle ping for t

Re: [PATCH v3 6/7] thermal/drivers/cpu_cooling: Introduce the cpu idle cooling driver

2018-04-13 Thread Daniel Thompson
On Thu, Apr 05, 2018 at 06:16:43PM +0200, Daniel Lezcano wrote: > +/** > + * cpuidle_cooling_register - Idle cooling device initialization function > + * > + * This function is in charge of creating a cooling device per cluster > + * and register it to thermal framework. For this we rely on the > +

Re: [PATCH v3 0/4] backlight: pwm_bl: support linear interpolation and brightness to human eye

2018-03-20 Thread Daniel Thompson
On Mon, Mar 19, 2018 at 05:04:31PM +0100, Enric Balletbo Serra wrote: > Hi Daniel, > > Gentle ping for this series, there is any possibility you have a > chance to review it? Let me know if you want I change something. I haven't got it in my TODO backlog... which means either I mistakenly deleted

Re: [PATCH V2 5/7] thermal/drivers/cpu_cooling: Add idle cooling device documentation

2018-03-08 Thread Daniel Thompson
On Thu, Mar 08, 2018 at 09:59:49AM +0100, Pavel Machek wrote: > Hi! > > > >> +Under certain circumstances, the SoC reaches a temperature exceeding > > >> +the allocated power budget or the maximum temperature limit. The > > > > > > I don't understand. Power budget is in W, temperature is in > > >

Re: [PATCH V2 0/7] CPU cooling device new strategies

2018-03-08 Thread Daniel Thompson
On Wed, Mar 07, 2018 at 07:57:17PM +0100, Daniel Lezcano wrote: > >> The preliminary benchmarks show the following changes: > >> > >> On the hikey6220, dhrystone shows a throughtput increase of 40% for an > >> increase of the latency of 16% while sysbench shows a latency increase > >> of 5%. > > >

  1   2   3   4   5   6   7   8   9   10   >