On Thu, Apr 20, 2017 at 10:44 AM, Arnd Bergmann wrote:
> On Thu, Apr 20, 2017 at 8:48 AM, Daniel Baluta
> wrote:
>> Hi Arnd,
>>
>> On Wed, Apr 19, 2017 at 8:04 PM, Arnd Bergmann wrote:
>>> The new PLL configuration code triggers a harmless warning:
>
On Wed, Apr 19, 2017 at 11:20 AM, Eugen Hristev
wrote:
> Increased trigger length to 50 in order to cope with trigger names like
> fc03.adc-dev0-external-rising
>
> Signed-off-by: Eugen Hristev
> ---
> tools/iio/iio_utils.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --g
.html
Second one does the actual bitclk relaxation.
Daniel Baluta (2):
ASoC: codec: wm9860: avoid maybe-uninitialized warning
ASoC: codec: wm8960: Relax bit clock computation when using PLL
sound/soc/codecs/wm8960.c | 29 -
1 file changed, 20 insertions(+), 9 dele
ets do the same thing when sysclk is derived via PLL.
Signed-off-by: Daniel Baluta
---
Here, I forced the following harmless initialization:
*sysclk_idx = *dac_idx = *bclk_idx = -1;
otherwise I would trigger a gcc false positive warning:
sound/soc/codecs/wm8960.c: I
8960: Stop when a matching PLL freq is
found")
Suggested-by: Arnd Bergmann
Signed-off-by: Daniel Baluta
---
Arnd,
I agree that your code was more both humans and gcc anyhow
for consistency with wm8960_configure_sysclk function I preferred
to keep the "if(..) break" statements.
soun
ets do the same thing when sysclk is derived via PLL.
Signed-off-by: Daniel Baluta
---
Changes since v2:
* rebase after changes in first patch in the series
sound/soc/codecs/wm8960.c | 18 --
1 file changed, 16 insertions(+), 2 deletions(-)
diff --git a/sound/soc/codecs/
4af8d ("ASoC: codec: wm8960: Stop when a matching PLL freq is
found")
Suggested-by: Arnd Bergmann
Signed-off-by: Daniel Baluta
---
Changes since v1:
* use return instead of break
* update commit message
sound/soc/codecs/wm8960.c | 26 +-
1 file chang
.html
Second one does the actual bitclk relaxation.
Daniel Baluta (2):
ASoC: codec: wm9860: avoid maybe-uninitialized warning
ASoC: codec: wm8960: Relax bit clock computation when using PLL
sound/soc/codecs/wm8960.c | 36 +---
1 file changed, 21 insertions(+
On Jo, 2017-04-27 at 12:07 +0200, Arnd Bergmann wrote:
> On Wed, Apr 26, 2017 at 3:09 PM, Daniel Baluta > wrote:
> >
> > The new PLL configuration code triggers a harmless warning:
> >
> > sound/soc/codecs/wm8960.c: In function 'wm8960_configure_clocking&#x
On Thu, Jan 15, 2015 at 3:34 PM, Zidan Wang wrote:
> On Wed, Jan 14, 2015 at 07:27:03PM +, Mark Brown wrote:
>> On Wed, Jan 07, 2015 at 03:31:45PM +0800, Zidan Wang wrote:
>>
>> > + for (i = 0; i < ARRAY_SIZE(dac_divs); ++i) {
>> > + if (wm8960->sysclk == lrclk * dac_divs[i]) {
>>
On Mon, Apr 3, 2017 at 4:34 PM, Charles Keepax
wrote:
> On Mon, Apr 03, 2017 at 04:16:23PM +0300, Daniel Baluta wrote:
>> On Thu, Jan 15, 2015 at 3:34 PM, Zidan Wang wrote:
>> > On Wed, Jan 14, 2015 at 07:27:03PM +, Mark Brown wrote:
>> >> On Wed, Jan 07, 2015 a
On Mon, Apr 3, 2017 at 4:54 PM, Charles Keepax
wrote:
> On Mon, Apr 03, 2017 at 04:39:40PM +0300, Daniel Baluta wrote:
>> On Mon, Apr 3, 2017 at 4:34 PM, Charles Keepax
>> wrote:
>> > On Mon, Apr 03, 2017 at 04:16:23PM +0300, Daniel Baluta wrote:
>> > Does th
Add a separate function for deriving (sysclk, lrclk, bclk)
when the clock is auto or pll.
Signed-off-by: Daniel Baluta
---
sound/soc/codecs/wm8960.c | 93 ---
1 file changed, 64 insertions(+), 29 deletions(-)
diff --git a/sound/soc/codecs/wm8960.c b
This is a follow up of commit 3c01b9ee2ab ("ASoC: codec: wm8960: Relax bit
clock computation")
where we relaxed bitclk when sysclk was derived from MCLK.
Now, we do the same thing for sysclk derived using PLL.
Daniel Baluta (2):
ASoC: codec: wm9860: Refactor PLL out freq search
A
ets do the same thing when sysclk is derived via PLL.
Signed-off-by: Daniel Baluta
---
sound/soc/codecs/wm8960.c | 14 +-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/sound/soc/codecs/wm8960.c b/sound/soc/codecs/wm8960.c
index 36c8454..e8cb764 100644
--- a/sound/
On Tue, Apr 4, 2017 at 7:45 PM, Daniel Baluta wrote:
> Add a separate function for deriving (sysclk, lrclk, bclk)
> when the clock is auto or pll.
>
> Signed-off-by: Daniel Baluta
Just noticed this warnings:
sound/soc/codecs/wm8960.c:743:3: warning: 'best_freq_out' may be
warnings [i strongly believe
they were compiler false positive - see full warning log here (1)]
* fixed break for inner loop
[1] http://mailman.alsa-project.org/pipermail/alsa-devel/2017-April/119513.html
Daniel Baluta (2):
ASoC: codec: wm9860: Refactor PLL out freq search
ASoC:
Add a separate function for deriving (sysclk, lrclk, bclk)
when the clock is auto or pll.
Signed-off-by: Daniel Baluta
Acked-by: Charles Keepax
---
sound/soc/codecs/wm8960.c | 97 +--
1 file changed, 68 insertions(+), 29 deletions(-)
diff --git a
ets do the same thing when sysclk is derived via PLL.
Signed-off-by: Daniel Baluta
Acked-by: Charles Keepax
---
sound/soc/codecs/wm8960.c | 14 +-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/sound/soc/codecs/wm8960.c b/sound/soc/codecs/wm8960.c
index 1c973f0..8ab9
did
in patch 2/2 of previous series.
Daniel Baluta (2):
ASoC: codec: wm8960: Stop when a matching PLL freq is found
ASoC: codec: wm8960: Relax bit clock computation when using PLL
sound/soc/codecs/wm8960.c | 20 ++--
1 file changed, 18 insertions(+), 2 deletions(-)
--
2.7.4
When a matching PLL freq is found, searching continues even this is
not necessary. The problem was introduced with the following refactoring
commit 84fdc00d519ffd ("ASoC: codec: wm9860: Refactor PLL out freq search)
Signed-off-by: Daniel Baluta
---
sound/soc/codecs/wm8960.c | 4
1
ets do the same thing when sysclk is derived via PLL.
Signed-off-by: Daniel Baluta
Acked-by: Charles Keepax
---
sound/soc/codecs/wm8960.c | 16 ++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/sound/soc/codecs/wm8960.c b/sound/soc/codecs/wm8960.c
index ace69da..8ab9
On Fri, Apr 21, 2017 at 5:46 PM, Arnd Bergmann wrote:
> On Fri, Apr 21, 2017 at 3:07 PM, Daniel Baluta wrote:
>> The new PLL configuration code triggers a harmless warning:
>>
>> sound/soc/codecs/wm8960.c: In function 'wm8960_configure_clocking':
>> s
On Mon, Apr 24, 2017 at 6:27 PM, Arnd Bergmann wrote:
> On Mon, Apr 24, 2017 at 3:15 PM, Daniel Baluta
> wrote:
>> On Fri, Apr 21, 2017 at 5:46 PM, Arnd Bergmann wrote:
>>> On Fri, Apr 21, 2017 at 3:07 PM, Daniel Baluta
>>> wrote:
>>>> The new
Use // for .c and /* for .h files according to:
Documentation/process/license-rules.rst file.
Signed-off-by: Daniel Baluta
---
sound/soc/codecs/ak5558.c | 11 +--
sound/soc/codecs/ak5558.h | 4 ++--
2 files changed, 7 insertions(+), 8 deletions(-)
diff --git a/sound/soc/codecs/ak5558
Hi Pierre,
Few comments inline:
On Wed, Feb 21, 2018 at 2:55 PM, Pierre Bourdon wrote:
> Ambient light sensor that supports visible light and IR measurements and
> configurable gain/integration time.
>
Can you have a quick look to existing ROHM light sensor support.
Perhaps your sensor
is simil
On Wed, Feb 21, 2018 at 4:05 PM, Rodrigo Siqueira
wrote:
> This patch fixes the following checkpatch.pl warnings:
>
> drivers/iio/dummy/iio_simple_dummy.c:603: WARNING: Block comments should
> align the * on each line
> drivers/iio/dummy/iio_dummy_evgen.c:151: WARNING: Symbolic permissions
> 'S_IW
On Wed, Feb 21, 2018 at 6:15 PM, Pierre Bourdon (delroth)
wrote:
> Hi Daniel,
>
> On Wed, Feb 21, 2018 at 4:31 PM, Daniel Baluta
> wrote:
>> On Wed, Feb 21, 2018 at 2:55 PM, Pierre Bourdon wrote:
>>> Ambient light sensor that supports visible light and IR measurement
On Wed, Feb 21, 2018 at 9:28 PM, Rodrigo Siqueira
wrote:
> This patch fixes the checkpatch.pl warning:
>
> drivers/iio/dummy/iio_dummy_evgen.c:151: WARNING: Symbolic permissions
> 'S_IWUSR' are not preferred. Consider using octal permissions '0200'.
> ... Why this "..." :)?
Commit subject could
Hi Dan,
On Jo, 2018-02-22 at 10:43 +0300, Dan Carpenter wrote:
> On Wed, Feb 21, 2018 at 11:01:50PM +0200, Daniel Baluta wrote:
> >
> > On Wed, Feb 21, 2018 at 9:28 PM, Rodrigo Siqueira
> > wrote:
> > >
> > > This patch fixes the checkpatch.pl
power_on alone isn't enough. With just power_on after resume aplay plays a
song for 1 seconds and then the sound stops.
Datasheet says, page 55"
(1) The PDN pin should be held to “L” for more than 150 ns after AVDD and TVDD
are powered up.
Daniel Baluta (2):
ASoC: codecs: Add support for
]
Signed-off-by: Mihai Serban
[cleanups and porting to 4.9 kernel]
Signed-off-by: Shengjiu Wang
[tdm support]
Signed-off-by: Daniel Baluta
[pm support, cleanups and porting to latest kernel]
---
sound/soc/codecs/Kconfig | 6 +
sound/soc/codecs/Makefile | 2 +
sound/soc/codecs/ak5558.c | 626
Signed-off-by: Daniel Baluta
---
Documentation/devicetree/bindings/sound/ak5558.txt | 23 ++
1 file changed, 23 insertions(+)
create mode 100644 Documentation/devicetree/bindings/sound/ak5558.txt
diff --git a/Documentation/devicetree/bindings/sound/ak5558.txt
b
On Sun, Feb 4, 2018 at 4:31 PM, Andy Shevchenko
wrote:
> On Sat, Feb 3, 2018 at 1:11 AM, Mark Brown wrote:
>> On Fri, Feb 02, 2018 at 09:33:18PM +0200, Andy Shevchenko wrote:
>>> On Fri, Feb 2, 2018 at 6:20 PM, Daniel Baluta wrote:
>>
>>> > +static int ak
]
Signed-off-by: Mihai Serban
[cleanups and porting to 4.9 kernel]
Signed-off-by: Shengjiu Wang
[tdm support]
Signed-off-by: Daniel Baluta
[pm support, cleanups and porting to latest kernel]
---
sound/soc/codecs/Kconfig | 6 +
sound/soc/codecs/Makefile | 2 +
sound/soc/codecs/ak5558.c | 618
Document the bindings for AK5558 ADC.
Signed-off-by: Daniel Baluta
---
Documentation/devicetree/bindings/sound/ak5558.txt | 22 ++
1 file changed, 22 insertions(+)
create mode 100644 Documentation/devicetree/bindings/sound/ak5558.txt
diff --git a/Documentation/devicetree
x27;t enough. With just power_on after resume aplay plays a
song for 1 seconds and then the sound stops.
Datasheet says, page 55"
(1) The PDN pin should be held to “L” for more than 150 ns after AVDD and TVDD
are powered up.
Daniel Baluta (2):
ASoC: codecs: Add support for AK5558 ADC dri
On Vi, 2018-02-16 at 12:14 +, Mark Brown wrote:
> On Tue, Feb 13, 2018 at 04:29:33PM +0200, Daniel Baluta wrote:
>
> >
> > +++ b/sound/soc/codecs/ak5558.c
> > @@ -0,0 +1,417 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> Just make this a C++ c
Hi Rodrigo,
I think this is a nice finding. One comment inline:
On Vi, 2018-02-16 at 10:50 -0200, rodrigosiqueira wrote:
> This patch fixes the checkpatch.pl warning:
>
> drivers/staging/iio/meter/ade7854.h:157: WARNING: function definition
> argument 'struct device *' should also have an identi
Hi Rodrigo,
Mostly looking good. Few comments.
Please read:
https://chris.beams.io/posts/git-commit/
1) Capitalize the first letter of commit
2) Use prefix tags to indicate the driver that is changed. Here
iio:pressure:ms5611.
If not sure what prefix tags to use please use git log file.c and
On Lu, 2018-02-12 at 12:02 +, Mark Brown wrote:
> On Mon, Feb 05, 2018 at 07:01:54PM +0200, Daniel Baluta wrote:
> >
> > AK5558 is a 32-bit, 768 kHZ sampling, differential input ADC
> > for digital audio systems.
> >
> > --- /dev/null
> > +++ b/sound
ifier
* remove debug prints at the beginning of functions.
* only support auto clock switching (manual switching was dead code anyway)
(in the
future we could add a DT property to choose between manual and auto)
* Use gpiod API
* use GENMASK
* introduce power_off/power_on
Daniel Baluta (2):
-off-by: Junichi Wakasugi
[initial coding for 3.18 kernel]
Signed-off-by: Mihai Serban
[cleanups and porting to 4.9 kernel]
Signed-off-by: Shengjiu Wang
[tdm support]
Signed-off-by: Daniel Baluta
[pm support, cleanups and porting to latest kernel]
---
sound/soc/codecs/Kconfig | 6 +
sound/soc
Document the bindings for AK5558 ADC.
Reviewed-by: Rob Herring
Signed-off-by: Daniel Baluta
---
Documentation/devicetree/bindings/sound/ak5558.txt | 22 ++
1 file changed, 22 insertions(+)
create mode 100644 Documentation/devicetree/bindings/sound/ak5558.txt
diff --git a
On Mon, Feb 26, 2018 at 3:13 PM, Pavel Machek wrote:
> Hi!
>
>> JFYI: This issues is tracked in the regression reports for Linux 4.16
>> (http://bit.ly/lnxregrep416 ) with this id:
>>
>> Linux-Regression-ID: lr#4b650f
>
> Ok, so it seems that issue is bigger: whole sound subsystem does not
> work.
rrect tabs and spaces to Kconfig
> iio:dummy: Add extra paragraphs on Kconfig
Reviewed-by: Daniel Baluta
On Thu, Nov 23, 2017 at 12:52 AM, Marc CAPDEVILLE
wrote:
> Somme cosmetic cleanup suggested by Peter Meerwald-Stadler.
Proper way to give credit to someone is to use the Suggested-by tag above your
Signed-off by tag.
thanks,
Daniel.
Signed-off-by: Daniel Baluta
---
Documentation/devicetree/bindings/sound/simple-scu-card.txt | 1 +
sound/soc/generic/simple-scu-card.c | 4
2 files changed, 5 insertions(+)
diff --git a/Documentation/devicetree/bindings/sound/simple-scu-card.txt
b/Documentation
Hi Himanshi,
On Tue, Sep 12, 2017 at 1:43 AM, Himanshi Jain wrote:
> Fixed IIO_DEVICE_ATTR_NAMED API to take name as a
> string instead of implicit conversion to string using
> preprocessors. Added double quotes around names in
> existing usage of IIO_DEVICE_ATTR_NAMED.
Always use imperative moo
On Lu, 2017-08-21 at 00:43 +, Kuninori Morimoto wrote:
> Hi
>
> >
> > Signed-off-by: Daniel Baluta
> > ---
> > Documentation/devicetree/bindings/sound/simple-scu-card.txt | 1 +
> > sound/soc/generic/simple-scu-card.c | 4 +++
On Fri, Sep 9, 2016 at 6:24 PM, Laura Abbott wrote:
>
> The iio tools have been updated as new event types have been added to
> the kernel. The tools currently use the standard system headers which
> means that the system may not have the newest defintitions. This leads
> to build failures when bu
is we also define an invalid notifid as 0xU. This
should be placed as notifids if users want Linux to generate the ids.
Signed-off-by: Alexandru Lastur
Signed-off-by: Daniel Baluta
---
drivers/remoteproc/remoteproc_core.c | 14 --
include/linux/remoteproc.h | 1 +
2
On Wed, Oct 23, 2024 at 6:32 PM Mathieu Poirier
wrote:
>
> Hello Daniel,
>
> On Fri, Oct 18, 2024 at 02:09:29PM +0300, Daniel Baluta wrote:
> > Currently we generate notifyids in the linux kernel and override
> > those found in rsc_table.
> >
> > This doesn
ppet example
Changes since v1:
(https://lore.kernel.org/imx/20250219030809.GD6537@nxa18884-linux/T/)
- addresed comments received on v1
- picked up R-b and A-b tags
Daniel Baluta (8):
dt-bindings: reset: audiomix: Add reset ids for EARC and DSP
dt-bindings: dsp: fsl,dsp: Add res
l.org/project/imx/patch/20250212085222.107102-6-daniel.bal...@nxp.com/
Signed-off-by: Daniel Baluta
Reviewed-by: Frank Li
---
.../devicetree/bindings/dsp/fsl,dsp.yaml | 16 +++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/ds
Add resets property to dsp node in order to be able to control the dsp
run/stall bit from audio block control.
Signed-off-by: Daniel Baluta
Reviewed-by: Frank Li
---
arch/arm64/boot/dts/freescale/imx8mp.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale
For EARC and EARC PHY the reset happens when clearing the reset bits.
Refactor assert/deassert function in order to take into account the
active_low configuration option.
Signed-off-by: Daniel Baluta
Reviewed-by: Philipp Zabel
Reviewed-by: Peng Fan
Reviewed-by: Frank Li
---
drivers/reset
We can Run/Stall the DSP via audio block control bits found in audiomix.
Implement this functionality using the reset controller and use assert
for Stall and deassert for Run.
Signed-off-by: Daniel Baluta
Reviewed-by: Frank Li
---
drivers/reset/reset-imx8mp-audiomix.c | 8
1 file
07102-6-daniel.bal...@nxp.com/
Signed-off-by: Daniel Baluta
Reviewed-by: Peng Fan
Reviewed-by: Frank Li
---
drivers/remoteproc/imx_dsp_rproc.c | 25 +
drivers/remoteproc/imx_rproc.h | 2 ++
2 files changed, 19 insertions(+), 8 deletions(-)
diff --git a/drivers/remot
Add reset ids used for EARC and DSP on i.MX8MP platform.
Signed-off-by: Daniel Baluta
Acked-by: Rob Herring (Arm)
Reviewed-by: Frank Li
---
include/dt-bindings/reset/imx8mp-reset-audiomix.h | 13 +
1 file changed, 13 insertions(+)
create mode 100644 include/dt-bindings/reset
This adds IMX8MP_AUDIOMIX_ prefix to internal macros in order to show
that specific macros are related to audiomix.
Signed-off-by: Daniel Baluta
Reviewed-by: Philipp Zabel
Reviewed-by: Frank Li
Reviewed-by: Peng Fan
---
drivers/reset/reset-imx8mp-audiomix.c | 14 +++---
1 file
Current code supports EARC PHY Software Reset and EARC Software Reset
but it is not easily extensible to more reset bits.
So, refactor the code in order to easily allow more reset bits in the
future.
Signed-off-by: Daniel Baluta
Reviewed-by: Frank Li
---
drivers/reset/reset-imx8mp-audiomix.c
Hello Philipp,
Thanks for your comments!
> The DAP core reset is mentioned in the commit message. Why is it
> missing here? After reading the discussion in [1], I'd expect both the
> stall and the (core) reset signal to be documented, something like:
There is no reset controller driver for DAP a
On Tue, Feb 25, 2025 at 3:18 PM Philipp Zabel wrote:
>
> On Di, 2025-02-25 at 12:19 +0200, Daniel Baluta wrote:
> > Add reset ids used for EARC and DSP on i.MX8MP platform.
> >
> > Signed-off-by: Daniel Baluta
> > Acked-by: Rob Herring (Arm)
> > Reviewed-b
On Tue, Feb 18, 2025 at 5:56 PM Frank Li wrote:
>
> On Tue, Feb 18, 2025 at 10:57:09AM +0200, Daniel Baluta wrote:
> > Current code supports EARC PHY Software Reset and EARCSoftware
> > Reset but it is not easily extensible to more reset bits.
> >
> > So,
> > + case IMX_RPROC_RESET_CONTROLLER:
> > + priv->reset = devm_reset_control_get_optional_exclusive(dev,
> > NULL);
>
> Is this optional on purpose? There is no mention of it in the commit
> message. Where is this resets property documented in the dt-bindings?
For this particular
This adds IMX8MP_AUDIOMIX_ prefix to internal macros
in order to show that specific macros are related to
audiomix.
Signed-off-by: Daniel Baluta
---
drivers/reset/reset-imx8mp-audiomix.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/reset/reset
Current code supports EARC PHY Software Reset and EARC Software
Reset but it is not easily extensible to more reset bits.
So, refactor the code in order to easily allow more reset bits
in the future.
Signed-off-by: Daniel Baluta
---
drivers/reset/reset-imx8mp-audiomix.c | 53
For EARC and EARC PHY the reset happens when clearing the reset bits.
Refactor assert/deassert function in order to take into account
the active_low configuratin option.
Signed-off-by: Daniel Baluta
---
drivers/reset/reset-imx8mp-audiomix.c | 45 ++-
1 file changed, 23
Use the reset controller API to control the DSP on i.MX8MP. This way
we can have a better control of the resources and avoid using a syscon
to access the audiomix bits.
Signed-off-by: Daniel Baluta
---
drivers/remoteproc/imx_dsp_rproc.c | 25 +
drivers/remoteproc
We can Run/Stall the DSP via audio block control bits found in audiomix.
Implement this functionality using the reset controller and use assert
for Stall and deassert for Run.
Signed-off-by: Daniel Baluta
---
drivers/reset/reset-imx8mp-audiomix.c | 12 ++--
1 file changed, 10 insertions
://patchwork.kernel.org/project/imx/patch/20241210125338.104959-6-daniel.bal...@nxp.com/
Daniel Baluta (5):
reset: imx8mp-audiomix: Add prefix for internal macro
reset: imx8mp-audiomix: Prepare the code for more reset bits
reset: imx8mp-audiomix: Introduce active_low configuration option
reset
ff-by: Daniel Baluta
---
.../devicetree/bindings/dsp/fsl,dsp.yaml | 24 ++-
1 file changed, 23 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml
b/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml
index ab93ffd3d2e5..b8693e4b4b0d 1
- add correct include in the yaml dts snippet example
Changes since v1:
(https://lore.kernel.org/imx/20250219030809.GD6537@nxa18884-linux/T/)
- addresed comments received on v1
- picked up R-b and A-b tags
Daniel Baluta (8):
dt-bindings: reset: audiomix: Add reset ids for EA
Add reset ids used for EARC and DSP on i.MX8MP platform.
Acked-by: Rob Herring (Arm)
Reviewed-by: Frank Li
Signed-off-by: Daniel Baluta
---
include/dt-bindings/reset/imx8mp-reset-audiomix.h | 13 +
1 file changed, 13 insertions(+)
create mode 100644 include/dt-bindings/reset
Add resets property to dsp node in order to be able to control the dsp
run/stall bit from audio block control.
Reviewed-by: Peng Fan
Reviewed-by: Frank Li
Signed-off-by: Daniel Baluta
---
arch/arm64/boot/dts/freescale/imx8mp.dtsi | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch
We can Run/Stall the DSP via audio block control bits found in audiomix.
Implement this functionality using the reset controller and use assert
for Stall and deassert for Run.
Reviewed-by: Peng Fan
Reviewed-by: Frank Li
Signed-off-by: Daniel Baluta
---
drivers/reset/reset-imx8mp-audiomix.c
Current code supports EARC PHY Software Reset and EARC Software Reset
but it is not easily extensible to more reset bits.
So, refactor the code in order to easily allow more reset bits in the
future.
Reviewed-by: Peng Fan
Reviewed-by: Frank Li
Signed-off-by: Daniel Baluta
---
drivers/reset
This adds IMX8MP_AUDIOMIX_ prefix to internal macros in order to show
that specific macros are related to audiomix.
Reviewed-by: Philipp Zabel
Reviewed-by: Frank Li
Reviewed-by: Peng Fan
Signed-off-by: Daniel Baluta
---
drivers/reset/reset-imx8mp-audiomix.c | 14 +++---
1 file
On Mon, Mar 10, 2025 at 5:43 PM Mathieu Poirier
wrote:
>
> Good day,
>
> On Wed, Mar 05, 2025 at 12:00:36PM +0200, Daniel Baluta wrote:
> > DSP on i.MX8MP doesn't have a direct reset line so according to hardware
> > design team in order to handle assert/deassert/re
For EARC and EARC PHY the reset happens when clearing the reset bits.
Refactor assert/deassert function in order to take into account the
active_low configuration option.
Reviewed-by: Philipp Zabel
Reviewed-by: Peng Fan
Reviewed-by: Frank Li
Signed-off-by: Daniel Baluta
---
drivers/reset
https://patchwork.kernel.org/project/imx/patch/20250212085222.107102-6-daniel.bal...@nxp.com/
Reviewed-by: Peng Fan
Reviewed-by: Frank Li
Signed-off-by: Daniel Baluta
---
drivers/remoteproc/imx_dsp_rproc.c | 25 +
drivers/remoteproc/imx_rproc.h | 2 ++
2 files changed, 19 insertions(
07102-6-daniel.bal...@nxp.com/
Reviewed-by: Peng Fan
Reviewed-by: Frank Li
Signed-off-by: Daniel Baluta
---
drivers/remoteproc/imx_dsp_rproc.c | 25 +
drivers/remoteproc/imx_rproc.h | 2 ++
2 files changed, 19 insertions(+), 8 deletions(-)
diff --git a/drivers/remot
emove 'resets' description as it is a common property
- add correct include in the yaml dts snippet example
Changes since v1:
(https://lore.kernel.org/imx/20250219030809.GD6537@nxa18884-linux/T/)
- addresed comments received on v1
- picked up R-b and A-b tags
Daniel B
Add reset ids used for EARC and DSP on i.MX8MP platform.
Acked-by: Rob Herring (Arm)
Reviewed-by: Frank Li
Signed-off-by: Daniel Baluta
---
include/dt-bindings/reset/imx8mp-reset-audiomix.h | 13 +
1 file changed, 13 insertions(+)
create mode 100644 include/dt-bindings/reset
Add resets property to dsp node in order to be able to control the dsp
run/stall bit from audio block control.
Reviewed-by: Frank Li
Signed-off-by: Daniel Baluta
---
arch/arm64/boot/dts/freescale/imx8mp.dtsi | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale
We can Run/Stall the DSP via audio block control bits found in audiomix.
Implement this functionality using the reset controller and use assert
for Stall and deassert for Run.
Reviewed-by: Frank Li
Signed-off-by: Daniel Baluta
---
drivers/reset/reset-imx8mp-audiomix.c | 8
1 file
For EARC and EARC PHY the reset happens when clearing the reset bits.
Refactor assert/deassert function in order to take into account the
active_low configuration option.
Reviewed-by: Philipp Zabel
Reviewed-by: Peng Fan
Reviewed-by: Frank Li
Signed-off-by: Daniel Baluta
---
drivers/reset
Current code supports EARC PHY Software Reset and EARC Software Reset
but it is not easily extensible to more reset bits.
So, refactor the code in order to easily allow more reset bits in the
future.
Reviewed-by: Frank Li
Signed-off-by: Daniel Baluta
---
drivers/reset/reset-imx8mp-audiomix.c
stall control now, but softreset will
be added in the future when we will convert the softreset functionality
to use reset controller API.
[1]
https://patchwork.kernel.org/project/imx/patch/20250212085222.107102-6-daniel.bal...@nxp.com/
Reviewed-by: Frank Li
Signed-off-by: Daniel B
This adds IMX8MP_AUDIOMIX_ prefix to internal macros in order to show
that specific macros are related to audiomix.
Reviewed-by: Philipp Zabel
Reviewed-by: Frank Li
Reviewed-by: Peng Fan
Signed-off-by: Daniel Baluta
---
drivers/reset/reset-imx8mp-audiomix.c | 14 +++---
1 file
trol the
DSP")
Reported-by: kernel test robot
Closes:
https://lore.kernel.org/oe-kbuild-all/202503142125.ie33scto-...@intel.com/
Signed-off-by: Daniel Baluta
---
drivers/remoteproc/imx_dsp_rproc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/remoteproc/imx_dsp_rproc.c
b/
On Mon, Mar 17, 2025 at 5:30 PM Alexander Stein
wrote:
>
> Am Montag, 17. März 2025, 14:33:03 CET schrieb Daniel Baluta:
> > Enable MU2 node and add mu2 root clock.
> > MU2 is used to communicate with DSP core.
> >
> > Reviewed-by: Iuliana Prodan
> > Revi
With imx8mp-evk board we are now configuring 'dsp' node for rproc usage,
so add rproc specific memory regions.
Also, enable dsp node because it is ready to be used.
Reviewed-by: Ahmad Fatoum
Reviewed-by: Iuliana Prodan
Reviewed-by: Peng Fan
Signed-off-by: Daniel Baluta
---
arch/
DSP core needs ocram, core and debug clocks.
Reviewed-by: Iuliana Prodan
Reviewed-by: Peng Fan
Signed-off-by: Daniel Baluta
---
arch/arm64/boot/dts/freescale/imx8mp.dtsi | 5 +
1 file changed, 5 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
b/arch/arm64/boot/dts
ware) will need to
create a separate dts file (or an overlay).
This change follows the approach taken for other i.MX8 boards
in commit 391a319c81f6d7 ("arm64: dts: imx8-ss-audio: configure dsp node
for rproc usage")
Reviewed-by: Iuliana Prodan
Reviewed-by: Peng Fan
Signed-off-by:
Add resets property to dsp node in order to be able to control the dsp
run/stall bit from audio block control.
Reviewed-by: Peng Fan
Reviewed-by: Frank Li
Signed-off-by: Daniel Baluta
---
arch/arm64/boot/dts/freescale/imx8mp.dtsi | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch
rved_mem_region_to_resource() which is checked for an error.
>
> Signed-off-by: Rob Herring (Arm)
For IMX part:
Reviewed-by: Daniel Baluta
" and then get
> the region's address and size. As this is a standard property, it should
> have common functions for drivers to use. Add new functions to count the
> number of regions and retrieve the region's address as a resource.
>
> Signed-off-by: Rob Herring (Arm)
Reviewed-by: Daniel Baluta
Enable MU2 node and add mu2 root clock.
MU2 is used to communicate with DSP core.
Reviewed-by: Iuliana Prodan
Reviewed-by: Peng Fan
Signed-off-by: Daniel Baluta
---
arch/arm64/boot/dts/freescale/imx8mp-evk.dts | 4
arch/arm64/boot/dts/freescale/imx8mp.dtsi| 1 +
2 files changed, 5
901 - 1000 of 1014 matches
Mail list logo
