Re: [PATCH v3 1/2] iio: resistance: Document that resistance can be output

2015-09-22 Thread Daniel Baluta
On Tue, Sep 22, 2015 at 3:55 PM, Peter Rosin wrote: > On 2015-09-22 14:48, Daniel Baluta wrote: >> On Tue, Sep 22, 2015 at 3:39 PM, Peter Rosin wrote: >>> From: Peter Rosin >>> >>> Signed-off-by: Peter Rosin >>> --- >>> Documentation/ABI/

[PATCH 0/3] MMC35240 magneto fixes

2015-07-14 Thread Daniel Baluta
Found while testing with a compass Android app. Jonathan, this is a follow up of the first patch in this series, initially sent for review before merged window was closed: See: https://lkml.org/lkml/2015/6/21/68 Daniel Baluta (2): iio: magnetometer: mmc35240: Fix crash in pm suspend iio

[PATCH 3/3] iio: magnetometer: mmc35240: fix SET/RESET sequence

2015-07-14 Thread Daniel Baluta
From: Viorel Suman The RESET operation invoked in the last instance will align in the natural way all 3 axis and the chip top view. Signed-off-by: Viorel Suman Signed-off-by: Daniel Baluta --- drivers/iio/magnetometer/mmc35240.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions

[PATCH 2/3] iio: magnetometer: mmc35240: Fix SET/RESET mask

2015-07-14 Thread Daniel Baluta
This fixes setting the SET/RESET bit in the REG_CTRL0 register. Signed-off-by: Daniel Baluta --- drivers/iio/magnetometer/mmc35240.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/magnetometer/mmc35240.c b/drivers/iio/magnetometer/mmc35240.c index e89b059

[PATCH 1/3] iio: magnetometer: mmc35240: Fix crash in pm suspend

2015-07-14 Thread Daniel Baluta
Trace: [ 322.573217] [<80c0d2d1>] pm_generic_suspend+0x21/0x30 [ 322.578284] [<80d042ab>] i2c_device_pm_suspend+0x1b/0x30 Signed-off-by: Daniel Baluta --- drivers/iio/magnetometer/mmc35240.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/iio/magnetometer/mmc35240.c b/driver

Re: [PATCH] DocBook documentation for IIO

2015-07-10 Thread Daniel Baluta
Hi Randy, On Fri, Jul 10, 2015 at 10:13 PM, Randy Dunlap wrote: > On 07/08/15 05:04, Daniel Baluta wrote: >> In our effort to support vendors writing drivers for their own >> sensors we introduce IIO documentation in DocBook format. >> >> It documents Industrial I/O

Re: [RFC PATCH 1/2] iio: hmc5843 Add channel attribute for bias configuration

2016-02-05 Thread Daniel Baluta
On Thu, Feb 4, 2016 at 7:45 PM, Lars-Peter Clausen wrote: > On 02/04/2016 03:50 PM, Cristina Moraru wrote: >> Replace non standard meas_conf attribute with the standard IIO >> calibbias attribute. >> >> API for setting bias measurement configuration: >> >> 0 - Normal measurement configuration (def

[PATCH v4] iio: adc: Add TI ADS1015 ADC driver support

2016-02-05 Thread Daniel Baluta
The driver has sysfs readings with runtime PM support for power saving. It also offers buffer support that can be used together with IIO software triggers. Datasheet can be found here: http://www.ti.com.cn/cn/lit/ds/symlink/ads1015.pdf Signed-off-by: Daniel Baluta --- Changes since v3

Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support

2016-02-05 Thread Daniel Baluta
On Fri, Feb 5, 2016 at 7:25 PM, Michael Welling wrote: > On Fri, Feb 05, 2016 at 03:17:18PM +0200, Daniel Baluta wrote: >> The driver has sysfs readings with runtime PM support for power saving. >> It also offers buffer support that can be used together with IIO softw

Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support

2016-02-05 Thread Daniel Baluta
On Fri, Feb 5, 2016 at 11:02 PM, Lucas De Marchi wrote: > Hi Daniel, > > On Fri, Feb 5, 2016 at 11:17 AM, Daniel Baluta > wrote: >> + >> +static const struct i2c_device_id ads1015_id[] = { >> + {"ads1015", 0}, >> + {} >> +}; &

Re: [PATCH 2/2] iio: si7005: add support for Hoperf th02

2016-01-27 Thread Daniel Baluta
On Wed, Jan 27, 2016 at 12:56 AM, Matt Ranostay wrote: > On Tue, Jan 26, 2016 at 12:21 PM, Cristina Moraru > wrote: >> This patch adds support for Hoperf th02 humidity and >> temperature sensor as it uses same register definitions >> as si7005 >> >> th02 Datasheet: >> http://www.anglia-live.com/

Re: [PATCH] iio: adc: Add TI ADS1015 ADC driver support

2016-01-27 Thread Daniel Baluta
On Wed, Jan 27, 2016 at 12:28 AM, Lucas De Marchi wrote: > Hi, > > On Thu, Jan 14, 2016 at 2:25 PM, Daniel Baluta > wrote: >> The driver has sysfs readings with runtime PM support for power saving. >> It also offers buffer support that can be used together with

Re: [PATCH] iio: adc: Add TI ADS1015 ADC driver support

2016-01-27 Thread Daniel Baluta
On Sat, Jan 16, 2016 at 2:07 PM, Jonathan Cameron wrote: > On 14/01/16 16:25, Daniel Baluta wrote: >> The driver has sysfs readings with runtime PM support for power saving. >> It also offers buffer support that can be used together with IIO software >> triggers. >> >

[PATCH 0/2] ms5611: Add triggered buffer support

2016-01-26 Thread Daniel Baluta
First patch reverts 7cb46c2a066 ("iio: pressure: ms5611: remove IIO_CHAN_INFO_SCALE from mask") because we need the scale to correctly transform "raw" data from buffer into correct measurement units. Second patch adds the actual buffer support. Daniel Baluta (2): iio: p

[PATCH 2/2] iio: pressure: ms5611: Add triggered buffer support

2016-01-26 Thread Daniel Baluta
This will be used together with an external trigger (e.g hrtimer based software trigger). Signed-off-by: Daniel Baluta --- drivers/iio/pressure/Kconfig | 1 + drivers/iio/pressure/ms5611.h | 1 + drivers/iio/pressure/ms5611_core.c | 71

[PATCH 1/2] iio: pressure: ms5611: Add IIO_CHAN_INFO_SCALE to mask

2016-01-26 Thread Daniel Baluta
This allows data exported via buffer interface to be converted to standard units in userspace. Signed-off-by: Daniel Baluta --- drivers/iio/pressure/ms5611_core.c | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/drivers/iio/pressure/ms5611_core.c b

[PATCH v2 2/2] iio: pressure: ms5611: Add triggered buffer support

2016-01-26 Thread Daniel Baluta
This will be used together with an external trigger (e.g hrtimer based software trigger). Signed-off-by: Daniel Baluta --- drivers/iio/pressure/Kconfig | 1 + drivers/iio/pressure/ms5611.h | 1 + drivers/iio/pressure/ms5611_core.c | 77

[PATCH v2 1/2] iio: pressure: ms5611: Add IIO_CHAN_INFO_SCALE to mask

2016-01-26 Thread Daniel Baluta
This allows data exported via buffer interface to be converted to standard units in userspace. Signed-off-by: Daniel Baluta --- drivers/iio/pressure/ms5611_core.c | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/drivers/iio/pressure/ms5611_core.c b

[PATCH v2 0/2] ms5611: Add triggered buffer support

2016-01-26 Thread Daniel Baluta
ressed comments from Peter * explain why the need for allocating a buffer of 4 s32 elements * correctly handle data copy into buffer when not all channels are enabled * fixed timestamp channel index (2 instead of 3) * added some new lines for readability Dani

[PATCH v2] iio: adc: Add TI ADS1015 ADC driver support

2016-02-03 Thread Daniel Baluta
The driver has sysfs readings with runtime PM support for power saving. It also offers buffer support that can be used together with IIO software triggers. Datasheet can be found here: http://www.ti.com.cn/cn/lit/ds/symlink/ads1015.pdf Signed-off-by: Daniel Baluta --- Changes since v1

[PATCH v3 2/2] iio: pressure: ms5611: Add triggered buffer support

2016-02-03 Thread Daniel Baluta
This will be used together with an external trigger (e.g hrtimer based software trigger). Signed-off-by: Daniel Baluta --- drivers/iio/pressure/Kconfig | 1 + drivers/iio/pressure/ms5611.h | 1 + drivers/iio/pressure/ms5611_core.c | 74

[PATCH v3 1/2] iio: pressure: ms5611: Add IIO_CHAN_INFO_SCALE to mask

2016-02-03 Thread Daniel Baluta
This allows data exported via buffer interface to be converted to standard units in userspace. Signed-off-by: Daniel Baluta --- drivers/iio/pressure/ms5611_core.c | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/drivers/iio/pressure/ms5611_core.c b

[PATCH v3 0/2] ms5611: Add triggered buffer support

2016-02-03 Thread Daniel Baluta
* correctly handle data copy into buffer when not all channels are enabled * fixed timestamp channel index (2 instead of 3) * added some new lines for readability Daniel Baluta (2): iio: pressure: ms5611: Add IIO_CHAN_INFO_SCALE to mask iio: pressure: ms5611: Add triggered buff

[PATCH v3] iio: adc: Add TI ADS1015 ADC driver support

2016-02-03 Thread Daniel Baluta
The driver has sysfs readings with runtime PM support for power saving. It also offers buffer support that can be used together with IIO software triggers. Datasheet can be found here: http://www.ti.com.cn/cn/lit/ds/symlink/ads1015.pdf Signed-off-by: Daniel Baluta --- Changes since v2

Re: [PATCH v3] iio: adc: Add TI ADS1015 ADC driver support

2016-02-04 Thread Daniel Baluta
> Would it be more consistent to handle the mutex outside of the switch above > similar > to how it is handled in ads1015_write_raw? > > Also the ads1015_set_power_state(data, false) is called either way so why not > just > use one call? > I don't have a strong preference for that. I think acros

Re: [PATCH V4 0/9] Support i.MX8 SoCs pinctrl drivers built as module

2020-06-11 Thread Daniel Baluta
Hi Anson, Patch series mostly looks good to me. I have a comment about adding the MODULE_LICENSE. This is a pretty important change. Can you please add this change in a separate patch with a proper explanation of why it is needed. Most likely it is because it was forgotten in the previous p

Re: [PATCH V4 4/9] pinctrl: imx8mn: Support building as module

2020-06-11 Thread Daniel Baluta
Maybe this is obvious but I would really like to see an explanation of why we are switching from arch_initcall to platform_init. Commit message act as documentation  for the reviewers. On 10.06.2020 10:57, Anson Huang wrote: Support building i.MX8MN pinctrl driver as module. Signed-off-by: An

Re: [PATCH V4 0/9] Support i.MX8 SoCs pinctrl drivers built as module

2020-06-11 Thread Daniel Baluta
On 11.06.2020 11:44, Anson Huang wrote: Hi, Daniel Subject: Re: [PATCH V4 0/9] Support i.MX8 SoCs pinctrl drivers built as module Hi Anson, Patch series mostly looks good to me. I have a comment about adding the MODULE_LICENSE. This is a pretty important change. Can you please add this c

Re: [PATCH V4 4/9] pinctrl: imx8mn: Support building as module

2020-06-11 Thread Daniel Baluta
On 11.06.2020 11:48, Anson Huang wrote: Hi, Daniel Subject: Re: [PATCH V4 4/9] pinctrl: imx8mn: Support building as module Maybe this is obvious but I would really like to see an explanation of why we are switching from arch_initcall to platform_init. Commit message act as documentation  f

[PATCH 3/3] firmware: imx-dsp: Export functions to request/free channels

2020-07-08 Thread Daniel Baluta
From: Daniel Baluta In order to save power, we only need to request a channel when the communication with the DSP active. For this we export the following functions: - imx_dsp_request_channel, gets a channel with a given index - imx_dsp_free_channel, frees a channel with a given

[PATCH 1/3] firmware: imx: Introduce imx_dsp_setup_channels

2020-07-08 Thread Daniel Baluta
From: Daniel Baluta Create a separate function that sets up DSP mailbox channels so that imx_dsp_probe function will be easier to read. Signed-off-by: Daniel Baluta --- drivers/firmware/imx/imx-dsp.c | 41 +- 1 file changed, 26 insertions(+), 15 deletions

[PATCH 2/3] firmware: imx: Save channel name for further use

2020-07-08 Thread Daniel Baluta
From: Daniel Baluta We want to request / free channels on demand later in order to save power. For this for each channel we save the name and use it to reference the channel later. Signed-off-by: Daniel Baluta --- drivers/firmware/imx/imx-dsp.c | 6 +++--- 1 file changed, 3 insertions(+), 3

[PATCH 0/3] Allow on demand channel request / free

2020-07-08 Thread Daniel Baluta
From: Daniel Baluta Requesting an mailbox channel will call mailbox's startup function. startup function calls pm_runtime_get_sync which increments device usage count and will keep the device active. Specifically, mailbox clock will be always ON when a mailbox channel is requested. For

Re: [PATCH AUTOSEL 5.7 055/388] ASoC: SOF: Do nothing when DSP PM callbacks are not set

2020-06-18 Thread Daniel Baluta
On 6/18/20 2:01 PM, Mark Brown wrote: On Wed, Jun 17, 2020 at 09:02:32PM -0400, Sasha Levin wrote: From: Daniel Baluta [ Upstream commit c26fde3b15ed41f5f452f1da727795f787833287 ] This provides a better separation between runtime and PM sleep callbacks. Only do nothing if given runtime flag

[RESEND PATCH v2 1/2] PM / domains: Introduce multi PM domains helpers

2020-06-23 Thread Daniel Baluta
From: Daniel Baluta This patch introduces helpers support for multi PM domains. API consists of: 1) dev_multi_pm_attach - powers up all PM domains associated with a given device. Because we can attach one PM domain per device, we create virtual devices (children of initial device) and

[RESEND PATCH v2 0/2] Introduce multi PM domains helpers

2020-06-23 Thread Daniel Baluta
From: Daniel Baluta i.MX8QXP/i.MX8QM has IPs that need multiple power domains to be up in order to work. In order to help drivers, we introduce multi PM domains helpers that are able to activate/deactivate multi PM domains. First patch introduces the helpers and second patch demonstrates how a

[RESEND PATCH v2 2/2] ASoC: SOF: Use multi PM domains helpers

2020-06-23 Thread Daniel Baluta
From: Daniel Baluta Use dev_multi_pm_attach / dev_multi_pm_detach instead of the hardcoded version. Signed-off-by: Daniel Baluta --- sound/soc/sof/imx/imx8.c | 60 ++-- 1 file changed, 9 insertions(+), 51 deletions(-) diff --git a/sound/soc/sof/imx/imx8.c

Re: [PATCH] ASoC: fsl_spdif: Add support for higher sample rates

2020-10-13 Thread Daniel Baluta
t; > Signed-off-by: Shengjiu Wang > > Signed-off-by: Viorel Suman > > Probably should put your own Signed-off at the bottom? Hi Shengjiu, Also please keep the original author of the patch. You can change that using git commit --amend --author="Viorel Suman ". With that, Reviewed-by: Daniel Baluta

Re: [PATCH] ASoC: fsl_spdif: Add support for higher sample rates

2020-10-13 Thread Daniel Baluta
On Tue, Oct 13, 2020 at 1:49 PM Shengjiu Wang wrote: > > On Tue, Oct 13, 2020 at 6:42 PM Daniel Baluta wrote: > > > > On Tue, Oct 13, 2020 at 12:29 PM Nicolin Chen > > wrote: > > > > > > Hi Shengjiu, > > > > > > On Mon, Oct 12, 2020 a

Re: [PATCH 1/2] arm64: dts: Add a device tree for the Librem5 phone

2020-05-26 Thread Daniel Baluta
ed-off-by: Guido Günther For audio related part: Reviewed-by: Daniel Baluta

Re: [PATCH] arm64: dts: imx8mm-beacon: Fix voltages on LDO1 and LDO2

2020-05-26 Thread Daniel Baluta
> Fixes: 593816fa2f35 ("arm64: dts: imx: Add Beacon i.MX8m-Mini development > kit") > > Signed-off-by: Adam Ford No need for a new line between fixes and signed-off-by. With that: Reviewed-by: Daniel Baluta

Re: [PATCH] soc: imx: scu: use devm_kasprintf

2020-06-03 Thread Daniel Baluta
On 03.06.2020 12:29, peng@nxp.com wrote: From: Peng Fan Use devm_kasprintf to simplify code Signed-off-by: Peng Fan Reviewed-by: Daniel Baluta

Re: [PATCH v2 1/4] dt-bindings: iio: imu: bmi160: convert txt format to yaml

2020-05-22 Thread Daniel Baluta
+ +maintainers: + - can't find a mantainer, author is Daniel Baluta Daniel is still active in the kernel, just not at Intel any more. +CC Oh ok thank you! Daniel are you still maintaining this driver? I can do reviews if requested but I'm not actively maintaining this

Re: [PATCH v2 1/4] dt-bindings: iio: imu: bmi160: convert txt format to yaml

2020-05-22 Thread Daniel Baluta
On 22.05.2020 17:26, Jonathan Albrieux wrote: On Fri, May 22, 2020 at 01:47:21PM +0300, Daniel Baluta wrote: + +maintainers: + - can't find a mantainer, author is Daniel Baluta Daniel is still active in the kernel, just not at Intel any more. +CC Oh ok thank you! Daniel are you

[PATCH RESEND 0/3] Allow on demand channel request / free

2020-11-11 Thread Daniel Baluta
uce a way to request/free IMX DSP channels on demand to save power when the channels are not used. First two patches are doing code refactoring preparing the path for 3rd patch which exports functions for on demand channel request/free Daniel Baluta (3): firmware: imx: Introduce imx_dsp_setup_cha

[PATCH RESEND 1/3] firmware: imx: Introduce imx_dsp_setup_channels

2020-11-11 Thread Daniel Baluta
Create a separate function that sets up DSP mailbox channels so that imx_dsp_probe function will be easier to read. Signed-off-by: Daniel Baluta --- drivers/firmware/imx/imx-dsp.c | 41 +- 1 file changed, 26 insertions(+), 15 deletions(-) diff --git a/drivers

[PATCH RESEND 3/3] firmware: imx-dsp: Export functions to request/free channels

2020-11-11 Thread Daniel Baluta
_sync which increments device usage count and will keep the device active. Specifically, mailbox clock will be always ON when a mailbox channel is requested. Signed-off-by: Daniel Baluta --- drivers/firmware/imx/imx-dsp.c | 25 + include/linux/firmware/imx/dsp.h

[PATCH RESEND 2/3] firmware: imx: Save channel name for further use

2020-11-11 Thread Daniel Baluta
We want to request / free channels on demand later in order to save power. For this for each channel we save the name and use it to reference the channel later. Signed-off-by: Daniel Baluta --- drivers/firmware/imx/imx-dsp.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

Re: [PATCH V3 1/5] firmware: imx: scu-seco: Add Secure Controller APIS

2020-11-11 Thread Daniel Baluta
On Tue, Nov 10, 2020 at 4:15 PM wrote: > > From: Franck LENORMAND Looks good to me. Thanks Franck! Reviewed-by: Daniel Baluta

[PATCH 5/7] ASoC: SOF: imx8: Add SAI dai driver for i.MX/i.MX8X

2020-07-20 Thread Daniel Baluta
From: Daniel Baluta With SOF we support 1 ESAI interface and 1 SAI interface. This patch adds SAI1 interface support existing on i.MX8/i.MX8X boards. Signed-off-by: Daniel Baluta Reviewed-by: Pierre-Louis Bossart Reviewed-by: Kai Vehmanen Reviewed-by: Ranjani Sridharan Reviewed-by: Guennadi

[PATCH 4/7] ASoC: SOF: imx8m: Fix SAI DAI driver for i.MX8M

2020-07-20 Thread Daniel Baluta
From: Daniel Baluta This must match DAI name from topology. Also, sai-port is too generic. Physical DAI port on i.MX8MP is labeled SAI3. Signed-off-by: Daniel Baluta Reviewed-by: Pierre-Louis Bossart Reviewed-by: Kai Vehmanen Reviewed-by: Ranjani Sridharan Reviewed-by: Guennadi Liakhovetski

[PATCH 7/7] ASoC: SOF: pcm: Update rate/channels for SAI/ESAI DAIs

2020-07-20 Thread Daniel Baluta
From: Daniel Baluta Fixup BE DAI links rate/channels parameters to match any values from topology. Signed-off-by: Daniel Baluta Reviewed-by: Pierre-Louis Bossart Reviewed-by: Ranjani Sridharan --- sound/soc/sof/pcm.c | 8 1 file changed, 8 insertions(+) diff --git a/sound/soc/sof

[PATCH 1/7] ASoC: SOF: define INFO_ flags in dsp_ops for imx8

2020-07-20 Thread Daniel Baluta
From: Daniel Baluta In the past, the INFO_ flags such as PAUSE/NO_PERIOD_WAKEUP were defined in the SOF PCM core, but that was changed since commit 27e322fabd50 ("ASoC: SOF: define INFO_ flags in dsp_ops") Now these flags must be set in DSP ops. Signed-off-by: Daniel Baluta R

[PATCH 0/7] SOF IMX fixes

2020-07-20 Thread Daniel Baluta
From: Daniel Baluta This patchseries contains a couple of SOF IMX fixes found during our first IMX SOF release. Daniel Baluta (7): ASoC: SOF: define INFO_ flags in dsp_ops for imx8 ASoC: SOF: imx: Use ARRAY_SIZE instead of hardcoded value ASoC: SOF: imx8: Fix ESAI DAI driver name for

[PATCH 6/7] ASoC: SOF: topology: Update SAI config bclk/fsync rate

2020-07-20 Thread Daniel Baluta
From: Daniel Baluta These parameters are read from topology file and sent to DSP. Signed-off-by: Daniel Baluta Reviewed-by: Pierre-Louis Bossart Reviewed-by: Ranjani Sridharan --- sound/soc/sof/topology.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/sof/topology.c b/sound

[PATCH 2/7] ASoC: SOF: imx: Use ARRAY_SIZE instead of hardcoded value

2020-07-20 Thread Daniel Baluta
From: Daniel Baluta With this change we no longer need to update num_drv when adding new DAI driver. Signed-off-by: Daniel Baluta Reviewed-by: Pierre-Louis Bossart Reviewed-by: Kai Vehmanen Reviewed-by: Ranjani Sridharan Reviewed-by: Guennadi Liakhovetski --- sound/soc/sof/imx/imx8.c | 4

[PATCH 3/7] ASoC: SOF: imx8: Fix ESAI DAI driver name for i.MX8/iMX8X

2020-07-20 Thread Daniel Baluta
From: Daniel Baluta This must match DAI name from topology. Also, esai-port is too generic as they are 2 ESAIs on i.MX8/i.MX8X boards. SOF integration only uses ESAI0 for now. Signed-off-by: Daniel Baluta Reviewed-by: Pierre-Louis Bossart Reviewed-by: Kai Vehmanen Reviewed-by: Ranjani

Re: [PATCH] drivers: soc: Fix mailbox suspend/resume no irq for IMX SCU

2020-07-06 Thread Daniel Baluta
imx_mu_suspend_noirq()/imx_mu_resume_noirq() __maybe_unused to address the issue. Cc: Jassi Brar Cc: Shawn Guo Cc: Sascha Hauer Cc: Pengutronix Kernel Team Cc: Fabio Estevam Cc: NXP Linux Team Signed-off-by: Vincenzo Frascino Reviewed-by: Daniel Baluta

Re: [RFC PATCH v2 6/6] ASoC: q6asm-dai: add support to set_codec_params

2020-07-22 Thread Daniel Baluta
On Tue, Jul 21, 2020 at 8:03 PM Srinivas Kandagatla wrote: > > Make use of new set_codec_params callback to allow decoder switching > during gapless playback. > > Signed-off-by: Srinivas Kandagatla > --- > sound/soc/qcom/qdsp6/q6asm-dai.c | 33 > 1 file changed,

Re: [PATCH 1/2] pinctrl: imx: Support building SCU pinctrl driver as module

2020-07-16 Thread Daniel Baluta
Hi Anson, Few comments inline: On 7/16/20 6:06 PM, Anson Huang wrote: To support building i.MX SCU pinctrl driver as module, below things need to be changed: - Export SCU related functions and use "IS_ENABLED" instead of "ifdef" to support SCU pinctrl driver user and itself to be

Re: [PATCH 1/2] pinctrl: imx: Support building SCU pinctrl driver as module

2020-07-16 Thread Daniel Baluta
On 7/16/20 6:21 PM, Anson Huang wrote: Hi, Daniel Subject: Re: [PATCH 1/2] pinctrl: imx: Support building SCU pinctrl driver as module Hi Anson, Few comments inline: On 7/16/20 6:06 PM, Anson Huang wrote: To support building i.MX SCU pinctrl driver as module, below things need to be chang

Re: [PATCH 1/2] pinctrl: imx: Support building SCU pinctrl driver as module

2020-07-17 Thread Daniel Baluta
On 7/17/20 2:44 AM, Anson Huang wrote: Hi, Daniel Subject: Re: [PATCH 1/2] pinctrl: imx: Support building SCU pinctrl driver as module On 7/16/20 6:21 PM, Anson Huang wrote: Hi, Daniel Subject: Re: [PATCH 1/2] pinctrl: imx: Support building SCU pinctrl driver as module Hi Anson, Few com

[RESEND PATCH 0/3] Allow on demand channel request / free

2020-09-14 Thread Daniel Baluta
From: Daniel Baluta Requesting an mailbox channel will call mailbox's startup function. startup function calls pm_runtime_get_sync which increments device usage count and will keep the device active. Specifically, mailbox clock will be always ON when a mailbox channel is requested. For

[RESEND PATCH 3/3] firmware: imx-dsp: Export functions to request/free channels

2020-09-14 Thread Daniel Baluta
From: Daniel Baluta In order to save power, we only need to request a channel when the communication with the DSP active. For this we export the following functions: - imx_dsp_request_channel, gets a channel with a given index - imx_dsp_free_channel, frees a channel with a given

[RESEND PATCH 2/3] firmware: imx: Save channel name for further use

2020-09-14 Thread Daniel Baluta
From: Daniel Baluta We want to request / free channels on demand later in order to save power. For this for each channel we save the name and use it to reference the channel later. Signed-off-by: Daniel Baluta --- drivers/firmware/imx/imx-dsp.c | 6 +++--- 1 file changed, 3 insertions(+), 3

[RESEND PATCH 1/3] firmware: imx: Introduce imx_dsp_setup_channels

2020-09-14 Thread Daniel Baluta
From: Daniel Baluta Create a separate function that sets up DSP mailbox channels so that imx_dsp_probe function will be easier to read. Signed-off-by: Daniel Baluta --- drivers/firmware/imx/imx-dsp.c | 41 +- 1 file changed, 26 insertions(+), 15 deletions

[PATCH 0/2] Enable runtime PM for SOF device

2020-09-24 Thread Daniel Baluta
From: Daniel Baluta This enables runtime PM for SOF device. Next patchseries will provide PM suspend/resume handlers for i.MX8 specific devices. Daniel Baluta (2): ASoC: SOF: Activate runtime PM with SOF OF device ASoC: SOF: Add .prepare/.complete callbacks sound/soc/sof/sof-of-dev.c | 6

[PATCH 2/2] ASoC: SOF: Add .prepare/.complete callbacks

2020-09-24 Thread Daniel Baluta
From: Daniel Baluta Use SOF defined callbacks (snd_sof_prepare/snd_sof_complete) in order to update internal SOF system suspend target. Reviewed-by: Kai Vehmanen Reviewed-by: Paul Olaru Reviewed-by: Pierre-Louis Bossart Signed-off-by: Daniel Baluta --- sound/soc/sof/sof-of-dev.c | 2 ++ 1

[PATCH 1/2] ASoC: SOF: Activate runtime PM with SOF OF device

2020-09-24 Thread Daniel Baluta
From: Daniel Baluta SOF boots the DSP at probe and keeps it up all the time. With this change, after booting if no one is using the DSP the SOF core will turn off the DSP to save power. Reviewed-by: Kai Vehmanen Reviewed-by: Paul Olaru Reviewed-by: Pierre-Louis Bossart Signed-off-by: Daniel

[PATCH v4 1/2] arm64: dts: imx8mm: Add SAI nodes

2019-06-04 Thread daniel . baluta
From: Daniel Baluta i.MX8MM has 5 SAI instances with the following base addresses according to RM. SAI1 base address: 3001_h SAI2 base address: 3002_h SAI3 base address: 3003_h SAI5 base address: 3005_h SAI6 base address: 3006_h Signed-off-by: Daniel Baluta Reviewed-by

[PATCH v4 0/2] Enable wm8524 codec on i.MX8MM EVK

2019-06-04 Thread daniel . baluta
From: Daniel Baluta This patch series introduces the SAI nodes on i.MX8MM EVK then creates the wm8524 codec node and finally uses simple card machine driver to create a sound card. Changes since v3: - rebased on latest for-next branch - fixed encoding problems Changes since v2

[PATCH v4 2/2] arm64: dts: imx8mm-evk: Enable audio codec wm8524

2019-06-04 Thread daniel . baluta
From: Daniel Baluta i.MX8MM has one wm8524 audio codec connected with SAI3 digital audio interface. This patch uses simple-card machine driver in order to enable wm8524 codec. We need to set: * SAI3 pinctrl configuration * codec reset gpio pinctrl configuration * clock

Re: [RFC PATCH 2/2] imx: mailbox: Introduce TX doorbell with ACK

2019-06-11 Thread Daniel Baluta
On Tue, Jun 11, 2019 at 11:40 AM Oleksij Rempel wrote: > > On Tue, Jun 11, 2019 at 10:52:47AM +0300, Daniel Baluta wrote: > > Hi Oleksij, > > > > On Tue, Jun 11, 2019 at 8:56 AM Oleksij Rempel > > wrote: > > > > > > Hi Daniel, > > > &

Re: [PATCH v3 2/2] arm64: dts: imx8mm-evk: Enable audio codec wm8524

2019-05-28 Thread Daniel Baluta
On Mon, May 20, 2019 at 10:33 PM Fabio Estevam wrote: > > On Thu, May 16, 2019 at 3:35 PM Fabio Estevam wrote: > > > > On Wed, May 15, 2019 at 11:42 AM Daniel Baluta > > wrote: > > > > > + simple-audio-card,codec { > > &

Re: [alsa-devel] [PATCH] ASoC: fsl: sai: Fix clock source for mclk0

2019-05-28 Thread Daniel Baluta
On Sun, Apr 21, 2019 at 11:26 AM Nicolin Chen wrote: > > On Sun, Apr 21, 2019 at 01:04:39AM -0700, Nicolin Chen wrote: > > On Sun, Apr 21, 2019 at 10:26:40AM +0300, Daniel Baluta wrote: > > > > Firstly, according to your commit message, neither imx8qm nor > > >

[PATCH 0/3] Add mclk0 clock source for SAI

2019-05-28 Thread Daniel Baluta
r MUX option 0. [1] lkml.org/lkml/2019/4/20/141 [2] lkml.org/lkml/2019/4/20/56 Daniel Baluta (2): dt-bindings: sound: Clarify the usage of clocks in SAI ASoC: fsl_sai: Read SAI clock source 0 from DT Shengjiu Wang (1): ARM: dts: imx: Add mclk0 clock for SAI Documentation/devicetree/bin

[PATCH 1/3] ARM: dts: imx: Add mclk0 clock for SAI

2019-05-28 Thread Daniel Baluta
generic way in SAI driver. Signed-off-by: Shengjiu Wang Signed-off-by: Daniel Baluta --- arch/arm/boot/dts/imx6sx.dtsi | 6 -- arch/arm/boot/dts/imx6ul.dtsi | 9 ++--- arch/arm/boot/dts/imx7s.dtsi | 9 ++--- 3 files changed, 16 insertions(+), 8 deletions(-) diff --git a/arch/arm/boot

[PATCH 3/3] ASoC: fsl_sai: Read SAI clock source 0 from DT

2019-05-28 Thread Daniel Baluta
ion selected. 11b - Master Clock (MCLK) 3 option selected. So, this patch will read mclk0 source clock from device tree. Signed-off-by: Shengjiu Wang Signed-off-by: Daniel Baluta --- sound/soc/fsl/fsl_sai.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sound/soc/fsl/fsl_sai.

[PATCH 2/3] dt-bindings: sound: Clarify the usage of clocks in SAI

2019-05-28 Thread Daniel Baluta
SAI might have up to 4 clock sources selected by an internal CLK mux. On imx6/7 mclk0/mclk1 are the same, while on imx8 mclk0 and mclk1 are coming from different sources. Signed-off-by: Daniel Baluta --- Documentation/devicetree/bindings/sound/fsl-sai.txt | 5 +++-- 1 file changed, 3

Re: [PATCH V2 1/2] soc: imx: Add SCU SoC info driver support

2019-05-15 Thread Daniel Baluta
Hi Anson, Since you are going to send a new version for this please consider my comment inline. > +static u32 imx8qxp_soc_revision(void) > +{ > + struct imx_sc_msg_misc_get_soc_id msg; > + struct imx_sc_rpc_msg *hdr = &msg.hdr; > + u32 rev = 0; No need to initialize this here

[PATCH v3 1/2] arm64: dts: imx8mm: Add SAI nodes

2019-05-15 Thread Daniel Baluta
i.MX8MM has 5 SAI instances with the following base addresses according to RM. SAI1 base address: 3001_h SAI2 base address: 3002_h SAI3 base address: 3003_h SAI5 base address: 3005_h SAI6 base address: 3006_h Signed-off-by: Daniel Baluta --- arch/arm64/boot/dts/freescale

[PATCH v3 2/2] arm64: dts: imx8mm-evk: Enable audio codec wm8524

2019-05-15 Thread Daniel Baluta
* codec node * simple-card configuration Signed-off-by: Daniel Baluta --- arch/arm64/boot/dts/freescale/imx8mm-evk.dts | 55 1 file changed, 55 insertions(+) diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts index

[RESEND PATCH v3 0/2] Enable wm8524 codec on i.MX8MM EVK

2019-05-15 Thread Daniel Baluta
codec phandle Changes since v1: - use "fsl,imx8mm-sai", "fsl,imx8mq-sai" compatbile strings and remove "fsl,imx6sx-sai" because SAI module on i.MX8M is not compatbile with SAI modules form i.MX6 RESEND to fix email encoding. Daniel Baluta

Re: [PATCH] ASoC: AK4458: add regulator for ak4458

2019-05-16 Thread Daniel Baluta
On Thu, 2019-05-16 at 13:00 +, Viorel Suman wrote: > From: Shengjiu Wang > > Add regulator for ak4458. > Hi Viorel, While at it please disable/enable the regulator in suspend/resume. thanks, Daniel.

[PATCH] regmap: debugfs: Fix memory leak in regmap_debugfs_init

2019-05-17 Thread Daniel Baluta
gfs_name is allocated using kasprintf and then the pointer is lost by assigning it other memory address. Reported-by: Stefan Wahren Signed-off-by: Daniel Baluta --- drivers/base/regmap/regmap-debugfs.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/base/regmap/regmap-debugfs

[PATCH 0/2] Add support for DSP IPC protocol driver

2019-06-14 Thread daniel . baluta
From: Daniel Baluta Hifi4 DSP can be found on some i.MX8 platforms (e.g i.MX8QXP, i.MX8QM). This patch series introduces the layer that allows Host CPU to communicate with DSP. This layer provides a doorbell and clients can used that to notify DSP that a message is placed somewhere in the

[PATCH 1/2] firmware: imx: Add DSP IPC protocol driver

2019-06-14 Thread daniel . baluta
From: Daniel Baluta Some of i.MX8 processors (e.g i.MX8QM, i.MX8QXP) contain the Tensilica HiFi4 DSP for advanced pre- and post-audio processing. The communication between Host CPU and DSP firmware is taking place using a shared memory area for message passing and a dedicated Messaging Unit for

[PATCH 2/2] dt-bindings: arm: fsl: Add DSP IPC binding support

2019-06-14 Thread daniel . baluta
From: Daniel Baluta DSP IPC is the layer that allows the Host CPU to communicate with DSP firmware. DSP is part of some i.MX8 boards (e.g i.MX8QM, i.MX8QXP) Signed-off-by: Daniel Baluta --- .../bindings/arm/freescale/fsl,dsp.yaml | 43 +++ 1 file changed, 43 insertions

Re: [PATCH 1/2] firmware: imx: Add DSP IPC protocol driver

2019-06-14 Thread Daniel Baluta
On Fri, Jun 14, 2019 at 12:08 PM Oleksij Rempel wrote: > > Hi Daniel, > > please, see my review inline. Thanks Oleksij for review. See my answers inline. > > On Fri, Jun 14, 2019 at 04:16:49PM +0800, daniel.bal...@nxp.com wrote: > > From: Daniel Baluta > > >

Re: [PATCH 0/3] Add mclk0 clock source for SAI

2019-05-30 Thread Daniel Baluta
On Wed, 2019-05-29 at 16:03 -0700, Nicolin Chen wrote: > On Tue, May 28, 2019 at 01:20:46PM +0000, Daniel Baluta wrote: > > > 1) SAI clock source select MUX is really part of the hardware > > 2) flexibility! We let DT tell us which is the option for MUX > > option 0. &

[PATCH v3 0/2] Introduce multi PM domains helpers

2020-06-24 Thread Daniel Baluta
From: Daniel Baluta i.MX8QXP/i.MX8QM has IPs that need multiple power domains to be up in order to work. In order to help drivers, we introduce multi PM domains helpers that are able to activate/deactivate multi PM domains. First patch introduces the helpers and second patch demonstrates how a

[PATCH v3 1/2] PM / domains: Introduce multi PM domains helpers

2020-06-24 Thread Daniel Baluta
From: Daniel Baluta This patch introduces helpers support for multi PM domains. API consists of: 1) dev_multi_pm_attach - powers up all PM domains associated with a given device. Because we can attach one PM domain per device, we create virtual devices (children of initial device) and

[PATCH v3 2/2] ASoC: SOF: Use multi PM domains helpers

2020-06-24 Thread Daniel Baluta
From: Daniel Baluta Use dev_multi_pm_attach / dev_multi_pm_detach instead of the hardcoded version. Signed-off-by: Daniel Baluta --- sound/soc/sof/imx/imx8.c | 60 ++-- 1 file changed, 9 insertions(+), 51 deletions(-) diff --git a/sound/soc/sof/imx/imx8.c

[PATCH v3 0/2] imx-wm8962: Let codec driver enable/disable its MCLK

2017-03-28 Thread Daniel Baluta
codec_clk cleanup * fixed prefix subject Daniel Baluta (2): ASoC: imx-wm8962: Let codec driver enable/disable its MCLK ASoC: imx-wm8962: Fix codec_clk cleanup sound/soc/fsl/imx-wm8962.c | 41 + 1 file changed, 9 insertions(+), 32 deletions

[PATCH v3 1/2] ASoC: imx-wm8962: Let codec driver enable/disable its MCLK

2017-03-28 Thread Daniel Baluta
WM8962 needs its MCLK when powerup in wm8962_resume(). Thus it's better to control the MCLK in codec driver. Thus remove the clock enable in machine driver accordingly. While at it, get rid of imx_wm8962_remove function since it is now empty. Signed-off-by: Daniel Baluta --- sound/soc/fs

[PATCH v3 2/2] ASoC: imx-wm8962: Fix codec_clk cleanup

2017-03-28 Thread Daniel Baluta
Resource managed devm_clk_get only works with platform's device dev. Reported-by: Nicolin Chen Signed-off-by: Daniel Baluta --- sound/soc/fsl/imx-wm8962.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sound/soc/fsl/imx-wm8962.c b/sound/soc/fsl/imx-wm8962.c index 3d

Re: [alsa-devel] [PATCH v3 2/2] ASoC: imx-wm8962: Fix codec_clk cleanup

2017-03-28 Thread Daniel Baluta
On Tue, Mar 28, 2017 at 12:21 PM, Charles Keepax wrote: > On Tue, Mar 28, 2017 at 11:58:52AM +0300, Daniel Baluta wrote: >> Resource managed devm_clk_get only works with platform's device dev. >> > > I feel like this could use an explaination of why not using devm &g

Re: [alsa-devel] [PATCH v3 2/2] ASoC: imx-wm8962: Fix codec_clk cleanup

2017-03-29 Thread Daniel Baluta
On Tue, Mar 28, 2017 at 6:24 PM, Mark Brown wrote: > On Tue, Mar 28, 2017 at 12:53:06PM +0100, Charles Keepax wrote: >> On Tue, Mar 28, 2017 at 01:47:04PM +0300, Daniel Baluta wrote: > >> > >> - codec_clk = devm_clk_get(&codec_dev->dev, NULL); >> > &

Re: [Outreachy kernel] [PATCH 1/4] iio: common: st_sensors: Replace ternary operator with min macro

2017-03-29 Thread Daniel Baluta
On Wed, Mar 29, 2017 at 3:33 PM, simran singhal wrote: > Use macro min() to get the minimum of two values for brevity and > readability. > > Signed-off-by: simran singhal > --- > drivers/iio/common/st_sensors/st_sensors_i2c.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH] ASoC: codec: wm9860: avoid maybe-uninitialized warning

2017-04-19 Thread Daniel Baluta
Hi Arnd, On Wed, Apr 19, 2017 at 8:04 PM, Arnd Bergmann wrote: > The new PLL configuration code triggers a harmless warning: > > sound/soc/codecs/wm8960.c: In function 'wm8960_configure_clocking': > sound/soc/codecs/wm8960.c:735:3: error: 'best_freq_out' may be used > uninitialized in this funct

<    4   5   6   7   8   9   10   11   >