[PATCH] net: fix psock_fanout selftest bind error message

2013-03-20 Thread Daniel Baluta
Signed-off-by: Daniel Baluta --- .../testing/selftests/net-afpacket/psock_fanout.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tools/testing/selftests/net-afpacket/psock_fanout.c b/tools/testing/selftests/net-afpacket/psock_fanout.c index f765f09..226e5e3 100644

Re: [PATCH] net: fix psock_fanout selftest bind error message

2013-03-20 Thread Daniel Baluta
ck_fanout-selftest-bind-error-message.patch "David S. Miller" (commit_signer:4/4=100%) Willem de Bruijn (commit_signer:2/4=50%) Daniel Baluta (commit_signer:1/4=25%) Eric Dumazet (commit_signer:1/4=25%) linux-kernel@vger.kernel.org (open list) thanks, Daniel. -- To unsubscribe from this

[PATCH] perf/hwbp: Fix cleanup in case of kzalloc failure

2013-02-06 Thread Daniel Baluta
Obviously this is a typo and could result in memory leaks if kzalloc fails on a given cpu. Signed-off-by: Daniel Baluta --- kernel/events/hw_breakpoint.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/kernel/events/hw_breakpoint.c b/kernel/events/hw_breakpoint.c index

[PATCH] ndisc: bool initializations should use true and false

2013-07-13 Thread Daniel Baluta
Signed-off-by: Daniel Baluta --- net/ipv6/ndisc.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/ipv6/ndisc.c b/net/ipv6/ndisc.c index b3b5730..24c03396 100644 --- a/net/ipv6/ndisc.c +++ b/net/ipv6/ndisc.c @@ -479,7 +479,7 @@ static void ndisc_send_na(struct

Re: [PATCH] mm: fix overflow in alloc_vmap_area

2013-06-20 Thread Daniel Baluta
gt;> A printk placed in __insert_vmap_area will show: >> >> [ 95.218256] va->va_start=0xfecfb000 tmp_va->va_end=0xf85e2000 >> va->va_end=0 tmp_va->va_start=0xf85dc000 >> >> and another one, before sum operation in alloc_vmap_area: >> >> [ 95.2182

Re: [PATCH] net: fix build warning in trans_rdma.c

2013-07-30 Thread Daniel Baluta
On Tue, Jul 30, 2013 at 12:15 PM, Xishi Qiu wrote: > When building v3.11-rc3, I get the following warning: > ... > net/9p/trans_rdma.c:594: warning: ‘rdma_cancelled’ defined but not used > ... > As the function is not be used, so remove it. > > Signed-off-by: Xishi Qiu > --- > net/9p/trans_rdma.

Re: [PATCH] lustre:libcfs: remove redundant code.

2013-07-19 Thread Daniel Baluta
On Fri, Jul 19, 2013 at 6:46 PM, Greg Kroah-Hartman wrote: > On Fri, Jul 19, 2013 at 06:29:34PM +0300, Alexandru Juncu wrote: >> On 19 July 2013 18:21, Pekka Enberg wrote: >> > On Fri, Jul 19, 2013 at 6:13 PM, Alexandru Juncu wrote: >> >> I was thinking the same thing, but I hesitated because I

[PATCH] lguest: rename i386_head.S

2013-05-03 Thread Daniel Baluta
Since commit 9a163ed8e0 (i386: move kernel) kernel/i386_head.S was renamed to kernel/head_32.S. We do the same for lguest/i386_head.S. Signed-off-by: Daniel Baluta --- arch/x86/lguest/{i386_head.S => head_32.S} |0 1 files changed, 0 insertions(+), 0 deletions(-) rename arch/x86/lgu

[PATCH v2] lguest: rename i386_head.S

2013-05-03 Thread Daniel Baluta
Since commit 9a163ed8e0 (i386: move kernel) kernel/i386_head.S was renamed to kernel/head_32.S. We do the same for lguest/i386_head.S. Signed-off-by: Daniel Baluta --- Changes since v1: * use head_32.o in Makefile arch/x86/lguest/Makefile |2 +- arch/x86/lguest

Re: [PATCH] hugetlb: fix sparse warning for hugetlb_register_node

2013-03-07 Thread Daniel Baluta
On Mon, Mar 4, 2013 at 12:46 PM, Claudiu Ghioc wrote: > Removed the following sparse warnings: > * mm/hugetlb.c:1764:6: warning: symbol > 'hugetlb_unregister_node' was not declared. > Should it be static? > * mm/hugetlb.c:1808:6: warning: symbol > 'hugetlb_register_node' was not dec

Re: [PATCH] kgdb: Removed kmalloc returned value cast

2013-03-10 Thread Daniel Baluta
On Sun, Mar 10, 2013 at 4:10 PM, Pekka Enberg wrote: > On Sun, Mar 10, 2013 at 3:06 PM, Alex Grad wrote: >> Signed-off-by: Alex Grad >> --- >> arch/powerpc/kernel/kgdb.c |2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/powerpc/kernel/kgdb.c b/arch/powerpc/kern

Re: [PATCH] block: replace kmalloc and then memcpy with kmemdup

2013-03-11 Thread Daniel Baluta
Hi Konrad, The performance is the same using kmemdup, but we have the following advantages: * code is cleaner * kmemdup adds additional debugging info useful for tracking the real place where memory was allocated [1] [2]. thanks, Daniel. [1] http://lxr.linux.no/#linux+v3.8.2/mm/util.c#L61 [2] ht

Re: [PATCH] Arch: x86: kernel: smpboot.c: Remove unused variable

2013-03-11 Thread Daniel Baluta
On Mon, Mar 11, 2013 at 9:23 PM, Valentin Ilie wrote: > Remove unused variable 'c' > > Signed-off-by: Valentin Ilie > --- > arch/x86/kernel/smpboot.c |1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c > index a6ceaed..7bc998a 100644 >

Re: [PATCH] virtio: suppress kmemleak false positive

2013-01-11 Thread Daniel Baluta
On Fri, Jan 11, 2013 at 4:32 PM, Daniel Baluta wrote: > > > On Fri, Jan 11, 2013 at 4:02 PM, Catalin Marinas > wrote: >> >> On Fri, Jan 11, 2013 at 01:51:43PM +, Alexandru Copot wrote: >> > While doing simple IPv6 tests in KVM virtual machines, >> &

Re: [PATCH] tools/lguest: Don't bork the terminal in case of wrong args

2016-09-07 Thread Daniel Baluta
On Tue, Dec 8, 2015 at 4:35 PM, Daniel Baluta wrote: > Running lguest without arguments or with a wrong argument name > borks the terminal, because the cleanup handler is set up too late > in the initialization process. > > Signed-off-by: Daniel Baluta Hi Rusty, Any chance to pick this up?

Re: [PATCH] iio: Move IIO Dummy Driver out of staging

2015-10-12 Thread Daniel Baluta
>> +static unsigned instances = 1; >> +module_param(instances, uint, 0); One concern about this. We will still create a default number of 'instances' when using configuration via configfs? I'm not sure we can remove this parameter once the module is moved out of staging, since we break the ABI

Re: [PATCH v8 1/5] configfs: Allow dynamic group creation

2015-10-22 Thread Daniel Baluta
On Thu, Oct 22, 2015 at 11:40 AM, Christoph Hellwig wrote: > On Tue, Oct 20, 2015 at 01:53:42PM +0300, Daniel Baluta wrote: >> We don't want to hardcode default groups at subsystem >> creation time. We export: >> * configfs_register_group >> * confi

Re: [RFC v1 4/4] iio: chemical: add SGX VZ89x VOC sensor support

2015-09-05 Thread Daniel Baluta
On Sat, Sep 5, 2015 at 8:53 AM, Matt Ranostay wrote: > Add support for VZ89X sensors VOC and CO2 reporting channels in > ppm/ppb units. Adding more info on this would be great. s/VOC/VOC(volatile organic compound) Also, link to datasheet? > > Signed-off-by: Matt Ranostay > --- > .../devicetr

Re: [RFC v1 3/4] devicetree: add SGX Sensortech vendor id

2015-09-05 Thread Daniel Baluta
don't forget to cc devicetree people. On Sat, Sep 5, 2015 at 8:53 AM, Matt Ranostay wrote: > Signed-off-by: Matt Ranostay > --- > Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt

Re: [RFC v1 0/4] iio: new chemical sensor framework and channel types

2015-09-05 Thread Daniel Baluta
On Sat, Sep 5, 2015 at 8:53 AM, Matt Ranostay wrote: > Initial RFC for new chemical sensor framework, IIO_CONCENTRATION, > and IIO_RESISTANCE channel types. > > Important notes: > * Not been tested on real hardware yet but that isn't the main RFC reason and > once hardware is in hand it will be

Re: [PATCH] staging: iio: select IRQ_WORK for IIO_DUMMY_EVGEN

2015-10-19 Thread Daniel Baluta
;: > (.text+0x208a04): undefined reference to `irq_work_queue' > > This changes the Kconfig file to match what other drivers do. > > Signed-off-by: Arnd Bergmann > Fixes: fd2bb310ca3d ("Staging: iio: Move evgen interrupt generation to > irq_work") Acked-by: Daniel

[PATCH v8 3/5] iio: core: Introduce IIO software triggers

2015-10-20 Thread Daniel Baluta
kernel module is loaded. Software triggers can be created directly from drivers or from user space via configfs interface. Signed-off-by: Daniel Baluta --- drivers/iio/Kconfig | 7 ++ drivers/iio/Makefile | 1 + drivers/iio/industrialio-configfs.c | 37

[PATCH v8 1/5] configfs: Allow dynamic group creation

2015-10-20 Thread Daniel Baluta
ed-by: Lars-Peter Clausen Signed-off-by: Daniel Baluta --- fs/configfs/dir.c| 50 include/linux/configfs.h | 4 2 files changed, 54 insertions(+) diff --git a/fs/configfs/dir.c b/fs/configfs/dir.c index c81ce7f..1f5337c 100644 ---

[PATCH v8 0/5] Add initial configfs support for IIO

2015-10-20 Thread Daniel Baluta
none * patch 3/4 - none * patch 4/4 - removed "Further work" chapter in iio_configfs.txt - added configfs-iio file in Documentation/ABI/testing Daniel Baluta (5): configfs: Allow dynamic group creation iio: core: Introduce IIO conf

[PATCH v8 4/5] iio: trigger: Introduce IIO hrtimer based trigger

2015-10-20 Thread Daniel Baluta
based on an older version from Marten and Lars-Peter. Signed-off-by: Marten Svanfeldt Signed-off-by: Lars-Peter Clausen Signed-off-by: Daniel Baluta --- drivers/iio/trigger/Kconfig| 10 ++ drivers/iio/trigger/Makefile | 2 + drivers/iio/trigger/iio-trig-hrtimer.c | 193

[PATCH v8 5/5] iio: Documentation: Add IIO configfs documentation

2015-10-20 Thread Daniel Baluta
Signed-off-by: Daniel Baluta --- Documentation/ABI/testing/configfs-iio | 21 Documentation/iio/iio_configfs.txt | 93 ++ 2 files changed, 114 insertions(+) create mode 100644 Documentation/ABI/testing/configfs-iio create mode 100644 Documentation

[PATCH v8 2/5] iio: core: Introduce IIO configfs support

2015-10-20 Thread Daniel Baluta
This creates an IIO configfs subystem named "iio", with a default "triggers" group. Next patches will add trigger types support, allowing new triggers creation using configfs. Signed-off-by: Daniel Baluta --- drivers/iio/Kconfig | 8 +

Re: [PATCH v8 5/5] iio: Documentation: Add IIO configfs documentation

2015-10-20 Thread Daniel Baluta
On Tue, Oct 20, 2015 at 2:50 PM, Crt Mori wrote: > On 20 October 2015 at 12:53, Daniel Baluta wrote: >> Signed-off-by: Daniel Baluta >> --- >> Documentation/ABI/testing/configfs-iio | 21 >> Documentation/iio/iio_configfs.txt | 93 >> +

[PATCH v9 0/5] Add initial configfs support for IIO

2015-10-23 Thread Daniel Baluta
none * patch 4/4 - removed "Further work" chapter in iio_configfs.txt - added configfs-iio file in Documentation/ABI/testing Daniel Baluta (5): configfs: Allow dynamic group creation iio: core: Introduce IIO configfs support iio: core: In

[PATCH v9 2/5] iio: core: Introduce IIO configfs support

2015-10-23 Thread Daniel Baluta
: Daniel Baluta --- drivers/iio/Kconfig | 8 ++ drivers/iio/Makefile| 1 + drivers/iio/industrialio-configfs.c | 50 + 3 files changed, 59 insertions(+) create mode 100644 drivers/iio/industrialio-configfs.c diff --git a

[PATCH v9 5/5] iio: Documentation: Add IIO configfs documentation

2015-10-23 Thread Daniel Baluta
Signed-off-by: Daniel Baluta --- Documentation/ABI/testing/configfs-iio | 21 Documentation/iio/iio_configfs.txt | 93 ++ 2 files changed, 114 insertions(+) create mode 100644 Documentation/ABI/testing/configfs-iio create mode 100644 Documentation

[PATCH v9 3/5] iio: core: Introduce IIO software triggers

2015-10-23 Thread Daniel Baluta
The first support trigger type is "hrtimer" found under /config/iio/triggers/hrtimer. Signed-off-by: Daniel Baluta --- drivers/iio/Kconfig | 8 ++ drivers/iio/Makefile | 1 + drivers/iio/industrialio-sw-trigger.c | 206 +

[PATCH v9 1/5] configfs: Allow dynamic group creation

2015-10-23 Thread Daniel Baluta
ed-by: Lars-Peter Clausen Signed-off-by: Daniel Baluta --- fs/configfs/dir.c| 102 +++ include/linux/configfs.h | 8 2 files changed, 110 insertions(+) diff --git a/fs/configfs/dir.c b/fs/configfs/dir.c index c81ce7f..bf76795 100644 ---

[PATCH v9 4/5] iio: trigger: Introduce IIO hrtimer based trigger

2015-10-23 Thread Daniel Baluta
based on an older version from Marten and Lars-Peter. Signed-off-by: Marten Svanfeldt Signed-off-by: Lars-Peter Clausen Signed-off-by: Daniel Baluta --- drivers/iio/trigger/Kconfig| 10 ++ drivers/iio/trigger/Makefile | 2 + drivers/iio/trigger/iio-trig-hrtimer.c | 193

Re: [PATCH v9 1/5] configfs: Allow dynamic group creation

2015-10-23 Thread Daniel Baluta
On Fri, Oct 23, 2015 at 3:48 PM, Christoph Hellwig wrote: > Hi Daniel, > > all these functions look great, but can you also move your new > iio_sw_trigger_type_configfs_register/unregister functions to the > core code as those are the wrappers that everyone would have to write, > e.g. something li

Re: [PATCH v9 1/5] configfs: Allow dynamic group creation

2015-10-23 Thread Daniel Baluta
Christoph, one question. See below. On Fri, Oct 23, 2015 at 3:48 PM, Christoph Hellwig wrote: > Hi Daniel, > > all these functions look great, but can you also move your new > iio_sw_trigger_type_configfs_register/unregister functions to the > core code as those are the wrappers that everyone wou

[PATCH v10 0/5] Add initial configfs support for IIO

2015-10-23 Thread Daniel Baluta
"Further work" chapter in iio_configfs.txt - added configfs-iio file in Documentation/ABI/testing Daniel Baluta (5): configfs: Allow dynamic group creation iio: core: Introduce IIO configfs support iio: core: Introduce IIO software triggers iio: trigger: Introd

[PATCH v10 2/5] iio: core: Introduce IIO configfs support

2015-10-23 Thread Daniel Baluta
: Daniel Baluta --- drivers/iio/Kconfig | 8 ++ drivers/iio/Makefile| 1 + drivers/iio/industrialio-configfs.c | 50 + 3 files changed, 59 insertions(+) create mode 100644 drivers/iio/industrialio-configfs.c diff --git a

[PATCH v10 5/5] iio: Documentation: Add IIO configfs documentation

2015-10-23 Thread Daniel Baluta
Signed-off-by: Daniel Baluta --- Documentation/ABI/testing/configfs-iio | 21 Documentation/iio/iio_configfs.txt | 93 ++ 2 files changed, 114 insertions(+) create mode 100644 Documentation/ABI/testing/configfs-iio create mode 100644 Documentation

[PATCH v10 4/5] iio: trigger: Introduce IIO hrtimer based trigger

2015-10-23 Thread Daniel Baluta
based on an older version from Marten and Lars-Peter. Signed-off-by: Marten Svanfeldt Signed-off-by: Lars-Peter Clausen Signed-off-by: Daniel Baluta --- drivers/iio/trigger/Kconfig| 10 ++ drivers/iio/trigger/Makefile | 2 + drivers/iio/trigger/iio-trig-hrtimer.c | 193

[PATCH v10 1/5] configfs: Allow dynamic group creation

2015-10-23 Thread Daniel Baluta
ed-by: Lars-Peter Clausen Signed-off-by: Daniel Baluta --- fs/configfs/dir.c| 110 +++ include/linux/configfs.h | 10 + 2 files changed, 120 insertions(+) diff --git a/fs/configfs/dir.c b/fs/configfs/dir.c index c81ce7f..a7a1b21 100644 ---

[PATCH v10 3/5] iio: core: Introduce IIO software triggers

2015-10-23 Thread Daniel Baluta
The first supported trigger type is "hrtimer" found under /config/iio/triggers/hrtimer. Signed-off-by: Daniel Baluta --- drivers/iio/Kconfig | 8 ++ drivers/iio/Makefile | 1 + drivers/iio/industrialio-sw-trigger.c | 183 +

Re: [PATCH v4] iio: chemical: Add support for Bosch BME680 sensor

2018-07-21 Thread Daniel Baluta
On Sat, Jul 21, 2018 at 6:43 PM, Andy Shevchenko wrote: > On Sat, Jul 21, 2018 at 6:36 PM, Himanshu Jha > wrote: > >>> > + /* Look up table 1 for the possible gas range values */ >>> > + u32 lookupTable1[16] = {2147483647u, 2147483647u, 2147483647u, >>> > + 214748364

[PATCH] ASoC: codecs: Add support for AK5558 ADC driver

2018-01-31 Thread Daniel Baluta
Signed-off-by: Shengjiu Wang Signed-off-by: Daniel Baluta --- Documentation/devicetree/bindings/sound/ak5558.txt | 20 + sound/soc/codecs/Kconfig | 6 + sound/soc/codecs/Makefile | 2 + sound/soc/codecs/ak5558.c | 754

Re: [PATCH] ASoC: codecs: Add support for AK5558 ADC driver

2018-02-01 Thread Daniel Baluta
Hi Fabio, Andy, Thanks a lot for your comments. I will address them and send v2. Few comments inline. On Mi, 2018-01-31 at 18:12 +0200, Andy Shevchenko wrote: > On Wed, Jan 31, 2018 at 2:57 PM, Daniel Baluta wrote: > > > > AK5558 is a 32-bit, 768 kHZ sampling, differential in

Re: [alsa-devel] [PATCH v3 1/5] ALSA: soc-compress: add support to snd_compr_set_runtime_buffer()

2018-11-15 Thread Daniel Baluta
Hi Srinivas, One minor comment: > struct snd_compr_ops *ops; > + struct snd_dma_buffer *dma_buffer_p; I don't think it is necessary to encode the type inside the name variable So, dma_buffer would sounds better to me then dma_buffer_p; > void *buffer; It is also consist

Re: [PATCH] clk: imx: Make the i.MX8MQ CCM clock driver CLK_IMX8MQ dependant

2018-12-13 Thread Daniel Baluta
> --- a/drivers/clk/imx/Makefile > +++ b/drivers/clk/imx/Makefile > @@ -34,5 +34,6 @@ obj-$(CONFIG_SOC_IMX6SX) += clk-imx6sx.o > obj-$(CONFIG_SOC_IMX6UL) += clk-imx6ul.o > obj-$(CONFIG_SOC_IMX7D) += clk-imx7d.o > obj-$(CONFIG_SOC_IMX7ULP) += clk-imx7ulp.o > -obj-$(CONFIG_SOC_IMX8MQ) += clk-im

Re: [REGRESSION] imx_v6_v7_defconfig: undefined reference to `__hyp_stub_vectors'

2018-12-19 Thread Daniel Baluta
On Wed, 2018-12-19 at 12:42 +, Marcel Ziswiler wrote: > Hi there > > I noticed that at least today's and yesterdays -next won't build with > the imx_v6_v7_defconfig giving the following error: > > LD arch/arm/boot/compressed/vmlinux > arch/arm/boot/compressed/head.o: In function `rest

Re: [REGRESSION] imx_v6_v7_defconfig: undefined reference to `__hyp_stub_vectors'

2018-12-19 Thread Daniel Baluta
On Wed, Dec 19, 2018 at 3:17 PM Daniel Baluta wrote: > > > On Wed, 2018-12-19 at 12:42 +, Marcel Ziswiler wrote: > > Hi there > > > > I noticed that at least today's and yesterdays -next won't build with > > the imx_v6_v7_defconfig giving the follo

Re: [PATCH] clk: imx: Make the i.MX8MQ CCM clock driver CLK_IMX8MQ dependant

2018-12-14 Thread Daniel Baluta
On Fri, Dec 14, 2018 at 3:02 AM Shawn Guo wrote: > > On Thu, Dec 13, 2018 at 04:51:18PM +, Aisheng Dong wrote: > > [...] > > > > > > --- a/drivers/clk/imx/Makefile > > > > +++ b/drivers/clk/imx/Makefile > > > > @@ -34,5 +34,6 @@ obj-$(CONFIG_SOC_IMX6SX) += clk-imx6sx.o > > > > obj-$(CONFIG_SO

[PATCH 2/2] ASoC: dt-bindings: Document support for ak4497

2019-01-04 Thread Daniel Baluta
ak4458 driver supports also ak4497 codec. Signed-off-by: Daniel Baluta --- Documentation/devicetree/bindings/sound/ak4458.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/sound/ak4458.txt b/Documentation/devicetree/bindings/sound/ak4458

[PATCH 0/2] Add support for AK4497 codec

2019-01-04 Thread Daniel Baluta
AK4497 is almost register compatible with AK4458. Almost means that AK4497 has an extra "debug" register that we currently do not use. Daniel Baluta (2): ASoC: ak4458: Add support for AK4497 ASoC: dt-bindings: Document support for ak4497 .../devicetree/bindings/sound/ak4458.txt

[PATCH 1/2] ASoC: ak4458: Add support for AK4497

2019-01-04 Thread Daniel Baluta
/file/ev-board-manual/AK4497EQ.pdf Datasheet for AK4458 is at: https://www.akm.com/akm/en/file/datasheet/AK4458VN.pdf Signed-off-by: Daniel Baluta --- sound/soc/codecs/ak4458.c | 79 +-- 1 file changed, 76 insertions(+), 3 deletions(-) diff --git a/sound/soc

Re: [PATCH v2 0/5] PM: domains: Add helpers for multi PM domains to avoid open-coding

2024-01-08 Thread Daniel Baluta
On Fri, Jan 5, 2024 at 6:02 PM Ulf Hansson wrote: > > Updates in v2: > - Ccing Daniel Baluta and Iuliana Prodan the NXP remoteproc patches to > requests help with testing. > - Fixed NULL pointer bug in patch1, pointed out by Nikunj. > - Added so

Re: [PATCH v2 0/4] remoteproc: imx_rproc: various patches for misc

2024-07-19 Thread Daniel Baluta
> Signed-off-by: Peng Fan Neat and clean. Reviewed-by: Daniel Baluta Thanks Peng!

Re: [PATCH v2 0/2] remoteproc: imx_rproc: support non-blocking tx for i.MX7ULP

2024-07-19 Thread Daniel Baluta
for completion. > > patch 1 is to support non-blocking tx mailbox channel > patch 2 is to switch to non-blocking tx for system poweroff or restart. > > Based on patchset: > https://lore.kernel.org/all/20240719-imx_rproc-v2-0-10d0268c7...@nxp.com/ > > Signed-off-by: Peng Fan Series looks good to me. Reviewed-by: Daniel Baluta

Re: [PATCH v2 2/2] remoteproc: imx_rproc: handle system off for i.MX7ULP

2024-08-21 Thread Daniel Baluta
Hello Mathieu, I've talked to Peng and if my understanding is correct I think the patch is OK. Maybe we can split the patch in two: * first, adding the power off callback with explanations. * second, adding the restart callback with explanations. And also add a more detailed explanation. Power o

Re: [PATCH v3 1/2] remoteproc: imx_rproc: Allow setting of the mailbox transmit mode

2024-08-23 Thread Daniel Baluta
x_block mode to be set (true/false) depending on usecase. > > No functional changes. > > Signed-off-by: Peng Fan Reviewed-by: Daniel Baluta

Re: [PATCH v3 2/2] remoteproc: imx_rproc: Add support for poweroff and reboot

2024-08-23 Thread Daniel Baluta
eate them as non-blocking. > > Note that power off and restart are totally different operations and are > not complementary. > > We introduce a new flag in the imx remoteproc per device data which tells > us when a device needs this special setup. For now, only imx7ulp needs it. > > Signed-off-by: Peng Fan Reviewed-by: Daniel Baluta

Re: [PATCH 2/2] arm64: dts: imx8mp: add reserve-memory nodes for DSP

2023-09-12 Thread Daniel Baluta
On Tue, Sep 12, 2023 at 12:54 PM Iuliana Prodan wrote: > > On 9/12/2023 11:26 AM, Krzysztof Kozlowski wrote: > > On 12/09/2023 10:13, Iuliana Prodan wrote: > >> On 9/12/2023 10:07 AM, Krzysztof Kozlowski wrote: > >>> On 12/09/2023 00:44, Iuliana Prodan (OSS) wrote: > From: Iuliana Prodan > >

Re: [PATCH 03/10] iio: imu: kmx61: Enhance error handling

2015-01-05 Thread Daniel Baluta
On 01/04/2015 12:45 PM, Jonathan Cameron wrote: On 01/01/15 13:47, Hartmut Knaack wrote: Daniel Baluta schrieb am 23.12.2014 um 14:22: This fixes parts of kmx61 error handling to make code easier to read and to be more consistent with IIO coding conventions: * prefer as single point

[PATCH v2] iio: imu: kmx61: Drop odr_bits from kmx61_samp_freq_table

2015-01-05 Thread Daniel Baluta
odr_bits values are between 0 and 11, so we can use the index in kmx61_samp_freq_table instead of odr_bits structure member. Signed-off-by: Daniel Baluta --- Changes since v1: * use ARRAY_SIZE instead of an hardcoded value * review is at: https://lkml.org/lkml/2015/1/1/46

Re: [PATCH V1 1/1] iio: Added Capella cm3232 ambient light sensor driver.

2015-01-05 Thread Daniel Baluta
On Thu, Jan 1, 2015 at 2:10 AM, Kevin Tsai wrote: > CM3232 is an advanced ambient light sensor with I2C protocol interface. > The I2C slave address is internally hardwired as 0x10 (7-bit). Writing > to configure register is byte mode, but reading ALS register requests to > use word mode for 16-bi

Re: [PATCH V1 1/1] iio: Added Capella cm3232 ambient light sensor driver.

2015-01-05 Thread Daniel Baluta
On Mon, Jan 5, 2015 at 3:09 PM, Joe Perches wrote: > On Mon, 2015-01-05 at 12:51 +0200, Daniel Baluta wrote: >> On Thu, Jan 1, 2015 at 2:10 AM, Kevin Tsai wrote: >> > CM3232 is an advanced ambient light sensor with I2C protocol interface. >> > The I2C slave address

Re: [PATCH V1 1/1] iio: Added Capella cm3232 ambient light sensor driver.

2015-01-05 Thread Daniel Baluta
On Mon, Jan 5, 2015 at 6:42 PM, Joe Perches wrote: > On Mon, 2015-01-05 at 16:20 +0200, Daniel Baluta wrote: >> On Mon, Jan 5, 2015 at 3:09 PM, Joe Perches wrote: >> > On Mon, 2015-01-05 at 12:51 +0200, Daniel Baluta wrote: >> >> On Thu, Jan 1, 2015 at 2:10 AM, Kev

[PATCH 00/10] iio: KMX61 fixes

2014-12-23 Thread Daniel Baluta
//marc.info/?l=linux-kernel&m=141868557909385&w=2 Daniel Baluta (10): iio: imu: kmx61: Save odr_bits for later use iio: imu: kmx61: Don't ignore kmx61_set_power_state errors iio: imu: kmx61: Enhance error handling iio: imu: kmx61: Fixup parameters alignment iio: imu: kmx61: Drop unused dev

[PATCH 07/10] iio: imu: kmx61: Fix device initialization when setting trigger state

2014-12-23 Thread Daniel Baluta
Signed-off-by: Daniel Baluta --- drivers/iio/imu/kmx61.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/iio/imu/kmx61.c b/drivers/iio/imu/kmx61.c index 30825cf..5b5be2b 100644 --- a/drivers/iio/imu/kmx61.c +++ b/drivers/iio/imu/kmx61.c @@ -1057,8 +1057,7 @@ static

[PATCH 10/10] iio: imu: kmx61: Use correct base when reading data

2014-12-23 Thread Daniel Baluta
We have two IIO devices and we need to adjust the base when reading data. Signed-off-by: Daniel Baluta --- drivers/iio/imu/kmx61.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/iio/imu/kmx61.c b/drivers/iio/imu/kmx61.c index 98369eb..6178cea 100644 --- a

[PATCH 04/10] iio: imu: kmx61: Fixup parameters alignment

2014-12-23 Thread Daniel Baluta
Signed-off-by: Daniel Baluta --- drivers/iio/imu/kmx61.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/iio/imu/kmx61.c b/drivers/iio/imu/kmx61.c index 4fc4f63..2652179 100644 --- a/drivers/iio/imu/kmx61.c +++ b/drivers/iio/imu/kmx61.c @@ -926,11

[PATCH 09/10] iio: imu: kmx61: Drop odr_bits from kmx61_samp_freq_table

2014-12-23 Thread Daniel Baluta
odr_bits values are between 0 and 11, so we can use the index in kmx61_samp_freq_table instead of odr_bits structure member. Signed-off-by: Daniel Baluta --- drivers/iio/imu/kmx61.c | 64 - 1 file changed, 26 insertions(+), 38 deletions(-) diff

[PATCH 08/10] iio: imu: kmx61: Remove unnecessary REG_INS1 read

2014-12-23 Thread Daniel Baluta
Useful in the debugging phase, not needed now. Signed-off-by: Daniel Baluta --- drivers/iio/imu/kmx61.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/iio/imu/kmx61.c b/drivers/iio/imu/kmx61.c index 5b5be2b..eb3900e 100644 --- a/drivers/iio/imu/kmx61.c +++ b/drivers/iio/imu/kmx61

[PATCH 06/10] iio: imu: kmx61: Use false instead of 0 for ev_enable_state

2014-12-23 Thread Daniel Baluta
Signed-off-by: Daniel Baluta --- drivers/iio/imu/kmx61.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/imu/kmx61.c b/drivers/iio/imu/kmx61.c index 332ee67..30825cf 100644 --- a/drivers/iio/imu/kmx61.c +++ b/drivers/iio/imu/kmx61.c @@ -976,7 +976,7 @@ static int

[PATCH 03/10] iio: imu: kmx61: Enhance error handling

2014-12-23 Thread Daniel Baluta
breaking * fix error message for writing REG_CTRL1 Also, add separate error paths for kmx61_trigger_setup/iio_triggered_buffer_setup calls. Signed-off-by: Daniel Baluta --- drivers/iio/imu/kmx61.c | 100 +--- 1 file changed, 43 insertions(+), 57

[PATCH 05/10] iio: imu: kmx61: Drop unused device parameter

2014-12-23 Thread Daniel Baluta
Signed-off-by: Daniel Baluta --- drivers/iio/imu/kmx61.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/iio/imu/kmx61.c b/drivers/iio/imu/kmx61.c index 2652179..332ee67 100644 --- a/drivers/iio/imu/kmx61.c +++ b/drivers/iio/imu/kmx61.c @@ -681,7 +681,7

[PATCH 02/10] iio: imu: kmx61: Don't ignore kmx61_set_power_state errors

2014-12-23 Thread Daniel Baluta
..except while in an error handler, where there is nothing to be done anyway. Signed-off-by: Daniel Baluta --- drivers/iio/imu/kmx61.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/iio/imu/kmx61.c b/drivers/iio/imu/kmx61.c index fe0cee7..e9cbd91 100644

[PATCH 01/10] iio: imu: kmx61: Save odr_bits for later use

2014-12-23 Thread Daniel Baluta
Signed-off-by: Daniel Baluta --- drivers/iio/imu/kmx61.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/iio/imu/kmx61.c b/drivers/iio/imu/kmx61.c index 972424b..fe0cee7 100644 --- a/drivers/iio/imu/kmx61.c +++ b/drivers/iio/imu/kmx61.c @@ -465,6 +465,8 @@ static int kmx61_set_odr

Re: [PATCH] iio: imu: kmx61: fix simple_return.cocci warnings

2014-12-27 Thread Daniel Baluta
ly combine with a > preceding function call. > Generated by: scripts/coccinelle/misc/simple_return.cocci > > CC: Daniel Baluta > Signed-off-by: Fengguang Wu > --- > > kmx61.c |6 +- > 1 file changed, 1 insertion(+), 5 deletions(-) > > --- a/drivers

Re: [PATCH 2/2] nfc: NXP PN544 ACPI support

2015-01-22 Thread Daniel Baluta
On Fri, Jan 9, 2015 at 2:02 PM, Robert Dolca wrote: > Device id: NXP5440 > Pin mapping: > - 0 IRQ pin > - 1 enable pin > - 2 firmware pin > > Signed-off-by: Robert Dolca > --- > drivers/nfc/Kconfig | 1 + > drivers/nfc/pn544/i2c.c | 115 > ++-

Re: [PATCH] iio: light: Add support for Capella CM3323 color/light sensor

2015-01-25 Thread Daniel Baluta
On Sun, Jan 25, 2015 at 12:27 PM, Jonathan Cameron wrote: > On 22/01/15 10:10, Daniel Baluta wrote: >> Minimal implementation providing raw light intensity and illuminance >> readings. For illuminance user can compute lux values using raw readings >> and scale. >> &

Re: [PATCH v2 07/10] iio: core: Introduce IIO_CHAN_INFO_FILTER_OUTLIERS_THRESH and _PERIOD

2015-01-26 Thread Daniel Baluta
On Mon, Jan 26, 2015 at 1:07 AM, Jonathan Cameron wrote: > On 11/01/15 19:10, Irina Tirdea wrote: >> The pedometer needs to filter out false steps that might be generated by >> tapping the foot, sitting, etc. To do that it computes the number of >> steps that occur in a given time and decides the

checkpatch wrong error message

2015-01-09 Thread Daniel Baluta
be 0123456789ab (12 chars). thanks, Daniel. [1] http://marc.info/?l=linux-iio&m=142079625602634&w=2 From 0f9fb78211d73484a4e919d3696f2358d20e9c2c Mon Sep 17 00:00:00 2001 From: Daniel Baluta Date: Fri, 9 Jan 2015 11:17:27 +0200 Subject: [PATCH] iio kmx61 / PM: Replace CONFIG_PM_RUN

Re: checkpatch wrong error message

2015-01-09 Thread Daniel Baluta
On Fri, Jan 9, 2015 at 3:31 PM, Joe Perches wrote: > On Fri, 2015-01-09 at 13:57 +0200, Daniel Baluta wrote: >> Hi Joe, >> >> Running ./scripts/checkpatch on the attached [1] patch i get the >> following error: >> >> ERROR: Please use 12 or more ch

Re: [PATCH V2 1/1] iio: Added Capella cm3232 ambient light sensor driver.

2015-01-12 Thread Daniel Baluta
ed als_raw to regs_als. Moved it to cm3232_chip structure. > Modified cm3232_read_als_it() and cm3232_write_als_it() to support val2. > > Thanks comments from Jeremiah Mahler, Peter Meerwald, Daniel Baluta, > and Joe Perches. > > v1: > Added cm3232.c to support Capella Microsystems CM323

Re: [PATCH V3 1/1] iio: Added Capella cm3232 ambient light sensor driver.

2015-01-16 Thread Daniel Baluta
On Fri, Jan 16, 2015 at 3:41 AM, Kevin Tsai wrote: > CM3232 is an advanced ambient light sensor with I2C protocol interface. > The I2C slave address is internally hardwired as 0x10 (7-bit). Writing > to configure register is byte mode, but reading ALS register requests to > use word mode for 16-b

Re: [RFC PATCH] iio: ak8975: Make sure chipset is always initialized

2015-01-19 Thread Daniel Baluta
Hello, On Sat, Dec 20, 2014 at 11:29 PM, Pandruvada, Srinivas wrote: > +Mika > > On Sat, 2014-12-20 at 13:26 -0800, Srinivas Pandruvada wrote: >> On Sat, 2014-12-20 at 00:25 +0200, Daniel Baluta wrote: >> > On Sat, Dec 20, 2014 at 12:16 AM, Hartmut Knaack wrote: >>

Re: [RFC PATCH] iio: ak8975: Make sure chipset is always initialized

2015-01-19 Thread Daniel Baluta
On Mon, Jan 19, 2015 at 6:44 PM, Pandruvada, Srinivas wrote: > On Mon, 2015-01-19 at 16:40 +0200, Daniel Baluta wrote: >> Hello, >> >> On Sat, Dec 20, 2014 at 11:29 PM, Pandruvada, Srinivas >> wrote: >> > +Mika >> > >> > On Sat, 2014-12-20 a

Re: [RESEND PATCH] configfs: init configfs module earlier at boot time

2015-04-02 Thread Daniel Baluta
On Wed, Mar 18, 2015 at 9:56 PM, Daniel Baluta wrote: > We need this earlier in the boot process to allow various subsystems > to use configfs (e.g Industrial IIO). > > Also, debugfs is at core_initcall level and configfs should be on > the same level from infrastructur

[PATCH v2 0/3] Add initial configfs support for IIO

2015-04-03 Thread Daniel Baluta
s Documentation Changes since v1 are listed in each individual patch. Daniel Baluta (3): iio: configfs: Add configfs support to IIO iio: trigger: Add support for highres timer trigger type iio: Documentation: Add documentation for IIO configfs Documentation/iio/iio_configfs.txt | 82

[PATCH v2 3/3] iio: Documentation: Add documentation for IIO configfs

2015-04-03 Thread Daniel Baluta
Signed-off-by: Daniel Baluta --- Changes since v1: * addressed feedback for v1: * https://lkml.org/lkml/2015/3/25/648 * adapted to match the changes in patches 1 and 2 * fixed some typos and clarified further work Documentation/iio/iio_configfs.txt | 82

[PATCH v2 2/3] iio: trigger: Add support for highres timer trigger type

2015-04-03 Thread Daniel Baluta
he trigger is the same as the dir name. Each trigger will have a "delay" attribute representing the delay between two successive IIO trigger_poll calls. Signed-off-by: Marten Svanfeldt Signed-off-by: Lars-Peter Clausen Signed-off-by: Daniel Baluta --- Changes since v2: * replace

[PATCH v2 1/3] iio: configfs: Add configfs support to IIO

2015-04-03 Thread Daniel Baluta
gger types. To add a new trigger type we must create a new kernel module which implements iio_configfs_trigger.h interface. See Documentation/iio/iio_configfs.txt for more details on how configfs support for IIO works. Signed-off-by: Daniel Baluta --- Changes since v1: * addressed f

Re: [PATCH v2 1/3] iio: configfs: Add configfs support to IIO

2015-04-06 Thread Daniel Baluta
On Sat, Apr 4, 2015 at 9:26 PM, Paul Bolle wrote: > On Fri, 2015-04-03 at 18:57 +0300, Daniel Baluta wrote: >> --- a/drivers/iio/Kconfig >> +++ b/drivers/iio/Kconfig >> +config IIO_CONFIGFS >> + tristate "Enable IIO configuration via configfs" >

[PATCH v3 0/3] Add initial configfs support for IIO

2015-04-06 Thread Daniel Baluta
s Documentation Changes since last version are listed in each individual patch. Daniel Baluta (3): iio: configfs: Add configfs support to IIO iio: trigger: Add support for highres timer trigger type iio: Documentation: Add documentation for IIO configfs Documentation/iio/iio_configfs.txt

[PATCH v3 3/3] iio: Documentation: Add documentation for IIO configfs

2015-04-06 Thread Daniel Baluta
Signed-off-by: Daniel Baluta --- Changes since v2: * fix some whitespace issues reported by Paul Changes since v1: * addressed feedback for v1: * https://lkml.org/lkml/2015/3/25/648 * adapted to match the changes in patches 1 and 2 * fixed some

[PATCH v3 1/3] iio: configfs: Add configfs support to IIO

2015-04-06 Thread Daniel Baluta
gger types. To add a new trigger type we must create a new kernel module which implements iio_configfs_trigger.h interface. See Documentation/iio/iio_configfs.txt for more details on how configfs support for IIO works. Signed-off-by: Daniel Baluta --- Changes since v2: * Fix build erro

[PATCH v3 2/3] iio: trigger: Add support for highres timer trigger type

2015-04-06 Thread Daniel Baluta
he trigger is the same as the dir name. Each trigger will have a "delay" attribute representing the delay between two successive IIO trigger_poll calls. Signed-off-by: Marten Svanfeldt Signed-off-by: Lars-Peter Clausen Signed-off-by: Daniel Baluta --- Changes since v2: * n

Re: [PATCH] lguest: explicitly setup /dev/lguest private_data

2015-04-07 Thread Daniel Baluta
On Tue, Apr 7, 2015 at 11:18 AM, Tom Van Braeckel wrote: > The private_data member of the /dev/lguest device file is used to hold > the current struct lguest and needs to be set to NULL to signify that > no initialization has taken place. > > We explicitly set it to NULL to be independent of whate

Re: [PATCH] iio: light: add support for ROHM BH1710/BH1715/BH1721/BH1750/BH1751 ambient light sensors

2015-04-23 Thread Daniel Baluta
On Tue, Apr 21, 2015 at 9:43 PM, Tomasz Duszynski wrote: > Add support for ROHM BH1710/BH1715/BH1721/BH1750/BH1751 ambient light > sensors. > > Signed-off-by: Tomasz Duszynski > --- > drivers/iio/light/Kconfig | 10 ++ > drivers/iio/light/Makefile | 1 + > drivers/iio/light/bh1750.c | 322 >

[RESEND PATCH] configfs: init configfs module earlier at boot time

2015-04-24 Thread Daniel Baluta
We need this earlier in the boot process to allow various subsystems to use configfs (e.g Industrial IIO). Also, debugfs is at core_initcall level and configfs should be on the same level from infrastructure point of view. Suggested-by: Lars-Peter Clausen Signed-off-by: Daniel Baluta Reviewed

[PATCH v2 3/3] iio: magnetometer: Add ACPI support for MMC35240

2015-04-24 Thread Daniel Baluta
We assume that ACPI device tables use MMC35240 to identify MEMSIC's 3 axis magnetic sensor. Signed-off-by: Daniel Baluta --- drivers/iio/magnetometer/mmc35240.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/iio/magnetometer/mmc35240.c b/drivers/iio/magnetometer/mmc35

  1   2   3   4   5   6   7   8   9   10   >