dependency with each other.
If one of these patches cannot be merged, some other patches maybe
cannot be merged properly, I think.
Daeseok Youn (11):
staging: dgnc: remove redundant initialization for channel_t
staging: dgnc: remove useless message buffer
staging: dgnc: missing NULL check for
The channel array in board_t was initialized in dgnc_found_board()
with NULL. But the channel is going to initialize in dgnc_tty_init().
So the channel array doesn't need to set NULL for initailization.
Signed-off-by: Daeseok Youn
---
drivers/staging/dgnc/dgnc_driver.c | 3 ---
1 file ch
There is a temporary message buffer for the boot message
in dgnc_found_board() but the buffer was not used anywhere in
dgnc driver.
Signed-off-by: Daeseok Youn
---
drivers/staging/dgnc/dgnc_driver.c | 28
drivers/staging/dgnc/dgnc_driver.h | 6 --
2 files
The functions related with tty device initialization are needed
to be moved from dgnc_found_board() to dgnc_init_one().
Signed-off-by: Daeseok Youn
---
drivers/staging/dgnc/dgnc_driver.c | 81 --
1 file changed, 43 insertions(+), 38 deletions(-)
diff --git a
The board structure should be freed when any function was failed
in dgnc_found_board(). And the board strucure will be stored
into dgnc_board array when the dgnc_found_board() function has no error.
Signed-off-by: Daeseok Youn
---
drivers/staging/dgnc/dgnc_driver.c | 17 +
1
The ioremap() function can be failed, so it need to have error
handling in dgnc_do_remap(). And also the return type of
dgnc_do_remap() should be changed from "void" to "int"
Signed-off-by: Daeseok Youn
---
drivers/staging/dgnc/dgnc_driver.c | 31 +--
dgnc_cleanup_tty() cannot be called with unregistered tty.
Signed-off-by: Daeseok Youn
---
drivers/staging/dgnc/dgnc_driver.h | 3 --
drivers/staging/dgnc/dgnc_tty.c| 64 +++---
2 files changed, 25 insertions(+), 42 deletions(-)
diff --git a/drivers/staging/dgnc
The dgnc_tty_uninit() doesn't match with dgnc_tty_init() at all.
And also the dgnc_cleanup_tty() is only called for exiting the module.
Signed-off-by: Daeseok Youn
---
drivers/staging/dgnc/dgnc_driver.c | 2 +-
drivers/staging/dgnc/dgnc_tty.c| 4 ++--
drivers/staging/dgnc/dgnc_tty.h
The dgnc_free_irq() will free the requested IRQ from
the dgnc_request_irq().
Signed-off-by: Daeseok Youn
---
drivers/staging/dgnc/dgnc_driver.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/dgnc/dgnc_driver.c
b/drivers/staging/dgnc
The dgnc_finalize_board_init() function has only job for
requesting the IRQ. It should be renamed to dgnc_request_irq()
Signed-off-by: Daeseok Youn
---
drivers/staging/dgnc/dgnc_driver.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_driver.c
The dgnc_tty_unregister() will be called when
the dgnc_tty_register() is failed.
Signed-off-by: Daeseok Youn
---
drivers/staging/dgnc/dgnc_driver.c | 7 +--
drivers/staging/dgnc/dgnc_tty.c| 8
drivers/staging/dgnc/dgnc_tty.h| 1 +
3 files changed, 14 insertions(+), 2
It was used to get a board structure with dgnc_BoardsByMajor array.
But this driver already has the array for managing initialized board
as dgap_board[]. It can be used for searching the board structure
by major number.
Signed-off-by: Daeseok Youn
---
drivers/staging/dgnc/dgnc_tty.c | 25
2016-06-16 18:23 GMT+09:00 DaeSeok Youn :
> 2016-05-10 15:44 GMT+09:00 Daeseok Youn :
>> The dgnc_block_til_ready() is only used in dgnc_tty_open().
>> The unit data(struct un_t) was stored into tty->driver_data in
>> dgnc_tty_open().
>> And also tty and un w
2016-09-22 16:21 GMT+09:00 Greg KH :
> On Thu, Sep 22, 2016 at 02:22:03PM +0900, Daeseok Youn wrote:
>> The board structure should be freed when any function was failed
>> in dgnc_found_board(). And the board strucure will be stored
>> into dgnc_board array when the dgnc_found
The channel array in board_t was initialized in dgnc_found_board()
with NULL. But the channel is going to initialize in dgnc_tty_init()
again. So the channel array doesn't need to set NULL
for initailization in dgnc_found_board().
Signed-off-by: Daeseok Youn
---
V2: The subject line was cu
The ioremap() function can be failed, so it need to have error
handling in dgnc_do_remap(). And also the return type of
dgnc_do_remap() should be changed from "void" to "int"
Signed-off-by: Daeseok Youn
---
V2: the subject line was cut off, I put it completely.
The board structure should be freed when any function was failed
in dgnc_found_board(). And the board strucure will be stored
into dgnc_board array when the dgnc_found_board() function has no error.
Signed-off-by: Daeseok Youn
---
V2: the subject line was cut off, I put it completely.
drivers
The functions related with tty device initialization are needed
to be moved from dgnc_found_board() to dgnc_init_one().
Signed-off-by: Daeseok Youn
---
V2: the subject line was cut off, I put it completely.
drivers/staging/dgnc/dgnc_driver.c | 81 --
1 file
The dgnc_finalize_board_init() function has only job for
requesting the IRQ. It should be renamed to dgnc_request_irq()
Signed-off-by: Daeseok Youn
---
V2: the subject line was cut off, I put it completely.
drivers/staging/dgnc/dgnc_driver.c | 6 +++---
1 file changed, 3 insertions(+), 3
The dgnc_tty_uninit() doesn't match with dgnc_tty_init() at all.
And also the dgnc_cleanup_tty() is only called for exiting the module.
Signed-off-by: Daeseok Youn
---
V2: the subject line was cut off, I put it completely.
drivers/staging/dgnc/dgnc_driver.c | 2 +-
drivers/staging
2016-09-23 21:15 GMT+09:00 Greg KH :
> On Fri, Sep 23, 2016 at 10:25:02AM +0900, Daeseok Youn wrote:
>> The channel array in board_t was initialized in dgnc_found_board()
>> with NULL. But the channel is going to initialize in dgnc_tty_init()
>> again. So the channel array doe
The channel array in board_t was initialized in dgnc_found_board()
with NULL. But the channel is going to initialize in dgnc_tty_init().
So the channel array doesn't need to set NULL for initailization.
Signed-off-by: Daeseok Youn
---
RESEND: send the whole series again. Because I missed
There is a temporary message buffer for the boot message
in dgnc_found_board() but the buffer was not used anywhere in
dgnc driver.
Signed-off-by: Daeseok Youn
---
RESEND: send the whole series again. Because I missed some patches
when the V2 patches sent.
drivers/staging/dgnc/dgnc_driver.c
The ioremap() function can be failed, so it need to have error
handling in dgnc_do_remap(). And also the return type of
dgnc_do_remap() should be changed from "void" to "int"
Signed-off-by: Daeseok Youn
---
RESEND: send the whole series again. Because I missed some patches
The board structure should be freed when any function was failed
in dgnc_found_board(). And the board strucure will be stored
into dgnc_board array when the dgnc_found_board() function has no error.
Signed-off-by: Daeseok Youn
---
RESEND: send the whole series again. Because I missed some
The functions related with tty device initialization are needed
to be moved from dgnc_found_board() to dgnc_init_one().
Signed-off-by: Daeseok Youn
---
RESEND: send the whole series again. Because I missed some patches
when the V2 patches sent.
V2: The subject line was cut off, I put it
The dgnc_tty_unregister() will be called when
the dgnc_tty_register() is failed.
Signed-off-by: Daeseok Youn
---
RESEND: send the whole series again. Because I missed some patches
when the V2 patches sent.
drivers/staging/dgnc/dgnc_driver.c | 7 +--
drivers/staging/dgnc/dgnc_tty.c| 8
The dgnc_finalize_board_init() function has only job for
requesting the IRQ. It should be renamed to dgnc_request_irq()
Signed-off-by: Daeseok Youn
---
RESEND: send the whole series again. Because I missed some patches
when the V2 patches sent.
V2: The subject line was cut off, I put it
The dgnc_free_irq() will free the requested IRQ from
the dgnc_request_irq().
Signed-off-by: Daeseok Youn
---
RESEND: send the whole series again. Because I missed some patches
when the V2 patches sent.
drivers/staging/dgnc/dgnc_driver.c | 11 ++-
1 file changed, 10 insertions(+), 1
The dgnc_tty_uninit() doesn't match with dgnc_tty_init() at all.
And also the dgnc_cleanup_tty() is only called for exiting the module.
Signed-off-by: Daeseok Youn
---
RESEND: send the whole series again. Because I missed some patches
when the V2 patches sent.
V2: The subject line was cu
dgnc_cleanup_tty() cannot be called with unregistered tty.
Signed-off-by: Daeseok Youn
---
RESEND: send the whole series again. Because I missed some patches
when the V2 patches sent.
drivers/staging/dgnc/dgnc_driver.h | 3 --
drivers/staging/dgnc/dgnc_tty.c| 64
It was used to get a board structure with dgnc_BoardsByMajor array.
But this driver already has the array for managing initialized board
as dgap_board[]. It can be used for searching the board structure
by major number.
Signed-off-by: Daeseok Youn
---
RESEND: send the whole series again. Because
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c | 30 +++---
1 files changed, 15 insertions(+), 15 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index bdb5317..518ab56 100644
--- a/drivers/staging/dgap/dgap.c
+++ b
cppcheck warning:
(warnning) Logical disjunction always evaluates to true
Reported-by: David Binderman
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap
Signed-off-by: Daeseok Youn
---
drivers/scsi/aic7xxx/aic7xxx_core.c |9 +++--
1 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/scsi/aic7xxx/aic7xxx_core.c
b/drivers/scsi/aic7xxx/aic7xxx_core.c
index 10172a3..7f34d25 100644
--- a/drivers/scsi/aic7xxx/aic7xxx_core.c
Signed-off-by: Daeseok Youn
---
drivers/scsi/aic7xxx/aic79xx_core.c |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/aic7xxx/aic79xx_core.c
b/drivers/scsi/aic7xxx/aic79xx_core.c
index 97f2acc..109e2c9 100644
--- a/drivers/scsi/aic7xxx/aic79xx_core.c
+++ b
Signed-off-by: Daeseok Youn
---
drivers/scsi/aic7xxx/aic7xxx_osm.c |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/aic7xxx/aic7xxx_osm.c
b/drivers/scsi/aic7xxx/aic7xxx_osm.c
index 8836011..a2f2c77 100644
--- a/drivers/scsi/aic7xxx/aic7xxx_osm.c
+++ b
It also need to call iounmap() when it fails to get res_start and
res_len from pci_resource_start{len}(pdev, bar).
Signed-off-by: Daeseok Youn
---
drivers/scsi/mvsas/mv_init.c | 10 +-
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/scsi/mvsas/mv_init.c b
2015-03-19 15:24 GMT+09:00 Joseph Qi :
> Looks good to me.
>
> On 2015/2/28 7:48, Daeseok Youn wrote:
>> The use of 'status' in __ocfs2_add_entry() can return wrong
>> status when some functions are failed.
>>
>> If ocfs2_journal_access_db() in __ocf
OK.
If i want to clean up mlog() call twice, mlog() in " bail" can be
removed, right?
Thanks.
Regards,
Daeseok Youn
2015-03-19 19:45 GMT+09:00 Joseph Qi :
> On 2015/2/28 7:49, Daeseok Youn wrote:
>> Signed-off-by: Daeseok Youn
>> ---
>> RESEND: this patch is
OK.
I will send this patch again.
This patch will be based on https://lkml.org/lkml/2015/2/27/655
thanks
regards,
Daeseok Youn
2015-03-19 20:00 GMT+09:00 Joseph Qi :
> On 2015/2/28 7:51, Daeseok Youn wrote:
>> There is no error handle when ocfs2_journal_access_di() is failed.
>&
Hi, Joseph.
2015-04-23 9:49 GMT+09:00 Joseph Qi :
> On 2015/4/19 13:43, Daeseok Youn wrote:
>> The use of 'status' in __ocfs2_add_entry() can return wrong
>> value. Some functions' return value in __ocfs2_add_entry(),
>> i.e ocfs2_journal_access_di() is saved
Hi, Andrew.
Is there problem this patch to merge?
If you care about mlog_errno() cleanup, I will send another patch for that.
And also if you have any reasons this patch has not been taken,
please let me know. I will fix and test again.
Thanks.
regards,
Daeseok Youn/
2015-04-23 9:49 GMT+09:00
add_entry().
So use retval instead of status.
Reviewed-by: Joseph Qi
Signed-off-by: Daeseok Youn
---
RESEND: missed my patch in ocfs2-devel mailing list so send it again
And also add 'Reviewed-by' line.
Previous sent message of my patch
This patch was came from 'https://lkml.org/lkml/20
Hi, Andrew.
2015-04-24 10:45 GMT+09:00 Daeseok Youn :
> The use of 'status' in __ocfs2_add_entry() can return wrong
> value. Some functions' return value in __ocfs2_add_entry(),
> i.e ocfs2_journal_access_di() is saved to 'status'.
> But 'status' i
add_entry().
So use retval instead of status.
Signed-off-by: Daeseok Youn
---
This patch was came from 'https://lkml.org/lkml/2015/2/27/655'
This patch was needed to test but I didn't have any environment
for testing ocfs2 filesystem. But I have one, now.
(I'm too busy to make this
of freed pages.
Signed-off-by: Daeseok Youn
---
include/linux/memblock.h | 2 +-
mm/memblock.c| 6 +-
2 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/include/linux/memblock.h b/include/linux/memblock.h
index 9c5cc95c7cee..076fda398dff 100644
--- a/include/linux
>From 5e737e8211cd1f83488e484c088befc5feb755a9 Mon Sep 17 00:00:00 2001
From: Daeseok Youn
Date: Mon, 24 Feb 2014 09:17:41 +0900
Subject: [PATCH] staging: ced401: remove redundant spin_unlock
sparse says:
drivers/staging/ced1401/usb1401.c:1080:28: warning:
context imbalance in 'Handl
2014-02-24 17:06 GMT+09:00 Dan Carpenter :
> On Mon, Feb 24, 2014 at 09:51:35AM +0900, Daeseok Youn wrote:
>> >From 5e737e8211cd1f83488e484c088befc5feb755a9 Mon Sep 17 00:00:00 2001
>> From: Daeseok Youn
>> Date: Mon, 24 Feb 2014 09:17:41 +0900
>> Subject: [
rning:
context imbalance in 'Handle1401Esc' - unexpected unlock
Signed-off-by: Daeseok Youn
---
drivers/staging/ced1401/usb1401.c |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/ced1401/usb1401.c
b/drivers/staging/ced1401/usb1401.c
index efc310c..8195eb9 100644
--- a/
Signed-off-by: Daeseok Youn
---
fs/dcache.c |7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/fs/dcache.c b/fs/dcache.c
index 265e0ce..f360620 100644
--- a/fs/dcache.c
+++ b/fs/dcache.c
@@ -3345,10 +3345,9 @@ EXPORT_SYMBOL(d_tmpfile);
static __initdata unsigned long
Ok.
I will make a patch based on linux-next branch and send it again.
Thanks.
Daeseok Youn
2014-02-25 9:43 GMT+09:00 Greg KH :
> On Mon, Feb 24, 2014 at 07:23:15PM +0900, Daeseok Youn wrote:
>>
>> After spin_lock() is called, all of if-else conditions in this brace
>> sh
rning:
context imbalance in 'Handle1401Esc' - unexpected unlock
Reviewed-by: Dan Carpenter
Signed-off-by: Daeseok Youn
---
drivers/staging/ced1401/usb1401.c |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/ced1401/usb1401.c
b/drivers/staging/ced1401/usb1401.c
index f
These functions are only referenced in this file scope
so it can be marked static.
And remove space between function name and open parenthesis.
Signed-off-by: Daeseok Youn
---
.../staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c| 94 ++--
1 file changed, 47 insertions(+), 47
Actually , I saw some code like this file which is seperate line
between return value and function name.
So I didn't make one line of them.
Ok, I will make another patch after merge this one.
Thanks.
Daeseok Youn.
2014-02-26 18:20 GMT+09:00, Dan Carpenter :
> On Wed, Feb 26, 2014 at 06
Oh.. sorry.
Ok, I will seperate this patch as you said.
Thanks.
Daeseok Youn.
2014-02-26 20:31 GMT+09:00, Dan Carpenter :
> On Wed, Feb 26, 2014 at 08:11:40PM +0900, DaeSeok Youn wrote:
>> Actually , I saw some code like this file which is seperate line
>> between return value an
Signed-off-by: Daeseok Youn
---
drivers/staging/unisys/uislib/uislib.c |5 +
drivers/staging/unisys/uislib/uisutils.c |2 +-
2 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/unisys/uislib/uislib.c
b/drivers/staging/unisys/uislib/uislib.c
index
The banner array doens't need to set to 0.
sprintf() adds a terminating '\0'.
And the sn array can be declared and initialized to zero.
So remove redundant memset() with zero.
Remove unnecessary cast for memcpy().
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/h
clean up checkpatch.pl warnings in linux.c:
WARNING: space prohibited between function name
and open parenthesis '('
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/linux.c | 524
1 files changed, 262 insertions(+), 262 deletion
clean up checkpatch.pl warnings:
WARNING: please no spaces at the start of a line in
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/linux.c | 1478
1 files changed, 743 insertions(+), 735 deletions(-)
diff --git a/drivers/staging/cxt1e1
clean up checkpatch.pl warnings:
WARNING: Line length over 80 characters
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/linux.c | 48 +--
1 files changed, 31 insertions(+), 17 deletions(-)
diff --git a/drivers/staging/cxt1e1/linux.c b/drivers
checkpatch.pl error in linux.c:
ERROR: do not use assignment in if condition
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/linux.c | 28 +---
1 files changed, 17 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/cxt1e1/linux.c b/drivers/staging
clean up checkpatch.pl error in linux.c:
ERROR: that open brace { should be on the previous line
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/linux.c | 67 ---
1 files changed, 21 insertions(+), 46 deletions(-)
diff --git a/drivers/staging
The mkret() change a value of error from positive to
negative. This patch is modified to return negative value
when it failed. It doesn't need to call with function
for changing from positive to negative.
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/linux.c |
It doesn't need to assign name array address to np pointer.
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/linux.c |5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/cxt1e1/linux.c b/drivers/staging/cxt1e1/linux.c
index 599a5ef..390b1f5 1
.
just my opinion.
Regards.
Daeseok Youn.
2014-03-04 12:24 GMT+09:00 Joe Perches :
> On Tue, 2014-03-04 at 11:08 +0900, Daeseok Youn wrote:
>> clean up checkpatch.pl warnings:
>> WARNING: Line length over 80 characters
>
> Please run your patches through checkpatch.
>
clean up checkpatch.pl warnings:
WARNING: Line length over 80 characters
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/hwprobe.c | 45 --
1 file changed, 28 insertions(+), 17 deletions(-)
diff --git a/drivers/staging/cxt1e1/hwprobe.c b/drivers
Thanks for review.
Ok. I Will fix later.
Daeseok Youn
2014-03-04 17:45 GMT+09:00, Dan Carpenter :
> On Tue, Mar 04, 2014 at 11:08:46AM +0900, Daeseok Youn wrote:
>>
>> clean up checkpatch.pl warnings:
>> WARNING: Line length over 80 characters
>>
>
Yes, it need to add brace in inner loop.
I will send again.
Thanks for review.
Daeseok Youn
2014-03-04 18:04 GMT+09:00, Dan Carpenter :
> On Tue, Mar 04, 2014 at 11:09:39AM +0900, Daeseok Youn wrote:
>> @@ -1174,7 +1179,8 @@ cleanup_hdlc(void)
>> ci = (ci_t *)
checkpatch.pl error in linux.c:
ERROR: do not use assignment in if condition
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/linux.c | 31 +++
1 files changed, 19 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/cxt1e1/linux.c b/drivers/staging
clean up checkpatch.pl error in linux.c:
ERROR: that open brace { should be on the previous line
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/linux.c | 67 ---
1 files changed, 21 insertions(+), 46 deletions(-)
diff --git a/drivers/staging
-next branch from mailing list.
Please check.
Thanks.
Daeseok Youn.
2014-03-05 9:35 GMT+09:00 Greg KH :
> On Tue, Mar 04, 2014 at 11:10:44AM +0900, Daeseok Youn wrote:
>>
>> clean up checkpatch.pl error in linux.c:
>> ERROR: that open brace { should be on the previous lin
OK.
I send patches again.
Thanks.
Daeseok Youn.
2014-03-05 10:06 GMT+09:00 Greg KH :
> On Wed, Mar 05, 2014 at 09:55:14AM +0900, DaeSeok Youn wrote:
>> Hi, greg
>>
>> I already resend patch 4 and 5. :-)
>>
>> It had a bug which is noticed by Dan.
>>
>&
checkpatch.pl error in linux.c:
ERROR: do not use assignment in if condition
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/linux.c | 31 +++
1 files changed, 19 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/cxt1e1/linux.c b/drivers/staging
clean up checkpatch.pl error in linux.c:
ERROR: that open brace { should be on the previous line
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/linux.c | 67 ---
1 files changed, 21 insertions(+), 46 deletions(-)
diff --git a/drivers/staging
The mkret() change a value of error from positive to
negative. This patch is modified to return negative value
when it failed. It doesn't need to call with function
for changing from positive to negative.
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/linux.c |
It doesn't need to assign name array address to np pointer.
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/linux.c |5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/cxt1e1/linux.c b/drivers/staging/cxt1e1/linux.c
index 5bb42ae..cae8c66 1
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/sbecom_inline_linux.h |6 ++
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/cxt1e1/sbecom_inline_linux.h
b/drivers/staging/cxt1e1/sbecom_inline_linux.h
index ba3ff3e..6dd1b55 100644
--- a/drivers
coccinelle warning:
drivers/staging/dgap/dgap.c:782:3-7: WARNING:
casting value returned by k[cmz]alloc to (char *) is useless.
drivers/staging/dgap/dgap.c:776:2-16: WARNING:
casting value returned by k[cmz]alloc to (struct board_t *) is useless.
Signed-off-by: Daeseok Youn
---
drivers
Thanks for review.
OK. I will try to change all of OS_kmalloc to kmalloc/kzalloc.
And I also check GFP_DMA flag in kmalloc/kzalloc.
Regards,
Daeseok Youn
2014-03-05 19:04 GMT+09:00 Tobias Klauser :
> On 2014-03-05 at 03:37:15 +0100, Daeseok Youn wrote:
>>
>> Signed-off-b
2014-03-05 19:13 GMT+09:00 Tobias Klauser :
> On 2014-03-05 at 02:24:22 +0100, Daeseok Youn wrote:
>>
>> It doesn't need to assign name array address to np pointer.
>>
>> Signed-off-by: Daeseok Youn
>> ---
>> drivers/staging/cxt1e1/linux.c |5 +
Ok.
I will use sizeof(name) for snprintf() call.
Thanks.
Daeseok Youn.
2014-03-06 16:33 GMT+09:00 Tobias Klauser :
> On 2014-03-06 at 08:19:19 +0100, DaeSeok Youn wrote:
>> 2014-03-05 19:13 GMT+09:00 Tobias Klauser :
>> > On 2014-03-05 at 02:24:22 +0100, Daeseok
It doesn't need to assign name array address to np pointer.
Signed-off-by: Daeseok Youn
---
v2: replace sprintf() with snprintf() and remove memset() call
because snprintf() adds a terminating '\0'
drivers/staging/cxt1e1/linux.c |8 +++-
1 files changed, 3 insertions(
rebase current staging-next branch.
Thanks.
Daeseok Youn.
2014-03-07 4:57 GMT+09:00 Greg KH :
> On Wed, Mar 05, 2014 at 10:21:01AM +0900, Daeseok Youn wrote:
>>
>> checkpatch.pl error in linux.c:
>> ERROR: do not use assignment in if condition
>>
>
Ok.
I will fix it and send again.
Thanks.
Daeseok Youn
2014-03-07 4:58 GMT+09:00 Greg KH :
> On Thu, Mar 06, 2014 at 05:12:48PM +0900, Daeseok Youn wrote:
>>
>> It doesn't need to assign name array address to np pointer.
>>
>> Signed-off-by: Daeseok Youn
>
checkpatch.pl error in linux.c:
ERROR: do not use assignment in if condition
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/linux.c | 31 +++
1 files changed, 19 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/cxt1e1/linux.c b/drivers/staging
clean up checkpatch.pl error in linux.c:
ERROR: that open brace { should be on the previous line
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/linux.c | 67 ---
1 files changed, 21 insertions(+), 46 deletions(-)
diff --git a/drivers/staging
The mkret() change a value of error from positive to
negative. This patch is modified to return negative value
when it failed. It doesn't need to call with function
for changing from positive to negative.
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/linux.c |
The name array doens't need to set to 0. Because
sprintf/snprintf adds a terminating '\0'.
And also it doesn't need to assign name array
address to np pointer.
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/linux.c |8 +++-
1 files changed, 3 insert
These functions are only referenced in this file scope
so it can be marked static.
And remove space between function name and open parenthesis.
Signed-off-by: Daeseok Youn
---
.../staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c| 70 ++--
1 file changed, 35 insertions(+), 35
bClassificationSucceed is initialized with "false",
do not need to set "false" again.
Signed-off-by: Daeseok Youn
---
drivers/staging/bcm/Qos.c |3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/bcm/Qos.c b/drivers/staging/bcm/Qos.c
index 0727599..
clean up checkpatch errors and bClassificationSucceed is set to "TRUE"
proper location.
If protocal is not TCP or UDP, when it checks protocal, bClassificationSucceed
must be set to TRUE.
Also the end of do-while(0) loop, bClassificationSucceed is set to TRUE.
Signed-off-by: Da
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/hwprobe.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/cxt1e1/hwprobe.c b/drivers/staging/cxt1e1/hwprobe.c
index 02b4f8f..07de83f 100644
--- a/drivers/staging/cxt1e1/hwprobe.c
+++ b/drivers
clean up checkpatch.pl warnings:
WARNING: space prohibited between function name
and open parenthesis '('
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/hwprobe.c | 120 +++---
1 file changed, 60 insertions(+), 60 deletions(-)
diff --git
clean up checkpatch.pl warnings:
WARNING: please no spaces at the start of a line in
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/hwprobe.c | 585 +++---
1 file changed, 293 insertions(+), 292 deletions(-)
diff --git a/drivers/staging/cxt1e1
clean up checkpatch.pl warnings:
WARNING: Line length over 80 characters
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/hwprobe.c | 45
--
1 file changed, 28 insertions(+), 17 deletions(-)
diff --git a/drivers/staging/cxt1e1/hwprobe.c
b/drivers
checkpatch.pl error:
ERROR: do not use assignment in if condition
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/hwprobe.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/cxt1e1/hwprobe.c b/drivers/staging/cxt1e1/hwprobe.c
index
clean up checkpatch.pl error:
ERROR: that open brace { should be on the previous line
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/hwprobe.c | 62 +++---
1 file changed, 25 insertions(+), 37 deletions(-)
diff --git a/drivers/staging/cxt1e1
OK. sorry.
I will send again.
Thanks.
Daeseok Youn
2014-02-28 16:28 GMT+09:00 Dan Carpenter :
> On Fri, Feb 28, 2014 at 04:12:22PM +0900, Daeseok Youn wrote:
>>
>> clean up checkpatch.pl warnings:
>> WARNING: Line length over 80 characters
>>
>
> Patch is white
clean up checkpatch.pl warnings:
WARNING: Line length over 80 characters
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/hwprobe.c | 45 --
1 file changed, 28 insertions(+), 17 deletions(-)
diff --git a/drivers/staging/cxt1e1/hwprobe.c b/drivers
1 - 100 of 560 matches
Mail list logo
