Re: [PATCH] driver-core : get_device before create/remove sysfs files

2008-01-31 Thread Cornelia Huck
On Thu, 31 Jan 2008 09:17:18 +0800, "Dave Young" <[EMAIL PROTECTED]> wrote: > On Jan 30, 2008 6:32 PM, Cornelia Huck <[EMAIL PROTECTED]> wrote: > > On Wed, 30 Jan 2008 09:56:25 +0800, > > Dave Young <[EMAIL PROTECTED]> wrote: > > > > > ge

Re: crypto/async_tx/* doesn't build on s390

2008-01-31 Thread Cornelia Huck
On Thu, 31 Jan 2008 15:50:58 +0100, Heiko Carstens <[EMAIL PROTECTED]> wrote: > I get the following: > > crypto/built-in.o: In function `do_async_xor': > async_xor.c:49: undefined reference to `dma_map_page' > async_xor.c:56: undefined reference to `dma_map_page' > > This is mainly because s390

Re: crypto/async_tx/* doesn't build on s390

2008-02-01 Thread Cornelia Huck
On Thu, 31 Jan 2008 12:49:00 -0700, "Williams, Dan J" <[EMAIL PROTECTED]> wrote: > I am mistaken, the 'depends on ARCH...' precludes HAS_DMA. Perhaps the > compiler is emitting a call to async_tx_find_channel when it needs to be > inline? On x86 do_async_xor is successfully compiled away when

Re: crypto/async_tx/* doesn't build on s390

2008-02-04 Thread Cornelia Huck
On Sun, 3 Feb 2008 07:10:50 -0700, "Dan Williams" <[EMAIL PROTECTED]> wrote: > On Feb 3, 2008 4:40 AM, Heiko Carstens <[EMAIL PROTECTED]> wrote: > > On Fri, Feb 01, 2008 at 02:31:28PM -0700, Dan Williams wrote: > [..] > > The fix works for me. Thanks! However your mailer replaced tabs with spaces

Re: [PATCH 026/193] arch/s390/kvm: remove CONFIG_EXPERIMENTAL

2012-10-24 Thread Cornelia Huck
ian Borntraeger > CC: Cornelia Huck > CC: Martin Schwidefsky > CC: Heiko Carstens > Signed-off-by: Kees Cook Acked-by: Cornelia Huck > --- > arch/s390/kvm/Kconfig |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/s390/kvm/Kconfig b/arch/

Re: Proposal for virtio standardization.

2012-10-09 Thread Cornelia Huck
On Thu, 27 Sep 2012 09:59:33 +0930 Rusty Russell wrote: > Hi all, > > I've had several requests for a more formal approach to the > virtio draft spec, and (after some soul-searching) I'd like to try that. > > The proposal is to use OASIS as the standards body, as it's > fairly light

[PATCH] virtio: Don't access index after unregister.

2012-11-08 Thread Cornelia Huck
the index we want to release before calling device_unregister(). Signed-off-by: Cornelia Huck --- drivers/virtio/virtio.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/virtio/virtio.c b/drivers/virtio/virtio.c index 1e8659c..809b0de 100644 --- a/drivers/virtio/vi

Re: [PATCH] KVM: introduce __kvm_io_bus_sort_cmp

2013-07-31 Thread Cornelia Huck
t throughout kvm_main.c. > > Signed-off-by: Paolo Bonzini > --- > virt/kvm/kvm_main.c | 21 - > 1 file changed, 12 insertions(+), 9 deletions(-) > Acked-by: Cornelia Huck -- To unsubscribe from this list: send the line "unsubscribe linux-kernel&

[Patch] Driver core: Fix error handling in bus_add_driver().

2008-02-18 Thread Cornelia Huck
- If the allocation of ->priv fails, the reference on the bus must be dropped. - If adding the kobject fails, kobject_put must be called to clean things up. Signed-off-by: Cornelia Huck <[EMAIL PROTECTED]> --- drivers/base/bus.c |9 + 1 files changed, 5 inserti

Re: [PATCH 0/3] virtio-net: inline header support

2012-10-12 Thread Cornelia Huck
On Fri, 12 Oct 2012 09:07:46 +1030 Rusty Russell wrote: > "Michael S. Tsirkin" writes: > > On Thu, Oct 11, 2012 at 10:33:31AM +1030, Rusty Russell wrote: > >> OK. Well, Anthony wants qemu to be robust in this regard, so I am > >> tempted to rework all the qemu drivers to handle arbitrary layout

Re: [PATCH] s390: kvm/sigp.c: fix memory leakage

2013-01-15 Thread Cornelia Huck
On Mon, 14 Jan 2013 22:39:54 +0100 Cong Ding wrote: > the variable inti should be freed in the branch CPUSTAT_STOPPED. > > Signed-off-by: Cong Ding > --- > arch/s390/kvm/sigp.c |4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/arch/s390/kvm/sigp.c b/arch/s390/kvm/

Re: [RFC] sample kset/ktype/kobject implementation code

2008-01-03 Thread Cornelia Huck
On Wed, 19 Dec 2007 16:31:35 -0800, Greg KH <[EMAIL PROTECTED]> wrote: > /* >* Initialize and add the kobject to the kernel. All the default files >* will be created here. As we have already specified a kset for this >* kobject, we don't have to set a parent for the

Re: [Bluez-devel] Oops involving RFCOMM and sysfs

2008-01-09 Thread Cornelia Huck
On Wed, 09 Jan 2008 18:16:02 +0900, Tejun Heo <[EMAIL PROTECTED]> wrote: > This isn't supported. sysfs doesn't allow parents to die first and the > dangling children to be salvaged using sysfs_move(). But (with the sysfs bugs fixed) it will return an error, won't it? It seems the bluetooth code

Re: [PATCH 0/7] convert semaphore to mutex in struct class

2008-01-10 Thread Cornelia Huck
On Thu, 10 Jan 2008 17:48:43 +0800, Dave Young <[EMAIL PROTECTED]> wrote: Please add a kerneldoc comment for each of the new interfaces. > +int class_for_each_device(struct class *class, void *data, > +int (*fn)(struct device *, void *)) > +{ > + struct device *dev; >

Re: [Bluez-devel] Oops involving RFCOMM and sysfs

2008-01-18 Thread Cornelia Huck
On Fri, 18 Jan 2008 10:19:33 +0100, Cornelia Huck <[EMAIL PROTECTED]> wrote: > > > > 1314 if (IS_ERR(new_parent_kobj)) { > > 1315 error = PTR_ERR(new_parent_kobj); > > 1316 put_device(new_parent); > > 131

Re: [Bluez-devel] Oops involving RFCOMM and sysfs

2008-01-18 Thread Cornelia Huck
On Fri, 18 Jan 2008 18:34:55 +0800, "Dave Young" <[EMAIL PROTECTED]> wrote: > On Jan 18, 2008 6:23 PM, Cornelia Huck <[EMAIL PROTECTED]> wrote: > > On Fri, 18 Jan 2008 10:19:33 +0100, > > Cornelia Huck <[EMAIL PROTECTED]> wrote: > > > &

[Patch] Driver core: Cleanup get_device_parent() in device_add() and device_move().

2008-01-21 Thread Cornelia Huck
efcounting problem reported in http://marc.info/?l=linux-kernel&m=120052487909200&w=2 Signed-off-by: Cornelia Huck <[EMAIL PROTECTED]> --- drivers/base/core.c | 29 ++--- 1 files changed, 14 insertions(+), 15 deletions(-) --- linux-2.6.orig/drivers/base/core

Re: [PATCH 1/6] driver-core : add class iteration api

2008-01-22 Thread Cornelia Huck
as david brownell's sugestion. > Is it right for me add Cornelia Huck's ack after this change? Fine with me. > --- > > Add the following class iteration functions for driver use: > class_for_each_device > class_find_device > class_for_each_child > class_f

Re: [PATCHSET 3/4] sysfs: divorce sysfs from kobject and driver model

2007-10-09 Thread Cornelia Huck
On Fri, 05 Oct 2007 17:00:48 +0900, Tejun Heo <[EMAIL PROTECTED]> wrote: > I think this definitely needs more discussion, so here we go... I agree, so I'll give my 0.02 € here... > > Greg KH wrote: > >> 1. What is a kobject? > [--snip--] > >> The functionality served by kobject can be broken dow

Re: [PATCHSET 3/4] sysfs: divorce sysfs from kobject and driver model

2007-10-10 Thread Cornelia Huck
On Tue, 9 Oct 2007 15:26:38 -0700, Greg KH <[EMAIL PROTECTED]> wrote: > > - relaying implementation details to userspace so that they cannot be > > easily changed. We would need to allow kobjects not showing up in sysfs > > and making symlinks a sysfs facility not relying on kobjects to help > > t

Re: [PATCHSET 3/4] sysfs: divorce sysfs from kobject and driver model

2007-10-10 Thread Cornelia Huck
On Tue, 9 Oct 2007 16:28:04 -0700, Greg KH <[EMAIL PROTECTED]> wrote: > On Tue, Oct 09, 2007 at 04:20:39PM -0700, Roland Dreier wrote: > > > > - relaying implementation details to userspace so that they cannot be > > > > easily changed. We would need to allow kobjects not showing up in sysfs > >

Re: [PATCHSET 3/4] sysfs: divorce sysfs from kobject and driver model

2007-10-10 Thread Cornelia Huck
On Wed, 10 Oct 2007 11:38:50 -0400 (EDT), Alan Stern <[EMAIL PROTECTED]> wrote: > On Tue, 9 Oct 2007, Greg KH wrote: > > > The rules for sysfs files are the following: > > - one value, in text format, per file. > > - no action apon open/close > > - binary files are only allowed for "p

Re: about probing a device

2007-10-10 Thread Cornelia Huck
On Wed, 10 Oct 2007 23:50:01 +0800, wit <[EMAIL PROTECTED]> wrote: > > The first one which matches and successfully attaches "wins". > > Seems that calling the bind routine can bind a driver to a device. Is > there any bad side effect of doing such thing? If the device is already bound to anothe

Re: [RFC] New kobject/kset/ktype documentation and example code

2007-11-28 Thread Cornelia Huck
On Wed, 28 Nov 2007 13:35:54 +0100, Kay Sievers <[EMAIL PROTECTED]> wrote: > On Wed, 2007-11-28 at 10:01 +0100, Cornelia Huck wrote: > > On Tue, 27 Nov 2007 15:02:52 -0800, Greg KH <[EMAIL PROTECTED]> wrote: > > > > Among other things, kobject_init() sets

Re: [RFC] New kobject/kset/ktype documentation and example code

2007-11-28 Thread Cornelia Huck
On Wed, 28 Nov 2007 13:23:02 +0100, Kay Sievers <[EMAIL PROTECTED]> wrote: > On Wed, 2007-11-28 at 12:45 +0100, Cornelia Huck wrote: > > On Tue, 27 Nov 2007 15:02:52 -0800, Greg KH <[EMAIL PROTECTED]> wrote: > > > > A kset serves these functions: > > >

Re: [RFC] New kobject/kset/ktype documentation and example code

2007-11-28 Thread Cornelia Huck
On Wed, 28 Nov 2007 17:03:07 +0100, Kay Sievers <[EMAIL PROTECTED]> wrote: > On Wed, 2007-11-28 at 16:52 +0100, Cornelia Huck wrote: > > On Wed, 28 Nov 2007 13:35:54 +0100, > > Kay Sievers <[EMAIL PROTECTED]> wrote: > > > > > On Wed, 2007-11-28 at 10:01

Re: [RFC] New kobject/kset/ktype documentation and example code

2007-11-28 Thread Cornelia Huck
On Wed, 28 Nov 2007 16:57:48 +0100, Kay Sievers <[EMAIL PROTECTED]> wrote: > On Wed, 2007-11-28 at 16:48 +0100, Cornelia Huck wrote: > > On Wed, 28 Nov 2007 13:23:02 +0100, > > Kay Sievers <[EMAIL PROTECTED]> wrote: > > > On Wed, 2007-11-28 at 12:45 +0100, Cor

Re: [RFC] Sample kset/ktype/kobject implementation

2007-11-28 Thread Cornelia Huck
On Tue, 27 Nov 2007 15:04:06 -0800, Greg KH <[EMAIL PROTECTED]> wrote: > static struct foo_obj *create_foo_obj(const char *name) > { > struct foo_obj *foo; > int retval; > > /* allocate the memory for the whole object */ > foo = kzalloc(sizeof(*foo), GFP_KERNEL); > i

Re: [RFC] New kobject/kset/ktype documentation and example code

2007-11-28 Thread Cornelia Huck
On Wed, 28 Nov 2007 17:36:29 +0100, Kay Sievers <[EMAIL PROTECTED]> wrote: > > On Wed, 2007-11-28 at 17:12 +0100, Cornelia Huck wrote: > > On Wed, 28 Nov 2007 16:57:48 +0100, > > Kay Sievers <[EMAIL PROTECTED]> wrote: > > > > > On Wed, 2007-11-28 at

Re: [RFC] New kobject/kset/ktype documentation and example code

2007-11-29 Thread Cornelia Huck
On Thu, 29 Nov 2007 08:50:31 +0100, Kay Sievers <[EMAIL PROTECTED]> wrote: > We have ~20 callers of kobject_(un)register(), convert them to > kobject_init() + kobject_add() + kobject_uevent(), and just delete the > broken kobject_(un)register() functions from the kobject code. I find a bit more c

Re: [RFC] Sample kset/ktype/kobject implementation

2007-11-29 Thread Cornelia Huck
On Wed, 28 Nov 2007 22:11:39 -0800, Greg KH <[EMAIL PROTECTED]> wrote: > > > foo->kobj.kset = example_kset; > > > foo->kobj.ktype = &foo_ktype; > > > > > > /* > > >* Register the kobject with the kernel, all the default files will > > >* be created here and the uevent will be sent o

Re: [RFC] New kobject/kset/ktype documentation and example code

2007-11-29 Thread Cornelia Huck
On Wed, 28 Nov 2007 22:04:58 -0800, Greg KH <[EMAIL PROTECTED]> wrote: > > > The uevent function will be called when the uevent is about to be sent to > > > userspace to allow more environment variables to be added to the uevent. > > > > It may be helpful to mention which uevents are by default c

Re: [PATCH] kobject: make sure kobj->ktype is set before kobject_init

2007-11-29 Thread Cornelia Huck
On Wed, 28 Nov 2007 17:00:57 -0500 (EST), Alan Stern <[EMAIL PROTECTED]> wrote: > On Wed, 28 Nov 2007, Greg KH wrote: > > > On Wed, Nov 28, 2007 at 03:42:00PM -0500, Alan Stern wrote: > > > This patch (as1020) adds a check to kobject_init() to insure that the > > > ktype field is not NULL. This

Re: [RFC] New kobject/kset/ktype documentation and example code

2007-11-29 Thread Cornelia Huck
On Wed, 28 Nov 2007 14:18:18 -0500 (EST), Alan Stern <[EMAIL PROTECTED]> wrote: > On Wed, 28 Nov 2007, Cornelia Huck wrote: > > > We should perhaps add a bit fat warning here: > > > > Note that once you registered your kobject via kobject_add(), you must &g

Re: [PATCH] kobject: make sure kobj->ktype is set before kobject_init

2007-11-29 Thread Cornelia Huck
On Thu, 29 Nov 2007 11:59:06 +0100, Kay Sievers <[EMAIL PROTECTED]> wrote: > On Thu, 2007-11-29 at 11:05 +0100, Cornelia Huck wrote: > > On Wed, 28 Nov 2007 17:00:57 -0500 (EST), > > Alan Stern <[EMAIL PROTECTED]> wrote: > > > On Wed, 28 Nov 2007, Greg KH wrote

Re: [PATCH] kobject: make sure kobj->ktype is set before kobject_init

2007-11-29 Thread Cornelia Huck
On Thu, 29 Nov 2007 17:04:40 +0100, Kay Sievers <[EMAIL PROTECTED]> wrote: > On Thu, 2007-11-29 at 10:54 -0500, Alan Stern wrote: > > On Thu, 29 Nov 2007, Kay Sievers wrote: > > > > > > And if someone calls kobject_put() after kobject_init() to clean up, > > > > their release function will not be

Re: [RFC] New kobject/kset/ktype documentation and example code

2007-11-29 Thread Cornelia Huck
On Thu, 29 Nov 2007 10:47:19 -0500 (EST), Alan Stern <[EMAIL PROTECTED]> wrote: > On Thu, 29 Nov 2007, Cornelia Huck wrote: > > > > The only problem arises when a child's driver retains a reference to > > > the parent kobject. If things are done properly, t

Re: [RFC] New kobject/kset/ktype documentation and example code

2007-11-29 Thread Cornelia Huck
On Thu, 29 Nov 2007 11:55:43 -0500 (EST), Alan Stern <[EMAIL PROTECTED]> wrote: > On Thu, 29 Nov 2007, Cornelia Huck wrote: > > > > Unfortunately kobjects don't have an owner field. In practice this > > > means that it isn't possible to pin the owner o

Re: [PATCH] kobject: make sure kobj->ktype is set before kobject_init

2007-11-30 Thread Cornelia Huck
On Thu, 29 Nov 2007 21:26:40 +0100, Kay Sievers <[EMAIL PROTECTED]> wrote: > On Thu, 2007-11-29 at 21:20 +0100, Kay Sievers wrote: > > On Thu, 2007-11-29 at 15:09 -0500, Alan Stern wrote: > > > On Thu, 29 Nov 2007, Kay Sievers wrote: > > > > > > There's another good reason for not assigning the n

Re: kobject_init rewrite

2007-11-30 Thread Cornelia Huck
On Thu, 29 Nov 2007 13:54:55 -0800, Greg KH <[EMAIL PROTECTED]> wrote: > One minor documentation update: > > > /** > > * kobject_init - initialize a kobject structure > > * @kobj: pointer to the kobject to initialize > > * @ktype: pointer to the ktype for this kobject. > > * @fmt: the name of

Re: [RFC] kobject: add kobject_init_ng, kobject_add_ng, and kobject_init_and_add functions

2007-12-03 Thread Cornelia Huck
On Fri, 30 Nov 2007 22:29:39 -0500 (EST), Alan Stern <[EMAIL PROTECTED]> wrote: > On Fri, 30 Nov 2007, Greg KH wrote: > > > /** > > + * kobject_init_ng - initialize a kobject structure > > + * @kobj: pointer to the kobject to initialize > > + * @ktype: pointer to the ktype for this kobject. > >

Re: [RFC] kobject: add kobject_init_ng, kobject_add_ng, and kobject_init_and_add functions

2007-12-04 Thread Cornelia Huck
On Mon, 3 Dec 2007 11:06:26 -0800, Greg KH <[EMAIL PROTECTED]> wrote: > On Mon, Dec 03, 2007 at 01:00:03PM +0100, Cornelia Huck wrote: > > On Fri, 30 Nov 2007 22:29:39 -0500 (EST), > > Alan Stern <[EMAIL PROTECTED]> wrote: > > > &g

[patch 3/3] zfcp: Use device_driver default attribute groups.

2007-12-05 Thread Cornelia Huck
CC: Swen Schillig <[EMAIL PROTECTED]> Signed-off-by: Cornelia Huck <[EMAIL PROTECTED]> --- drivers/s390/scsi/zfcp_ccw.c | 14 -- drivers/s390/scsi/zfcp_ext.h |3 +-- drivers/s390/scsi/zfcp_sysfs_driver.c | 27 --- 3 file

[patch 0/3] driver core: Fix s390, get default driver attributes for free.

2007-12-05 Thread Cornelia Huck
Hi Greg, I spent some time fixing up the driver tree on s390 and found that the easiest way to do so is to introduce default attribute groups for device drivers (like for devices). Since I'm lazy, I didn't take care to delay the uevent for device drivers to after adding the attribute groups, but

[patch 1/3] driver core: Introduce default attribute groups.

2007-12-05 Thread Cornelia Huck
This is lot like default attributes for devices (and indeed, a lot of the code is lifted from there). Signed-off-by: Cornelia Huck <[EMAIL PROTECTED]> --- drivers/base/driver.c | 44 +++- include/linux/device.h |2 ++ 2 files changed, 45 inse

[patch 2/3] netiucv: Use device_driver default attribute groups.

2007-12-05 Thread Cornelia Huck
CC: Ursula Braun <[EMAIL PROTECTED]> Signed-off-by: Cornelia Huck <[EMAIL PROTECTED]> --- drivers/s390/net/netiucv.c | 16 ++-- 1 files changed, 6 insertions(+), 10 deletions(-) --- linux-2.6.orig/drivers/s390/net/netiucv.c +++ linux-2.6/drivers/s390/net/netiucv.

Re: [RFC] New kobject/kset/ktype documentation and example code

2007-11-28 Thread Cornelia Huck
On Tue, 27 Nov 2007 15:02:52 -0800, Greg KH <[EMAIL PROTECTED]> wrote: > So, while it is all relativly fresh in my mind, I thought it would be > good to also document the whole mess, and provide some solid example > code for others to use in the future. Cool. > Embedding kobjects > > It is rar

Re: [RFC] New kobject/kset/ktype documentation and example code

2007-11-28 Thread Cornelia Huck
On Tue, 27 Nov 2007 15:02:52 -0800, Greg KH <[EMAIL PROTECTED]> wrote: > > ksets > > A kset is merely a collection of kobjects that want to be associated with > each other. There is no restriction that they be of the same ktype, but be > very careful if they are not. > > A kset serves these fu

Re: [PATCH 0/7] convert semaphore to mutex in struct class

2008-01-11 Thread Cornelia Huck
On Fri, 11 Jan 2008 10:33:16 +0800, "Dave Young" <[EMAIL PROTECTED]> wrote: > > > +struct device *class_find_device(struct class *class, void *data, > > > +int (*match)(struct device *, void *)) > > > +{ > > > + struct device *dev; > > > + > > > + if (!clas

Re: [PATCH 1/7] driver-core : add class iteration api

2008-01-14 Thread Cornelia Huck
On Sat, 12 Jan 2008 17:47:54 +0800, Dave Young <[EMAIL PROTECTED]> wrote: Minor style suggestion (same for class_find_child): > +struct device *class_find_device(struct class *class, void *data, > +int (*match)(struct device *, void *)) > +{ > + struct device *

Re: [Bluez-devel] Oops involving RFCOMM and sysfs

2008-01-14 Thread Cornelia Huck
On Mon, 14 Jan 2008 15:05:19 +0800, "Dave Young" <[EMAIL PROTECTED]> wrote: > On Jan 12, 2008 7:09 AM, Gabor Gombas <[EMAIL PROTECTED]> wrote: > > On Thu, Jan 10, 2008 at 09:11:17AM +0800, Dave Young wrote: > > > > > For bluetooth device_move, the only child device of hci_conn dev is > > > the rfc

Re: [PATCH 1/7] driver-core : add class iteration api

2008-01-15 Thread Cornelia Huck
On Tue, 15 Jan 2008 17:13:22 +0800, Dave Young <[EMAIL PROTECTED]> wrote: > > Add the following class iteration functions for driver use: > class_for_each_device > class_find_device > class_for_each_child > class_find_child > > Signed-off-by: Dave Young <[EMAIL

Re: [PATCH 2.6.24-rc7 2/2] sysfs: fix bugs in sysfs_rename/move_dir()

2008-01-16 Thread Cornelia Huck
On Wed, 16 Jan 2008 15:47:11 +0900, Tejun Heo <[EMAIL PROTECTED]> wrote: > Linus Torvalds wrote: > > > > On Wed, 16 Jan 2008, Tejun Heo wrote: > >> * sysfs_move_dir() has an extra dput() on success path. > > > > Are you sure? How did this ever work? > > I'm pretty sure. I've seen dentry blowin

Re: [Bluez-devel] Oops involving RFCOMM and sysfs

2008-01-17 Thread Cornelia Huck
On Thu, 17 Jan 2008 16:15:04 +0800, Dave Young <[EMAIL PROTECTED]> wrote: > On Thu, Jan 17, 2008 at 03:24:50PM +0800, Dave Young wrote: > > On Jan 17, 2008 7:06 AM, Gabor Gombas <[EMAIL PROTECTED]> wrote: > > > Hi, > > > > > > On Wed, Jan 16, 2008 at 09:02:05AM +0800, Dave Young wrote: > > > > > >

Re: [Bluez-devel] Oops involving RFCOMM and sysfs

2008-01-18 Thread Cornelia Huck
On Fri, 18 Jan 2008 11:37:21 +0800, "Dave Young" <[EMAIL PROTECTED]> wrote: > Lets see the device_move function, seems there's some problems in it: > > 1302 int device_move(struct device *dev, struct device *new_parent) > 1303 { > 1304 int error; > 1305 struct device *old_parent;

Re: [PATCH] driver-core : get_device before create/remove sysfs files

2008-01-30 Thread Cornelia Huck
On Wed, 30 Jan 2008 09:56:25 +0800, Dave Young <[EMAIL PROTECTED]> wrote: > get dev reference before create/remove sysfiles, errno fixes as well. > > Signed-off-by: Dave Young <[EMAIL PROTECTED]> > > --- > drivers/base/core.c | 12 > 1 file changed, 8 insertions(+), 4 deletions(-)

Re: EIP is at device_shutdown+0x32/0x60

2007-11-15 Thread Cornelia Huck
On Thu, 15 Nov 2007 21:55:34 +0900, Yasunori Goto <[EMAIL PROTECTED]> wrote: > /** > * device_shutdown - call ->shutdown() on each device to shutdown. > */ > void device_shutdown(void) > { > struct device * dev, *devn; > > list_for_each_entry_safe_reverse(dev, devn, &devices_kse

Re: [patch 1/6] sclp: sysfs interface for SCLP cpi

2007-11-18 Thread Cornelia Huck
On Fri, 16 Nov 2007 16:08:21 +0100, "Kay Sievers" <[EMAIL PROTECTED]> wrote: > On Nov 16, 2007 3:29 PM, Martin Schwidefsky <[EMAIL PROTECTED]> wrote: > > + > > +static decl_subsys(cpi, NULL, NULL); > > + > > decl_subsys() and all other static kset cruft called "subsys" will be > gone with 2.6.25.

Re: EIP is at device_shutdown+0x32/0x60

2007-11-19 Thread Cornelia Huck
On Thu, 15 Nov 2007 17:22:11 -0800, Greg KH <[EMAIL PROTECTED]> wrote: > On Fri, Nov 16, 2007 at 10:13:42AM +0900, Yasunori Goto wrote: > > > > > > > > Care to try this: > > > > + system_kset = kset_create_and_register("system", NULL, > > > > +

Re: [PATCH] add_partition silently ignored errors

2007-10-29 Thread Cornelia Huck
On Mon, 29 Oct 2007 05:22:11 -0700, Dirk Hohndel <[EMAIL PROTECTED]> wrote: > @@ -390,20 +390,31 @@ void add_partition(struct gendisk *disk, int part, > sector_t start, sector_t len, > p->kobj.parent = &disk->kobj; > p->kobj.ktype = &ktype_part; > kobject_init(&p->kobj); > -

Re: [PATCH] add_partition silently ignored errors

2007-10-29 Thread Cornelia Huck
On Mon, 29 Oct 2007 07:24:27 -0700, Dirk Hohndel <[EMAIL PROTECTED]> wrote: > @@ -390,20 +390,33 @@ void add_partition(struct gendisk *disk, int part, > sector_t start, sector_t len, > p->kobj.parent = &disk->kobj; > p->kobj.ktype = &ktype_part; > kobject_init(&p->kobj); > -

Re: [PATCH] add_partition silently ignored errors

2007-10-29 Thread Cornelia Huck
On Mon, 29 Oct 2007 08:48:49 -0700, Dirk Hohndel <[EMAIL PROTECTED]> wrote: > [PATCH] add_partition silently ignored errors > > Signed-off-by: Dirk Hohndel <[EMAIL PROTECTED]> > > --- > block/ioctl.c |5 - > fs/partitions/check.c | 30 -- > include/

Re: [PATCH] sysfs: add filter function to groups

2007-10-29 Thread Cornelia Huck
On Mon, 29 Oct 2007 11:57:51 -0500, James Bottomley <[EMAIL PROTECTED]> wrote: > On Mon, 2007-10-29 at 17:54 +0100, Kay Sievers wrote: > > On Mon, 2007-10-29 at 10:16 -0500, James Bottomley wrote: > > > This patch is a first pass at adding a filter function to the group > > > attributes, just to s

Re: [PATCH] sysfs: add filter function to groups

2007-10-30 Thread Cornelia Huck
On Mon, 29 Oct 2007 12:24:06 -0500, James Bottomley <[EMAIL PROTECTED]> wrote: > > Can you determine which subset of the attributes you want just before > > actually creating the group? Then you could do something like: > > > > create_group(grp, kobj) > > { > > grp->update_creation_mask(kobj)

Re: [PATCH] sysfs: add filter function to groups

2007-10-30 Thread Cornelia Huck
On Mon, 29 Oct 2007 12:29:27 -0500, James Bottomley <[EMAIL PROTECTED]> wrote: > On Mon, 2007-10-29 at 13:27 -0400, Jeff Garzik wrote: > > James Bottomley wrote: > > > visibility and creation are the same thing, aren't they? An invisible > > > attribute doesn't appear in the sysfs directory, so i

Re: [PATCH] add_partition silently ignored errors

2007-10-30 Thread Cornelia Huck
On Tue, 30 Oct 2007 09:07:42 +0100, Jens Axboe <[EMAIL PROTECTED]> wrote: > On Mon, Oct 29 2007, Dirk Hohndel wrote: > > diff --git a/block/ioctl.c b/block/ioctl.c > > index 52d6385..bb3933e 100644 > > --- a/block/ioctl.c > > +++ b/block/ioctl.c > > @@ -61,7 +61,10 @@ static int blkpg_ioctl(struct

Re: [PATCH] add_partition silently ignored errors

2007-10-30 Thread Cornelia Huck
On Tue, 30 Oct 2007 09:56:08 -0700, Dirk Hohndel <[EMAIL PROTECTED]> wrote: > > > IIRC, Al recently vetoed a similar patch. As far as I'm concerned, with > > > the correct return values, the patch then looks fine to me. > > > > We need some kind of check concerning the kobject to avoid mysterious

Re: [PATCH] sysfs: add filter function to groups

2007-10-31 Thread Cornelia Huck
On Tue, 30 Oct 2007 20:55:06 -0700, Greg KH <[EMAIL PROTECTED]> wrote: > On Tue, Oct 30, 2007 at 01:25:43PM -0500, James Bottomley wrote: > > Index: BUILD-2.6/fs/sysfs/group.c > > === > > --- BUILD-2.6.orig/fs/sysfs/group.c 2007-10-28

Re: [PATCH] add_partition silently ignored errors

2007-10-31 Thread Cornelia Huck
On Tue, 30 Oct 2007 15:56:35 -0700, Dirk Hohndel <[EMAIL PROTECTED]> wrote: > On Tue, Oct 30, 2007 at 06:31:12PM +0100, Cornelia Huck wrote: > > On Tue, 30 Oct 2007 09:56:08 -0700, > > Dirk Hohndel <[EMAIL PROTECTED]> wrote: > > > > > > > IIRC, A

Re: [PATCH] sysfs: add filter function to groups

2007-10-31 Thread Cornelia Huck
On Wed, 31 Oct 2007 10:52:35 +0100, Stefan Richter <[EMAIL PROTECTED]> wrote: > Cornelia Huck wrote: > > Greg KH <[EMAIL PROTECTED]> wrote: > >> On Tue, Oct 30, 2007 at 01:25:43PM -0500, James Bottomley wrote: > >>> + for (i = 0, attr = grp->attrs

Re: [PATCH] sysfs: add filter function to groups

2007-10-31 Thread Cornelia Huck
On Wed, 31 Oct 2007 11:37:36 +0100, Stefan Richter <[EMAIL PROTECTED]> wrote: > > mask_out() would also imply that the common use case is to have all > > attributes in the group created and that you need to take action to > > have an attribute not created. > > Here you have a point. But James ha

Re: 2.6.22-git: known regressions with patches

2007-07-19 Thread Cornelia Huck
Caused-By : ? > Handled-By : Cornelia Huck <[EMAIL PROTECTED]> > Patch : http://lkml.org/lkml/2007/7/19/223 > Status : patch available > Multiple people posted this fix, and Andrew's already made it to git (commit 275afcac9953ece0828972edeab9684cf

Re: Documentation for sysfs, hotplug, and firmware loading.

2007-07-20 Thread Cornelia Huck
On Fri, 20 Jul 2007 00:00:01 -0700, Greg KH <[EMAIL PROTECTED]> wrote: > > I don't insist on it, mknod insists on it. You cannot mknod a dev node > > without specifying block or char. > > > > You're saying that sysfs should provide major and minor numbers without > > anywhere specifying "char"

Re: kobject link failure

2007-07-20 Thread Cornelia Huck
On Fri, 20 Jul 2007 01:00:59 -0700, Greg KH <[EMAIL PROTECTED]> wrote: > --- a/drivers/base/core.c > +++ b/drivers/base/core.c > @@ -250,6 +250,7 @@ static struct kset_uevent_ops device_uev > .uevent = dev_uevent, > }; > > +#ifdef CONFIG_HOTPLUG > static ssize_t show_uevent(struct

Re: kobject link failure

2007-07-20 Thread Cornelia Huck
On Fri, 20 Jul 2007 11:32:21 +0200, Cornelia Huck <[EMAIL PROTECTED]> wrote: > Hm, this would be an interface change (the uevent attribute used to > exist even for !CONFIG_HOTPLUG, it just triggered nothing). How about > moving kobject_actions[] out of the #ifdef (maybe next to &

Re: [bug] pcwd_init_module(): WARNING: at lib/kref.c:33 kref_get()

2007-07-23 Thread Cornelia Huck
On Sun, 22 Jul 2007 20:23:20 +0530, "Satyam Sharma" <[EMAIL PROTECTED]> wrote: > On 7/22/07, Ingo Molnar <[EMAIL PROTECTED]> wrote: > > > > enabling CONFIG_PCWATCHDOG=y crashes bzImage bootup, see below. Tested > > on latest -git. > > > > Ingo > > > > ---> > > Calling initc

Re: Documentation for sysfs, hotplug, and firmware loading.

2007-07-24 Thread Cornelia Huck
On Mon, 23 Jul 2007 19:26:54 -0400, Rob Landley <[EMAIL PROTECTED]> wrote: Sorry, that's way too much for me to bother reading. I'd look at any patches against the existing documentation, though. But I'll stop looking at this thread, there's too much ranting for my taste in there. - To unsubscri

Re: sysfs/udev broken in latest git?

2007-07-24 Thread Cornelia Huck
On Tue, 24 Jul 2007 00:25:40 -0700, Greg KH <[EMAIL PROTECTED]> wrote: > On Tue, Jul 24, 2007 at 07:39:38AM +0100, Simon Arlott wrote: > > The following commit appears to break some of my udev rules (I don't > > have the time to finish the bisect right now, but there's only four > > changes show

Re: sysfs/udev broken in latest git?

2007-07-24 Thread Cornelia Huck
On Tue, 24 Jul 2007 11:20:02 +0200, "Kay Sievers" <[EMAIL PROTECTED]> wrote: > It looks fine to me. "device" links must never point to anything else > than a bus device. Hm, but then 1. The patch sneaks this check in (the old code only checked for dev->parent) 2. The code is rather inconsisten

Re: sysfs/udev broken in 2.6.23-rc1 [input, i2c, ...] (Was: sysfs/udev broken in latest git?)

2007-07-25 Thread Cornelia Huck
nk. Unfortunately, this breaks input, so let's revert to the old behaviour. Signed-off-by: Cornelia Huck <[EMAIL PROTECTED]> --- drivers/base/core.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- linux-2.6.orig/drivers/base/core.c +++ linux-2.6/drivers/base/core.c @

Re: [PATCH] request_firmware: skip timeout if userspace was not notified

2007-08-06 Thread Cornelia Huck
On Fri, 03 Aug 2007 21:07:35 +0200, Javier Pello <[EMAIL PROTECTED]> wrote: > 1. The first part changes kobject_uevent_env in lib/kobject_uevent.c > to report a failure if both netlink_broadcast (if applicable) and > call_usermodehelper fail to send the event to userspace. Nothing in > the kernel

Re: [PATCH] request_firmware: skip timeout if userspace was not notified

2007-08-07 Thread Cornelia Huck
On Mon, 06 Aug 2007 22:23:07 +0200, Javier Pello <[EMAIL PROTECTED]> wrote: > > > 2. The second part changes _request_firmware in > > > drivers/base/firmware_class.c to actually check the return value > > > of kobject_uevent and skip the loading_timeout delay if the > > > loading event was not del

Re: [PATCH] request_firmware: skip timeout if userspace was not notified

2007-08-07 Thread Cornelia Huck
On Tue, 7 Aug 2007 13:46:55 +0200, "Kay Sievers" <[EMAIL PROTECTED]> wrote: > > - Use an extra parameter in which successful delivery can be indicated. > > Make this > > int kobject_uevent_env_check(struct kobject *kobject, > > enum kobject_action action, > >

Re: [PATCH] request_firmware: skip timeout if userspace was not notified

2007-08-07 Thread Cornelia Huck
On Tue, 7 Aug 2007 14:31:34 +0200, "Kay Sievers" <[EMAIL PROTECTED]> wrote: > > > How do you check if events have been "handled"? None of the recent > > > distros uses /sbin/hotplug anymore. Netlink events are broadcasted, > > > but no failure in delivery doesn't mean anything like "handled", or >

Re: [PATCH] request_firmware: skip timeout if userspace was not notified

2007-08-07 Thread Cornelia Huck
On Tue, 07 Aug 2007 14:57:52 +0200, Kay Sievers <[EMAIL PROTECTED]> wrote: > The real fix would be to change the driver not to block in the firmware > request and use async version of firmware loading. I guess some drivers want to fail the probe if they can't get the firmware. This sounds like th

Re: [PATCH] request_firmware: skip timeout if userspace was not notified

2007-08-07 Thread Cornelia Huck
On Tue, 07 Aug 2007 15:59:38 +0200, Javier Pello <[EMAIL PROTECTED]> wrote: > On Tue, 07 Aug 2007, Kay Sievers wrote: > > > If you don't have modules and the initial request fails, how do you > > load the firmware later? > > I trigger a rebinding of the device to the driver in an init file: > #

Re: [PATCH] request_firmware: skip timeout if userspace was not notified

2007-08-07 Thread Cornelia Huck
On Tue, 07 Aug 2007 16:08:25 +0200, Kay Sievers <[EMAIL PROTECTED]> wrote: > Nope, you would just fulfill in a completely generic way all outstanding > requests when you are ready. All requests are all nicely grouped and > visible in sysfs. There would be no need of coding your own device > specif

Re: [PATCH 0/25] Sysfs cleanups & tagged directory support

2007-08-08 Thread Cornelia Huck
On Tue, 07 Aug 2007 15:06:21 -0600, [EMAIL PROTECTED] (Eric W. Biederman) wrote: > > The following patchset applies on top of the last round of > sysfs cleanups that Tejun sent out on the 2nd. > > My target with this patchset is to support sysfs directories > with a tag on struct sysfs_dirent ma

Re: [PATCH 0/25] Sysfs cleanups & tagged directory support

2007-08-08 Thread Cornelia Huck
On Wed, 08 Aug 2007 01:47:51 -0600, [EMAIL PROTECTED] (Eric W. Biederman) wrote: > Cornelia Huck <[EMAIL PROTECTED]> writes: > > > My udev failed to create /dev/dasd* so it cannot mount root :( I'm > > currently trying to find out what causes this, may take some t

Re: [PATCH 0/25] Sysfs cleanups & tagged directory support

2007-08-08 Thread Cornelia Huck
On Wed, 08 Aug 2007 01:57:07 -0600, [EMAIL PROTECTED] (Eric W. Biederman) wrote: > > Got it: It's patch 6, the readdir simplification. > > > > (The udev on that guest is ancient (063)...) > > Ok. That is weird. More weirdness. If I activate another dasd from the repair file system, /dev/dasdb i

Re: [PATCH 0/25] Sysfs cleanups & tagged directory support

2007-08-08 Thread Cornelia Huck
On Wed, 08 Aug 2007 17:54:44 +0900, Tejun Heo <[EMAIL PROTECTED]> wrote: > Are you sure it's patch 6? Patch 17 adds a deadlock in rename path. Yes. If I apply the series up to patch 5, everything's fine. If I apply patch 6, /dev/dasda* is missing. - To unsubscribe from this list: send the line "

Re: Error message from device_rename in drivers/base/core.c

2007-08-08 Thread Cornelia Huck
On Tue, 07 Aug 2007 21:37:24 -0700 (PDT), David Miller <[EMAIL PROTECTED]> wrote: > From: Larry Finger <[EMAIL PROTECTED]> > Date: Tue, 07 Aug 2007 23:17:23 -0500 > > > I am getting the following error message from drivers/base/core.c: > > > > net eth1: device_rename: sysfs_create_symlink failed

Re: [PATCH 0/25] Sysfs cleanups & tagged directory support

2007-08-08 Thread Cornelia Huck
On Wed, 8 Aug 2007 10:37:59 +0200, Cornelia Huck <[EMAIL PROTECTED]> wrote: > On Wed, 08 Aug 2007 01:57:07 -0600, > [EMAIL PROTECTED] (Eric W. Biederman) wrote: > > > > Got it: It's patch 6, the readdir simplification. > > > > > > (The udev on tha

Re: [PATCH 0/25] Sysfs cleanups & tagged directory support

2007-08-08 Thread Cornelia Huck
On Wed, 08 Aug 2007 23:35:36 +0900, Tejun Heo <[EMAIL PROTECTED]> wrote: > Does the attached patch happen to fix the problem? Indeed it does; thanks! - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at htt

Re: [PATCH 0/25] Sysfs cleanups & tagged directory support

2007-08-08 Thread Cornelia Huck
On Wed, 08 Aug 2007 23:55:29 +0900, Tejun Heo <[EMAIL PROTECTED]> wrote: > Yeah, you seem to have 32bit off_t. UINT_MAX overflows, so... Yes, that was an 31 bit guest. (Good thing I tried it there, I usually use 64 bit guests...) - To unsubscribe from this list: send the line "unsubscribe linux

Re: [PATCH 0/25] Sysfs cleanups & tagged directory support

2007-08-08 Thread Cornelia Huck
On Wed, 8 Aug 2007 16:50:27 +0200, Cornelia Huck <[EMAIL PROTECTED]> wrote: > On Wed, 08 Aug 2007 23:35:36 +0900, > Tejun Heo <[EMAIL PROTECTED]> wrote: > > > Does the attached patch happen to fix the problem? > > Indeed it does; thanks! And the whole patchse

Re: [PATCH] request_firmware: skip timeout if userspace was not notified

2007-08-09 Thread Cornelia Huck
On Thu, 09 Aug 2007 11:13:12 +0200, Javier Pello <[EMAIL PROTECTED]> wrote: > On Tue, 07 Aug 2007, Kay Sievers wrote: > > Nope, you would just fulfill in a completely generic way all outstanding > > requests when you are ready. All requests are all nicely grouped and > > visible in sysfs. There wo

Re: 2.6.23-rc2-mm1: hang, prop_norm_single involved

2007-08-09 Thread Cornelia Huck
On Thu, 9 Aug 2007 15:10:44 +0400, Alexey Dobriyan <[EMAIL PROTECTED]> wrote: > LTP run reproducably hangs during rwtest01 test > rwtest -N rwtest01 -c -q -i 60s -f sync 10%25000:rs-sync=$$ > Calltrace is always the same: > > INFO: trying to register non-static key > __lock_acquire+0x210/0x

Re: [PATCH] Fix kobject documentation

2007-07-27 Thread Cornelia Huck
On Fri, 27 Jul 2007 19:27:26 +0900, Satoru Takeuchi <[EMAIL PROTECTED]> wrote: > Fix kobject documentation as follows. > > - remove trailing spaces. > - struct device_subsys -> devices_subsys > > Signed-off-by: Satoru Takeuchi<[EMAIL PROTECTED]> This is certainly a start, but kobject.txt need

Re: [PATCH] Fix kobject documentation

2007-07-27 Thread Cornelia Huck
Update kobject documentation: - Update structure definitions. - Remove documentation of removed struct subsystem. (First shot, uevent_ops probably need some documentation as well.) Signed-off-by: Cornelia Huck <[EMAIL PROTECTED]> --- Documentation/kobject.txt

  1   2   3   4   5   6   7   8   9   10   >