[PATCH v4 3/4] Staging: rtl8188eu/core: Coding style fix, set constant operand on right in tests

2016-02-16 Thread Colin Vidal
Remove a checkpatch warning, putting constant operant on right of two tests. Signed-off-by: Colin Vidal --- drivers/staging/rtl8188eu/core/rtw_iol.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_iol.c b/drivers/staging/rtl8188eu/core

[PATCH v4 1/4] Staging: rtl8188eu/core: remove paragraph which mention FSF address in comment header

2016-02-16 Thread Colin Vidal
As FSF address changed in the past, and can change in the future, remove the address paragraph in the comment header, and avoid a warning of checkpatch. Signed-off-by: Colin Vidal --- drivers/staging/rtl8188eu/core/rtw_iol.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging

[PATCH v4 4/4] Staging: rtl8188eu/core: Coding style fix, avoid line over 80 characters

2016-02-16 Thread Colin Vidal
Jump a new line after and operator of the test. It avoids to exceed 80 chars line, and remove a checkpatch warning. Signed-off-by: Colin Vidal --- drivers/staging/rtl8188eu/core/rtw_iol.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/core

[PATCH v4 2/4] Staging: rtl8188eu/core: Coding style fix, set conform spaces between identifiers

2016-02-16 Thread Colin Vidal
And a space after include keyword, making the preprocessor more readable, and remove an unexpected space between a type and variable name. Signed-off-by: Colin Vidal --- drivers/staging/rtl8188eu/core/rtw_iol.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers

Re: [PATCH v3 5/5] Staging: rtl8188eu/core: make core more readable

2016-02-15 Thread Colin Vidal
On Sun, 2016-02-14 at 16:39 -0800, Greg Kroah-Hartman wrote: > On Fri, Feb 12, 2016 at 07:05:53PM +0100, Colin Vidal wrote: > > Signed-off-by: Colin Vidal > > --- > >  drivers/staging/rtl8188eu/core/rtw_iol.c | 10 +++--- > >  1 file changed, 3 insertions(+), 7 delet

[PATCH] staging/rtl8192u: add endianness conversions

2017-01-26 Thread Colin Vidal
Fields frag_size and playload_size of struct ieee80211_txb are encoded as short little-endian. This patch adds conversions to / from cpu byte order when copy / write these values in variables of architecture independent byte order. It also avoid a sparse type warning. Signed-off-by: Colin Vidal

Re: [kernel-hardening] Re: [RFC v4 PATCH 00/13] HARDENED_ATOMIC

2016-11-10 Thread Colin Vidal
On Fri, 2016-11-11 at 00:57 +0100, Peter Zijlstra wrote: > On Thu, Nov 10, 2016 at 03:15:44PM -0800, Kees Cook wrote: > > > > On Thu, Nov 10, 2016 at 2:27 PM, Greg KH wrote: > > > > > > On Thu, Nov 10, 2016 at 10:13:10PM +0100, Peter Zijlstra wrote: > > > > > > > > > > > > > > As it stands k

Re: sched: current instead rq->current

2016-08-17 Thread Colin Vidal
On Mon, 2016-08-15 at 21:30 +0200, Colin Vidal wrote: > Hello, > > At the beginning of __schedule (kernel/sched/core.c), the current > task > is get with rq->curr. I try to to understand why not directly using > current instead? > > Since a runqueue is specific to a CP

[PATCH v2] Staging: fix coding style in rtl8188eu/core

2016-02-10 Thread Colin Vidal
Set constant operand on right of test, and refactor the code in a more compact and readable way. Signed-off-by: Colin Vidal --- drivers/staging/rtl8188eu/core/rtw_iol.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_iol.c b

[PATCH v3 5/5] Staging: rtl8188eu/core: make core more readable

2016-02-12 Thread Colin Vidal
Signed-off-by: Colin Vidal --- drivers/staging/rtl8188eu/core/rtw_iol.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_iol.c b/drivers/staging/rtl8188eu/core/rtw_iol.c index 2e2145c..ba6c492 100644 --- a/drivers/staging

[PATCH v3 3/5] Staging: rtl8188eu/core: Coding style fix, set constant operand on right in tests

2016-02-12 Thread Colin Vidal
Signed-off-by: Colin Vidal --- drivers/staging/rtl8188eu/core/rtw_iol.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_iol.c b/drivers/staging/rtl8188eu/core/rtw_iol.c index 7642c22..3dd1a9a 100644 --- a/drivers/staging/rtl8188eu/core

[PATCH v3 2/5] Staging: rtl8188eu/core: Coding style fix, set conform spaces between identifiers

2016-02-12 Thread Colin Vidal
Signed-off-by: Colin Vidal --- drivers/staging/rtl8188eu/core/rtw_iol.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_iol.c b/drivers/staging/rtl8188eu/core/rtw_iol.c index 000a81c..7642c22 100644 --- a/drivers/staging/rtl8188eu/core

[PATCH v3 1/5] Staging: rtl8188eu/core: remove paragraph which mention FSF address in comment header

2016-02-12 Thread Colin Vidal
Signed-off-by: Colin Vidal --- drivers/staging/rtl8188eu/core/rtw_iol.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_iol.c b/drivers/staging/rtl8188eu/core/rtw_iol.c index cdcf0ea..000a81c 100644 --- a/drivers/staging/rtl8188eu/core/rtw_iol.c +++ b

[PATCH v3 4/5] Staging: rtl8188eu/core: Coding style fix, avoid line over 80 characters

2016-02-12 Thread Colin Vidal
Signed-off-by: Colin Vidal --- drivers/staging/rtl8188eu/core/rtw_iol.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_iol.c b/drivers/staging/rtl8188eu/core/rtw_iol.c index 3dd1a9a..2e2145c 100644 --- a/drivers/staging/rtl8188eu/core

[PATCH] Staging: fix coding style in rtl8188eu/core

2016-02-02 Thread Colin Vidal
Set constant on the left of the test, and jump a new line to avoid to exceed the 80 char length limit. Signed-off-by: Colin Vidal --- drivers/staging/rtl8188eu/core/rtw_iol.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_iol.c b

Re: [PATCH] Staging: fix coding style in rtl8188eu/core

2016-02-02 Thread Colin Vidal
On Tue, 2016-02-02 at 13:14 -0800, Joe Perches wrote: > On Tue, 2016-02-02 at 21:57 +0100, Colin Vidal wrote: > > Set constant on the left of the test, and jump a new line to avoid > > to > > exceed the 80 char length limit. > [] > > diff --git a/drivers/staging/

[PATCH] Staging: fix coding style in rtl8188eu/core

2016-02-02 Thread Colin Vidal
Set constant operand on right of test, and refactor the code in a more compact and readable way. Signed-off-by: Colin Vidal --- drivers/staging/rtl8188eu/core/rtw_iol.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_iol.c b

Re: [PATCH] Staging: fix coding style in rtl8188eu/core

2016-02-02 Thread Colin Vidal
On Tue, 2016-02-02 at 23:54 +0100, Colin Vidal wrote: > Set constant operand on right of test, and refactor the code in a > more > compact and readable way. > > Signed-off-by: Colin Vidal > --- >  drivers/staging/rtl8188eu/core/rtw_iol.c | 13 + >  1 file cha

sched: current instead rq->current

2016-08-15 Thread Colin Vidal
Hello, At the beginning of __schedule (kernel/sched/core.c), the current task is get with rq->curr. I try to to understand why not directly using current instead? Since a runqueue is specific to a CPU, it dosen't make sense to get the the current task of another CPU's runqueue. Yes? I try the fo