Re: [PATCH 1/2] drm/mediatek: set panel orientation before drm_dev_register().

2021-04-20 Thread Chun-Kuang Hu
Hi, Hsin-Yi: Hsin-Yi Wang 於 2021年4月20日 週二 下午5:05寫道: > > On Fri, Apr 9, 2021 at 12:53 PM Hsin-Yi Wang wrote: > > > > drm_dev_register() sets connector->registration_state to > > DRM_CONNECTOR_REGISTERED and dev->registered to true. If > > drm_connector_set_panel_orientation() is first called afte

Re: [PATCH] drm/dsi: Add _NO_ to MIPI_DSI_* flags disabling features

2021-02-15 Thread Chun-Kuang Hu
E_NO_EOT_PACKET. For Mediatek part, Acked-by: Chun-Kuang Hu > > Signed-off-by: Nicolas Boichat > --- > I considered adding _DISABLE_ instead, but that'd make the > flag names a big too long. > > Generated with: > flag=MIPI_DSI_MODE_VIDEO_HFP; git grep $flag | cut -f1

Re: [PATCH] drm/mediatek: force hsa hsa hfp packets multiple of line num to avoid screen shift

2021-04-07 Thread Chun-Kuang Hu
Hi, Jitao: Jitao Shi 於 2021年4月7日 週三 下午10:37寫道: > > The bridge chip ANX7625 require the line packets ending at the sametime > or ANX7625 will shift the screen. > > Change-Id: Ia324ad28fbff54140feedb9a1d6bfb2b246d0447 > Signed-off-by: Jitao Shi > --- > drivers/gpu/drm/mediatek/mtk_dsi.c | 12

Re: [PATCH next v3 03/16] dt-bindings: phy: mediatek: dsi-phy: modify compatible dependence

2021-02-12 Thread Chun-Kuang Hu
Hi, Chunfeng: Chunfeng Yun 於 2021年2月1日 週一 下午3:00寫道: > > mt7623-mipi-tx is compatible to mt2701-mipi-tx, and use > "mediatek,mt2701-mipi-tx" instead on MT7623, so modify > the compatible items to make dependence clear. Acked-by: Chun-Kuang Hu > > Cc: Chun-K

Re: [PATCH next v3 04/16] dt-bindings: phy: mediatek: hdmi-phy: modify compatible items

2021-02-12 Thread Chun-Kuang Hu
compatible items to make dependence clear. Acked-by: Chun-Kuang Hu > > Cc: Chun-Kuang Hu > Cc: Philipp Zabel > Signed-off-by: Chunfeng Yun > --- > v3: modify commit message > v2: no changes > --- > .../devicetree/bindings/phy/mediatek,hdmi-phy.yaml| 11 +++--

Re: [PATCH -next] soc / drm: mediatek: Mark mtk_mutex_driver with static keyword

2021-02-18 Thread Chun-Kuang Hu
Hi, Zou: Zou Wei 於 2021年2月18日 週四 下午3:12寫道: > > Fix the following sparse warning: > > drivers/soc/mediatek/mtk-mutex.c:464:24: warning: symbol 'mtk_mutex_driver' > was not declared. Should it be static? > Reviewed-by: Chun-Kuang Hu > Signed-off-by: Zou Wei &g

Re: [PATCH v6 6/8] drm/mediatek: add matrix_bits private data for ccorr

2021-02-03 Thread Chun-Kuang Hu
Hi, Hsin-Yi: Hsin-Yi Wang 於 2021年2月2日 週二 下午4:14寫道: > > From: Yongqiang Niu > > Add matrix_bits and coeffs_precision to ccorr private data: > - matrix bits of mt8183 is 10 > - matrix bits of mt8192 is 11 Applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/

Re: [PATCH v6 4/8] drm/mediatek: separate ccorr module

2021-02-03 Thread Chun-Kuang Hu
Hi, Hsin-Yi: Hsin-Yi Wang 於 2021年2月2日 週二 下午4:13寫道: > > From: Yongqiang Niu > > ccorr ctm matrix bits will be different in mt8192 Applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next Regards, Chun-Kuang.

Re: [PATCH v6 5/8] drm/mediatek: Fix ccorr size config

2021-02-03 Thread Chun-Kuang Hu
Hi, Hsin-Yi: Hsin-Yi Wang 於 2021年2月2日 週二 下午4:13寫道: > > From: Yongqiang Niu > > Fix setting to follow hardware datasheet. The original error setting > affects mt8192 display. > Applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/

Re: [PATCH] soc: mediatek: cmdq: Remove cmdq_pkt_flush()

2021-01-30 Thread Chun-Kuang Hu
Hi, Matthias: Chun-Kuang Hu 於 2021年1月10日 週日 上午6:59寫道: > > Hi, Matthias: > > Chun-Kuang Hu 於 2020年12月3日 週四 上午7:59寫道: > > > > rx_callback is a standard mailbox callback mechanism and could > > cover the function of proprietary cmdq_task_cb, so it is better > >

Re: [PATCH v13 3/8] drm/mediatek: add mtk_dither_set_common() function

2021-01-30 Thread Chun-Kuang Hu
Hi, Hsin-Yi: Hsin-Yi Wang 於 2021年1月29日 週五 下午5:23寫道: > > Current implementation of mtk_dither_set() cast dev data to > struct mtk_ddp_comp_dev. But other devices with different dev data > would also call this function. > > Separate necessary parameters out so other device components (dither, > gam

Re: [PATCH v13 4/8] drm/mediatek: separate gamma module

2021-01-30 Thread Chun-Kuang Hu
Hi, Hsin-Yi: Hsin-Yi Wang 於 2021年1月29日 週五 下午5:23寫道: > > From: Yongqiang Niu > > mt8183 gamma module will different with mt8173 > separate gamma for add private data After I clean up all checkpatch error, applied to mediatek-drm-next [1]. Remember to clean up all checkpatch error before send out

Re: [PATCH v13 5/8] drm/mediatek: add has_dither private data for gamma

2021-01-30 Thread Chun-Kuang Hu
Hi, Hsin-Yi: Hsin-Yi Wang 於 2021年1月29日 週五 下午5:23寫道: > > From: Yongqiang Niu > > Not all SoC has dither function in gamma module. > Add private data to control this function setting. Applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linu

Re: [PATCH v13 8/8] drm/mediatek: add support for mediatek SOC MT8183

2021-01-30 Thread Chun-Kuang Hu
Hi, Hsin-Yi: Hsin-Yi Wang 於 2021年1月29日 週五 下午5:23寫道: > > From: Yongqiang Niu > > 1. add ovl private data > 2. add rdma private data > 3. add gamma privte data > 4. add main and external path module for crtc create Applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm/lin

Re: [PATCH v13 6/8] drm/mediatek: enable dither function

2021-01-30 Thread Chun-Kuang Hu
Hi, Hsin-Yi: Hsin-Yi Wang 於 2021年1月29日 週五 下午5:23寫道: > > From: Yongqiang Niu > > Enable dither function to improve the display quality for dither > supported bpc 4, 6, 8. For not supported bpc, use relay mode. > > Signed-off-by: Yongqiang Niu > Signed-off-by: Hsin-Yi Wang > --- > drivers/gpu/d

Re: [PATCH v4 4/8] drm/mediatek: enable OVL_LAYER_SMI_ID_EN for multi-layer usecase

2021-01-30 Thread Chun-Kuang Hu
Hi, Hsin-Yi: CK Hu 於 2021年1月29日 週五 下午4:21寫道: > > Hi, Hsin-Yi: > > On Fri, 2021-01-29 at 15:34 +0800, Hsin-Yi Wang wrote: > > From: Yongqiang Niu > > > > enable OVL_LAYER_SMI_ID_EN for multi-layer usecase, without this patch, > > ovl will hang up when more than 1 layer enabled. > > Reviewed-by: C

Re: [PATCH v4 5/8] drm/mediatek: separate ccorr module

2021-01-30 Thread Chun-Kuang Hu
Hi, Hsin-Yi: Hsin-Yi Wang 於 2021年1月29日 週五 下午3:35寫道: > > From: Yongqiang Niu > > ccorr ctm matrix bits will be different in mt8192 > > Signed-off-by: Yongqiang Niu > Signed-off-by: Hsin-Yi Wang > --- > drivers/gpu/drm/mediatek/Makefile | 3 +- > drivers/gpu/drm/mediatek/mtk_disp_cc

Re: [PATCH] drm/mediatek: enable dither function

2021-02-01 Thread Chun-Kuang Hu
Hi, Hsin-Yi: Chun-Kuang Hu 於 2021年2月1日 週一 上午12:20寫道: > > Hi, Hsin-Yi: > > Hsin-Yi Wang 於 2021年1月31日 週日 下午1:11寫道: > > > > From: Yongqiang Niu > > > > Enable dither function to improve the display quality. > > Reviewed-by: Chun-Kuang Hu > Applied

Re: [PATCH v3 1/3] dt-binding: gce: add gce header file for mt8192

2021-02-05 Thread Chun-Kuang Hu
Hi, Hsin-Yi: Hsin-Yi Wang 於 2021年2月5日 週五 下午3:19寫道: > > From: Yongqiang Niu > > Add documentation for the mt8192 gce. > > Add gce header file defined the gce hardware event, > subsys number and constant for mt8192. > > Signed-off-by: Yongqiang Niu > Reviewed-by: Rob Herring > Signed-off-by: Hsi

Re: [PATCH v3 3/3] dt-bindings: mediatek,dpi: add mt8192 to mediatek,dpi

2021-02-08 Thread Chun-Kuang Hu
Hi, Jitao: Jitao Shi 於 2021年2月8日 週一 上午9:42寫道: > > Add compatible "mediatek,mt8192-dpi" for the mt8192 dpi. > Reviewed-by: Chun-Kuang Hu > Signed-off-by: Jitao Shi > --- > .../devicetree/bindings/display/mediatek/mediatek,dpi.yaml | 1 + > 1 file changed

Re: [PATCH v3 1/3] drm/mediatek: mtk_dpi: Add check for max clock rate in mode_valid

2021-02-08 Thread Chun-Kuang Hu
Hi, Jitao: Jitao Shi 於 2021年2月8日 週一 上午9:42寫道: > > Add per-platform max clock rate check in mtk_dpi_bridge_mode_valid. Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Jitao Shi > --- > drivers/gpu/drm/mediatek/mtk_dpi.c | 17 + > 1 file changed, 17 inserti

Re: [PATCH v3 2/3] drm/mediatek: mtk_dpi: Add dpi config for mt8192

2021-02-08 Thread Chun-Kuang Hu
Hi, Jitao: Jitao Shi 於 2021年2月8日 週一 上午9:42寫道: Where is the description? Say something here. > > Signed-off-by: Jitao Shi > --- > drivers/gpu/drm/mediatek/mtk_dpi.c | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c > b/drivers/gpu/drm/mediate

Re: [PATCH v4 10/17] drm/mediatek: Add pm runtime support for ovl and rdma

2020-05-30 Thread Chun-Kuang Hu
ime_get for smi via > ovl or rdma device. > > This is a preparing patch that smi cleaning up "mediatek,larb". > Acked-by: Chun-Kuang Hu > CC: CK Hu > Signed-off-by: Yongqiang Niu > Signed-off-by: Yong Wu > --- > drivers/gpu/drm/mediatek/mtk_disp_ovl.c |

Re: [PATCH v4 11/17] drm/mediatek: Get rid of mtk_smi_larb_get/put

2020-05-30 Thread Chun-Kuang Hu
Hi, Yong: Yong Wu 於 2020年5月30日 週六 下午4:27寫道: > > MediaTek IOMMU has already added the device_link between the consumer > and smi-larb device. If the drm device call the pm_runtime_get_sync, > the smi-larb's pm_runtime_get_sync also be called automatically. > Acked-by: Chun-Ku

Re: [PATCH 1/4] clk/soc: mediatek: mt8183: Bind clock driver from platform device

2020-05-18 Thread Chun-Kuang Hu
Hi, Matthias: Matthias Brugger 於 2020年5月18日 週一 下午11:57寫道: > > > > On 18/05/2020 17:30, Chun-Kuang Hu wrote: > > Hi, Matthias: > > > > 於 2020年5月18日 週一 下午7:32寫道: > >> > >> From: Matthias Brugger > >> > >> The mmsys driver is n

Re: [PATCH 2/4] clk/soc: mediatek: mt6797: Bind clock driver from platform device

2020-05-18 Thread Chun-Kuang Hu
ent and > therefor will errror out for now. > Reviewed-by: Chun-Kuang Hu > Signed-off-by: Matthias Brugger > --- > > drivers/clk/mediatek/clk-mt6797-mm.c | 9 ++--- > drivers/soc/mediatek/mtk-mmsys.c | 8 > 2 files changed, 10 insertions(+), 7 deletion

Re: [PATCH 4/4] arm64: dts: mt6797: Fix mmsys node name

2020-05-19 Thread Chun-Kuang Hu
Hi, Matthias: 於 2020年5月18日 週一 下午7:33寫道: > > From: Matthias Brugger > > Node names are supposed to match the class of the device. The > mmsys node is a syscon as it provides more then just a clock controller. > Update the name. Reviewed-by: Chun-Kuang Hu > > Signed-

Re: [PATCH 3/4] clk/soc: mediatek: mt6779: Bind clock driver from platform device

2020-05-19 Thread Chun-Kuang Hu
Hi, Matthias: 於 2020年5月18日 週一 下午7:33寫道: > > From: Matthias Brugger > > The mmsys driver is now the top level entry point for the multimedia > system (mmsys), we bind the clock driver by creating a platform device. > We also bind the MediaTek DRM driver which is not yet implement and > therefor w

Re: [PATCH] drm/mediatek: mtk_mt8173_hdmi_phy: Remove unnused const variables

2020-05-19 Thread Chun-Kuang Hu
Hi, Enric: Enric Balletbo i Serra 於 2020年5月19日 週二 下午5:40寫道: > > There are some `static const u8` variables that are not used, this > triggers a warning building with `make W=1`, it is safe to remove them, > so do it and make the compiler more happy. > Reviewed-by: Chun-Kuang Hu

Re: [PATCH] drm/mediatek: mtk_hdmi: Remove debug messages for function calls

2020-05-19 Thread Chun-Kuang Hu
Hi, Enric: Enric Balletbo i Serra 於 2020年5月19日 週二 下午5:41寫道: > > Equivalent information can be nowadays obtained using function tracer > Reviewed-by: Chun-Kuang Hu > Signed-off-by: Enric Balletbo i Serra > --- > > drivers/gpu/drm/mediatek/mtk_hdmi.c| 12 +-

Re: [PATCH 3/4] clk/soc: mediatek: mt6779: Bind clock driver from platform device

2020-05-19 Thread Chun-Kuang Hu
Matthias Brugger 於 2020年5月20日 週三 上午5:26寫道: > > > > On 19/05/2020 17:10, Chun-Kuang Hu wrote: > > Hi, Matthias: > > > > 於 2020年5月18日 週一 下午7:33寫道: > >> > >> From: Matthias Brugger > >> > >> The mmsys driver is now the top level ent

Re: [PATCH v4 2/2] soc: mediatek: add mtk-devapc driver

2020-07-29 Thread Chun-Kuang Hu
Hi, Neal: Neal Liu 於 2020年7月29日 週三 下午4:29寫道: > > MediaTek bus fabric provides TrustZone security support and data > protection to prevent slaves from being accessed by unexpected > masters. > The security violation is logged and sent to the processor for > further analysis or countermeasures. > >

Re: [PATCH v4 2/2] soc: mediatek: add mtk-devapc driver

2020-07-29 Thread Chun-Kuang Hu
Hi, Neal: Neal Liu 於 2020年7月29日 週三 下午4:29寫道: > > MediaTek bus fabric provides TrustZone security support and data > protection to prevent slaves from being accessed by unexpected > masters. > The security violation is logged and sent to the processor for > further analysis or countermeasures. > >

Re: [PATCH v4 2/2] soc: mediatek: add mtk-devapc driver

2020-07-30 Thread Chun-Kuang Hu
Hi, Neal: Neal Liu 於 2020年7月29日 週三 下午4:29寫道: > > MediaTek bus fabric provides TrustZone security support and data > protection to prevent slaves from being accessed by unexpected > masters. > The security violation is logged and sent to the processor for > further analysis or countermeasures. > >

Re: [PATCH v5 2/2] soc: mediatek: add mt6779 devapc driver

2020-08-10 Thread Chun-Kuang Hu
Hi, Neal: Neal Liu 於 2020年8月10日 週一 上午11:43寫道: > > Hi Chun-Kuang, > > On Fri, 2020-08-07 at 23:52 +0800, Chun-Kuang Hu wrote: > > Hi, Neal: > > > > Neal Liu 於 2020年8月7日 週五 上午10:34寫道: > > > > > > MediaTek bus fabric provides TrustZone security sup

Re: [PATCH 1/2] arm: dts: mt7623: move more display-related nodes to mt7623n.dtsi

2020-08-10 Thread Chun-Kuang Hu
Hi, David: David Woodhouse 於 2020年8月10日 週一 下午3:48寫道: > > On Sun, 2020-08-09 at 08:16 +0800, Chun-Kuang Hu wrote: > > I would like to put all device in mt7623.dtsi with some device's > > status is "disabled" and change its status in platform dtsi. > > I woul

Re: [RESEND v7, PATCH 3/7] mtk-mmsys: add mmsys private data

2020-08-10 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2020年8月8日 週六 上午10:56寫道: > > the reason why split out display connection function: > 1. there will more and more Mediatek Soc upstream, and the display path > connection function mtk_mmsys_ddp_mout_en, mtk_mmsys_ddp_sel_in and > mtk_mmsys_ddp_sout_sel will complicate

Re: [PATCH v4 2/2] soc: mediatek: add mtk-devapc driver

2020-07-31 Thread Chun-Kuang Hu
Hi, Neal: Neal Liu 於 2020年7月31日 週五 上午10:44寫道: > > Hi Chun-Kuang, > > > On Thu, 2020-07-30 at 00:38 +0800, Chun-Kuang Hu wrote: > > Hi, Neal: > > > > Neal Liu 於 2020年7月29日 週三 下午4:29寫道: > > > > > > MediaTek bus fabric provides TrustZone security

Re: [PATCH v4 2/2] soc: mediatek: add mtk-devapc driver

2020-07-31 Thread Chun-Kuang Hu
Hi, Neal: Neal Liu 於 2020年7月31日 週五 上午10:52寫道: > > Hi Chun-Kuang, > > On Fri, 2020-07-31 at 00:14 +0800, Chun-Kuang Hu wrote: > > Hi, Neal: > > > > Neal Liu 於 2020年7月29日 週三 下午4:29寫道: > > > > > > MediaTek bus fabric provides TrustZone security sup

Re: [PATCH v4 2/2] soc: mediatek: add mtk-devapc driver

2020-07-31 Thread Chun-Kuang Hu
Hi, Neal: This patch is for "mediatek,mt6779-devapc", so I think commit title should show the SoC ID. Neal Liu 於 2020年7月29日 週三 下午4:29寫道: > > MediaTek bus fabric provides TrustZone security support and data > protection to prevent slaves from being accessed by unexpected > masters. > The security

Re: [PATCH v4 2/2] soc: mediatek: add mtk-devapc driver

2020-08-01 Thread Chun-Kuang Hu
Hi, Neal: Neal Liu 於 2020年7月29日 週三 下午4:29寫道: > > MediaTek bus fabric provides TrustZone security support and data > protection to prevent slaves from being accessed by unexpected > masters. > The security violation is logged and sent to the processor for > further analysis or countermeasures. > >

Re: [PATCH v2 1/5] drm/mediatek: config component output by device node port

2020-08-01 Thread Chun-Kuang Hu
Hi, Frank: Frank Wunderlich 於 2020年7月28日 週二 下午7:18寫道: > > From: Bibby Hsieh > > We can select output component by decive node port. > Main path default output component is DSI. > External path default output component is DPI. > > without this Patch i get this warning: > > WARNING: CPU: 3 PID: 70

Re: [PATCH v2 2/5] drm/mediatek: fix boot up for 720 and 480 but 1080

2020-08-01 Thread Chun-Kuang Hu
Hi, Frank: Frank Wunderlich 於 2020年7月28日 週二 下午7:19寫道: > > From: chunhui dai > > - disable tmds on phy on mt2701 > - support other resolutions like 1280x1024 If this patch does two things, it should be broken into two patches. > > without this Patch i see flickering on my TFT (1280x1024), > so

Re: [PATCH v2 3/5] drm: Add get_possible_crtc API for dpi, dsi

2020-08-01 Thread Chun-Kuang Hu
Hi, Frank: Frank Wunderlich 於 2020年7月28日 週二 下午7:18寫道: > Describe why need this patch. I think the reason is: For current mediatek dsi encoder, its possible crtc is fixed in crtc 0, and mediatek dpi encoder's possible crtc is fixed in crtc 1. In some SoC the possible crtc is not fixed in this ca

Re: [PATCH v2 4/5] drm/mediatek: dpi/dsi: change the getting possible_crtc way

2020-08-01 Thread Chun-Kuang Hu
Hi, Frank: Frank Wunderlich 於 2020年7月28日 週二 下午7:18寫道: > > From: Jitao Shi > > [Detail] > dpi/dsi get the possible_crtc by > mtk_drm_find_possible_crtc_by_comp(*drm_dev, ddp_comp) > I would like more information of why do this patch. For example: For current mediatek dsi encoder, its possible

Re: [PATCH v2 2/5] drm/mediatek: fix boot up for 720 and 480 but 1080

2020-08-02 Thread Chun-Kuang Hu
Hi, Frank: Frank Wunderlich 於 2020年8月2日 週日 下午12:44寫道: > > Hi, > > Am 2. August 2020 02:08:44 MESZ schrieb Chun-Kuang Hu > : > >Hi, Frank: > >> - disable tmds on phy on mt2701 > >> - support other resolutions like 1280x1024 > > > >If this

Re: Re: [PATCH v2 1/5] drm/mediatek: config component output by device node port

2020-08-02 Thread Chun-Kuang Hu
Hi, Frank: Frank Wunderlich 於 2020年8月2日 週日 下午4:06寫道: > > > Gesendet: Sonntag, 02. August 2020 um 02:03 Uhr > > Von: "Chun-Kuang Hu" > > An: "Frank Wunderlich" > > Cc: "Chun-Kuang Hu" , "Philipp Zabel" > > , "Davi

Re: [PATCH v4 2/2] soc: mediatek: add mtk-devapc driver

2020-08-03 Thread Chun-Kuang Hu
Neal Liu 於 2020年8月3日 週一 下午12:05寫道: > > Hi Chun-Kuang, > > On Sun, 2020-08-02 at 07:50 +0800, Chun-Kuang Hu wrote: > > Hi, Neal: > > > > Neal Liu 於 2020年7月29日 週三 下午4:29寫道: > > > > > > MediaTek bus fabric provides TrustZone security support and da

Re: [PATCH v4 2/2] soc: mediatek: add mtk-devapc driver

2020-08-03 Thread Chun-Kuang Hu
Hi, Neal: Neal Liu 於 2020年8月3日 週一 下午12:01寫道: > > Hi Chun-Kuang, > > On Sat, 2020-08-01 at 08:12 +0800, Chun-Kuang Hu wrote: > > Hi, Neal: > > > > This patch is for "mediatek,mt6779-devapc", so I think commit title > > should show the SoC ID. >

Re: [PATCH v4 2/2] soc: mediatek: add mtk-devapc driver

2020-08-03 Thread Chun-Kuang Hu
Hi, Neal: Neal Liu 於 2020年8月3日 週一 上午11:32寫道: > > Hi Chun-Kuang, > > On Fri, 2020-07-31 at 23:03 +0800, Chun-Kuang Hu wrote: > > Hi, Neal: > > > > Neal Liu 於 2020年7月31日 週五 上午10:44寫道: > > > > > > Hi Chun-Kuang, > > > > > > > &

Re: Re: Re: [PATCH v2 1/5] drm/mediatek: config component output by device node port

2020-08-03 Thread Chun-Kuang Hu
Hi, Frank: Frank Wunderlich 於 2020年8月3日 週一 下午6:43寫道: > > Hi > > Gesendet: Montag, 03. August 2020 um 01:47 Uhr > > Von: "Chun-Kuang Hu" > > > Now I just care about the bls to dpi. So in mediatek,disp.txt, you > > just need to add a Optional propertie

Re: [PATCH -next] drm/mediatek: remove duplicate include

2020-08-20 Thread Chun-Kuang Hu
Hi, Wang Hai: Wang Hai 於 2020年8月19日 週三 上午11:00寫道: > > Remove mtk_drm_ddp.h which is included more than once > Reviewed-by: Chun-Kuang Hu > Reported-by: Hulk Robot > Signed-off-by: Wang Hai > --- > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 1 - > 1 file changed, 1 de

Re: [PATCH v4 2/4] drm/mediatek: Separate mtk_hdmi_phy to an independent module

2020-08-20 Thread Chun-Kuang Hu
Hi, Randy: Randy Dunlap 於 2020年8月19日 週三 下午11:58寫道: > > On 8/19/20 8:44 AM, Chun-Kuang Hu wrote: > > diff --git a/drivers/gpu/drm/mediatek/Kconfig > > b/drivers/gpu/drm/mediatek/Kconfig > > index aa74aac3cbcc..ca3cd871a350 100644 > > --- a/drivers/gpu/drm/mediatek

Re: [PATCH v4 3/4] phy: mediatek: Move mtk_hdmi_phy driver into drivers/phy/mediatek folder

2020-08-20 Thread Chun-Kuang Hu
Hi, Randy: Randy Dunlap 於 2020年8月20日 週四 上午12:00寫道: > > On 8/19/20 8:44 AM, Chun-Kuang Hu wrote: > > diff --git a/drivers/phy/mediatek/Kconfig b/drivers/phy/mediatek/Kconfig > > index dee757c957f2..10f0ec2d5b54 100644 > > --- a/drivers/phy/mediatek/Kconfig > > +++

Re: [PATCH v4 3/4] phy: mediatek: Move mtk_hdmi_phy driver into drivers/phy/mediatek folder

2020-08-20 Thread Chun-Kuang Hu
Hi, Sam: Sam Ravnborg 於 2020年8月20日 週四 上午12:04寫道: > > Hi Chun-Kuang > > Two small details below. > > Sam > > On Wed, Aug 19, 2020 at 11:44:20PM +0800, Chun-Kuang Hu wrote: > > From: CK Hu > > > > mtk_hdmi_phy is currently placed inside mediatek

Re: [PATCH v1 04/21] mtk-mmsys: add mt8192 mmsys support

2020-08-20 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2020年8月20日 週四 下午2:16寫道: > > add mt8192 mmsys support > > Signed-off-by: Yongqiang Niu > --- > drivers/soc/mediatek/mmsys/Makefile | 1 + > drivers/soc/mediatek/mmsys/mt8192-mmsys.c | 159 > ++ > 2 files changed, 160 insertions(

Re: [PATCH v1 05/21] mtk-mmsys: add ovl mout on support

2020-08-20 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2020年8月20日 週四 下午2:16寫道: > > add ovl mout on support > > Signed-off-by: Yongqiang Niu > --- > drivers/soc/mediatek/mmsys/mt8192-mmsys.c | 23 +++ > drivers/soc/mediatek/mtk-mmsys.c | 8 > include/linux/soc/mediatek/mtk-mmsys.h

Re: [PATCH v1 06/21] drm/mediatek: add disp config and mm 26mhz clock into mutex device

2020-08-20 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2020年8月20日 週四 下午2:06寫道: > > there are 2 more clock need enable for display. > parser these clock when mutex device probe, > enable and disable when mutex on/off > > Signed-off-by: Yongqiang Niu > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 49 > +++

Re: [PATCH v1 07/21] drm/mediatek: enable OVL_LAYER_SMI_ID_EN for multi-layer usecase

2020-08-20 Thread Chun-Kuang Hu
HI, Yongqiang: Yongqiang Niu 於 2020年8月20日 週四 下午2:06寫道: > > enable OVL_LAYER_SMI_ID_EN for multi-layer usecase > > Signed-off-by: Yongqiang Niu > --- > drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c > b

Re: [PATCH v1 09/21] drm/mediatek: fix aal size config

2020-08-20 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2020年8月20日 週四 下午2:18寫道: > > fix aal size config > > Signed-off-by: Yongqiang Niu > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 11 ++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c >

Re: [PATCH v1 14/21] drm/mediatek: add bypass shadow register function call for ddp component

2020-08-20 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2020年8月20日 週四 下午2:18寫道: > > the shadow register for mt8192 ddp component is enable, > we need disable it before enable ddp component MT2701 has shadow register and use it. Why MT8192 have shadow register but disable it? I would like to use shadow register like MT27

Re: [PATCH v1 08/21] drm/mediatek: check if fb is null

2020-08-20 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2020年8月20日 週四 下午2:06寫道: > > It's possible that state->base.fb is null. Add a check before access its > format. Add a Fixes tag. Regards, Chun-Kuang. > > Signed-off-by: Yongqiang Niu > --- > drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 2 +- > 1 file changed, 1 ins

Re: [PATCH v5 2/2] soc: mediatek: add mt6779 devapc driver

2020-08-07 Thread Chun-Kuang Hu
Hi, Neal: Neal Liu 於 2020年8月7日 週五 上午10:34寫道: > > MediaTek bus fabric provides TrustZone security support and data > protection to prevent slaves from being accessed by unexpected > masters. > The security violation is logged and sent to the processor for > further analysis or countermeasures. > >

Re: [PATCH 1/2] arm: dts: mt7623: move more display-related nodes to mt7623n.dtsi

2020-08-08 Thread Chun-Kuang Hu
Hi, Frank: Frank Wunderlich 於 2020年8月8日 週六 下午8:27寫道: > > Hi, > > as i made a mistake in cover-letter, it is not assigned to the series. > > to show its content, i send it here as comment (instead of resending the > whole series): > > based on series from David Woodhouse [1] > i moved more displa

Re: [RESEND v7, PATCH 6/7] drm/mediatek: add support for mediatek SOC MT8183

2020-08-08 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2020年8月8日 週六 上午11:05寫道: > > This patch add support for mediatek SOC MT8183 > 1. add ovl private data > 2. add rdma private data > 3. add mutes private data > 4. add main and external path module for crtc create > > Signed-off-by: Yongqiang Niu [snip] > + > stati

Re: [RESEND v7, PATCH 0/7] add drm support for MT8183

2020-08-08 Thread Chun-Kuang Hu
Hi, Yongqiang: This series is 'v8', not 'RESEND v7' Yongqiang Niu 於 2020年8月8日 週六 上午10:56寫道: > > This series are based on 5.8-rc1 and provide 7 patch > to support mediatek SOC MT8183 > > Change since v6 > - move ddp component define into mtk_mmsys.h > - add mmsys private data to support different

Re: [RESEND v7, PATCH 2/7] drm/mediatek: move ddp component define into mtk_mmsys.h

2020-08-08 Thread Chun-Kuang Hu
Yongqiang Niu 於 2020年8月8日 週六 上午11:05寫道: > > mmsys is the driver which control the routing of these ddp component, > so the definition of mtk_ddp_comp_id should be placed in mtk-mmsys.h > Reviewed-by: Chun-Kuang Hu > Signed-off-by: Yongqiang Niu > --- > dri

Re: [RESEND v7, PATCH 1/7] dt-bindings: mediatek: add rdma_fifo_size description for mt8183 display

2020-08-08 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2020年8月8日 週六 上午11:04寫道: > > rdma fifo size may be different even in same SOC, add this > property to the corresponding rdma > > Change-Id: I67635ec7f3f59cf4cbc7737285e5e28ff0ab71c9 Remove change-id. > Signed-off-by: Yongqiang Niu > --- > .../devicetree/bindings/

Re: [RESEND v7, PATCH 1/7] dt-bindings: mediatek: add rdma_fifo_size description for mt8183 display

2020-08-08 Thread Chun-Kuang Hu
Hi, Yongqiang: Chun-Kuang Hu 於 2020年8月9日 週日 上午8:56寫道: > > Hi, Yongqiang: > > Yongqiang Niu 於 2020年8月8日 週六 上午11:04寫道: > > > > rdma fifo size may be different even in same SOC, add this > > property to the corresponding rdma > > > > Change-Id: I67635ec7f

Re: [PATCH 1/2] arm: dts: mt7623: move more display-related nodes to mt7623n.dtsi

2020-08-09 Thread Chun-Kuang Hu
Hi, Frank: Frank Wunderlich 於 2020年8月9日 週日 下午3:22寫道: > > > > Am 9. August 2020 02:16:59 MESZ schrieb Chun-Kuang Hu > : > > > >I would like to put all device in mt7623.dtsi with some device's > >status is "disabled" and change its status in pla

Re: [PATCH v2] drm/mediatek: dsi: fix scrolling of panel with small hfp or hbp

2020-08-18 Thread Chun-Kuang Hu
Hi, Jitao: Jitao Shi 於 2020年8月18日 週二 上午10:41寫道: > > On Tue, 2020-08-18 at 07:42 +0800, Chun-Kuang Hu wrote: > > Hi, Jitao: > > > > Jitao Shi 於 2020年8月17日 週一 下午9:07寫道: > > > > > > horizontal_backporch_byte should be hbp * bpp - hbp extra bytes

[PATCH v4 4/4] MAINTAINERS: add files for Mediatek DRM drivers

2020-08-19 Thread Chun-Kuang Hu
Mediatek HDMI phy driver is moved from drivers/gpu/drm/mediatek to drivers/phy/mediatek, so add the new folder to the Mediatek DRM drivers' information. Signed-off-by: Chun-Kuang Hu Reviewed-by: Matthias Brugger --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAIN

[PATCH v4 2/4] drm/mediatek: Separate mtk_hdmi_phy to an independent module

2020-08-19 Thread Chun-Kuang Hu
From: CK Hu mtk_hdmi_phy is a part of mtk_hdmi module, but phy driver should be an independent module rather than be part of drm module, so separate the phy driver to an independent module. Signed-off-by: CK Hu Signed-off-by: Chun-Kuang Hu Reviewed-by: Chunfeng Yun --- drivers/gpu/drm

[PATCH v4 1/4] drm/mediatek: Move tz_disabled from mtk_hdmi_phy to mtk_hdmi driver

2020-08-19 Thread Chun-Kuang Hu
From: CK Hu tz_disabled is used to control mtk_hdmi output signal, but this variable is stored in mtk_hdmi_phy and mtk_hdmi_phy does not use it. So move tz_disabled to mtk_hdmi where it's used. Signed-off-by: CK Hu Signed-off-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/mtk_h

[PATCH v4 3/4] phy: mediatek: Move mtk_hdmi_phy driver into drivers/phy/mediatek folder

2020-08-19 Thread Chun-Kuang Hu
From: CK Hu mtk_hdmi_phy is currently placed inside mediatek drm driver, but it's more suitable to place a phy driver into phy driver folder, so move mtk_hdmi_phy driver into phy driver folder. Signed-off-by: CK Hu Signed-off-by: Chun-Kuang Hu Reviewed-by: Chunfeng Yun Reviewed-by: Mat

[PATCH v4 0/4] Move Mediatek HDMI PHY driver from DRM folder to PHY folder

2020-08-19 Thread Chun-Kuang Hu
refix. Changes in v2: - include module.h in mtk_hdmi.c CK Hu (3): drm/mediatek: Move tz_disabled from mtk_hdmi_phy to mtk_hdmi driver drm/mediatek: Separate mtk_hdmi_phy to an independent module phy: mediatek: Move mtk_hdmi_phy driver into drivers/phy/mediatek folder Chun-Kuang

Re: [PATCH v3, 08/15] drm/mediatek: check if fb is null

2021-01-11 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2021年1月11日 週一 下午3:48寫道: > > It's possible that state->base.fb is null. Add a check before access its > format. Applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next Regards,

Re: [PATCH v3, 07/15] drm/mediatek: enable OVL_LAYER_SMI_ID_EN for multi-layer usecase

2021-01-11 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2021年1月11日 週一 下午3:44寫道: > > enable OVL_LAYER_SMI_ID_EN for multi-layer usecase Could you describe more information? Without this patch, what would happen? > > Signed-off-by: Yongqiang Niu > --- > drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 12 > 1 fil

Re: [PATCH v3, 06/15] drm/mediatek: add component RDMA4

2021-01-11 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2021年1月11日 週一 下午3:44寫道: > > This patch add component RDMA4 Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Yongqiang Niu > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git

Re: [PATCH v3, 05/15] drm/mediatek: add component POSTMASK

2021-01-11 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2021年1月11日 週一 下午3:44寫道: > > This patch add component POSTMASK, This patch has conflicts with the series "Decouple Mediatek DRM sub driver" [1] which has been applied to mediatek-drm-next, so please rebase this patch onto mediatek-drm-next. [1] https://patchwork.ke

Re: [PATCH v3, 04/15] drm/mediatek: add component OVL_2L2

2021-01-11 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2021年1月11日 週一 下午3:44寫道: > > This patch add component OVL_2L2 Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Yongqiang Niu > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git

Re: [PATCH v3, 03/15] arm64: dts: mt8192: add display node

2021-01-11 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2021年1月11日 週一 下午3:48寫道: > > add display node > > Signed-off-by: Yongqiang Niu > --- > arch/arm64/boot/dts/mediatek/mt8192.dtsi | 134 > +++ > 1 file changed, 134 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi

Re: [PATCH v3, 02/15] dt-bindings: mediatek: add description for mt8192 display

2021-01-11 Thread Chun-Kuang Hu
ongqiang Niu > Reviewed-by: Chun-Kuang Hu > Acked-by: Rob Herring > --- > Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git > a/Documentation/devicetree/bindings/display/mediatek/

Re: [PATCH v3, 01/15] dt-bindings: mediatek: add description for postmask

2021-01-11 Thread Chun-Kuang Hu
Yongqiang Niu 於 2021年1月11日 週一 下午3:44寫道: > > add description for postmask > postmask is used control round corner for display frame After changing to 'used to control', Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Yongqiang Niu > --- > Documentation/devic

[PATCH v2 12/12] drm/mediatek: Move mtk_ddp_comp_init() from sub driver to DRM driver

2020-12-10 Thread Chun-Kuang Hu
From: CK Hu Some ddp component exist in both display path and other path, so sub driver should not directly call DRM driver's function. Moving mtk_ddp_comp_init() from sub driver to DRM driver to achieve this. Signed-off-by: CK Hu Signed-off-by: Chun-Kuang Hu --- drivers/gpu/drm/med

[PATCH v2 11/12] drm/mediatek: DRM driver directly refer to sub driver's function

2020-12-10 Thread Chun-Kuang Hu
ned-off-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/mtk_disp_color.c | 23 +++--- drivers/gpu/drm/mediatek/mtk_disp_drv.h | 69 ++ drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 68 +++--- drivers/gpu/drm/mediatek/mtk_disp_rdma.c| 46 +--- drive

[PATCH v2 09/12] drm/mediatek: Change sub driver interface from mtk_ddp_comp to device

2020-12-10 Thread Chun-Kuang Hu
From: CK Hu Some ddp component exist in both display path and other path, so sub driver interface should get rid of display info. Using device instead of mtk_ddp_comp make interface general. Signed-off-by: CK Hu Signed-off-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/mtk_disp_color.c

[PATCH v2 10/12] drm/mediatek: Register vblank callback function

2020-12-10 Thread Chun-Kuang Hu
From: CK Hu Some ddp component exist in both display path and other path, so sub driver should not directly call crtc function. crtc register callback function to sub driver to prevent sub driver directly call crtc function. Signed-off-by: CK Hu Signed-off-by: Chun-Kuang Hu --- drivers/gpu

[PATCH v2 07/12] drm/mediatek: Use struct cmdq_client_reg to gather cmdq variable

2020-12-10 Thread Chun-Kuang Hu
From: CK Hu struct cmdq_client_reg include subsys and offset, so use it to replace these two variable. Signed-off-by: CK Hu Signed-off-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 26 ++--- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h | 4 ++-- 2 files

[PATCH v2 06/12] drm/mediatek: Remove irq in struct mtk_ddp_comp

2020-12-10 Thread Chun-Kuang Hu
From: CK Hu irq in struct mtk_ddp_comp is useless, so remove it. Signed-off-by: CK Hu Signed-off-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek

[PATCH v2 02/12] drm/mediatek: Use correct device pointer to get CMDQ client register

2020-12-10 Thread Chun-Kuang Hu
Some ddp component use mmsys device pointer to get CMDQ client register, this would get mmsys' CMDQ client register, so use each ddp component's device pointer to get. Signed-off-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/mtk_disp_color.c | 2 +- drivers/gpu/drm/mediatek/mtk_

[PATCH v2 03/12] drm/mediatek: Separate getting larb device to a function

2020-12-10 Thread Chun-Kuang Hu
From: CK Hu To make the code cleaner, separate getting larb device to a function. Signed-off-by: CK Hu Signed-off-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 57 - 1 file changed, 32 insertions(+), 25 deletions(-) diff --git a/drivers/gpu/drm

[PATCH v2 04/12] drm/mediatek: Move clk info from struct mtk_ddp_comp to sub driver private data

2020-12-10 Thread Chun-Kuang Hu
From: CK Hu Some ddp component exist in both display path and other path, so data belonged to sub driver should be moved into sub driver private data so it could be used for multiple path. clk info is one of sub driver data, so move it. Signed-off-by: CK Hu Signed-off-by: Chun-Kuang Hu

Re: [PATCH] drm/mediatek: mtk_dpi: Create connector for bridges

2020-12-11 Thread Chun-Kuang Hu
connector operations across > multiple bridges when necessary, instead of having the last bridge in > the chain creating the connector and handling all connector operations > internally. Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Hsin-Yi Wang > --- > drivers/gpu/drm/mediatek/m

Re: [PATCH v8, 1/6] dt-bindings: mediatek: add rdma_fifo_size description for mt8183 display

2020-12-11 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2020年12月11日 週五 上午8:43寫道: > > On Thu, 2020-12-10 at 23:40 +0800, Chun-Kuang Hu wrote: > > Hi, Yongqiang: > > > > Yongqiang Niu 於 2020年12月10日 週四 下午5:22寫道: > > > > > > rdma fifo size may be different even in same SOC, add thi

Re: [PATCH v8, 3/6] soc: mediatek: mmsys: add mt8183 function call for setting the routing registers

2020-12-11 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2020年12月10日 週四 下午5:08寫道: > > add mt8183 function call for setting the routing registers I think you should move this patch to the series "soc: mediatek: Prepare MMSYS for DDP routing using function call" [1]. Without this patch, that series has no strong reason to

Re: [PATCH v2, 04/17] drm/mediatek: add component OVL_2L2

2020-12-12 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2020年12月12日 週六 下午12:12寫道: > > This patch add component OVL_2L2 Break drm part and soc part into different patches. Regards, Chun-Kuang. > > Signed-off-by: Yongqiang Niu > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 1 + > include/linux/soc/mediatek/mtk-

Re: [PATCH v2, 12/17] drm/mediatek: fix gamma size config

2020-12-23 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2020年12月23日 週三 上午9:37寫道: > > On Tue, 2020-12-15 at 07:40 +0800, Chun-Kuang Hu wrote: > > Hi, Yongqiang: > > > > Yongqiang Niu 於 2020年12月12日 週六 下午12:13寫道: > > > > > > fix gamma size config > > > > I would l

Re: [PATCH v3, 09/15] drm/mediatek: Add pm runtime support for gamma

2021-01-12 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2021年1月11日 週一 下午3:48寫道: > > gamma power domain need controled in the device. In this series, why only gamma and color add pm runtime support? I think all ddp component need pm runtime support. And pm runtime support is not related to mt8192, so move these patches

Re: [PATCH v3, 12/15] drm/mediatek: separate ccorr module

2021-01-12 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2021年1月11日 週一 下午3:54寫道: > > ccorr ctm matrix bits will be different in mt8192 This patch has conflicts with the series "Decouple Mediatek DRM sub driver" [1] which has been applied to mediatek-drm-next, so please rebase this patch onto mediatek-drm-next. [1] https

  1   2   3   4   5   >