What happens if statd is restarted?
Sent from my iPhone
On Sep 14, 2012, at 10:25 AM, Stanislav Kinsbursky
wrote:
> This is a bug fix for https://bugzilla.redhat.com/show_bug.cgi?id=830862.
>
> The problem is that with NFSv4 mount in container (with separated mount
> namesapce) and active loc
t;
> static int nsm_xdr_dec_stat_res(struct rpc_rqst *rqstp,
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.h
On Sep 14, 2012, at 1:38 PM, Myklebust, Trond wrote:
> On Fri, 2012-09-14 at 13:01 -0400, Chuck Lever wrote:
>> What happens if statd is restarted?
>
> Nothing unusual. Why?
The NSM upcall transport is a potential application for TCP + softconn, now
that a persistent rpc_cl
Hi David-
On Jan 29, 2008, at 10:25 PM, David Howells wrote:
Chuck Lever <[EMAIL PROTECTED]> wrote:
This patch really ought to be broken into more manageable atomic
changes to make it easier to review, and to provide more fine-grained
explanation and rationalization for each specific
is not at beginning of
declaration
Signed-off-by: Chuck Lever <[EMAIL PROTECTED]>
Cc: Jeremy Fitzhardinge <[EMAIL PROTECTED]>
---
include/asm-x86/page.h |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/asm-x86/page.h b/include/asm-x86/page.h
index 1
t seem to make any difference either.
>
> So far, this seems like a regression to me
> Any ideas what I might be doing wrong? How can I
> help make this work again?
3.10-rc3 appears to be missing the fix for this. See:
http://marc.info/?l=linux-nfs&m=136855668104598&
s going to be on the order of a
millisecond. And what about RDMA, where RTT is about 20usecs?
A better answer might be to start at one second then exponentially back off to
the minimum of 0.25x the lease time and 0.25x the RPC retransmit time out.
--
Chuck Lever
chuck[dot]lever[at]oracle[
>
> We also by default map four errors (ETIMEDOUT, EAGAIN, EWOULDBLOCK,
> ENOMEM) to delay. I thought I remembered one of those being used by
> some HFS system, but can't actually find an example now. A quick grep
> doesn't show anything interesting.
It's worth ment
On Apr 25, 2013, at 2:46 PM, "bfie...@fieldses.org"
wrote:
> On Thu, Apr 25, 2013 at 02:40:11PM -0400, Chuck Lever wrote:
>>
>> On Apr 25, 2013, at 2:19 PM, "bfie...@fieldses.org"
>> wrote:
>>
>>> On Thu, Apr 25, 2013 at 02:10:36PM +
6 for today.
Bruce, it might make sense for me to submit the three server-side RPC GSS
patches, and then you can rebase the gssproxy work on top of those. Let me
know how you would like to proceed.
--
Chuck Lever
chuck[dot]lever[at]oracle[dot]com
--
To unsubscribe from this list: send the
On Apr 29, 2013, at 11:45 AM, "J. Bruce Fields" wrote:
> On Mon, Apr 29, 2013 at 10:53:37AM -0400, Chuck Lever wrote:
>>
>> On Apr 28, 2013, at 9:24 PM, Stephen Rothwell wrote:
>>
>>> Hi J.,
>>>
>>> After merging the nfsd tree, tod
On Apr 29, 2013, at 12:29 PM, Simo Sorce wrote:
> On Mon, 2013-04-29 at 12:05 -0400, Chuck Lever wrote:
>> On Apr 29, 2013, at 11:45 AM, "J. Bruce Fields" wrote:
>>
>>> On Mon, Apr 29, 2013 at 10:53:37AM -0400, Chuck Lever wrote:
>>>>
>
On Apr 29, 2013, at 12:21 PM, Trond Myklebust
wrote:
> On Mon, 2013-04-29 at 12:05 -0400, Chuck Lever wrote:
>> On Apr 29, 2013, at 11:45 AM, "J. Bruce Fields" wrote:
>>
>>> On Mon, Apr 29, 2013 at 10:53:37AM -0400, Chuck Lever wrote:
>>>>
>
On Apr 29, 2013, at 1:38 PM, "J. Bruce Fields" wrote:
> On Mon, Apr 29, 2013 at 01:04:01PM -0400, Chuck Lever wrote:
>>
>> On Apr 29, 2013, at 12:21 PM, Trond Myklebust
>> wrote:
>>
>>> On Mon, 2013-04-29 at 12:05 -0400, Chuck Lever wrote:
>&
On Apr 29, 2013, at 1:59 PM, "J. Bruce Fields" wrote:
> On Mon, Apr 29, 2013 at 01:47:16PM -0400, Chuck Lever wrote:
>>
>> On Apr 29, 2013, at 1:38 PM, "J. Bruce Fields" wrote:
>>
>>> On Mon, Apr 29, 2013 at 01:04:01PM -0400, Chuck Lever wro
On Apr 29, 2013, at 2:57 PM, J. Bruce Fields wrote:
> On Mon, Apr 29, 2013 at 02:30:33PM -0400, Chuck Lever wrote:
>>
>> On Apr 29, 2013, at 1:59 PM, "J. Bruce Fields"
>> wrote:
>>
>>> On Mon, Apr 29, 2013 at 01:47:16PM -0400, Chuck Lever wro
On Sep 17, 2012, at 6:49 AM, Stanislav Kinsbursky wrote:
> 14.09.2012 23:10, Chuck Lever пишет:
>>
>> On Sep 14, 2012, at 1:38 PM, Myklebust, Trond wrote:
>>
>>> On Fri, 2012-09-14 at 13:01 -0400, Chuck Lever wrote:
>>>> What happens if statd i
ectly Chuck Lever and Andrew Morton but i really wanted to thank
Chuck for his precious help and thought that /akpm/ having signed
this commit maybe he's going to figure out whats wrong easily
The commit you found is a plausible source of the trouble (based on
our current theory about t
Scratching my head to find an appropriate mailing list for review of some
proposed NFS-related Kconfig changes. These have already seen some light
on linux-nfs, but Herbert Xu suggested lkml for review by Kconfig experts.
In addition to updating the help text, I've tried to untangle the entry
dep
Clean up: since NFSD_V2_ACL is a boolean, it can be selected safely
under the NFSD_V3_ACL entry (also a boolean).
Signed-off-by: Chuck Lever <[EMAIL PROTECTED]>
---
fs/Kconfig |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/Kconfig b/fs/Kconfig
index 3
By the way, we've got another config-related nit here:
http://bugzilla.linux-nfs.org/show_bug.cgi?id=156
You can build lockd without CONFIG_SYSCTL set, but then the module will
fail to load.
Signed-off-by: Chuck Lever <[EMAIL PROTECTED]>
---
fs/Kconfig |1 +
fs/
On Feb 8, 2008, at 3:20 PM, Sam Ravnborg wrote:
On Fri, Feb 08, 2008 at 12:52:08PM -0500, Chuck Lever wrote:
Clean up: Because NFSD_V4 "depends on" NFSD_V3, it appears as a
child of
the NFSD_V3 menu entry, and is not visible if NFSD_V3 is unselected.
Replace the dependency on NFSD
FSD_V3 is
enabled if NFSD_V4 is.
Signed-off-by: Chuck Lever <[EMAIL PROTECTED]>
---
fs/Kconfig |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/fs/Kconfig b/fs/Kconfig
index 9ad62a9..4c16789 100644
--- a/fs/Kconfig
+++ b/fs/Kconfig
@@ -1723,7 +1723,8 @@ config NFS
Clean up: refresh the help text for Kconfig items related to the NFS
client. Remove obsolete URLs, and make the language consistent among
the options.
Also move the ROOT_NFS config option next to the options related to the
NFS client.
Signed-off-by: Chuck Lever <[EMAIL PROTECTED]>
--
SEC_GSS_KRB5, which is
visible, which kconfig-language.txt also frowns upon. The intent was to
enable at least one GSS mechanism if V4 was enabled. Perhaps we should
make SUNRPC_GSS visible, and make the NFSv4 options visible only if
SUNRPC_GSS is enabled.
Signed-off-by: Chuck Lever <[EMAIL PR
Clean up: since FS_POSIX_ACL is a non-visible boolean entry, it can be
selected safely under the NFSD_V4 entry (also a boolean).
Signed-off-by: Chuck Lever <[EMAIL PROTECTED]>
---
fs/Kconfig |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/Kconfig b/fs/K
Since O_DIRECT is a standard feature that is enabled in most distros,
eliminate the CONFIG_NFS_DIRECTIO build option, and change the
fs/nfs/Makefile to always build in the NFS direct I/O engine.
Signed-off-by: Chuck Lever <[EMAIL PROTECTED]>
---
fs/Kconfig
Clean up: refresh the help text for Kconfig items related to the NFS
server. Remove obsolete URLs, and make the language consistent among
the options.
Signed-off-by: Chuck Lever <[EMAIL PROTECTED]>
---
fs/Kconfig | 76 +---
1
or "M" based on the setting of CONFIG_NFSD after this
change is applied.
Signed-off-by: Chuck Lever <[EMAIL PROTECTED]>
---
fs/Kconfig |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/fs/Kconfig b/fs/Kconfig
index 21362e9..f799964 100644
--- a/fs/Kconfig
Clean up: refresh the help text for Kconfig items related to the sunrpc
module. Remove obsolete URLs, and make the language consistent among
the options.
Signed-off-by: Chuck Lever <[EMAIL PROTECTED]>
---
fs/Kconfig | 44 +---
1 files chang
ld like
to disable NFSD's TCP support.
Signed-off-by: Chuck Lever <[EMAIL PROTECTED]>
---
fs/Kconfig | 10 --
fs/nfsd/nfssvc.c |2 --
2 files changed, 0 insertions(+), 12 deletions(-)
diff --git a/fs/Kconfig b/fs/Kconfig
index 4965fd8..9c2c24b 100644
--- a/fs/Kco
merging and to
> allow receiving of many events with one call. For the next kernels.
we just published a paper in the ALS proceedings describing our
implementation of a new system call similar to sigtimedwait() that
collects many events at once.
- Chuck Lever
--
corporate: <[EMAIL
Hi David-
On Dec 5, 2007, at 8:22 PM, David Howells wrote:
Chuck Lever <[EMAIL PROTECTED]> wrote:
I don't see how persistent local caching means we can no longer
ignore (a)
and (b) above. Can you amplify this a bit?
How about I put it like this. There are two principal probl
Hi David-
[ Some history snipped... ]
On Dec 6, 2007, at 3:00 PM, David Howells wrote:
Chuck Lever <[EMAIL PROTECTED]> wrote:
Is it a problem because, if there are multiple copies of the same
remote file
in its cache, then FS-cache doesn't know, upon reconnection,
which ite
s_sync_mapping(mapping);
if (retval)
goto out;
retval = nfs_direct_write(iocb, iov, nr_segs, pos, count);
--
Chuck Lever
chuck[dot]lever[at]oracle[dot]com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a mes
longer working?
--
Chuck Lever
chuck[dot]lever[at]oracle[dot]com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
On Jan 18, 2008, at 12:30 PM, Peter Staubach wrote:
Chuck Lever wrote:
On Jan 18, 2008, at 11:55 AM, Peter Staubach wrote:
Chuck Lever wrote:
Hi Peter-
On Jan 18, 2008, at 10:35 AM, Peter Staubach wrote:
Hi.
Here is a patch set which modifies the system to enhance the
ESTALE error handling
On Jan 18, 2008, at 11:55 AM, Peter Staubach wrote:
Chuck Lever wrote:
Hi Peter-
On Jan 18, 2008, at 10:35 AM, Peter Staubach wrote:
Hi.
Here is a patch set which modifies the system to enhance the
ESTALE error handling for system calls which take pathnames
as arguments.
The VFS already
Hi Peter-
On Jan 18, 2008, at 12:30 PM, Peter Staubach wrote:
Chuck Lever wrote:
On Jan 18, 2008, at 11:55 AM, Peter Staubach wrote:
Chuck Lever wrote:
Hi Peter-
On Jan 18, 2008, at 10:35 AM, Peter Staubach wrote:
and the window in between the revalidation
and the actual use of the file
Hi Miklos-
Miklos Szeredi wrote:
From: Miklos Szeredi <[EMAIL PROTECTED]>
Add posix, bsize=, namelen= options to /proc/mounts for nfs
filesystems.
Document several other options that are still missing.
NFS lists only some options in /proc/mounts on purpose: only the
essential options are me
Some comments below.
This patch really ought to be broken into more manageable atomic changes
to make it easier to review, and to provide more fine-grained
explanation and rationalization for each specific change via individual
patch descriptions.
David Howells wrote:
The attached patch mak
bases (either the Linux kernel
bugzilla or the NFSv4 bug tracker at http://bugzilla.linux-nfs.org/
I'm not sure what the NFS client's policy is regarding support for
userspace servers. But I'd certainly hope that it is "don't break
them".
The general policy is
whether the page and attribute caches are shared -- "sharecache". Is
this mount option not adequate for persistent caching?
--
Chuck Lever
chuck[dot]lever[at]oracle[dot]com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
uses
it.
It can go away for all I care, as long as we retain some flexible
mechanism for non-block-based file systems to report I/O stats. As
far as I am aware, there are only two user utilities that understand
and parse this data, and I maintain both.
--
Chuck Lever
chuck[dot]lever[at
ple, if you copy options out from /proc/mount, umount the
filesystem, and then create a new mount with the copied options, you
should get the same mount.
For NFS, umount also needs to read some of the options in order to
determine how mountd is to connect to the server for the unmount.
(That&
-482,6 +486,17 @@ static void nfs_show_mount_options(struc
seq_printf(m, ",timeo=%lu", 10U * nfss->client->cl_timeout-
>to_initval / HZ);
seq_printf(m, ",retrans=%u", nfss->client->cl_timeout->to_retries);
seq_printf(m, ",sec=%s", nf
afe to use while
other processes are unmounting file systems.
Version: Mon, 14 Mar 2005 17:06:04 -0500
Signed-off-by: Chuck Lever <[EMAIL PROTECTED]>
---
fs/namespace.c | 66 +
fs/proc/base.c | 40 +++
incl
We still have a need to provide "iostat" like statistics for NFS
clients. Following are a couple of patches, against 2.6.11.3, which
prototype an approach for providing this kind of data to user programs.
I'd like some comment on the approach.
01-mountstats.patch adds a new file called /pro
Add an extensible per-superblock performance counter facility to the NFS
client. This facility mimics the counters available for block devices and
for networking.
Expose these new counters via /proc/self/mountstats.
Version: Mon, 14 Mar 2005 17:06:12 -0500
Signed-off-by: Chuck Lever
Andrew Morton wrote:
Chuck Lever <[EMAIL PROTECTED]> wrote:
testing NFS client workloads on a dual Pentium-III system running 2.6.11
with some NFS patches. i hit this oops while doing simple-minded ftps
and tars.
the system locks up once or twice a day under this workload. this is
the
testing NFS client workloads on a dual Pentium-III system running 2.6.11
with some NFS patches. i hit this oops while doing simple-minded ftps
and tars.
the system locks up once or twice a day under this workload. this is
the first time i had the console and captured the oops output.
Unable
the default behavior is that close() waits for all write-backs to
be committed to the server's disk. you might add support for the
"nocto" mount option so that waiting is skipped for shared mmap'd
files, but then what happens to data that is pinned on the client
because a write-back failed after
ACK.
Al Viro wrote:
Obviously broken on little-endian; fortunately, the option is
not frequently used...
Signed-off-by: Al Viro <[EMAIL PROTECTED]>
---
diff --git a/fs/nfs/super.c b/fs/nfs/super.c
index b34b7a7..b2a851c 100644
--- a/fs/nfs/super.c
+++ b/fs/nfs/super.c
@@ -732,7 +732,7 @
For various reasons I want a silent PC, so I'm using a notebook hard
drive in my desktop system. I've recycled an ancient Foxconn Socket 754
mainboard in it with this IDE controller:
00:02.5 IDE interface: Silicon Integrated Systems [SiS] 5513 [IDE] (rev
01) (prog-if 80 [Master])
Subsyst
Alan Cox wrote:
Aug 9 07:41:29 monet kernel: ata1.00: limiting speed to UDMA/66:PIO4
Aug 9 07:41:29 monet kernel: ata1.00: exception Emask 0x0 SAct 0x0 SErr
0x0 action 0x2
Aug 9 07:41:29 monet kernel: ata1.00: (BMDMA stat 0x64)
Aug 9 07:41:29 monet kernel: ata1.00: cmd
c8/00:08:fb:7c:a1/00:
Miklos:
Some mount options are never passed to the kernel, and thus can't appear
in /proc/mounts. Examples include user, users, and _netdev for NFS.
Miklos Szeredi wrote:
[please consider pruning the CC list if discussing some aspect, which
doesn't concern all]
I've done an audit of all fil
Miklos Szeredi wrote:
Some mount options are never passed to the kernel, and thus can't appear
in /proc/mounts. Examples include user, users, and _netdev for NFS.
These options control *who* may mount and *when* to mount. They are
not a property of the mount itself and are not added to /etc/m
Miklos Szeredi wrote:
Some mount options are never passed to the kernel, and thus can't appear
in /proc/mounts. Examples include user, users, and _netdev for NFS.
These options control *who* may mount and *when* to mount. They are
not a property of the mount itself and are not added to /etc/
Miklos Szeredi wrote:
After a successful mount, the NFS mount command tucks some options into
/etc/mtab that reflect which mountd was used for the mount, and what
protocol version and port was used for the mount request. Those options
are not passed to the kernel, and do not appear in /proc/mo
Miklos Szeredi wrote:
After a successful mount, the NFS mount command tucks some options into
/etc/mtab that reflect which mountd was used for the mount, and what
protocol version and port was used for the mount request. Those options
are not passed to the kernel, and do not appear in /proc/mo
In include/asm-x86_64/bitops.h, the find_{first,next,first_zero,next_zero}_bit
macros return a result type that depends on the width of the "size" argument.
The type of both arms of a conditional expression should always be the same.
I changed the return type of __scanbit() to match the return typ
onal expression
/home/cel/src/linux/include/linux/nodemask.h: In function
‘__first_unset_node’:
/home/cel/src/linux/include/linux/nodemask.h:253: warning: signed and
unsigned type in conditional expression
Signed-off-by: Chuck Lever <[EMAIL PROTECTED]>
---
include/asm-x86_64/bitops.
I apologize for sending a separate cover letter for a single patch.
Andi Kleen wrote:
On Wed, Aug 15, 2007 at 05:02:47PM -0400, Chuck Lever wrote:
The return type of __scanbit() doesn't match the return type of
find_{first,next}_bit(). Thus when you construct something like
this:
bo
The get_seconds() function returns an unsigned long. To prevent incorrect
comparison results between values saved in ts_recent_stamp and later
invocations of get_seconds(), change the type of ts_recent_stamp to match
the return type of get_seconds().
Signed-off-by: Chuck Lever <[EMAIL PROTEC
In some places, the result of skb_headroom() is compared to an unsigned
integer, and in others, the result is compared to a signed integer. Make
the comparisons consistent and correct.
Signed-off-by: Chuck Lever <[EMAIL PROTECTED]>
Cc: <[EMAIL PROTECTED]>
---
include/linux/skbuff.
tcp_minshall_update().
Signed-off-by: Chuck Lever <[EMAIL PROTECTED]>
Cc: <[EMAIL PROTECTED]>
---
include/net/tcp.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/net/tcp.h b/include/net/tcp.h
index 92049e6..d695cea 100644
--- a/include/net/tcp.h
+++ b/include/net/tcp
David Miller wrote:
From: Chuck Lever <[EMAIL PROTECTED]>
Date: Tue, 23 Oct 2007 11:44:28 -0400
The get_seconds() function returns an unsigned long. To prevent incorrect
comparison results between values saved in ts_recent_stamp and later
invocations of get_seconds(), change the t
Adrian Bunk wrote:
xs_setup_{udp,tcp}() can now become static.
ACK. Sorry this was overlooked.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
include/linux/sunrpc/xprtsock.h |6 --
net/sunrpc/xprtsock.c |4 ++--
2 files changed, 2 insertions(+), 8 deletions(-)
8
Ming Zhang wrote:
On Tue, 2007-02-13 at 10:44 +1100, NeilBrown wrote:
From: J. Bruce Fields <[EMAIL PROTECTED]>
The server name is expected to be a null-terminated string, so we can't
pass in the raw client identifier.
What's more, the client identifier is just a binary, not necessarily
printab
David Miller wrote:
From: Pete Clements <[EMAIL PROTECTED]>
Date: Mon, 12 Feb 2007 20:10:13 -0500 (EST)
2.6.20-git8 fails compile:
CHK include/linux/compile.h
UPD include/linux/compile.h
CC init/version.o
LD init/built-in.o
LD .tmp_vmlinux1
net/built-in.o: In f
Roland Dreier wrote:
> They are mostly from Chuck Level and make preparating for IPv6 support
> in the NFS server.
> They are *not* for 2.6.20, but should be ok for .21.
Out of curiousity, does this patch series reduce the delta between the
NFS/RDMA tree and mainline Linux? In other words do
Oops. This one looks old. Let me see if I can dig up the latest.
On 12/8/06, Trond Myklebust <[EMAIL PROTECTED]> wrote:
On Fri, 2006-12-08 at 23:01 +1100, NeilBrown wrote:
> From: Chuck Lever <[EMAIL PROTECTED]>
> Sometimes we need to create an RPC service but not register i
On 12/12/06, Andrew Morton <[EMAIL PROTECTED]> wrote:
On Wed, 13 Dec 2006 10:59:27 +1100
NeilBrown <[EMAIL PROTECTED]> wrote:
> From: Chuck Lever <[EMAIL PROTECTED]>
> The only reason svcsock.c looks at a sockaddr's port is to check whether
> the remote peer is c
On 11/27/06, Chris Caputo <[EMAIL PROTECTED]> wrote:
From: Chris Caputo <[EMAIL PROTECTED]>
[PATCH 2.6.19-rc6] sunrpc: fix race condition
Patch linux-2.6.10-01-rpc_workqueue.dif introduced a race condition into
net/sunrpc/sched.c in kernels 2.6.11-rc1 through 2.6.19-rc6. The race
scenario is as
Al Viro wrote:
On Wed, Jun 20, 2007 at 01:57:33PM -0700, H. Peter Anvin wrote:
... or, alternatively, add a subfield to the first field (which would
entail escaping whatever separator we choose):
/dev/md6 /export ext3 rw,data=ordered 0 0
/dev/md6:/users/foo /home/foo ext3 rw,data=ordered 0 0
/d
H. Peter Anvin wrote:
Chuck Lever wrote:
To support NFS client performance statistics, I recently added
/proc/self/mountstats. That might be a place to add details about
--move and --bind mounts without changing the format of /proc/mounts.
I just looked at /proc/self/mountstats; it seems to
H. Peter Anvin wrote:
Chuck Lever wrote:
The advantage is that it doesn't have strong user space dependencies on
its format like /proc/mounts does.
If you have NFS mount points, you will see that it includes a great deal
of additional information about each mount.
OK, I see now:
d
Hi Chris-
John Stoffel wrote:
As a user of Netapps, having quotas (if only for reporting purposes)
and some way to migrate non-used files to slower/cheaper storage would
be great.
Ie. being able to setup two pools, one being RAID6, the other being
RAID1, where all currently accessed files are i
Chris Mason wrote:
On Thu, Jun 14, 2007 at 02:20:26PM -0400, Chuck Lever wrote:
NetApp happens to use the standard NDMP protocol for sending the
flattened file system. NetApp uses it for synchronous replication,
volume migration, and back up to nearline storage and tape. AFS used
"vol
Trond Myklebust wrote:
On Wed, 2007-05-09 at 15:52 -0700, Andrew Morton wrote:
It's a bit rough that Jeff spent a large amount of time hunting down an
already-known bug. That's normally my job :(
The bug was reported by Florin Iucha (on lkml!) on Saturday. It has only
just been debugged, and
Mike Snitzer wrote:
On 2/2/07, Chuck Lever <[EMAIL PROTECTED]> wrote:
Roland Dreier wrote:
> > They are mostly from Chuck Level and make preparating for IPv6
support
> > in the NFS server.
> > They are *not* for 2.6.20, but should be ok for .21.
>
> Out
Mike Snitzer wrote:
On 4/13/07, Chuck Lever <[EMAIL PROTECTED]> wrote:
Mike Snitzer wrote:
> On 2/2/07, Chuck Lever <[EMAIL PROTECTED]> wrote:
>> Roland Dreier wrote:
>> > > They are mostly from Chuck Level and make preparating for IPv6
>> support
>
Mike Snitzer wrote:
On 4/13/07, Chuck Lever <[EMAIL PROTECTED]> wrote:
Mike Snitzer wrote:
> On 2/2/07, Chuck Lever <[EMAIL PROTECTED]> wrote:
>> Roland Dreier wrote:
>> > > They are mostly from Chuck Level and make preparating for IPv6
>> support
>
ot; field is overloaded.
Perhaps instead of looking at the number of bytes sent, the logic in the
last hunk of this patch should check which queue the request is sitting on.
---
commit 43d78ef2ba5bec26d0315859e8324bfc0be23766
Author: Chuck Lever <[EMAIL P
be32_to_cpup(p++);
> + be32_to_cpup(p++);
If these values are not used, what's the point of byte swapping them?
Surely "p += 2;" should be enough.
> break;
> default:
> goto xdr_error;
--
Chuck Lever
> On Jul 22, 2018, at 2:33 PM, Trond Myklebust wrote:
>
> On Sun, 2018-07-22 at 14:12 -0400, Chuck Lever wrote:
>>> On Jul 22, 2018, at 4:50 AM, nixiaoming
>>> wrote:
>>>
>>> dummy = be32_to_cpup(p++);
>>> dummy = be32_to_cpup(p++);
>
> On Jul 25, 2018, at 9:27 AM, Krzysztof Kozlowski wrote:
>
> On 18 June 2018 at 18:20, Chuck Lever wrote:
>>
>> The extra serialization appears to have a reproducible performance
>> impact on RDMA, which no longer takes the reserve_lock when allocating
>&
not used
> [-Werror=unused-function]
>
> This adds another #ifdef around the definition.
>
> Fixes: e40d99e6183e ("NFSD: Clean up symlink argument XDR decoders")
> Signed-off-by: Arnd Bergmann
Seems OK to me, and sorry for the noise.
Reviewed-by: Chuck Lever
> --
t; + goto out_overflow;
> size = xdr_stream_remaining(&rep->rr_stream);
>
> #ifdef RPCRDMA_BACKCHANNEL_DEBUG
> --
> 2.17.2 (Apple Git-113)
>
--
Chuck Lever
nt to
embed specific knowledge about struct xdr_stream into
rpcrdma_decode_msg. IOW, adhere to the API contract.
Given the need for adding a type cast to this function call, as
reported by the kbuild robot, I don't see that this patch improves
things significantly.
> r_xprt->rx_stats.total_rdma_reply += writelist;
> return rpclen + xdr_align_size(writelist);
> --
> 2.17.2 (Apple Git-113)
>
--
Chuck Lever
8,7 @@ void
> rpcrdma_post_recvs(struct rpcrdma_xprt *r_xprt, bool temp)
> {
> struct rpcrdma_buffer *buf = &r_xprt->rx_buf;
> - struct ib_recv_wr *wr, *bad_wr;
> + struct ib_recv_wr *wr, *bad_wr = NULL;
> int needed, count, rc;
>
> rc = 0;
> --
> 2.7.0
Does this need
Fixes: d34ac5cd3a73 ("RDMA, core and ULPs: Declare ib_post_send() and
ib_post_recv() arguments const") ???
Bart, any comments?
--
Chuck Lever
++ = htonl((u32) from_kgid(&init_user_ns, cred->uc_gids[i]));
> + if (gi)
> + for (i = 0; i < UNX_NGROUPS && i < gi->ngroups; i++)
> + *p++ = htonl((u32) from_kgid(&init_user_ns,
> gi->gid[i]));
> *hold = htonl(p - hold - 1);/* gid array length */
> *base = htonl((p - base - 1) << 2); /* cred length */
>
> @@ -214,12 +176,13 @@ unx_validate(struct rpc_task *task, __be32 *p)
>
> int __init rpc_init_authunix(void)
> {
> - return rpcauth_init_credcache(&unix_auth);
> + unix_pool = mempool_create_kmalloc_pool(16, sizeof(struct rpc_cred));
> + return unix_pool ? 0 : -ENOMEM;
> }
>
> void rpc_destroy_authunix(void)
> {
> - rpcauth_destroy_credcache(&unix_auth);
> + mempool_destroy(unix_pool);
> }
>
> const struct rpc_authops authunix_ops = {
> @@ -228,9 +191,7 @@ const struct rpc_authops authunix_ops = {
> .au_name= "UNIX",
> .create = unx_create,
> .destroy= unx_destroy,
> - .hash_cred = unx_hash_cred,
> .lookup_cred= unx_lookup_cred,
> - .crcreate = unx_create_cred,
> };
>
> static
>
>
--
Chuck Lever
> On Nov 7, 2018, at 8:41 PM, NeilBrown wrote:
>
> On Wed, Nov 07 2018, Chuck Lever wrote:
>
>> Hi Neil-
>>
>>
>>> On Nov 6, 2018, at 11:12 PM, NeilBrown wrote:
>>>
>>> 1/ discard 'struct unx_cred'. We don't need a
ckd/lockd.h, fs/lockd/, and
fs/nfsd/:
Acked-by: Chuck Lever
> ---
> fs/9p/vfs_file.c| 38 ++---
> fs/afs/flock.c | 55 +++---
> fs/ceph/locks.c | 66 +++
> fs/dlm/plock.c | 44 ++---
> fs/fuse/file.c
| 74 ++--
> fs/smb/client/smb2file.c| 2 +-
> fs/smb/server/smb2pdu.c | 44 +--
> fs/smb/server/vfs.c | 14 +-
> include/linux/filelock.h| 58 ++-
> include/linux/fs.h | 5 +-
> include/linux/lockd/lockd.h | 8 +-
> include/trace/events/afs.h | 4 +-
> include/trace/events/filelock.h | 54 +--
> 48 files changed, 1119 insertions(+), 825 deletions(-)
> ---
> base-commit: 052d534373b7ed33712a63d5e17b2b6cdbce84fd
> change-id: 20240116-flsplit-bdb46824db68
>
> Best regards,
> --
> Jeff Layton
>
--
Chuck Lever
on
For the changes in fs/lockd/ and fs/nfsd/:
Acked-by: Chuck Lever
> ---
> fs/ceph/locks.c | 8 ++---
> fs/lockd/clnt4xdr.c | 8 ++---
> fs/lockd/clntproc.c | 6 ++--
> fs/lockd/clntxdr.c | 8 ++---
> fs/lockd/svc4proc
't seem to be benefit for API consumers to have to
understand the internal structure of struct file_lock/lease to reach
into fl_core. Having accessor functions for common fields like
fl_type and fl_flags could be cleaner.
For the series:
Reviewed-by: Chuck Lever
For the nfsd and lockd parts:
verifier, NFS4_VERIFIER_SIZE)
> - __string_len(name, name, clp->cl_name.len)
> + __string_len(name, clp->cl_name.data, clp->cl_name.len)
> ),
> TP_fast_assign(
> __entry->cl_boot = clp->cl_clientid.cl_boot;
> --
> 2.43.0
>
Do you want me to take this through the nfsd tree, or would you like
an Ack from me so you can handle it as part of your clean up? Just
in case:
Acked-by: Chuck Lever
--
Chuck Lever
tuality, commit c1fa617caeb0 ("tracing:
> Rework __assign_str() and __string() to not duplicate getting the string")
> is the commit that makes __string_str_len() obsolete).
>
> Cc: sta...@vger.kernel.org
> Fixes: 0c77668ddb4e7 ("SUNRPC: Introduce trace points in
On Wed, Apr 10, 2024 at 01:07:41PM -0400, Steven Rostedt wrote:
> On Wed, 10 Apr 2024 12:38:53 -0400
> Chuck Lever wrote:
>
> > On Wed, Apr 10, 2024 at 12:38:13PM -0400, Steven Rostedt wrote:
> > > From: "Steven Rostedt (Google)"
> > >
> > >
1 - 100 of 251 matches
Mail list logo
