Re: [PATCH] NFC: st21nfca: Remove double assignment of .owner in struct device_driver

.of_match_table = > of_match_ptr(of_st21nfca_i2c_match), }, > .probe = st21nfca_hci_i2c_probe, Acked-by: Christophe RICARD -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] NFC: st21nfca: fix error handling of irq_of_parse_and_map

Hi Dmitry, Thank you for your feedback. A patch got already pushed earlier this month: https://lists.01.org/pipermail/linux-nfc/2014-November/003123.html The i2c-core is already running the i2c_of_parse_and_map function when registering the slave device when using dts. This step got removed for t

Re: [PATCH] NFC: st21nfcb: fix error handling of irq_of_parse_and_map

Hi Dmitry, Thank you for your feedback. A patch got already pushed earlier this month: https://lists.01.org/pipermail/linux-nfc/2014-November/003126.html The i2c-core is already running the i2c_of_parse_and_map function when registering the slave device when using dts. This step got removed for t

[PATCH] .mailmap: Add Christophe Ricard

Different computers had different settings in the mail client. Some contributions appear as Christophe Ricard, others as Christophe RICARD. Signed-off-by: Christophe Ricard --- .mailmap | 1 + 1 file changed, 1 insertion(+) diff --git a/.mailmap b/.mailmap index 7e6c533..90c0aef 100644 --- a

Re: [PATCH 2/5] tpm_tis_spi: Abort transfer when too many wait states are signaled

Nitpick: Are you sure this patch is necessary having #3 on top of it ? On 16/02/2017 08:08, Peter Huewe wrote: Abort the transfer with ETIMEDOUT when the TPM signals more than TPM_RETRY wait states. Continuing with the transfer in this state will only lead to arbitrary failures in other parts of

Re: [PATCH 3/5] tpm_tis_spi: Check correct byte for wait state indicator

That's is correct, this is a mistake on my side and never saw it :-(. I guess it was possibly leading to "waste" at least 1 wait state on some TPMs. Wouldn't it be better to merge that with #1 and update the comment consequently? On 16/02/2017 08:08, Peter Huewe wrote: Wait states are sig

Re: [PATCH 5/5] tpm_tis_spi: Add small delay after last transfer

Are you sure it is not better to introduce this delay directly in the rpi spi driver ? Other than that i don't see any issue with it. On 16/02/2017 08:09, Peter Huewe wrote: Testing the implementation with a Raspberry Pi 2 showed that under some circumstances its SPI master erroneously releas

Re: [PATCH 4/5] tpm_tis_spi: Remove limitation of transfers to MAX_SPI_FRAMESIZE bytes

I am not sure i understand here, are you considering there could be burstcount > 64 with "TCG" TPM ? Or is this because of TIS vs PTP differences ? To be honest, this is a little behind me now :-) On 16/02/2017 08:08, Peter Huewe wrote: Limiting transfers to MAX_SPI_FRAMESIZE was not expecte