On Mon, Jun 03, 2013 at 03:55:55PM -0400, J??rn Engel wrote:
> Actually, when I compare the two invocations, I prefer the
> list_for_each_entry_del() variant over list_pop_entry().
>
> while ((ref = list_pop_entry(&prefs, struct __prelim_ref, list))) {
> list_for_each_entry_del(ref
I can't say I like the structure.
A list_pop that removes and entry from the head or returns NULL if the
list is empty would lead to nice while loops that are obviously
readable instead.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord.
On Sat, May 25, 2013 at 09:05:25AM +0200, Paolo Bonzini wrote:
> Linus wanted to keep that for CAP_SYS_RAWIO. We found two uses of SG_IO
> on partitions: zfs-fuse used SYNCHRONIZE CACHE; some proprietary driver
> used TEST UNIT READY.
FYI I looked at the zfs code and the way it uses it is part of
On Fri, Jun 21, 2013 at 04:42:41PM -0700, Colin Cross wrote:
> ranges, which John Stultz has been implementing. The second is
> anonymous shareable memory without having a world-writable tmpfs that
> untrusted apps could fill with files.
I still haven't seen any explanation of what ashmem buys ov
On Mon, Jun 24, 2013 at 12:44:59PM +1000, Dave Chinner wrote:
> various DVR companies shipping equivalent ioctl-based functionality
> for XFS filesystems to both insert and remove chunks in video
> streams, but I've never been able to find the code for it anywhere.
Samsung does this, also for UDF.
On Sat, Jun 22, 2013 at 12:47:29PM -0700, Alex Elsayed wrote:
> Couldn't this be done by having a root-only tmpfs, and having a userspace
> component that creates per-app directories with restrictive permissions on
> startup/app install? Then each app creates files in its own directory, and
> ca
> @@ -1900,17 +1901,9 @@ srcip_matches(struct sockaddr *srcaddr, struct
> sockaddr *rhs)
> {
I think your new sockaddr_equal should be equivalent to to this
srcip_matches, that is it should warn about and return false for unknown
address families.
--
To unsubscribe from this list: send the line
On Wed, Jul 31, 2013 at 02:15:41PM +1000, Dave Chinner wrote:
> From: Dave Chinner
>
> Some filesystems don't use the VFS inode hash and fake the fact they
> are hashed so that all the writeback code works correctly. However,
> this means the evict() path still tries to remove the inode from the
At this point the list_lru name really becomes confusing. Given that
it's not really LRU specific maybe just rename it to pernode_list
or similar?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info a
Instead of adding more mess to change_file_space it might be a good idea
to pull my
"refactor the preallocation and hole punching code"
series from December in first.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.or
Btw, FreeBSD has an extension to shm_open to create unnamed but fd
passable segments. From their man page:
As a FreeBSD extension, the constant SHM_ANON may be used for the path
argument to shm_open(). In this case, an anonymous, unnamed shared
memory object is created. Since the ob
On Tue, Jul 30, 2013 at 08:29:51AM +0800, Xiong Zhou wrote:
> From: Xiong Zhou
>
> In the lustre client driver, lloop depends on BLOCK. Add an
> option for this dependence. Last version of this patch makes
> LUSTRE_FS depends on BLOCK.
> Remove unnecessary jdb head files which depends on BLOCK.
What should be added to this support is to move the swap over nfs code
over to this interface instead of the utterly bogus
KERNEL_READ/KERNEL_WRITE hacks that were added for it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.ke
On Mon, Jul 01, 2013 at 08:59:49PM +0100, Al Viro wrote:
> The major change in that pile is ->readdir() replacement with ->iterate(),
> dealing with ->f_pos races in ->readdir() instances for good. There's
> a lot more, but I'd prefer to split the pull request into several stages
> and this is the
On Fri, Aug 02, 2013 at 03:14:32PM +0800, Cong Wang wrote:
> From: Cong Wang
>
> nfs and cifs define some helper functions for sockaddr,
> they can use the generic functions for union inet_addr too.
>
> Since some dlm code needs to compare ->sin_port, introduce a
> generic function inet_addr_equ
On Thu, Aug 01, 2013 at 08:04:24AM -0500, Dave Kleikamp wrote:
> On 08/01/2013 03:58 AM, Christoph Hellwig wrote:
> > What should be added to this support is to move the swap over nfs code
> > over to this interface instead of the utterly bogus
> > KERNEL_READ/KERNEL_WRITE
On Thu, Aug 01, 2013 at 07:57:22PM +, Dilger, Andreas wrote:
> It provides significant performance improvement for network IO on Lustre.
> It bypasses DLM locking in Lustre and the VFS layer on the client, copying
> in the loop driver, and page-by-page IO submission in the normal IO path.
Part
On Fri, Aug 02, 2013 at 11:11:33AM +1000, Dave Chinner wrote:
> But that doesn't fix the problem of taking the hash lock in evict()
> when it is not necessary. If everything sets I_NEEDS_WRITEBACK, and
> we still fake hashing the inode, how are do we know that we don't
> need to unhash it in evict(
On Thu, Aug 01, 2013 at 04:36:08AM -0400, Rich Felker wrote:
> I'm not sure what the purpose is. shm_open with a long random filename
> and O_EXCL|O_CREAT, followed immediately by shm_unlink, is just as
> good except in the case where you have a malicious user killing the
> process in between these
On Mon, Aug 05, 2013 at 10:16:41AM +0200, Ingo Molnar wrote:
> If you want fewer dependencies then build with 'make NO_GTK=1'.
Doesn't help the distros. Installing perf and pulling all the graphics
libraries in is highly annoying, especially in size constrained VM or
Cloud images. Having a separ
On Sun, Aug 04, 2013 at 08:45:16PM -0700, Linus Torvalds wrote:
> The patch looks right to me - we should pass in similar flags for the
> create case as for tmpfile to the filesystem.
>
> But let's make sure we're all on the same page. Al?
Given all the problems and very limited fs support I'd mu
On Mon, Aug 05, 2013 at 10:31:32AM +0200, Ingo Molnar wrote:
> Nonsense, a distro, if it truly worried about this, could create two
> packages already, there's no need to expose configuration options in the
> binary name itself and burden users with the separation. I sometimes
> switch the UI fr
As I've seen very few replies to this: how do we ensure this gets
picked up for the 3.12 merge window? The series has been a reposted
a few times without complaints or major changes, but the ball still
doesn't seem to get rolling.
I'd really like to do some ecryptfs and scsi target work that is
On Tue, Aug 20, 2013 at 08:07:51PM +, Nicholas A. Bellinger wrote:
>
> It's also currently lacking the necessary sychronization between I/O
> submission of COMPARE_AND_WRITE verify instance and write instance
> user data, which is still being worked on in order to avoid additional
> overhead i
Looks good,
Reviewed-by: Christoph Hellwig
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
> @@ -1832,7 +1832,8 @@ static void transport_complete_qf(struct se_cmd *cmd)
> ret = cmd->se_tfo->queue_data_in(cmd);
> break;
> case DMA_TO_DEVICE:
> - if (cmd->t_bidi_data_sg) {
> + if (cmd->t_bidi_data_sg &&
> + cmd->t_ta
On Tue, Aug 20, 2013 at 08:07:57PM +, Nicholas A. Bellinger wrote:
> From: Nicholas Bellinger
>
> COMPARE_AND_WRITE expects to be able to send down a DMA_FROM_DEVICE
> to obtain the necessary READ payload for comparision against the
> first half of the WRITE payload containing the verify user
On Tue, Aug 20, 2013 at 08:08:00PM +, Nicholas A. Bellinger wrote:
> From: Nicholas Bellinger
>
> Add a special case for COMPARE_AND_WRITE for the reverse data direction
> mapping used for pci_map_sg() + friends.
A low level driver is an even worse place to hardcode a specific cdb
opcode. A
On Tue, Aug 20, 2013 at 11:19:06PM +0200, dl...@gmx.de wrote:
> From: Jan-Simon M??ller
>
> Author: PaX Team
> ML-Post:
> http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20120507/142707.html
> URL: http://llvm.linuxfoundation.org
>
> Merge: Jan-Simon M??ller
>
> Descriptio
On Wed, Aug 21, 2013 at 07:38:21AM -0700, Roland Dreier wrote:
> I don't understand this. In fact the whole patch series looks quite
> confused. COMPARE AND WRITE is a normal Data-Out command, with no
> requirement for special bidirectional handling or anything like that.
> The only slightly unus
On Wed, Aug 21, 2013 at 12:31:07AM -0700, Nicholas A. Bellinger wrote:
> Is it really worth having two se_cmd_flags for COMPARE_AND_WRITE..?
Not leaking the abstraction into the driver is always worth the effort.
But looking at the other patches I haven't reviewed yet I think the
issue is more se
I don't like the layering here. The re-execution of the same command
for both reading and writing the data from/to the backend device already
looks sketchy here due to doubling work of task attribute handling, the
various state bits, etc. And it will only get more complicated when
the required lo
> static int
> +transport_generic_get_mem_bidi(struct se_cmd *cmd)
Except for the fields touched in struct se_cmd this is a duplication
of transport_generic_get_mem. I'd suggest to factor that one into
a new helper:
static int
target_alloc_sgl(struct scatterlist **sgl, unsigned int **nents,
On Mon, Aug 05, 2013 at 11:08:57AM +0200, Ingo Molnar wrote:
> You never replied to the original counter-arguments, such as this one from
> Linus:
>
> http://article.gmane.org/gmane.linux.kernel/849965
The only thing Linus sais is that it's trivial to generate a subpackage,
and that opofile is
On Tue, Aug 06, 2013 at 11:03:08AM -0400, Benjamin LaHaise wrote:
> On Tue, Aug 06, 2013 at 08:31:01PM +0800, Peng Tao wrote:
> > From: Peng Tao
> >
> > We also missed ki_nbytes...
>
> Applied to the aio-next.git tree.
The correct fix would be to just switch the .read and .write entry
points in
On Wed, Aug 07, 2013 at 10:28:18PM +0200, Ben Hutchings wrote:
> As Kent said back in 2011 (commit 84759c6d18c5), bcache needs
> {down,up}_read_non_owner(). But these are not implemented by the -rt
> patchset when PREEMPT_RT_FULL is enabled. Can they be added, or is
> there a fundamental conflict
On Thu, Aug 08, 2013 at 12:43:26AM -0700, Kent Overstreet wrote:
> I seem to recall from looking at the logs that you just removed them
> because all the old users could be and were converted to something
> saner, for what they were doing (using them as completions, I want to
> say?)
We explicitly
On Wed, Aug 07, 2013 at 07:45:17AM +, Dilger, Andreas wrote:
> The problem still remains that the kernel loop driver eventually depends on
> a local block device for the pages/bios to be written. The Lustre lloop
> driver bypasses the VFS and block layer to generate RPCs from the submitted
> p
On Wed, Aug 07, 2013 at 02:54:09PM -0700, Kent Overstreet wrote:
> _However_, I have more patches (that depend on this patch series) to get
> that back - segment merging improvements that get rid of
> bi_seg_front_size, bi_seg_back_size, and bi_phys_segments. Once all that
> is in it should be a ne
On Fri, May 24, 2013 at 12:58:52PM +0200, Philippe De Muyter wrote:
> > This very much screams like it should be implemented in the lvm2
> > userspace package using the dm kernel driver.
>
> Is lvm2 a generic tool for discovering foreign partition layouts, or it is
> about one linux-specific lvm i
On Tue, May 21, 2013 at 09:27:54AM +0200, Philippe De Muyter wrote:
> AIX LVM permits to make "logical volumes" which are made of multiple slices
> of multiple disks. The new code allows only access to the "logical volumes"
> which are made of one slice on the probed disk, a slice being a contiguo
On Fri, May 24, 2013 at 09:35:02PM -0700, James Bottomley wrote:
> I'll go along with this. I'm also wondering what the problem would be
> if we just allowed all commands on either CAP_SYS_RAWIO or opening the
> device for write, so we just defer to the filesystem permissions and
> restricted read
On Sat, May 25, 2013 at 09:05:25AM +0200, Paolo Bonzini wrote:
> > you could send destructive commands to a partition. The right fix
> > for that would be to not allow SG_IO on partitions at all, just
> > wondering if anything would be broken by this.
>
> Linus wanted to keep that for CAP_SYS_RAW
On Thu, Aug 02, 2012 at 02:25:56PM +0800, Asias He wrote:
> We need to support both REQ_FLUSH and REQ_FUA for bio based path since
> it does not get the sequencing of REQ_FUA into REQ_FLUSH that request
> based drivers can request.
>
> REQ_FLUSH is emulated by:
> 1. Send VIRTIO_BLK_T_FLUSH to devi
On Thu, Aug 02, 2012 at 02:43:04PM +0800, Asias He wrote:
>> Even if it has a payload waiting is highly suboptimal and it should
>> use a non-blocking sequencing like it is done in the request layer.
>
> So, for REQ_FLUSH, what we need is that send out the VIRTIO_BLK_T_FLUSH and
> not to wait.
If
At least after review is done I really think this patch sopuld be folded
into the previous one.
Some more comments below:
> @@ -58,6 +58,12 @@ struct virtblk_req
> struct bio *bio;
> struct virtio_blk_outhdr out_hdr;
> struct virtio_scsi_inhdr in_hdr;
> + struct work_struct
On Tue, Aug 07, 2012 at 04:47:13PM +0800, Asias He wrote:
> 1) Ramdisk device
> With bio-based IO path, sequential read/write, random read/write
> IOPS boost : 28%, 24%, 21%, 16%
> Latency improvement: 32%, 17%, 21%, 16%
> 2) Fusion IO device
> With bio-based IO path, se
On Thu, Aug 09, 2012 at 01:28:03PM +0800, Shaohua Li wrote:
> The SCSI discard request merge never worked, and looks no solution for in
> future, let's disable it temporarily.
>
> Signed-off-by: Shaohua Li
Looks good and is equivalent to what I proposed over a year aggo,
Revie
On Sun, Feb 17, 2008 at 10:20:28AM +0200, Adrian Bunk wrote:
> This patch moves the extern declarations of several structs to vxfs_extern.h
>
> Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
ACK.
>
> ---
>
> fs/freevxfs/vxfs_extern.h |5 +
> fs/freevxfs/vxfs_immed.c |1 +
> fs/fr
On Sat, Feb 16, 2008 at 02:12:05PM -0500, Erez Zadok wrote:
> diff --git a/fs/sysfs/file.c b/fs/sysfs/file.c
> index 02223e2..a57b024 100644
> --- a/fs/sysfs/file.c
> +++ b/fs/sysfs/file.c
> @@ -329,9 +329,11 @@ static int sysfs_open_file(struct inode *inode, struct
> file *file)
> struct sy
On Sun, Feb 17, 2008 at 10:18:42AM +0200, Adrian Bunk wrote:
> This patch makes the needlessly global vfs_ioctl() static.
I think the point was toa eventually export it for stackable filesystem
use. But until they start using it marking it static seems fine with
me.
--
To unsubscribe from this l
On Sun, Feb 17, 2008 at 10:16:37AM +0200, Adrian Bunk wrote:
> This patch removes the obsolete and no longer used generic_commit_write().
Given that the APIs these are helpers for are gone this function should
go away.
ACK.
--
To unsubscribe from this list: send the line "unsubscribe linux-kerne
On Wed, Feb 20, 2008 at 02:25:52PM -0800, Dave Hansen wrote:
> On Sat, 2008-02-16 at 07:31 +0100, Christoph Hellwig wrote:
> > once we put pieces in the first three patches would be useful aswell,
> > to easily catch additions in the next cycle that might be adding
> > N
On Thu, Feb 21, 2008 at 04:38:28AM -0800, Andrew Morton wrote:
> (net-related cc's removed)
>
> This look like a startup ordering bug in mnt_want_write().
Do you have CONFIG_ACPI_CUSTOM_DSDT_INITRD set?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a me
On Thu, Feb 21, 2008 at 08:02:36PM +0100, ??ric Piel wrote:
> It's been a week and no one has screamed, so I guess the idea looks fine
> to everyone :-)
>
> Here is a boot tested patch for integration. In addition to the previous
> version, it removes also rootfs_initcall(), and uses fs_initcall_
July saw the release of Linux 3.5, which included an average sized XFS
update:
81 files changed, 2633 insertions(+), 3004 deletions(-)
Noteworthy updates in Linux 3.5 include the removal of the xfsbufd
background thread which writes metadata buffers, background processing
of CIL flushes and t
On Thu, Jan 31, 2008 at 10:48:32AM +0300, Denis V. Lunev wrote:
> Christoph Hellwig wrote:
> > On Wed, Jan 30, 2008 at 02:41:34PM +0300, Denis V. Lunev wrote:
> >> The pid of the locking daemon can be substituted with a task struct
> >> without a problem. Namely, the val
On Tue, Feb 05, 2008 at 10:28:07PM +0200, Pekka Paalanen wrote:
> Use lookup_address() from pageattr.c instead of doing the same
> manually. Also had to EXPORT_SYMBOL(lookup_address) to make this
> work for modules. This also fixes "undefined symbol 'init_mm'"
> compile error for x86_32.
This shou
On Thu, Feb 07, 2008 at 12:14:56PM +0100, Harald Arnesen wrote:
> > The only recent changes to drivers/scsi/advansys.c are
> >
> > commit b80ca4f7ee36c26d300c5a8f429e73372d153379
> > Author: FUJITA Tomonori <[EMAIL PROTECTED]>
> > Date: Sun Jan 13 15:46:13 2008 +0900
> >
> > [SCSI] replace si
On Thu, Feb 07, 2008 at 01:38:05PM +0100, Hans-J??rgen Koch wrote:
> From: Hans J Koch <[EMAIL PROTECTED]>
> To: linux-kernel@vger.kernel.org
> Cc: [EMAIL PROTECTED]
> Cc: Greg KH <[EMAIL PROTECTED]>
> Subject: arch/arm/Kconfig: Make UIO available on ARM architecture
>
> Source drivers/uio/Kconfig
On Thu, Feb 07, 2008 at 01:53:27PM +0100, Ingo Molnar wrote:
>
> Pekka,
>
> i've picked up your latest cleanups, but a fundamental worry still
> remains: all the ugly 'custom pagefault handlers' stuff. Lets just have
> one clean direct callback to mmiotrace, ok?
Yes, please. And any chance we
On Thu, Feb 07, 2008 at 11:53:59AM -0500, Jeff Dike wrote:
> [ This is 2.6.25 fodder ]
>
> Update defconfig.
>
> Cc: Christoph Hellwig <[EMAIL PROTECTED]>
> Signed-off-by: Jeff Dike <[EMAIL PROTECTED]>
Thanks!
--
To unsubscribe from this list: send the line &qu
On Mon, Feb 04, 2008 at 08:11:03PM -0800, Phil Oester wrote:
> On Mon, Feb 04, 2008 at 07:27:53PM -0800, Linus Torvalds wrote:
> > kgdb? Not so interesting. We have many more hard problems happening at
> > user sites, not in developer hands.
>
> FWIW, I'm not a fulltime developer by any means, bu
On Thu, Feb 07, 2008 at 07:11:33PM -0800, Linus Torvalds wrote:
>
>
> On Thu, 7 Feb 2008, Andrew Morton wrote:
> >
> > Sob. Can we please merge "Convert SG from nopage to fault"?
>
> Heh. I just took it directly then.
>
> I think it's more of a VM patch than a SCSI patch anyway, so I don't th
Signed-off-by: Christoph Hellwig <[EMAIL PROTECTED]>
Index: linux-2.6/drivers/char/mxser.c
===
--- linux-2.6.orig/drivers/char/mxser.c 2008-02-08 07:07:55.0 +0100
+++ linux-2.6/drivers/char/mxser.c 2008-02-08
When trying to put some stress on qemu by running the xfs testsuite
I get the following:
debian:~/xfs-cmds/xfstests# sh check
[ 438.166822] SGI XFS with ACLs, security attributes, realtime, large block
numbers, no debug enabled
[ 438.185557] SGI XFS Quota Management subsystem
[ 438.193150] hd
On Fri, Feb 08, 2008 at 08:26:57AM -0500, Andreas Dilger wrote:
> You may as well make the common ioctl the same as the XFS version,
> both by number and parameters, so that applications which already
> understand the XFS ioctl will work on other filesystems.
Yes. In facy you should be able to li
On Fri, Feb 08, 2008 at 02:26:54PM -0800, Dave Hansen wrote:
>
> open_namei() will, in the future, need to take mount write counts
> over its creation and truncation (via may_open()) operations. It
> needs to keep these write counts until any potential filp that is
> created gets __fput()'d.
>
>
reworking from hch and a patch from Jeff Dike.
>
> Just posting here to let everyone have a sniff before we resend
> it back to -mm.
Except for the comment snafu in patch 8 this looks good to me.
Feel free to add
Signed-off-by: Christoph Hellwig <[EMAIL PROTECTED]>
as after a
On Sat, Feb 09, 2008 at 12:39:41AM -0600, Jason Wessel wrote:
> The kgdb tree has been collapsed review. It includes
> the kgdb core, the x86 arch, the kgdb8250 uart driver
> and the kgdb console sharing driver.
>
> Since the last time the kgdb patches were posted to LKML
> several months ago, th
- remove non-standard in/out markers
- use tabs for formatting
Signed-off-by: Christoph Hellwig <[EMAIL PROTECTED]>
Index: linux-2.6/fs/ioctl.c
===
--- linux-2.6.orig/fs/ioctl.c 2008-02-09 07:49:02.0 +0100
+++ lin
On Sat, Feb 09, 2008 at 02:19:27AM -0500, Erez Zadok wrote:
> > * Invokes filesystem specific ->unlocked_ioctl, if one exists; otherwise
> > * invokes * filesystem specific ->ioctl method. If neither method exists,
> ^
>
> I also think this extra '*' in the last comment line abo
On Sat, Feb 09, 2008 at 07:35:10AM -0600, [EMAIL PROTECTED] wrote:
> From: Jason Wessel <[EMAIL PROTECTED]>
>
> This patch adds in the ability to unoptimize a single kernel module to
> make source stepping more linear and not optimize out variables that
> the developer might like to inspect. It u
On Sat, Feb 09, 2008 at 07:35:07AM -0600, [EMAIL PROTECTED] wrote:
> index 000..24e0b6c
> --- /dev/null
> +++ b/include/asm-generic/kgdb.h
> @@ -0,0 +1,105 @@
> +/*
> + * include/asm-generic/kgdb.h
Please don't mention the file name in the top-of-file comments. This
information is redundant a
On Sat, Feb 09, 2008 at 07:35:09AM -0600, [EMAIL PROTECTED] wrote:
> From: Jason Wessel <[EMAIL PROTECTED]>
>
> With more information in the kernel, gdb can be modified in such a way
> as to automatically read the kernel module section information and
> allow for easy kernel module debugging.
>
>
On Sat, Feb 09, 2008 at 07:35:08AM -0600, [EMAIL PROTECTED] wrote:
> From: Ingo Molnar <[EMAIL PROTECTED]>
>
> add pid_max prototype - now used by sysctl and kgdb as well.
extern should never be in .c files, so this should be submitted now,
even independent of kgdb.
--
To unsubscribe from this l
On Sat, Feb 09, 2008 at 07:35:06AM -0600, [EMAIL PROTECTED] wrote:
> Per reqest on lkml, here are the individual kgdb patches
> targeted at 2.6.25.
>
> The kgdb tree has been collapsed review. It includes
> the kgdb core, the x86 arch, the kgdb8250 uart driver
> and the kgdb console sharing drive
On Sun, Feb 10, 2008 at 01:10:07AM +0100, Ondrej Zary wrote:
> > > +typedef enum { EL3_ISA, EL3_PNP, EL3_MCA, EL3_EISA } el3_cardtype;
> > > +
> >
> > No typedef please (see checkpatch)
>
> Is there any standard way to solve this without a typedef? I added
> el3_dev_fill() function which fills th
On Sun, Feb 10, 2008 at 12:38:11AM +0100, Sven Wegener wrote:
> struct ip_vs_sync_thread_data {
> - struct completion *startup;
> + struct completion *startup; /* set to NULL once completed */
This is not needed anmore. kthread_run guarantees that the newly
creates thread is run before r
On Sat, Feb 09, 2008 at 09:42:59PM +0100, Ingo Molnar wrote:
> Linus,
>
> while this is probably one of the last days of the merge window, please
> still consider pulling the "kgdb light" git tree from:
>
>git://git.kernel.org/pub/scm/linux/kernel/git/mingo/linux-2.6-kgdb.git
Without postin
Folks, moving this call around hidden behing in completely unreviewed
acpi junk is not acceptable.
Either populate_rootfs _is_ safe to be called earlier and then we should
do it always or it's not. Either way such a change should be posted
separately and reviewd on lkml.
Len, can you please reve
On Sun, Feb 10, 2008 at 08:12:26AM +0100, Christoph Hellwig wrote:
> Folks, moving this call around hidden behing in completely unreviewed
> acpi junk is not acceptable.
>
> Either populate_rootfs _is_ safe to be called earlier and then we should
> do it always or it's not
On Sun, Feb 10, 2008 at 08:13:21AM +0100, Ingo Molnar wrote:
> From: Ingo Molnar <[EMAIL PROTECTED]>
>
> add pid_max prototype - used by sysctl and will be used by kgdb as well.
Looks good, and this should go in ASAP independent of kgdb.
And while you're at it, I think all of the below want to f
This still doesn't address a lot of the review comments from Jason's
last posting.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at htt
On Sun, Feb 10, 2008 at 08:43:52AM +0100, Ingo Molnar wrote:
>
> * Christoph Hellwig <[EMAIL PROTECTED]> wrote:
>
> > This still doesn't address a lot of the review comments from Jason's
> > last posting.
>
> sorry, which mails are those?
It's a
On Sun, Feb 10, 2008 at 09:02:25AM +0100, Ingo Molnar wrote:
> thanks - i found Sam's mail meanwhile and addressed most of the
> observations and updated the kgdb.git tree. I'll now check the threads
> above whether i missed anything. (feel free to point it out if you
> notice anything outright)
On Sun, Feb 10, 2008 at 09:21:32AM +0100, Ingo Molnar wrote:
> > Kerneldoc comments don't belong above the prototype of a function but
> > the function body.
>
> disagree - the best is to have it in both places - and in many places we
> do that. Anyway, this is up to maintainer discretion.
Huh?
On Sun, Feb 10, 2008 at 09:57:35AM +0100, Ingo Molnar wrote:
> > It would be nice if you could move the kerneldoc comments to the
> > proper place at least. [...]
>
> i'd agree in general but this is really a special case, please look at
> the context. This would duplicate all the kerneldoc head
> +#ifdef UART_CAP_UUE
> + if (up->capabilities & UART_CAP_UUE)
> +#else
> + if (up->port.type == PORT_XSCALE)
> +#endif
This looks very odd. Can anyone explain what's going on here?
Especially as UART_CAP_UUE is defined in drivers/serial/8250.h
unconditionally.
> diff --git a/drivers/se
On Sun, Feb 10, 2008 at 10:27:28AM +0100, Ingo Molnar wrote:
> > The one I noticed quickly is the __ASSEMBLY__ removal from
> > asm-x86/kgdb.h. [...]
>
> people might want to experiment with early debug code as well and
> include asm-x86/kgdb.h in assembly files. So i kept that, it's sensible.
June has been a pretty slow month for XFS in Linus tree, as June saw the
stabilization of the Linux 3.5 and thus only a handful of important XFS
fixes. Development of the tree destined for the next merge window has been
a bit more busy with the addition of discontinuous buffers that replace the
da
On Wed, Jul 25, 2012 at 08:31:10AM +1000, Dave Chinner wrote:
> FWIW, if you are going to change generic code, you need to present
> results for other filesystems as well (xfs, btrfs are typical), as
> they may not have the same problems as ext4 or react the same way to
> your change. The result mi
On Fri, Aug 17, 2012 at 09:15:58AM -0400, Theodore Ts'o wrote:
> Thanks Fengguang:
>
> For the record, I was able to find my own easy repro, last night using
> only a 220 meg partition:
>
> # mke2fs -t ext4 -b 1024 -J size=1 /dev/vdc
> # mount -t ext2 /dev/vdc /vdc
> # mkdir /vdc/a
> # cd /vdc/a
On Mon, Aug 20, 2012 at 09:57:39AM -0400, Mike Snitzer wrote:
> But I haven't put my finger on _why_ a discard bio has bio->bi_io_vec
> (but given my use of DM, bio comes from bio_alloc_bioset, and DM passes
> original bio->bi_max_vecs for nr_iovecs).
TRIM has a payload and we cheay by preallocati
On Mon, Aug 20, 2012 at 10:12:29AM -0400, Mike Snitzer wrote:
> Thought we pushed that down? Hence sd_setup_discard_cmnd's
> alloc_page + blk_add_request_payload hack.
Yeah, but we still need the bio_vec from early on, as it's allocated as
part of the bio.
--
To unsubscribe from this list: send t
On Thu, Oct 11, 2012 at 11:32:27AM -0500, ? Yang Su Li wrote:
> I am not quite whether I should ask this question here, but in terms
> of light weight barrier/fsync, could anyone tell me why the device
> driver / OS provide the barrier interface other than some other
> abstractions anyway?
On Fri, Oct 12, 2012 at 02:34:33PM +0300, Pekka Enberg wrote:
> Hi Linus,
>
> Please consider pulling the latest LKVM tree from:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/penberg/linux.git
> kvmtool/for-linus
>
> LKVM is the long lost userspace friend of KVM that makes it really easy
On Sat, Oct 13, 2012 at 08:51:28AM +0100, Al Viro wrote:
> It's somewhat pointless on its own... If you were doing something with
> the callers afterwards - sure, it would be make sense, but as it is...
I'd really like to see ->truncate and vmtruncate done, so from that side
I'm absolutely in fav
On Sat, Oct 13, 2012 at 05:01:15PM +0100, Al Viro wrote:
> You know, I'm in the middle of dealing with one such TODO. Yours, as it
> were. From six years ago. kernel_thread() unexporting. TODO comments
> of any form are routinely shat upon and ignored, especially when shuffled
> away into less
> @@ -536,8 +536,9 @@ static int ufs_write_begin(struct file *file, struct
> address_space *mapping,
> ufs_getfrag_block);
> if (unlikely(ret)) {
> loff_t isize = mapping->host->i_size;
> - if (pos + len > isize)
> -
101 - 200 of 14612 matches
Mail list logo
