Re: [PATCH v3 07/12] KVM: arm/arm64: Adapt vgic_v3_check_base to multiple rdist regions

2018-04-24 Thread Christoffer Dall
On Fri, Apr 13, 2018 at 10:20:53AM +0200, Eric Auger wrote: > We introduce a new helper to check there is no overlap between > dist region (if set) and registered rdist regions. This both > handles the case of legacy single rdist region (implicitly sized > with the number of online vcpus) and the n

Re: [PATCH v3 10/12] KVM: arm/arm64: Add KVM_VGIC_V3_ADDR_TYPE_REDIST_REGION

2018-04-24 Thread Christoffer Dall
_VGIC_V3_ADDR_TYPE_DIST 2 > +#define KVM_VGIC_V3_ADDR_TYPE_REDIST 3 > +#define KVM_VGIC_ITS_ADDR_TYPE 4 > +#define KVM_VGIC_V3_ADDR_TYPE_REDIST_REGION 5 > > #define KVM_VGIC_V3_DIST_SIZESZ_64K > #define KVM_VGIC_V3_REDIST_SIZE (2 * SZ_64K) > -- > 2.5.5 > Otherwise: Acked-by: Christoffer Dall

Re: [PATCH v3 09/12] KVM: arm/arm64: Check all vcpu redistributors are set on map_resources

2018-04-24 Thread Christoffer Dall
On Fri, Apr 13, 2018 at 10:20:55AM +0200, Eric Auger wrote: > On vcpu first run, we eventually know the actual number of vcpus. > This is a synchronization point to check all redistributors regions > were assigned. Isn't it the other way around? We want to check that all redistributors (one for e

Re: [PATCH v3 02/12] KVM: arm/arm64: Document KVM_VGIC_V3_ADDR_TYPE_REDIST_REGION

2018-04-24 Thread Christoffer Dall
On Tue, Apr 24, 2018 at 05:50:37PM +0100, Peter Maydell wrote: > On 24 April 2018 at 17:46, Christoffer Dall wrote: > > On Fri, Apr 13, 2018 at 10:20:48AM +0200, Eric Auger wrote: > >> --- a/Documentation/virtual/kvm/devices/arm-vgic-v3.txt > >> +++ b/Documentation/virt

Re: [PATCH v3 06/12] KVM: arm/arm64: Helper to register a new redistributor region

2018-04-26 Thread Christoffer Dall
On Thu, Apr 26, 2018 at 09:32:49AM +0200, Auger Eric wrote: > Hi Christoffer, > > On 04/24/2018 06:47 PM, Christoffer Dall wrote: > > On Fri, Apr 13, 2018 at 10:20:52AM +0200, Eric Auger wrote: > >> We introduce a new helper that creates and inserts a new redistributor &g

Re: [PATCH v3 07/12] KVM: arm/arm64: Adapt vgic_v3_check_base to multiple rdist regions

2018-04-26 Thread Christoffer Dall
On Thu, Apr 26, 2018 at 10:29:35AM +0200, Auger Eric wrote: > Hi Christoffer, > On 04/24/2018 11:07 PM, Christoffer Dall wrote: > > On Fri, Apr 13, 2018 at 10:20:53AM +0200, Eric Auger wrote: > >> We introduce a new helper to check there is no overlap between > >

Re: [PATCH v3 08/12] KVM: arm/arm64: Check vcpu redist base before registering an iodev

2018-04-26 Thread Christoffer Dall
On Thu, Apr 26, 2018 at 11:25:06AM +0200, Auger Eric wrote: > Hi Christoffer, > > On 04/24/2018 11:07 PM, Christoffer Dall wrote: > > On Fri, Apr 13, 2018 at 10:20:54AM +0200, Eric Auger wrote: > >> As we are going to register several redist regions, > >> vgic_re

Re: [PATCH v3 09/12] KVM: arm/arm64: Check all vcpu redistributors are set on map_resources

2018-04-26 Thread Christoffer Dall
On Thu, Apr 26, 2018 at 11:56:10AM +0200, Auger Eric wrote: > > > On 04/24/2018 11:08 PM, Christoffer Dall wrote: > > On Fri, Apr 13, 2018 at 10:20:55AM +0200, Eric Auger wrote: > >> On vcpu first run, we eventually know the actual number of vcpus. > >> This is

Re: [PATCH 0/3] KVM: arm/arm64: trivial header path sanitization

2019-01-25 Thread Christoffer Dall
f this work, > the full patch set is available at: > > git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.git > build-test Changes appear fine to me: Acked-by: Christoffer Dall

Re: [PATCH v3 10/52] arm, kvm: Fix CPU hotplug callback registration

2014-03-12 Thread Christoffer Dall
se of the double underscored version of the API */ > __register_cpu_notifier(&foobar_cpu_notifier); > > cpu_notifier_register_done(); > > > Fix the kvm code in arm by using this latter form of callback registration. > > Cc: Christoffer Dall > Cc: Gleb N

Re: [PATCH v3 10/52] arm, kvm: Fix CPU hotplug callback registration

2014-03-14 Thread Christoffer Dall
On Fri, Mar 14, 2014 at 11:13:29AM +0530, Srivatsa S. Bhat wrote: > On 03/13/2014 04:51 AM, Christoffer Dall wrote: > > On Tue, Mar 11, 2014 at 02:05:38AM +0530, Srivatsa S. Bhat wrote: > >> Subsystems that want to register CPU hotplug callbacks, as well as perform > >>

Re: [UPDATED PATCH v3 10/52] arm, kvm: Fix CPU hotplug callback registration

2014-03-18 Thread Christoffer Dall
On 18 March 2014 03:23, Srivatsa S. Bhat wrote: > On 03/15/2014 12:40 AM, Christoffer Dall wrote: >> On Fri, Mar 14, 2014 at 11:13:29AM +0530, Srivatsa S. Bhat wrote: >>> On 03/13/2014 04:51 AM, Christoffer Dall wrote: >>>> On Tue, Mar 11, 2014 at 02:05:38AM

Re: [RFC PATCH] PCI: Introduce new device binding path using pci_dev.driver_override

2014-04-01 Thread Christoffer Dall
On Tue, Apr 01, 2014 at 11:15:40AM -0600, Alex Williamson wrote: > On Tue, 2014-04-01 at 09:47 -0700, Greg KH wrote: > > On Tue, Apr 01, 2014 at 10:28:54AM -0600, Alex Williamson wrote: > > > The driver_override field allows us to specify the driver for a device > > > rather than relying on the dri

Re: [PATCH] ARM: KVM: Handle IPA unmapping on memory region deletion

2014-04-03 Thread Christoffer Dall
On 3 April 2014 08:26, Marc Zyngier wrote: > Hi Eric, > > On 03/04/14 16:17, Eric Auger wrote: >> Currently when a KVM region is removed using >> kvm_vm_ioctl_set_memory_region (with memory region size equal to 0), the >> corresponding intermediate physical memory is not unmapped. >> >> This patch

Re: linux-next: manual merge of the kvm-arm tree

2013-10-16 Thread Christoffer Dall
On 16 October 2013 11:58, Marc Zyngier wrote: > On 16/10/13 19:51, Thierry Reding wrote: >> Today's linux-next merge of the kvm-arm tree got conflicts in >> >> arch/arm/kvm/reset.c >> >> caused by commits e8c2d99 (KVM: ARM: Add support for Cortex-A7) and ac570e0 >> (ARM: kvm: rename cpu_rese

Re: linux-next: manual merge of the kvm-arm tree

2013-10-16 Thread Christoffer Dall
On 16 October 2013 12:04, Thierry Reding wrote: > On Wed, Oct 16, 2013 at 12:02:08PM -0700, Christoffer Dall wrote: >> On 16 October 2013 11:58, Marc Zyngier wrote: >> > On 16/10/13 19:51, Thierry Reding wrote: >> >> Today's linux-next merge o

Re: linux-next: manual merge of the kvm-arm tree

2013-10-17 Thread Christoffer Dall
On 17 October 2013 07:55, Gleb Natapov wrote: > On Wed, Oct 16, 2013 at 12:02:08PM -0700, Christoffer Dall wrote: >> On 16 October 2013 11:58, Marc Zyngier wrote: >> > On 16/10/13 19:51, Thierry Reding wrote: >> >> Today's linux-next merge o

Re: linux-next: manual merge of the kvm-arm tree with Linus' tree

2014-07-31 Thread Christoffer Dall
On Thu, Jul 31, 2014 at 01:15:40PM +0100, Marc Zyngier wrote: > On Thu, Jul 31 2014 at 12:53:03 pm BST, Christoffer Dall > wrote: > > Hi Christoffer, > > > On Thu, Jul 31, 2014 at 8:30 AM, Stephen Rothwell > > wrote: > > > > Hi all, > > &g

Re: [PATCH] arm64: KVM: export current vcpu->pause state via pseudo regs

2014-07-31 Thread Christoffer Dall
On Wed, Jul 09, 2014 at 02:55:12PM +0100, Alex Bennée wrote: > To cleanly restore an SMP VM we need to ensure that the current pause > state of each vcpu is correctly recorded. Things could get confused if > the CPU starts running after migration restore completes when it was > paused before it sta

Re: [PATCH] arm64: KVM: export current vcpu->pause state via pseudo regs

2014-07-31 Thread Christoffer Dall
On Thu, Jul 31, 2014 at 04:14:51PM +0100, Alex Bennée wrote: > > Christoffer Dall writes: > > > On Wed, Jul 09, 2014 at 02:55:12PM +0100, Alex Bennée wrote: > >> To cleanly restore an SMP VM we need to ensure that the current pause > >> state of each vcpu is cor

Re: [PATCH] arm64: KVM: export current vcpu->pause state via pseudo regs

2014-07-31 Thread Christoffer Dall
On Thu, Jul 31, 2014 at 05:45:28PM +0100, Peter Maydell wrote: > On 31 July 2014 17:38, Christoffer Dall wrote: > >> > If we are not complaining when setting the pause value to false if it > >> > was true before, then we probably also need to wake up the thread in >

Re: [PATCH v3] ARM: KVM: add irqfd support

2014-09-18 Thread Christoffer Dall
On Thu, Sep 11, 2014 at 07:03:32PM +0200, Christoffer Dall wrote: > On Thu, Sep 11, 2014 at 10:14:13AM +0200, Eric Auger wrote: > > On 09/11/2014 05:09 AM, Christoffer Dall wrote: > > > On Mon, Sep 01, 2014 at 10:53:04AM +0200, Eric Auger wrote: > > >> T

Re: linux-next: build failure after merge of the kvm-arm tree

2014-09-24 Thread Christoffer Dall
On Wed, Sep 24, 2014 at 04:50:30PM +1000, Stephen Rothwell wrote: > Hi all, > > On Mon, 22 Sep 2014 14:06:45 +1000 Stephen Rothwell > wrote: > > > > Hi all, > > > > After merging the kvm-arm tree, today's linux-next build (x86_64 > > allmodconfig) > > failed like this: > > > > arch/x86/kvm/..

Re: [PATCH] KVM: EVENTFD: remove inclusion of irq.h

2014-09-10 Thread Christoffer Dall
On Mon, Sep 01, 2014 at 12:11:19PM +0200, Paolo Bonzini wrote: > Il 01/09/2014 10:36, Eric Auger ha scritto: > > No more needed. irq.h would be void on ARM. > > > > Signed-off-by: Eric Auger > > > > --- > > > > I don't think irq.h is needed anymore since Paul Mackerras' work. However > > I did

Re: [RFC v2 1/9] KVM: ARM: VGIC: fix multiple injection of level sensitive forwarded IRQ

2014-09-10 Thread Christoffer Dall
On Mon, Sep 01, 2014 at 02:52:40PM +0200, Eric Auger wrote: > Fix multiple injection of level sensitive forwarded IRQs. > With current code, the second injection fails since the state bitmaps > are not reset (process_maintenance is not called anymore). > New implementation consists in fully bypassi

Re: [PATCH v3] ARM: KVM: add irqfd support

2014-09-10 Thread Christoffer Dall
On Mon, Sep 01, 2014 at 10:53:04AM +0200, Eric Auger wrote: > This patch enables irqfd on ARM. > > irqfd framework enables to inject a virtual IRQ into a guest upon an > eventfd trigger. User-side uses KVM_IRQFD VM ioctl to provide KVM with > a kvm_irqfd struct that associates a VM, an eventfd, a

Re: [RFC v2 5/9] KVM: KVM-VFIO: update user API to program forwarded IRQ

2014-09-10 Thread Christoffer Dall
On Mon, Sep 01, 2014 at 02:52:44PM +0200, Eric Auger wrote: > add new device group commands: > - KVM_DEV_VFIO_DEVICE_FORWARD_IRQ and > KVM_DEV_VFIO_DEVICE_UNFORWARD_IRQ > > which enable to turn forwarded IRQ mode on/off. > > the kvm_arch_forwarded_irq struct embodies a forwarded IRQ > > Signed

Re: [RFC v2 2/9] KVM: ARM: VGIC: add forwarded irq rbtree lock

2014-09-10 Thread Christoffer Dall
On Mon, Sep 01, 2014 at 02:52:41PM +0200, Eric Auger wrote: > add a lock related to the rb tree manipulation. The rb tree can be Ok, I can't hold myself back any longer. Please begin sentences with a capital letter. You don't do this in French? :) > searched in one thread (irqfd handler for inst

Re: [RFC v2 6/9] VFIO: Extend external user API

2014-09-10 Thread Christoffer Dall
On Mon, Sep 01, 2014 at 02:52:45PM +0200, Eric Auger wrote: > New functions are added to be called from ARM KVM-VFIO device. This commit message seems somewhat random. This patch doesn't deal with anything ARM specific, it introduces some generic functions that allows users external to vfio itsel

Re: [RFC v2 7/9] KVM: KVM-VFIO: add new VFIO external API hooks

2014-09-10 Thread Christoffer Dall
On Mon, Sep 01, 2014 at 02:52:46PM +0200, Eric Auger wrote: > add functions that implement the gateway to the extended Capital letter when beginning a new sentence. Also the reference to 'the extended VFIO API' feels a bit weird. Can't you make your commit message a little more descriptive of th

Re: [RFC v2 9/9] KVM: KVM-VFIO: ARM forwarding control

2014-09-10 Thread Christoffer Dall
On Mon, Sep 01, 2014 at 02:52:48PM +0200, Eric Auger wrote: > Enables forwarding control for ARM. By defining > __KVM_HAVE_ARCH_KVM_VFIO_FORWARD the patch enables > KVM_DEV_VFIO_DEVICE_FORWARD/UNFORWARD_IRQ command on ARM. As a > result it brings an optimized injection/completion handling for > for

Re: [RFC v2 8/9] KVM: KVM-VFIO: generic KVM_DEV_VFIO_DEVICE command and IRQ forwarding control

2014-09-10 Thread Christoffer Dall
On Mon, Sep 01, 2014 at 02:52:47PM +0200, Eric Auger wrote: > This patch introduces a new KVM_DEV_VFIO_DEVICE attribute. > > This is a new control channel which enables KVM to cooperate with > viable VFIO devices. > > The kvm-vfio device now holds a list of devices (kvm_vfio_device) > in addition

Re: [RFC v2 0/9] KVM-VFIO IRQ forward control

2014-09-10 Thread Christoffer Dall
On Tue, Sep 02, 2014 at 03:05:41PM -0600, Alex Williamson wrote: > On Mon, 2014-09-01 at 14:52 +0200, Eric Auger wrote: > > This RFC proposes an integration of "ARM: Forwarding physical > > interrupts to a guest VM" (http://lwn.net/Articles/603514/) in > > KVM. > > > > It enables to transform a VF

Re: [RFC v2 4/9] VFIO: platform: handler tests whether the IRQ is forwarded

2014-09-10 Thread Christoffer Dall
On Mon, Sep 01, 2014 at 02:52:43PM +0200, Eric Auger wrote: > In case the IRQ is forwarded, the VFIO platform IRQ handler does not > need to disable the IRQ anymore. In that mode, when the handler completes add a comma after completes > the IRQ is not deactivated but only its priority is lowered.

Re: [PATCH v3] ARM: KVM: add irqfd support

2014-09-11 Thread Christoffer Dall
On Thu, Sep 11, 2014 at 10:14:13AM +0200, Eric Auger wrote: > On 09/11/2014 05:09 AM, Christoffer Dall wrote: > > On Mon, Sep 01, 2014 at 10:53:04AM +0200, Eric Auger wrote: > >> This patch enables irqfd on ARM. > >> > >> irqfd framework enables to injec

Re: [RFC v2 4/9] VFIO: platform: handler tests whether the IRQ is forwarded

2014-09-11 Thread Christoffer Dall
On Thu, Sep 11, 2014 at 10:44:02AM +0200, Eric Auger wrote: > On 09/11/2014 05:10 AM, Christoffer Dall wrote: > > On Mon, Sep 01, 2014 at 02:52:43PM +0200, Eric Auger wrote: > >> In case the IRQ is forwarded, the VFIO platform IRQ handler does not > >> need to disable th

Re: [RFC v2 5/9] KVM: KVM-VFIO: update user API to program forwarded IRQ

2014-09-11 Thread Christoffer Dall
On Thu, Sep 11, 2014 at 10:49:08AM +0200, Eric Auger wrote: > On 09/11/2014 05:10 AM, Christoffer Dall wrote: > > On Mon, Sep 01, 2014 at 02:52:44PM +0200, Eric Auger wrote: [...] > >> + > >> +It is up to the caller of this API to make sure the IRQ is not > &g

Re: [RFC v2 8/9] KVM: KVM-VFIO: generic KVM_DEV_VFIO_DEVICE command and IRQ forwarding control

2014-09-11 Thread Christoffer Dall
On Wed, Sep 10, 2014 at 11:05:49PM -0600, Alex Williamson wrote: > On Thu, 2014-09-11 at 05:10 +0200, Christoffer Dall wrote: > > On Mon, Sep 01, 2014 at 02:52:47PM +0200, Eric Auger wrote: [...] > > > > > > +#ifdef __KVM_HAVE_ARCH_KVM_VFIO_FORWARD > > >

Re: [RFC v2 8/9] KVM: KVM-VFIO: generic KVM_DEV_VFIO_DEVICE command and IRQ forwarding control

2014-09-11 Thread Christoffer Dall
On Thu, Sep 11, 2014 at 02:04:39PM +0200, Eric Auger wrote: > On 09/11/2014 07:05 AM, Alex Williamson wrote: > > On Thu, 2014-09-11 at 05:10 +0200, Christoffer Dall wrote: > >> On Mon, Sep 01, 2014 at 02:52:47PM +0200, Eric Auger wrote: > >>> This patch introd

Re: [RFC v2 8/9] KVM: KVM-VFIO: generic KVM_DEV_VFIO_DEVICE command and IRQ forwarding control

2014-09-11 Thread Christoffer Dall
On Thu, Sep 11, 2014 at 09:59:24AM -0600, Alex Williamson wrote: > On Thu, 2014-09-11 at 14:04 +0200, Eric Auger wrote: > > On 09/11/2014 07:05 AM, Alex Williamson wrote: > > > On Thu, 2014-09-11 at 05:10 +0200, Christoffer Dall wrote: > > >> On Mon, Sep 01, 2014 a

Re: [RFC v2 8/9] KVM: KVM-VFIO: generic KVM_DEV_VFIO_DEVICE command and IRQ forwarding control

2014-09-11 Thread Christoffer Dall
On Thu, Sep 11, 2014 at 11:35:56AM +0200, Eric Auger wrote: > On 09/11/2014 05:10 AM, Christoffer Dall wrote: > > On Mon, Sep 01, 2014 at 02:52:47PM +0200, Eric Auger wrote: [...] > >> + if (!pfwd) > >> + return -ENOMEM; > >> + pfwd->index = fwd_

Re: [RFC v2 8/9] KVM: KVM-VFIO: generic KVM_DEV_VFIO_DEVICE command and IRQ forwarding control

2014-09-11 Thread Christoffer Dall
On Thu, Sep 11, 2014 at 12:14:10PM -0600, Alex Williamson wrote: > On Thu, 2014-09-11 at 19:10 +0200, Christoffer Dall wrote: > > On Wed, Sep 10, 2014 at 11:05:49PM -0600, Alex Williamson wrote: > > > On Thu, 2014-09-11 at 05:10 +0200, Christoffer Dall wrote: > > > >

Re: [RFC v2 1/9] KVM: ARM: VGIC: fix multiple injection of level sensitive forwarded IRQ

2014-09-11 Thread Christoffer Dall
On Thu, Sep 11, 2014 at 08:17:49PM +0200, Eric Auger wrote: > On 09/11/2014 05:09 AM, Christoffer Dall wrote: > > On Mon, Sep 01, 2014 at 02:52:40PM +0200, Eric Auger wrote: > >> Fix multiple injection of level sensitive forwarded IRQs. > >> With current code, the secon

Re: [PATCH 1/2] KVM: document KVM_SET_GUEST_DEBUG api

2014-09-11 Thread Christoffer Dall
On Tue, Sep 09, 2014 at 05:27:18PM +0100, Alex Bennée wrote: > In preparation for working on the ARM implementation I noticed the debug > interface was missing from the API document. I've pieced together the > expected behaviour from the code and commit messages written it up as > best I can. > >

Re: [PATCH v5 3/6] arm64: Add a description on 48-bit address space with 4KB pages

2014-05-01 Thread Christoffer Dall
On Thu, May 01, 2014 at 11:34:05AM +0900, Jungseok Lee wrote: > This patch adds memory layout and translation lookup information > about 48-bit address space with 4K pages. The description is based > on 4 levels of translation tables. > > Cc: Catalin Marinas > Cc: Steve Capper > Signed-off-by: J

Re: [PATCH v5 2/6] arm64: Introduce VA_BITS and translation level options

2014-05-01 Thread Christoffer Dall
> #define pmd_index(addr) (((addr) >> PMD_SHIFT) & (PTRS_PER_PMD > - 1)) > static inline pmd_t *pmd_offset(pud_t *pud, unsigned long addr) > { > diff --git a/arch/arm64/include/asm/tlb.h b/arch/arm64/include/asm/tlb.h > index 80e2c08..bc19101 100644 > --- a/arch/arm64/include/asm/tlb.h > +++ b/arch/arm64/include/asm/tlb.h > @@ -91,7 +91,7 @@ static inline void __pte_free_tlb(struct mmu_gather *tlb, > pgtable_t pte, > tlb_remove_page(tlb, pte); > } > > -#ifndef CONFIG_ARM64_64K_PAGES > +#ifndef CONFIG_ARM64_2_LEVELS > static inline void __pmd_free_tlb(struct mmu_gather *tlb, pmd_t *pmdp, > unsigned long addr) > { > -- > 1.7.10.4 > > Otherwise looks good, Reviewed-by: Christoffer Dall -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v5 2/6] arm64: Introduce VA_BITS and translation level options

2014-05-02 Thread Christoffer Dall
On Fri, May 02, 2014 at 10:57:09AM +0900, Jungseok Lee wrote: > On Thursday, May 01, 2014 7:06 PM, Christoffer Dall wrote: > > On Thu, May 01, 2014 at 11:33:56AM +0900, Jungseok Lee wrote: [...] > > > + > > > +choice > > > + prompt "Virtual address space

Re: [PATCH 19/19] Documentation: ACPI for ARM64

2014-07-29 Thread Christoffer Dall
On Thu, Jul 24, 2014 at 02:19:14PM -0700, Randy Dunlap wrote: > On 07/24/2014 02:16 PM, Naresh Bhat wrote: > > > > On 24 July 2014 18:30, Hanjun Guo > > wrote: > > > > From: Graeme Gregory > > > > > > Add documentation for

Re: [PATCH 19/19] Documentation: ACPI for ARM64

2014-07-29 Thread Christoffer Dall
On Thu, Jul 24, 2014 at 09:00:25PM +0800, Hanjun Guo wrote: > From: Graeme Gregory > > Add documentation for the guidelines of how to use ACPI > on ARM64. > > Signed-off-by: Graeme Gregory > Signed-off-by: Hanjun Guo > --- > Documentation/arm64/arm-acpi.txt | 240 > +

Re: [PATCH 2/2 v2] ARM: KVM: user_mem_abort: support stage 2 MMIO page mapping

2014-06-30 Thread Christoffer Dall
passthrough support in QEMU. > > > > During early development, we found the PAGE_S2 memory type being used > > for MMIO mappings. This patch corrects that by using the more strongly > > ordered memory type for device MMIO mappings: PAGE_S2_DEVICE. > > > > Signed-off-b

Re: [PATCH] arm64: KVM: export demux regids as KVM_REG_ARM64

2014-07-04 Thread Christoffer Dall
ementation kvm_arm_get_reg() returns -EINVAL and hilarity ensues. > > > > The kvm/api.txt document describes all arm64 registers as starting with > > 0x60xx... (i.e KVM_REG_ARM64). > > > > Signed-off-by: Alex Bennée > > Acked-by: Christoffer Dall > > --- &g

Re: [PATCH] arm64: KVM: allow export and import of generic timer regs

2014-07-07 Thread Christoffer Dall
s. > However I have re-jigged the kvm_arm_timer_set/get_reg declarations to > be in the common include/kvm/arm_arch_timer.h headers. > > Signed-off-by: Alex Bennée Reviewed-by: Christoffer Dall -- To unsubscribe from this list: send the line "unsubscribe linux-kernel"

Re: [PATCH v2] ARM: KVM: Unmap IPA on memslot delete/move

2014-06-05 Thread Christoffer Dall
, > +struct kvm_memory_slot *dont) > +{ > +} > + > +int kvm_arch_create_memslot(struct kvm *kvm, struct kvm_memory_slot *slot, > + unsigned long npages) > +{ > + return 0; > +} > + > +void kvm_arch_memslots_updated(struct kvm *kvm) > +{ &

Re: [PATCH v2] ARM: KVM: add irqfd and irq routing support

2014-06-05 Thread Christoffer Dall
On Thu, Jun 05, 2014 at 03:15:15PM +0200, Eric Auger wrote: > On 06/05/2014 12:28 PM, Christoffer Dall wrote: > > On Mon, Jun 02, 2014 at 09:29:56AM +0200, Eric Auger wrote: > >> This patch enables irqfd and irq routing on ARM. > >> > >> It

Re: [PATCH v2] ARM: KVM: add irqfd and irq routing support

2014-06-05 Thread Christoffer Dall
On Thu, Jun 05, 2014 at 05:58:02PM +0200, Eric Auger wrote: > On 06/05/2014 04:39 PM, Christoffer Dall wrote: > > On Thu, Jun 05, 2014 at 03:15:15PM +0200, Eric Auger wrote: > >> On 06/05/2014 12:28 PM, Christoffer Dall wrote: > >>> On Mon, Jun 02, 2014 at 09:2

Re: [PATCH v3] ARM: KVM: Unmap IPA on memslot delete/move

2014-06-06 Thread Christoffer Dall
On Fri, Jun 06, 2014 at 11:10:23AM +0200, Eric Auger wrote: > Currently when a KVM region is deleted or moved after > KVM_SET_USER_MEMORY_REGION ioctl, the corresponding > intermediate physical memory is not unmapped. > > This patch corrects this and unmaps the region's IPA range > in kvm_arch_com

Re: [PATCH v2] ARM: KVM: add irqfd and irq routing support

2014-06-06 Thread Christoffer Dall
On Mon, Jun 02, 2014 at 02:54:12PM +0100, Marc Zyngier wrote: > Hi Eric, > > On Mon, Jun 02 2014 at 8:29:56 am BST, Eric Auger > wrote: > > This patch enables irqfd and irq routing on ARM. > > > > It turns on CONFIG_HAVE_KVM_EVENTFD and CONFIG_HAVE_KVM_IRQ_ROUTING > > > > irqfd framework enable

Re: [PATCH v2] ARM: KVM: add irqfd and irq routing support

2014-06-06 Thread Christoffer Dall
On Thu, Jun 05, 2014 at 12:37:36PM +0200, Christoffer Dall wrote: > On Mon, Jun 02, 2014 at 04:42:36PM +0200, Eric Auger wrote: > > On 06/02/2014 03:54 PM, Marc Zyngier wrote: > > > Hi Eric, > > > > > > On Mon, Jun 02 2014 at 8:29

Re: [RFC PATCH v6 14/20] vfio/platform: initial interrupts support

2014-06-08 Thread Christoffer Dall
On Thu, Jun 05, 2014 at 07:03:22PM +0200, Antonios Motakis wrote: > This patch allows to set an eventfd for a patform device's interrupt, > and also to trigger the interrupt eventfd from userspace for testing. > > Signed-off-by: Antonios Motakis > --- > drivers/vfio/platform/vfio_platform.c

Re: [RFC PATCH v6 15/20] vfio/platform: support for maskable and automasked interrupts

2014-06-08 Thread Christoffer Dall
On Thu, Jun 05, 2014 at 07:03:23PM +0200, Antonios Motakis wrote: > Adds support to mask interrupts, and also for automasked interrupts. > Level sensitive interrupts are exposed as automasked interrupts and > are masked and disabled automatically when they fire. > > Signed-off-by: Antonios Motakis

Re: [RFC PATCH v6 04/20] iommu/arm-smmu: add capability IOMMU_CAP_INTR_REMAP

2014-06-08 Thread Christoffer Dall
On Thu, Jun 05, 2014 at 07:03:12PM +0200, Antonios Motakis wrote: > With an ARM SMMU, interrupt remapping should always be safe from the > SMMU's point of view, as it is properly handled by the GIC. > > Signed-off-by: Antonios Motakis > --- > drivers/iommu/arm-smmu.c | 2 +- > 1 file changed, 1

Re: [RFC PATCH 1/4] ARM: KVM: on unhandled IO mem abort, route the call to the KVM MMIO bus

2014-03-28 Thread Christoffer Dall
On Thu, Mar 13, 2014 at 04:57:26PM +0100, Antonios Motakis wrote: > On an unhandled IO memory abort, use the kvm_io_bus_* API in order to > handle the MMIO access through any registered read/write callbacks. This > is a dependency for eventfd support (ioeventfd and irqfd). > > However, accesses to

Re: [PATCH] arm: KVM: fix possible misalignment of PGDs and bounce page

2014-03-28 Thread Christoffer Dall
err = -ENOMEM; > -- > 1.8.5.3 > This looks right to me. Funnily enough I seem to remember a discussion from when we originally merged this code where someone (maybe me) argued that kmalloc() would align to the size of the allocation, but I don't see anything bac

Re: [RFC 0/5] of: Automatic console registration cleanups

2014-03-28 Thread Christoffer Dall
On Fri, Mar 28, 2014 at 02:19:23PM -0500, Rob Herring wrote: > On Fri, Mar 28, 2014 at 1:56 PM, Olof Johansson wrote: > > On Fri, Mar 28, 2014 at 09:08:00AM -0700, Grant Likely wrote: > >> Hi all, > >> > >> This is a series that I've been playing with over the last few days to > >> clean up the se

Re: [PATCH v6 6/7] arm64: KVM: Set physical address size related factors in runtime

2014-05-27 Thread Christoffer Dall
but I want to leave this open for comments... > > Cc: Marc Zyngier > Cc: Christoffer Dall > Signed-off-by: Jungseok Lee > Reviewed-by: Sungjinn Chung > --- > arch/arm/kvm/arm.c | 82 > +- > arch/arm64/include/as

Re: [PATCH v6 6/7] arm64: KVM: Set physical address size related factors in runtime

2014-05-27 Thread Christoffer Dall
On Tue, May 27, 2014 at 03:53:49PM +0200, Christoffer Dall wrote: > On Mon, May 12, 2014 at 06:40:54PM +0900, Jungseok Lee wrote: > > This patch sets TCR_EL2.PS, VTCR_EL2.T0SZ and vttbr_baddr_mask in runtime, > > not compile time. > > > > In ARMv8, EL2 physical ad

Re: [RESEND PATCH v6 7/7] arm64: KVM: Implement 4 levels of translation tables for HYP and stage2

2014-05-27 Thread Christoffer Dall
uest on 64KB + 2 levels host > > Cc: Marc Zyngier > Cc: Christoffer Dall > Signed-off-by: Jungseok Lee > Reviewed-by: Sungjinn Chung > Acked-by: Kukjin Kim I'm going to hold off giving this a final review until we have that previous VTTBR_X patch sorted out. Give

Re: [PATCH v6 3/7] arm64: Add a description on 48-bit address space with 4KB pages

2014-05-27 Thread Christoffer Dall
r > Signed-off-by: Jungseok Lee > Reviewed-by: Sungjinn Chung > Acked-by: Kukjin Kim > --- Looks reasonable to me: Acked-by: Christoffer Dall -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger

Re: [PATCH v5 4/6] arm64: Add 4 levels of page tables definition with 4KB pages

2014-05-06 Thread Christoffer Dall
ypedef pgdval_t pgd_t; > +typedef pteval_t pgprot_t; > + > +#define pte_val(x) (x) > +#define pmd_val(x) (x) > +#define pud_val(x) (x) > +#define pgd_val(x) (x) > +#define pgprot_val(x)(x) > + > +#define __pte(x) (x) > +#define __pmd(x) (x) > +#define __pud(x) (x) > +#define __pgd(x) (x) > +#define __pgprot(x) (x) > + > +#endif /* STRICT_MM_TYPECHECKS */ > + > +#endif /* __ASM_PGTABLE_4LEVEL_TYPES_H */ > -- > 1.7.10.4 > > Reviewed-by: Christoffer Dall -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v5 5/6] arm64: mm: Implement 4 levels of translation tables

2014-05-06 Thread Christoffer Dall
; > diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c > index 6b7e895..4d29332 100644 > --- a/arch/arm64/mm/mmu.c > +++ b/arch/arm64/mm/mmu.c > @@ -32,6 +32,7 @@ > #include > #include > #include > +#include > #include > > #include "mm.h&quo

Re: [PATCH v5 6/6] arm64: KVM: Implement 4 levels of translation tables for HYP and stage2

2014-05-06 Thread Christoffer Dall
st > > 6) 64KB + 2 levels guest on 4KB + 4 levels host > > 7) 4KB + 3 levels guest on 64KB + 2 levels host > > 8) 4KB + 4 levels guest on 64KB + 2 levels host > > 9) 64KB + 2 levels guest on 64KB + 2 levels host > > Cc: Marc Zyngier > Cc: Christoffer Dall &

Re: [PATCH 2/2] ARM: KVM: user_mem_abort: support stage 2 MMIO page mapping

2014-05-06 Thread Christoffer Dall
coherent_icache_guest_page(kvm, hva, PAGE_SIZE); > - ret = stage2_set_pte(kvm, memcache, fault_ipa, &new_pte, false); > + ret = stage2_set_pte(kvm, memcache, fault_ipa, &new_pte, > + mem_type == PAGE_S2_DEVICE); > } > > > -- > 1.9.1 &g

Re: [PATCH v5 5/6] arm64: mm: Implement 4 levels of translation tables

2014-05-07 Thread Christoffer Dall
On Wed, May 07, 2014 at 01:22:50PM +0900, Jungseok Lee wrote: > On Tuesday, May 06, 2014 7:49 PM, Christoffer Dall wrote: > > On Thu, May 01, 2014 at 11:34:16AM +0900, Jungseok Lee wrote: > > > This patch implements 4 levels of translation tables since 3 levels of > > >

Re: [PATCH 2/2] ARM: KVM: user_mem_abort: support stage 2 MMIO page mapping

2014-05-07 Thread Christoffer Dall
On Wed, May 07, 2014 at 10:00:21AM +0100, Marc Zyngier wrote: > Kim, Christoffer, > > On Tue, May 06 2014 at 7:04:48 pm BST, Christoffer Dall > wrote: > > On Tue, Mar 25, 2014 at 05:08:14PM -0500, Kim Phillips wrote: > >> Use the correct memory type for device MM

Re: [PATCH v6 6/7] arm64: KVM: Set physical address size related factors in runtime

2014-06-04 Thread Christoffer Dall
On Mon, Jun 02, 2014 at 05:11:39PM +0900, Jungseok Lee wrote: > On Tuesday, May 27, 2014 11:03 PM, Christoffer Dall wrote: > > On Tue, May 27, 2014 at 03:53:49PM +0200, Christoffer Dall wrote: > > > On Mon, May 12, 2014 at 06:40:54PM +0900, Jungseok Lee wrote: > > > &

Re: [PATCH v2] ARM: KVM: add irqfd and irq routing support

2014-06-05 Thread Christoffer Dall
On Mon, Jun 02, 2014 at 09:29:56AM +0200, Eric Auger wrote: > This patch enables irqfd and irq routing on ARM. > > It turns on CONFIG_HAVE_KVM_EVENTFD and CONFIG_HAVE_KVM_IRQ_ROUTING > > irqfd framework enables to assign physical IRQs to guests. > > 1) user-side uses KVM_IRQFD VM ioctl to pass K

Re: [PATCH v2] ARM: KVM: add irqfd and irq routing support

2014-06-05 Thread Christoffer Dall
On Mon, Jun 02, 2014 at 04:42:36PM +0200, Eric Auger wrote: > On 06/02/2014 03:54 PM, Marc Zyngier wrote: > > Hi Eric, > > > > On Mon, Jun 02 2014 at 8:29:56 am BST, Eric Auger > > wrote: [...] > >> @@ -408,11 +411,27 @@ static bool handle_mmio_clear_pending_reg(struct > >> kvm_vcpu *vcpu, >

Re: [PATCH] arm: document "mach-virt" platform.

2014-02-02 Thread Christoffer Dall
On Thu, Jan 30, 2014 at 04:11:02PM +, Ian Campbell wrote: > mach-virt has existed for a while but it is not written down what it actually > consists of. Although it seems a bit unusual to document a binding for an > entire platform since mach-virt is entirely virtual it is helpful to have > som

Re: [PATCH] arm: document "mach-virt" platform.

2014-02-02 Thread Christoffer Dall
On Thu, Jan 30, 2014 at 11:54:46AM -0500, Christopher Covington wrote: > Hi Ian, > > On 01/30/2014 11:11 AM, Ian Campbell wrote: > > mach-virt has existed for a while but it is not written down what it > > actually > > consists of. Although it seems a bit unusual to document a binding for an > >

Re: [PATCH] arm: document "mach-virt" platform.

2014-02-03 Thread Christoffer Dall
On Mon, Feb 03, 2014 at 08:46:07AM -0500, Christopher Covington wrote: > Hi Christoffer, > > On 02/02/2014 11:56 PM, Christoffer Dall wrote: > > On Thu, Jan 30, 2014 at 11:54:46AM -0500, Christopher Covington wrote: > >> I think it would be informative to provide pointe

Re: [PATCH v2] arch: arm: uapi: be sure of "_UAPI" prefix for all guard macros

2013-11-14 Thread Christoffer Dall
On Thu, Nov 14, 2013 at 10:42:31AM +0800, Chen Gang wrote: > For all uapi headers, need use "_UAPI" prefix for its guard macro > (which will be stripped by "scripts/headers_installer.sh"). > > Additional completions: > > - be sure that all "endif" need be appended related comment, also it >h

Re: [RFC PATCH v6 15/20] vfio/platform: support for maskable and automasked interrupts

2014-09-10 Thread Christoffer Dall
On Tue, Sep 02, 2014 at 06:06:17PM +0200, Antonios Motakis wrote: > On Sun, Jun 8, 2014 at 12:17 PM, Christoffer Dall > wrote: > > On Thu, Jun 05, 2014 at 07:03:23PM +0200, Antonios Motakis wrote: > >> Adds support to mask interrupts, and also for automasked interrupts.

Re: [RFC PATCH] ARM: KVM: add irqfd support

2014-08-19 Thread Christoffer Dall
On Tue, Aug 19, 2014 at 10:53:16AM +0200, Eric Auger wrote: > On 08/13/2014 04:55 PM, Christoffer Dall wrote: > > On Mon, Aug 04, 2014 at 02:08:22PM +0200, Eric Auger wrote: > >> This patch enables irqfd on ARM. > >> > >> irqfd framework enables to injec

Re: [PATCH 1/2] KVM: static inline empty kvm_arch functions

2014-09-01 Thread Christoffer Dall
h_flush_shadow was not removed from arch/mips/kvm/mips.c > 2df72e9bc KVM: split kvm_arch_flush_shadow > and kvm_arch_sched_in never made it into arch/ia64/kvm/kvm-ia64.c. > e790d9ef6 KVM: add kvm_arch_sched_in > > Signed-off-by: Radim Krčmář For the arm/arm64 part: Acked-by: Ch

Re: [PATCH 2/2] KVM: remove garbage arg to *hardware_{en,dis}able

2014-09-01 Thread Christoffer Dall
Radim Krčmář For the arm/arm64 part: Acked-by: Christoffer Dall -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [RFC PATCH 4/9] irqchip: GIC: add support for forwarded interrupts

2014-08-06 Thread Christoffer Dall
On Wed, Jun 25, 2014 at 10:28:45AM +0100, Marc Zyngier wrote: > Now that we've switched to EOImode == 1, prevent a forwarded interrupt > from being deactivated after its priority has been dropped. > > Also add support for the interrupt state to be saved/restored. > > Signed-off-by: Marc Zyngier

Re: [RFC PATCH 3/9] irqchip: GIC: Convert to EOImode == 1

2014-08-06 Thread Christoffer Dall
On Wed, Jun 25, 2014 at 03:06:33PM +0100, Peter Maydell wrote: > On 25 June 2014 10:28, Marc Zyngier wrote: > > For this case, the GIC architecture provides EOImode == 1, where: > > - A write to the EOI register drops the priority of the interrupt and leaves > > it active. Other interrupts at the

Re: [RFC PATCH 7/9] KVM: arm: vgic: allow dynamic mapping of physical/virtual interrupts

2014-08-11 Thread Christoffer Dall
On Thu, Aug 07, 2014 at 05:47:53PM +0200, Eric Auger wrote: > On 08/04/2014 03:13 PM, Marc Zyngier wrote: > > On Sun, Aug 03 2014 at 10:48:52 am BST, Eric Auger > > wrote: > >> On 06/25/2014 11:28 AM, Marc Zyngier wrote: > >>> In order to be able to feed physical interrupts to a guest, we need >

Re: [RFC PATCH] ARM: KVM: add irqfd support

2014-08-13 Thread Christoffer Dall
On Mon, Aug 04, 2014 at 02:08:22PM +0200, Eric Auger wrote: > This patch enables irqfd on ARM. > > irqfd framework enables to inject a virtual IRQ into a guest upon an > eventfd trigger. User-side uses KVM_IRQFD VM ioctl to provide KVM with > a kvm_irqfd struct that associates a VM, an eventfd, an

Re: [PATCH] arm64: KVM: export current vcpu->pause state via pseudo regs

2014-08-04 Thread Christoffer Dall
On Fri, Aug 01, 2014 at 10:48:36AM +0100, Alex Bennée wrote: > > Christoffer Dall writes: > > > On Thu, Jul 31, 2014 at 05:45:28PM +0100, Peter Maydell wrote: > >> On 31 July 2014 17:38, Christoffer Dall > >> wrote: > >> >> > If we are not c

Re: [PATCH] arm64: KVM: export current vcpu->pause state via pseudo regs

2014-08-04 Thread Christoffer Dall
On Fri, Aug 01, 2014 at 10:11:52AM +0100, Alex Bennée wrote: > > Christoffer Dall writes: > > > On Thu, Jul 31, 2014 at 04:14:51PM +0100, Alex Bennée wrote: > >> > >> Christoffer Dall writes: > >> > >> > On Wed, Jul 09, 2014 at 02:55:12PM +

Re: [PATCH] arm64: KVM: export current vcpu->pause state via pseudo regs

2014-08-04 Thread Christoffer Dall
On Thu, Jul 31, 2014 at 07:21:44PM +0200, Paolo Bonzini wrote: > Il 31/07/2014 19:04, Peter Maydell ha scritto: > > On 31 July 2014 17:57, Paolo Bonzini wrote: > >> Il 09/07/2014 15:55, Alex Bennée ha scritto: > >>> To cleanly restore an SMP VM we need to ensure that the current pause > >>> state

Re: [Qemu-devel] [RFC PATCH 0/2] virtio-mmio: add irqfd support for vhost-net based on virtio-mmio

2014-11-05 Thread Christoffer Dall
On Mon, Oct 27, 2014 at 12:58 PM, Peter Maydell wrote: > On 27 October 2014 11:23, Li Liu wrote: >> So you mean virtio-mmio will be replaced by PCI/PCIe on ARM at last? > > That is the plan, yes. I can't make any promises on > timescales at the moment, though... > Linaro has scheduled resources t

Re: [PATCH] kvm:arm:Fix error handling in the function vgic_v3_probe

2015-08-06 Thread Christoffer Dall
On Thu, Aug 06, 2015 at 02:00:55PM +0200, Paolo Bonzini wrote: > > > On 06/08/2015 10:06, Marc Zyngier wrote: > > > If this structure of function pointers can handle function pointers with > > > a return type of > > > void I will be glad to do what you request otherwise this would require a >

Re: [PATCH v8 08/11] KVM: arm64: introduce vcpu->arch.debug_ptr

2015-07-08 Thread Christoffer Dall
r works we have nit: you have generic twice > introduced a new pair of function pointers to the sys_reg_desc structure > to override the generic code when needed. > > Signed-off-by: Alex Bennée > Reviewed-by: Christoffer Dall Thanks, -Christoffer > --- > v6: >

Re: [PATCH v8 11/11] KVM: arm64: add trace points for guest_debug debug

2015-07-08 Thread Christoffer Dall
registers. > > Signed-off-by: Alex Bennée Seems like a lot of traces, but I guess that doesn't hurt anything: Acked-by: Christoffer Dall -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org Mo

Re: [PATCH] KVM: Add Kconfig option to signal cross-endian guests

2015-07-09 Thread Christoffer Dall
On Thu, Jul 09, 2015 at 09:49:05AM +0200, Thomas Huth wrote: > The option for supporting cross-endianness legacy guests in > the vhost and tun code should only be available on systems > that support cross-endian guests. > > Signed-off-by: Thomas Huth Acked-by: Christof

Re: add multiple times opening support to a virtserialport

2015-08-27 Thread Christoffer Dall
On Thu, Aug 27, 2015 at 10:23:38AM -0400, Christopher Covington wrote: > On 07/24/2015 08:00 AM, Matt Ma wrote: > > Hi all, > > > > Linaro has developed the foundation for the new Android Emulator code > > base based on a fairly recent upstream QEMU code base, when we > > re-based the code, we upd

Re: [PATCH v2 2/2] arm64: vhe: Verify CPU Exception Levels

2016-04-14 Thread Christoffer Dall
running in hyp mode or not and ensure the > remaining CPUs match it. > > Applies on 4.6-rc3. > > Cc: Marc Zyngier > Cc: Christoffer Dall > Cc: Will Deacon > Cc: Mark Rutland > Cc: Catalin Marinas > Signed-off-by: Suzuki K Poulose > > --- > Changes since v1 >

Re: [PATCH 15/17] kvm: arm64: Get rid of fake page table levels

2016-04-14 Thread Christoffer Dall
On Wed, Apr 13, 2016 at 06:49:59PM +0100, Suzuki K Poulose wrote: > On 12/04/16 13:14, Christoffer Dall wrote: > >On Mon, Apr 11, 2016 at 03:33:45PM +0100, Suzuki K Poulose wrote: > >>On 08/04/16 16:05, Christoffer Dall wrote: > >>>On Mon, Apr 04, 2016 at 05:26:15PM

<    1   2   3   4   5   6   7   8   9   >