Commit 048177ce3b3962852fd34a7e04938959271c7e70 (spi: spi-davinci:
convert to DMA engine API) introduced a regression: dma_map_single()
is called with direction DMA_FROM_DEVICE for rx and for tx.
Signed-off-by: Christian Eggers
Cc: sta...@vger.kernel.org
---
--- drivers/spi/spi-davinci.c.orig
Commit 048177ce3b3962852fd34a7e04938959271c7e70 (spi: spi-davinci:
convert to DMA engine API) introduced a regression: dma_map_single()
is called with direction DMA_FROM_DEVICE for rx and for tx.
Signed-off-by: Christian Eggers
Cc: sta...@vger.kernel.org # v3.7.x+
Acked-by: Matt Porter
or rx and for tx.
Signed-off-by: Christian Eggers
Cc: sta...@vger.kernel.org # v3.7.x+
Acked-by: Matt Porter
---
--- drivers/spi/spi-davinci.c.orig 2013-04-18 20:54:02.728719412 +0200
+++ drivers/spi/spi-davinci.c 2013-04-18 20:54:51.900623956 +0200
@@ -608,7 +608,7 @@ static int davinci_spi
> +++ b/drivers/thermal/devfreq_cooling.c
> @@ -19,10 +19,10 @@
> #include
> #include
> #include
> +#include
>
> #include
>
> -#define HZ_PER_KHZ 1000
> #define SCALE_ERROR_MITIGATION 100
>
> static DEFINE_IDA(devfreq_ida);
>
Reviewed-by: Christian Eggers
Hi Andy,
thanks for the extensive review. Almost all of you comments will be integrated
into v3.
On Tuesday, 28 July 2020, 20:00:31 CEST, Andy Shevchenko wrote:
> On Tue, Jul 28, 2020 at 9:32 AM Christian Eggers wrote:
> > + if (data->client->irq)
> > +
t divided into the datasheet or anything yet!
> Christian Eggers wrote:
> > +/**
> > + * struct as73211_data - Instance data for one AS73211
> > + * @client: I2C client.
> > + * @osr:Cached Operational State Register.
> > + * @creg1: Cached Configuration Re
This series adds support for the AMS AS73211 digital XYZ sensor.
Changes in v3:
--
- Integrated comments from Andy Shevchenko
- Integrated comments from Jonathan Cameron
Changes in v2:
---
- Fix $id in dt binding
- Document full I2C address range in "reg" property
- Move
Add DT bindings for AMS AS73211 XYZ True Color Sensor.
Signed-off-by: Christian Eggers
---
.../bindings/iio/light/ams,as73211.yaml | 54 +++
1 file changed, 54 insertions(+)
create mode 100644 Documentation/devicetree/bindings/iio/light/ams,as73211.yaml
diff --git a
latter
is not used by design as this would require tight timing synchronization
between hardware and driver without much benefit.
Datasheet:
https://ams.com/documents/20143/36005/AS73211_DS000556_3-01.pdf/a65474c0-b302-c2fd-e30a-c98df87616df
Signed-off-by: Christian Eggers
---
MAINTAINERS
Good morning Andy,
thank you again for the comprehensive feedback! Below I removed
everything but possible open points. I'll send v4 soon.
Best regards
Christian
On Thursday, 30 July 2020, 13:31:31 CEST, Andy Shevchenko wrote:
> On Thu, Jul 30, 2020 at 1:52 PM Christian Egger
his series adds support for the AMS AS73211 digital XYZ sensor.
Changes in v4:
---
- Integrated 2nd review from Andy Shevchenko
- Use more devm_ functions in as73211_probe()
Changes in v3:
---
- Integrated comments from Andy Shevchenko
- Integrated comments from Jonathan C
Add DT bindings for AMS AS73211 XYZ True Color Sensor.
Signed-off-by: Christian Eggers
---
.../bindings/iio/light/ams,as73211.yaml | 54 +++
1 file changed, 54 insertions(+)
create mode 100644 Documentation/devicetree/bindings/iio/light/ams,as73211.yaml
diff --git a
latter
is not used by design as this would require tight timing synchronization
between hardware and driver without much benefit.
Datasheet:
https://ams.com/documents/20143/36005/AS73211_DS000556_3-01.pdf/a65474c0-b302-c2fd-e30a-c98df87616df
Signed-off-by: Christian Eggers
---
MAINTAINERS
members
are reported on my system.
On Friday, 31 July 2020, 09:34:02 CEST, Andy Shevchenko wrote:
> On Fri, Jul 31, 2020 at 10:03 AM Christian Eggers wrote:
> > +static const int as73211_samp_freq_avail[] = { 1024000, 2048000, 4096000,
> > 8192000 };
> This looks related to th
Hi Lars
On Monday, 3 August 2020, 08:52:54 CEST, Lars-Peter Clausen wrote:
> On 8/3/20 8:44 AM, Christian Eggers wrote:
> > ...
> > is my patch sufficient, or would you prefer a different solution?
>
> The code in normal upstream is correct, there is no nee
" member out of "struct as73211_data"
- Fix sparse warnings by using correct data types
On Friday, 31 July 2020, 17:41:47 CEST, Andy Shevchenko wrote:
> On Fri, Jul 31, 2020 at 1:52 PM Christian Eggers wrote:
> > devm_iio_device_alloc() doesn't pass 'dev' to iio_
Add DT bindings for AMS AS73211 XYZ True Color Sensor.
Signed-off-by: Christian Eggers
Reviewed-by: Rob Herring
---
.../bindings/iio/light/ams,as73211.yaml | 54 +++
1 file changed, 54 insertions(+)
create mode 100644 Documentation/devicetree/bindings/iio/light/ams
latter
is not used by design as this would require tight timing synchronization
between hardware and driver without much benefit.
Datasheet:
https://ams.com/documents/20143/36005/AS73211_DS000556_3-01.pdf/a65474c0-b302-c2fd-e30a-c98df87616df
Signed-off-by: Christian Eggers
---
MAINTAINERS
e settings required
by a driver are given as separate properties.
Signed-off-by: Christian Eggers
---
On Friday, Jul 31 2020, Rob Herring wrote:
>> On Tue, Jul 28, 2020 at 1:34 AM Christian Eggers wrote:
>> When I specify
>>
>> compatible:
>> enum:
>> -
On Saturday, 1 August 2020, 18:02:34 CEST, Jonathan Cameron wrote:
> On Mon, 27 Jul 2020 16:57:13 +0200
>
> Christian Eggers wrote:
> > iio_trigger_poll() calls generic_handle_irq(). This function expects to
> > be run with local IRQs disabled.
>
> Was there an er
Hi Lars,
On Monday, 3 August 2020, 08:37:43 CEST, Lars-Peter Clausen wrote:
> The sysfs IIO trigger uses irq_work to schedule the iio_trigger_poll()
> and the promise of irq_work is that the callback will run in hard IRQ
> context. That's the whole point of it.
>
> irq_work_run_list(), which show
Hi Jonathan,
On Thursday, 6 August 2020, 19:44:51 CEST, Jonathan Cameron wrote:
> Hi Christian,
>
> I'll take this, but please send a follow up patch to add documentation
> for in_intensity_x_raw and all the other new ABI this adds in
> Documentation/ABI/testing/sysfs-bus-iio
> I should have ment
Unscaled light intensity according to CIE 1931/DIN 5033 color
space.
+ Units after application of scale are nano nanowatts per square
meter.
--
Christian Eggers
Embedded software developer
Arnold & Richter Cine Technik GmbH & Co. Betriebs KG
Sitz: Muenchen - Registergericht
Eggers
---
Jonathan Cameron:
> If it is shared across 'ALL' channels then it will be just integration_time
> If it is shared across all channels of a given type, it will be
> _integration_time.
changed.
Best regards
Christian Eggers
Documentation/ABI/testing
On Monday, 10 August 2020, 11:00:54 CEST, Pavel Machek wrote:
> Hi!
>
> > The driver for the as73211 light sensor provides the following not yet
> > documented sysfs entries:
> > - in_intensity_(x|y|z)_raw
> > - in_intensity_(x|y|z)_scale
> > - in_intensity_sampling_frequency(_available)
> > - in_
Hi Pavel,
On Monday, 10 August 2020, 14:35:40 CEST, Pavel Machek wrote:
> On Mon 2020-08-10 11:57:46, Christian Eggers wrote:
> > On Monday, 10 August 2020, 11:00:54 CEST, Pavel Machek wrote:
> > > Hi!
> > >
> > > > The driver for the as73211 ligh
Hi Jiri,
I have two Fujitsu different FRAMs running with the stock at25 driver. I set
the page size equal to the device size (as FRAMs have no pages).
Are you able to run your FRAM with the unmodified driver?
I assume that getting the device geometry from the chip is vendor specific (in
contra
Using a PTP wide enum will obsolete different driver internal defines
and uses of magic numbers.
Signed-off-by: Christian Eggers
Cc: Kurt Kanzenbach
---
include/linux/ptp_classify.h | 15 +++
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/include/linux
Use new return type of ptp_get_msgtype(). Remove usage of magic number.
Signed-off-by: Christian Eggers
Cc: Richard Cochran
Cc: Kurt Kanzenbach
---
drivers/net/phy/dp83640.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/net/phy/dp83640.c b/drivers/net
Use new return type of ptp_get_msgtype(). Remove usage of magic numbers.
Signed-off-by: Christian Eggers
Cc: Ioana Ciornei
Cc: Ioana Radulescu
Cc: Yangbo Lu
---
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a
Use new return type of ptp_get_msgtype(). Remove driver internal defines
for this.
Signed-off-by: Christian Eggers
Cc: Richard Cochran
Cc: Kurt Kanzenbach
---
drivers/ptp/ptp_ines.c | 25 ++---
1 file changed, 10 insertions(+), 15 deletions(-)
diff --git a/drivers/ptp
If dsa_switch_ops::port_txtstamp() returns false, clone will be freed
immediately. Storing the pointer in DSA_SKB_CB(skb)->clone anyway,
supports annoying use-after-free bugs.
Signed-off-by: Christian Eggers
Fixes 146d442c2357 ("net: dsa: Keep a pointer to the skb clone for TX
time
This series introduces commen defines for PTP event messages. Driver
internal defines are removed and some uses of magic numbers are replaced
by the new defines.
Using PTP wide defines will obsolete different driver internal defines
and uses of magic numbers.
Signed-off-by: Christian Eggers
Cc: Kurt Kanzenbach
---
include/linux/ptp_classify.h | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/include/linux/ptp_classify.h b
Remove usage of magic numbers.
Signed-off-by: Christian Eggers
Cc: Ioana Ciornei
Cc: Ioana Radulescu
Cc: Yangbo Lu
---
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
b
Remove driver internal defines for this.
Signed-off-by: Christian Eggers
Cc: Richard Cochran
Cc: Kurt Kanzenbach
---
drivers/ptp/ptp_ines.c | 19 +++
1 file changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/ptp/ptp_ines.c b/drivers/ptp/ptp_ines.c
index
This series adds support for PTP to the KSZ956x and KSZ9477 devices.
There is only little documentation for PTP available on the data sheet
[1] (more or less only the register reference). Questions to the
Microchip support were seldom answered comprehensively or in reasonable
time. So this is more
Convert the bindings document for Microchip KSZ Series Ethernet switches
from txt to yaml.
Signed-off-by: Christian Eggers
---
.../devicetree/bindings/net/dsa/ksz.txt | 125 --
.../bindings/net/dsa/microchip,ksz.yaml | 152 ++
MAINTAINERS
The dsa.yaml device tree binding allows "ethernet-ports" (preferred) and
"ports".
Signed-off-by: Christian Eggers
Reviewed-by: Vladimir Oltean
---
drivers/net/dsa/microchip/ksz_common.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drive
PTP functionality will be built into a separate source file
(ksz9477_ptp.c).
Signed-off-by: Christian Eggers
Reviewed-by: Vladimir Oltean
---
drivers/net/dsa/microchip/Makefile | 1 +
drivers/net/dsa/microchip/{ksz9477.c => ksz9477_main.c} | 0
2 files changed, 1 insert
The devices have an optional interrupt line.
Signed-off-by: Christian Eggers
---
.../devicetree/bindings/net/dsa/microchip,ksz.yaml | 7 +++
1 file changed, 7 insertions(+)
diff --git a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
b/Documentation/devicetree
The next patch will add basic interrupt support. Chip reset must be
performed before requesting the IRQ, so move this from ksz9477_setup()
to ksz9477_init().
Signed-off-by: Christian Eggers
---
drivers/net/dsa/microchip/ksz9477_main.c | 15 +++
1 file changed, 7 insertions(+), 8
Interrupts are required for TX time stamping. Probably they could also
be used for PHY connection status.
This patch only adds the basic infrastructure for interrupts, no
interrupts are finally enabled nor handled.
Signed-off-by: Christian Eggers
---
drivers/net/dsa/microchip/ksz9477_i2c.c
Implement routines (adjfine, adjtime, gettime and settime) for
manipulating the chip's PTP clock.
Signed-off-by: Christian Eggers
---
drivers/net/dsa/microchip/Kconfig| 8 +
drivers/net/dsa/microchip/Makefile | 1 +
drivers/net/dsa/microchip/ksz9477_i2c.c | 2 +-
dr
tail-tag is set to zero) or move the value from
the correction field back to the tail-tag.
Changing the correction field requires updating the UDP checksum (if UDP
is used as transport).
Signed-off-by: Christian Eggers
---
include/linux/ptp_classify.h | 73
1
details:
https://patchwork.ozlabs.org/project/netdev/patch/20201019172435.4416-8-cegg...@arri.de/
Signed-off-by: Christian Eggers
---
drivers/net/dsa/microchip/ksz9477_main.c | 6 +
drivers/net/dsa/microchip/ksz9477_ptp.c | 187 +++
drivers/net/dsa/microchip/ksz9477_ptp.h | 22
an invalid UDP checksum if this
field is negative.
Of course, the UDP checksums (if any) have to be corrected after this
(for both directions).
Everything has been tested on a Microchip KSZ9563 switch.
Signed-off-by: Christian Eggers
---
drivers/net/dsa/microchip/ksz9477_main.c | 12
The KSZ9563 has a Trigger Output Unit (TOU) which can be used to
generate periodic signals.
After adjusting the PTP clock time, the PPS signal has to be restarted.
Tested on a Microchip KSZ9563 switch.
Signed-off-by: Christian Eggers
---
drivers/net/dsa/microchip/ksz9477_ptp.c | 251
The KSZ9563 has a Trigger Output Unit (TOU) which can be used to
generate periodic signals.
The pulse length can be altered via a device attribute.
Tested on a Microchip KSZ9563 switch.
Signed-off-by: Christian Eggers
---
drivers/net/dsa/microchip/ksz9477_ptp.c | 197
On Thursday, 19 November 2020, 00:33:57 CET, Vladimir Oltean wrote:
> On Wed, Nov 18, 2020 at 04:43:35PM +0100, Christian Eggers wrote:
> > If dsa_switch_ops::port_txtstamp() returns false, clone will be freed
> > immediately. Storing the pointer in DSA_SKB_CB(skb)->clone an
On Wednesday, 18 November 2020, 22:03:56 CET, Jacob Keller wrote:
> On 11/18/2020 8:22 AM, Christian Eggers wrote:
> > Remove driver internal defines for this.
> >
> > Signed-off-by: Christian Eggers
> > Cc: Richard Cochran
> > Cc: Kurt Kanzenbach
> > --
Hi Vladimir,
On Thursday, 19 November 2020, 00:40:18 CET, Vladimir Oltean wrote:
> On Wed, Nov 18, 2020 at 09:30:01PM +0100, Christian Eggers wrote:
> > This series adds support for PTP to the KSZ956x and KSZ9477 devices.
> >
> > There is only little documentation for PTP
If dsa_switch_ops::port_txtstamp() returns false, clone will be freed
immediately. Shouldn't store a pointer to freed memory.
Signed-off-by: Christian Eggers
Fixes: 146d442c2357 ("net: dsa: Keep a pointer to the skb clone for TX
timestamping")
---
Changes since v1:
- Fixed &q
Hi Tristram,
thank you for joining this thread.
On Thursday, 19 November 2020, 19:51:15 CET, tristram...@microchip.com wrote:
> > On Thursday, 19 November 2020, 00:40:18 CET, Vladimir Oltean wrote:
> > > On Wed, Nov 18, 2020 at 09:30:01PM +0100, Christi
On Thursday, 19 November 2020, 14:48:01 CET, Rob Herring wrote:
> On Wed, Nov 18, 2020 at 09:30:02PM +0100, Christian Eggers wrote:
> > Convert the bindings document for Microchip KSZ Series Ethernet switches
> > from txt to yaml.
> >
> > Sign
This series introduces commen defines for PTP event messages. Driver
internal defines are removed and some uses of magic numbers are replaced
by the new defines.
Changes v2 --> v3
--
- extend commit description for ptp_ines (Jacob Keller)
Changes v1 --> v2
--
- use
Using PTP wide defines will obsolete different driver internal defines
and uses of magic numbers.
Signed-off-by: Christian Eggers
Cc: Kurt Kanzenbach
---
include/linux/ptp_classify.h | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/include/linux/ptp_classify.h b
Remove driver internal defines for this. Masking msgtype with 0xf is
already done within ptp_get_msgtype().
Signed-off-by: Christian Eggers
Cc: Richard Cochran
Cc: Kurt Kanzenbach
---
drivers/ptp/ptp_ines.c | 19 +++
1 file changed, 7 insertions(+), 12 deletions(-)
diff --git
Remove usage of magic numbers.
Signed-off-by: Christian Eggers
Cc: Ioana Ciornei
Cc: Ioana Radulescu
Cc: Yangbo Lu
---
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
b
These patches are orginally from the series
"net: dsa: microchip: PTP support for KSZ956x"
As the the device tree conversion to yaml is not really related to the
PTP patches and the original series is going to take more time than
I expected, I would like to split this.
Changes (original series -
Convert the bindings document for Microchip KSZ Series Ethernet switches
from txt to yaml. Removed spi-cpha and spi-cpol flags is this should be
handled by the device driver.
Signed-off-by: Christian Eggers
---
.../devicetree/bindings/net/dsa/ksz.txt | 125 ---
.../bindings
The dsa.yaml device tree binding allows "ethernet-ports" (preferred) and
"ports".
Signed-off-by: Christian Eggers
Reviewed-by: Vladimir Oltean
---
drivers/net/dsa/microchip/ksz_common.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drive
This should be done in the device driver instead of the device tree.
Signed-off-by: Christian Eggers
---
drivers/net/dsa/microchip/ksz9477_spi.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/net/dsa/microchip/ksz9477_spi.c
b/drivers/net/dsa/microchip/ksz9477_spi.c
index
This should be done in the device driver instead of the device tree.
Signed-off-by: Christian Eggers
---
drivers/net/dsa/microchip/ksz8795_spi.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/net/dsa/microchip/ksz8795_spi.c
b/drivers/net/dsa/microchip/ksz8795_spi.c
index
On Saturday, 10 October 2020, 13:09:20 CET, Wolfram Sang wrote:
> On Fri, Oct 09, 2020 at 01:03:18PM +0200, Christian Eggers wrote:
> > According to the "VFxxx Controller Reference Manual" (and the comment
> > block starting at line 97), Vybrid requires writing a one for
driver internal enumeration / uses of magic
numbers with the newly introduced PTP_MSGTYPE_* defines.
On Friday, 20 November 2020, 23:39:10 CET, Vladimir Oltean wrote:
> On Fri, Nov 20, 2020 at 09:41:03AM +0100, Christian Eggers wrote:
> > This series introduces commen defines for PTP event
Replace use of magic number with recently introduced define.
Signed-off-by: Christian Eggers
Cc: Kurt Kanzenbach
---
drivers/net/phy/dp83640.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/net/phy/dp83640.c b/drivers/net/phy/dp83640.c
index f2caccaf4408
Use recently introduced PTP wide defines instead of a driver internal
enumeration.
Signed-off-by: Christian Eggers
Reviewed-by: Ido Schimmel
Cc: Petr Machata
Cc: Jiri Pirko
Cc: Ido Schimmel
---
drivers/net/ethernet/mellanox/mlxsw/spectrum_ptp.c | 8
drivers/net/ethernet/mellanox
Use recently introduced PTP_MSGTYPE_SYNC and PTP_MSGTYPE_DELAY_REQ
defines instead of a driver internal enumeration.
Signed-off-by: Christian Eggers
Reviewed-by: Antoine Tenart
Cc: Antoine Tenart
---
drivers/net/phy/mscc/mscc_ptp.c | 14 +++---
drivers/net/phy/mscc/mscc_ptp.h | 5
I need some help from Microchip, please read below.
On Thursday, 19 November 2020, 19:51:15 CET, tristram...@microchip.com wrote:
> There is one more requirement that is a little difficult to do. The
> calculated peer delay
> needs to be programmed in hardware register, but the regular PTP stack
There is only little documentation for PTP available on the data sheet
[1] (more or less only the register reference). Questions to the
Microchip support were seldom answered comprehensively or in reasonable
time. So this is more or less the result of reverse engineering.
[1]
http://ww1.microchip.
The devices have an optional interrupt line.
Signed-off-by: Christian Eggers
---
.../devicetree/bindings/net/dsa/microchip,ksz.yaml | 7 +++
1 file changed, 7 insertions(+)
diff --git a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
b/Documentation/devicetree
PTP functionality will be built into a separate source file
(ksz9477_ptp.c).
Signed-off-by: Christian Eggers
Reviewed-by: Vladimir Oltean
---
drivers/net/dsa/microchip/Makefile | 1 +
drivers/net/dsa/microchip/{ksz9477.c => ksz9477_main.c} | 0
2 files changed, 1 insert
The next patch will add basic interrupt support. Chip reset must be
performed before requesting the IRQ, so move this from ksz9477_setup()
to ksz9477_init().
Signed-off-by: Christian Eggers
Reviewed-by: Vladimir Oltean
---
drivers/net/dsa/microchip/ksz9477_main.c | 15 +++
1 file
Interrupts are required for TX time stamping. Probably they could also
be used for PHY connection status.
This patch only adds the basic infrastructure for interrupts, no
interrupts are finally enabled nor handled.
Signed-off-by: Christian Eggers
Reviewed-by: Vladimir Oltean
---
Changes in v4
Implement routines (adjfine, adjtime, gettime and settime) for
manipulating the chip's PTP clock.
Signed-off-by: Christian Eggers
Reviewed-by: Vladimir Oltean
---
drivers/net/dsa/microchip/Kconfig| 8 +
drivers/net/dsa/microchip/Makefile | 1 +
drivers/net/dsa/micr
tail-tag is set to zero) or move the value from
the correction field back to the tail-tag.
Changing the correction field requires updating the UDP checksum (if UDP
is used as transport).
Signed-off-by: Christian Eggers
---
include/linux/ptp_classify.h | 73
1
details:
https://patchwork.ozlabs.org/project/netdev/patch/20201019172435.4416-8-cegg...@arri.de/
Signed-off-by: Christian Eggers
Reviewed-by: Vladimir Oltean
---
Changes in v4:
--
- Remove useless case statement
- Reviewed-by: Vladimir Oltean
drivers/net/dsa/microchip/ksz9477_main.c
this
field is negative.
Of course, the UDP checksums (if any) have to be corrected after this
(for both directions).
Everything has been tested on a Microchip KSZ9563 switch.
Signed-off-by: Christian Eggers
---
Changes in v4:
--
- s/low active/active low/
- 80 chars per line
- Use IEEE
The KSZ9563 has a Trigger Output Unit (TOU) which can be used to
generate periodic signals.
The pulse length can be altered via a device attribute.
Tested on a Microchip KSZ9563 switch.
Signed-off-by: Christian Eggers
---
Changes in v4:
--
- 80 chars per line
- reverse christmas
[1]
http://ww1.microchip.com/downloads/en/DeviceDoc/KSZ9563R-Data-Sheet-DS2419D.pdf
Changes from v4 --> v5
[8/9]- Fix compile error reported by kernel test robot
(NET_DSA_TAG_KSZ must select NET_PTP_CLASSIFY)
Changes from v3 --> v4
-
PTP functionality will be built into a separate source file
(ksz9477_ptp.c).
Signed-off-by: Christian Eggers
Reviewed-by: Vladimir Oltean
---
drivers/net/dsa/microchip/Makefile | 1 +
drivers/net/dsa/microchip/{ksz9477.c => ksz9477_main.c} | 0
2 files changed, 1 insert
The devices have an optional interrupt line.
Signed-off-by: Christian Eggers
---
.../devicetree/bindings/net/dsa/microchip,ksz.yaml | 7 +++
1 file changed, 7 insertions(+)
diff --git a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
b/Documentation/devicetree
The next patch will add basic interrupt support. Chip reset must be
performed before requesting the IRQ, so move this from ksz9477_setup()
to ksz9477_init().
Signed-off-by: Christian Eggers
Reviewed-by: Vladimir Oltean
---
drivers/net/dsa/microchip/ksz9477_main.c | 15 +++
1 file
Interrupts are required for TX time stamping. Probably they could also
be used for PHY connection status.
This patch only adds the basic infrastructure for interrupts, no
interrupts are finally enabled nor handled.
Signed-off-by: Christian Eggers
Reviewed-by: Vladimir Oltean
---
Changes in v4
Implement routines (adjfine, adjtime, gettime and settime) for
manipulating the chip's PTP clock.
Signed-off-by: Christian Eggers
Reviewed-by: Vladimir Oltean
---
drivers/net/dsa/microchip/Kconfig| 8 +
drivers/net/dsa/microchip/Makefile | 1 +
drivers/net/dsa/micr
tail-tag is set to zero) or move the value from
the correction field back to the tail-tag.
Changing the correction field requires updating the UDP checksum (if UDP
is used as transport).
Signed-off-by: Christian Eggers
---
include/linux/ptp_classify.h | 73
1
details:
https://patchwork.ozlabs.org/project/netdev/patch/20201019172435.4416-8-cegg...@arri.de/
Signed-off-by: Christian Eggers
Reviewed-by: Vladimir Oltean
---
Changes in v4:
--
- Remove useless case statement
- Reviewed-by: Vladimir Oltean
drivers/net/dsa/microchip/ksz9477_main.c
this
field is negative.
Of course, the UDP checksums (if any) have to be corrected after this
(for both directions).
Everything has been tested on a Microchip KSZ9563 switch.
Signed-off-by: Christian Eggers
---
Changes in v5:
--
- Fix compile error reported by kernel test robot
The KSZ9563 has a Trigger Output Unit (TOU) which can be used to
generate periodic signals.
The pulse length can be altered via a device attribute.
Tested on a Microchip KSZ9563 switch.
Signed-off-by: Christian Eggers
---
Changes in v4:
--
- 80 chars per line
- reverse christmas
On Thursday, 3 December 2020, 15:12:55 CET, Richard Cochran wrote:
> On Thu, Dec 03, 2020 at 11:21:17AM +0100, Christian Eggers wrote:
> > The KSZ9563 has a Trigger Output Unit (TOU) which can be used to
> > generate periodic signals.
> >
> > The pulse length can be alt
On Thursday, 3 December 2020, 16:52:46 CET, Vladimir Oltean wrote:
> On Thu, 3 Dec 2020 at 17:36, Christian Eggers wrote:
> > Should ptp_sysfs be extended with a "pulse" attribute with calls
> > enable() with only PTP_PEROUT_DUTY_CYCLE set?
>
> Use tools/testing
ALU_VAL_C0100 FID 0 MAC_0_1
01:00
ALU_VAL_D5E000181 MAC_2_55E:00:01:81
On Wednesday, 25 November 2020, 22:08:39 CET, Christian Eggers wrote:
> I need some help from Microchip, please read below.
>
> On Thursday, 19 November
This series replaces further driver internal enumeration / uses of magic
numbers with the newly introduced PTP_MSGTYPE_* defines.
On Friday, 20 November 2020, 23:39:10 CET, Vladimir Oltean wrote:
> On Fri, Nov 20, 2020 at 09:41:03AM +0100, Christian Eggers wrote:
> > This series introduc
Replace use of magic number with recently introduced define.
Signed-off-by: Christian Eggers
Cc: Kurt Kanzenbach
---
drivers/net/phy/dp83640.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/net/phy/dp83640.c b/drivers/net/phy/dp83640.c
index f2caccaf4408
Use recently introduced PTP wide defines instead of a driver internal
enumeration.
Signed-off-by: Christian Eggers
Cc: Petr Machata
Cc: Jiri Pirko
Cc: Ido Schimmel
---
drivers/net/ethernet/mellanox/mlxsw/spectrum_ptp.c | 8
drivers/net/ethernet/mellanox/mlxsw/spectrum_ptp.h | 7
Use recently introduced PTP_MSGTYPE_SYNC and PTP_MSGTYPE_DELAY_REQ
defines instead of a driver internal enumeration.
Signed-off-by: Christian Eggers
Cc: Quentin Schulz
Cc: Antoine Tenart
Cc: Antoine Tenart
---
drivers/net/phy/mscc/mscc_ptp.c | 14 +++---
drivers/net/phy/mscc
On Sunday, 22 November 2020, 15:35:55 CET, Ido Schimmel wrote:
> On Sun, Nov 22, 2020 at 09:26:35AM +0100, Christian Eggers wrote:
> > Use recently introduced PTP wide defines instead of a driver internal
> > enumeration.
> >
> > Signed-off-by: Christian Eggers
> &g
On Monday, 5 October 2020, 10:07:25 CEST, Krzysztof Kozlowski wrote:
> The I2C on Vybrid VF500 still works fine. I did not test this actual
> condition (arbitration) but only a regular I2C driver (BQ27xxx fuel
> gauge). Obviously this only proves that regular operation is not
> broken...
thank you
.
2. Only queue delayed work in ksz_mac_link_down() if init is completed.
3. Queue work once in ksz_switch_register(), after dsa_register_switch()
has completed.
Signed-off-by: Christian Eggers
Cc: sta...@vger.kernel.org
---
Call tree:
ksz9477_i2c_probe()
\--ksz9477_switch_regis
1 - 100 of 255 matches
Mail list logo
