Re: [PATCH 3/5] kvm: Directly account vtime to system on guest switch

2012-10-25 Thread Christian Borntraeger
On 25/10/12 02:51, Frederic Weisbecker wrote: > Switching to or from guest context is done on ioctl context. > So by the time we call kvm_guest_enter() or kvm_guest_exit() > we know we are not running the idle task. > > As a result, we can directly account the cputime using > vtime_account_system_

Re: [PATCH 3/5] kvm: Directly account vtime to system on guest switch

2012-10-25 Thread Christian Borntraeger
On 25/10/12 09:56, Frederic Weisbecker wrote: [...] >>> * s390 doesn't disable irqs in its implementation of vtime_account(). >>> If vtime_account() in kvm races with an irq, the pending time might >>> be accounted twice. With vtime_account_system_irqsafe() we are protected. >> >> We disable irqs b

"avoid overflows in kernel/time" breakes my ondemand scheduler

2008-02-13 Thread Christian Borntraeger
Hello H. Peter, the patch "avoid overflows in kernel/time" makes the ondemand cpufreq scheduler unusable. It looks like the cpufreq scheduler takes minutes to react on load changes. I looked at the patch but did not found an obvious problem. Reverting this patch seems to fix the problem. Do y

Re: [PATCH 1/4] PF: Add FAULT_FLAG_RETRY_NOWAIT for guest fault

2013-07-09 Thread Christian Borntraeger
need for mm notifiers. >> >> Based on a patch from Martin Schwidefsky. >> > For that we will obviously need Christian and Cornelia ACKs. Or it can > go in via S390 tree. > >> Signed-off-by: Dominik Dingel Acked-by: Christian Borntraeger Do you want me or Conn

Re: [PATCH 3/4] PF: Provide additional direct page notification

2013-07-09 Thread Christian Borntraeger
rmation. On the other hand there is now the direct > mechanism, this will directly push the information to the guest. > > Still the vcpu thread should call check_completion to cleanup leftovers, > that leaves most of the common code untouched. > > Signed-off-by: Dominik Dingel Acke

Re: [PATCH 4/4] PF: Async page fault support on s390

2013-07-10 Thread Christian Borntraeger
On 09/07/13 15:56, Dominik Dingel wrote: > This patch enables async page faults for s390 kvm guests. > It provides the userspace API to enable, disable or get the status of this > feature. Also it includes the diagnose code, called by the guest to enable > async page faults. > > The async page fau

Re: [PATCH 3/4] PF: Provide additional direct page notification

2013-07-10 Thread Christian Borntraeger
On 10/07/13 12:39, Alexander Graf wrote: > > On 09.07.2013, at 18:01, Christian Borntraeger wrote: > >> On 09/07/13 15:56, Dominik Dingel wrote: >>> By setting a Kconfig option, the architecture can control when >>> guest notifications will be presented by the

Re: [PATCH 4/4] PF: Async page fault support on s390

2013-07-11 Thread Christian Borntraeger
On 11/07/13 11:04, Gleb Natapov wrote: > On Wed, Jul 10, 2013 at 02:59:55PM +0200, Dominik Dingel wrote: >> This patch enables async page faults for s390 kvm guests. >> It provides the userspace API to enable, disable or get the status of this >> feature. Also it includes the diagnose code, called

Re: [PATCH] ext4: fix a big-endian bug when an extent is zeroed out

2013-04-22 Thread Christian Borntraeger
On 20/04/13 17:19, Theodore Ts'o wrote: > On Mon, Apr 08, 2013 at 11:05:11PM -0400, CAI Qian wrote: >> I can help run xfstests for ext4 dev tree on x64, Power7, Z10 and >> KVM platforms with back-storage like SAN/multipath, iSCSI and FCoE. >> I plan to run this weekly and setup a wiki page to updat

Re: [PATCH 4/4] PF: Async page fault support on s390

2013-07-18 Thread Christian Borntraeger
On 18/07/13 15:57, Paolo Bonzini wrote: > Il 11/07/2013 12:41, Christian Borntraeger ha scritto: >> On 11/07/13 11:04, Gleb Natapov wrote: >>> On Wed, Jul 10, 2013 at 02:59:55PM +0200, Dominik Dingel wrote: >>>> This patch enables async page faults for s390 kv

Re: [RFC][PATCH 0/2] s390/kvm: add kvm support for guest page hinting v2

2013-07-25 Thread Christian Borntraeger
On 25/07/13 10:54, Martin Schwidefsky wrote: > v1->v2: > - found a way to simplify the common code patch > > Linux on s390 as a guest under z/VM has been using the guest page > hinting interface (alias collaborative memory management) for a long > time. The full version with volatile states has b

Re: [PATCH 1/2] mm: add support for discard of unused ptes

2013-07-25 Thread Christian Borntraeger
or swap out and potentially > another one for swap in. > > [ Martin Schwidefsky: patch reordering and simplification ] > > Signed-off-by: Konstantin Weitz > Signed-off-by: Martin Schwidefsky Reviewed-by: Christian Borntraeger > --- > include/asm-generic/pgtable.h |

Re: [PATCH 2/2] s390/kvm: support collaborative memory management

2013-07-25 Thread Christian Borntraeger
add some code to the diag308 handler to make reset save. For other kinds of reset (e.g. those for kdump) we need to make this accessible to userspace. Again, this can be added later on when we implement the other missing pieces for kdump and friends. So Reviewed-by: Christian Borntr

Re: [ 17/53] s390/kvm: Fix store status for ACRS/FPRS

2013-02-28 Thread Christian Borntraeger
On 28/02/13 23:26, Jiri Slaby wrote: > On 02/27/2013 12:57 AM, Greg Kroah-Hartman wrote: >> 3.0-stable review patch. If anyone has any objections, please let me know. >> >> -- >> >> From: Christian Borntraeger >> >> commit 15bc

Re: [PATCH RFC V5 0/3] kvm: Improving directed yield in PLE handler

2012-07-23 Thread Christian Borntraeger
On 22/07/12 14:43, Avi Kivity wrote: > On 07/22/2012 03:34 PM, Raghavendra K T wrote: >> >> Thanks Marcelo for the review. Avi, Rik, Christian, please let me know >> if this series looks good now. >> > > It looks fine to me. Christian, is this okay for s390? &g

Re: [PATCH RFC 0/2] kvm: Improving directed yield in PLE handler

2012-07-11 Thread Christian Borntraeger
On 11/07/12 11:06, Avi Kivity wrote: [...] >> Almost all s390 kernels use diag9c (directed yield to a given guest cpu) for >> spinlocks, though. > > Perhaps x86 should copy this. See arch/s390/lib/spinlock.c The basic idea is using several heuristics: - loop for a given amount of loops - check i

Re: [PATCH RFC 0/2] kvm: Improving directed yield in PLE handler

2012-07-11 Thread Christian Borntraeger
On 11/07/12 13:04, Avi Kivity wrote: > On 07/11/2012 01:17 PM, Christian Borntraeger wrote: >> On 11/07/12 11:06, Avi Kivity wrote: >> [...] >>>> Almost all s390 kernels use diag9c (directed yield to a given guest cpu) >>>> for spinlocks, though. >>

Re: [PATCH RFC 0/2] kvm: Improving directed yield in PLE handler

2012-07-11 Thread Christian Borntraeger
On 11/07/12 13:51, Raghavendra K T wrote: Almost all s390 kernels use diag9c (directed yield to a given guest cpu) for spinlocks, though. >>> >>> Perhaps x86 should copy this. >> >> See arch/s390/lib/spinlock.c >> The basic idea is using several heuristics: >> - loop for a given amount o

Re: [PATCH RFC V3 2/3] kvm: Note down when cpu relax intercepted or pause loop exited

2012-07-12 Thread Christian Borntraeger
On 12/07/12 21:18, Raghavendra K T wrote: > +#ifdef CONFIG_HAVE_KVM_CPU_RELAX_INTERCEPT [...] > + struct { > + bool cpu_relax_intercepted; > + bool dy_eligible; > + } ple; > +#endif [...] > } > vcpu->run = page_address(page); > + vcpu->ple.cpu_relax_i

Re: [PATCH RFC V3 2/3] kvm: Note down when cpu relax intercepted or pause loop exited

2012-07-12 Thread Christian Borntraeger
On 13/07/12 05:35, Raghavendra K T wrote: > Yes! I forgot about archs in init function. > How about having > #ifdef CONFIG_HAVE_KVM_CPU_RELAX_INTERCEPT > vcpu->ple.cpu_relax_intercepted = false; > vcpu->ple.dy_eligible = false; > #endif > > This would solve all the problem. No, you need to mask a

Re: [PATCH RFC 0/2] kvm: Improving directed yield in PLE handler

2012-07-09 Thread Christian Borntraeger
On 09/07/12 08:20, Raghavendra K T wrote: > Currently Pause Looop Exit (PLE) handler is doing directed yield to a > random VCPU on PL exit. Though we already have filtering while choosing > the candidate to yield_to, we can do better. > > Problem is, for large vcpu guests, we have more probability

Re: [patch] mm: fix XIP file writes

2007-12-10 Thread Christian Borntraeger
Hi Nick, > Here we go. See, brd already found a bug ;) > Can you apply the ext2 XIP patch too? And I'll resend the brd XIP patch. [...] > Writing to XIP files at a non-page-aligned offset results in data corruption > because the writes were always sent to the start of the page. [...] > @@ -314,7 +

Re: [RFC] Proposed new directory layout for kvm and virtualization

2007-12-11 Thread Christian Borntraeger
Am Dienstag, 11. Dezember 2007 schrieb Avi Kivity: > KVM is due to receive support for multiple architectures (ppc, ia64, and > s390, in addition to the existing x86), hopefully in time for the 2.6.25 > merge window. It is awkward to place the new arch support in > drivers/kvm/, so I'd like to

Re: Decreasing stime running confuses top

2007-10-04 Thread Christian Borntraeger
Am Donnerstag, 4. Oktober 2007 schrieb Chuck Ebbert: > Is CONFIG_VIRT_CPU_ACCOUNTING set? This is s390 and powerpc only, so the answer is probably no ;-) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at

[PATCH for testing] Re: Decreasing stime running confuses top

2007-10-04 Thread Christian Borntraeger
Am Donnerstag, 4. Oktober 2007 schrieb Chuck Ebbert: > On 10/04/2007 04:00 PM, Christian Borntraeger wrote: > > Am Donnerstag, 4. Oktober 2007 schrieb Chuck Ebbert: > >> Is CONFIG_VIRT_CPU_ACCOUNTING set? > > > > This is s390 and powerpc only, so the answer is prob

Re: [PATCH for testing] Re: Decreasing stime running confuses top

2007-10-04 Thread Christian Borntraeger
Am Freitag, 5. Oktober 2007 schrieb Chuck Ebbert: > On 10/04/2007 05:10 PM, Christian Borntraeger wrote: > > > > > Alternative patch: > > procfs: Don't read runtime twice when computing task's stime > > Current code reads p->se.sum_exec_run

Re: [PATCH for testing] Re: Decreasing stime running confuses top

2007-10-08 Thread Christian Borntraeger
5fa and should restore the 2.6.22 > > behavior. The process time is used from tasks utime and stime instead of > > the scheduler clock. That means, in general after a long period of time, > > it is less accurate than the current time and behaves like 2.6.22. > > > > Signed-o

[PATCH] ramdisk: fix zeroed ramdisk pages on memory pressure

2007-10-09 Thread Christian Borntraeger
From: Christian Borntraeger <[EMAIL PROTECTED]> We have seen ramdisk based install systems, where some pages of mapped libraries and programs were suddendly zeroed under memory pressure. This should not happen, as the ramdisk avoids freeing its pages by keeping them dirty all the tim

Re: [s390] networking related oops during boot on Hercules (was: build failure)

2007-11-28 Thread Christian Borntraeger
s to be related to the new network namespace code by Eric Biederman (CCed). Can you try the following (untested) patch? I also CCed Ursula and Peter as they know the ctc code better than me. CC: Eric W. Biederman <[EMAIL PROTECTED]> CC: Ursula Braun <[EMAIL PROTECTED]> CC: Peter Tiedem

Re: [patch] rewrite rd

2007-12-04 Thread Christian Borntraeger
Am Dienstag, 4. Dezember 2007 schrieb Nick Piggin: [...] > There is one slight downside -- direct block device access and filesystem > metadata access goes through an extra copy and gets stored in RAM twice. > However, this downside is only slight, because the real buffercache of the > device is no

Re: [s390] build failure

2007-11-28 Thread Christian Borntraeger
ror 1 > > We have a patch for that in our repository. Martin will send that fix with the next bunch of fixes. Subject: [PATCH] Fix compile error on 31bit without preemption From: Christian Borntraeger <[EMAIL PROTECTED]> Commit b8e7a54cd06b0b0174029ef3a7f5a1415a2c28f2 introduced

Re: Linux 2.6.23.10

2007-12-16 Thread Christian Borntraeger
Am Freitag, 14. Dezember 2007 schrieb Greg Kroah-Hartman: > Christian Borntraeger (1): > Future of Linux 2.6.22.y series This should be: rd: fix data corruption on memory pressure. Same for 2.6.22 Christian -- To unsubscribe from this list: send the line "unsubscribe linux-ker

Re: [PATCH 1/2] Thinkpad Suspend Powersave: Fix ACPI's GFP_KERNEL allocations in contexts that can sleep

2005-03-16 Thread Christian Borntraeger
Andrew Morton wrote: > "Theodore Y. Ts'o" <[EMAIL PROTECTED]> wrote: > > This fixes a problem originally reported by Christian Borntraeger where > > during the wakeup from a suspend-to-ram, several "sleeping function > > called from invalid

Re: [patch 05/12] acpi: sleep-while-atomic during S3 resume from ram

2005-02-24 Thread Christian Borntraeger
[EMAIL PROTECTED] wrote: > From: Christian Borntraeger <[EMAIL PROTECTED]> > > During the wakeup from suspend-to-ram I get several warnings. > > Signed-off-by: Christian Borntraeger <[EMAIL PROTECTED]> > Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> Andr

Re: how to capture kernel panics

2005-02-25 Thread Christian Borntraeger
shabanip wrote: > is there any way to capture and log kernel panics on disk or ...? In former times, the Linux kernel tried to sync in the panic function. (If the panic did not happen in interrupt context) Unfortunately this had severe side effects in cases where the panic was triggered by file

Re: Invalid module format in Fedora core2

2005-02-25 Thread Christian Borntraeger
Payasam Manohar wrote: > Hai all, >I tried to insert a sample module into Fedora core 2 , But it is > giving an error message that " no module in the object" > The same module was inserted successfully into Redhat linux 9. > > Is there any changes from RH 9 to Fedora Core 2 with respect to th

Re: Disable cache disk

2005-03-31 Thread Christian Borntraeger
Yves Crespin wrote: > Christian Bornträger wrote: > >On Wednesday 30 March 2005 15:00, Yves Crespin wrote: > >>1/ is-it possible to *really* be synchronize. I prefer to have a > >> blocked write() than use cache and get swap! > >Try to mount with the sync option. > exactly async and noatime ? No.

[PATCH resend2] rd: fix data corruption on memory pressure

2007-10-29 Thread Christian Borntraeger
or the ramdisk driver. This avoids try_to_free_buffers for ramdisk pages. Signed-off-by: Christian Borntraeger <[EMAIL PROTECTED]> --- drivers/block/rd.c | 13 + 1 file changed, 13 insertions(+) Index: linux-2.6/driver

Re: [stable] 2.6.23 regression: top displaying 9999% CPU usage

2007-10-29 Thread Christian Borntraeger
Am Montag, 29. Oktober 2007 schrieb Ingo Molnar: > i've got a patch from Peter queued up. (see below) This should fix the > main issue. [...] > --- linux.orig/fs/proc/array.c > +++ linux/fs/proc/array.c > @@ -358,7 +358,8 @@ static cputime_t task_utime(struct task_ > } > utime = (clock

Re: [stable] 2.6.23 regression: top displaying 9999% CPU usage

2007-10-29 Thread Christian Borntraeger
Am Montag, 29. Oktober 2007 schrieb Balbir Singh: > We'll also need this additional patch (untested), but in the long run > I think the approach needs to be > > 1. Update stime and utime at the time of context switching -- keep it >in sync with p->sum_exec_runtime > 2. Keep track of system/use

Re: [Patch 09/16] Remove unnecessary kmalloc casts in the pci subsystem.

2007-07-31 Thread Christian Borntraeger
Am Dienstag, 31. Juli 2007 schrieb [EMAIL PROTECTED]: > --- a/drivers/pci/rom.c > +++ b/drivers/pci/rom.c > @@ -185,7 +185,7 @@ void __iomem *pci_map_rom_copy(struct pc > IORESOURCE_ROM_BIOS_COPY)) > return rom; > > - res->start = (unsigned long)kmalloc(*s

Re: [Patch 08/16] Remove unnecessary kmalloc casts in the parisc drivers.

2007-07-31 Thread Christian Borntraeger
Am Dienstag, 31. Juli 2007 schrieb [EMAIL PROTECTED]: > - a = (unsigned long)kmalloc(sizeof(struct irt_entry) * num_entries + 8, GFP_KERNEL); > + a = kmalloc(sizeof(struct irt_entry) * num_entries + 8, GFP_KERNEL); NAK. Same as in some other patches. "void *" -> "ulong" is not auto casted

Re: [Patch 02/16] Remove unnecessary kmalloc casts from the mips arch.

2007-07-31 Thread Christian Borntraeger
Am Dienstag, 31. Juli 2007 schrieb [EMAIL PROTECTED]: > === > --- a/arch/mips/au1000/common/dbdma.c > +++ b/arch/mips/au1000/common/dbdma.c [...] > - desc_base = (u32)kmalloc(entries * sizeof(au1x_ddma_desc_t), > + desc_base =

Re: [Patch 11/16] Remove unnecessary kmalloc casts in drivers/net.

2007-07-31 Thread Christian Borntraeger
Am Dienstag, 31. Juli 2007 schrieb [EMAIL PROTECTED]: > --- a/drivers/net/lance.c > +++ b/drivers/net/lance.c [...] > - lp->rx_buffs = (unsigned long)kmalloc(PKT_BUF_SZ*RX_RING_SIZE, > - GFP_DMA | GFP_KERNEL); > + lp->rx_buffs = kmalloc(PKT_BUF_

Re: [Patch 06/16] This removes unnecessary kmalloc casts and corrects a test for kmalloc failure.

2007-07-31 Thread Christian Borntraeger
Am Dienstag, 31. Juli 2007 schrieb [EMAIL PROTECTED]: > --- a/drivers/media/video/zoran_driver.c > +++ b/drivers/media/video/zoran_driver.c [...] > - mem = > - (unsigned long) kmalloc(fh->jpg_buffers. > - bu

Re: [kvm-devel] [PATCH 0/2][KVM] guest time accounting

2007-08-13 Thread Christian Borntraeger
old PATCH GPLv2 -- Subject: [PATCH/RFC] Fix system<->user misaccount of interpreted execution From: Christian Borntraeger <[EMAIL PROTECTED]> This patches fixes the accouting of guest cpu time. As sie is executed via a system call, all guest operations were accounted as system time.

Re: [kvm-devel] [PATCH 0/2][KVM] guest time accounting

2007-08-13 Thread Christian Borntraeger
Am Montag, 13. August 2007 schrieb Laurent Vivier: > > [copying Ingo and Rusty] @Avi, seems that sourceforge is mangling the cc list? > > > > The patches look good. A couple of comments: > > > > - perhaps the new fields should be guarded by a #ifdef CONFIG_HYPERVISOR > > (selected by CONFIG_KV

Re: [kvm-devel] [PATCH 0/2][KVM] guest time accounting

2007-08-13 Thread Christian Borntraeger
Am Montag, 13. August 2007 schrieb Avi Kivity: > Laurent's patch gives the best of both worlds: on old 'top', you get > guest time accounted as user time, while on new 'top' it is accounted > separately. This is done by reporting user time as the sum of the real > user time and guest time. A

Re: [kvm-devel] [PATCH 0/2][KVM] guest time accounting

2007-08-13 Thread Christian Borntraeger
Am Montag, 13. August 2007 schrieb Laurent Vivier: > >> As guest accounting is hw dependent, I think we should add a hook in the > >> accounting functions. > >> > > > > Isn't PF_VM exactly such a hook? All the hypervisor needs to do is to > > set/unset it correctly? > > In fact, no. > > PF_V

Re: [kvm-devel] [PATCH 0/2][KVM] guest time accounting

2007-08-13 Thread Christian Borntraeger
Am Montag, 13. August 2007 schrieb Avi Kivity: > Christian Borntraeger wrote: > > Am Montag, 13. August 2007 schrieb Laurent Vivier: > > > >>> [copying Ingo and Rusty] > >>> > > > > @Avi, seems that sourceforge is mangling the cc list?

Re: [accounting regression since rc1] scheduler updates

2007-08-14 Thread Christian Borntraeger
This is a 2nd try with correct email address, sorry for the duplicates. Am Sonntag, 12. August 2007 schrieb Ingo Molnar: > Linus, please pull the latest scheduler git tree from: Hello Ingo, this is a followup to the discussion in http://lkml.org/lkml/2007/7/19/538 Since 2.6.12, s390 already do

Re: [accounting regression since rc1] scheduler updates

2007-08-14 Thread Christian Borntraeger
Am Dienstag, 14. August 2007 schrieb Linus Torvalds: > On Tue, 14 Aug 2007, Christian Borntraeger wrote: > > Hello Ingo, > Just a fyi: I think Ingo is on vacation this week without any internet > access, I think he'll be back next Monday. > > Linus Well d

[PATCH][RFC] Re: accounting regression since rc1

2007-08-16 Thread Christian Borntraeger
CONFIG_VIRT_CPU_ACCOUTING is set, task->utime and task->stime are returned directly instead of using sum_exec_runtime. Patch is tested on s390x with and without VIRT_CPU_ACCOUTING as well as on i386. Not tested on ppc64 - Paul? Feedback is welcome. Signed-Off-By: Christian Borntraeger &

Re: [kvm-devel] [PATCH/RFC 3/4]Introduce "account modifiers" mechanism

2007-08-17 Thread Christian Borntraeger
Am Freitag, 17. August 2007 schrieb Laurent Vivier: > > The normal user/system accounting has the same issue, no? Whereever we > > happen to land (kernel or user) gets the whole tick. > > Yes... but perhaps I should rewrite this too ;-) If you look further, you will see, that this was actually r

Fix guest time accounting going faster than user time accounting

2007-10-18 Thread Christian Borntraeger
Seems I overlooked this type while reviewing Laurents patch. cputime_add already adds, dont do it twice. Avi. This should go to Linus before 2.6.24. Signed-off-by: Christian Borntraeger <[EMAIL PROTECTED]> --- fs/proc/array.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: 2.6.23-mm1 s390 driver problem

2007-10-18 Thread Christian Borntraeger
Am Donnerstag, 18. Oktober 2007 schrieb Serge E. Hallyn: > Sigh, well this turned out less informative than I'd liked. > After bisecting 2.6.23 to 2.6.23-mm1, I found that > git-s390.patch is the one breaking my s390 boot :( > (Frown bc it's a conglomeration of patches0 > > Symptom is: > "Ca

Re: [kvm-devel] severe bug in 2.6.23+ kvm.git

2007-10-19 Thread Christian Borntraeger
Am Freitag, 19. Oktober 2007 schrieb Luca Tettamanti: > linus-git has at least one bug with SG chaining, but usually it just > hangs the machine. Patch is here: > > http://lkml.org/lkml/2007/10/17/269 Looks promising. I pulled this fix by pulling the latest Linus-git into the kvm.git. I also ena

Re: [kvm-devel] severe bug in 2.6.23+ kvm.git

2007-10-19 Thread Christian Borntraeger
Am Freitag, 19. Oktober 2007 schrieb Jan Engelhardt: > > On Oct 19 2007 15:44, Carsten Otte wrote: > > Carsten Otte wrote: > >> First thing we do, is figure whether or not 2.6.23.1 as released breaks our > >> system too. This way, we can either focus on differences between Linus and > >> Avi, or t

Re: [kvm-devel] severe bug in 2.6.23+ kvm.git

2007-10-19 Thread Christian Borntraeger
Am Freitag, 19. Oktober 2007 schrieb Laurent Vivier: > Carsten Otte a écrit : > > Laurent Vivier wrote: > >> How do you know the problem has been introduced by kvm ? > > I don't. In fact I think it has not been introduced by kvm. All I > > stated, is that we experienced the problem when running th

Re: [kvm-devel] severe bug in 2.6.23+ kvm.git

2007-10-19 Thread Christian Borntraeger
Am Freitag, 19. Oktober 2007 schrieb Laurent Vivier: > Did you patch kvm.git with patch-2.6.23.1.bz2 or did you download > linux-2.6.23.1.tar.bz2 ? > > 2.6.23.1 corrects nothing except sata_mv... Yes I know. The question we tried to answer was: is the bug in 2.6.23 or was it introduced after 2.6

Re: [PATCH] rd: Use a private inode for backing storage

2007-10-21 Thread Christian Borntraeger
Am Sonntag, 21. Oktober 2007 schrieb Eric W. Biederman: > Nick. Reread the patch. The only thing your arguments have > established for me is that this patch is not obviously correct. Which > makes it ineligible for a back port. Frankly I suspect the whole > issue is to subtle and rare to make a

Re: [git pull] lguest: paravirt boot code

2007-10-22 Thread Christian Borntraeger
ion on s390. For all virtio patches: Acked-by: Christian Borntraeger <[EMAIL PROTECTED]> That reminds me that I promised Rusty to look at one small issue in virtio net driver. Nothing that should hold of the merge. I will sent the patch via Rusty when its ready. - To unsubscribe from t

Re: [PATCH 06/10] [SG] Update net/ to use sg helpers

2007-10-23 Thread Christian Borntraeger
set_page' use the proper include file. SCTP maintainers Vlad Yasevich and Sridhar Samudrala are CCed. Signed-off-by: Christian Borntraeger <[EMAIL PROTECTED]> --- net/sctp/sm_make_chunk.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index

Re: [stable] 2.6.23 regression: top displaying 9999% CPU usage

2007-10-14 Thread Christian Borntraeger
Am Samstag, 13. Oktober 2007 schrieb Frans Pop: > > > Please consider this patch for 2.6.23.2 > > > http://lkml.org/lkml/2007/10/4/389 > > Is it already in Linus's tree? If so, do you have a git commit id? If > > not, please let us (stable@) know when it is, and what the id is, and > > then we ca

[PATCH resend] ramdisk: fix zeroed ramdisk pages on memory pressure

2007-10-15 Thread Christian Borntraeger
buffer_heads_over_limit true, which means: - lower max_buffer_heads or - have a system with lots of high memory Andrew, if there are no objections - please apply. The patch applies against todays git. Signed-off-by: Christian Borntraeger <[EMAIL PROTECTED]> --- drivers/block/rd.c

Re: [PATCH resend] ramdisk: fix zeroed ramdisk pages on memory pressure

2007-10-15 Thread Christian Borntraeger
Am Montag, 15. Oktober 2007 schrieb Nick Piggin: > On Monday 15 October 2007 18:28, Christian Borntraeger wrote: > > Andrew, this is a resend of a bugfix patch. Ramdisk seems a bit > > unmaintained, so decided to sent the patch to you :-). > > I have CCed Ted, who did work o

Re: [RESEND 2][PATCH 0/4] Virtual Machine Time Accounting

2007-10-15 Thread Christian Borntraeger
Am Montag, 10. September 2007 schrieb Laurent Vivier: > The aim of these four patches is to introduce Virtual Machine time accounting. I would move this line    if (p->flags & PF_VCPU) {    account_guest_time(p, cputime); -->   p->flags &= ~PF_VCPU; <-    

Re: [RESEND 2][PATCH 4/4] Modify KVM to update guest time accounting.

2007-10-15 Thread Christian Borntraeger
forgot to CC everybody besides Laurent: Am Montag, 15. Oktober 2007 schrieben Sie: > No, It must not be cleared here because we can't enter in the accounting code > between kvm_guest_enter(void) and kvm_guest_exit(void). > > This is why the accounting code clears it. > > I put a kvm_guest_exit()

Re: [RESEND 2][PATCH 4/4] Modify KVM to update guest time accounting.

2007-10-15 Thread Christian Borntraeger
Am Montag, 15. Oktober 2007 schrieb Avi Kivity: > We can clear it a bit later, after local_irq_enable() in __vcpu_run(). > However we need a nop instruction first because "sti" keeps interrupts > disabled for one more instruction. Ah, I see. The host interrupt behaves different and instead of

Re: [RESEND 2][PATCH 4/4] Modify KVM to update guest time accounting.

2007-10-15 Thread Christian Borntraeger
patches, as the userspace interface seems fine. To make the accounting work for virtual cpu accounting found on ppc and s390 we can later add an additional patch that also deals with interruptible guest contexts. So something like this should work: Signed-off-by: Christian Borntraeger <[EMAIL PROTECT

Re: [PATCH] rd: Mark ramdisk buffers heads dirty

2007-10-16 Thread Christian Borntraeger
hes, and the problem seems gone. I will try to get these patches to our testers. As long as they dont find new problems: Acked-by: Christian Borntraeger <[EMAIL PROTECTED]> Nick, Eric. What is the best patch for the stable series? Both patches from Eric or mine? I CCed stable, so they know

Re: [stable] 2.6.23 regression: top displaying 9999% CPU usage

2007-10-16 Thread Christian Borntraeger
that we save the old value of utime and stime and therefore requires additional locking. Otherwise I suggest to apply my reversion patch from below: Am Sonntag, 14. Oktober 2007 schrieb Christian Borntraeger: > Am Samstag, 13. Oktober 2007 schrieb Frans Pop: > > > > Please consider

Re: [PATCH] rd: Mark ramdisk buffers heads dirty

2007-10-16 Thread Christian Borntraeger
Am Dienstag, 16. Oktober 2007 schrieb Nick Piggin: > While I said it was a good fix when I saw the patch earlier, I think > it's not closing the entire hole, and as such, Christian's patch is > probably the way to go for stable. That would be my preferred method. Merge Erics and my fixup for 2.6.2

Re: [stable] 2.6.23 regression: top displaying 9999% CPU usage

2007-10-16 Thread Christian Borntraeger
Am Dienstag, 16. Oktober 2007 schrieb Balbir Singh: > I am trying to think out loud as to what the root cause of the problem > might be. In one of the discussion threads, I saw utime going backwards, > which seemed very odd, I suspect that those are rounding errors. > > I don't understand your exp

Re: [PATCH] clear PF_VCPU in kvm_guest_exit()

2007-10-17 Thread Christian Borntraeger
ked-By: Christian Borntraeger <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] rd: Mark ramdisk buffers heads dirty

2007-10-17 Thread Christian Borntraeger
Eric, Am Dienstag, 16. Oktober 2007 schrieb Christian Borntraeger: > Am Dienstag, 16. Oktober 2007 schrieb Eric W. Biederman: > > > fs/buffer.c |    3 +++ > > 1 files changed, 3 insertions(+), 0 deletions(-) > > drivers/block/rd.c | 13 + > > 1 file

Re: [PATCH] rd: Mark ramdisk buffers heads dirty

2007-10-17 Thread Christian Borntraeger
Am Mittwoch, 17. Oktober 2007 schrieb Eric W. Biederman: > Did you have both of my changes applied? > To init_page_buffer() and to the ramdisk_set_dirty_page? Yes, I removed my patch and applied both patches from you. Christian - To unsubscribe from this list: send the line "unsubscribe linux-ke

Re: [PATCH] rd: Mark ramdisk buffers heads dirty

2007-10-18 Thread Christian Borntraeger
Am Donnerstag, 18. Oktober 2007 schrieb Eric W. Biederman: > Grr. Inconsistent rules on a core piece of infrastructure. > It looks like that if there is any trivial/minimal fix it > is based on your patch suppressing try_to_free_buffers. Ugh. > > Eric Ok. What do you think about having my patch

Use virtual cpu accounting if available for guest times.

2007-10-18 Thread Christian Borntraeger
patch on s390. Avi, please apply. Signed-off-by: Christian Borntraeger <[EMAIL PROTECTED]> --- drivers/kvm/kvm.h |3 +++ 1 file changed, 3 insertions(+) Index: kvm/drivers/kvm/kvm.h === --- kvm.orig/drivers/kvm/kvm.h +

Re: Future of Linux 2.6.22.y series

2007-11-06 Thread Christian Borntraeger
Am Dienstag, 6. November 2007 schrieb Jan Kara: > In that case you might be interested in picking up the attached fix :) > I don't know if you already didn't get it... --- [PATCH] rd: fix data corruption on memory pressure --- The patch is currently in mm but not yet upstream. As soon as it is

Re: Bug: 2.6.15 Process accounting fails to account for small time slice loads (still)

2007-01-30 Thread Christian Borntraeger
ement with x86 hardware. -- Mit freundlichen Grüßen / Best Regards Christian Borntraeger Linux Software Engineer zSeries Linux & Virtualization - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo inf

Re: A set of "standard" virtual devices?

2007-04-03 Thread Christian Borntraeger
On Monday 02 April 2007 23:12, Andi Kleen wrote: > > > How would that work in the case where virtualized guests don't have a > > visible PCI bus, and the virtual environment doesn't pretend to emulate > > a PCI bus? > > If they emulated one with the appropiate device > then distribution driver a

Re: [PATCH v3 02/11] mm: Hardened usercopy

2016-07-19 Thread Christian Borntraeger
On 07/19/2016 09:31 PM, Kees Cook wrote: > On Tue, Jul 19, 2016 at 2:21 AM, Christian Borntraeger > wrote: >> On 07/15/2016 11:44 PM, Kees Cook wrote: >>> +config HAVE_ARCH_LINEAR_KERNEL_MAPPING >>> + bool >>> + help >>> + An archi

Re: [PATCH v3 02/11] mm: Hardened usercopy

2016-07-19 Thread Christian Borntraeger
On 07/19/2016 10:34 PM, Kees Cook wrote: [...] >> >> So what about for the CONFIG text: >> >>An architecture should select this if the kernel mapping has a >> secondary >>linear mapping of the kernel text - in other words more than one >> virtual >>kernel address that poin

linux-next: new scheduler messages span: 0-15 (max cpu_capacity = 589) when starting KVM guests

2016-09-19 Thread Christian Borntraeger
Dietmar, Ingo, Tejun, since commit cd92bfd3b8cb0ec2ee825e55a3aee704cd55aea9 sched/core: Store maximum per-CPU capacity in root domain I get tons of messages from the scheduler like [..] span: 0-15 (max cpu_capacity = 589) span: 0-15 (max cpu_capacity = 589) span: 0-15 (max cpu_capacity = 589)

Re: linux-next: new scheduler messages span: 0-15 (max cpu_capacity = 589) when starting KVM guests

2016-09-19 Thread Christian Borntraeger
On 09/19/2016 03:40 PM, Peter Zijlstra wrote: > On Mon, Sep 19, 2016 at 03:19:11PM +0200, Christian Borntraeger wrote: >> Dietmar, Ingo, Tejun, >> >> since commit cd92bfd3b8cb0ec2ee825e55a3aee704cd55aea9 >>sched/core: Store maximum per-CPU capacity in root domain &

Re: linux-next: new scheduler messages span: 0-15 (max cpu_capacity = 589) when starting KVM guests

2016-09-20 Thread Christian Borntraeger
On 09/19/2016 03:40 PM, Peter Zijlstra wrote: > On Mon, Sep 19, 2016 at 03:19:11PM +0200, Christian Borntraeger wrote: >> Dietmar, Ingo, Tejun, >> >> since commit cd92bfd3b8cb0ec2ee825e55a3aee704cd55aea9 >>sched/core: Store maximum per-CPU capacity in root domain &

4.7-rc1: lockdep: inconsistent lock state kcompactd/aio_migratepage/mem_cgroup_migrate....

2016-06-20 Thread Christian Borntraeger
Has anyone seen this before? [ 335.384657] = [ 335.384659] [ INFO: inconsistent lock state ] [ 335.384663] 4.7.0-rc1+ #52 Tainted: GW [ 335.384666] - [ 335.384669] inconsistent {IN-SOFTIRQ-W} -> {SOFTIRQ-ON-W} usag

[PATCH 1/1] mm/page_ref: introduce page_ref_inc_return

2016-06-20 Thread Christian Borntraeger
From: David Hildenbrand Let's introduce that helper. Signed-off-by: David Hildenbrand Signed-off-by: Christian Borntraeger --- include/linux/page_ref.h | 9 + 1 file changed, 9 insertions(+) diff --git a/include/linux/page_ref.h b/include/linux/page_ref.h index 8b5e0a9..61

[PATCH 0/1] introduce page_ref_inc_return

2016-06-20 Thread Christian Borntraeger
commit 0139aa7b7fa1 ("mm: rename _count, field of the struct page, to _refcount") changed all accesses to page->_count to use wrappers. There is already a page_ref_dec_return and we need for kvm/s390 code the function "page_ref_inc_return" as well. FWIW, the code is under https://git.kernel.org/cg

Re: [PATCH] memcg: mem_cgroup_migrate() may be called with irq disabled

2016-06-20 Thread Christian Borntraeger
71ce>] mark_lock+0x17e/0x758) > ([<001a784a>] mark_held_locks+0xa2/0xd0) > ([<001a79b8>] trace_hardirqs_on_caller+0x140/0x1c0) > ([<00326026>] mem_cgroup_migrate+0x266/0x370) > ([<0038fdaa>] aio_migratepage+0x16a/0x1e8) &

Re: [PATCH v2 0/2] x86/entry: speed up context-tracking system calls by 150 clock cycles

2016-06-21 Thread Christian Borntraeger
On 06/20/2016 04:58 PM, Paolo Bonzini wrote: > The first patches are the two optimizations I posted on May 30th > for the system call entry/exit code. The only change is in the > function names, which use the user_{enter,exit}_irqoff favored > by Andy and Ingo. The first patch matches what commit

group scheduler regression since 4.3 (bisect 9d89c257d sched/fair: Rewrite runnable load and utilization average tracking)

2016-09-26 Thread Christian Borntraeger
Folks, I have seen big scalability degredations sind 4.3 (bisected 9d89c257d sched/fair: Rewrite runnable load and utilization average tracking) This has not been fixed by subsequent patches,e.g. the ones that try to fix this for interactive workload. The problem is only visible for sleep/wakeup

Re: group scheduler regression since 4.3 (bisect 9d89c257d sched/fair: Rewrite runnable load and utilization average tracking)

2016-09-26 Thread Christian Borntraeger
On 09/26/2016 12:56 PM, Peter Zijlstra wrote: > On Mon, Sep 26, 2016 at 12:42:22PM +0200, Christian Borntraeger wrote: >> Folks, >> >> I have seen big scalability degredations sind 4.3 (bisected 9d89c257d >> sched/fair: Rewrite runnable load and utilization average tra

Re: group scheduler regression since 4.3 (bisect 9d89c257d sched/fair: Rewrite runnable load and utilization average tracking)

2016-09-26 Thread Christian Borntraeger
On 09/26/2016 01:53 PM, Peter Zijlstra wrote: > On Mon, Sep 26, 2016 at 01:42:05PM +0200, Christian Borntraeger wrote: >> On 09/26/2016 12:56 PM, Peter Zijlstra wrote: > >>> One of the differences in the old and new thing is being addressed by >>> these

Re: group scheduler regression since 4.3 (bisect 9d89c257d sched/fair: Rewrite runnable load and utilization average tracking)

2016-09-26 Thread Christian Borntraeger
On 09/26/2016 02:10 PM, Peter Zijlstra wrote: > On Mon, Sep 26, 2016 at 02:01:43PM +0200, Christian Borntraeger wrote: >> They applied ok on next from 9/13. Things go even worse. >> With this host configuration: >> >> CPU NODE BOOK SOCKET CORE L1d:L1i:L2d:L2i ONLINE

Re: group scheduler regression since 4.3 (bisect 9d89c257d sched/fair: Rewrite runnable load and utilization average tracking)

2016-09-26 Thread Christian Borntraeger
On 09/26/2016 02:10 PM, Peter Zijlstra wrote: > On Mon, Sep 26, 2016 at 02:01:43PM +0200, Christian Borntraeger wrote: >> They applied ok on next from 9/13. Things go even worse. >> With this host configuration: >> >> CPU NODE BOOK SOCKET CORE L1d:L1i:L2d:L2i ONLINE

lockdep warning in btrfs in 4.8-rc3

2016-09-08 Thread Christian Borntraeger
Chris, with 4.8-rc3 I get the following on an s390 box: [ 1094.009172] = [ 1094.009174] [ INFO: possible recursive locking detected ] [ 1094.009177] 4.8.0-rc3 #126 Tainted: GW [ 1094.009179] - [

Re: lockdep warning in btrfs in 4.8-rc3

2016-09-08 Thread Christian Borntraeger
On 09/08/2016 01:48 PM, Christian Borntraeger wrote: > Chris, > > with 4.8-rc3 I get the following on an s390 box: Sorry for the noise, just saw the fix in your pull request.

Re: [PATCH 2/4] virtio_blk: Less function calls in init_vq() after error detection

2016-09-13 Thread Christian Borntraeger
On 09/13/2016 02:13 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 13 Sep 2016 13:20:44 +0200 > > The kfree() function was called in up to three cases > by the init_vq() function during error handling even if > the passed variable contained a null pointer. > > * Split a conditi

  1   2   3   4   5   6   7   8   9   10   >