RE: [RFC] sdhci: fix DMA leaks [was: [SHDCI] Heavy (thousands) DMA leaks]

2015-08-06 Thread Chen Bough
Hi Js, I read your attached log and patch, yes, dma memory leak will happen when more than one pre_request execute. The method of ++next->cookie is not good, your patch seems good, but I still need some time to test the patch, because you unmap the dma in sdhci_finish_data rather than the sdhci_po

RE: [RFC] sdhci: fix DMA leaks [was: [SHDCI] Heavy (thousands) DMA leaks]

2015-08-06 Thread Chen Bough
gt; > On 08/06/2015, 09:42 AM, Chen Bough wrote: > > I read your attached log and patch, yes, dma memory leak will happen > > when more than one pre_request execute. The method of ++next->cookie > > is not good, your patch seems good, but I still need some time to

RE: [RFC] sdhci: fix DMA leaks [was: [SHDCI] Heavy (thousands) DMA leaks]

2015-08-24 Thread Chen Bough
Haibo-B51421; Jiri Slaby; Ulf Hansson > Cc: linux-...@vger.kernel.org; Linux kernel mailing list > Subject: Re: [RFC] sdhci: fix DMA leaks [was: [SHDCI] Heavy (thousands) > DMA leaks] > > On 08/06/2015 02:17 AM, Chen Bough wrote: > > I will format a patch based on your diff file

RE: [SHDCI] Heavy (thousands) DMA leaks

2015-07-30 Thread Chen Bough
Hi Jiri, I will check this issue ASAP, thanks for report this! Best Regards Haibo Chen > -Original Message- > From: Jiri Slaby [mailto:jsl...@suse.cz] > Sent: Thursday, July 30, 2015 5:32 PM > To: Chen Haibo-B51421 > Cc: Ulf Hansson; linux-...@vger.kernel.org; Linux kernel mailing list

RE: [PATCH 5/5] ARM: dts: imx6ul-14x14-evk.dts: add tsc support

2015-07-28 Thread Chen Bough
> -Original Message- > From: Shawn Guo [mailto:shawn...@kernel.org] > Sent: Monday, July 27, 2015 10:13 PM > To: Chen Haibo-B51421 > Cc: robh...@kernel.org; pawel.m...@arm.com; mark.rutl...@arm.com; > ijc+devicet...@hellion.org.uk; ga...@codeaurora.org; > ker...@pengutronix.de; li...@arm.

RE: [PATCH 1/5] input: touchscreen: add imx6ul_tsc driver support

2015-07-28 Thread Chen Bough
Hi Dmitry, Thanks for your careful review! My comments is following. Best Regards Haibo Chen > -Original Message- > From: Dmitry Torokhov [mailto:dmitry.torok...@gmail.com] > Sent: Tuesday, July 28, 2015 6:05 AM > To: Chen Haibo-B51421 > Cc: robh...@kernel.org; pawel.m...@arm.com; ma

RE: [PATCH 2/5] Documentation: Detail permitted DT properties for the imx6ul_tsc

2015-07-28 Thread Chen Bough
Hi Mark, > -Original Message- > From: Mark Rutland [mailto:mark.rutl...@arm.com] > Sent: Monday, July 27, 2015 7:26 PM > To: Chen Haibo-B51421 > Cc: robh...@kernel.org; Pawel Moll; ijc+devicet...@hellion.org.uk; > ga...@codeaurora.org; shawn...@kernel.org; ker...@pengutronix.de; > li...@

RE: [PATCH v4 1/4] iio: adc: add IMX7D ADC driver support

2015-12-01 Thread Chen Bough
> -Original Message- > From: Peter Meerwald-Stadler [mailto:pme...@pmeerw.net] > Sent: Tuesday, December 01, 2015 4:51 PM > To: Chen Haibo-B51421 > Cc: ji...@kernel.org; knaac...@gmx.de; l...@metafoo.de; > shawn...@kernel.org; linux-...@vger.kernel.org; linux- > ker...@vger.kernel.org > Su

RE: [PATCH v5 1/4] iio: adc: add IMX7D ADC driver support

2015-12-13 Thread Chen Bough
Hi Jonathan, Thanks for your careful and patient review! Best Regards Haibo Chen > -Original Message- > From: Jonathan Cameron [mailto:ji...@kernel.org] > Sent: Sunday, December 13, 2015 1:03 AM > To: Chen Haibo-B51421; knaac...@gmx.de; l...@metafoo.de; > pme...@pmeerw.net; shawn...@ker

RE: [SHDCI] Heavy (thousands) DMA leaks

2015-08-03 Thread Chen Bough
Hi Js, I carefully review my patch, all the DMA memory mapped in sdhci_pre_req() is unmapped in sdhci_post_req. Can you provide the method of your testing DMA leaks? You said over 4000 leaked mappings during one card transfer, if true, We can't map any dma memory after some sd transfer, do yo

RE: [PATCH v2 1/5] input: touchscreen: add imx6ul_tsc driver support

2015-08-21 Thread Chen Bough
Hi Dmitry, Thanks for your patient review, especially for the patch you attached. I test your patch these days, with below change, touch can work normally. (also change the xnur to active low in dts) In probe function: > - tsc->xnur_gpio = of_get_named_gpio(np, "xnur-gpio", 0); > - err

RE: [PATCH v2 2/5] Documentation: Detail permitted DT properties for the imx6ul_tsc

2015-08-21 Thread Chen Bough
Hi Markus, > -Original Message- > From: Markus Pargmann [mailto:m...@pengutronix.de] > Sent: Wednesday, August 19, 2015 1:55 PM > To: Chen Haibo-B51421 > Cc: robh...@kernel.org; pawel.m...@arm.com; mark.rutl...@arm.com; > ijc+devicet...@hellion.org.uk; ga...@codeaurora.org; shawn...@kernel

RE: [PATCH v2 1/5] input: touchscreen: add imx6ul_tsc driver support

2015-08-24 Thread Chen Bough
Hi Markus, > -Original Message- > From: Markus Pargmann [mailto:m...@pengutronix.de] > Sent: Friday, August 21, 2015 5:26 PM > To: Chen Haibo-B51421 > Cc: robh...@kernel.org; pawel.m...@arm.com; mark.rutl...@arm.com; > ijc+devicet...@hellion.org.uk; ga...@codeaurora.org; shawn...@kernel.

RE: [PATCH v2 2/5] Documentation: Detail permitted DT properties for the imx6ul_tsc

2015-08-24 Thread Chen Bough
ntation: Detail permitted DT properties > for the imx6ul_tsc > > On Fri, Aug 21, 2015 at 08:30:16AM +, Chen Bough wrote: > > Hi Markus, > > > > > -Original Message- > > > From: Markus Pargmann [mailto:m...@pengutronix.de] > > > Sent: Wednesd

RE: [PATCH v2 0/5] Add imx6ul touch screen controller support

2015-08-12 Thread Chen Bough
Hi all, Any suggestion about these patch set? Since half month passed without any response. > -Original Message- > From: Haibo Chen [mailto:haibo.c...@freescale.com] > Sent: Tuesday, July 28, 2015 5:59 PM > To: robh...@kernel.org; pawel.m...@arm.com; mark.rutl...@arm.com; > ijc+device

[Bug] compile error

2015-12-29 Thread Chen Bough
Hi, For the latest linux-next tree[tag: v4.4-rc6], I meet one compile error, drivers/media/usb/uvc/uvc_driver.c: In function 'uvc_probe': drivers/media/usb/uvc/uvc_driver.c:1941:32: error: 'struct uvc_device' has no member named 'mdev' if (media_device_register(&dev->mdev) < 0)