Consolidating similar algorithms into common functions to make
GPIO SCH simpler and manageable.
Signed-off-by: Chang Rebecca Swee Fun
Reviewed-by: Mika Westerberg
Reviewed-by: Alexandre Courbot
---
drivers/gpio/gpio-sch.c | 81 +
1 file changed
ration.
- Changed sch_gpio_enable()/sch_gpio_disable() to sch_gpio_register_set()/
sch_gpio_register_clear().
Patch 3:
- Changed all sch_gpio_enable()/sch_gpio_disable() to sch_gpio_register_set()/
sch_gpio_register_clear().
Version 1:
Initial version.
Chang Rebecca Swee Fun (2):
gpio: sch: Consolidate si
work is derived from Dan O'Donovan's initial work for Quark
X1000 enabling.
Signed-off-by: Chang Rebecca Swee Fun
Reviewed-by: Mika Westerberg
Reviewed-by: Alexandre Courbot
---
drivers/gpio/Kconfig| 11 +--
drivers/gpio/gpio-sch.c | 6 ++
2 files changed, 15 insert
linux-next.git.
The patches has been built and tested working on Intel Galileo board.
Thank you.
Regards
Rebecca
Chang Rebecca Swee Fun (3):
gpio: sch: Consolidate similar algorithms
gpio: sch: Add support for Intel Quark X1000 SoC
gpio: sch: Enable IRQ support for Quark X1000
drivers/gp
work is derived from Dan O'Donovan's initial work for Quark
X1000 enabling.
Signed-off-by: Chang Rebecca Swee Fun
---
drivers/gpio/Kconfig| 11 +--
drivers/gpio/gpio-sch.c |6 ++
2 files changed, 15 insertions(+), 2 deletions(-)
diff --git a/drivers/gpio/Kconfig
Consolidating similar algorithms into common functions to make
GPIO SCH simpler and manageable.
Signed-off-by: Chang Rebecca Swee Fun
---
drivers/gpio/gpio-sch.c | 95 ++-
1 file changed, 53 insertions(+), 42 deletions(-)
diff --git a/drivers/gpio
for
Quark X1000 enabling.
Signed-off-by: Chang Rebecca Swee Fun
---
drivers/gpio/gpio-sch.c | 267 ---
1 file changed, 253 insertions(+), 14 deletions(-)
diff --git a/drivers/gpio/gpio-sch.c b/drivers/gpio/gpio-sch.c
index 38d6e74..c6c64a5 100644
---
> -Original Message-
> From: Mika Westerberg [mailto:mika.westerb...@linux.intel.com]
> Sent: 18 September, 2014 7:23 PM
> To: Chang, Rebecca Swee Fun
> Cc: Linus Walleij; linux-g...@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH 2/3] gpio: sch: Add
Replied inline. :)
> -Original Message-
> From: Mika Westerberg [mailto:mika.westerb...@linux.intel.com]
> Sent: 18 September, 2014 7:17 PM
> To: Chang, Rebecca Swee Fun
> Cc: Linus Walleij; linux-g...@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PA
> -Original Message-
> From: 'Mika Westerberg' [mailto:mika.westerb...@linux.intel.com]
> Sent: 22 September, 2014 5:25 PM
> To: Chang, Rebecca Swee Fun
> Cc: Linus Walleij; linux-g...@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH 1/3] gp
> -Original Message-
> From: 'Mika Westerberg' [mailto:mika.westerb...@linux.intel.com]
> Sent: 24 September, 2014 5:51 PM
> To: Chang, Rebecca Swee Fun
> Cc: Linus Walleij; linux-g...@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH 1/3] gp
> > @@ -203,6 +376,17 @@ static int sch_gpio_probe(struct platform_device
> *pdev)
> > pdev->name))
> > return -EBUSY;
> >
> > + irq = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
> > + sch->irq_support = !!irq;
> > + if (sch->irq_support) {
> > +
> -Original Message-
> From: 'Mika Westerberg' [mailto:mika.westerb...@linux.intel.com]
> Sent: 26 September, 2014 5:18 PM
> To: Chang, Rebecca Swee Fun
> Cc: Linus Walleij; linux-g...@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH 3/3] g
es in MFD (lpc_sch.c) required in order
to support gpio-sch has been merged into linux-next.git.
The patches has been built and tested working on Intel Galileo board.
Thank you.
Regards
Rebecca
Chang Rebecca Swee Fun (3):
gpio: sch: Consolidate similar algorithms
gpio: sch: Add support for Intel Qu
Consolidating similar algorithms into common functions to make
GPIO SCH simpler and manageable.
Signed-off-by: Chang Rebecca Swee Fun
---
drivers/gpio/gpio-sch.c | 95 ++-
1 file changed, 53 insertions(+), 42 deletions(-)
diff --git a/drivers/gpio
for
Quark X1000 enabling.
Signed-off-by: Chang Rebecca Swee Fun
---
drivers/gpio/gpio-sch.c | 267 ---
1 file changed, 253 insertions(+), 14 deletions(-)
diff --git a/drivers/gpio/gpio-sch.c b/drivers/gpio/gpio-sch.c
index 952990f..332ffaf 100644
---
work is derived from Dan O'Donovan's initial work for Quark
X1000 enabling.
Signed-off-by: Chang Rebecca Swee Fun
---
drivers/gpio/Kconfig| 11 +--
drivers/gpio/gpio-sch.c |6 ++
2 files changed, 15 insertions(+), 2 deletions(-)
diff --git a/drivers/gpio/Kconfig
> -Original Message-
> From: Andy Shevchenko [mailto:andriy.shevche...@linux.intel.com]
> Sent: 01 September, 2014 5:14 PM
> To: Bjorn Helgaas
> Cc: Lee Jones; linux-kernel@vger.kernel.org; Samuel Ortiz; Chang, Rebecca
> Swee Fun; Ahmad, Josef
> Subject: Re: [PATCH
> -Original Message-
> From: Andy Shevchenko [mailto:andriy.shevche...@linux.intel.com]
> Sent: 01 September, 2014 6:25 PM
> To: Lee Jones
> Cc: Bjorn Helgaas; linux-kernel@vger.kernel.org; Samuel Ortiz; Chang, Rebecca
> Swee Fun
> Subject: Re: [PATCH v1 2/5] mfd:
Thanks for the review comments. Please check my reply below.
> -Original Message-
> From: Alexandre Courbot [mailto:gnu...@gmail.com]
> Sent: 17 October, 2014 4:44 PM
> To: Chang, Rebecca Swee Fun
> Cc: Linus Walleij; Westerberg, Mika; GPIO Subsystem Mailing List; Linux K
> > +
> > +static int sch_gpio_irq_type(struct irq_data *d, unsigned type)
> > +{
> > + struct sch_gpio *sch = container_of(d, struct sch_gpio, data);
> > + unsigned long flags;
> > + u32 gpio_num;
> > +
> > + if (d == NULL)
> > + return -EINVAL;
> > +
> > +
Sorry for the late reply, was working on something else.
> -Original Message-
> From: Westerberg, Mika
> Sent: 16 October, 2014 6:19 PM
> To: Chang, Rebecca Swee Fun
> Cc: Linus Walleij; GPIO Subsystem Mailing List; Linux Kernel Mailing List;
> Denis
> Turischev
>
> -Original Message-
> From: Alexandre Courbot [mailto:gnu...@gmail.com]
> Sent: 09 October, 2014 2:29 PM
> To: Chang, Rebecca Swee Fun
> Cc: Linus Walleij; Westerberg, Mika; GPIO Subsystem Mailing List; Linux Kernel
> Mailing List
> Subject: Re: [PATCHv2 0/3] Enabl
> -Original Message-
> From: Linus Walleij [mailto:linus.wall...@linaro.org]
> Sent: 15 October, 2014 3:13 PM
> To: Chang, Rebecca Swee Fun; Denis Turischev
> Cc: Westerberg, Mika; GPIO Subsystem Mailing List; Linux Kernel Mailing List
> Subject: Re: [PATCHv2 3/3] gpi
Consolidating similar algorithms into common functions to make
GPIO SCH simpler and manageable.
Signed-off-by: Chang Rebecca Swee Fun
---
drivers/gpio/gpio-sch.c | 95 ++-
1 file changed, 53 insertions(+), 42 deletions(-)
diff --git a/drivers/gpio
for
Quark X1000 enabling.
Signed-off-by: Chang Rebecca Swee Fun
---
drivers/gpio/gpio-sch.c | 257 ---
1 file changed, 245 insertions(+), 12 deletions(-)
diff --git a/drivers/gpio/gpio-sch.c b/drivers/gpio/gpio-sch.c
index 952990f..dd84b1f 100644
---
_set() to avoid forward declaration.
- Changed sch_gpio_enable()/sch_gpio_disable() to sch_gpio_register_set()/
sch_gpio_register_clear().
Patch 3:
- Changed all sch_gpio_enable()/sch_gpio_disable() to sch_gpio_register_set()/
sch_gpio_register_clear().
Version 1:
Initial version.
Chang Rebe
work is derived from Dan O'Donovan's initial work for Quark
X1000 enabling.
Signed-off-by: Chang Rebecca Swee Fun
---
drivers/gpio/Kconfig| 11 +--
drivers/gpio/gpio-sch.c |6 ++
2 files changed, 15 insertions(+), 2 deletions(-)
diff --git a/drivers/gpio/Kconfig
Consolidating similar algorithms into common functions to make
GPIO SCH simpler and manageable.
Signed-off-by: Chang Rebecca Swee Fun
---
drivers/gpio/gpio-sch.c | 81 ---
1 file changed, 28 insertions(+), 53 deletions(-)
diff --git a/drivers/gpio
)/sch_gpio_disable() to sch_gpio_register_set()/
sch_gpio_register_clear().
Version 1:
Initial version.
Chang Rebecca Swee Fun (3):
gpio: sch: Consolidate similar algorithms
gpio: sch: Add support for Intel Quark X1000 SoC
gpio: sch: Enable IRQ support for Quark X1000
drivers/gpio/Kconfi
for
Quark X1000 enabling.
Signed-off-by: Chang Rebecca Swee Fun
---
drivers/gpio/gpio-sch.c | 231 +--
1 file changed, 224 insertions(+), 7 deletions(-)
diff --git a/drivers/gpio/gpio-sch.c b/drivers/gpio/gpio-sch.c
index 1a465bb..498746c 100644
--- a/dr
work is derived from Dan O'Donovan's initial work for Quark
X1000 enabling.
Signed-off-by: Chang Rebecca Swee Fun
Reviewed-by: Mika Westerberg
---
drivers/gpio/Kconfig| 11 +--
drivers/gpio/gpio-sch.c |6 ++
2 files changed, 15 insertions(+), 2 deletions(-)
di
November, 2014 10:03 PM
> To: Chang, Rebecca Swee Fun
> Cc: Linux Kernel Mailing List; GPIO Subsystem Mailing List; Westerberg, Mika;
> Denis Turischev; Alexandre Courbot
> Subject: Re: [PATCHv4 3/3] gpio: sch: Enable IRQ support for Quark X1000
>
> On Wed, Nov 26, 2014 at 5:48
.
Please review the patch and provide feedback if any. Thanks.
Regards,
Rebecca
Chang Rebecca Swee Fun (1):
gpio: sch: Consolidate similar algorithms
drivers/gpio/gpio-sch.c | 83 +
1 file changed, 29 insertions(+), 54 deletions(-)
--
1.9.1
-
Consolidating similar algorithms into common functions to make
GPIO SCH simpler and manageable.
Signed-off-by: Chang Rebecca Swee Fun
---
drivers/gpio/gpio-sch.c | 83 +
1 file changed, 29 insertions(+), 54 deletions(-)
diff --git a/drivers/gpio
Hi both,
Noted with thanks!
Rebecca
> -Original Message-
> From: Westerberg, Mika
> Sent: 22 January, 2015 5:46 PM
> To: Chang, Rebecca Swee Fun
> Cc: Linus Walleij; Alexandre Courbot; GPIO Subsystem Mailing List; Linux
> Kernel
> Mailing List
> Subject: R
36 matches
Mail list logo
