Looks good to me.
Just 's/supplics/supplies/'.
Without looking into the entire code, If we can change the type of
max_reconnect and nr_reconnects to unsigned int then we can just get away with
the one comparison (ctrl->nr_reconnects < ctrl->opts->max_reconnects).
Will send out a path.
On 12/16/18, 8:26 AM, "Christoph Hellwig" wrote:
Thanks, applied.
Maybe it might be worth adding a NVME_NO_ERR_LOC defintion to clean
this up a bit more. Chaitanya, can you look into that?
On 4/8/24 10:02, ni.liqiang wrote:
> In our testing of the virtio hardware accelerator, we found that
> configuring the flags of the descriptor after addr and len,
> as implemented in DPDK, seems to be more friendly to the hardware.
please describe in detail "friendly to the hardware" means ..
> I
On 2/14/21 20:28, Hyeongseok Kim wrote:
> add FITRIM ioctl to support trimming mounted filesystem
>
> Signed-off-by: Hyeongseok Kim
> ---
> fs/exfat/balloc.c | 89 +
> fs/exfat/exfat_fs.h | 1 +
> fs/exfat/file.c | 33 +
> 3 files
On 2/16/21 14:36, Hyeongseok Kim wrote:
> Initialize empty ioctl function
>
> Signed-off-by: Hyeongseok Kim
This patch doesn't do much, but this commit log could be better.
Also from my experience there is not point in introducing an empty
function.
On 2/16/21 14:36, Hyeongseok Kim wrote:
> +static int exfat_ioctl_fitrim(struct inode *inode, unsigned long arg)
> +{
> + struct super_block *sb = inode->i_sb;
Do you really need sb variable ? it is only used once if I'm not wrong.
> + struct request_queue *q = bdev_get_queue(sb->s_bdev);
>
On 2/16/21 16:13, Hyeongseok Kim wrote:
> Sorry, I don't understand exactly.
> You're saying that these 2 patch should be merged to a single patch?
> Would it be better?
I think so unless there is a specific reason for this to keep it isolated.
On 4/7/21 04:10, Colin King wrote:
> From: Colin Ian King
>
> There is a spelling mistake in a pr_err error message. Fix it.
>
> Signed-off-by: Colin Ian King
> ---
Looks good.
Reviewed-by: Chaitanya Kulkarni
On 4/8/21 22:21, Naresh Kamboju wrote:
> Linux next tag 20210408 architecture sh builds failed due to these errors.
>
> # to reproduce this build locally:
>
> make --silent --keep-going --jobs=8
> O=/home/tuxbuild/.cache/tuxmake/builds/1/tmp ARCH=sh
> CROSS_COMPILE=sh4-linux-gnu- 'CC=sccache sh4-li
Naresh,
On 4/8/21 22:31, Chaitanya Kulkarni wrote:
> On 4/8/21 22:21, Naresh Kamboju wrote:
>> Linux next tag 20210408 architecture sh builds failed due to these errors.
>>
>> # to reproduce this build locally:
>>
>> make --silent --keep-going --jobs=8
>> O
On 4/8/21 23:24, Naresh Kamboju wrote:
>> bio_offset(req->bio),
>> GDROM_DMA_STARTADDR_REG);
>> __raw_writel(block_cnt * GDROM_HARD_SECTOR, GDROM_DMA_LENGTH_REG);
>> __raw_writel(1, GDROM_DMA_DIRECTION_REG);
> Thanks for your patch.
> After applying this typo
Thanks for the fix Enrico. I'm still wondering on what platform
you got this error ?
Looks good.
Reviewed-by: Chaitanya Kulkarni
On 04/24/2019 03:35 AM, Enrico Weigelt, metux IT consult wrote:
> Build breaks:
>
> drivers/nvme/target/core.c: In function '
The function blk_put_request() is just a wrapper to
blk_mq_free_request(), remove the unnecessary wrapper.
Any feedback is welcome on this RFC.
Signed-off-by: Chaitanya Kulkarni
---
block/blk-core.c | 6 --
block/blk-merge.c | 2 +-
block/bsg-lib.c
On 2/22/21 13:01, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
> 179d16007236 ("block: remove superfluous param in blk_fill_rwbs()")
>
> Fixes tag
>
> Fixes: 1b9a9ab78b0 ("blktrace: use op accessors")
>
> has these problem(s):
>
> - SHA1 should be at least 12 digits long
> Can be fix
On 2/22/21 19:07, John Stultz wrote:
> [ 34.784901] ueventd: LoadWithAliases was unable to load platform:regulatory
> [ 34.785313] bio_alloc_bioset+0x14/0x230
> [ 34.796189] bio_clone_fast+0x28/0x80
> [ 34.799848] bio_split+0x50/0xd0
> [ 34.803072] blk_crypto_fallback_encrypt_bio+0x2e
Christoph,
On 2/22/21 19:07, John Stultz wrote:
> [ 34.785313] bio_alloc_bioset+0x14/0x230
> [ 34.796189] bio_clone_fast+0x28/0x80
> [ 34.799848] bio_split+0x50/0xd0
> [ 34.803072] blk_crypto_fallback_encrypt_bio+0x2ec/0x5e8
> [ 34.808384] blk_crypto_fallback_bio_prep+0xfc/0x140
> [
On 2/22/21 20:22, John Stultz wrote:
> On Mon, Feb 22, 2021 at 7:39 PM Chaitanya Kulkarni
> wrote:
>> On 2/22/21 19:07, John Stultz wrote:
>>> [ 34.784901] ueventd: LoadWithAliases was unable to load
>>> platform:regulatory
>>> [ 34.785313] bio_al
On 2/22/21 23:10, Christoph Hellwig wrote:
> Well, that is a somewhat odd calling convention. What about the patch below
> instead? That being we really need to kill this bouncing code off..
If we can kill it off soon it will be great.
>
> diff --git a/block/bounce.c b/block/bounce.c
> index fc55
On 2/22/21 23:10, Christoph Hellwig wrote:
> On Tue, Feb 23, 2021 at 03:51:23AM +0000, Chaitanya Kulkarni wrote:
>> Looking at the other call sites do we need something like following ?
>> Since __blk_queue_bounce() passes the NULL for the passthru case as a
>> bio_set valu
it is :-
Signed-off-by: Chaitanya Kulkarni .
I'll review the patch(es) once you post again.
On 2/23/21 18:31, Stephen Rothwell wrote:
> Hi all,
>
> After merging the block tree, today's linux-next build (htmldocs)
> produced this warning:
>
> kernel/trace/blktrace.c:1878: warning: Function parameter or member 'rwbs'
> not described in 'blk_fill_rwbs'`
>
> Introduced by commit
>
> 1f83b
Stephen,
On 2/23/21 18:31, Stephen Rothwell wrote:
> Hi all,
>
> After merging the block tree, today's linux-next build (htmldocs)
> produced this warning:
>
> kernel/trace/blktrace.c:1878: warning: Function parameter or member 'rwbs'
> not described in 'blk_fill_rwbs'`
>
> Introduced by commit
>
On 2/23/21 21:33, Stephen Rothwell wrote:
>> I've failed to understand this warning as rwbs is present in the doc header
>> and in the function parameter :-
> I presume it is the missing ':' after @rwbs in the comment.
Thanks, I was looking at the wrong places all this time, will send a fix.
I'll
On 2/23/21 21:33, Stephen Rothwell wrote:
>>> 1f83bb4b4914 ("blktrace: add blk_fill_rwbs documentation comment")
>>>
>>> -- Cheers, Stephen Rothwell
>> I've failed to understand this warning as rwbs is present in the doc header
>> and in the function parameter :-
> I presume it is the missing '
On 2/24/21 02:43, Stephen Rothwell wrote:
>> I'll setup doc generation using sphinx on my machine, is there
>> a particular command line that you have used for these warnings ?
> I just do a "make htmldocs"
I did that, please have a look at the test log.
Randy,
On 2/24/21 13:45, Randy Dunlap wrote:
> On 2/24/21 1:41 PM, Chaitanya Kulkarni wrote:
>> On 2/24/21 02:43, Stephen Rothwell wrote:
>>>> I'll setup doc generation using sphinx on my machine, is there
>>>> a particular command line that you have use
On 2/24/21 10:56, Christoph Hellwig wrote:
> On Wed, Feb 24, 2021 at 09:48:21AM -0700, Jens Axboe wrote:
>> Would make sense to rename blk_get_request() to blk_mq_alloc_request()
>> and then we have API symmetry. The get/put don't make sense when there
>> are no references involved.
>>
>> But it's
n1563...@iweiny-desk2.sc.intel.com/
>
> Cc: Boris Pismenny
> Cc: Or Gerlitz
> Cc: Dave Hansen
> Suggested-by: Matthew Wilcox
> Suggested-by: Christoph Hellwig
> Suggested-by: Dan Williams
> Suggested-by: Al Viro
> Suggested-by: Eric Biggers
> Signed-off-by: Ira Weiny
Thanks for adding a new line in the new calls after variable declaration.
Looks good.
Reviewed-by: Chaitanya Kulkarni
On 2/9/21 22:25, ira.we...@intel.com wrote:
> From: Ira Weiny
>
> kmap_local_page() is more efficient and is well suited for these calls.
> Convert the kmap() to kmap_local_page()
>
> Cc: Andrew Morton
> Cc: Christoph Hellwig
> Signed-off-by: Ira Weiny
Looks good.
Christoph Hellwig
> Signed-off-by: Ira Weiny
Looks good.
Reviewed-by: Chaitanya Kulkarni
On 2/9/21 22:25, ira.we...@intel.com wrote:
> From: Ira Weiny
>
> Add VM_BUG_ON bounds checks to ensure the newly lifted and created page
> memory operations do not result in corrupted data in neighbor pages and
> to make them consistent with zero_user().[1][2]
>
I did not understand this, in my t
uot;Unused value")
> Fixes: b63534c41e20 ("io_uring: re-issue block requests that failed because
> of resources")
> Signed-off-by: Colin Ian King
Looks good.
Reviewed-by: Chaitanya Kulkarni
https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git
> xfs-5.12-merge
> head: 560ab6c0d12ebccabb83638abe23a7875b946f9a
> commit: 37444fc4cc398266fe0f71a9c0925620d44fb76a [25/36] xfs: lift writable
> fs check up into log worker task
Looks good.
Reviewed-by: Chaitanya Kulkarni
On 2/16/21 22:07, Hyeongseok Kim wrote:
> Add FITRIM ioctl to enable discarding unused blocks while mounted.
> As current exFAT doesn't have generic ioctl handler, add empty ioctl
> function first, and add FITRIM handler.
>
> Signed-off-by: Hyeongseok Kim
Looks good.
Re
On 2/17/21 14:03, Pavel Machek wrote:
> Hi!
>> diff --git a/kernel/power/swap.c b/kernel/power/swap.c
>> index c73f2e295167..e92e36c053a6 100644
>> --- a/kernel/power/swap.c
>> +++ b/kernel/power/swap.c
>> @@ -271,13 +271,12 @@ static int hib_submit_io(int op, int op_flags, pgoff_t
>> page_off, vo
ent_fetch_work(struct work_struct
> *work)
> agent->state = AGENT_STATE_SUSPENDED;
>
> spin_unlock_bh(&agent->lock);
> - };
> + }
> }
>
> static struct sbp_target_agent *sbp_target_agent_register(
Looks good.
Reviewed-by: Chaitanya Kulkarni
On 2/2/21 18:39, Ming Lei wrote:
> + /* fall through */
> case REQ_OP_WRITE_ZEROES:
> - return 0;
I don't think returning 1 for write-zeroes is right,
did you test this patch with write-zeores enabled controller with
the right fs that triggers this behavior ?
On 2/2/21 18:39, Ming Lei wrote:
> + struct bio *bio = rq->bio;
> + for_each_bio(bio)
> + nr_phys_segs++;
> + return nr_phys_segs;
> + }
Also, you need to add a new line after declaration of bio in t
On 2/1/21 13:27, Jianxiong Gao wrote:
>> Why is this setting being done and undone on each IO? Wouldn't it be
>> more efficient to set it once during device initialization?
>>
>> And more importantly, this isn't thread safe: one CPU may be setting the
>> device's dma alignment mask to 0 while anoth
se scnprintf or sprintf.
> ./drivers/nvme/host/core.c:3526:8-16: WARNING: use scnprintf or sprintf.
> ./drivers/nvme/host/core.c:2833:8-16: WARNING: use scnprintf or sprintf.
>
> Reported-by: Abaci Robot
> Signed-off-by: Jiapeng Chong
Looks good.
Reviewed-by: Chaitanya Kulkarni
> Signed-off-by: John Hubbard
Looks good.
Reviewed-by: Chaitanya Kulkarni
On 2/4/21 20:55, Amy Parker wrote:
> Many single-line statements have unnecessary braces, and some statement pairs
> have mismatched braces. This is a clear violation of the kernel style guide,
> which mandates that single line statements have no braces and that pairs with
> at least one multi-l
On 2/4/21 21:01, Amy Parker wrote:
>> Commit message is too long. Follow the style present in the tree.
> Are you referring to the per-line length? That was supposed to have
> been broken up, my apologies. Or is it the overall length that is the
> issue?
>
>-Amy IP
>
Per line length. I think it
_UP in dm-log-writes.c
>> - Use DIV_ROUND_UP in iomap/buffered-io.c
Looks good.
Reviewed-by: Chaitanya Kulkarni
On 2/27/21 06:49, Steven Rostedt wrote:
> On Sat, 27 Feb 2021 19:44:40 +0800
> kernel test robot wrote:
>
>> [ 20.216017] WARNING: CPU: 0 PID: 1 at kernel/trace/trace.c:8370
>> create_trace_option_files (kbuild/src/consumer/kernel/trace/trace.c:8370
>> (discriminator 1))
>> [ 20.218480] Mod
; blk_done_softirq+0x187/0x1e0
> __do_softirq+0x118/0x595
> run_ksoftirqd+0x35/0x50
> smpboot_thread_fn+0x1d3/0x310
> kthread+0x1e7/0x210
> ret_from_fork+0x22/0x30
>
> Fixes: be93e87e7802 ("nvme: support for multiple Command Sets Supported and
> Effects log pages")
> Signed-off-by: Logan Gunthorpe
Thanks for this fix, looks good.
Tested-by: Chaitanya Kulkarni
Reviewed-by: Chaitanya Kulkarni
ng
Looks good.
Reviewed-by: Chaitanya Kulkarni
Signed-off-by: Chaitanya Kulkarni
---
drivers/nvme/target/passthru.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/nvme/target/passthru.c b/drivers/nvme/target/passthru.c
index 89d91dc999a6..b56292c9a76c 100644
--- a/drivers/nvme/target/passthru.c
+++ b/drivers/n
On 8/5/20 18:09, Sagi Grimberg wrote:
>
>> This patch adds a check in nvmet_execute_passthru_cmd() to prevent the
>> following oops :-
>
> Why LKML and not linux-nvme?
>
My bad (+linux-nvme).
On 8/5/20 18:15, Sagi Grimberg wrote:
> It doesn't have the patch. can you resend?
Okay.
On 1/9/21 13:29, Pavel Begunkov wrote:
> On 09/01/2021 20:52, Chaitanya Kulkarni wrote:
>> On 1/9/21 12:40, Pavel Begunkov wrote:
>>> I expect you won't find any, but such little things can pile up
>>> into a not-easy-to-spot overhead over time.
>> That
On 1/10/21 18:32, Pavel Begunkov wrote:
> On 11/01/2021 02:06, Chaitanya Kulkarni wrote:
>> On 1/9/21 13:29, Pavel Begunkov wrote:
>>> On 09/01/2021 20:52, Chaitanya Kulkarni wrote:
>>>> On 1/9/21 12:40, Pavel Begunkov wrote:
>>>>> I expect you won&#
On 12/11/20 08:45, Puranjay Mohan wrote:
> PCI core calls __pcie_print_link_status() for every device, it prints
> both the link width and the link speed. skd_pci_info() does the same
> thing again, hence it can be removed.
>
> Signed-off-by: Puranjay Mohan
> ---
> drivers/block/skd_main.c | 31 -
blem this patch causes?
You are not, I'm just not sure without any documentation why does
it print "unknown" and I attributed that to probable firmware issue
(since we all knowhow creative firmware can get ;)).
That makes it the problem with original code more so than with this patch.
In that case I was proposing just keep the original behavior.
But maybe we should apply patch and if any user(s) comes up with the problem
then we can deal with it.
Whoever is going to apply they can add :-
Reviewed-by: Chaitanya Kulkarni
On 1/17/21 1:00 AM, Dinghao Liu wrote:
> Once we have called device_initialize(), we should use put_device() to
> give up the reference on error, just like what we have done on failure
> of device_add().
>
> Signed-off-by: Dinghao Liu
Looks good.
Reviewed-by: Chaitanya Kulkarni
code. Subsequent patches use this function to reduce repeated code.
Signed-off-by: Chaitanya Kulkarni
---
block/blk-lib.c | 13 +
include/linux/bio.h | 13 +
2 files changed, 18 insertions(+), 8 deletions(-)
diff --git a/block/blk-lib.c b/block/blk-lib.c
index
Signed-off-by: Chaitanya Kulkarni
---
drivers/md/dm-bufio.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/md/dm-bufio.c b/drivers/md/dm-bufio.c
index 9c1a86bde658..1295e7e33e06 100644
--- a/drivers/md/dm-bufio.c
+++ b/drivers/md/dm-bufio.c
@@ -633,11 +633,8
shows code level benefits of this helper :-
??38 files changed, 124 insertions(+), 236 deletions(-)
-ck
Chaitanya Kulkarni (37):
block: introduce bio_init_fields() helper
fs: use bio_init_fields in block_dev
btrfs: use bio_init_fields in disk-io
btrfs: use bio_init_fields in volumes
ext4
Signed-off-by: Chaitanya Kulkarni
---
fs/jfs/jfs_logmgr.c | 16
1 file changed, 4 insertions(+), 12 deletions(-)
diff --git a/fs/jfs/jfs_logmgr.c b/fs/jfs/jfs_logmgr.c
index 9330eff210e0..ee7407ca32c0 100644
--- a/fs/jfs/jfs_logmgr.c
+++ b/fs/jfs/jfs_logmgr.c
@@ -1980,15
Signed-off-by: Chaitanya Kulkarni
---
fs/gfs2/meta_io.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/fs/gfs2/meta_io.c b/fs/gfs2/meta_io.c
index 2db573e31f78..822489b10aec 100644
--- a/fs/gfs2/meta_io.c
+++ b/fs/gfs2/meta_io.c
@@ -217,8 +217,8 @@ static void
Signed-off-by: Chaitanya Kulkarni
---
fs/btrfs/volumes.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
index ee086fc56c30..836167212252 100644
--- a/fs/btrfs/volumes.c
+++ b/fs/btrfs/volumes.c
@@ -6371,14 +6371,12 @@ static void
Signed-off-by: Chaitanya Kulkarni
---
fs/iomap/direct-io.c | 15 +--
1 file changed, 5 insertions(+), 10 deletions(-)
diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c
index 933f234d5bec..3756dbf51909 100644
--- a/fs/iomap/direct-io.c
+++ b/fs/iomap/direct-io.c
@@ -190,10
Signed-off-by: Chaitanya Kulkarni
---
drivers/block/drbd/drbd_actlog.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/block/drbd/drbd_actlog.c b/drivers/block/drbd/drbd_actlog.c
index 7227fc7ab8ed..733679cf456b 100644
--- a/drivers/block/drbd/drbd_actlog.c
+++ b
Signed-off-by: Chaitanya Kulkarni
---
fs/iomap/buffered-io.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c
index 16a1e82e3aeb..d256799569cf 100644
--- a/fs/iomap/buffered-io.c
+++ b/fs/iomap/buffered-io.c
@@ -1222,10
Signed-off-by: Chaitanya Kulkarni
---
fs/gfs2/ops_fstype.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/fs/gfs2/ops_fstype.c b/fs/gfs2/ops_fstype.c
index 61fce59cb4d3..32506d5615f4 100644
--- a/fs/gfs2/ops_fstype.c
+++ b/fs/gfs2/ops_fstype.c
@@ -255,12 +255,9
Signed-off-by: Chaitanya Kulkarni
---
fs/zonefs/super.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/fs/zonefs/super.c b/fs/zonefs/super.c
index bec47f2d074b..3117a89550f6 100644
--- a/fs/zonefs/super.c
+++ b/fs/zonefs/super.c
@@ -682,10 +682,9 @@ static ssize_t
Signed-off-by: Chaitanya Kulkarni
---
drivers/block/drbd/drbd_receiver.c | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/block/drbd/drbd_receiver.c
b/drivers/block/drbd/drbd_receiver.c
index 09c86ef3f0fd..2715081a4603 100644
--- a/drivers/block/drbd
Signed-off-by: Chaitanya Kulkarni
---
drivers/block/pktcdvd.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/block/pktcdvd.c b/drivers/block/pktcdvd.c
index b8bb8ec7538d..47eb4e0bd4c3 100644
--- a/drivers/block/pktcdvd.c
+++ b/drivers/block/pktcdvd.c
Signed-off-by: Chaitanya Kulkarni
---
drivers/md/dm-zoned-metadata.c | 15 +--
1 file changed, 5 insertions(+), 10 deletions(-)
diff --git a/drivers/md/dm-zoned-metadata.c b/drivers/md/dm-zoned-metadata.c
index b298fefb022e..f114d595ce23 100644
--- a/drivers/md/dm-zoned-metadata.c
Signed-off-by: Chaitanya Kulkarni
---
drivers/md/md.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/md/md.c b/drivers/md/md.c
index ca409428b4fc..b331c81f3a12 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -1001,11 +1001,9 @@ void md_super_write(struct
Signed-off-by: Chaitanya Kulkarni
---
drivers/md/dm-zoned-target.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/md/dm-zoned-target.c b/drivers/md/dm-zoned-target.c
index 697f9de37355..8b232b9e3386 100644
--- a/drivers/md/dm-zoned-target.c
+++ b/drivers/md
Signed-off-by: Chaitanya Kulkarni
---
drivers/md/bcache/journal.c | 21 -
1 file changed, 8 insertions(+), 13 deletions(-)
diff --git a/drivers/md/bcache/journal.c b/drivers/md/bcache/journal.c
index aefbdb7e003b..0aabcb5cf2ad 100644
--- a/drivers/md/bcache/journal.c
+++ b
Signed-off-by: Chaitanya Kulkarni
---
drivers/md/dm-crypt.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/md/dm-crypt.c b/drivers/md/dm-crypt.c
index 53791138d78b..b03dbcbff491 100644
--- a/drivers/md/dm-crypt.c
+++ b/drivers/md/dm-crypt.c
@@ -1764,9 +1764,7
Signed-off-by: Chaitanya Kulkarni
---
fs/btrfs/scrub.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/fs/btrfs/scrub.c b/fs/btrfs/scrub.c
index 5f4f88a4d2c8..1e533966ccf1 100644
--- a/fs/btrfs/scrub.c
+++ b/fs/btrfs/scrub.c
@@ -1650,10 +1650,8 @@ static int
Signed-off-by: Chaitanya Kulkarni
---
drivers/target/target_core_iblock.c | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/target/target_core_iblock.c
b/drivers/target/target_core_iblock.c
index 8ed93fd205c7..ec65a9494bee 100644
--- a/drivers/target
Signed-off-by: Chaitanya Kulkarni
---
fs/erofs/zdata.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/fs/erofs/zdata.c b/fs/erofs/zdata.c
index 6cb356c4217b..f7cdae88982a 100644
--- a/fs/erofs/zdata.c
+++ b/fs/erofs/zdata.c
@@ -1236,12 +1236,9 @@ static void
Signed-off-by: Chaitanya Kulkarni
---
drivers/md/bcache/writeback.c | 14 ++
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/drivers/md/bcache/writeback.c b/drivers/md/bcache/writeback.c
index a129e4d2707c..e2b769bbdb14 100644
--- a/drivers/md/bcache/writeback.c
+++ b
Signed-off-by: Chaitanya Kulkarni
---
fs/buffer.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/fs/buffer.c b/fs/buffer.c
index 32647d2011df..32e9f780e134 100644
--- a/fs/buffer.c
+++ b/fs/buffer.c
@@ -3027,16 +3027,13 @@ static int submit_bh_wbc(int op, int op_flags
Signed-off-by: Chaitanya Kulkarni
---
fs/xfs/xfs_buf.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/fs/xfs/xfs_buf.c b/fs/xfs/xfs_buf.c
index f8400bbd6473..1c157cfc5f8f 100644
--- a/fs/xfs/xfs_buf.c
+++ b/fs/xfs/xfs_buf.c
@@ -1508,10 +1508,8 @@ xfs_buf_ioapply_map
Signed-off-by: Chaitanya Kulkarni
---
fs/erofs/data.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/fs/erofs/data.c b/fs/erofs/data.c
index ea4f693bee22..15f3a3f01fa3 100644
--- a/fs/erofs/data.c
+++ b/fs/erofs/data.c
@@ -220,10 +220,8 @@ static inline struct bio
Signed-off-by: Chaitanya Kulkarni
---
fs/nfs/blocklayout/blocklayout.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/fs/nfs/blocklayout/blocklayout.c b/fs/nfs/blocklayout/blocklayout.c
index 3be6836074ae..7ac96519c8b7 100644
--- a/fs/nfs/blocklayout/blocklayout.c
Signed-off-by: Chaitanya Kulkarni
---
fs/xfs/xfs_log.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/fs/xfs/xfs_log.c b/fs/xfs/xfs_log.c
index fa2d05e65ff1..062ee664a910 100644
--- a/fs/xfs/xfs_log.c
+++ b/fs/xfs/xfs_log.c
@@ -1702,10 +1702,8 @@ xlog_write_iclog
Signed-off-by: Chaitanya Kulkarni
---
drivers/md/dm-log-writes.c | 21 ++---
1 file changed, 6 insertions(+), 15 deletions(-)
diff --git a/drivers/md/dm-log-writes.c b/drivers/md/dm-log-writes.c
index e3d35c6c9f71..35c2e0418561 100644
--- a/drivers/md/dm-log-writes.c
+++ b
Signed-off-by: Chaitanya Kulkarni
---
fs/jfs/jfs_metapage.c | 16 +++-
1 file changed, 7 insertions(+), 9 deletions(-)
diff --git a/fs/jfs/jfs_metapage.c b/fs/jfs/jfs_metapage.c
index 176580f54af9..5cea9c137a48 100644
--- a/fs/jfs/jfs_metapage.c
+++ b/fs/jfs/jfs_metapage.c
Signed-off-by: Chaitanya Kulkarni
---
fs/ocfs2/cluster/heartbeat.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/fs/ocfs2/cluster/heartbeat.c b/fs/ocfs2/cluster/heartbeat.c
index 0179a73a3fa2..dd37aaac4f32 100644
--- a/fs/ocfs2/cluster/heartbeat.c
+++ b/fs/ocfs2/cluster
Signed-off-by: Chaitanya Kulkarni
---
drivers/nvme/target/io-cmd-bdev.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/nvme/target/io-cmd-bdev.c
b/drivers/nvme/target/io-cmd-bdev.c
index 125dde3f410e..302ec6bc2a55 100644
--- a/drivers/nvme/target/io-cmd-bdev.c
Signed-off-by: Chaitanya Kulkarni
---
fs/btrfs/disk-io.c | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
index 765deefda92b..9a65432fc5e9 100644
--- a/fs/btrfs/disk-io.c
+++ b/fs/btrfs/disk-io.c
@@ -3637,10 +3637,8 @@ static
Signed-off-by: Chaitanya Kulkarni
---
fs/gfs2/lops.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/fs/gfs2/lops.c b/fs/gfs2/lops.c
index 3922b26264f5..9f8a9757b086 100644
--- a/fs/gfs2/lops.c
+++ b/fs/gfs2/lops.c
@@ -264,10 +264,8 @@ static struct bio
Signed-off-by: Chaitanya Kulkarni
---
drivers/block/drbd/drbd_bitmap.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/block/drbd/drbd_bitmap.c b/drivers/block/drbd/drbd_bitmap.c
index df53dca5d02c..4fd9746af469 100644
--- a/drivers/block/drbd/drbd_bitmap.c
+++ b
Signed-off-by: Chaitanya Kulkarni
---
drivers/block/floppy.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c
index dfe1dfc901cc..1237b64bb37b 100644
--- a/drivers/block/floppy.c
+++ b/drivers/block/floppy.c
@@ -4219,13
Signed-off-by: Chaitanya Kulkarni
---
drivers/md/bcache/super.c | 19 +--
1 file changed, 5 insertions(+), 14 deletions(-)
diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
index a4752ac410dc..b4ced138a0c0 100644
--- a/drivers/md/bcache/super.c
+++ b/drivers/md
Signed-off-by: Chaitanya Kulkarni
---
fs/ext4/page-io.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/fs/ext4/page-io.c b/fs/ext4/page-io.c
index 03a44a0de86a..53a79a7aac15 100644
--- a/fs/ext4/page-io.c
+++ b/fs/ext4/page-io.c
@@ -400,10 +400,8 @@ static void
Signed-off-by: Chaitanya Kulkarni
---
fs/block_dev.c | 17 +
1 file changed, 5 insertions(+), 12 deletions(-)
diff --git a/fs/block_dev.c b/fs/block_dev.c
index 3e5b02f6606c..44b992976ee5 100644
--- a/fs/block_dev.c
+++ b/fs/block_dev.c
@@ -239,12 +239,9
On 1/18/21 21:06, Chaitanya Kulkarni wrote:
> Hi,
>
> This is a *compile only RFC* which adds a generic helper to initialize
> the various fields of the bio that is repeated all the places in
> file-systems, block layer, and drivers.
>
> The new helper allows callers to initi
On 1/19/21 20:06, Gao Xiang wrote:
> Hi Chaitanya,
>
> (drop in-person Cc..)
>
> On Mon, Jan 18, 2021 at 09:06:25PM -0800, Chaitanya Kulkarni wrote:
>
> ...it would be nice if you could update the subject line to
> "erofs: use bio_init_fields "
Sure, if new
On 1/9/21 07:59, Pavel Begunkov wrote:
> iov_iter_bvec() initialises iterators well, no need to pre-zero it
> beforehand as done in fd_execute_rw_aio(). Compilers can't optimise it
> out and generate extra code for that (confirmed with assembly).
It will be great if we can quantify this optimizatio
On 1/9/21 12:40, Pavel Begunkov wrote:
> I expect you won't find any, but such little things can pile up
> into a not-easy-to-spot overhead over time.
That is what I suspected with the resulting assembly. The commit log
needs to document that there is no direct impact on the performance
which can
On 1/14/21 11:10 PM, Valdis Klētnieks wrote:
> Correct the spelling of Nagle's name in a comment.
>
> Signed-off-by: Valdis Kletnieks
Looks good.
Reviewed-by: Chaitanya Kulkarni
On 3/4/21 01:58, Jiapeng Chong wrote:
> Fix the following coccicheck warnings:
>
> ./drivers/nvme/host/core.c:3714:60-61: WARNING opportunity for
> kobj_to_dev().
>
> ./drivers/nvme/host/core.c:3475:60-61: WARNING opportunity for
> kobj_to_dev().
>
> Reported-by: Abaci Robot
> Signed-off-by: Jiape
On 3/2/21 22:21, Pintu Kumar wrote:
> The sysctl_compact_memory is mostly unsed in mm/compaction.c
> It just acts as a place holder for sysctl.
>
> Thus we can remove it from here and move the declaration directly
> in kernel/sysctl.c itself.
> This will also eliminate the extern declaration from h
1 - 100 of 220 matches
Mail list logo
