Re: [PATCH 2.6.24-rc8-mm1 09/15] (RFC) IPC: new kernel API to change an ID

2008-01-31 Thread Cedric Le Goater
Hello Kirill ! Kirill Korotaev wrote: Pierre, my point is that after you've added interface "set IPCID", you'll need more and more for checkpointing: - "create/setup conntrack" (otherwise connections get dropped), - "set task start time" (needed for Oracle checkpointing BTW), - "set some stati

[PATCH 1/2] change clone_flags type to u64

2008-02-04 Thread Cedric Le Goater
From: Cedric Le Goater <[EMAIL PROTECTED]> This is a preliminary patch changing the clone_flags type to 64bits for all the routines called by do_fork(). It prepares ground for the next patch which introduces an enhanced version of clone(). This is work in progress. All conversions might

[PATCH 2/2] extend clone_flags using parent_tidptr argument

2008-02-04 Thread Cedric Le Goater
From: Cedric Le Goater <[EMAIL PROTECTED]> We have at least 2 patchsets requiring each a new clone flag and there it is, we've reached the limit, none are left. This patch uses the CLONE_DETACHED flag (unused) as a marker to extend the clone flags through the parent_tidp

Re: [PATCH 2/2] extend clone_flags using parent_tidptr argument

2008-02-05 Thread Cedric Le Goater
Andrew Morton wrote: On Mon, 4 Feb 2008 14:24:16 -0600 "Serge E. Hallyn" <[EMAIL PROTECTED]> wrote: Quoting Cedric Le Goater ([EMAIL PROTECTED]): From: Cedric Le Goater <[EMAIL PROTECTED]> We have at least 2 patchsets requiring each a new clone flag and there it is, w

Re: 2.6.24-rc4-mm1

2007-12-12 Thread Cedric Le Goater
Ilpo Järvinen wrote: > On Wed, 5 Dec 2007, David Miller wrote: > >> From: Reuben Farrelly <[EMAIL PROTECTED]> >> Date: Thu, 06 Dec 2007 17:59:37 +1100 >> >>> On 5/12/2007 4:17 PM, Andrew Morton wrote: - Lots of device IDs have been removed from the e1000 driver and moved over to e1000e

Re: 2.6.24-rc4-mm1

2007-12-12 Thread Cedric Le Goater
Ilpo Järvinen wrote: > On Wed, 5 Dec 2007, Andrew Morton wrote: > >> On Thu, 06 Dec 2007 17:59:37 +1100 Reuben Farrelly <[EMAIL PROTECTED]> wrote: >> >>> This non fatal oops which I have just noticed may be related to this change >>> then >>> - certainly looks networking related. >> yep, but it

tcp_sacktag_one() WARNING (was Re: 2.6.24-rc4-mm1)

2007-12-13 Thread Cedric Le Goater
Cedric Le Goater wrote: > Ilpo Järvinen wrote: >> On Wed, 5 Dec 2007, Andrew Morton wrote: >> >>> On Thu, 06 Dec 2007 17:59:37 +1100 Reuben Farrelly <[EMAIL PROTECTED]> >>> wrote: >>> >>>> This non fatal oops which I have just notice

Re: 2.6.24-rc4-mm1 - BUG in tcp_fragment

2007-12-13 Thread Cedric Le Goater
Andrew Morton wrote: > Temporarily at > > http://userweb.kernel.org/~akpm/2.6.24-rc4-mm1/ > > Will appear later at > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.24-rc4/2.6.24-rc4-mm1/ I got this one while compiling on NFS. C. kernel BUG at /home/legoater/linux/2

Re: 2.6.24-rc4-mm1 - BUG in tcp_fragment

2007-12-13 Thread Cedric Le Goater
Ilpo Järvinen wrote: > On Thu, 13 Dec 2007, Cedric Le Goater wrote: > >> I got this one while compiling on NFS. >> >> C. >> >> kernel BUG at /home/legoater/linux/2.6.24-rc4-mm1/include/net/tcp.h:1480! > > I'm not exactly sure what patches you have

Re: [PATCH 1/2] Extend sys_clone and sys_unshare system calls API

2008-01-24 Thread Cedric Le Goater
Pavel Machek wrote: > On Wed 2008-01-16 15:58:55, Pavel Emelyanov wrote: >> There's only one bit in the clone_flags left, so we won't be able >> to create more namespaces after we make it busy. Besides, for >> checkpoint/restart jobs we might want to create tasks with given >> pids (virtual of co

Re: [PATCH] Consolidate IPC namespace cleanup functions

2007-10-02 Thread Cedric Le Goater
t be applied after the ones with the NAMESPACES config > option introduced. > > Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> Acked-by: Cedric Le Goater <[EMAIL PROTECTED]> Thanks Pavel ! C. > > --- > > ipc/msg.c | 2

Re: [patch -mm 0/4] mqueue namespace

2007-11-29 Thread Cedric Le Goater
Pavel Emelyanov wrote: > Cedric Le Goater wrote: >> Hello ! >> >> Here's a small patchset introducing a new namespace for POSIX >> message queues. >> >> Nothing really complex a part from the mqueue filesystem which >> needed some spec

Re: [patch -mm 2/4] mqueue namespace : add unshare support

2007-11-29 Thread Cedric Le Goater
cannot be unshared when the mount one is not ;) arg. yes :) Thanks ! C. Signed-off-by: Cedric Le Goater <[EMAIL PROTECTED]> --- kernel/fork.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: 2.6.24-rc3-mm2/kernel/fork.c

Re: [patch -mm 2/4] mqueue namespace : add unshare support

2007-11-29 Thread Cedric Le Goater
>> Index: 2.6.24-rc3-mm2/include/linux/sched.h >> === >> --- 2.6.24-rc3-mm2.orig/include/linux/sched.h >> +++ 2.6.24-rc3-mm2/include/linux/sched.h >> @@ -27,6 +27,7 @@ >> #define CLONE_NEWUSER 0x1000 /* New user

Re: [PATCH] Isolate the UTS namespace's domainname and hostname back

2007-11-21 Thread Cedric Le Goater
Pavel Emelyanov wrote: > The commit > > commit 7d69a1f4a72b18876c99c697692b78339d491568 > Author: Cedric Le Goater <[EMAIL PROTECTED]> > Date: Sun Jul 15 23:40:58 2007 -0700 > > remove CONFIG_UTS_NS and CONFIG_IPC_NS > > accidentally removed the code,

Re: [PATCH 2.6.24-rc3-mm1] IPC: make struct ipc_ids static in ipc_namespace

2007-11-22 Thread Cedric Le Goater
. > Thus, we can allocate all in once and get rid of all the code needed to > allocate and free these ipc_ids separately. It looks safe and saves quite a lot of line. Pavel, what do you think of it ? Acked-by: Cedric Le Goater <[EMAIL PROTECTED]> Thanks, C. > Signed-off-by:

Re: [PATCH 1/2] Extend sys_clone and sys_unshare system calls API

2008-01-17 Thread Cedric Le Goater
Al Viro wrote: > On Wed, Jan 16, 2008 at 07:23:40AM -0700, Jonathan Corbet wrote: >> Hi, Pavel, >> >> [Adding Ulrich] >> >>> I use the last bit in the clone_flags for CLONE_LONGARG. When set it >>> will denote that the child_tidptr is not a pointer to a tid storage, >>> but the pointer to the struc

Re: [Devel] [PATCH] pidns: Place under CONFIG_EXPERIMENTAL (take 2)

2007-10-29 Thread Cedric Le Goater
Eric W. Biederman wrote: > Adrian Bunk <[EMAIL PROTECTED]> writes: > >> On Sun, Oct 28, 2007 at 09:12:34AM -0700, Jeremy Fitzhardinge wrote: >>> Eric W. Biederman wrote: Roughly that sounds like CONFIG_EXPERIMENTAL to me. But I would be happy to hear if someone has a better idea. >>> Ra

Re: [Devel] [PATCH] pidns: Place under CONFIG_EXPERIMENTAL (take 2)

2007-10-29 Thread Cedric Le Goater
Eric W. Biederman wrote: > Andrew Morton <[EMAIL PROTECTED]> writes: > >>> On Sat, 27 Oct 2007 04:04:08 +0200 Adrian Bunk <[EMAIL PROTECTED]> wrote: be happy to hear if someone has a better idea. >>> There is a difference between "complete the feature" and "early adopters >>> to start playin

Re: [PATCH 0/5] A config option to compile out some namespaces code (v3)

2007-10-31 Thread Cedric Le Goater
Pavel Emelyanov wrote: > There were some questions like "do I need this on my cellphone" > in reply to different namespaces patches. Indeed, the namespaces > are not useful for most of the embedded systems, but the code > creating and releasing them weights a lot. > > So I propose to add a config

Re: [PATCH 2/5] Move the UTS namespace under the option

2007-10-31 Thread Cedric Le Goater
> diff --git a/init/Kconfig b/init/Kconfig > index fc76773..d592aa2 100644 > --- a/init/Kconfig > +++ b/init/Kconfig > @@ -409,6 +409,13 @@ config NAMESPACES > or same user id or pid may refer to different tasks when used in > different namespaces. > > +config UTS_NS > + bool

Re: 2.6.23-rc1-mm1

2007-07-25 Thread Cedric Le Goater
Hello, Andrew Morton wrote: > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc1/2.6.23-rc1-mm1/ I'm having issue compiling on i386 and x86_64. make defconfig on i386 : LD init/built-in.o LD .tmp_vmlinux1 drivers/built-in.o(.text+0x9649): In function `acpi_

Re: 2.6.23-rc1-mm1

2007-07-25 Thread Cedric Le Goater
Hello, Andrew Morton wrote: > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc1/2.6.23-rc1-mm1/ found that one on ppc, drivers/char/hw_random/pasemi-rng.c:140: error: unknown field 'type' specified in initializer drivers/char/hw_random/pasemi-rng.c:140: warning: initializ

Re: 2.6.23-rc1-mm1

2007-07-25 Thread Cedric Le Goater
ND_MEM' undeclared (first use in this function) drivers/video/chipsfb.c:461: error: (Each undeclared identifier is reported only once drivers/video/chipsfb.c:461: error: for each function it appears in.) Cheers, C. Signed-off-by: Cedric Le Goater <[EMAIL PROTECTED]> --- drivers/vid

[PATCH -mm] fix order of container subsystems in init/Kconfig

2007-07-25 Thread Cedric Le Goater
some cosmetic changes to init/Kconfig to make the subsystem list under containers look nicer when CONFIG_CONTAINERS=y. also changed the 'select' to 'depends on' for the namespace subsystem. Signed-off-by: Cedric Le Goater <[EMAIL PROTECTED]>

Re: 2.6.23-rc1-mm1

2007-07-26 Thread Cedric Le Goater
Mel Gorman wrote: > On (25/07/07 19:26), Len Brown didst pronounce: >> On Wednesday 25 July 2007 14:58, Andrew Morton wrote: >>> On Wed, 25 Jul 2007 13:23:04 -0400 >>> Len Brown <[EMAIL PROTECTED]> wrote: >>> Andrew, you want to re-pull the acpi tree, or do you want me to send you some pa

[PATCH -mm] ipc namespace: remove config ipc ns fix

2007-09-03 Thread Cedric Le Goater
Finish the work : kill all #ifdef CONFIG_IPC_NS. Thanks Robert ! C. Signed-off-by: Cedric Le Goater <[EMAIL PROTECTED]> Cc: Andrew Morton <[EMAIL PROTECTED]> Cc: Eric Biederman <[EMAIL PROTECTED]> Cc: Robert P. J. Day <[EMAIL PROTECTED]> --- ipc/ipc_sysctl.c |4

Re: 2.6.23-mm1 s390 driver problem

2007-10-19 Thread Cedric Le Goater
Martin Schwidefsky wrote: > On Fri, 2007-10-19 at 11:16 +0200, Cedric Le Goater wrote: >>> This is the vmlinux.lds.S problem. The cleanup patch from Sam Ravnborg >>> moved the __initramfs_start and __initramfs_end symbols into >>> the .init.ramfs section. This is i

Re: 2.6.23-mm1 s390 driver problem

2007-10-19 Thread Cedric Le Goater
Martin Schwidefsky wrote: > On Thu, 2007-10-18 at 15:31 -0500, Serge E. Hallyn wrote: >> Quoting Christian Borntraeger ([EMAIL PROTECTED]): >>> Am Donnerstag, 18. Oktober 2007 schrieb Serge E. Hallyn: Sigh, well this turned out less informative than I'd liked. After bisecting 2.6.23 to 2.

Re: 2.6.23-mm1 s390 driver problem

2007-10-19 Thread Cedric Le Goater
>> that helped going a little further in the boot process but we then have >> a network issue when bringing the network interface up : > > please cc netdev on network issues. yes. >> Bringing up interface eth0: Ý cut here ¨ >> Kernel BUG at 0002 Ýverbose d

Re: 2.6.23-mm1

2007-10-11 Thread Cedric Le Goater
to make target > `/home/kamezawa/ref-2.6.23-mm1/arch//Makefile'. Stop. > == > > $(ARCH) cannot be detected automatically... > > What information is useful for fixing this ? cross compile work but native compile doesn't anymore :( Here's a tmp fix. Thanks, C.

Re: 2.6.23-mm1 - list_add corruption in cgroup

2007-10-17 Thread Cedric Le Goater
Hello ! While polling the contents of a cgroup task file, I caught the following corruption. Is there a known race (and a fix) or should I start digging ? the program running in the cgroup is fork/exec intensive: while (1) { int i, s; for (i = 0; i < count; i++)

Re: [PATCH -mm 7/8] user_ns: handle file sigio

2007-01-15 Thread Cedric Le Goater
reproduce it. I did reproduce it on a FC5 desktop finally. get_user_ns() returns NULL when CONFIG_USER_NS=n and this breaks sigio_perm() which does not expect NULL values for ->user_ns. I would fix this with the following patch. C. Signed-off-by: Cedri

Re: [PATCH -mm 7/8] user_ns: handle file sigio

2007-01-15 Thread Cedric Le Goater
[ ... ] > Rewriting the userns testcases right now. Clearly, in addition to > separately testing clone and unshare, I need to add a sigioperm check, > and have a separate set of testcases for CONFIG_USER_NS=n. Could we get rid of CONFIG_USER_NS ? It doesn't look that useful anyway, it just de

[PATCH -mm] user_ns: remove CONFIG_USER_NS

2007-01-16 Thread Cedric Le Goater
It doesn't look that useful anyway, it just deactivates the unshare capability for the user namespace. Signed-off-by: Cedric Le Goater <[EMAIL PROTECTED]> --- include/linux/sched.h |9 - include/linux/user_namespace.h | 33 - i

[PATCH -mm] uts namespace : remove CONFIG_UTS_NS

2007-01-16 Thread Cedric Le Goater
CONFIG_UTS_NS has very little value as it only deactivates the unshare of the uts namespace and does not improve performance. Signed-off-by: Cedric Le Goater <[EMAIL PROTECTED]> --- include/linux/utsname.h | 19 --- init/Kconfig|8 kernel/Ma

[PATCH -mm] ipc namespace : remove CONFIG_IPC_NS

2007-01-16 Thread Cedric Le Goater
CONFIG_IPC_NS has very little value as it only deactivates the unshare of the ipc namespace and does not improve performance. Signed-off-by: Cedric Le Goater <[EMAIL PROTECTED]> --- include/linux/ipc.h | 11 --- init/Kconfig|9 - ipc/msg.c

Re: NFS causing oops when freeing namespace

2007-01-17 Thread Cedric Le Goater
Oleg Nesterov wrote: > On 01/17, Daniel Hokka Zakrisson wrote: Call Trace: [] _spin_lock_irqsave+0x20/0x90 [] lockd_down+0x125/0x190 [] nfs_free_server+0x6d/0xd0 [] nfs_kill_super+0xc/0x20 [] deactivate_super+0x7d/0xa0 [] release_mounts+0x6e/0x80 [] __

Re: NFS causing oops when freeing namespace

2007-01-17 Thread Cedric Le Goater
Oleg Nesterov wrote: > On 01/17, Cedric Le Goater wrote: >> Oleg Nesterov wrote: >>> On 01/17, Daniel Hokka Zakrisson wrote: >>>> It was the only semi-plausible explanation I could come up with. I added a >>>> printk in do_exit right before exit_task_na

Re: [PATCH] Add new categories of DEPRECATED and OBSOLETE.

2007-01-18 Thread Cedric Le Goater
Robert P. J. Day wrote: > Next to EXPERIMENTAL, add two new kernel config categories of > DEPRECATED and OBSOLETE. What about adding some printks when DEPRECATED and OBSOLETE are set ? like in print_tainted() for example. C. - To unsubscribe from this list: send the line "unsubscribe linux-ke

[PATCH] mxser: remove useless fields

2007-01-23 Thread Cedric Le Goater
the session and pgrp fields in mxser_struct are unused. Signed-off-by: Cedric Le Goater <[EMAIL PROTECTED]> --- drivers/char/mxser.c |7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) Index: 2.6.20-rc4-mm1/drivers/char/m

Re: [PATCH/RFC] kthread API conversion for dvb_frontend and av7110

2007-01-24 Thread Cedric Le Goater
Cedric Le Goater wrote: > Andrew de Quincey wrote: > >> Hi - the conversion looks good to me.. I can't really offer any more >> constructive suggestions beyond what Cedric has already said. > > ok. so, should we just resend a refreshed version of the

Re: [PATCH] namespaces: fix race at task exit

2007-01-25 Thread Cedric Le Goater
Serge E. Hallyn wrote: > In do_exit(), the exit_task_namespaces() was placed after > exit_notify() because exit_notify ends up using the pid > namespace both to access the reaper, and for detaching the > pid. However, this placement allows an nfs server to reap > the task before exit_task_namespac

Re: mm snapshot broken-out-2007-02-06-16-59.tar.gz uploaded

2007-02-07 Thread Cedric Le Goater
[EMAIL PROTECTED] wrote: > The mm snapshot broken-out-2007-02-06-16-59.tar.gz has been uploaded to > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/mm/broken-out-2007-02-06-16-59.tar.gz I'm having download issues : wrong modes :( ftp.kernel.org:/pub/linux/kernel/people/akpm/mm> ls ...

Re: mm snapshot broken-out-2007-02-06-16-59.tar.gz uploaded

2007-02-07 Thread Cedric Le Goater
Michal Piotrowski wrote: > On 07/02/07, Andrew Morton <[EMAIL PROTECTED]> wrote: >> I copied it to >> http://userweb.kernel.org/~akpm/broken-out-2007-02-06-16-59.tar.gz but >> there's really not much point in using it - it's ancient. > > Cedric, here is an updated version > http://www.stardust.web

Re: [PATCH 3/7] containers (V7): Add generic multi-subsystem API to containers

2007-02-12 Thread Cedric Le Goater
>> +#include > > I did have a problem with this include. On s390 it didn't exist so I've > just been running without it (with no problems). A quick 'find' > suggests it only exists on x86_64, so I'd expect failures on all other > arches. confirmed on x86 also. C. - To unsubscribe from this li

Re: 2.6.20-rc6-mm3

2007-02-01 Thread Cedric Le Goater
Hello ! changes in git-acpi.patch in 2.6.20-rc6-mm3 (and maybe before) broke the Summit sub-arch (IBM x440) compile :( thanks, C. CC arch/i386/kernel/cpu/intel.o CC arch/i386/kernel/early_printk.o arch/i386/kernel/srat.c: In function 'parse_cpu_affinity_structure': arch/i386/

Re: 2.6.20-rc6-mm3

2007-02-01 Thread Cedric Le Goater
Starikovskiy, Alexey Y wrote: > Sorry, here is the patch... ACPI has switched to acpi_find_rsdp(), so > srat.c might want to do that too, please check. got it. running a compile and boot test. I should have the results in 'my' morning (UTC+1). Thanks ! C. - To unsubscribe from this list: send

Re: 2.6.20-rc6-mm3

2007-02-01 Thread Cedric Le Goater
Cedric Le Goater wrote: > Starikovskiy, Alexey Y wrote: >> Sorry, here is the patch... ACPI has switched to acpi_find_rsdp(), so >> srat.c might want to do that too, please check. > > got it. running a compile and boot test. hmm, i got another issue while compiling :

Re: 2.6.20-rc6-mm3

2007-02-02 Thread Cedric Le Goater
Hello ! Starikovskiy, Alexey Y wrote: > Hi, > I updated patch to use acpi_find_rsdp(), as all other code does. so it probably means that drivers/acpi/tables/tbxfroot.c is obsolete ? > Could you please try it? sure, I'll cancel the current boot test in which I was using acpi_find_root_pointer(

Re: 2.6.20-rc6-mm3

2007-02-02 Thread Cedric Le Goater
Starikovskiy, Alexey Y wrote: >> so it probably means that drivers/acpi/tables/tbxfroot.c is >> obsolete ? > Yes. >>> Could you please try it? >> sure, I'll cancel the current boot test in which I was using >> acpi_find_root_pointer() in tbxfroot.c and restart one with your >> new patch. I should h

Re: 2.6.20-rc6-mm3

2007-02-02 Thread Cedric Le Goater
Cedric Le Goater wrote: > Starikovskiy, Alexey Y wrote: >>> so it probably means that drivers/acpi/tables/tbxfroot.c is >>> obsolete ? >> Yes. >>>> Could you please try it? >>> sure, I'll cancel the current boot test in which I was using >&

Re: [Devel] Re: [PATCH/RFC] kthread API conversion for dvb_frontend and av7110

2006-12-13 Thread Cedric Le Goater
Herbert Poetzl wrote: > On Tue, Dec 12, 2006 at 03:58:16PM -0700, Eric W. Biederman wrote: >> Andrew de Quincey <[EMAIL PROTECTED]> writes: >> >>> [snip] >>> correct, will fix that up in the next round thanks for the feedback, Herbert >>> Hi - the conversion looks good to me.. I

Re: Linux 2.6.19 VServer 2.1.x

2006-12-01 Thread Cedric Le Goater
Great ! I'm dreaming that the next patchsets will not require as much debate. nah, stop dreaming Cedric :) Thanks to Andrew and Linus who made it happen. C. Kirill Korotaev wrote: > OpenVZ has been using them for more than a month already ;-) > > Kirill > >> Ladies and Gentlemen! >> >> here

[PATCH] fix refcounting of nsproxy object when unshared

2007-06-18 Thread Cedric Le Goater
When a namespace is unshared, a refcount on the previous nsproxy is abusively taken, leading to a memory leak of nsproxy objects. Signed-off-by: Cedric Le Goater <[EMAIL PROTECTED]> --- kernel/nsproxy.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) Index: 2.6.

[PATCH -mm] add a kmem_cache for nsproxy objects

2007-06-18 Thread Cedric Le Goater
: Cedric Le Goater <[EMAIL PROTECTED]> --- kernel/nsproxy.c | 21 + 1 file changed, 17 insertions(+), 4 deletions(-) Index: 2.6.22-rc4-mm2/kernel/nsproxy.c === --- 2.6.22-rc4-mm2.orig/kernel/nsproxy.c +++ 2.6.

Re: [PATCH] create_new_namespaces: fix improper return of NULL

2007-06-19 Thread Cedric Le Goater
Oleg Nesterov wrote: > Untested. > > dup_mnt_ns() and clone_uts_ns() return NULL on failure. This is wrong, > create_new_namespaces() uses ERR_PTR() to catch an error. This means > that the subsequent create_new_namespaces() will hit BUG_ON() in > copy_mnt_ns() or copy_utsname(). I sent one just

Re: [PATCH] create_new_namespaces: fix improper return of NULL

2007-06-19 Thread Cedric Le Goater
Oleg Nesterov wrote: > On 06/19, Cedric Le Goater wrote: >> Oleg Nesterov wrote: >>> Untested. >>> >>> dup_mnt_ns() and clone_uts_ns() return NULL on failure. This is wrong, >>> create_new_namespaces() uses ERR_PTR() to catch an error. This means

Re: [PATCH] namespace: ensure clone_flags are always stored in an unsigned long

2007-06-22 Thread Cedric Le Goater
waiting for next -mm doing the same. Acked-by : Cedric Le Goater <[EMAIL PROTECTED]> C. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH -mm] add a kmem_cache for nsproxy objects

2007-06-22 Thread Cedric Le Goater
Christoph Lameter wrote: > On Tue, 19 Jun 2007, Andrew Morton wrote: > >> On Mon, 18 Jun 2007 22:53:13 +0200 >> Cedric Le Goater <[EMAIL PROTECTED]> wrote: >> >>> +static int __init nsproxy_cache_init(void) >>> +{ >>> + nsproxy_ca

Re: [PATCH -mm 2/2] user namespace : add unshare

2007-06-11 Thread Cedric Le Goater
Andrew Morton wrote: > On Fri, 08 Jun 2007 17:14:12 +0200 > Cedric Le Goater <[EMAIL PROTECTED]> wrote: > >> Changelog: Fix !CONFIG_USER_NS clone with CLONE_NEWUSER so it returns -EINVAL >> rather than 0, so that userspace knows they didn't get a new u

PATCH -mm] fix create_new_namespaces() return value

2007-06-11 Thread Cedric Le Goater
The following patch modifies create_new_namespaces() to also use the errors returned by the copy_*_ns routines and not to systematically return ENOMEM. Signed-off-by: Cedric Le Goater <[EMAIL PROTECTED]> Cc: Serge E. Hallyn <[EMAIL PROTECTED]> Cc: Badari Pulavarty <[EMAIL PROTEC

Re: [PATCH -mm 2/2] user namespace : add unshare

2007-06-11 Thread Cedric Le Goater
Cedric Le Goater wrote: > Andrew Morton wrote: >> On Fri, 08 Jun 2007 17:14:12 +0200 >> Cedric Le Goater <[EMAIL PROTECTED]> wrote: >> >>> Changelog: Fix !CONFIG_USER_NS clone with CLONE_NEWUSER so it returns >>> -EINVAL >>> rather than

Re: PATCH -mm] fix create_new_namespaces() return value

2007-06-12 Thread Cedric Le Goater
Badari Pulavarty wrote: > > > Cedric Le Goater wrote: > >> The following patch modifies create_new_namespaces() to also use the >> errors returned by the copy_*_ns routines and not to systematically >> return ENOMEM. >> > > In my initial version, I d

Re: PATCH -mm] fix create_new_namespaces() return value

2007-06-12 Thread Cedric Le Goater
Badari Pulavarty wrote: > > > Cedric Le Goater wrote: > >> The following patch modifies create_new_namespaces() to also use the >> errors returned by the copy_*_ns routines and not to systematically >> return ENOMEM. >> > > In my initial version, I d

Re: [PATCH 0/16] Pid namespaces

2007-07-09 Thread Cedric Le Goater
Badari Pulavarty wrote: > On Fri, 2007-07-06 at 12:01 +0400, Pavel Emelianov wrote: >> This is "submition for inclusion" of hierarchical, not kconfig >> configurable, zero overheaded ;) pid namespaces. > > Not able to boot my ppc64 machine with the patchset :( I can't boot either on a x86_64 but

Re: [PATCH 0/16] Pid namespaces

2007-07-09 Thread Cedric Le Goater
3. Suka assumes that pid namespace can live without proc mount and tries to make the code work with pid_ns->proc_mnt change from NULL to not-NULL from times to times. My code calls the kern_mount() at the namespace creation and thus the pid_namespace always work

Re: [PATCH 1/16] Round up the API

2007-07-09 Thread Cedric Le Goater
Pavel Emelianov wrote: > The set of functions process_session, task_session, process_group > and task_pgrp is confusing, as the names can be mixed with each other > when looking at the code for a long time. > > The proposals are to > * equip the functions that return the integer with _nr suffix to

Re: [PATCH 2/16] Miscelaneous preparations for namespaces

2007-07-09 Thread Cedric Le Goater
Pavel Emelianov wrote: > The most importaint change is moving exit_task_namespaces() > inside exit_notify() to makes it possible to notify the > exiting task's parent. However this should be done before > release_task() to address the issue pointed by Sukadev with > NFS kernel thread. Have you act

Re: [PATCH 4/16] Change data structures for pid namespaces

2007-07-09 Thread Cedric Le Goater
Pavel Emelianov wrote: > struct pid_namespace will have the kmem_cache to allocate > the pids from, the parent, as they are hierarchical, and > the level of nesting value. > > struct pid will have a variable length array of pid_number-s > one for each namespace this pid lives in. The level value >

Re: [PATCH 4/16] Change data structures for pid namespaces

2007-07-10 Thread Cedric Le Goater
>> | > + >> | > struct pid >> | > { >> | > atomic_t count; >> | > @@ -40,6 +40,8 @@ enum pid_type >> | > /* lists of tasks that use this pid */ >> | > struct hlist_head tasks[PIDTYPE_MAX]; >> | > struct rcu_head rcu; >> | > +int level; >> | > +s

Re: 2.6.22-rc4-mm1

2007-06-06 Thread Cedric Le Goater
Hi Andrew, When CONFIG_DEBUG_VM=y, boot on i386 and s390 (the only one tested) ends with the following. C. [ cut here ] kernel BUG at mm/rmap.c:557! invalid opcode: [#1] CPU:0 EIP:0060:[]Not tainted VLI EFLAGS: 0206 (2.6.22-rc4-mm1 #1) EIP is at

Re: checkpointing and restoring processes

2007-06-06 Thread Cedric Le Goater
Mark Pflueger wrote: > hi everyone! > > i'm not subscribed to the list, so if you care to flame because of my noob > question, just do it to the list, otherwise please cc me. you should subscribe to [EMAIL PROTECTED] and send your ideas on that list. There's a BOF on that topic at OLS if you can

Re: 2.6.22-rc4-mm1

2007-06-06 Thread Cedric Le Goater
nel/e820.c:248: warning: implicit declaration of function `register_nosave_region' Signed-off-by: Cedric Le Goater <[EMAIL PROTECTED]> --- include/linux/suspend.h |8 1 file changed, 8 insertions(+) Index: 2.6.22-rc4-mm1/in

Re: 2.6.22-rc4-mm1

2007-06-06 Thread Cedric Le Goater
> Same problem here > > http://www.stardust.webpages.pl/files/tbf/bitis-gabonica/2.6.22-rc4-mm1/console.log > > http://www.stardust.webpages.pl/files/tbf/bitis-gabonica/2.6.22-rc4-mm1/mm-config2 > > > l *__page_check_anon_rmap+0x49 > 0xc1075ee5 is in __page_check_anon_rmap (mm/rmap.c:557). > 55

Re: 2.6.22-rc4-mm1

2007-06-06 Thread Cedric Le Goater
ll/spufs/file.c:122: warning: unused variable 'addr0' I'm not sure how useful is the addr0 variable. Signed-off-by: Cedric Le Goater <[EMAIL PROTECTED]> Cc: Arnd Bergmann <[EMAIL PROTECTED]> Cc: Nick Piggin <[EMAIL PROTECTED]> Cc: Andrew Morton <[EMAIL PROTECTED]

Re: 2.6.22-rc4-mm1

2007-06-06 Thread Cedric Le Goater
Mel Gorman wrote: > On (06/06/07 09:35), William Lee Irwin III didst pronounce: >> On Wed, Jun 06, 2007 at 05:26:49PM +0100, Mel Gorman wrote: >>> I do not believe this is Nick's problem. I encountered the same issue and >>> the bisect ended up here; >>> # BISECT HERE >>> mm-variable-length-argumen

Re: [PATCH 03/10] Containers(V10): Add tasks file interface

2007-06-07 Thread Cedric Le Goater
log_lvl+0x1a/0x2f [] show_trace+0x12/0x14 [] dump_stack+0x15/0x17 [] __kmalloc+0x56/0xf3 [] container_tasks_open+0x56/0x131 [] container_file_open+0x32/0x3a [] __dentry_open+0x99/0x13c [] nameidata_to_filp+0x27/0x37 [] do_filp_open+0x33/0x3b [] do_sys_open+0x45/0xc9 [] sys_open+0x1c/0x1e

[PATCH -mm] remove CONFIG_UTS_NS and CONFIG_IPC_NS

2007-06-08 Thread Cedric Le Goater
CONFIG_UTS_NS and CONFIG_IPC_NS have very little value as they only deactivate the unshare of the uts and ipc namespaces and do not improve performance. Signed-off-by: Cedric Le Goater <[EMAIL PROTECTED]> Acked-by: "Serge E. Hallyn" <[EMAIL PROTECTED]> Cc: Eric W. Biederman

Re: [PATCH -mm 1/2] user namespace : add unshare

2007-06-08 Thread Cedric Le Goater
oops, wrong subject. it should be : "user namespace : add the framework" Sorry about that, C. Cedric Le Goater wrote: > Basically, it will allow a process to unshare its user_struct table, resetting > at the same time its own user_struct and all the associated accoun

[PATCH -mm 2/2] user namespace : add unshare

2007-06-08 Thread Cedric Le Goater
From: Serge E. Hallyn <[EMAIL PROTECTED]> Changelog: Fix !CONFIG_USER_NS clone with CLONE_NEWUSER so it returns -EINVAL rather than 0, so that userspace knows they didn't get a new user namespace. Signed-off-by: Serge E. Hallyn <[EMAIL PROTECTED]> Signed-off-by:

[PATCH -mm 1/2] user namespace : add unshare

2007-06-08 Thread Cedric Le Goater
user_namespace to files user_namespace.{c,h} Changes since [try #2]: - removed struct user_namespace* argument from find_user() Changes since [try #1]: - removed struct user_namespace* argument from find_user() - added a root_user per user namespace Signed-off-by: Cedric Le

Re: [PATCH] kthread_should_stop_check_freeze

2007-03-12 Thread Cedric Le Goater
Oleg Nesterov wrote: > On 03/12, Rafael J. Wysocki wrote: >> On Monday, 12 March 2007 09:14, Pavel Machek wrote: >>> Can we get better name for this function? >> Well, I took the name from the Oleg's message. Can you please suggest >> something? > > Well, kthread_should_stop_check_freeze() is rea

Re: [RFC][PATCH 4/7] RSS accounting hooks over the code

2007-03-14 Thread Cedric Le Goater
; /* No need to invalidate - it was non-present before */ > update_mmu_cache(vma, addr, pte); > lazy_mmu_prot_update(pte); > + pte_unmap_unlock(ptep, ptl); > + return; > > out: > pte_unmap_unlock(ptep, ptl); > + container_rss_release(pcont); &g

Re: [PATCH 2/2] Replace pid_t in autofs with struct pid reference

2007-03-16 Thread Cedric Le Goater
ange to autofs_wait_queue (pid and tgid in the wait queue are just used to write to a userspace daemon's pipe). - Fix Cedric's comments: retain old prototype of parse_options() and move necessary change to its caller. Signed-off-by: Sukadev Bhattipro

Re: [PATCH] dvb_en_50221: Convert to kthread API

2007-04-20 Thread Cedric Le Goater
Andrew Morton wrote: > On Fri, 20 Apr 2007 07:37:14 +0100 Christoph Hellwig <[EMAIL PROTECTED]> > wrote: > >>> urgh, yes, this is just sad. We should convert this driver fully to >>> the kthread API - it will end up much better. >>> >>> I'll queue this up as a -mm-only thing as a gentle reminder

Re: [Devel] Re: [PATCH] bluetooth bnep: Convert to kthread API.

2007-04-20 Thread Cedric Le Goater
Andrew Morton wrote: > On Thu, 19 Apr 2007 01:58:51 -0600 > "Eric W. Biederman" <[EMAIL PROTECTED]> wrote: > >> From: Eric W. Biederman <[EMAIL PROTECTED]> >> >> This patch starts kbenpd using kthread_run replacing >> a combination of kernel_thread and daemonize. Making >> the code a little simpl

Re: [PATCH] saa7134-tvaudio: Convert to kthread API.

2007-04-20 Thread Cedric Le Goater
rivers/modules. Also remove signalling code as it is not needed in the driver. Signed-off-by: Sukadev Bhattiprolu <[EMAIL PROTECTED]> Signed-off-by: Cedric Le Goater <[EMAIL PROTECTED]> Cc: Mauro Carvalho Chehab <[EMAIL PROTECTED]> Cc: [EMAIL PROTECTED] Cc: [EMAIL PROTECTED] Cc:

Re: [Devel] Re: [PATCH] bluetooth rfcomm: Convert to kthread API.

2007-04-20 Thread Cedric Le Goater
t;> -kernel_thread(rfcomm_run, NULL, CLONE_KERNEL); >> +kthread_run(rfcomm_run, NULL, "krfcommd"); >> >> if (class_create_file(bt_class, &class_attr_rfcomm_dlc) < 0) >> BT_ERR("Failed to create RFCOMM info file&qu

Re: [Devel] Re: [PATCH] bluetooth bnep: Convert to kthread API.

2007-04-20 Thread Cedric Le Goater
Cedric Le Goater wrote: > Andrew Morton wrote: >> On Thu, 19 Apr 2007 01:58:51 -0600 >> "Eric W. Biederman" <[EMAIL PROTECTED]> wrote: >> >>> From: Eric W. Biederman <[EMAIL PROTECTED]> >>> >>> This patch starts kbenpd using

[PATCH -mm] remove dup_namespaces() declaration

2007-03-23 Thread Cedric Le Goater
Hello ! Here's a minor fix for merge-sys_clone-sys_unshare-nsproxy-and-namespace.patch dup_namespaces() does not exist any more, so we should remove the declaration from nsproxy.h. Signed-off-by: Cedric Le Goater <[EMAIL PROTECTED]> --- include/linux/nsproxy.h |1 - 1 file

Re: [PATCH] Hookup group-scheduler with task container infrastructure

2007-09-11 Thread Cedric Le Goater
Paul Menage wrote: > On 9/10/07, Dmitry Adamushko <[EMAIL PROTECTED]> wrote: >> On 10/09/2007, Srivatsa Vaddagiri <[EMAIL PROTECTED]> wrote: >>> On Mon, Sep 10, 2007 at 10:22:59AM -0700, Andrew Morton wrote: objection ;) "cpuctlr" isn't memorable. Kernel code is write-rarely, read-often

Re: 2.6.23-rc7-mm1

2007-09-24 Thread Cedric Le Goater
/dasd_eckd.o] Error 1 make[2]: *** [drivers/s390/block] Error 2 Signed-off-by: Cedric Le Goater <[EMAIL PROTECTED]> --- drivers/s390/block/dasd_eckd.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: 2.6.23-rc7-

Re: 2.6.23-rc7-mm1 -- s390 compile failures

2007-09-24 Thread Cedric Le Goater
. I think this patch fixes it. C. Signed-off-by: Cedric Le Goater <[EMAIL PROTECTED]> --- arch/s390/mm/cmm.c |1 + 1 file changed, 1 insertion(+) Index: 2.6.23-rc7-mm1/arch/s390/mm/cmm.c === --- 2.6.23-rc7-mm1.orig/arch/s390

Re: 2.6.23-rc7-mm1

2007-09-24 Thread Cedric Le Goater
Andrew Morton wrote: > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc7/2.6.23-rc7-mm1/ I also get this compile error on s390. 'linux/scatterlist.h' has disappeared from the #include pile but where ? /home/clg/linux/2.6.23-rc7-mm1/net/sctp/auth.c: In function `sctp_auth

Re: 2.6.23-rc7-mm1

2007-09-24 Thread Cedric Le Goater
putting Vlad in Cc: Cedric Le Goater wrote: > Andrew Morton wrote: >> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc7/2.6.23-rc7-mm1/ > > I also get this compile error on s390. 'linux/scatterlist.h' has disappeared > from the #include pil

Re: [PATCH] Remove unused member from nsproxy

2007-09-26 Thread Cedric Le Goater
Pavel Emelyanov wrote: > The nslock spinlock is not used in the kernel at all. it's also useless now that you have put some RCU rules around it. right ? C. > Remove it. > Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> > > --- > > diff --git a/include/linux/init_task.h b/include/linux/ini

Re: [PATCH] Use KMEM_CACHE macro to create the nsproxy cache

2007-09-26 Thread Cedric Le Goater
Pavel Emelyanov wrote: > The blessed way for standard caches is to use it. > Besides, this may give this cache a better alignment. > > Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> yes of course. thanks. Acked-by: Cedric Le Goater <[EMAIL PROTECTED]> > -

Re: [PATCH 1/5] The config option itself

2007-09-27 Thread Cedric Le Goater
#x27;s request to move there all the namespaces that are > not finished yet. Currently only the user and the network > namespaces are such. > > Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> Acked-by: Cedric Le Goater <[EMAIL PROTECTED]> Thanks ! C. > > --- >

Re: [PATCH 2/5] Move the UST namespace under the option

2007-09-27 Thread Cedric Le Goater
t;[EMAIL PROTECTED]> Acked-by: Cedric Le Goater <[EMAIL PROTECTED]> Thanks ! C. > > --- > > diff --git a/include/linux/utsname.h b/include/linux/utsname.h > index 923db99..52b9116 100644 > --- a/include/linux/utsname.h > +++ b/include/linux/utsname.h > @@

  1   2   >