Re: [PATCH 2/2] mtd: nand: Get rid of needless 'goto'

2016-07-19 Thread Boris Brezillon
On Tue, 19 Jul 2016 11:48:04 -0700 Andrey Smirnov wrote: > On Tue, Jul 19, 2016 at 11:30 AM, Brian Norris > wrote: > > On Tue, Jul 19, 2016 at 08:41:44AM -0700, Andrey Smirnov wrote: > >> Using "goto" in that "switch" statement only makes it harder to follow > >> control flow and doesn't bring

Re: [PATCH v2 1/2] mtd: nand: Error out if cmd_ctrl() is missing

2016-07-19 Thread Boris Brezillon
On Tue, 19 Jul 2016 22:33:57 -0700 Andrey Smirnov wrote: > If no user specified chip->select_chip() function is provided, code in > nand_base.c will automatically set this hook to nand_select_chip(), > which in turn depends on chip->cmd_ctrl() hook being valid. Not > providing both of those funct

Re: [PATCH] arm: dts: fix rk3066a based boards vdd_log voltage initialization

2016-09-19 Thread Boris Brezillon
On Mon, 19 Sep 2016 09:38:34 -0700 Doug Anderson wrote: > Hi, > > On Mon, Sep 19, 2016 at 9:15 AM, Heiko Stuebner wrote: > > Am Montag, 19. September 2016, 08:15:30 CEST schrieb Doug Anderson: > >> Hi, > >> > >> On Mon, Sep 19, 2016 at 1:44 AM, Andy Yan wrote: > >> > >> > The current rk30

Re: [PATCH] arm: dts: fix rk3066a based boards vdd_log voltage initialization

2016-09-19 Thread Boris Brezillon
On Mon, 19 Sep 2016 10:22:43 -0700 Doug Anderson wrote: > Hi, > > On Mon, Sep 19, 2016 at 10:13 AM, Boris Brezillon > wrote: > > Correct me if I'm wrong, but the main problem here is that, when we try > > to detect the initial regulator state, we ran into a "m

Re: [PATCH] arm: dts: fix rk3066a based boards vdd_log voltage initialization

2016-09-19 Thread Boris Brezillon
On Mon, 19 Sep 2016 10:52:51 -0700 Doug Anderson wrote: > Hi, > > On Mon, Sep 19, 2016 at 10:48 AM, Boris Brezillon > wrote: > > The PWM chip has always claimed the pins and muxed them to the PWM IP. > > So, this means it's broken from the beginning, and my pat

Re: [PATCH] arm: dts: fix rk3066a based boards vdd_log voltage initialization

2016-09-19 Thread Boris Brezillon
On Mon, 19 Sep 2016 11:12:12 -0700 Doug Anderson wrote: > Hi, > > On Mon, Sep 19, 2016 at 11:06 AM, Boris Brezillon > wrote: > > On Mon, 19 Sep 2016 10:52:51 -0700 > > Doug Anderson wrote: > > > >> Hi, > >> > >> On Mon, Sep 19, 2016 a

Re: [PATCH] arm: dts: fix rk3066a based boards vdd_log voltage initialization

2016-09-19 Thread Boris Brezillon
On Mon, 19 Sep 2016 11:12:12 -0700 Doug Anderson wrote: > Hi, > > On Mon, Sep 19, 2016 at 11:06 AM, Boris Brezillon > wrote: > > On Mon, 19 Sep 2016 10:52:51 -0700 > > Doug Anderson wrote: > > > >> Hi, > >> > >> On Mon, Sep 19, 2016 a

Re: [PATCH v5] mtd: spi-nor: Add support for S3AN spi-nor devices

2016-09-20 Thread Boris Brezillon
Hi Ricardo, On Fri, 16 Sep 2016 21:33:52 +0200 Ricardo Ribalda Delgado wrote: > Xilinx Spartan-3AN FPGAs contain an In-System Flash where they keep > their configuration data and (optionally) some user data. > > The protocol of this flash follows most of the spi-nor standard. With > the followi

Re: [PATCH v5] mtd: spi-nor: Add support for S3AN spi-nor devices

2016-09-20 Thread Boris Brezillon
On Tue, 20 Sep 2016 17:45:55 +0200 Ricardo Ribalda Delgado wrote: > Hi Boris > > Thanks for your review. > > On Tue, Sep 20, 2016 at 1:21 PM, Boris Brezillon > wrote: > >> int sr, fsr; > >> - sr = spi_nor_sr_ready(nor); > >> + >

Re: [PATCH v5] mtd: spi-nor: Add support for S3AN spi-nor devices

2016-09-20 Thread Boris Brezillon
On Fri, 16 Sep 2016 21:33:52 +0200 Ricardo Ribalda Delgado wrote: > Xilinx Spartan-3AN FPGAs contain an In-System Flash where they keep > their configuration data and (optionally) some user data. > > The protocol of this flash follows most of the spi-nor standard. With > the following difference

Re: [PATCH] mtd: spi-nor: Add support for S3AN spi-nor devices

2016-09-21 Thread Boris Brezillon
> > Protocol is described on Xilinx User Guide UG333 > > Reviewed-by: Cyrille Pitchen > Signed-off-by: Ricardo Ribalda Delgado > --- > v6: > Suggested by: Boris Brezillon > -Replace triple operator with if/else > > v5: > -Rebase on top of l2-mtd/master > Sug

Re: [PATCH] mtd: spi-nor: Add support for S3AN spi-nor devices

2016-09-21 Thread Boris Brezillon
On Wed, 21 Sep 2016 09:57:23 +0200 Ricardo Ribalda Delgado wrote: > Hi Boris > > On Wed, Sep 21, 2016 at 9:07 AM, Boris Brezillon > wrote: > > Hi Ricardo, > > > > Please try to pass the version in your subject prefix (pass > > --subject-prefix="PATCH v

Re: [PATCH] mtd: spi-nor: Add support for S3AN spi-nor devices

2016-09-21 Thread Boris Brezillon
On Wed, 21 Sep 2016 10:14:20 +0200 Boris Brezillon wrote: > On Wed, 21 Sep 2016 09:57:23 +0200 > Ricardo Ribalda Delgado wrote: > > > Hi Boris > > > > On Wed, Sep 21, 2016 at 9:07 AM, Boris Brezillon > > wrote: > > > Hi Ricardo, > > > &

Re: [PATCH] mtd: spi-nor: Add support for S3AN spi-nor devices

2016-09-21 Thread Boris Brezillon
On Wed, 21 Sep 2016 10:19:10 +0200 Ricardo Ribalda Delgado wrote: > Hi Boris > > On Wed, Sep 21, 2016 at 10:14 AM, Boris Brezillon > wrote: > > Wait. If you really want to manipulate an loff_t variable, you can do > > > > offset = do_div(addr, nor->

Re: [PATCH v2 02/46] mtd: nand: Provide nand_cleanup() function to free NAND related resources

2016-09-21 Thread Boris Brezillon
On Wed, 21 Sep 2016 11:44:41 +0200 Daniel Walter wrote: > From: Richard Weinberger > > Provide a nand_cleanup() function to free all nand related resources > without unregistering the mtd device. > This should allow drivers to call mtd_device_unregister() and handle > its return value and still

Re: [PATCH v2 01/46] mtdpart: Propagate _get/put_device()

2016-09-21 Thread Boris Brezillon
ng _get/put_device() down. Brian, can we have this one queued for 4.9? I can't take it in my tree if you want, but it's probably better if it's in the mtd tree. > > Reviewed-by: Boris Brezillon > Signed-off-by: Richard Weinberger > --- > drivers/mtd/mtdpart

Re: [PATCH 1/2] mtd: nand: mxc: Test CONFIG_OF instead of CONFIG_OF_MTD

2016-09-21 Thread Boris Brezillon
On Sat, 17 Sep 2016 19:57:10 +0200 Boris Brezillon wrote: > We are about to drop the OF_MTD Kconfig option. Test CONFIG_OF > activation instead of CONFIG_OF_MTD. Applied both. > > Signed-off-by: Boris Brezillon > --- > drivers/mtd/nand/mxc_nand.c | 2 +- > 1 file chang

Re: [PATCH v2 02/46] mtd: nand: Provide nand_cleanup() function to free NAND related resources

2016-09-21 Thread Boris Brezillon
Daniel, Richard, On Wed, 21 Sep 2016 11:44:41 +0200 Daniel Walter wrote: > From: Richard Weinberger > > Provide a nand_cleanup() function to free all nand related resources > without unregistering the mtd device. > This should allow drivers to call mtd_device_unregister() and handle > its retu

Re: [PATCH v2 03/46] mtd: Don't unconditionally unregister reboot notifier

2016-09-21 Thread Boris Brezillon
On Wed, 21 Sep 2016 11:45:12 +0200 Daniel Walter wrote: > From: Richard Weinberger > > del_mtd_device() is allowed to fail. > i.e. when the MTD is busy. > Unregister the reboot notifier only when we're really > about to delete the MTD. > > Signed-off-by: Richard Weinberger > --- > drivers/mt

Re: [PATCH v2 02/46] mtd: nand: Provide nand_cleanup() function to free NAND related resources

2016-09-21 Thread Boris Brezillon
On Wed, 21 Sep 2016 16:38:28 +0200 Daniel Walter wrote: > Boris, > > On 09/21/2016 04:25 PM, Boris Brezillon wrote: > > Daniel, Richard, > > > > On Wed, 21 Sep 2016 11:44:41 +0200 > > Daniel Walter wrote: > > > >> From: Richard Weinberger

Re: [PATCH] tty/serial: atmel: fix fractional baud rate computation

2016-09-22 Thread Boris Brezillon
On Thu, 22 Sep 2016 09:07:46 +0200 Uwe Kleine-König wrote: > On Wed, Sep 21, 2016 at 12:44:14PM +0200, Nicolas Ferre wrote: > > From: Alexey Starikovskiy > > > > The problem with previous code was it rounded values in wrong > > place and produced wrong baud rate in some cases. > > > > Signed-o

Re: [PATCH] tty/serial: atmel: fix fractional baud rate computation

2016-09-22 Thread Boris Brezillon
On Thu, 22 Sep 2016 09:39:04 +0200 Boris Brezillon wrote: > On Thu, 22 Sep 2016 09:07:46 +0200 > Uwe Kleine-König wrote: > > > On Wed, Sep 21, 2016 at 12:44:14PM +0200, Nicolas Ferre wrote: > > > From: Alexey Starikovskiy > > > > > > The problem w

Re: [PATCH] arm: dts: fix rk3066a based boards vdd_log voltage initialization

2016-09-22 Thread Boris Brezillon
+Mark I realize Mark has been out of the discussion, and what started as a DT problem actually turned into a PWM regulator discussion. Maybe we should start a new thread. On Mon, 19 Sep 2016 14:15:06 -0700 Doug Anderson wrote: > Hi, > > On Mon, Sep 19, 2016 at 1:43 PM, Boris

Re: [PATCH 1/6] mtd: spi-nor: Add quad page program support

2016-09-22 Thread Boris Brezillon
On Thu, 22 Sep 2016 19:59:13 +0530 Jagan Teki wrote: > On Mon, Aug 29, 2016 at 6:54 PM, Jagan Teki wrote: > > On Wed, Aug 10, 2016 at 2:10 AM, Jagan Teki wrote: > >> Add quad page program support with the use of nor->flags > >> and then controller will use 4 lines for data transmission > >> w

[PATCH v3 15/16] mtd: nand: hynix: rework NAND ID decoding to extract more information

2016-06-20 Thread Boris Brezillon
we are handling all the cases, but if new formats are discovered, the code should evolve to take them into account instead of adding more full-id entries in the nand_ids table. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/nand_hynix.c | 228 ++ 1

[PATCH v3 16/16] mtd: nand: hynix: add read-retry support for 1x nm MLC NANDs

2016-06-20 Thread Boris Brezillon
set of values instead of retrieving those information from the OTP area). Signed-off-by: Boris Brezillon --- drivers/mtd/nand/nand_hynix.c | 359 +- 1 file changed, 358 insertions(+), 1 deletion(-) diff --git a/drivers/mtd/nand/nand_hynix.c b/drivers/mtd

Re: [PATCH v3 00/16] mtd: nand: allow vendor specific detection/initialization

2016-06-20 Thread Boris Brezillon
On Mon, 20 Jun 2016 11:26:46 +0200 Boris Brezillon wrote: > Hello, > > This patch series is a step forward in supporting vendor-specific > functionalities. > This series is mainly moving vendor-specific initialization or > detection code out of the core, but also introduces

[PATCH v3 08/16] mtd: nand: move Samsung specific init/detection logic in nand_samsung.c

2016-06-20 Thread Boris Brezillon
Move Samsung specific initialization and detection logic into nand_samsung.c. This is part of the "separate vendor specific code from core" cleanup process. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/Makefile | 1 + drivers/mtd/nand/nand_base

[PATCH v3 14/16] mtd: nand: samsung: retrieve ECC requirements from extended ID

2016-06-20 Thread Boris Brezillon
, K9GAG08X0D, K9GBG08U0A, K9GBG08U0B. These all use these bits in the exact same way. Signed-off-by: Hans de Goede Signed-off-by: Boris Brezillon --- drivers/mtd/nand/nand_samsung.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/mtd/nand/nand_samsung.c b/drivers/mtd

[PATCH v3 11/16] mtd: nand: move Micron specific init logic in nand_micron.c

2016-06-20 Thread Boris Brezillon
Move Micron specific initialization logic into nand_micron.c. This is part of the "separate vendor specific code from core" cleanup process. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/Makefile | 1 + drivers/mtd/nand/nand_base.c | 31 +--- driver

[PATCH v3 07/16] mtd: nand: kill the MTD_NAND_IDS Kconfig option

2016-06-20 Thread Boris Brezillon
MTD_NAND_IDS is selected by MTD_NAND, which makes it useless. Remove the Kconfig option and link nand_ids.o into the nand.o object file. Doing that also prevents adding an extra nand_ids.ko module when MTD_NAND is activated as a module. Signed-off-by: Boris Brezillon --- arch/cris/arch-v32

[PATCH v3 10/16] mtd: nand: move Toshiba specific init/detection logic in nand_toshiba.c

2016-06-20 Thread Boris Brezillon
Move Toshiba specific initialization and detection logic into nand_toshiba.c. This is part of the "separate vendor specific code from core" cleanup process. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/Makefile | 1 + drivers/mtd/nand/nand_base.c| 19 ++-

[PATCH v3 12/16] mtd: nand: move AMD/Spansion specific init/detection logic in nand_amd.c

2016-06-20 Thread Boris Brezillon
Moving AMD/Spansion specific initialization/detection into nand_amd.c. This is part of the "separate vendor specific code from core" cleanup process. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/Makefile| 1 + drivers/mtd/nand/nand_a

[PATCH v3 00/16] mtd: nand: allow vendor specific detection/initialization

2016-06-20 Thread Boris Brezillon
t's not. ->detect() implementation should can call nand_decode_ext_id() if needed. Boris Brezillon (15): mtd: nand: Fix nand_command_lp() for 8bits opcodes mtd: nand: get rid of the mtd parameter in all auto-detection functions mtd: nand: store nand ID in struct nand_chi

[PATCH v3 09/16] mtd: nand: move Hynix specific init/detection logic in nand_hynix.c

2016-06-20 Thread Boris Brezillon
Move Hynix specific initialization and detection logic into nand_hynix.c. This is part of the "separate vendor specific code from core" cleanup process. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/Makefile | 1 + drivers/mtd/nand/nand_bas

[PATCH v3 01/16] mtd: nand: Fix nand_command_lp() for 8bits opcodes

2016-06-20 Thread Boris Brezillon
8 bits opcodes should be followed by a single address cycle. Make the 2nd address cycle dependent of !nand_opcode_8bits(command). Signed-off-by: Boris Brezillon --- drivers/mtd/nand/nand_base.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/mtd/nand/nand_base.c

[PATCH v3 13/16] mtd: nand: move Macronix specific initialization in nand_macronix.c

2016-06-20 Thread Boris Brezillon
Move Macronix specific initialization into nand_macronix.c. This is part of the "separate vendor specific code from core" cleanup process. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/Makefile| 1 + drivers/mtd/nand/nand_base.c | 11 --- drivers/mtd/nand/

[PATCH v3 03/16] mtd: nand: store nand ID in struct nand_chip

2016-06-20 Thread Boris Brezillon
Store the NAND ID in struct nand_chip to avoid passing id_data and id_len as function parameters. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/nand_base.c | 55 include/linux/mtd/nand.h | 13 +++ 2 files changed, 43 insertions

[PATCH v3 02/16] mtd: nand: get rid of the mtd parameter in all auto-detection functions

2016-06-20 Thread Boris Brezillon
Now that struct nand_chip embeds an mtd_info object we can get rid of the mtd parameter and extract it from the chip parameter with the nand_to_mtd() helper. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/nand_base.c | 56 1 file changed, 30

[PATCH v3 04/16] mtd: nand: get rid of busw parameter

2016-06-20 Thread Boris Brezillon
hip->options if needed. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/nand_base.c | 68 1 file changed, 37 insertions(+), 31 deletions(-) diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c index f890f3e2eaa3..b174d7c6ba1f

[PATCH v3 05/16] mtd: nand: rename nand_get_flash_type() into nand_detect()

2016-06-20 Thread Boris Brezillon
The only caller of nand_get_flash_type() (nand_scan_ident()) actually don't use the returned nand_flash_dev pointer except for converting it to to an error code. Rename this function nand_detect() and make it return an integer. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/nand_b

[PATCH v3 06/16] mtd: nand: add manufacturer specific initialization/detection steps

2016-06-20 Thread Boris Brezillon
or all the vendor specific cases added over the time in the generic NAND ID decoding logic. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/nand_base.c | 67 +++- include/linux/mtd/nand.h | 36 2 files changed, 90

Re: [PATCH 2/2] mtd: nand: sunxi: add reset line support

2016-06-20 Thread Boris Brezillon
Hi Philipp, On Mon, 20 Jun 2016 14:05:54 +0200 Philipp Zabel wrote: > Am Sonntag, den 19.06.2016, 14:06 +0200 schrieb Boris Brezillon: > > +Philipp > > > > On Sun, 19 Jun 2016 19:37:39 +0800 > > Icenowy Zheng wrote: > > > > > The NAND controller o

[PATCH v2 2/3] mtd: nand: implement two pairing scheme

2016-06-20 Thread Boris Brezillon
Implement two common pairing scheme (found on many MLC devices), and name them in reference to the paired pages distance (3 or 6 pages). Signed-off-by: Boris Brezillon Signed-off-by: Richard Weinberger --- drivers/mtd/nand/nand_base.c | 97 include

[PATCH v2 3/3] mtd: nand: add a pairing field to nand_flash_dev

2016-06-20 Thread Boris Brezillon
Add a new field to attach a pairing scheme to a NAND chip definition and assign it to mtd->pairing when a full-id match is detected. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/nand_base.c | 1 + include/linux/mtd/nand.h | 2 ++ 2 files changed, 3 insertions(+) diff --git a/driv

[PATCH v2 1/3] mtd: introduce the mtd_pairing_scheme concept

2016-06-20 Thread Boris Brezillon
nformation attached to a given page (here called wunit), or the other way around (the wunit pointed by pairing information). It also provides several helpers to help the conversion between absolute offsets and wunits, and query the number of pairing groups. Signed-off-by: Boris Brezillon --- d

[PATCH v2 0/3] mtd: add support for pairing scheme description

2016-06-20 Thread Boris Brezillon
t6 pairing scheme to the H27UCG8T2ATR NAND (in the light of George comment I'm not longer sure this scheme is suitable for this NAND, and I can't test it) Boris Brezillon (3): mtd: introduce the mtd_pairing_scheme concept mtd: nand: implement two pairing scheme mtd: nand: add

[PULL] drm/bridge: sii902x driver

2016-06-20 Thread Boris Brezillon
7:06 +0200) Add basic support for the sii902x RGB -> HDMI bridge. ---- Boris Brezillon (2): drm/bridge: Add sii902x driver drm/bridge: Add sii902x DT bindings doc Documentation/devicetree/bindings/d

Re: [PATCH 02/11] mtd: nand_bbt: introduce BBT related data structure

2016-06-21 Thread Boris Brezillon
On Fri, 17 Jun 2016 10:38:27 +0800 Peter Pan wrote: > >> > >> Again, I'm sorry that you had to be the one supporting this transition, > >> but I don't want to introduce any more quick-and-dirty hacks that we'll > >> have to maintain until someone decides to tackle the real problem. > > > > No s

Re: [PATCH v2 4/6] mtd: nand: gpmi: correct bitflip for erased NAND page

2016-06-21 Thread Boris Brezillon
On Tue, 21 Jun 2016 10:53:48 -0500 Han Xu wrote: > On Tue, Jun 14, 2016 at 2:14 PM, Boris Brezillon > wrote: > > On Fri, 10 Jun 2016 12:01:32 -0500 > > Han Xu wrote: > > > >> i.MX6QP and i.MX7D BCH module integrated a new feature to detect the > >> b

Re: [PATCH v2] pwm: improve args checking in pwm_apply_state()

2016-06-21 Thread Boris Brezillon
On Tue, 21 Jun 2016 11:37:31 -0700 Brian Norris wrote: > Hi Geert, > > On Tue, Jun 21, 2016 at 04:42:04PM +0200, Geert Uytterhoeven wrote: > > On Fri, May 27, 2016 at 6:45 PM, Brian Norris > > wrote: > > > It seems like in the process of refactoring pwm_config() to utilize the > > > newly-in

Re: [PATCH] arm: dts: fix rk3066a based boards vdd_log voltage initialization

2016-09-22 Thread Boris Brezillon
On Thu, 22 Sep 2016 17:47:52 +0100 Mark Brown wrote: > On Thu, Sep 22, 2016 at 05:12:17PM +0200, Boris Brezillon wrote: > > +Mark > > > I realize Mark has been out of the discussion, and what started as a DT > > problem actually turned into a PWM regulator discuss

Re: [PATCH] tty/serial: atmel: fix fractional baud rate computation

2016-09-25 Thread Boris Brezillon
On Thu, 22 Sep 2016 11:43:08 +0200 Boris Brezillon wrote: > On Thu, 22 Sep 2016 09:39:04 +0200 > Boris Brezillon wrote: > > > On Thu, 22 Sep 2016 09:07:46 +0200 > > Uwe Kleine-König wrote: > > > > > On Wed, Sep 21, 2016 at 12:44:14PM +0200, Nicolas F

Re: [PATCH] tty/serial: atmel: fix fractional baud rate computation

2016-09-25 Thread Boris Brezillon
port to newer kernel and add commit log] > Signed-off-by: Nicolas Ferre Reviewed-by: Boris Brezillon > --- > drivers/tty/serial/atmel_serial.c | 10 ++ > include/linux/atmel_serial.h | 1 + > 2 files changed, 7 insertions(+), 4 deletions(-) > > diff --gi

Re: [PATCH] mtd: s3c2410: add device tree support

2016-09-25 Thread Boris Brezillon
Hi Sergio, On Sun, 25 Sep 2016 14:42:57 -0300 Sergio Prado wrote: > Hi Boris, > > > > +Optional properties: > > > +- samsung,tacls : time for active CLE/ALE to nWE/nOE > > > +- samsung,twrph0 : active time for nWE/nOE > > > +- samsung,twrph1 : time for release CLE/ALE from nWE/nOE inactive >

[PULL] mtd: nand: material for 4.9

2016-09-25 Thread Boris Brezillon
r out if cmd_ctrl() is missing mtd: nand: Get rid of needless 'goto' Boris Brezillon (10): mtd: nand: timings: Fix tADL_min for ONFI 4.0 chips mtd: nand: timings: Reorder tRR_min def in mode 0 mtd: nand_bbt: Move BBT block selection logic out of write_bbt()

[PATCH] irqchip/atmel-aic: Fix potential deadlock in ->xlate()

2016-09-13 Thread Boris Brezillon
}() ones to prevent this bug from happening. Signed-off-by: Boris Brezillon Fixes: b1479ebb7720 ("irqchip: atmel-aic: Add atmel AIC/AIC5 drivers") Cc: --- drivers/irqchip/irq-atmel-aic.c | 5 +++-- drivers/irqchip/irq-atmel-aic5.c | 5 +++-- 2 files changed, 6 insertions(+), 4 deletions(-)

Re: [PATCH] irqchip/atmel-aic: Fix potential deadlock in ->xlate()

2016-09-13 Thread Boris Brezillon
On Tue, 13 Sep 2016 12:10:09 +0200 Boris Brezillon wrote: > aic5_irq_domain_xlate() and aic_irq_domain_xlate() take the generic chip > lock without disabling interrupts, which can lead to a deadlock if an > interrupt occurs while the lock is held in one of these functions. > >

Re: [PATCH] irqchip/atmel-aic: Fix potential deadlock in ->xlate()

2016-09-13 Thread Boris Brezillon
On Tue, 13 Sep 2016 12:10:09 +0200 Boris Brezillon wrote: > aic5_irq_domain_xlate() and aic_irq_domain_xlate() take the generic chip > lock without disabling interrupts, which can lead to a deadlock if an > interrupt occurs while the lock is held in one of these functions. > >

[PATCH v2] irqchip/atmel-aic: Fix potential deadlock in ->xlate()

2016-09-13 Thread Boris Brezillon
}() ones to prevent this bug from happening. Signed-off-by: Boris Brezillon Fixes: b1479ebb7720 ("irqchip: atmel-aic: Add atmel AIC/AIC5 drivers") Cc: Acked-by: Marc Zyngier --- Changes in v2: - add Marc's ack - fix stable ML address --- drivers/irqchip/irq-atmel-aic.c | 5 +++-- driv

Re: [PATCH] irqchip/atmel-aic: Fix potential deadlock in ->xlate()

2016-09-13 Thread Boris Brezillon
On Tue, 13 Sep 2016 14:55:20 +0200 (CEST) Thomas Gleixner wrote: > On Tue, 13 Sep 2016, Boris Brezillon wrote: > > > aic5_irq_domain_xlate() and aic_irq_domain_xlate() take the generic chip > > lock without disabling interrupts, which can lead to a deadlock if an > > in

[PATCH v3 2/2] irqchip/atmel-aic: Fix potential deadlock in ->xlate()

2016-09-13 Thread Boris Brezillon
}() ones to prevent this bug from happening. Signed-off-by: Boris Brezillon Fixes: b1479ebb7720 ("irqchip: atmel-aic: Add atmel AIC/AIC5 drivers") Cc: Acked-by: Marc Zyngier --- Changes in v3: - introduce and use the irq_gc_{lock_irqsave,unlock_irqrestore}() helpers Changes in v2: - add

[PATCH v3 1/2] genirq: Provide irq_gc_{lock_irqsave,unlock_irqrestore}() helpers

2016-09-13 Thread Boris Brezillon
ers for !SMP, because they are not called from the hot-path. Signed-off-by: Boris Brezillon Cc: --- include/linux/irq.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/linux/irq.h b/include/linux/irq.h index b52424eaa0ed..b13668f97648 100644 --- a/include/linux/irq.h +++ b/incl

Re: [PATCH v3 2/2] irqchip/atmel-aic: Fix potential deadlock in ->xlate()

2016-09-13 Thread Boris Brezillon
On Tue, 13 Sep 2016 15:58:29 +0200 Boris Brezillon wrote: > aic5_irq_domain_xlate() and aic_irq_domain_xlate() take the generic chip > lock without disabling interrupts, which can lead to a deadlock if an > interrupt occurs while the lock is held in one of these functions. > >

[PATCH v3] mtd: introduce the mtd_pairing_scheme concept

2016-09-15 Thread Boris Brezillon
nformation attached to a given page (here called wunit), or the other way around (the wunit pointed by pairing information). It also provides several helpers to help the conversion between absolute offsets and wunits, and query the number of pairing groups. Signed-off-by: Boris Brezillon Reviewed

Re: [PATCH BUGFIX] mtd: nand: mxc: fix obiwan error in mxc_nand_v[12]_ooblayout_free() functions

2016-09-15 Thread Boris Brezillon
Hi Lothar, On Fri, 9 Sep 2016 16:44:11 +0200 Lothar Waßmann wrote: > commit a894cf6c5a82 ("mtd: nand: mxc: switch to mtd_ooblayout_ops") > introduced a regression accessing the OOB area from the mxc_nand > driver due to an Obiwan error in the mxc_nand_v[12]_ooblayout_free() > functions. They re

Re: drm/atmel-hlcdc: connector type & fbdev mode settings

2016-08-31 Thread Boris Brezillon
On Wed, 31 Aug 2016 11:29:53 +0900 Hyung Jin Jung wrote: > According to Atmel's guideline... > http://www.at91.com/linux4sam/bin/view/Linux4SAM/UsingAtmelDRMDriver > > the "fbdev emulation mode" could be set from kernel command line (LVDS-1:...) > however, driver register it as DRM_MODE_CONNECT

Re: [RESEND v5] mtd: nand_bbt: scan for next free bbt block if writing bbt fails

2016-08-08 Thread Boris Brezillon
Hi Kyle, On Tue, 2 Aug 2016 15:01:50 -0500 Kyle Roeschley wrote: > If erasing or writing the BBT fails, we should mark the current BBT > block as bad and use the BBT descriptor to scan for the next available > unused block in the BBT. We should only return a failure if there isn't > any space le

Re: Linux 4.8-rc1 Cirrus QEMU crashes on boot.

2016-08-08 Thread Boris Brezillon
encoder = drm_atomic_helper_best_encoder(connector); > else > encoder = connector_funcs->best_encoder(connector); > > in particular, the trapping instruction is the load of "atomic_commit". > > (The "callq *%rax" seems to be the "co

Re: [PATCH v2 1/3] mtd: introduce the mtd_pairing_scheme concept

2016-08-08 Thread Boris Brezillon
Hi Brian, On Thu, 4 Aug 2016 12:37:51 +0800 Brian Norris wrote: > Hi Boris, > > On Mon, Jun 20, 2016 at 03:50:16PM +0200, Boris Brezillon wrote: > > MLC and TLC NAND devices are using NAND cells exposing more than one bit, > > but instead of attaching all the bits in a g

[PATCH] drm/cirrus: Fix NULL pointer dereference when registering the fbdev

2016-08-08 Thread Boris Brezillon
ocess. Make sure dev->mode_config.funcs is properly set to avoid dereferencing a NULL pointer. Signed-off-by: Boris Brezillon Fixes: c61b93fe51b1 ("drm/atomic: Fix remaining places where !funcs->best_encoder is valid") --- Hi Dave, As discussed on IRC, I'm sending this patc

Re: [PATCH] drm/cirrus: Fix NULL pointer dereference when registering the fbdev

2016-08-09 Thread Boris Brezillon
On Mon, 08 Aug 2016 22:36:13 -0500 ebied...@xmission.com (Eric W. Biederman) wrote: > Boris Brezillon writes: > > > cirrus_modeset_init() is initializing/registering the emulated fbdev > > and, since commit c61b93fe51b1 ("drm/atomic: Fix remaining places where > >

Re: [PATCH v2 1/2] mtd: brcmnand: iProc big endian and ONFI support

2016-08-26 Thread Boris Brezillon
On Wed, 20 Jul 2016 14:53:50 -0700 Ray Jui wrote: > This patch adds big endian and ONFI support for various iProc based > SoCs that use the core brcmstb NAND controller > > This patch was originally implemented by Prafulla Kota > and fully tested on iProc based NS2 SVK > > Signed-off-by: Prafu

Re: [PATCH] mtd: nand: Allow MTD_NAND_OMAP2 to be usable on Keystone devices

2016-08-26 Thread Boris Brezillon
On Wed, 24 Aug 2016 12:25:00 +0300 Roger Quadros wrote: > Some Keystone devices (e.g. K2G) include a OMAP NAND IP. > Allow the NAND driver to be usable for both > Keystone and OMAP devices. > > Signed-off-by: Roger Quadros Applied. Thanks, Boris > --- > drivers/mtd/nand/Kconfig | 8 ---

Re: [PATCH 7/7] UBI: provide helpers to allocate and free aeb elements

2016-08-26 Thread Boris Brezillon
On Tue, 23 Aug 2016 09:32:54 +0200 Boris Brezillon wrote: > This not only hides the aeb allocation internals (which is always good in > case we ever want to change the allocation system), but also helps us > factorize the initialization of some common fields (ec and pnum). > >

Re: [RFC 2/5] i3c: Add core I3C infrastructure

2017-08-17 Thread Boris Brezillon
Le Wed, 16 Aug 2017 23:03:55 +0200, Geert Uytterhoeven a écrit : > On Tue, Aug 1, 2017 at 5:01 PM, Wolfram Sang wrote: > >> I'm perfectly fine with the I3C / I2C framework separation. The only > >> minor problem I had with that was the inaccuracy of the > >> sysfs/device-model representation: we

Re: [PATCH v5 1/9] mtd: sharpslpart: Add sharpslpart partition parser

2017-08-17 Thread Boris Brezillon
Le Mon, 14 Aug 2017 22:48:32 +0200, Andrea Adami a écrit : > The Sharp SL Series (Zaurus) PXA handhelds have 16/64/128M of NAND flash > and share the same layout of the first 7M partition, managed by Sharp FTL. > > The purpose of this self-contained patch is to add a common parser and > remove t

Re: [RFC 2/5] i3c: Add core I3C infrastructure

2017-08-17 Thread Boris Brezillon
Le Thu, 17 Aug 2017 11:03:10 +0200, Linus Walleij a écrit : > On Mon, Jul 31, 2017 at 6:24 PM, Boris Brezillon > wrote: > > > This infrastructure is not complete yet and will be extended over > > time. > > I noticed the lack of pm_* from the core. > >

Re: [PATCH] mtd: spear_smi: add NULL check on devm_kzalloc() return value

2017-08-17 Thread Boris Brezillon
Le Thu, 6 Jul 2017 17:25:50 -0500, "Gustavo A. R. Silva" a écrit : > Check return value from call to devm_kzalloc() > in order to prevent a NULL pointer dereference. > > This issue was detected using Coccinelle and the following semantic patch: > > @@ > expression x; > identifier fld; > @@ > >

Re: [PATCH 03/11] mtd: physmap_of: Drop unnecessary static

2017-08-17 Thread Boris Brezillon
Le Sat, 15 Jul 2017 22:07:38 +0200, Julia Lawall a écrit : > Drop static on a local variable, when the variable is initialized before > any possible use. Thus, the static has no benefit. > > The semantic patch that fixes this problem is as follows: > (http://coccinelle.lip6.fr/) > > // > @bad

Re: [PATCH] mtd: Convert to using %pOF instead of full_name

2017-08-17 Thread Boris Brezillon
t; > Signed-off-by: Rob Herring > Cc: David Woodhouse > Cc: Brian Norris > Cc: Boris Brezillon > Cc: Marek Vasut > Cc: Richard Weinberger > Cc: Cyrille Pitchen > Cc: linux-...@lists.infradead.org > --- > drivers/mtd/maps/physmap_of_core.c | 4 ++--

Re: [PATCH] [RESEND] mtd: only use __xipram annotation when XIP_KERNEL is set

2017-08-17 Thread Boris Brezillon
Le Fri, 4 Aug 2017 11:00:05 +0200, Arnd Bergmann a écrit : > On Fri, Aug 4, 2017 at 9:35 AM, Boris Brezillon > wrote: > > On Fri, 21 Jul 2017 22:26:25 +0200 > > Arnd Bergmann wrote: > > >> Note that MTD_XIP has been broken on ARM since around 2011 or 2012. I

Re: [PATCH 0/6] constify mtd pci_device_id

2017-08-17 Thread Boris Brezillon
Le Thu, 3 Aug 2017 21:52:04 +0530, Arvind Yadav a écrit : > pci_device_id are not supposed to change at runtime. All functions > working with pci_device_id provided by work with > const pci_device_id. So mark the non-const structs as const. Applied the whole series to l2-mtd/master. Thanks,

Re: [PATCH] mtd: physmap_of: Fix resources leak in 'of_flash_probe()'

2017-08-17 Thread Boris Brezillon
Le Sun, 6 Aug 2017 14:55:01 +0200, Christophe JAILLET a écrit : > If 'of_flash_probe_gemini()' or 'of_flash_probe_versatile()' fail, we must > reslease some resources, as already done in all error handling paths in > this function. Applied to l2-mtd/master. Thanks, Boris > > Signed-off-by:

Re: [PATCH v2] mtd: plat-ram: use release_mem_region instead of release_resource

2017-08-17 Thread Boris Brezillon
describe in more details what linuxtesting complained about and why you decided to fix it using devm_ioremap_resource(). > > Signed-off-by: Anton Vasilyev > Suggested-by: Boris Brezillon > --- > v1: Fix commit based on Boris Brezillon review > --- > v2: Change comm

Re: [PATCH] mtd: nand: convert to unified device property interface

2017-08-17 Thread Boris Brezillon
Le Wed, 16 Aug 2017 15:29:05 +0800, Kefeng Wang a écrit : > Changing from of_* to device_* interface, then we can also extract > the properties from ACPI tables as well as from DT. > > Signed-off-by: Kefeng Wang > --- > > - APCI will be supported in hisi504_nand.c, and it will use nand_scan_id

Re: [PATCH v3] MTD: NAND: add OOB layout without ECC bytes

2017-08-17 Thread Boris Brezillon
+Yoshi Hi Miquel, Subject prefix should be "mtd: nand: " in lowercase. Le Wed, 16 Aug 2017 09:39:06 +0200, Miquel Raynal a écrit : > Add layout functions for small and large pages with mainly free bytes > plus reserved space for Bad Block Markers. This may be useful for > specific chip that us

Re: [PATCH v7 00/16] mtd: nand: denali: Denali NAND IP improvements

2017-06-20 Thread Boris Brezillon
On Tue, 13 Jun 2017 22:45:34 +0900 Masahiro Yamada wrote: > This patch series intends to solve various problems. > > [1] The driver just retrieves the OOB area as-is > whereas the controller uses syndrome page layout. > [2] ONFi devices are not working > [3] It can not read Bad Block Marker

Re: [PATCH 4/4] drm/vc4: Remove dead vc4_event_pending().

2017-06-21 Thread Boris Brezillon
Le Wed, 21 Jun 2017 11:50:02 -0700, Eric Anholt a écrit : > It is no longer used as of commit 34c8ea400ff6 ("drm/vc4: Mimic > drm_atomic_helper_commit() behavior") > > Signed-off-by: Eric Anholt Reviewed-by: Boris Brezillon > --- > drivers/gpu/drm/vc4/vc4_crtc.c

Re: [PATCH 11/11] drm: remove unused and redundant callbacks

2017-06-22 Thread Boris Brezillon
On Thu, 22 Jun 2017 08:37:55 +0200 Daniel Vetter wrote: > On Thu, Jun 22, 2017 at 12:34:36AM +0800, kbuild test robot wrote: > > Hi Peter, > > > > [auto build test ERROR on drm/drm-next] > > [also build test ERROR on next-20170621] > > [cannot apply to v4.12-rc6] > > [if your patch is applied to

Re: [PATCH 2/4] drm/vc4: Wait for fences interruptibly in blocking mode.

2017-06-22 Thread Boris Brezillon
On Wed, 21 Jun 2017 11:50:00 -0700 Eric Anholt wrote: > We should allow SIGIO and things to interrupt us before we get to the > no-error stage of the commit process. This code is effectively copied > from drm_atomic_helper_commit(). > > Signed-off-by: Eric Anholt Reviewed-by:

Re: [PATCH 1/4] drm/vc4: Hook up plane prepare_fb to lookup dma-buf reservations.

2017-06-22 Thread Boris Brezillon
On Wed, 21 Jun 2017 11:49:59 -0700 Eric Anholt wrote: > This way drm_atomic_helper_wait_for_fences() will actually do > something. The vc4_seqno_cb has been doing the fence waits on V3D > manually, so far. > > Signed-off-by: Eric Anholt Reviewed-by: Boris Brezillon > ---

Re: [PATCH 3/4] drm/vc4: Use the atomic state's commit workqueue.

2017-06-22 Thread Boris Brezillon
On Wed, 21 Jun 2017 11:50:01 -0700 Eric Anholt wrote: > Now that we're using the atomic helpers for fence waits, we can use > the same codepath as drm_atomic_helper_commit() does for async, > getting rid of our custom vc4_commit struct. > > Signed-off-by: Eric Anholt

Re: [PATCH 1/7] drm/bridge: Support hotplugging panel-bridge.

2017-06-22 Thread Boris Brezillon
On Thu, 22 Jun 2017 13:47:43 +0530 Archit Taneja wrote: > On 06/22/2017 01:20 PM, Benjamin Gaignard wrote: > > 2017-06-20 19:31 GMT+02:00 Eric Anholt : > >> Archit Taneja writes: > >> > >>> On 06/16/2017 08:13 PM, Eric Anholt wrote: > Archit Taneja writes: > > > On 06/16/2

Re: [PATCH 1/7] drm/bridge: Support hotplugging panel-bridge.

2017-06-22 Thread Boris Brezillon
On Thu, 22 Jun 2017 14:29:07 +0200 Andrzej Hajda wrote: > On 22.06.2017 11:23, Boris Brezillon wrote: > > On Thu, 22 Jun 2017 13:47:43 +0530 > > Archit Taneja wrote: > > > >> On 06/22/2017 01:20 PM, Benjamin Gaignard wrote: > >>> 2017-06-20 19:31

Re: [PATCH v2] drm/vc4: Fix sleeps during the IRQ handler for DSI transactions.

2017-10-14 Thread Boris Brezillon
gt; > As a solution, use an interrupt thread so that all our writes happen > when sleeping is is allowed. > > v2: Use IRQF_ONESHOT (suggested by Boris) > > Signed-off-by: Eric Anholt Reviewed-by: Boris Brezillon > --- > > Boris, that cleanup ended up working an

Re: [PATCH v3 1/1] mtd: nand: pxa3xx: Set FORCE_CSX bit to ARMADA370 variants.

2017-10-14 Thread Boris Brezillon
Hi Kalyan, On Thu, 28 Sep 2017 13:57:56 +1300 Kalyan Kinthada wrote: > When the arbitration between NOR and NAND flash is enabled > the field bit[21] in the Data Flash Control Register > needs to be set to 1 according to guidleine GL-5830741 mentioned > in Marvell Errata document MV-S501377-00,

Re: pxa3xx-nand failing to find device on linux-next

2017-05-26 Thread Boris Brezillon
Le Thu, 25 May 2017 22:12:12 +, Chris Packham a écrit : > On 25/05/17 18:19, Boris Brezillon wrote: > > Le Wed, 24 May 2017 22:58:53 +, > > Chris Packham a écrit : > > > >> On 25/05/17 10:36, Boris Brezillon wrote: > >>> Le Wed, 24 May 2

Re: [PATCH -next] mtd: nand: Add support for Toshiba BENAND (Built-in ECC NAND)

2017-05-26 Thread Boris Brezillon
Hi KOBAYASHI, Le Fri, 26 May 2017 10:15:35 +0900, KOBAYASHI Yoshitake a écrit : > This patch enables support for Toshiba BENAND. It was originally posted on > https://lkml.org/lkml/2015/7/24/571 > > This patch is rewrote to adapt the recent mtd "separate vendor specific code > from core" clea

Re: mtd: nand: fsl_ifc: fix handing of bit flips in erased pages

2017-05-29 Thread Boris Brezillon
Hi, On Thu, 25 May 2017 23:33:43 + Darwin Dingel wrote: > Hi, > > We are also having the same problem where the IFC (nand flash) was > reporting ECC uncorrectable errors on single bitflips with erased pages. > Applying this patch with some minor modifications seems to solve our > issue.

<    1   2   3   4   5   6   7   8   9   10   >