Re: [PATCH v2 0/5] Add movablecore_map boot option

2012-11-27 Thread Bob Liu
Hi Tang, On Fri, Nov 23, 2012 at 6:44 PM, Tang Chen wrote: > [What we are doing] > This patchset provide a boot option for user to specify ZONE_MOVABLE memory > map for each node in the system. > > movablecore_map=nn[KMG]@ss[KMG] > > This option make sure memory range from ss to ss+nn is movable

Re: [PATCH v2 0/5] Add movablecore_map boot option

2012-11-27 Thread Bob Liu
On Tue, Nov 27, 2012 at 4:29 PM, Tang Chen wrote: > On 11/27/2012 04:00 PM, Bob Liu wrote: >> >> Hi Tang, >> >> On Fri, Nov 23, 2012 at 6:44 PM, Tang Chen >> wrote: >>> >>> [What we are doing] >>> This patchset provide a boot option

Re: [PATCH v2 0/5] Add movablecore_map boot option

2012-11-27 Thread Bob Liu
On Tue, Nov 27, 2012 at 8:49 PM, Tang Chen wrote: > On 11/27/2012 08:09 PM, Bob Liu wrote: >> >> On Tue, Nov 27, 2012 at 4:29 PM, Tang Chen >> wrote: >>> >>> Hi Liu, >>> >>> >>> This feature is used in memory hotplug. >>&g

Re: kernel BUG at mm/huge_memory.c:212!

2012-11-28 Thread Bob Liu
Hi Jiri, On Wed, Nov 28, 2012 at 5:18 AM, Jiri Slaby wrote: > Hi, > > I've hit BUG_ON(atomic_dec_and_test(&huge_zero_refcount)) in > put_huge_zero_page right now. There are some "Bad rss-counter state" > before that, but those are perhaps unrelated as I saw many of them in > the previous -next. B

Re: [PATCH v4 2/8] staging: zcache: zero-filled pages awareness

2013-03-20 Thread Bob Liu
> @@ -641,16 +691,22 @@ static void zcache_pampd_free(void *pampd, struct > tmem_pool *pool, > { > struct page *page = NULL; > unsigned int zsize, zpages; > + bool zero_filled = false; > > BUG_ON(preemptible()); > - if (pampd_is_remote(pampd)) { > + > + if (pampd

Re: [PATCH 02/15] mm: frontswap: lazy initialization to allow tmem backends to build/run as modules

2013-02-03 Thread Bob Liu
Stefan Hengelein >> Signed-off-by: Florian Schmaus >> Signed-off-by: Andor Daam >> Signed-off-by: Dan Magenheimer >> [v1: Fixes per Seth Jennings suggestions] >> [v2: Removed FRONTSWAP_HAS_.. ] >> [v3: Fix up per Bob

Re: [uclinux-dist-devel] [PATCH v2 2/9] blackfin: Provide dma_mmap_coherent() and dma_get_sgtable()

2013-01-28 Thread Bob Liu
On Sun, Jan 27, 2013 at 6:33 PM, Geert Uytterhoeven wrote: > blackfin/allmodconfig: > > drivers/media/v4l2-core/videobuf2-dma-contig.c: In function ‘vb2_dc_mmap’: > drivers/media/v4l2-core/videobuf2-dma-contig.c:204: error: implicit > declaration of function ‘dma_mmap_coherent’ > drivers/media/v4

Re: [PATCH v5 31/45] blackfin/smp: Use get/put_online_cpus_atomic() to prevent CPU offline

2013-01-28 Thread Bob Liu
ic() APIs to prevent CPUs from going offline, > while invoking from atomic context. > > Cc: Mike Frysinger > Cc: Bob Liu > Cc: Steven Miao > Cc: uclinux-dist-de...@blackfin.uclinux.org > Signed-off-by: Srivatsa S. Bhat Thanks, will be applied to my blackfin arch tree. &

[GIT PULL] Blackfin updates for 3.9

2013-02-21 Thread Bob Liu
f656c240ae07c48ddf8552e83b64692121044c42: blackfin: time-ts: Remove duplicate assignment (2013-02-20 15:21:23 +0800) Akinobu Mita (1): blackfin: use bitmap library functions Bob Liu (1): blackfin: mem_init: update dmc config register

Re: [PATCHv7 1/8] zsmalloc: add to mm/

2013-03-16 Thread Bob Liu
On 03/06/2013 11:52 PM, Seth Jennings wrote: > = > DO NOT MERGE, FOR REVIEW ONLY > This patch introduces zsmalloc as new code, however, it already > exists in drivers/staging. In order to build successfully, you > must select EITHER to driver/staging version OR this version. > Once zsmal

Re: [PATCH v3 2/5] zero-filled pages awareness

2013-03-16 Thread Bob Liu
On 03/15/2013 10:34 AM, Wanpeng Li wrote: > Compression of zero-filled pages can unneccessarily cause internal > fragmentation, and thus waste memory. This special case can be > optimized. > > This patch captures zero-filled pages, and marks their corresponding > zcache backing page entry as zero

[GIT PULL] Blackfin updates for 3.6-rc6

2012-09-10 Thread Bob Liu
Hi Linus, Please pull blackfin updates for 3.6-rc6, one kbuild and a smp build fix. Thanks, -Bob The following changes since commit 0d7614f09c1ebdbaa1599a5aba7593f147bf96ee: Linux 3.6-rc1 (2012-08-02 16:38:10 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linu

Re: Partialy mapped page stays in page cache after unmap

2012-10-31 Thread Bob Liu
On Wed, Oct 31, 2012 at 2:24 AM, wrote: > Hi! > I'm currently revisiting mmap related tests in LTP (Linux Test Project) > and I've came to the tests testing that writes to the partially > mapped page (at the end of mapping) are carried out correctly. > > These tests fails because even after the o

Re: [RFC v2] Support volatile range for anon vma

2012-11-01 Thread Bob Liu
On Tue, Oct 30, 2012 at 9:29 AM, Minchan Kim wrote: > This patch introudces new madvise behavior MADV_VOLATILE and > MADV_NOVOLATILE for anonymous pages. It's different with > John Stultz's version which considers only tmpfs while this patch > considers only anonymous pages so this cannot cover Jo

Re: [PATCH 2/5] mm: frontswap: lazy initialization to allow tmem backends to build/run as modules

2012-11-02 Thread Bob Liu
On Sat, Nov 3, 2012 at 2:27 AM, Konrad Rzeszutek Wilk wrote: > On Wed, Oct 31, 2012 at 12:05:32PM -0500, Seth Jennings wrote: >> On 10/31/2012 10:07 AM, Dan Magenheimer wrote: >> > With the goal of allowing tmem backends (zcache, ramster, Xen tmem) to be >> > built/loaded as modules rather than bu

Re: mm: NULL ptr deref in anon_vma_interval_tree_verify

2012-11-04 Thread Bob Liu
On Sat, Nov 3, 2012 at 11:51 AM, Sasha Levin wrote: > Ping? > > On Thu, Oct 25, 2012 at 4:26 PM, Sasha Levin wrote: >> On 10/18/2012 06:46 PM, Sasha Levin wrote: >>> Hi all, >>> >>> While fuzzing with trinity inside a KVM tools (lkvm) guest, on today's >>> linux-next kernel, >>> I saw the follow

Re: mm: NULL ptr deref in anon_vma_interval_tree_verify

2012-11-04 Thread Bob Liu
On Mon, Nov 5, 2012 at 11:31 AM, Michel Lespinasse wrote: > On Sun, Nov 4, 2012 at 6:20 PM, Bob Liu wrote: >> The loop for each entry of vma->anon_vma_chain in validate_mm() is not >> protected by anon_vma lock. >> I think that may be the cause. >> >> Michel,

[PATCH] drivers: net: irda: bfin_sir: fix compile error

2012-07-29 Thread Bob Liu
c:435:18: error: 'IREN' undeclared (first use in this function) drivers/net/irda/bfin_sir.c:521:11: error: 'IREN' undeclared (first use in this function) This patch fix it. Signed-off-by: Sonic Zhang Signed-off-by: Bob Liu --- drivers/net/irda/bfin_sir.c |8

Re: [PATCH 0/50] Basic scheduler support for automatic NUMA balancing V7

2013-09-13 Thread Bob Liu
Hi Mel, On 09/10/2013 05:31 PM, Mel Gorman wrote: > It has been a long time since V6 of this series and time for an update. Much > of this is now stabilised with the most important addition being the inclusion > of Peter and Rik's work on grouping tasks that share pages together. > > This series

Re: [PATCH v2 0/5] mm: migrate zbud pages

2013-09-17 Thread Bob Liu
Hi Krzysztof, On 09/11/2013 04:58 PM, Krzysztof Kozlowski wrote: > Hi, > > Currently zbud pages are not movable and they cannot be allocated from CMA > (Contiguous Memory Allocator) region. These patches add migration of zbud > pages. > I agree that the migration of zbud pages is important so

Re: [RFC PATCH RESEND] mm: munlock: Prevent walking off the end of a pagetable in no-pmd configuration

2013-09-17 Thread Bob Liu
art + PMD_SIZE) & PMD_MASK; + end = (pmd_end - 1 < end - 1) ? pmd_end : end; /* * Initialize pte walk starting at the already pinned page where we * are sure that there is a pte. */ pte = get_locked_pte(vma->vm_mm, start, &ptl); -

Re: [PATCH v2 1/4] mm/zswap: bugfix: memory leak when re-swapon

2013-09-05 Thread Bob Liu
On 09/06/2013 01:16 PM, Weijie Yang wrote: > zswap_tree is not freed when swapoff, and it got re-kmalloc in swapon, > so memory-leak occurs. > > Modify: free memory of zswap_tree in zswap_frontswap_invalidate_area(). > > Signed-off-by: Weijie Yang Reviewed-by: Bob Liu &

Re: [PATCH v2 3/4] mm/zswap: avoid unnecessary page scanning

2013-09-05 Thread Bob Liu
On 09/06/2013 01:16 PM, Weijie Yang wrote: > add SetPageReclaim before __swap_writepage so that page can be moved to the > tail of the inactive list, which can avoid unnecessary page scanning as this > page was reclaimed by swap subsystem before. > > Signed-off-by: Weijie Yang R

Re: [PATCH v2 2/4] mm/zswap: bugfix: memory leak when invalidate and reclaim occur concurrently

2013-09-05 Thread Bob Liu
t also by invalidate. > > Signed-off-by: Weijie Yang Reviewed-by: Bob Liu > --- > mm/zswap.c | 21 + > 1 file changed, 13 insertions(+), 8 deletions(-) > > diff --git a/mm/zswap.c b/mm/zswap.c > index cbd9578..1be7b90 100644 > --- a/mm/zswap.c &

Re: [PATCH v2 4/4] mm/zswap: use GFP_NOIO instead of GFP_KERNEL

2013-09-05 Thread Bob Liu
On 09/06/2013 01:16 PM, Weijie Yang wrote: > To avoid zswap store and reclaim functions called recursively, > use GFP_NOIO instead of GFP_KERNEL > The reason of using GFP_KERNEL in write back path is we want to try our best to move those pages from zswap to real swap device. I think it would be

Re: [RFC PATCH 1/4] zbud: use page ref counter for zbud pages

2013-09-08 Thread Bob Liu
f > additional reclaim paths. > > The page count is incremented when: > - a handle is created and passed to zswap (in zbud_alloc()), > - user-supplied eviction callback is called (in zbud_reclaim_page()). > > Signed-off-by: Krzysztof Kozlowski > Signed-off-by: Tomas

Re: [PATCH] frontswap: enable call to invalidate area on swapoff

2013-10-09 Thread Bob Liu
On 10/09/2013 04:08 AM, Andrew Morton wrote: > On Tue, 08 Oct 2013 10:13:20 +0200 Krzysztof Kozlowski > wrote: > >> On pon, 2013-10-07 at 15:03 -0700, Andrew Morton wrote: >>> On Mon, 07 Oct 2013 17:25:41 +0200 Krzysztof Kozlowski >>> wrote: >>> During swapoff the frontswap_map was NULL-

Re: [PATCH] frontswap: enable call to invalidate area on swapoff

2013-10-09 Thread Bob Liu
On 10/09/2013 10:40 PM, Seth Jennings wrote: > On Tue, Oct 08, 2013 at 01:08:53PM -0700, Andrew Morton wrote: >> On Tue, 08 Oct 2013 10:13:20 +0200 Krzysztof Kozlowski >> wrote: >> >>> On pon, 2013-10-07 at 15:03 -0700, Andrew Morton wrote: On Mon, 07 Oct 2013 17:25:41 +0200 Krzysztof Kozlo

[PATCH] x86: e820: fix memmap kernel boot parameter

2013-08-29 Thread Bob Liu
n't find the root cause, I think maybe grub reserved "$0" as something special. Replace '$' with '%' in kernel boot parameter can fix this issue. Signed-off-by: Bob Liu --- Documentation/kernel-parameters.txt |6 +++--- arch/x86/kernel/e820.c

Re: [PATCH] x86: e820: fix memmap kernel boot parameter

2013-08-29 Thread Bob Liu
On Fri, Aug 30, 2013 at 2:14 PM, Dan Aloni wrote: > On Fri, Aug 30, 2013 at 01:47:53PM +0800, Bob Liu wrote: >>[..] >> Machine2: bootcmdline in grub.cfg "memmap=0x77ff$0x88000", the >> result of >> "cat /proc/cmdline" changed to "memmap

Re: [munlock] BUG: Bad page map in process killall5 pte:cf17e720 pmd:05a22067

2013-09-25 Thread Bob Liu
3510+ > Revert "mm: munlock: manual pte walk in fast path instead of > follow_page_mask()" > git bisect bad 22356f447ceb8d97a4885792e7d9e4607f712e1b # 04:40 48- > mm: Place preemption point in do_mlockall() loop > git bisect bad 050f4da86e9bd

Re: [munlock] BUG: Bad page map in process killall5 pte:cf17e720 pmd:05a22067

2013-09-25 Thread Bob Liu
On Thu, Sep 26, 2013 at 9:59 AM, Fengguang Wu wrote: > Hi Bob, > > On Thu, Sep 26, 2013 at 09:48:08AM +0800, Bob Liu wrote: >> Hi Fengguang, >> >> Would you please have a try with the attached patch? >> It added a small fix based on Vlastimil's patch. >

Re: [munlock] BUG: Bad page map in process killall5 pte:cf17e720 pmd:05a22067

2013-09-25 Thread Bob Liu
On Thu, Sep 26, 2013 at 2:49 PM, Vlastimil Babka wrote: > On 09/26/2013 02:40 AM, Fengguang Wu wrote: >> Hi Vlastimil, >> >> FYI, this bug seems still not fixed in linux-next 20130925. > > Hi, > > I sent (including you) a RFC patch and later reviewed patch about week > ago. I assumed you would tes

Re: [BUG REPORT] ZSWAP: theoretical race condition issues

2013-09-26 Thread Bob Liu
; >>> > On Wed, Sep 25, 2013 at 05:33:43PM +0800, Weijie Yang wrote: >>> >> On Wed, Sep 25, 2013 at 4:31 PM, Bob Liu wrote: >>> >> > On Wed, Sep 25, 2013 at 4:09 PM, Weijie Yang >>> >> > wrote: >>> >> >> I think

Re: [PATCH v2 0/5] mm: migrate zbud pages

2013-09-27 Thread Bob Liu
On 09/28/2013 06:00 AM, Seth Jennings wrote: > On Fri, Sep 27, 2013 at 12:16:37PM +0200, Tomasz Stanislawski wrote: >> On 09/25/2013 11:57 PM, Seth Jennings wrote: >>> On Wed, Sep 25, 2013 at 07:09:50PM +0200, Tomasz Stanislawski wrote: > I just had an idea this afternoon to potentially kill

[PATCH] mm: pagevec: cleanup: drop pvec->cold argument in all places

2013-09-28 Thread Bob Liu
Nobody uses the pvec->cold argument of pagevec and it's also unreasonable for pages in pagevec released as cold page, so drop the cold argument from pagevec. Signed-off-by: Bob Liu --- fs/9p/cache.c |2 +- fs/afs/cache.c |2 +- fs/afs/write.c |4

Re: [PATCH v2 3/4] mm/zswap: avoid unnecessary page scanning

2013-09-22 Thread Bob Liu
On 09/10/2013 12:29 AM, Seth Jennings wrote: > On Fri, Sep 06, 2013 at 01:16:45PM +0800, Weijie Yang wrote: >> add SetPageReclaim before __swap_writepage so that page can be moved to the >> tail of the inactive list, which can avoid unnecessary page scanning as this >> page was reclaimed by swap s

Re: [PATCH v2 0/5] mm: migrate zbud pages

2013-09-24 Thread Bob Liu
On Tue, Sep 24, 2013 at 5:20 PM, Krzysztof Kozlowski wrote: > Hi, > > On pon, 2013-09-23 at 17:07 -0500, Seth Jennings wrote: >> On Tue, Sep 17, 2013 at 02:59:24PM +0800, Bob Liu wrote: >> > Mel mentioned several problems about zswap/zbud in thread "[PATCH v6 >

Re: [BUG REPORT] ZSWAP: theoretical race condition issues

2013-09-25 Thread Bob Liu
On Wed, Sep 25, 2013 at 4:09 PM, Weijie Yang wrote: > I think I find a new issue, for integrity of this mail thread, I reply > to this mail. > > It is a concurrence issue either, when duplicate store and reclaim > concurrentlly. > > zswap entry x with offset A is already stored in zswap backend. >

Re: [BUG REPORT] ZSWAP: theoretical race condition issues

2013-09-25 Thread Bob Liu
On Wed, Sep 25, 2013 at 5:33 PM, Weijie Yang wrote: > On Wed, Sep 25, 2013 at 4:31 PM, Bob Liu wrote: >> On Wed, Sep 25, 2013 at 4:09 PM, Weijie Yang >> wrote: >>> I think I find a new issue, for integrity of this mail thread, I reply >>> to this mail. >>

Re: [PATCH] kbuild: add symbol prefix arg to kallsyms

2012-09-07 Thread Bob Liu
Hi James, On Fri, Sep 7, 2012 at 5:11 AM, James Hogan wrote: > Commit 1f2bfbd00e466ff3489b2ca5cc75b1cccd14c123 ("kbuild: link of > vmlinux moved to a script") introduced in v3.5-rc1 broke kallsyms on > architectures which have symbol prefixes. > > The --symbol-prefix argument used to be added to

Re: BF561-EZKIT-SMP_defconfig build error in smp.c

2012-09-07 Thread Bob Liu
On Fri, Sep 7, 2012 at 4:03 PM, Fengguang Wu wrote: > Greetings, > > FYI, BF561-EZKIT-SMP_defconfig has this build error: > > kernel/built-in.o: In function `on_each_cpu mask': > kernel/smp.c:708: undefined reference to `smp_call_function_many' > We have fixed this issue in our internal tree but

[GIT PULL] Blackfin updates for 3.7-rc1

2012-10-08 Thread Bob Liu
6594b982f6d5f957c8d72de7658bf8e240c7dfca: Blackfin: smp: add smp_mb() to keep coherency (2012-10-08 14:36:30 +0800) Bob Liu (1): Blackfin: update defconfig for bf609-ezkit Harald Krapfenbauer (1): Blackfin: CM-BF537E: Update SPORT support in

Re: [uclinux-dist-devel] [GIT PULL] Disintegrate UAPI for blackfin [ver #2]

2012-10-09 Thread Bob Liu
On Tue, Oct 9, 2012 at 5:15 PM, David Howells wrote: > Can you merge the following branch into the blackfin tree please. > Merged into my git tree: git://git.kernel.org/pub/scm/linux/kernel/git/lliubbo/blackfin.git for-linus And what time i need to ask linus to pull? Next merge window? > This i

Re: [PATCH 2/2] thp: avoid race on multiple parallel page faults to the same page

2012-12-02 Thread Bob Liu
On Fri, Nov 30, 2012 at 11:03 PM, Kirill A. Shutemov wrote: > From: "Kirill A. Shutemov" > > pmd value is stable only with mm->page_table_lock taken. After taking > the lock we need to check that nobody modified the pmd before change it. > > Signed-off-by: Kirill

Re: [PATCH 1/2] thp: fix anononymous page accounting in fallback path for COW of HZP

2012-12-02 Thread Bob Liu
On Fri, Nov 30, 2012 at 11:03 PM, Kirill A. Shutemov wrote: > From: "Kirill A. Shutemov" > > Don't forget to account newly allocated page in fallback path for > copy-on-write of huge zero page. > What about fallback path in do_huge_pmd_wp_page_fallback()? I think we should also account newly all

[PATCH 3/4] thp: introduce hugepage_vma_check()

2012-10-18 Thread Bob Liu
Multi place do the same check. Signed-off-by: Bob Liu --- mm/huge_memory.c | 38 +- 1 file changed, 17 insertions(+), 21 deletions(-) diff --git a/mm/huge_memory.c b/mm/huge_memory.c index e575b29..3588fec 100644 --- a/mm/huge_memory.c +++ b/mm

[PATCH 1/4] thp: clean up __collapse_huge_page_isolate

2012-10-18 Thread Bob Liu
There are duplicated place using release_pte_pages(). And release_all_pte_pages() can also be removed. Signed-off-by: Bob Liu --- mm/huge_memory.c | 37 +++-- 1 file changed, 11 insertions(+), 26 deletions(-) diff --git a/mm/huge_memory.c b/mm/huge_memory.c

[PATCH 2/4] thp: introduce hugepage_get_pmd()

2012-10-18 Thread Bob Liu
Introduce hugepage_get_pmd() to simple code. Signed-off-by: Bob Liu --- mm/huge_memory.c | 68 ++ 1 file changed, 27 insertions(+), 41 deletions(-) diff --git a/mm/huge_memory.c b/mm/huge_memory.c index 462d6ea..e575b29 100644 --- a/mm

[PATCH 4/4] thp: cleanup: introduce mk_huge_pmd()

2012-10-18 Thread Bob Liu
Introduce mk_huge_pmd() to simple code Signed-off-by: Bob Liu --- mm/huge_memory.c | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/mm/huge_memory.c b/mm/huge_memory.c index 3588fec..9fd1312 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c

Re: [RFC PATCH 0/8] remove vm_struct list management

2012-12-06 Thread Bob Liu
Hi Joonsoo, On Fri, Dec 7, 2012 at 12:09 AM, Joonsoo Kim wrote: > This patchset remove vm_struct list management after initializing vmalloc. > Adding and removing an entry to vmlist is linear time complexity, so > it is inefficient. If we maintain this list, overall time complexity of > adding an

Re: [RFC PATCH 1/8] mm, vmalloc: change iterating a vmlist to find_vm_area()

2012-12-07 Thread Bob Liu
On Fri, Dec 7, 2012 at 3:44 PM, Pekka Enberg wrote: > On Thu, Dec 6, 2012 at 6:09 PM, Joonsoo Kim wrote: >> The purpose of iterating a vmlist is finding vm area with specific >> virtual address. find_vm_area() is provided for this purpose >> and more efficient, because it uses a rbtree. >> So cha

Re: [PATCH 0/2] kernel BUG at mm/huge_memory.c:212!

2012-12-11 Thread Bob Liu
On Mon, Dec 3, 2012 at 9:02 PM, Jiri Slaby wrote: > On 11/30/2012 04:03 PM, Kirill A. Shutemov wrote: >> From: "Kirill A. Shutemov" >> >> Hi Jiri, >> >> Sorry for late answer. It took time to reproduce and debug the issue. >> >> Could you test two patches below by thread. I expect it to fix both

Re: Regression due to "mm: fix-up zone present pages"

2012-11-14 Thread Bob Liu
On Wed, Nov 14, 2012 at 6:09 PM, Daniel Vetter wrote: > Hi all, > > Our QA noticed a regression in one of our i915/GEM testcases in 3.7: > > https://bugs.freedesktop.org/show_bug.cgi?id=56859 > > Direct link to dmesg of the machine: > https://bugs.freedesktop.org/attachment.cgi?id=70052 Note that

Re: [PATCH] mm: fix a regression with HIGHMEM introduced by changeset 7f1290f2f2a4d

2012-11-15 Thread Bob Liu
On Thu, Nov 15, 2012 at 5:22 PM, Wen Congyang wrote: > Hi, Liu Jiang > > At 11/14/2012 10:52 PM, Jiang Liu Wrote: >> On 11/07/2012 04:43 AM, Andrew Morton wrote: >>> On Tue, 6 Nov 2012 09:31:57 +0800 >>> Jiang Liu wrote: >>> Changeset 7f1290f2f2 tries to fix a issue when calculating zon

Re: mm: NULL ptr deref in anon_vma_interval_tree_verify

2012-11-07 Thread Bob Liu
Hi Michel, On Wed, Nov 7, 2012 at 11:54 AM, Michel Lespinasse wrote: > On Tue, Nov 6, 2012 at 12:24 AM, Michel Lespinasse wrote: >> On Mon, Nov 5, 2012 at 5:41 AM, Michel Lespinasse wrote: >>> On Sun, Nov 4, 2012 at 8:44 PM, Michel Lespinasse wrote: >>>> On Su

Re: [PATCH/TRIVIAL] blackfin: time-ts: Remove duplicate assignment

2012-12-20 Thread Bob Liu
On Wed, Dec 19, 2012 at 7:01 AM, Stephen Boyd wrote: > It seems that this assignment is done twice in a row. Remove the > duplicate assignment. > That's right. Will be applied, thanks. > Signed-off-by: Stephen Boyd > Cc: Steven Miao > Cc: triv...@kernel.org > --- > > Noticed while grepping for

Re: [PATCH 2/8] mm: frontswap: lazy initialization to allow tmem backends to build/run as modules

2012-11-18 Thread Bob Liu
On Sat, Nov 17, 2012 at 7:16 AM, Andrew Morton wrote: > On Wed, 14 Nov 2012 13:57:06 -0500 > Konrad Rzeszutek Wilk wrote: > >> From: Dan Magenheimer >> >> With the goal of allowing tmem backends (zcache, ramster, Xen tmem) to be >> built/loaded as modules rather than built-in and enabled by a bo

Re: [PATCHv13 0/4] zswap: compressed swap caching

2013-06-13 Thread Bob Liu
Hi Seth, On 06/04/2013 04:33 AM, Seth Jennings wrote: > This is the latest version of the zswap patchset for compressed swap caching. > This is submitted for merging into linux-next and inclusion in v3.11. > Have you noticed that pool_pages >> stored_pages, like this: [root@ca-dev32 zswap]# cat

Re: [PATCHv13 3/4] zswap: add to mm/

2013-06-16 Thread Bob Liu
Hi Seth, On Tue, Jun 4, 2013 at 4:33 AM, Seth Jennings wrote: > zswap is a thin backend for frontswap that takes pages that are in the process > of being swapped out and attempts to compress them and store them in a > RAM-based memory pool. This can result in a significant I/O reduction on the >

Re: [PATCHv13 2/4] zbud: add to mm/

2013-06-04 Thread Bob Liu
Hi Seth, On 06/04/2013 04:33 AM, Seth Jennings wrote: > zbud is an special purpose allocator for storing compressed pages. It is > designed to store up to two compressed pages per physical page. While this > design limits storage density, it has simple and deterministic reclaim > properties that

Re: [PATCHv13 3/4] zswap: add to mm/

2013-06-18 Thread Bob Liu
> > So the minor fault rate improved and everything else got worse? I did the test again, in a new clean environment. I'm sure the config files are the same except enabled zswap. v3.10-rc4 v3.10-rc4 2G-paralli

Re: [PATCHv13 3/4] zswap: add to mm/

2013-06-18 Thread Bob Liu
> > I'm not sure how representative this is of real workloads, but it does > look rather fatal for zswap. The differences are so large, I wonder if > it's just some silly bug or config issue. > In my observation, zswap_pool_pages always close to zswap_stored_pages in this testing. I think it mean

Re: [PATCHv13 3/4] zswap: add to mm/

2013-06-19 Thread Bob Liu
On Wed, Jun 19, 2013 at 10:09 PM, Seth Jennings wrote: > On Mon, Jun 17, 2013 at 02:20:05PM +0800, Bob Liu wrote: >> Hi Seth, >> >> On Tue, Jun 4, 2013 at 4:33 AM, Seth Jennings >> wrote: >> > zswap is a thin backend for frontswap that takes pages that ar

Re: [PATCHv13 3/4] zswap: add to mm/

2013-06-20 Thread Bob Liu
On Thu, Jun 20, 2013 at 10:37 AM, Seth Jennings wrote: > On Mon, Jun 17, 2013 at 02:20:05PM +0800, Bob Liu wrote: >> Hi Seth, >> >> On Tue, Jun 4, 2013 at 4:33 AM, Seth Jennings >> wrote: >> > zswap is a thin backend for frontswap that takes pages that ar

Re: [PATCHv13 3/4] zswap: add to mm/

2013-06-20 Thread Bob Liu
On Thu, Jun 20, 2013 at 10:23 PM, Seth Jennings wrote: > On Thu, Jun 20, 2013 at 05:42:04PM +0800, Bob Liu wrote: >> > Just made a mmtests run of my own and got very different results: >> > >> >> It's strange, I'll update to rc6 and try again. >>

Re: [PATCHv12 2/4] zbud: add to mm/

2013-05-30 Thread Bob Liu
Hi Seth, On 05/31/2013 05:20 AM, Seth Jennings wrote: > Andrew, Mel, > > This struct page stuffing is taking a lot of time to work out and _might_ be > fraught with peril when memmap peekers are considered. > > What do you think about just storing the zbud page metadata inline in the > memory pa

Re: [PATCH] xen/tmem: Don't over-write tmem_frontswap_poolid after tmem_frontswap_init set it.

2013-06-07 Thread Bob Liu
p_poolid=-1] >> >> Which meant that in the failing case we would not call the hypercall >> to initialize the pool and never be able to make any frontswap >> backend calls. >> >> Moving the frontswap_register_ops after setting the tmem_frontswap_poolid >> fi

Re: [PATCH v6 0/5] zram/zsmalloc promotion

2013-08-14 Thread Bob Liu
On Thu, Aug 15, 2013 at 12:17 AM, Minchan Kim wrote: > Hi Luigi, > > On Wed, Aug 14, 2013 at 08:53:31AM -0700, Luigi Semenzato wrote: >> During earlier discussions of zswap there was a plan to make it work >> with zsmalloc as an option instead of zbud. Does zbud work for > > AFAIR, it was not an o

Re: [PATCH v6 0/5] zram/zsmalloc promotion

2013-08-15 Thread Bob Liu
Hi Mel, On 08/16/2013 01:12 AM, Mel Gorman wrote: > On Thu, Aug 15, 2013 at 03:58:20AM +0900, Minchan Kim wrote: >>> >>> >>> I do not believe this is a problem for zram as such because I do not >>> think it ever writes back to disk and is immune from the unpredictable >>> performance characterist

Re: [PATCH v6 0/5] zram/zsmalloc promotion

2013-08-15 Thread Bob Liu
Hi Mel, On 08/16/2013 01:12 AM, Mel Gorman wrote: > On Thu, Aug 15, 2013 at 03:58:20AM +0900, Minchan Kim wrote: >>> >>> >>> I do not believe this is a problem for zram as such because I do not >>> think it ever writes back to disk and is immune from the unpredictable >>> performance characterist

Re: [PATCH v6 0/5] zram/zsmalloc promotion

2013-08-15 Thread Bob Liu
Hi Minchan, On Fri, Aug 16, 2013 at 12:26 PM, Minchan Kim wrote: > Hi Mel, > > On Thu, Aug 15, 2013 at 06:12:50PM +0100, Mel Gorman wrote: >> On Thu, Aug 15, 2013 at 03:58:20AM +0900, Minchan Kim wrote: >> > > >> > > >> > > I do not believe this is a problem for zram as such because I do not >>

Re: [PATCH v6 0/5] zram/zsmalloc promotion

2013-08-16 Thread Bob Liu
Hi Mel, On 08/16/2013 04:33 PM, Mel Gorman wrote: > > I already said I recognise it has a large number of users in the field > and users count a lot more than me complaining. If it gets promoted then > I expect it will be on those grounds. > > My position is that I think it's a bad idea because

Re: [PATCH v6 0/5] zram/zsmalloc promotion

2013-08-16 Thread Bob Liu
che although since Dan left I do not believe anyone is >> planning to try. > > I should mention that Bob Liu did some work with zcache recently but is > now looking like it'll be dropped from staging. I did not look at the > details and I have no idea if anything else is pla

[PATCH 0/4] mm: merge zram into zswap

2013-08-18 Thread Bob Liu
: Improve the writeback of zswap pool pages! Bob Liu (4): drivers: staging: drop zram and zsmalloc mm: promote zsmalloc to mm/ mm: zswap: add supporting for zsmalloc mm: zswap: create a pseudo device /dev/zram0 drivers/staging/Kconfig |4 - drivers/staging/Makefile

[PATCH 2/4] mm: promote zsmalloc to mm/

2013-08-18 Thread Bob Liu
in response to an allocation request. That handle must be mapped, using zs_map_object(), which returns a pointer to the mapped region that can be used. The mapping is necessary since the object data may reside in two different noncontigious pages. Signed-off-by: Bob Liu --- include/linux/zsma

[PATCH 4/4] mm: zswap: create a pseudo device /dev/zram0

2013-08-18 Thread Bob Liu
parameter zswap.max_pool_percent. disksize = (totalram_pages * zswap.max_pool_percent/100)*PAGE_SIZE. Signed-off-by: Bob Liu --- mm/Kconfig | 12 mm/zswap.c | 196 2 files changed, 208 insertions(+) diff --git a/mm/Kconfig b/mm/Kconfig ind

[PATCH 3/4] mm: zswap: add supporting for zsmalloc

2013-08-18 Thread Bob Liu
veral area, zsmalloc has unpredictable performance characteristics when reclaiming a single page, then CONFIG_ZBUD are suggested. Signed-off-by: Bob Liu --- include/linux/zsmalloc.h |1 + mm/Kconfig |4 +++ mm/zsmalloc.c|9 -- mm/zswap.c

Re: [BUG REPORT] ZSWAP: theoretical race condition issues

2013-08-18 Thread Bob Liu
Hi Weijie, On 08/19/2013 12:14 AM, Weijie Yang wrote: > I found a few bugs in zswap when I review Linux-3.11-rc5, and I have > also some questions about it, described as following: > > BUG: > 1. A race condition when reclaim a page > when a handle alloced from zbud, zbud considers this handle is

Re: [PATCH v6 0/5] zram/zsmalloc promotion

2013-08-18 Thread Bob Liu
Hi Minchan, On 08/19/2013 11:18 AM, Minchan Kim wrote: > Hello Mel, > > On Fri, Aug 16, 2013 at 09:33:47AM +0100, Mel Gorman wrote: >> On Fri, Aug 16, 2013 at 01:26:41PM +0900, Minchan Kim wrote: >> >> If it's used for something like tmpfs then it becomes much worse. Normal >> tmpfs

Re: [PATCH 0/4] mm: merge zram into zswap

2013-08-18 Thread Bob Liu
Hi Minchan, On 08/19/2013 12:10 PM, Minchan Kim wrote: > On Sun, Aug 18, 2013 at 04:40:45PM +0800, Bob Liu wrote: >> Both zswap and zram are used to compress anon pages in memory so as to reduce >> swap io operation. The main different is that zswap uses zbud as its >> al

Re: [PATCH v6 0/5] zram/zsmalloc promotion

2013-08-18 Thread Bob Liu
Hi Luigi, On 08/19/2013 01:29 PM, Luigi Semenzato wrote: > > We are gearing up to evaluate zswap, but we have only ported kernels > up to 3.8 to our hardware, so we may be missing important patches. > > In our experience, and with all due respect, the linux MM is a complex > beast, and it's diff

Re: [PATCH 3/4] mm: zswap: add supporting for zsmalloc

2013-08-19 Thread Bob Liu
On 08/20/2013 12:59 AM, Seth Jennings wrote: > On Sun, Aug 18, 2013 at 04:40:48PM +0800, Bob Liu wrote: >> Make zswap can use zsmalloc as its allocater. >> But note that zsmalloc don't reclaim any zswap pool pages mandatory, if zswap >> pool gets full, frontswap_st

Re: [PATCH 4/4] mm: zswap: create a pseudo device /dev/zram0

2013-08-19 Thread Bob Liu
On 08/20/2013 01:46 AM, Seth Jennings wrote: > On Sun, Aug 18, 2013 at 04:40:49PM +0800, Bob Liu wrote: >> This is used to replace previous zram. >> zram users can enable this feature, then a pseudo device will be created >> automaticlly after kernel boot. >> Just usin

Re: zswap: How to determine whether it is compressing swap pages?

2013-07-17 Thread Bob Liu
Hi Martin, On 07/17/2013 06:04 PM, Martin Steigerwald wrote: Hi Seth, hi everyone, Yesterday I build 3.11-rc1 with CONFIG_ZSWAP and wanted to test it. I added zswap.enabled=1 and get: martin@merkaba:~> dmesg | grep zswap [0.00] Command line: BOOT_IMAGE=/vmlinuz-3.11.0-rc1-tp520+ root=

Re: [PATCH v7 0/5] zram/zsmalloc promotion

2013-08-21 Thread Bob Liu
Hi Minchan, On 08/21/2013 02:16 PM, Minchan Kim wrote: > It's 7th trial of zram/zsmalloc promotion. > I rewrote cover-letter totally based on previous discussion. > > The main reason to prevent zram promotion was no review of > zsmalloc part while Jens, block maintainer, already acked > zram part

Re: [PATCH v7 0/5] zram/zsmalloc promotion

2013-08-21 Thread Bob Liu
On 08/21/2013 05:24 PM, Bob Liu wrote: > Hi Minchan, > > On 08/21/2013 02:16 PM, Minchan Kim wrote: >> It's 7th trial of zram/zsmalloc promotion. >> I rewrote cover-letter totally based on previous discussion. >> >> The main reason to prevent zram promotion w

Re: [PATCH v7 0/5] zram/zsmalloc promotion

2013-08-23 Thread Bob Liu
Hi Minchan, On Thu, Aug 22, 2013 at 8:42 AM, Minchan Kim wrote: > Hi Bob, > > On Wed, Aug 21, 2013 at 05:24:00PM +0800, Bob Liu wrote: >> Hi Minchan, >> >> On 08/21/2013 02:16 PM, Minchan Kim wrote: >> > It's 7th trial of zram/zsmalloc promotion. >

Re: [RFC PATCH 1/4] zbud: use page ref counter for zbud pages

2013-08-06 Thread Bob Liu
nislawski Looks good to me. Reviewed-by: Bob Liu > --- > mm/zbud.c | 150 > +++-- > 1 file changed, 86 insertions(+), 64 deletions(-) > > diff --git a/mm/zbud.c b/mm/zbud.c > index ad1e781..a8e986f 100644 >

Re: [RFC PATCH 0/4] mm: reclaim zbud pages on migration and compaction

2013-08-06 Thread Bob Liu
On 08/06/2013 02:42 PM, Krzysztof Kozlowski wrote: > Hi, > > Currently zbud pages are not movable and they cannot be allocated from CMA > region. These patches try to address the problem by: > 1. Adding a new form of reclaim of zbud pages. > 2. Reclaiming zbud pages during migration and compaction

Re: [PATCH] mm: zcache: zcache_cleancache_flush_fs fix

2013-08-06 Thread Bob Liu
Hi Piotr, On 08/06/2013 05:36 PM, Piotr Sarna wrote: > This patch fixes "mm: zcache: core functions added" patch, > available at https://lkml.org/lkml/2013/7/20/90. > It regards incorrect implementation of zcache_cleancache_flush_fs(). > > Function above should be effective only if cleancache poo

Re: [PATCH v2 0/4] zcache: a compressed file page cache

2013-08-09 Thread Bob Liu
other file memory hungry applications and it do no harm for other users! Looking forward any feedback! On Tue, Aug 6, 2013 at 7:36 PM, Bob Liu wrote: > Overview: > Zcache is a in kernel compressed cache for file pages. > It takes active file pages that are in the process of being recl

Re: zswap: How to determine whether it is compressing swap pages?

2013-07-18 Thread Bob Liu
Hi Martin, On 07/18/2013 03:38 AM, Martin Steigerwald wrote: > Am Mittwoch, 17. Juli 2013, 09:38:34 schrieb Seth Jennings: >> On Wed, Jul 17, 2013 at 01:41:44PM +0200, Martin Steigerwald wrote: >>> Is there any way to run zcache concurrently with zswap? I.e. use zcache only >>> for read caches for

Re: [PATCH] mm: zbud: fix condition check on allocation size

2013-07-18 Thread Bob Liu
On 07/17/2013 10:30 PM, Heesub Shin wrote: > zbud_alloc() incorrectly verifies the size of allocation limit. It > should deny the allocation request greater than (PAGE_SIZE - > ZHDR_SIZE_ALIGNED - CHUNK_SIZE), not (PAGE_SIZE - ZHDR_SIZE_ALIGNED) > which has no remaining spaces for its buddy. There

[PATCH 1/2] zcache: staging: %s/ZCACHE/ZCACHE_OLD

2013-07-20 Thread Bob Liu
Signed-off-by: Bob Liu --- drivers/staging/zcache/Kconfig | 12 ++-- drivers/staging/zcache/Makefile |4 ++-- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/zcache/Kconfig b/drivers/staging/zcache/Kconfig index 2d7b2da..f96fb12 100644 --- a/drivers

[PATCH 2/2] mm: zcache: core functions added

2013-07-20 Thread Bob Liu
age : 1% 1% 105% 94% 65% 6% 29% -3% 50% You can see that reading side performance get improved a lot after using zcache. Because pages are cached by zcache, we only need to decompress them instead of reading from disk. Signed-off-by: Bob Liu -

[PATCH 0/2] zcache: a new start for upstream

2013-07-20 Thread Bob Liu
cleancache backend at first, which is based on the zbud allocation same as zswap. At the end, I hope we can combine the new cleancache backend with zswap(frontswap backend), in order to have a generic in-kernel memory compression solution in upstream. Bob Liu (2): zcache: staging: %s/ZCACHE/ZCACH

Re: [PATCH] mm: zswap: add runtime enable/disable

2013-07-23 Thread Bob Liu
On 07/23/2013 03:34 AM, Seth Jennings wrote: > Right now, zswap can only be enabled at boot time. This patch > modifies zswap so that it can be dynamically enabled or disabled > at runtime. > > In order to allow this ability, zswap unconditionally registers as a > frontswap backend regardless of

Re: [PATCH 0/2] zcache: a new start for upstream

2013-07-24 Thread Bob Liu
Hi Seth, On Mon, Jul 22, 2013 at 11:07 PM, Seth Jennings wrote: > Sorry for the dup Bob, last reply only went to linux-mm > > On Sat, Jul 20, 2013 at 10:36:56PM +0800, Bob Liu wrote: >> We already have zswap helps reducing the swap out/in IO operations by >> compressing

Re: [PATCHv11 2/4] zbud: add to mm/

2013-05-14 Thread Bob Liu
Hi Seth, On 05/13/2013 08:40 PM, Seth Jennings wrote: > zbud is an special purpose allocator for storing compressed pages. It is > designed to store up to two compressed pages per physical page. While this > design limits storage density, it has simple and deterministic reclaim > properties that

  1   2   3   4   5   >