The call to free_netdev() in __rtl8139_cleanup_dev() clears the network device
napi list, and explicit calls to netif_napi_del() are unnecessary.
Signed-off-by: Bo Chen
---
drivers/net/ethernet/realtek/8139too.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/realtek
is patch fixes the bug by calling 'snd_device_free()' in the error handling
path of 'kzalloc()', which removes the new pcm instance from the snd card before
returns with an error code.
Signed-off-by: Bo Chen
---
sound/pci/hda/hda_controller.c | 4 +++-
1 file changed, 3 ins
This check on pci_get_drvdata() prevents potential invalid pointer dereferences,
and is a common practice in *_remove() functions from other drivers, such as
'intel/e100.c', 'amd/pcnet32.c', 'realtek/8139too.c', and 'broadcom/tg3.c'.
Signed-off-by: Bo Che
rong to assume 'dev_get_drvdata()' can return NULL and inject
faults from it. Do you have any suggestions about how I can avoid such
wrong assumptions?
Thanks again for your time and attention. I hope this patch is not
wasting too much effort from the netdev community. Any other comments
or
Make sure to invoke pci_disable_device() when errors occur in
pcnet32_probe_pci().
Signed-off-by: Bo Chen
---
drivers/net/ethernet/amd/pcnet32.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/amd/pcnet32.c
b/drivers/net/ethernet/amd/pcnet32
5 matches
Mail list logo