On Sun, Aug 19, 2012 at 6:09 PM, huang ying
wrote:
> Hi, Bjorn,
>
> Could you please merge this patchset? They fix real bugs.
I assume you wanted the updated "[PATCH 3/4] PCI/PM: Fix config reg
access ..." patch posted Aug 15.
I merged these (with the updated 3/4 patch) to my "for-linus" branc
On Mon, Aug 20, 2012 at 9:40 PM, Cui, Dexuan wrote:
> Bjorn Helgaas wrote on 2012-08-21:
>> I am still concerned about reset_intel_82599_sfp_virtfn(). It looks
>> wrong and possibly unnecessary. It looks wrong because it sets
>> PCI_EXP_DEVCTL_BCR_FLR and blindly cle
er bits when setting the
> NOSNOOP flag.
I think you're right. I propose the following patch on top of your
original one:
commit 300ef7967e87467656b0fe24270edba66bce45e4
Author: Bjorn Helgaas
Date: Wed Aug 22 10:29:42 2012 -0600
r8169: Preserve other Device Control bits when settin
On Wed, Aug 22, 2012 at 12:49 AM, Feng Tang wrote:
> Hi Fengguang,
>
>
> On Wed, 22 Aug 2012 10:50:08 +0800
> Fengguang Wu wrote:
>
>> Feng,
>>
>> > I think it's pci_get_subsys() triggered this assert:
>> >
>> > /*
>> > * Oi! Can't be having __GFP_FS allocations with IRQs disable
On Thu, Aug 23, 2012 at 9:03 AM, Jiang Liu wrote:
> Hi Bjorn,
> Could you please help to fold this small patch into
> "[5/40] PCI/core: Use PCI Express Capability accessors"?
> It fixes a bug reported by Fengguang.
Thanks, I folded it in. I looked briefly at whether a similar fix is
need
On Thu, Aug 23, 2012 at 12:28:23AM -0700, Olof Johansson wrote:
> Hi,
>
> On Mon, Jul 9, 2012 at 11:20 AM, Bjorn Helgaas wrote:
> > After 253d2e5498, we disable MEM and IO decoding for most devices while we
> > size 32-bit BARs. However, we restore the original COMMAND r
On Thu, Aug 23, 2012 at 10:36 AM, Matthew Garrett wrote:
> EFI provides support for providing PCI ROMs via means other than the ROM
> BAR. This support vanishes after we've exited boot services, so add support
> for stashing copies of the ROMs in setup_data if they're not otherwise
> available.
-
On Mon, Aug 20, 2012 at 9:26 AM, Jiang Liu wrote:
> Hi Bjorn,
> I have made following changes according to your suggestions,
> 1) get rid of the "pci_" prefix for access functions.
> 2) rename pci_pcie_capability_change_{word|dword}() to
> pcie_capability_clear_and_
On Sat, Sep 15, 2012 at 1:53 AM, Thierry Reding
wrote:
> On Sat, Sep 15, 2012 at 09:32:10AM +0200, Geert Uytterhoeven wrote:
>> On Fri, Sep 14, 2012 at 10:44 PM, Thierry Reding
>> wrote:
>> > --- a/drivers/pci/setup-irq.c
>> > +++ b/drivers/pci/setup-irq.c
>> > @@ -17,6 +17,14 @@
>> > #include
On Sat, Sep 15, 2012 at 1:53 AM, Thierry Reding
wrote:
> On Sat, Sep 15, 2012 at 09:32:10AM +0200, Geert Uytterhoeven wrote:
>> On Fri, Sep 14, 2012 at 10:44 PM, Thierry Reding
>> wrote:
>> > --- a/drivers/pci/setup-irq.c
>> > +++ b/drivers/pci/setup-irq.c
>> > @@ -17,6 +17,14 @@
>> > #include
On Tue, Aug 28, 2012 at 9:43 AM, Jiang Liu wrote:
> Following code has a race window between pci_find_bus() and pci_get_slot()
> if PCI hotplug operation happens between them which removes the pci_bus.
> So use PCI hotplug safe interface pci_get_domain_bus_and_slot() instead,
> which also reduces
+cc Eric and kexec list
On Mon, Sep 17, 2012 at 2:54 AM, Huang Ying wrote:
> If PCI devices are put into D3cold before kexec, because the
> configuration registers of PCI devices in D3cold are not accessible.
>
> And if PCI bridges are put into low power state before kexec,
> configuration regist
On Sun, Sep 16, 2012 at 10:39 AM, Stephan Schreiber wrote:
> [0.065516] pci :00:1f.1: [8086:24cb] type 0 class 0x000101
> [0.065530] pci :00:1f.1: reg 10: [io 0x-0x0007]
> [0.065541] pci :00:1f.1: reg 14: [io 0x-0x0003]
> [0.065552] pci :00:1f.1: reg 18:
On Mon, Sep 17, 2012 at 3:41 PM, Tejun Heo wrote:
> On Fri, Sep 14, 2012 at 12:13:21PM -0600, Bjorn Helgaas wrote:
>> On Thu, Aug 23, 2012 at 3:35 PM, Tejun Heo wrote:
>> > pci_call_probe() uses work_on_cpu(), which creates and tears down a
>> > full kthread on each c
On Sun, Sep 2, 2012 at 3:50 PM, Yinghai Lu wrote:
> So could use it with hot-added root bus.
>
> Signed-off-by: Yinghai Lu
> ---
> arch/x86/pci/i386.c | 58
> ---
> 1 files changed, 41 insertions(+), 17 deletions(-)
>
> diff --git a/arch/x86/pci
On Sun, Sep 2, 2012 at 3:50 PM, Yinghai Lu wrote:
> During testing remove/rescan root bus 00, found
> [ 338.142574] bus: 'pci': really_probe: probing driver ata_piix with device
> :00:01.1
> [ 338.146788] ata_piix :00:01.1: device not available (can't reserve [io
> 0x01f0-0x01f7])
> [
On Fri, Sep 14, 2012 at 3:11 PM, Thierry Reding
wrote:
> When using deferred driver probing, PCI host controller drivers may
> actually require this function after the init stage.
>
> Signed-off-by: Thierry Reding
> ---
> arch/arm/kernel/bios32.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 de
On Fri, Sep 14, 2012 at 3:11 PM, Thierry Reding
wrote:
> In order to allow drivers to specify private data for each controller,
> this commit adds a private_data field to the struct hw_pci. This field
> is an array of nr_controllers pointers that will be used to initialize
> the private_data field
On Tue, Sep 18, 2012 at 12:34 PM, Thierry Reding
wrote:
> On Tue, Sep 18, 2012 at 11:21:21AM -0600, Bjorn Helgaas wrote:
>> On Fri, Sep 14, 2012 at 3:11 PM, Thierry Reding
>> wrote:
>> > In order to allow drivers to specify private data for each controller,
>> >
On Fri, Sep 14, 2012 at 6:48 PM, Yinghai Lu wrote:
> when __ARCH_HAS_VGA_DEFAULT_DEVICE is not defined, aka EFIFB is not used,
>
> for static path, vga_default setting is through vga_arbiter_add_pci_device.
> and for x86 pci_fixup_video, will skip that.
> because subsys_initcall(vga_arb_device_ini
On Fri, Sep 14, 2012 at 6:48 PM, Yinghai Lu wrote:
> Found one system one root bus hot remove get panic.
> Panic happens when try to release hostbridge resource.
>
> It turns out that resource get reject during put into resource tree
> because of conflicts.
> Also that resource parent pointer have
On Fri, Sep 14, 2012 at 6:48 PM, Yinghai Lu wrote:
> Should use struct pci_bus_resource instead of struct pci_host_bridge_window
Looks good, and this is all my fault, sorry. Applied to a
pci/yinghai-misc branch.
> Signed-off-by: Yinghai Lu
>
> ---
> drivers/pci/bus.c |6 +-
> 1 file c
On Tue, Sep 18, 2012 at 5:49 PM, Yinghai Lu wrote:
> On Tue, Sep 18, 2012 at 3:46 PM, Bjorn Helgaas wrote:
>> On Fri, Sep 14, 2012 at 6:48 PM, Yinghai Lu wrote:
>>> Found one system one root bus hot remove get panic.
>>> Panic happens when try to release hostbridge
On Mon, Sep 17, 2012 at 5:34 AM, Greg Kroah-Hartman
wrote:
> On Mon, Sep 17, 2012 at 01:22:53PM +0200, Thierry Reding wrote:
>> Remove the __init annotations in order to keep pci_fixup_irqs() around
>> after init (e.g. for hotplug). This requires the same change for the
>> implementation of pcibio
On Thu, Sep 20, 2012 at 8:16 AM, Stephan Schreiber wrote:
> description of the symptoms which you have already read on the initial
> RFC/PATCH==>
>
>
> Kernel 3.2.23 with Debian patches (Debian Wheezy, testing)
> Debian bug#679545 (http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=679545)
>
> M
On Thu, Sep 20, 2012 at 11:28 AM, Thanasis wrote:
> I have an Acer Aspire One notebook, and it has a NIC as shown below:
>
> # lspci |grep -i Realtek
> 02:00.0 Ethernet controller: Realtek Semiconductor Co., Ltd.
> RTL8101E/RTL8102E PCI Express Fast Ethernet controller (rev 02)
>
> The driver modu
On Thu, Sep 20, 2012 at 12:10 PM, Thanasis wrote:
> on 09/20/2012 08:47 PM Bjorn Helgaas wrote the following:
>> On Thu, Sep 20, 2012 at 11:28 AM, Thanasis wrote:
>>> I have an Acer Aspire One notebook, and it has a NIC as shown below:
>>>
>>> # lspci |
On Thu, Sep 20, 2012 at 2:38 PM, Yinghai Lu wrote:
> On Tue, Aug 28, 2012 at 8:43 AM, Jiang Liu wrote:
>> Following code has a race window between pci_find_bus() and pci_get_slot()
>> if PCI hotplug operation happens between them which removes the pci_bus.
>> So use PCI hotplug safe interface pci
On Tue, Aug 7, 2012 at 2:50 PM, Don Dutile wrote:
> On 08/06/2012 04:47 PM, Bjorn Helgaas wrote:
>>
>> On Sun, Aug 5, 2012 at 11:55 PM, Alex Williamson
>> wrote:
>>>
>>> On Sun, 2012-08-05 at 23:30 -0600, Bjorn Helgaas wrote:
>>>>
&g
On Wed, Aug 8, 2012 at 8:44 AM, Jiang Liu wrote:
> On 08/08/2012 07:38 AM, Toshi Kani wrote:
>> It is nice to see redundant ACPI namespace walks removed from the ACPI
>> drivers. But why do you need to add a new enumerator to create the
>> acpihp_slot tree, in addition to the current acpi_device
If you can collect complete dmesg logs from the working kernel and the
broken kernel and post them, the differences might have a clue. You
might also collect /proc/iomem and "lspci -vv" for both cases while
you're at it.
On Wed, Aug 8, 2012 at 10:38 PM, Alexei Kornienko
wrote:
> Hi,
>
> Yes it u
print_fn_descriptor_symbol() prints the address if we don't have a symbol,
so no need to print both.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Pleas
print_fn_descriptor_symbol() prints the address if we don't have a symbol,
so no need to print both.
Signed-off-by: Bjorn Helgaas <[EMAIL PROTECTED]>
Index: work6/drivers/pnp/quirks.c
===
--- work6.orig/drivers/pnp/quirks
print_fn_descriptor_symbol() prints the address if we don't have a symbol,
so no need to print both.
Signed-off-by: Bjorn Helgaas <[EMAIL PROTECTED]>
Index: work6/drivers/pci/quirks.c
===
--- work6.orig/drivers/pci/quirks
tcall pci_mmcfg_late_insert_resources+0x0/0x50() returned 1 after 0 msecs
initcall pci_mmcfg_late_insert_resources+0x0/0x50() returned with error code 1
Signed-off-by: Bjorn Helgaas <[EMAIL PROTECTED]>
Index: work6/init/main.c
===
--- work
not a real problem since the tests
> are also the first things done inside the blocks they protect -- if
> pnp_dev->protocol isn't set here, we're dead anyway therefore.
>
> That probably means we can just delete the pnp_dev->protocol tests but this
> would need a
On Wednesday 20 February 2008 10:47:21 pm Rene Herman wrote:
> On 20-02-08 17:59, Bjorn Helgaas wrote:
> > I agree with you that we can just delete the dev->protocol tests
> > completely. So I'd rather see something like this (built but untested):
> >
> >
> &
Every PNP device should have a valid protocol pointer. If it doesn't,
something's wrong and we should oops so we can find and fix the problem.
[This fixes a Coverity warning, but does not need to be in 2.6.25.
I'd rather have it in -mm for a while and put it in 2.6.26.]
Signe
On Wed, Aug 1, 2012 at 8:54 AM, Jiang Liu wrote:
> From: Jiang Liu
>
> As suggested by Bjorn Helgaas and Don Dutile in threads
> http://www.spinics.net/lists/linux-pci/msg15663.html, we could improve access
> to PCIe capabilities register in to way:
> 1) cache content of
On Mon, Jun 4, 2012 at 1:44 AM, Jiang Liu wrote:
> Commit 0d52f54e2ef64c189dedc332e680b2eb4a34590a (PCI / ACPI: Make acpiphp
> ignore root bridges using PCIe native hotplug) added code that made the
> acpiphp driver completely ignore PCIe root complexes for which the kernel
> had been granted cont
On Sun, Aug 12, 2012 at 3:26 PM, Rafael J. Wysocki wrote:
>
> Commit dbf0e4c (PCI: EHCI: fix crash during suspend on ASUS
> computers) added a workaround for an ASUS suspend issue related to
> USB EHCI and a bug in a number of ASUS BIOSes that attemt to shut
> down the EHCI controller during syste
On Sat, Aug 4, 2012 at 3:27 PM, Rafael J. Wysocki wrote:
>
> If a PCI device is put into D3_cold by acpi_bus_set_power(),
> the message printed by acpi_pci_set_power_state() says that its
> power state has been changed to D4, which doesn't make sense.
> In turn, if the device is put into D3_hot, t
On Thu, May 24, 2012 at 2:45 PM, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki
>
> We want to report that the kernel supports ASPM to the BIOS even if
> the BIOS signals us that it doesn't. So, we need the flags to include
> (OSC_ACTIVE_STATE_PWR_SUPPORT | OSC_CLOCK_PWR_CAPABILITY_SUPPORT)
On Fri, May 25, 2012 at 1:23 AM, Jiang Liu wrote:
> There are some resources associated with PCI host bridges on
> IA 64 platforms, they should be released when removing host
> bridges. Otherwise it will cause memory leak and other strange
> behavior.
>
> For example, PCI IO port address space are
On Sun, Jun 3, 2012 at 11:16 PM, Jiang Liu wrote:
> From: Jiang Liu
>
> According to device model documentation, the way to add/remove device
> object should be symmetric.
I think this 6-patch series has been folded into your "[RFC PATCH v1
00/22] introduce PCI bus lock to serialize PCI hotplug
On Thu, Aug 16, 2012 at 8:49 AM, Alexander Gordeev wrote:
> The new function pci_enable_msi_block_auto() tries to allocate maximum
> possible number of MSIs up to the number the device supports. It
> generalizes a pattern when pci_enable_msi_block() contiguously called
> until it succeeds or fails
On Tuesday 05 February 2008 11:15:12 am Linus Torvalds wrote:
>
> On Tue, 5 Feb 2008, Bjorn Helgaas wrote:
> > >
> > > - PnP/ACPI resource allocation *after* it, but before driver loading
> > >(which wll cause new resources to be allocated). This could be
On Tuesday 05 February 2008 04:12:09 pm Len Brown wrote:
> is there
> a version of cat that prints the file name before
> the contents of each file?
I use "grep . *" for this sort of thing.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAI
Dynamic resource management
- Track bus number allocation (struct resource tree per domain) (Yinghai Lu)
- Make P2P bridge 1K I/O windows work with resource reassignment (Bjorn
Helgaas, Yinghai Lu)
- Disable decoding while updating 64-bit BARs (Bjorn Helgaas)
Power management
s commit b918c62e for all other architectures.
>
> Signed-off-by: Chris Metcalf
Acked-by: Bjorn Helgaas
You pushed the other tile changes, so I assume you'll do the same with
this one. But let me know if you want me to push it to Linus.
> ---
> arch/tile/kernel/pci_gx.c |2
On Fri, Aug 17, 2012 at 2:19 AM, Alexander Gordeev wrote:
> On Thu, Aug 16, 2012 at 10:00:39AM -0600, Bjorn Helgaas wrote:
>> On Thu, Aug 16, 2012 at 8:49 AM, Alexander Gordeev
>> wrote:
>> > -4.2.3 pci_disable_msi
>> > +4.2.3 pci_enable_msi_block_auto
>>
On Mon, Aug 20, 2012 at 9:26 AM, Jiang Liu wrote:
> On 08/14/2012 12:25 PM, Bjorn Helgaas wrote:
>> On Wed, Aug 1, 2012 at 8:54 AM, Jiang Liu wrote:
>>> From: Jiang Liu
>>>
>>> As suggested by Bjorn Helgaas and Don Dutile in threads
>>> http://www.
On Mon, Aug 20, 2012 at 9:47 AM, Jiang Liu wrote:
> On 08/20/2012 11:35 PM, Bjorn Helgaas wrote:
>> On Mon, Aug 20, 2012 at 9:26 AM, Jiang Liu wrote:
>>> On 08/14/2012 12:25 PM, Bjorn Helgaas wrote:
>>>> On Wed, Aug 1, 2012 at 8:54 AM, Jiang Liu wrote:
>>
On Mon, Aug 20, 2012 at 10:10 AM, Bjorn Helgaas wrote:
> So I'll try pulling your branch (I'll do something about the tsi721.c
> stuff myself).
I pulled this into
git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git
pci/jiang-pcie-cap with the following changes:
- Dr
rnate path. The
other fixes D3/D3cold/D4 messages related to the D3cold support we
merged in v3.6-rc1.
We'd like both to be included in v3.6.
--------
Bjorn Helgaas (1):
Merge branch 'pci/rafael-3.6-fixes' into for-li
On Mon, Jul 9, 2012 at 4:05 AM, Jiang Liu wrote:
> Hi Bjorn and Yinghai,
> What's the policy to export a symbol by EXPORT_SYMBOL()
> or EXPORT_SYMBOL_GPL()? I know the legal difference, but don't
> know when I should mark a symbol as GPL.
>From Documentation/DocBook/kernel-hacking.tmpl,
> looks like they do not bios update for S10 yet.
>
> http://www.panasonic.com/business/toughbook/computer-support-bios.asp#CF-U1
>
> maybe you can try to email or call their support.
Please stop suggesting a BIOS upgrade. The BIOS is totally out of our
control, and if the current BIOS works with
ire two writes and
the half-written state is a potential problem.
I'm considering these changes for the 3.6 merge window, which is
approaching fast, so let me know if you see issues with either of these.
---
Bjorn Helgaas (2):
PCI: leave MEM and IO decoding disabled during 64-bit BAR si
27;re
completely finished sizing the BAR.
Reference: https://lkml.org/lkml/2007/8/25/154
Signed-off-by: Bjorn Helgaas
---
drivers/pci/probe.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c
index 658ac97..66b3a6f 100644
, disable MEM decoding while updating such BARs. This uses
the same safety test as 253d2e5498, which disables both MEM and IO while
sizing BARs, namely, we don't disable decoding for host bridge devices.
Signed-off-by: Bjorn Helgaas
---
drivers/pci/setup-res.c | 18 ++
1
reassignment of the window after
FINAL quirks. Fix that.
And also replace the sparc pci_cfg_fake_ranges() with the functionally
equivalent generic version.
---
Bjorn Helgaas (3):
PCI: allow P2P bridge windows starting at PCI bus address zero
PCI: reimplement P2P bridge 1K I/O windows (Intel
f]
pci :01:00.0: reg 10: [mem 0x1-0x100ff]
CC: Yinghai Lu
Signed-off-by: Bjorn Helgaas
---
drivers/pci/probe.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c
index 658ac97..9c5d2a9 100644
--- a/drivers/p
24d051 and
is no longer necessary (it probably was just cloned from x86 and was never
useful on sparc).
CC: "David S. Miller"
CC: sparcli...@vger.kernel.org
Signed-off-by: Bjorn Helgaas
---
arch/sparc/kernel/pci.c | 89 +--
1 files changed, 1 i
gnment code, e.g., pbus_size_io(), should
pay attention to dev->io_window_1k, too, but I didn't fix that.
Signed-off-by: Bjorn Helgaas
---
drivers/pci/probe.c | 25 ++---
drivers/pci/quirks.c | 39 +--
drivers
Hi Geert,
There are some PCI-related regressions here that I'd like to fix, but
I don't know where to start. For example, these:
> + drivers/pci/quirks.c: error: implicit declaration of function 'ioread32'
> [-Werror=implicit-function-declaration]: => 3154:2
> + drivers/pci/quirks.c: error
On Mon, Jul 9, 2012 at 3:43 PM, Yinghai Lu wrote:
> On Mon, Jul 9, 2012 at 1:32 PM, Bjorn Helgaas wrote:
>>
>> Note that the bridge window assignment code, e.g., pbus_size_io(), should
>> pay attention to dev->io_window_1k, too, but I didn't fix that.
>
> Pl
On Mon, Jul 9, 2012 at 3:31 PM, Geert Uytterhoeven wrote:
> Hi Bjorn (or Björn?),
>
> On Mon, Jul 9, 2012 at 11:20 PM, Bjorn Helgaas wrote:
>> There are some PCI-related regressions here that I'd like to fix, but
>> I don't know where to start. For example
On Mon, Jul 9, 2012 at 3:35 PM, Myron Stowe wrote:
> PCI's final quirks (pci_fixup_final) are currently invoked by
> pci_apply_final_quirk() which traverses the platform's list of PCI
> devices. The calling mechanism, and to some point the use of the device
> list, limits the quirk invocations to
On Mon, Jul 9, 2012 at 12:20 PM, Bjorn Helgaas wrote:
> Since 2.6.36 (253d2e5498), we've disabled MEM & IO decoding while we size
> BARs (except for host bridge devices). These patches tweak this in two
> ways:
>
> 1) We only kept decoding disabled while sizing the low
On Mon, Jul 9, 2012 at 2:31 PM, Bjorn Helgaas wrote:
> Two fixes here:
>
> 1) Zero is a legal P2P bridge window base and BAR value and is likely to
> occur when there is an offset between bus addresses and CPU addresses.
> Stop disallowing it.
>
> 2) The Intel-specific 1K I
On Mon, Jul 9, 2012 at 9:24 PM, Bjorn Helgaas wrote:
> On Mon, Jul 9, 2012 at 2:31 PM, Bjorn Helgaas wrote:
>> Two fixes here:
>>
>> 1) Zero is a legal P2P bridge window base and BAR value and is likely to
>> occur when there is an offset between bus addresses
On Tue, Jul 10, 2012 at 9:54 AM, Jiang Liu wrote:
> From: Jiang Liu
>
> Introduce four configuration access functions for PCIe capabilities to
> hide difference among PCIe Base Spec versions. With these functions,
> we can remove callers responsible for using pci_pcie_cap_has_*().
>
> pci_pcie_ca
On Tue, Jul 10, 2012 at 9:54 AM, Jiang Liu wrote:
> From: Jiang Liu
>
> Use PCIe cap access functions to simplify PCI core implementation.
>
> Signed-off-by: Jiang Liu
> ---
> drivers/pci/pci.c| 237
> ++
> drivers/pci/probe.c | 19 ++--
>
On Tue, Jul 10, 2012 at 9:54 AM, Jiang Liu wrote:
> From: Jiang Liu
>
> Use PCIe cap access functions to simplify pcihp_slot.c
>
> Signed-off-by: Jiang Liu
> ---
> drivers/pci/hotplug/pcihp_slot.c | 17 +
> 1 file changed, 9 insertions(+), 8 deletions(-)
>
> diff --git a/drive
On Tue, Jul 10, 2012 at 9:54 AM, Jiang Liu wrote:
> From: Jiang Liu
>
> As suggested by Bjorn Helgaas and Don Dutile in threads
> http://www.spinics.net/lists/linux-pci/msg15663.html, we could improve access
> to PCIe capabilities register in to way:
> 1) cache content of
On Tue, Jul 10, 2012 at 9:54 AM, Jiang Liu wrote:
> From: Jiang Liu
>
> Move pcie_cap_has_*() macros to include/linux/pci.h, so they can be shared.
> Since pcie_flags was introduced, rework these macros to take a struct pci_dev
> *
> and use pcie_flags insead of type and flags.
>
> Signed-off-by
On Tue, Jul 10, 2012 at 9:07 PM, Jiang Liu wrote:
> On 2012-7-11 2:35, Bjorn Helgaas wrote:
>>> diff --git a/drivers/pci/access.c b/drivers/pci/access.c
>>> index ba91a7e..80ae022 100644
>>> --- a/drivers/pci/access.c
>>> +++ b/drivers/pci
On Wed, Jul 11, 2012 at 12:40 AM, Jiang Liu wrote:
> On 2012-7-11 11:40, Bjorn Helgaas wrote:
>
>>> Good point. Return success when reading unimplemented registeres, that
>>> may simplify code. For we still should return -EINVAL when writing
>>> unimplemented regi
On Mon, Jun 25, 2012 at 2:54 PM, Nikhil P Rao wrote:
> On Sat, 2012-06-23 at 12:15 -0600, Bjorn Helgaas wrote:
>> On Thu, Jun 21, 2012 at 5:47 PM, Nikhil P Rao wrote:
>> > I ran into the "disabling BAR .." error message when
>> > trying to use a 8Gb PCIe c
On Wed, Jun 20, 2012 at 1:56 PM, Nikhil P Rao wrote:
> size parameter of _pci_assign_resource() needs to be
> of type resource_size_t rather than int
>
> Signed-off-by: Nikhil P Rao
> ---
> drivers/pci/setup-res.c |3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/dr
On Thu, Jul 12, 2012 at 11:27 AM, Octavian Purdila
wrote:
> When the requested range is outside of the root range the logic in
> __reserve_region_with_split will cause an infinite recursion which
> will overflow the stack as seen in the warning bellow.
I think reserve_region_with_split() is a dub
On Wed, Jul 11, 2012 at 6:13 PM, Yinghai Lu wrote:
> On Wed, Jul 11, 2012 at 3:53 PM, Bjorn Helgaas wrote:
>> On Mon, Jun 25, 2012 at 2:54 PM, Nikhil P Rao wrote:
>>> On Sat, 2012-06-23 at 12:15 -0600, Bjorn Helgaas wrote:
>>>> On Thu, Jun 21, 2012 at 5:47 PM, Nik
On Wed, Jul 11, 2012 at 8:56 PM, Jiang Liu wrote:
> On 2012-7-12 1:52, Bjorn Helgaas wrote:
>>> Hi Bjorn,
>>> Seems it would be better to return error code for unimplemented
>>> registers, otherwise following code will becomes more complex. A special
&g
pci_dev_put()
PCI: remove depends on CONFIG_EXPERIMENTAL
Betty Dall (1):
PCI/AER: pci_get_domain_bus_and_slot() call missing required pci_dev_put()
Bjorn Helgaas (4):
PCI: shpchp: Make shpchp_wq non-ordered
PCI
[+cc linux-pci, Rafael, Alan]
[https://bugzilla.kernel.org/show_bug.cgi?id=53551]
On Tue, Feb 12, 2013 at 1:13 PM, Artem S. Tashkinov wrote:
> Feb 13, 2013 01:32:53 AM, Linus Torvalds wrote:
> On Tue, Feb 12, 2013 at 10:29 AM, Artem S. Tashkinov wrote:
>>> Feb 12, 2013 11:30:20 PM, Linus Torvald
On Wed, Feb 13, 2013 at 7:32 AM, Daniel J Blueman wrote:
> On 12 February 2013 03:49, Rafael J. Wysocki wrote:
>> On Monday, February 11, 2013 08:27:49 PM Rafael J. Wysocki wrote:
>>> On Monday, February 11, 2013 12:01:37 PM Bjorn Helgaas wrote:
>>> > [+cc Rafa
On Thu, Feb 14, 2013 at 7:39 AM, Borislav Petkov wrote:
> On Sun, Feb 03, 2013 at 03:46:56PM +0100, Borislav Petkov wrote:
>> On Sun, Feb 03, 2013 at 12:04:46AM +0100, Rafael J. Wysocki wrote:
>> > The [2/5] is at: https://patchwork.kernel.org/patch/2001211/
>> >
>> > The other two are attached.
Hi Linus,
This is another fix for v3.8. It fixes an oops that happens when a
Thunderbolt adapter is unplugged (remove device, poll for PME events on
no-longer-existing device, oops).
Bjorn
The following changes since commit 444ee9bd3d0fa78317c6127c961af5accf50038b:
PCI: remove depends on CO
On Thu, Feb 14, 2013 at 11:37 AM, Alex Williamson
wrote:
> A bus reset can trigger a presence detection change and result in a
> suprise hotplug. This is generally not what we want to happen when
> trying to reset a device. Disable the presence detection control on
> on bridges around bus reset.
On Thu, Feb 14, 2013 at 11:35 AM, Alex Williamson
wrote:
> PCI_EXP_FLAGS_TYPE is a mask, not an offset. Fix it.
>
> Signed-off-by: Alex Williamson
I applied this to pci/misc so it will appear in v3.9 and marked it for
stable for v3.7+.
Thanks!
> ---
> drivers/pci/access.c |2 +-
> 1 file
ble a PCI
>>> device's IRQ, we should search up the PCI device tree looking for a
>>> _PRT associated with each node, and applying normal PCI bridge
>>> swizzling when we don't find a _PRT. I think this can be done without
>>> using PCI bus numbers at
On Wed, Feb 13, 2013 at 5:59 AM, Rafael J. Wysocki wrote:
> On Tuesday, February 12, 2013 05:54:08 PM Yinghai Lu wrote:
>> On Tue, Feb 12, 2013 at 4:16 PM, Rafael J. Wysocki wrote:
>> > From: Rafael J. Wysocki
>> >
>> > After commit 1aeae82 (ACPI / PCI: avoid building pci_slot as module)
>> > th
On Thu, Jan 10, 2013 at 6:12 AM, Rafael J. Wysocki wrote:
> Hi,
>
> On Thursday, January 10, 2013 11:28:36 AM Stephen Rothwell wrote:
>> Hi Rafael,
>>
>> Today's linux-next merge of the pm tree got a conflict in
>> drivers/acpi/pci_root.c between commit 3c449ed00759 ("PCI/ACPI: Reserve
>> firmware
On Thu, Jan 10, 2013 at 4:59 PM, Rafael J. Wysocki wrote:
> On Thursday, January 10, 2013 03:40:45 PM Yinghai Lu wrote:
>> On Thu, Jan 10, 2013 at 3:39 PM, Rafael J. Wysocki wrote:
>> > On Thursday, January 10, 2013 03:03:53 PM Yinghai Lu wrote:
>> >> On Thu, Jan 10, 2013 at 1:50 PM, Rafael J. Wy
ngelogs.
I propose to push the entire series for inclusion in v3.8, since it
fixes an easy-to-cause deadlock with Thunderbolt adapters.
---
Bjorn Helgaas (3):
PCI: shpchp: Make shpchp_wq non-ordered
PCI: shpchp: Handle push button event asynchronously
PCI: shpchp: Use per-slot
;pciehp:
update workqueue usage").
Signed-off-by: Bjorn Helgaas
CC: Tejun Heo
---
drivers/pci/hotplug/shpchp_core.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/pci/hotplug/shpchp_core.c
b/drivers/pci/hotplug/shpchp_core.c
index b6de307..59ca86c 100644
--- a
code inspection, since we don't have hardware
with this topology.
Based-on-patch-by: Yijing Wang
Signed-off-by: Bjorn Helgaas
CC: sta...@vger.kernel.org
---
drivers/pci/hotplug/shpchp.h |2 +-
drivers/pci/hotplug/shpchp_core.c | 26 ++
drivers/pci/hotplug/
eviewed-by: Kenji Kaneshige
Signed-off-by: Yijing Wang
Signed-off-by: Bjorn Helgaas
CC: sta...@vger.kernel.org
---
drivers/pci/hotplug/pciehp.h |2 +-
drivers/pci/hotplug/pciehp_core.c | 11 ++-
drivers/pci/hotplug/pciehp_ctrl.c |8
drivers/pci/hotplug/pciehp_hpc
ously") made
the same change to pciehp. I split this out from a patch by Yijing Wang
so we fix one thing at a time and to make the
shpchp history correspond more closely with the pciehp history.
Signed-off-by: Bjorn Helgaas
CC: Kenji Kaneshige
---
drivers/pci/hotplug/shpchp.h |1
On Mon, Jan 14, 2013 at 10:53 AM, Cong Ding wrote:
> we should ensure the pointer is not null before the first use, rather than
> after it.
These changes look technically correct, but the whole pcibr_reg.c file
is ridiculously defensive programming.
For example, the first two hunks are for pcire
701 - 800 of 6731 matches
Mail list logo
