Re: [PATCH v5 4/9] pci: Add slot reset option to pci_dev_reset

2013-08-14 Thread Bjorn Helgaas
On Thu, Aug 8, 2013 at 2:09 PM, Alex Williamson wrote: > If the hotplug controller provides a way to reset a slot, use that > before a direct parent bus reset. Like the bus reset option, this is > only available when a single pci_dev occupies the slot. > > Signed-off-by: Alex Williamson > --- >

Re: [PATCH v5 6/9] pci: Add slot and bus reset interfaces

2013-08-14 Thread Bjorn Helgaas
On Thu, Aug 8, 2013 at 2:09 PM, Alex Williamson wrote: > Sometimes pci_reset_function is not sufficient. We have cases where > devices do not support any kind of reset, but there might be multiple > functions on the bus preventing pci_reset_function from doing a > secondary bus reset. We also ha

Re: [PATCH] vfio-pci: PCI hot reset interface

2013-08-14 Thread Bjorn Helgaas
[+cc Al, linux-fsdevel for fdget/fdput usage] On Wed, Aug 14, 2013 at 2:10 PM, Alex Williamson wrote: > The current VFIO_DEVICE_RESET interface only maps to PCI use cases > where we can isolate the reset to the individual PCI function. This > means the device must support FLR (PCIe or AF), PM re

Re: [PATCH v5 0/9] pci: bus and slot reset interfaces

2013-08-15 Thread Bjorn Helgaas
On Thu, Aug 8, 2013 at 2:09 PM, Alex Williamson wrote: > v5: Increase length of time we assert reset in the final common > secondary bus reset function to 2ms and document that this is > to ensure that reset on the bus is seen for at least a full > 1ms (per converstation with Alex Duyc

Re: [PATCH] pci: Add probe functions for bus and slot reset

2013-08-15 Thread Bjorn Helgaas
On Wed, Aug 14, 2013 at 2:06 PM, Alex Williamson wrote: > Users of pci_reset_bus() and pci_reset_slot() need a way to probe > whether the bus or slot supports reset. Add trivial helper functions > and export them as vfio-pci will make use of these. > > Signed-off-by: Alex Williamson Merged to t

Re: [PATCH] vfio-pci: PCI hot reset interface

2013-08-19 Thread Bjorn Helgaas
On Mon, Aug 19, 2013 at 12:41 PM, Alex Williamson wrote: > On Wed, 2013-08-14 at 17:06 -0600, Alex Williamson wrote: >> On Wed, 2013-08-14 at 16:42 -0600, Bjorn Helgaas wrote: >> > On Wed, Aug 14, 2013 at 2:10 PM, Alex Williamson >> > wrote: >> > > +s

Re: [PATCH 1/7] PCI: tegra: replace devm_request_and_ioremap by devm_ioremap_resource

2013-08-19 Thread Bjorn Helgaas
On Mon, Aug 19, 2013 at 6:02 AM, Thierry Reding wrote: > Bjorn, how do you want to handle patches to the Tegra PCIe driver in the > future? Do you want me to prepare a branch and pull from that or would > you rather just take simple patches? I'm in the habit of applying patches from email, so th

Re: [PATCH 1/7] PCI: tegra: replace devm_request_and_ioremap by devm_ioremap_resource

2013-08-19 Thread Bjorn Helgaas
On Mon, Aug 19, 2013 at 2:12 PM, Thierry Reding wrote: > On Mon, Aug 19, 2013 at 02:04:24PM -0600, Bjorn Helgaas wrote: >> On Mon, Aug 19, 2013 at 6:02 AM, Thierry Reding >> wrote: >> >> > Bjorn, how do you want to handle patches to the Tegra PCIe driver in the

Re: [PATCH] x86/PCI: MMCONFIG: cleanup and add address warning to pci_mmconfig_insert

2013-07-27 Thread Bjorn Helgaas
On Sat, Jul 27, 2013 at 8:27 AM, Yinghai Lu wrote: > On Fri, Jul 26, 2013 at 10:39 AM, Bjorn Helgaas wrote: >> [bhelgaas: changelog, drop printk] >> Signed-off-by: ethan.zhao >> Signed-off-by: Bjorn Helgaas >> Acked-by: Yinghai Lu > > loo

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-07-29 Thread Bjorn Helgaas
On Sun, Jul 28, 2013 at 6:37 PM, Takao Indoh wrote: > (2013/07/26 2:00), Bjorn Helgaas wrote: >> On Wed, Jul 24, 2013 at 12:29 AM, Takao Indoh >> wrote: >>> Sorry for letting this discussion slide, I was busy on other works:-( >>> Anyway, the summary of previ

Re: [PATCH] APEI/ERST: Fix error message formatting

2013-07-29 Thread Bjorn Helgaas
On Mon, Jul 29, 2013 at 7:58 AM, Borislav Petkov wrote: > On Thu, Jul 25, 2013 at 11:32:06AM -0600, Bjorn Helgaas wrote: >> I would suggest a change similar to 46b91e37 for ERST, and I would >> suggest using the leading zeros, with %#010llx for physical memory >> addresses a

Re: [PATCH] PCI: update NumVFs register properly during enable/disable sriov

2013-07-29 Thread Bjorn Helgaas
[+cc Don] On Wed, Jul 24, 2013 at 3:26 AM, Yijing Wang wrote: > Currently, we only update NumVFs register during sriov_enable(). > This register should also be updated properly during sriov_disable. > Otherwise, we will get the stale "Number of VFs" info from lspci. Has this always been broken,

Re: [PATCH] APEI/ERST: Fix error message formatting

2013-07-29 Thread Bjorn Helgaas
On Mon, Jul 29, 2013 at 8:40 AM, Borislav Petkov wrote: > On Mon, Jul 29, 2013 at 08:28:05AM -0600, Bjorn Helgaas wrote: >> > @@ -186,7 +186,7 @@ static int erst_exec_stall(struct apei_exec_context >> > *ctx, >> > >> > if (ctx->value >

Re: [PATCH] APEI/ERST: Fix error message formatting

2013-07-29 Thread Bjorn Helgaas
On Mon, Jul 29, 2013 at 9:22 AM, Borislav Petkov wrote: > On Mon, Jul 29, 2013 at 08:50:19AM -0600, Bjorn Helgaas wrote: >> If I were the firmware developer and got a report about this message, >> I think the information I would want is ctx->ip, so I could identify >>

Re: [PATCH] PCI: update device mps when doing pci hotplug

2013-07-29 Thread Bjorn Helgaas
On Mon, May 27, 2013 at 9:15 PM, Yijing Wang wrote: > Hi Bjorn and Jon, >I'm sorry to disturb you. This patch is sent so long, but nobody seems had > comment about it. > Do you have any comment with this patch? > > This patch try to update device mps in following case: > 1) target device unde

Re: [PATCH] PCI: update device mps when doing pci hotplug

2013-07-29 Thread Bjorn Helgaas
On Mon, Jul 29, 2013 at 9:20 PM, Yijing Wang wrote: > On 2013/7/30 7:33, Bjorn Helgaas wrote: >> On Mon, May 27, 2013 at 9:15 PM, Yijing Wang wrote: >>> Hi Bjorn and Jon, >>>I'm sorry to disturb you. This patch is sent so long, but nobody seems >>>

Re: [PATCH -v3 3/3] PCI,pciehp: use PCIe DSN to identify device change during suspend

2013-07-29 Thread Bjorn Helgaas
On Mon, Jul 29, 2013 at 9:46 PM, Yijing Wang wrote: >> I'm not sure this is implemented at the correct place. The idea of >> using the serial number to detect card swaps is not really specific to >> pciehp. I know the Device Serial Number capability is defined in the >> PCIe spec, but it doesn't

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-07-30 Thread Bjorn Helgaas
On Tue, Jul 30, 2013 at 12:09 AM, Takao Indoh wrote: > (2013/07/29 23:17), Bjorn Helgaas wrote: >> On Sun, Jul 28, 2013 at 6:37 PM, Takao Indoh >> wrote: >>> (2013/07/26 2:00), Bjorn Helgaas wrote: >>>> My point about IOMMU and PCI initialization order

Re: [PATCH] PCI: update NumVFs register properly during enable/disable sriov

2013-07-30 Thread Bjorn Helgaas
On Wed, Jul 24, 2013 at 3:26 AM, Yijing Wang wrote: > Currently, we only update NumVFs register during sriov_enable(). > This register should also be updated properly during sriov_disable. > Otherwise, we will get the stale "Number of VFs" info from lspci. > > Signed-off-by: Yijing Wang Applied

Re: [PATCH] PCI: update device mps when doing pci hotplug

2013-07-30 Thread Bjorn Helgaas
On Mon, Jul 29, 2013 at 9:42 PM, Bjorn Helgaas wrote: > On Mon, Jul 29, 2013 at 9:20 PM, Yijing Wang wrote: >> On 2013/7/30 7:33, Bjorn Helgaas wrote: >>> On Mon, May 27, 2013 at 9:15 PM, Yijing Wang wrote: >>>> Hi Bjorn and Jon, >>>>I'm sorry

Re: [PATCH] PCI: update device mps when doing pci hotplug

2013-07-31 Thread Bjorn Helgaas
On Wed, Jul 31, 2013 at 3:15 AM, Yijing Wang wrote: > Hi Bjorn, >I didn't observe a performance difference between MPS=128 and MPS=512. I > use ping $dest_ip -s 65500(large size packet) > to test the different situations. Interesting. "ping" is probably not a good way to see performance dif

Re: [PATCH] APEI/ERST: Fix error message formatting

2013-07-31 Thread Bjorn Helgaas
On Wed, Jul 31, 2013 at 3:46 AM, Naveen N. Rao wrote: > My key question was about why we are using a field width of 10 implying a > 32-bit value, rather than a field width of 18 as suggested by the data type? > This shouldn't truncate the value, but if we are specifying the field width > for alig

Re: [PATCH] PCI: update device mps when doing pci hotplug

2013-07-31 Thread Bjorn Helgaas
On Wed, Jul 31, 2013 at 11:53 AM, Bjorn Helgaas wrote: > On Wed, Jul 31, 2013 at 3:15 AM, Yijing Wang wrote: >> Hi Bjorn, >>I didn't observe a performance difference between MPS=128 and MPS=512. I >> use ping $dest_ip -s 65500(large size packet) >>

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-07-31 Thread Bjorn Helgaas
[+cc Rafael, linux-acpi] On Tue, Jul 30, 2013 at 6:35 PM, Takao Indoh wrote: > On x86, currently IOMMU initialization run *after* PCI enumeration, but > what you are talking about is that it should be changed so that x86 > IOMMU initialization is done *before* PCI enumeration like sparc, right?

Re: [PATCH 2/3] Refactor msi/msix restore code Part2

2013-07-31 Thread Bjorn Helgaas
On Tue, Jul 23, 2013 at 9:08 PM, Zhenzhong Duan wrote: > xen_initdom_restore_msi_irqs trigger a hypercall to restore addr/data/mask > in dom0. It's better to do the same for default_restore_msi_irqs in baremetal. > > Move restore of mask in default_restore_msi_irqs, this could avoid mask > restore

Re: /sys/module/pcie_aspm/parameters/policy not writable?

2013-07-31 Thread Bjorn Helgaas
On Fri, Jul 19, 2013 at 11:46 AM, Bjorn Helgaas wrote: > Just to make sure I understand you correctly: I think you are saying > that the NIC has the same problem under Windows. Can you confirm or deny that the same problem occurs with Windows? > But since the problem also occurs wit

Re: /sys/module/pcie_aspm/parameters/policy not writable?

2013-08-01 Thread Bjorn Helgaas
On Thu, Aug 1, 2013 at 8:57 AM, Wyborny, Carolyn wrote: >> -Original Message- >> From: Bjorn Helgaas [mailto:bhelg...@google.com] >> Sent: Wednesday, July 31, 2013 4:53 PM >> To: Pavel Machek >> Cc: Greg KH; kernel list; Joe Lawrence; Myron Stowe; Kirsher, J

Re: /sys/module/pcie_aspm/parameters/policy not writable?

2013-08-01 Thread Bjorn Helgaas
On Thu, Aug 1, 2013 at 2:00 PM, Pavel Machek wrote: > Hi! > >> > But since the problem also occurs with Windows, it's pretty likely >> > that there's a BIOS update to fix it. I notice on the X60 support >> > page that there are several versions newer than what you're running. >> >> Do you have an

Re: /sys/module/pcie_aspm/parameters/policy not writable?

2013-08-02 Thread Bjorn Helgaas
On Thu, Aug 1, 2013 at 8:13 PM, Pavel Machek wrote: > Hmm. So I've update bios using 7buj28uc.iso . Reverted the patches and > yes, ping latencies are still bad: Wow. I can hardly believe how bad this is (assuming Windows has the same problem). Thanks a lot for checking this out. >> >> Caroly

[GIT PULL] PCI updates for v3.11

2013-08-02 Thread Bjorn Helgaas
Bjorn Helgaas (2): PCI: hotplug: Convert to be builtin only, not modular PCI: pciehp: Convert pciehp to be builtin only, not modular Thomas Petazzoni (1): PCI: mvebu: Disable prefetchable memory support in PCI-to-PCI bridge Yinghai Lu (2): PCI: pciehp: Fix null pointer deref

kernel mailing list permalinks

2013-08-02 Thread Bjorn Helgaas
vger already adds a "to unsubscribe from this list" footer to messages to LKML and other lists. What if it also added the lkml.kernel.org permalink for the message, e.g., "http://lkml.kernel.org/r/ca+55afxb3nt3_04zlkicfrttxsdi4bfqff0hjvirryptw4y...@mail.gmail.com";? I often use the permalink to c

Re: RFC: vfio-pci API for PCI bus/slot (hot) resets

2013-08-02 Thread Bjorn Helgaas
[+cc linux-pci] On Fri, Aug 2, 2013 at 3:28 PM, Benjamin Herrenschmidt wrote: > Right. Another use case is, I know of devices that need a fundamental > reset (PERST) after applying a FW update. This is a tangent from the real discussion here, but the question of resetting a device after a firmw

Re: [PATCH 1/7] PCI: tegra: replace devm_request_and_ioremap by devm_ioremap_resource

2013-08-20 Thread Bjorn Helgaas
'm hoping this goes via arm-soc. Let me know if you need me to do something. If you need it: Acked-by: Bjorn Helgaas > --- > v2: add the change to the comment > > drivers/pci/host/pci-tegra.c | 31 ++- > 1 file changed, 10 insertions(+), 21

Re: [E1000-devel] 3.11-rc4 ixgbevf: endless "Last Request of type 00 to PF Nacked" messages

2013-08-20 Thread Bjorn Helgaas
[+cc Don Dutile] On Tue, Aug 13, 2013 at 8:23 PM, Bjorn Helgaas wrote: > On Tue, Aug 13, 2013 at 3:54 PM, Skidmore, Donald C > wrote: > >> We were unable to recreate your failure here locally so I have some >> additional questions. First off you mentioned it was f

Re: [E1000-devel] 3.11-rc4 ixgbevf: endless "Last Request of type 00 to PF Nacked" messages

2013-08-20 Thread Bjorn Helgaas
On Tue, Aug 20, 2013 at 5:08 PM, Bjorn Helgaas wrote: > On Tue, Aug 13, 2013 at 8:23 PM, Bjorn Helgaas wrote: >> I played with this a little more and found this: >> >> 1) Magma card in z420, connected to chassis containing X540: fails >> (original report) >> 2)

Re: [PATCH 1/1] ACPI / PNP: Fix incorrect placement of __initdata

2013-08-22 Thread Bjorn Helgaas
[+cc linux-kernel] On Thu, Aug 22, 2013 at 1:44 AM, Sachin Kamat wrote: > __initdata should be placed between the variable name and equal > sign for the variable to be placed in the intended section. I'm not sure this is true, or maybe there's some sort of toolchain issue. On my system, I see t

Re: 3.9.0 dmesg reports that my NIC is hanging

2013-08-22 Thread Bjorn Helgaas
On Tue, May 7, 2013 at 3:07 PM, John wrote: > > > > > - Original Message - >> From: Bjorn Helgaas >> To: John >> Cc: lkml ; Jeff Kirsher >> ; "e1000-de...@lists.sourceforge.net" >> >> Sent: Monday, May 6, 2013 1:29

Re: [PATCH 2/3 v2] Refactor msi/msix restore code Part2

2013-08-22 Thread Bjorn Helgaas
On Mon, Aug 5, 2013 at 1:21 AM, Zhenzhong Duan wrote: > xen_initdom_restore_msi_irqs trigger a hypercall to restore addr/data/mask > in dom0. It's better to do the same in default_restore_msi_irqs for baremetal. > > Move restore of mask in default_restore_msi_irqs, this could avoid mask > restored

Re: [PATCH] pci: Add pci_walk_slot() interface

2013-08-22 Thread Bjorn Helgaas
On Mon, Aug 19, 2013 at 2:04 PM, Alex Williamson wrote: > We have a pci_walk_bus() interface, but it's exceptionally cumbersome > for the callback function to figure out if the device is relevant if > the caller is trying to walk all the devices in or below a slot. Add > a variant to walk only sl

Re: [PATCH] PCI: avoid NULL deref in alloc_pcie_link_state

2013-08-22 Thread Bjorn Helgaas
On Thu, Aug 08, 2013 at 03:57:07PM +0200, Radim Krčmář wrote: > PCIe switch can be connected directly to the PCIe root complex in QEMU; > ASPM does not expect this topology and dereferences NULL pointer when > initializing. > > Downstream port can be also connected to the root complex without > up

Re: [PATCH] pci: avoid unnecessary writing of the command register during probe

2013-08-23 Thread Bjorn Helgaas
size the BAR, we don't need to disable it again. [bhelgaas: changelog, add PCI_COMMAND_DECODING_ENABLE for readability] Signed-off-by: Zoltan Kiss Signed-off-by: Bjorn Helgaas --- drivers/pci/probe.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers

Re: [E1000-devel] 3.11-rc4 ixgbevf: endless "Last Request of type 00 to PF Nacked" messages

2013-08-23 Thread Bjorn Helgaas
On Tue, Aug 20, 2013 at 5:37 PM, Bjorn Helgaas wrote: > On Tue, Aug 20, 2013 at 5:08 PM, Bjorn Helgaas wrote: >> On Tue, Aug 13, 2013 at 8:23 PM, Bjorn Helgaas wrote: > >>> I played with this a little more and found this: >>> >>> 1) Magma card in z42

Re: [E1000-devel] 3.11-rc4 ixgbevf: endless "Last Request of type 00 to PF Nacked" messages

2013-08-23 Thread Bjorn Helgaas
On Fri, Aug 23, 2013 at 06:25:06PM +, Skidmore, Donald C wrote: > > -Original Message- > > From: Bjorn Helgaas [mailto:bhelg...@google.com] > > Sent: Friday, August 23, 2013 9:53 AM > > To: Skidmore, Donald C > > Cc: e1000-de...@lists.sourceforge.net; li

Re: [E1000-devel] 3.11-rc4 ixgbevf: endless "Last Request of type 00 to PF Nacked" messages

2013-08-23 Thread Bjorn Helgaas
On Fri, Aug 23, 2013 at 2:37 PM, Skidmore, Donald C wrote: >> -Original Message- >> From: Bjorn Helgaas [mailto:bhelg...@google.com] >> Sent: Friday, August 23, 2013 11:53 AM >> To: Skidmore, Donald C >> Cc: e1000-de...@lists.sourceforge.net; linux-...@

Re: [PATCH] ACPI: Fix osc flag setup ordering to allow pcie hotplug use when available

2013-08-23 Thread Bjorn Helgaas
rial to linux-pci in the first place. >> > >> Sorry, I ran get_maintainers and it seemed to think linux-acpi was >> sufficient. >> >> > The change that broke things for you was actually intentional: >> > >> > commit b8178f130e25c1bdac1c3

Re: [PATCH] PCI: avoid NULL deref in alloc_pcie_link_state

2013-08-23 Thread Bjorn Helgaas
[+cc Shaohua] On Thu, Aug 22, 2013 at 6:02 PM, Bjorn Helgaas wrote: > On Thu, Aug 08, 2013 at 03:57:07PM +0200, Radim Krčmář wrote: >> PCIe switch can be connected directly to the PCIe root complex in QEMU; >> ASPM does not expect this topology and dereferences NULL pointer when

Re: [PATCH] ACPI: Fix osc flag setup ordering to allow pcie hotplug use when available

2013-08-23 Thread Bjorn Helgaas
On Fri, Aug 23, 2013 at 3:40 PM, Rafael J. Wysocki wrote: > On Friday, August 23, 2013 02:46:23 PM Bjorn Helgaas wrote: >> On Fri, Aug 23, 2013 at 2:53 PM, Rafael J. Wysocki wrote: >> > On Friday, August 23, 2013 04:05:11 PM Neil Horman wrote: >> >> On Fri, Au

Re: [Help Test] kdump, x86, acpi: Reproduce CPU0 SMI corruption issue after unsetting BSP flag

2013-08-06 Thread Bjorn Helgaas
On Tue, Aug 6, 2013 at 3:19 AM, HATAYAMA Daisuke wrote: > So, could anyone help testing the idea 2) above if you have which of > the following machines? (or other ones that can lead to the same bug) > > - HP Compaq 6910p > - HP Compaq 6710b > - HP Compaq 6710s > - HP Compaq 6510b > - HP Compaq 251

Re: [PATCH v2] tile: support LSI MEGARAID SAS HBA hybrid dma_ops

2013-08-06 Thread Bjorn Helgaas
[+cc Myron, Adam] On Fri, Aug 2, 2013 at 10:24 AM, Chris Metcalf wrote: > The LSI MEGARAID SAS HBA suffers from the problem where it can do > 64-bit DMA to streaming buffers but not to consistent buffers. > In other words, 64-bit DMA is used for disk data transfers and 32-bit > DMA must be used f

Re: [PATCH V2 6/6] pci: mvebu: Convert to use devm_ioremap_resource

2013-08-06 Thread Bjorn Helgaas
On Tue, Aug 6, 2013 at 4:39 AM, Thomas Petazzoni wrote: > Dear Bjorn Helgaas, > > [+cc Jason Cooper, Gregory Clement and Ezequiel Garcia] > > On Tue, 23 Jul 2013 12:38:28 -0600, Bjorn Helgaas wrote: >> [+cc Thomas] >> >> On Mon, Jun 17, 2013 at 3:16 AM, Tush

Re: kernel mailing list permalinks

2013-08-06 Thread Bjorn Helgaas
[+cc vger postmaster] On Fri, Aug 2, 2013 at 3:38 PM, H. Peter Anvin wrote: > On 08/02/2013 02:36 PM, Shuah Khan wrote: >> On Fri, Aug 2, 2013 at 3:04 PM, Bjorn Helgaas wrote: >>> vger already adds a "to unsubscribe from this list" footer to messages >>>

Re: [PATCH V5] pci: exynos: split into two parts such as Synopsys part and Exynos part

2013-08-07 Thread Bjorn Helgaas
>> Also, the Synopsys designware part can be shared with other >> platforms; thus, it can be split two parts such as Synopsys >> designware part and Exynos specific part. >> >> Signed-off-by: Jingoo Han >> Cc: Pratyush Anand >> Cc: Mohit KUMAR > > H

Re: [PATCH] ACPI: Try harder to resolve _ADR collisions for bridges

2013-08-07 Thread Bjorn Helgaas
of this patch is that it fixes some sort of video problem? > References: https://bugzilla.kernel.org/show_bug.cgi?id=60561 > Reported-by: Peter Wu > Tested-by: Vladimir Lalov > Signed-off-by: Rafael J. Wysocki > Cc: 3.9+ # 3.9+ I'm OK with this as-is, and expect that you&#x

Re: /sys/module/pcie_aspm/parameters/policy not writable?

2013-07-19 Thread Bjorn Helgaas
On Fri, Jul 12, 2013 at 5:11 AM, Pavel Machek wrote: >> Pavel's ThinkPad X60 has two NICs: Intel 82573L and Intel PRO/Wireless >> 3945ABG. I'm pretty sure the problem he's reporting is with the >> 82573L. Ping times are bad (~100msec) when ASPM is enabled, as >> reported by lspci. > > Yep. Wired

Re: [PATCH v2] x86/pci: checkpatch.pl cleanup

2013-07-19 Thread Bjorn Helgaas
On Wed, Jul 17, 2013 at 1:58 AM, Ingo Molnar wrote: > > * Valentina Manea wrote: > >> This patch fixes warning and errors found by checkpatch.pl: >> >> * replace asm/acpi.h, asm/io.h and asm/smp.h with linux/acpi.h, >> linux/io.h and linux/smp.h respectively >> * remove explicit initialization to

Re: [PATCH 0/4] pci_ids, 8250_pci: remove PCI_VENDOR_ID_ADDIDATA_OLD

2013-07-19 Thread Bjorn Helgaas
drivers/staging/comedi/comedidev.h | 1 - > drivers/tty/serial/8250/8250_pci.c | 9 + > include/linux/pci_ids.h| 4 ++-- > 3 files changed, 7 insertions(+), 7 deletions(-) For patches 1 & 4 (the ones that touch pci_ids.h): Acked-by: Bjorn Helgaas Please merge them along with the

Re: workqueue, pci: INFO: possible recursive locking detected

2013-07-22 Thread Bjorn Helgaas
[+cc Alex, Yinghai, linux-pci] On Mon, Jul 22, 2013 at 9:37 AM, Srivatsa S. Bhat wrote: > On 07/22/2013 05:22 PM, Lai Jiangshan wrote: >> On 07/19/2013 04:57 PM, Srivatsa S. Bhat wrote: >>> On 07/19/2013 07:17 AM, Lai Jiangshan wrote: On 07/19/2013 04:23 AM, Srivatsa S. Bhat wrote: > >>>

Re: [PATCH v2 1/8] x86/PCI: prevent re-allocation of already existing bridge and ROM resources

2013-07-22 Thread Bjorn Helgaas
On Wed, Jul 3, 2013 at 8:04 AM, Mika Westerberg wrote: > In hotplug case (especially with Thunderbolt enabled systems) we might need > to call pcibios_resource_survey_bus() several times for a bus. The function > ends up calling pci_claim_resource() for each bridge resource that then > fails claim

Re: [PATCH v2 1/8] x86/PCI: prevent re-allocation of already existing bridge and ROM resources

2013-07-22 Thread Bjorn Helgaas
On Mon, Jul 22, 2013 at 6:08 PM, Bjorn Helgaas wrote: > On Wed, Jul 3, 2013 at 8:04 AM, Mika Westerberg > wrote: >> In hotplug case (especially with Thunderbolt enabled systems) we might need >> to call pcibios_resource_survey_bus() several times for a bus. The function

Re: [PATCH v2 1/8] x86/PCI: prevent re-allocation of already existing bridge and ROM resources

2013-07-22 Thread Bjorn Helgaas
On Mon, Jul 22, 2013 at 7:18 PM, Bjorn Helgaas wrote: > On Mon, Jul 22, 2013 at 6:08 PM, Bjorn Helgaas wrote: >> On Wed, Jul 3, 2013 at 8:04 AM, Mika Westerberg >> wrote: >>> In hotplug case (especially with Thunderbolt enabled systems) we might need >>> to

Re: Linux Plumbers ACPI/PM, PCI Microconference

2013-07-23 Thread Bjorn Helgaas
On Tue, Jul 16, 2013 at 8:21 PM, Myron Stowe wrote: > Linux Plumbers has approved an ACPI/PM, PCI microconference. The > overview page is here: > > http://wiki.linuxplumbersconf.org/2013:pci_subsystem > > We would like to start receiving volunteers for presenting topics of > interest. There is a

Re: [PATCH 13/27] drivers/pci/host: don't check resource with devm_ioremap_resource

2013-07-23 Thread Bjorn Helgaas
[+cc Jingoo] On Tue, Jul 23, 2013 at 12:01 PM, Wolfram Sang wrote: > devm_ioremap_resource does sanity checks on the given resource. No need to > duplicate this in the driver. > > Signed-off-by: Wolfram Sang Acked-by: Bjorn Helgaas Jingoo, I can apply this, or if you hav

Re: [PATCH V2 6/6] pci: mvebu: Convert to use devm_ioremap_resource

2013-07-23 Thread Bjorn Helgaas
_registers() to propagate error code. > > Signed-off-by: Tushar Behera > CC: linux-...@vger.kernel.org > CC: Bjorn Helgaas Acked-by: Bjorn Helgaas Thomas has a bunch of mvebu patches in the pipeline, so I assume he will incorporate this if appropriate. I don't want to put

Re: [PATCH v2 0/3] pci: ACS fixes & quirks

2013-07-23 Thread Bjorn Helgaas
On Thu, Jun 27, 2013 at 04:39:41PM -0600, Alex Williamson wrote: > v2: > > Revised patch 1/ to match comments from Bjorn. PCIe event collectors > and PCIe-to-PCI bridges now indicate that they do not support ACS. > I've reached out to try to get clarification on this, but I think it's > reasonabl

Re: [PATCH 0/30] ACPI / hotplug / PCI: Major rework + Thunderbolt workarounds

2013-07-24 Thread Bjorn Helgaas
On Wed, Jul 24, 2013 at 6:58 AM, Rafael J. Wysocki wrote: > On Tuesday, July 23, 2013 07:20:53 PM Yinghai Lu wrote: >> On Tue, Jul 23, 2013 at 2:39 PM, Rafael J. Wysocki wrote: > > [...] > >> [ 102.631369] pci_host_bridge pci:00: freeing pci_host_bridge info > > By the way this looks fishy:

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-07-25 Thread Bjorn Helgaas
On Wed, Jul 24, 2013 at 12:29 AM, Takao Indoh wrote: > Sorry for letting this discussion slide, I was busy on other works:-( > Anyway, the summary of previous discussion is: > - My patch adds new initcall(fs_initcall) to reset all PCIe endpoints on > boot. This expects PCI enumeration is done be

Re: [PATCH] APEI/ERST: Fix error message formatting

2013-07-25 Thread Bjorn Helgaas
e are intentional and those fields truly aren't 64-bit >>> (as suggested by the usage of long long int). >> >> >> I suggest using "0x%llx" everywhere unless there's a >> compelling reason like columnar alignment for them. > > > I think

Re: [PATCH v5 09/16] PCI: tegra: set up PADS_REFCLK_CFG1

2013-07-25 Thread Bjorn Helgaas
Beaver operate correctly. > > While we're at it, add some #defines to partially document the fields > within these 16-bit values. > > Signed-off-by: Stephen Warren > Signed-off-by: Thierry Reding Acked-by: Bjorn Helgaas > --- > drivers/pci/host/pci-tegra.c | 29 +++

Re: [PATCH v5 08/16] PCI: tegra: Add Tegra 30 PCIe support

2013-07-25 Thread Bjorn Helgaas
d-off-by: Jay Agarwal > Signed-off-by: Thierry Reding Acked-by: Bjorn Helgaas > --- > .../bindings/pci/nvidia,tegra20-pcie.txt | 4 +- > drivers/pci/host/pci-tegra.c | 209 > + > 2 files changed, 179 insertions(+), 34 dele

Re: [PATCH 14/36] PCI: convert class code to use dev_groups

2013-07-25 Thread Bjorn Helgaas
On Wed, Jul 24, 2013 at 03:05:17PM -0700, Greg Kroah-Hartman wrote: > The dev_attrs field of struct class is going away soon, dev_groups > should be used instead. This converts the PCI class code to use the > correct field. > > Cc: Bjorn Helgaas > Signed-off-by:

Re: [PATCH -v3 3/3] PCI,pciehp: use PCIe DSN to identify device change during suspend

2013-07-25 Thread Bjorn Helgaas
On Fri, Jul 12, 2013 at 3:32 AM, Yijing Wang wrote: > If device was removed from slot and reinsert a new device during > suspend, pciehp can not identify the physical device change now. > So the old driver .resume() method will be called for the new device, > this is bad. If device support device

Re: [PATCH] x86/PCI: MMCONFIG: cleanup and add address warning to pci_mmconfig_insert

2013-07-26 Thread Bjorn Helgaas
-EINVAL; > -} > - > rc = -EBUSY; > cfg = pci_mmconfig_alloc(seg, start, end, addr); > if (cfg == NULL) { Author: ethan.zhao Date: Fri Jul 26 11:21:24 2013 -0600 x86/PCI: MMCONFIG: Check earlier for MMCONFIG region at address zero We can chec

Re: [RFC 0/3] IO Hook: Method for emulating h/w events

2013-07-26 Thread Bjorn Helgaas
[+cc linux-acpi] On Fri, Jul 26, 2013 at 12:51 AM, Rui Wang wrote: > Hi Bjorn, > > This was originally the method I used to test hotplug on Intel SDV machines > which are not capable of doing hotplug. I would like to present it here in > case it interests the community, then it can be made availa

3.11-rc4 ixgbevf: endless "Last Request of type 00 to PF Nacked" messages

2013-08-09 Thread Bjorn Helgaas
When I enable VFs via sysfs on an Intel X540-AT, I see an endless stream of ixgbevf :08:10.2: Last Request of type 03 to PF Nacked messages. This on an HP z420 with the Intel X540-AT in external Magma PCIe expansion chassis. No cable is attached to the X540-AT. ixgbe is built as a modu

Re: [PATCH v2] tile: support LSI MEGARAID SAS HBA hybrid dma_ops

2013-08-09 Thread Bjorn Helgaas
On Thu, Aug 08, 2013 at 12:47:10PM -0400, Chris Metcalf wrote: > On 8/6/2013 1:48 PM, Bjorn Helgaas wrote: > > [+cc Myron, Adam] > > > > On Fri, Aug 2, 2013 at 10:24 AM, Chris Metcalf wrote: > >> According to LSI, > >> the firmware is not fully functional

Re: linux-next: Tree for Aug 8 (not CONFIG_PCI_MSI conflict)

2013-08-10 Thread Bjorn Helgaas
On Fri, Aug 9, 2013 at 12:50 PM, Jason Cooper wrote: > Randy, > > On Fri, Aug 09, 2013 at 09:41:38AM -0700, Randy Dunlap wrote: >> On 08/09/13 07:59, Jason Cooper wrote: >> > Randy, >> > >> > On Thu, Aug 08, 2013 at 01:03:04PM -0700, Randy Dunlap wrote: >> >> On 08/08/13 00:08, Stephen Rothwell wr

Re: linux-next: Tree for Aug 8 (not CONFIG_PCI_MSI conflict)

2013-08-12 Thread Bjorn Helgaas
On Mon, Aug 12, 2013 at 7:18 AM, Jason Cooper wrote: > On Sat, Aug 10, 2013 at 08:01:49AM -0600, Bjorn Helgaas wrote: >> On Fri, Aug 9, 2013 at 12:50 PM, Jason Cooper wrote: >> > Randy, >> > >> > On Fri, Aug 09, 2013 at 09:41:38AM -0700, Randy Dunlap wrote: &

Re: [PATCH v2] tile: support LSI MEGARAID SAS HBA hybrid dma_ops

2013-08-12 Thread Bjorn Helgaas
On Mon, Aug 12, 2013 at 1:42 PM, Chris Metcalf wrote: > On 8/9/2013 6:42 PM, Bjorn Helgaas wrote: >> On Thu, Aug 08, 2013 at 12:47:10PM -0400, Chris Metcalf wrote: >>> On 8/6/2013 1:48 PM, Bjorn Helgaas wrote: >>>> [+cc Myron, Adam] >>>> >>>>

Re: [PATCH 0/9] ARM: dove: DT PCIe support

2013-08-12 Thread Bjorn Helgaas
| 29 - > drivers/pci/host/Kconfig |2 +- > drivers/pci/host/pci-mvebu.c | 113 > +++++------- > 8 files changed, 241 insertions(+), 68 deletions(-) > create mode 100644 arch/arm/boot/dts/dove-d3plug.dts > --- &

Re: [PATCH v2 0/5] ARM: dove: DT PCIe support

2013-08-13 Thread Bjorn Helgaas
On Tue, Aug 13, 2013 at 8:01 AM, Jason Cooper wrote: > Bjorn, > > On Tue, Aug 13, 2013 at 02:25:19PM +0200, Sebastian Hesselbarth wrote: >> This patch set adds support for the PCIe controllers found on Marvell >> Dove SoCs. It depends on mvebu-pci patches sent by Thomas Petazzoni. > > Well, when i

Re: [PATCH v2] tile: support LSI MEGARAID SAS HBA hybrid dma_ops

2013-08-13 Thread Bjorn Helgaas
[+cc James in case he has opinions on the DMA mask question] On Tue, Aug 13, 2013 at 10:12 AM, Chris Metcalf wrote: > (Trimming the quoted material a little to try to keep this email under > control.) > > On 8/12/2013 4:42 PM, Bjorn Helgaas wrote: >> On Mon, Aug 12, 2013

Re: [E1000-devel] 3.11-rc4 ixgbevf: endless "Last Request of type 00 to PF Nacked" messages

2013-08-13 Thread Bjorn Helgaas
is preliminary info in case it rings any bells for you. >> -Original Message- >> From: Bjorn Helgaas [mailto:bhelg...@google.com] >> Sent: Friday, August 09, 2013 10:19 AM >> To: e1000-de...@lists.sourceforge.net >> Cc: linux-...@vger.kernel.org; linux-kernel@vger

Re: Uhhuh. NMI received for unknown reason 2c on CPU 0.

2013-03-04 Thread Bjorn Helgaas
[+cc e1000-devel, Jeff, Bruce] On Mon, Mar 4, 2013 at 2:50 PM, Borislav Petkov wrote: > On Fri, Feb 15, 2013 at 10:16:41AM +0100, Borislav Petkov wrote: >> So it looks Bjorn has taken most of them and the e1000e one will go >> through the e1000e maintainers. I'll test after the merge window is >>

Re: 3.9-linux-next-20130501: OOPS in intel_pstate_sample

2013-05-10 Thread Bjorn Helgaas
[+cc Viresh, Srinivas, Dirk, cpufreq list] On Wed, May 1, 2013 at 3:03 PM, Martin Mokrejs wrote: > Hi, > I opened yet another bug https://bugzilla.kernel.org/show_bug.cgi?id=57411 . > > This is maybe a dupe of bug https://bugzilla.kernel.org/show_bug.cgi?id=57401 > (which is vanilla 3.9) but ha

Re: is L1 really disabled in iwlwifi

2013-05-10 Thread Bjorn Helgaas
[+cc Rafael, other pci_disable_link_state() users] On Wed, May 01, 2013 at 11:13:15AM -0600, Bjorn Helgaas wrote: > On Wed, May 1, 2013 at 2:31 AM, Emmanuel Grumbach wrote: > > [from Bjorn's mail] > >> In Emmanuel's case, we don't get _OSC control, so > >

Re: [PATCH v6] irq: add quirk for broken interrupt remapping on 55XX chipsets

2013-04-08 Thread Bjorn Helgaas
[+cc Joerg, Konrad] On Mon, Apr 8, 2013 at 9:29 AM, Don Dutile wrote: > On 04/05/2013 09:55 PM, Bjorn Helgaas wrote: >> >> On Fri, Apr 5, 2013 at 1:31 PM, Neil Horman wrote: >>> >>> A few years back intel published a spec update: >>> >>> http:/

Re: [PATCH 2/3] PCI: Handle device quirks when accessing sysfs resource entries

2013-04-08 Thread Bjorn Helgaas
On Sat, Apr 6, 2013 at 2:49 AM, James Bottomley wrote: > On Thu, 2013-04-04 at 12:06 -0600, Bjorn Helgaas wrote: >> On Thu, Mar 21, 2013 at 6:51 PM, Robert Hancock wrote: >> > -Reconsider whether supporting read/write on the resource files for IO port >> > regions

Re: [PATCH v8 10/13] PCI/acpiphp: do not use ACPI PCI subdriver mechanism

2013-04-09 Thread Bjorn Helgaas
On Tue, Feb 26, 2013 at 8:25 AM, Jiang Liu wrote: > Previously the acpiphp driver registers itself as an ACPI PCI subdriver, > so it's callbacks will be invoked when creating/destroying PCI root > buses to manage ACPI based PCI hotplug slots. But it doesn't handle > P2P bridge hotplug events, so i

Re: [PATCH v3 03/27] PCI: pci resource iterator

2013-04-10 Thread Bjorn Helgaas
On Mon, Apr 8, 2013 at 10:51 PM, Ram Pai wrote: > On Thu, Apr 04, 2013 at 04:18:01PM -0600, Bjorn Helgaas wrote: >> On Wed, Mar 13, 2013 at 5:27 PM, Yinghai Lu wrote: >> > From: Ram Pai >> > >> > Currently pci_dev structure holds an array of 17 PCI resour

Re: [PATCH 1/2] pci/of: remove weak annotation of pcibios_get_phb_of_node

2013-04-10 Thread Bjorn Helgaas
On Thu, Apr 4, 2013 at 12:01 PM, Gabor Juhos wrote: > Due to the __weak annotation in the forward declaration > of the 'pcibios_get_phb_of_node' function GCC will emit > a weak symbol for this functions even if the actual > implementation does not use the weak attribute. > > If an architecture tri

Re: [PATCH 2/2] MIPS: implement pcibios_get_phb_of_node

2013-04-10 Thread Bjorn Helgaas
On Thu, Apr 4, 2013 at 12:01 PM, Gabor Juhos wrote: > The of_node field of the device assigned to a > PCI bus is used during scanning of the PCI bus. > However on MIPS, the of_node field is assigned > only after the bus has been scanned. > > Implement the architecture specific version of > 'pcibio

Re: [PATCH v8 10/13] PCI/acpiphp: do not use ACPI PCI subdriver mechanism

2013-04-10 Thread Bjorn Helgaas
On Wed, Apr 10, 2013 at 10:14 AM, Jiang Liu wrote: > On 04/10/2013 07:38 AM, Bjorn Helgaas wrote: >> On Tue, Feb 26, 2013 at 8:25 AM, Jiang Liu wrote: >>> Previously the acpiphp driver registers itself as an ACPI PCI subdriver, >>> so it's callbacks will be invo

Re: [PATCH] pciehp: Add pciehp_surprise module option

2013-04-10 Thread Bjorn Helgaas
On Wed, Apr 10, 2013 at 10:34 AM, Takashi Iwai wrote: > Hi Bjorn, > > sorry for the late follow up as I was on vacation and has been busy > for other tasks. Since this topic went to nirvana, I try to whip > again... > > At Mon, 25 Mar 2013 10:58:40 -0600, > Bjorn Helgaas

Re: x86/pci/mrst: force all pci config toward 0:0:0, 0:2:0 and 0:3:0 to type 1

2013-04-30 Thread Bjorn Helgaas
On Tue, Apr 30, 2013 at 1:21 AM, Bin Gao wrote: > x86/pci/mrst: force all pci config access toward 0:0:0, 0:2:0 and 0:3:0 to > type 1 > > For real pci devices 0:0:0, 0:2:0 and 0:3:0, there is either no pci shim, or > no guarantee of data correctness of offset 256-4k. So for whatever reason, > Lin

Re: x86/pci/mrst: force all pci config toward 0:0:0, 0:2:0 and 0:3:0 to type 1

2013-05-01 Thread Bjorn Helgaas
On Tue, Apr 30, 2013 at 1:21 AM, Bin Gao wrote: > x86/pci/mrst: force all pci config access toward 0:0:0, 0:2:0 and 0:3:0 to > type 1 > > For real pci devices 0:0:0, 0:2:0 and 0:3:0, there is either no pci shim, or > no guarantee of data correctness of offset 256-4k. So for whatever reason, > Lin

Re: 3.9.0 dmesg reports that my NIC is hanging

2013-05-06 Thread Bjorn Helgaas
[+cc Jeff, e1000-devel (from MAINTAINERS)] On Sat, May 4, 2013 at 1:56 PM, John wrote: > After upgrading to the official Arch Linux 3.9-2 kernel package, dmesg > reports that my NIC is hanging: > > [5.955720] e1000e :00:19.0 eno1: changing MTU from 1500 to 4000 > [8.464507] e1000e 00

Re: x86/pci/mrst: force all pci config toward 0:0:0, 0:2:0 and 0:3:0 to type 1

2013-05-06 Thread Bjorn Helgaas
On Wed, May 1, 2013 at 11:53 PM, Bin Gao wrote: > On Wed, May 01, 2013 at 11:17:10AM -0600, Bjorn Helgaas wrote: >> Is there any possibility of multi-function devices at bus 0, device 0, 2, or >> 3? >> >> What about bridges -- can any of these be a bridge? >> &

Re: x86/pci/mrst: force all pci config toward 0:0:0, 0:2:0 and 0:3:0 to type 1

2013-05-06 Thread Bjorn Helgaas
On Mon, May 6, 2013 at 10:38 AM, Bjorn Helgaas wrote: > On Wed, May 1, 2013 at 11:53 PM, Bin Gao wrote: >> On Wed, May 01, 2013 at 11:17:10AM -0600, Bjorn Helgaas wrote: >>> Is there any possibility of multi-function devices at bus 0, device 0, 2, >>> or 3? I hate

Re: x86/pci/mrst: force all pci config toward 0:0:0, 0:2:0 and 0:3:0 to type 1

2013-05-06 Thread Bjorn Helgaas
[+cc linux-pci] On Mon, May 6, 2013 at 3:42 PM, Bin Gao wrote: > On Mon, May 06, 2013 at 11:56:38AM -0700, Bjorn Helgaas wrote: >> I hate it when I go to the trouble of reviewing something and asking >> relevant questions, and then people ignore the questions :( > Sorry for th

Re: 3.8.4 kernel

2013-05-06 Thread Bjorn Helgaas
[+cc Xiong, Cloud, netdev since this looks like an atl1c issue] On Fri, Apr 26, 2013 at 3:33 PM, Bjorn Helgaas wrote: > On Wed, Mar 27, 2013 at 3:46 PM, Bjorn Helgaas wrote: >> On Wed, Mar 27, 2013 at 3:18 PM, Joseph A. Millikan >> wrote: >>> >>> We use Mint

<    1   2   3   4   5   6   7   8   9   10   >