Re: [PATCH] PCI: Remove not needed check in disable aspm link

2013-06-14 Thread Bjorn Helgaas
On Fri, Jun 14, 2013 at 10:57 AM, Yinghai Lu wrote: > On Fri, Jun 14, 2013 at 9:33 AM, Bjorn Helgaas wrote: >> On Fri, Jun 14, 2013 at 10:17 AM, Yinghai Lu wrote: >> >> Can you please refer to specific function names? I can't read your mind. >&

Re: [PATCH] PCI: Remove not needed check in disable aspm link

2013-06-14 Thread Bjorn Helgaas
[+cc Maxim, Jussi] On Fri, Jun 14, 2013 at 12:26 PM, Yinghai Lu wrote: > On Fri, Jun 14, 2013 at 10:44 AM, Bjorn Helgaas wrote: >> On Fri, Jun 14, 2013 at 10:57 AM, Yinghai Lu wrote: >>> On Fri, Jun 14, 2013 at 9:33 AM, Bjorn Helgaas wrote: >>>> On Fri, Jun 14

Re: [PATCH] PCI / ACPI / PM: Use correct power state strings in messages

2013-06-14 Thread Bjorn Helgaas
On Sat, Jun 15, 2013 at 12:28:12AM +0200, Rafael J. Wysocki wrote: > On Friday, June 14, 2013 11:08:44 AM Bjorn Helgaas wrote: > > On Thu, Jun 13, 2013 at 4:29 PM, Rafael J. Wysocki wrote: > > > From: Rafael J. Wysocki > > > > > > Make acpi_pci_set_power_state

Re: [PATCH] PCI: only WARN_ON() when pci_ioremap_bar() is called for io port BAR

2013-06-16 Thread Bjorn Helgaas
On Fri, Jun 14, 2013 at 8:44 PM, Jiang Liu wrote: > Ideally caller should check availability of IO BAR resource before > calling pci_ioremap_bar(), but no caller doing that yet:( > The WARN_ON() in function pci_ioremap_bar() is used to warn the caller > if it's called for an IO port BAR, so disabl

Re: [PATCH v2 1/3] PCI/AER: Fix incorrect return from aer_hest_parse()

2013-06-04 Thread Bjorn Helgaas
h is that we update info->firmware_first even for non-matching devices. I think we should do something like the following instead: commit c67612f272f1792a08f012f1b5ca37d5cfde5de4 Author: Bjorn Helgaas Date: Mon Jun 3 16:49:12 2013 -0600 PCI/AER: Don't parse HEST table for non-PCIe devic

Re: [PATCH v2 1/3] PCI/AER: Fix incorrect return from aer_hest_parse()

2013-06-04 Thread Bjorn Helgaas
On Mon, Jun 3, 2013 at 3:18 PM, Betty Dall wrote: > On Sat, 2013-06-01 at 18:38 -0600, Bjorn Helgaas wrote: >> [+cc Bob for ACPI HEST spec questions] >> >> On Thu, May 30, 2013 at 8:39 AM, Betty Dall wrote: >> > The function aer_hest_parse() is called to determine i

Re: [PATCH v2 2/3] ACPI/APEI: Force fatal AER severity when bus has been reset

2013-06-04 Thread Bjorn Helgaas
On Tue, Jun 04, 2013 at 03:53:36AM -0400, Chen Gong wrote: > On Thu, May 30, 2013 at 08:39:28AM -0600, Betty Dall wrote: > > Date: Thu, 30 May 2013 08:39:28 -0600 > > From: Betty Dall > > To: r...@sisk.pl, bhelg...@google.com > > Cc: ying.hu...@intel.com, linux-a...@vger.kernel.org, > > lin

Re: Subject : [ PATCH ] pci-reset-error_state-to-pci_channel_io_normal-at-report_slot_reset

2013-06-04 Thread Bjorn Helgaas
I'm not sure where we are with this patch. I think Joseph initially reported a problem (though I haven't actually seen that), and this patch fixed it, so it seems like there's something we want to do here. Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the bod

Re: [PATCH v2 3/3] PCI/AER: Provide reset_link for firmware first root port

2013-06-04 Thread Bjorn Helgaas
On Tue, Jun 4, 2013 at 2:36 AM, Chen Gong wrote: > On Thu, May 30, 2013 at 08:39:29AM -0600, Betty Dall wrote: >> Date: Thu, 30 May 2013 08:39:29 -0600 >> From: Betty Dall >> To: r...@sisk.pl, bhelg...@google.com >> Cc: ying.hu...@intel.com, linux-a...@vger.kernel.org, >> linux-kernel@vger.kerne

Re: [PATCH v2 3/3] PCI/AER: Provide reset_link for firmware first root port

2013-06-04 Thread Bjorn Helgaas
On Tue, Jun 4, 2013 at 3:38 PM, Betty Dall wrote: > On Tue, 2013-06-04 at 04:36 -0400, Chen Gong wrote: >> On Thu, May 30, 2013 at 08:39:29AM -0600, Betty Dall wrote: >> > Date: Thu, 30 May 2013 08:39:29 -0600 >> > From: Betty Dall >> > To: r...@sisk.pl, bhelg...@google.com >> > Cc: ying.hu

Re: [PATCH] pci: add pcibios_release_device

2013-06-04 Thread Bjorn Helgaas
On Tue, Jun 4, 2013 at 11:18 AM, Sebastian Ott wrote: > Hello Bjorn, > > part of your feedback to the PCI support on s390 was to put some smarts in > the config space accessors and let the pci core do the scanning of pci > functions. > To get there I had to implement pcibios_add_device on s390 to

Re: Subject : [ PATCH ] pci-reset-error_state-to-pci_channel_io_normal-at-report_slot_reset

2013-06-05 Thread Bjorn Helgaas
On Tue, Jun 4, 2013 at 6:38 PM, Yanmin Zhang wrote: > On Tue, 2013-06-04 at 12:04 -0600, Bjorn Helgaas wrote: >> I'm not sure where we are with this patch. I think Joseph initially >> reported a problem (though I haven't actually seen that), and this >> patch fix

Re: [PATCH v2 1/3] PCI/AER: Fix incorrect return from aer_hest_parse()

2013-06-05 Thread Bjorn Helgaas
On Tue, Jun 4, 2013 at 8:48 PM, Chen Gong wrote: > On Tue, Jun 04, 2013 at 07:13:24AM -0600, Bjorn Helgaas wrote: >> Date: Tue, 4 Jun 2013 07:13:24 -0600 >> From: Bjorn Helgaas >> To: Betty Dall >> Cc: r...@sisk.pl, ying.hu...@intel.com, linux-a...@vger.k

Re: [PATCH] x86/PCI: setup data may be in highmem

2013-06-05 Thread Bjorn Helgaas
On Wed, Jun 5, 2013 at 8:15 AM, Matt Fleming wrote: > On Tue, 28 May, at 11:28:54AM, Bjorn Helgaas wrote: >> OK, hopefully somebody will do the analysis to verify that ioremap() >> is appropriate in both cases. It seems likely, but I haven't looked >> in detail. > &

Re: [PATCH v3 -tip x86/apic 1/2] PCI/MSI: Allocate as many multiple-MSIs as requested

2013-06-05 Thread Bjorn Helgaas
On Tue, Jun 4, 2013 at 7:14 AM, Alexander Gordeev wrote: > On Mon, Jun 03, 2013 at 02:46:59PM -0600, Bjorn Helgaas wrote: >> On Wed, May 29, 2013 at 2:58 PM, Bjorn Helgaas wrote: >> I pushed these with updates to >> http://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git

Re: [PATCH v3 -tip x86/apic 1/2] PCI/MSI: Allocate as many multiple-MSIs as requested

2013-06-05 Thread Bjorn Helgaas
On Wed, Jun 5, 2013 at 12:33 PM, Konrad Rzeszutek Wilk wrote: > On Wed, Jun 05, 2013 at 11:18:54AM -0600, Bjorn Helgaas wrote: >> On Tue, Jun 4, 2013 at 7:14 AM, Alexander Gordeev >> wrote: >> > On Mon, Jun 03, 2013 at 02:46:59PM -0600, Bjorn Helgaas wrote: >> >

Re: [PATCH v3, part1 04/10] PCI: mark pci_scan_bus_parented() as __deprecated

2013-06-05 Thread Bjorn Helgaas
[+cc Konrad, Jeremy, xen-devel (users of interface you're deprecating)] On Sat, May 25, 2013 at 7:48 AM, Jiang Liu wrote: > Mark pci_scan_bus_parented() as __deprecated and clean up outdated > comments. > > Signed-off-by: Jiang Liu > Cc: Chris Metcalf > Cc: Greg Kroah-Hartman > Cc: Thierry Red

Re: [PATCH v3, part1 03/10] PCI: Convert alloc_pci_dev(void) to pci_alloc_dev(bus) instead

2013-06-05 Thread Bjorn Helgaas
On Sat, May 25, 2013 at 7:48 AM, Jiang Liu wrote: > From: Gu Zheng > > Use the new pci_alloc_dev(bus) to replace the existing using of > alloc_pci_dev(void). > ... > diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c > index 26df9c8..d5d18a0 100644 > --- a/drivers/pci/probe.c > +++ b/drivers

Re: [PATCH v3, part1 06/10] PCI: make PCI host bridge/bus creating and destroying logic symmetric

2013-06-05 Thread Bjorn Helgaas
On Sat, May 25, 2013 at 7:48 AM, Jiang Liu wrote: > This patch makes PCI host bridge/bus creating and destroying logic > symmetric by using device_initialize()/device_add()/device_del()/put_device() > pairs as discussed in thread at: > http://comments.gmane.org/gmane.linux.kernel.pci/22073 > > It

Re: [PATCH v3 -tip x86/apic 1/2] PCI/MSI: Allocate as many multiple-MSIs as requested

2013-06-05 Thread Bjorn Helgaas
On Wed, Jun 5, 2013 at 2:56 PM, Sebastian Andrzej Siewior wrote: > On Mon, May 13, 2013 at 11:05:48AM +0200, Alexander Gordeev wrote: >> Note, although the existing 'msi_desc::multiple' field might seem >> redundant, in fact in does not. In general case the number of MSIs a >> PCI device is initia

Re: [PATCH v3, part1 07/10] PCI, unicore, m68k: remove redundant call of pci_bus_add_devices()

2013-06-05 Thread Bjorn Helgaas
[+cc m68k and unicore32 maintainers] On Sat, May 25, 2013 at 7:48 AM, Jiang Liu wrote: > pci_scan_bus() and pci_scan_root_bus() has called pci_bus_add_devices() > once, so remove the redundant call of pci_bus_add_devices(). > On the other handle, subsys_init() callbacks will be invoked before > d

Re: [GIT PULL] PCI updates for v3.10

2013-06-06 Thread Bjorn Helgaas
[+cc linux-pci, linux-kernel] On Thu, Jun 6, 2013 at 11:34 AM, Bjorn Helgaas wrote: > Hi Linus, > > Here's another fix for v3.10. This fixes a crash when booting a 32-bit > kernel via the EFI boot stub. > > Bjorn > > > The following changes since commit f3f01175

Re: [PATCH v2 4/6] PCI/ACPI: Move AER severity defines to aer.h

2013-06-06 Thread Bjorn Helgaas
On Thu, Jun 6, 2013 at 12:23 PM, Joe Perches wrote: > On Thu, 2013-06-06 at 12:10 -0600, Betty Dall wrote: >> The function aer_recover_queue() is a public interface and the >> severity argument uses #defines that are in the private header >> pci/pcie/aer/aerdrv.h. >> >> This patch moves the #defin

Re: [PATCH v3 0/6] PCI/ACPI: Fix firmware first error recovery with root port in reset

2013-06-06 Thread Bjorn Helgaas
hanges since v1: > Fixed a typo in the comment of patch 2. > Removed incorrect setting of reset bit in patch 3. > > Changes since v2: > The v2 patch 1/3 was re-written by Bjorn Helgaas and is now patches 1/6 > through 3/6. > The v2 patch 2/3 is now 5/6 and changed to directly u

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-06-06 Thread Bjorn Helgaas
Sorry it's taken me so long to look at this. I've been putting this off because the patch doesn't seem "obviously correct," and I don't feel like I really understand the problem. I'm naive about both IOMMUs and kexec/kdump, so please pardon (and help me with) any silly questions or assumptions be

Re: [PATCH v3, part2 14/20] PCI, DRM: use hotplug-safe iterators to walk PCI buses

2013-06-17 Thread Bjorn Helgaas
On Sun, May 26, 2013 at 11:53:11PM +0800, Jiang Liu wrote: > Enhance DRM drvier to use hotplug-safe iterators to walk PCI buses. > > Signed-off-by: Jiang Liu > Cc: David Airlie > Cc: dri-de...@lists.freedesktop.org > Cc: linux-kernel@vger.kernel.org > --- > drivers/gpu/drm/drm_fops.c | 6 --

Re: [PATCH v3, part2 20/20] PCI, ARM: use hotplug-safe PCI bus iterators to walk PCI buses

2013-06-17 Thread Bjorn Helgaas
root_buses list will be scheduled > to be removed. > > Signed-off-by: Jiang Liu > Cc: Russell King > Cc: Thierry Reding > Cc: Bjorn Helgaas > Cc: Greg Kroah-Hartman > Cc: Rob Herring > Cc: linux-arm-ker...@lists.infradead.org > Cc: linux-kernel@vger.kernel.or

Re: [PATCH v3, part2 01/20] PCI: introduce hotplug-safe PCI bus iterators

2013-06-17 Thread Bjorn Helgaas
On Sun, May 26, 2013 at 11:52:58PM +0800, Jiang Liu wrote: > Introduce hotplug-safe PCI bus iterators as below, which hold a > reference on the returned PCI bus object. > bool pci_bus_exists(int domain, int busnr); > struct pci_bus *pci_get_bus(int domain, int busnr); > struct pci_bus *pci_get_next

Re: [PATCH v3, part2 15/20] PCI, EDAC: use hotplug-safe PCI bus iterators to walk PCI buses

2013-06-17 Thread Bjorn Helgaas
On Sun, May 26, 2013 at 11:53:12PM +0800, Jiang Liu wrote: > Enhance EDAC drviers to use hotplug-safe iterators to walk PCI buses. > > Signed-off-by: Jiang Liu > Cc: Mauro Carvalho Chehab > Cc: Doug Thompson > Cc: linux-e...@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > --- > drivers/ed

Re: [PATCH v3, part2 17/20] PCI, iommu: use hotplug-safe iterators to walk PCI buses

2013-06-17 Thread Bjorn Helgaas
On Sun, May 26, 2013 at 11:53:14PM +0800, Jiang Liu wrote: > Enhance iommu drviers to use hotplug-safe iterators to walk > PCI buses. > > Signed-off-by: Jiang Liu > Cc: Joerg Roedel > Cc: Ingo Molnar > Cc: Donald Dutile > Cc: Hannes Reinecke > Cc: "Li, Zhen-Hua" > Cc: io...@lists.linux-found

Re: [PATCH v2 1/2] pci: Fix flaw in pci_acs_enabled()

2013-06-18 Thread Bjorn Helgaas
On Fri, Jun 07, 2013 at 10:34:41AM -0600, Alex Williamson wrote: > Downstream ports support for all ACS flags supercedes multifunction > exclusion of some flags. The PCIe spec also fully specifies which > PCIe types are subject to the multifunction rules and excludes event > collectors and PCIe-to

Re: [PATCH] pci: Enable overrides for missing ACS capabilities

2013-06-18 Thread Bjorn Helgaas
On Thu, May 30, 2013 at 12:40:19PM -0600, Alex Williamson wrote: > PCIe ACS (Access Control Services) is the PCIe 2.0+ feature that > allows us to control whether transactions are allowed to be redirected > in various subnodes of a PCIe topology. For instance, if two > endpoints are below a root p

Re: [PATCH 7/9] PCI: use pdev->pm_cap instead of pci_find_capability(..,PCI_CAP_ID_PM)

2013-06-18 Thread Bjorn Helgaas
On Tue, Jun 18, 2013 at 7:44 AM, Rafael J. Wysocki wrote: > On Tuesday, June 18, 2013 04:22:14 PM Yijing Wang wrote: >> Pci pm cap register offset has been saved in pci_pm_init(), >> so we can use pdev->pm_cap instead of using pci_find_capability(..) >> here. >> >> Signed-off-by: Yijing Wang >> C

Re: [PATCH] pci: Enable overrides for missing ACS capabilities

2013-06-18 Thread Bjorn Helgaas
On Tue, Jun 18, 2013 at 12:20 PM, Alex Williamson wrote: > On Tue, 2013-06-18 at 11:28 -0600, Bjorn Helgaas wrote: >> On Thu, May 30, 2013 at 12:40:19PM -0600, Alex Williamson wrote: >> > PCIe ACS (Access Control Services) is the PCIe 2.0+ feature that >> > a

Re: [PATCH v2 1/2] pci: Fix flaw in pci_acs_enabled()

2013-06-18 Thread Bjorn Helgaas
On Tue, Jun 18, 2013 at 12:38 PM, Alex Williamson wrote: > On Tue, 2013-06-18 at 11:09 -0600, Bjorn Helgaas wrote: >> On Fri, Jun 07, 2013 at 10:34:41AM -0600, Alex Williamson wrote: >> > Downstream ports support for all ACS flags supercedes multifunction >> > exclusi

Re: [PATCH v2 1/2] pci: Fix flaw in pci_acs_enabled()

2013-06-18 Thread Bjorn Helgaas
On Tue, Jun 18, 2013 at 4:47 PM, Alex Williamson wrote: > On Tue, 2013-06-18 at 16:10 -0600, Bjorn Helgaas wrote: >> On Tue, Jun 18, 2013 at 12:38 PM, Alex Williamson >> wrote: >> > On Tue, 2013-06-18 at 11:09 -0600, Bjorn Helgaas wrote: >> >> On Fri, Ju

Re: [PATCH] pci: Enable overrides for missing ACS capabilities

2013-06-18 Thread Bjorn Helgaas
On Tue, Jun 18, 2013 at 5:03 PM, Don Dutile wrote: > On 06/18/2013 06:22 PM, Alex Williamson wrote: >> >> On Tue, 2013-06-18 at 15:31 -0600, Bjorn Helgaas wrote: >>> >>> On Tue, Jun 18, 2013 at 12:20 PM, Alex Williamson >>> wrote: >>>> >&

Re: [PATCH] xen-pciback: more uses of cached MSI-X capability offset

2013-05-29 Thread Bjorn Helgaas
On Wed, May 29, 2013 at 6:31 AM, Jan Beulich wrote: > Signed-off-by: Jan Beulich > > --- > drivers/xen/xen-pciback/pci_stub.c |4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Acked-by: Bjorn Helgaas I assume you'll take this, Konrad. Let me know if you ne

Re: [PATCH v3 -tip x86/apic 1/2] PCI/MSI: Allocate as many multiple-MSIs as requested

2013-05-29 Thread Bjorn Helgaas
[-cc Suresh] On Wed, May 29, 2013 at 2:36 AM, Alexander Gordeev wrote: > On Tue, May 28, 2013 at 03:51:52PM -0600, Bjorn Helgaas wrote: >> On Mon, May 13, 2013 at 3:05 AM, Alexander Gordeev >> wrote: >> >> The subject would make more sense as "Allocate *on

[PATCH] bio-integrity: Fix use of bs->bio_integrity_pool after free

2013-05-29 Thread Bjorn Helgaas
This fixes a copy and paste error introduced by 9f060e2231 ("block: Convert integrity to bvec_alloc_bs()"). Found by Coverity (CID 1020654). Signed-off-by: Bjorn Helgaas --- fs/bio-integrity.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/bio-integrity.

Re: [PATCH v1 2/2] ACPI, pci_root: use acpi_handle_print() and pr_xxx() to print messages

2013-05-30 Thread Bjorn Helgaas
On Tue, May 14, 2013 at 09:00:39PM +0800, Jiang Liu wrote: > Use acpi_handle_print() and pr_xxx() to print messages in pci_root.c. > > Signed-off-by: Jiang Liu > Cc: Len Brown > Cc: "Rafael J. Wysocki" > Cc: linux-a...@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > --- > drivers/acpi/pci

Re: [PATCH] PCI: set correct value for iov device before device

2013-05-30 Thread Bjorn Helgaas
On Thu, May 30, 2013 at 2:27 PM, Yinghai Lu wrote: > On Wed, May 29, 2013 at 11:04 PM, Yinghai Lu wrote: >> On Wed, May 29, 2013 at 10:45 PM, Xudong Hao wrote: >>> Since device registering is put into pci_device_add(), it must set value of >>> Virtual Function device's member before the pci_dev

Re: [PATCH v1 2/2] ACPI, pci_root: use acpi_handle_print() and pr_xxx() to print messages

2013-05-31 Thread Bjorn Helgaas
On Fri, May 31, 2013 at 10:20 AM, Jiang Liu wrote: > On Fri 31 May 2013 03:51:51 AM CST, Rafael J. Wysocki wrote: >> On Thursday, May 30, 2013 11:33:56 AM Bjorn Helgaas wrote: >>> On Tue, May 14, 2013 at 09:00:39PM +0800, Jiang Liu wrote: >>>> Use acpi_handle

Re: [PATCH v2 1/3] PCI/AER: Fix incorrect return from aer_hest_parse()

2013-06-01 Thread Bjorn Helgaas
[+cc Bob for ACPI HEST spec questions] On Thu, May 30, 2013 at 8:39 AM, Betty Dall wrote: > The function aer_hest_parse() is called to determine if the given > PCI device is firmware first or not. The code loops through each > section of the HEST table to look for a match. The bug is that > the f

Re: [PATCH v3 -tip x86/apic 1/2] PCI/MSI: Allocate as many multiple-MSIs as requested

2013-06-03 Thread Bjorn Helgaas
On Wed, May 29, 2013 at 2:58 PM, Bjorn Helgaas wrote: > [-cc Suresh] > > On Wed, May 29, 2013 at 2:36 AM, Alexander Gordeev > wrote: >> On Tue, May 28, 2013 at 03:51:52PM -0600, Bjorn Helgaas wrote: >>> On Mon, May 13, 2013 at 3:05 AM, Alexander Gordeev >>&

Re: linux-next: manual merge of the pci tree with Linus' tree

2013-06-03 Thread Bjorn Helgaas
On Mon, Jun 3, 2013 at 7:49 PM, Stephen Rothwell wrote: > Hi Bjorn, > > Today's linux-next merge of the pci tree got a conflict in > drivers/acpi/pci_root.c between commit 3f327e39b4b8 ("PCI: acpiphp: > Re-enumerate devices when host bridge receives Bus Check") from Linus' > tree and commit 6dc7d2

Re: [PATCH v2 1/2] pci: Fix flaw in pci_acs_enabled()

2013-06-24 Thread Bjorn Helgaas
On Thu, Jun 20, 2013 at 3:43 PM, Alex Williamson wrote: > On Tue, 2013-06-18 at 20:30 -0600, Bjorn Helgaas wrote: >> On Tue, Jun 18, 2013 at 4:47 PM, Alex Williamson >> wrote: >> > On Tue, 2013-06-18 at 16:10 -0600, Bjorn Helgaas wrote: >> >> On Tue, Jun 1

Re: [PATCH] pci: Enable overrides for missing ACS capabilities

2013-06-24 Thread Bjorn Helgaas
On Wed, Jun 19, 2013 at 6:43 AM, Don Dutile wrote: > On 06/18/2013 10:52 PM, Bjorn Helgaas wrote: >> >> On Tue, Jun 18, 2013 at 5:03 PM, Don Dutile wrote: >>> >>> On 06/18/2013 06:22 PM, Alex Williamson wrote: >>>> >>>> &g

Re: [PATCH] PCI: avoid NULL deref in alloc_pcie_link_state

2013-06-24 Thread Bjorn Helgaas
[+cc Michael, Alex, Isaku] On Wed, Jun 19, 2013 at 12:56 PM, Radim Krčmář wrote: > PCIe switch upstream port can be connected directly to the PCIe root bus > in QEMU; ASPM does not expect this topology and dereferences NULL pointer > when initializing. > > I have not confirmed this can happen on

Re: [PATCH V10 1/4] pci: Add PCIe driver for Samsung Exynos

2013-06-24 Thread Bjorn Helgaas
> Signed-off-by: Jingoo Han > Acked-by: Arnd Bergmann Acked-by: Bjorn Helgaas Please merge this through arm-soc as you discussed. > --- > .../devicetree/bindings/pci/designware-pcie.txt| 73 ++ > drivers/pci/host/Kconfig |9

Re: [PATCH] PCI: avoid NULL deref in alloc_pcie_link_state

2013-06-24 Thread Bjorn Helgaas
On Mon, Jun 24, 2013 at 8:58 PM, Alex Williamson wrote: > On Mon, 2013-06-24 at 19:38 -0600, Bjorn Helgaas wrote: >> [+cc Michael, Alex, Isaku] >> >> On Wed, Jun 19, 2013 at 12:56 PM, Radim Krčmář wrote: >> > PCIe switch upstream port can be connected directly to

Re: [PATCH] PCI: avoid NULL deref in alloc_pcie_link_state

2013-06-25 Thread Bjorn Helgaas
On Tue, Jun 25, 2013 at 5:23 AM, Michael S. Tsirkin wrote: > On Mon, Jun 24, 2013 at 07:38:45PM -0600, Bjorn Helgaas wrote: >> [+cc Michael, Alex, Isaku] >> >> On Wed, Jun 19, 2013 at 12:56 PM, Radim Krčmář wrote: >> > PCIe switch upstream port can be connected

Re: [PATCH v3 -tip x86/apic 1/2] PCI/MSI: Allocate as many multiple-MSIs as requested

2013-06-25 Thread Bjorn Helgaas
On Thu, Jun 20, 2013 at 6:51 AM, Joerg Roedel wrote: > On Mon, Jun 03, 2013 at 02:46:59PM -0600, Bjorn Helgaas wrote: >> I pushed these with updates to >> http://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git/log/?h=pci/alexander-msi >> >> Anybody want to ack the

Re: [PATCH v5 3/7] PCI: Use pci_walk_bus to detect unassigned resources

2013-06-25 Thread Bjorn Helgaas
On Fri, May 31, 2013 at 11:03:08PM -0700, Yinghai Lu wrote: > Per Bjorn, use pci_walk_bus instead of for_each_pci_dev or > calling pci_realloc_detect() recursively, that will make code more readable. > > Per Bjorn, separate it from big patch that handing assign_unssigned per root > bus. > > Sign

Re: [PATCH v5 3/7] PCI: Use pci_walk_bus to detect unassigned resources

2013-06-25 Thread Bjorn Helgaas
On Tue, Jun 25, 2013 at 3:38 PM, Benjamin Herrenschmidt wrote: > On Tue, 2013-06-25 at 15:15 -0600, Bjorn Helgaas wrote: >> - for_each_pci_dev(dev) { >> > - int i; >> > + /* Not assigned, or rejected by kernel ? */ >> > +

Re: [PATCH 8/8] pch_gbe: Add MinnowBoard support

2013-06-25 Thread Bjorn Helgaas
On Tue, Jun 25, 2013 at 7:53 PM, Darren Hart wrote: > The MinnowBoard uses an AR803x PHY with the PCH GBE. > > It does not implement the RGMII 2ns TX clock delay in the trace routing > nor via strapping. Add a detection method for the board and the PHY and > enable the tx clock delay via the regis

Re: [PATCH v3, part2 01/20] PCI: introduce hotplug-safe PCI bus iterators

2013-06-25 Thread Bjorn Helgaas
On Thu, Jun 20, 2013 at 10:18 AM, Jiang Liu wrote: > On 06/18/2013 04:06 AM, Bjorn Helgaas wrote: >> On Sun, May 26, 2013 at 11:52:58PM +0800, Jiang Liu wrote: >>> Introduce hotplug-safe PCI bus iterators as below, which hold a >>> reference on the returned PCI bus obje

Re: [PATCH v3, part2 15/20] PCI, EDAC: use hotplug-safe PCI bus iterators to walk PCI buses

2013-06-25 Thread Bjorn Helgaas
On Tue, Jun 18, 2013 at 10:33 AM, Jiang Liu wrote: > On 06/18/2013 04:18 AM, Bjorn Helgaas wrote: >> On Sun, May 26, 2013 at 11:53:12PM +0800, Jiang Liu wrote: >>> Enhance EDAC drviers to use hotplug-safe iterators to walk PCI buses. >>> >>> Signed-off-by: Jian

Re: [PATCH RFC] pci: ACS quirk for AMD southbridge

2013-06-25 Thread Bjorn Helgaas
On Wed, Jul 11, 2012 at 11:18 PM, Alex Williamson wrote: > We've confirmed that peer-to-peer between these devices is > not possible. We can therefore claim that they support a > subset of ACS. > > Signed-off-by: Alex Williamson > Cc: Joerg Roedel > --- > > Two things about this patch make me a

Re: [PATCH RFC] pci: ACS quirk for AMD southbridge

2013-06-25 Thread Bjorn Helgaas
[fix Joerg's email address] On Tue, Jun 25, 2013 at 10:15 PM, Bjorn Helgaas wrote: > On Wed, Jul 11, 2012 at 11:18 PM, Alex Williamson > wrote: >> We've confirmed that peer-to-peer between these devices is >> not possible. We can therefore claim that the

Re: [PATCH v3, part1 04/10] PCI: mark pci_scan_bus_parented() as __deprecated

2013-06-07 Thread Bjorn Helgaas
On Fri, Jun 7, 2013 at 9:30 AM, Jiang Liu wrote: > On 06/07/2013 10:37 PM, Konrad Rzeszutek Wilk wrote: >> On Fri, Jun 07, 2013 at 12:32:28AM +0800, Jiang Liu wrote: >>> On Thu 06 Jun 2013 04:04:36 AM CST, Bjorn Helgaas wrote: >>>> [+cc Konrad, Jeremy, xen-de

Re: [PATCH] arch: asm-geniric: for atomic_set_mask() 1st param, use 'unsigned int' instead of 'unsigned long'

2013-06-08 Thread Bjorn Helgaas
s/geniric/generic/ in subject -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] arch: asm-geniric: for atomic_set_mask() 1st param, use 'unsigned int' instead of 'unsigned long'

2013-06-10 Thread Bjorn Helgaas
On Sat, Jun 8, 2013 at 7:52 PM, Chen Gang wrote: > On 06/09/2013 01:49 AM, Bjorn Helgaas wrote: >> s/geniric/generic/ in subject >> > > Could you provide more details information ? In your subject line, "geniric" is spelled incorrectly. The correct spelling is &q

Re: Subject : [ PATCH ] pci-reset-error_state-to-pci_channel_io_normal-at-report_slot_reset

2013-06-10 Thread Bjorn Helgaas
that means for pcie_portdrv_slot_reset(), which restores the device state if it is frozen. Bjorn On Thu, Jun 6, 2013 at 12:29 AM, Yanmin Zhang wrote: > On Wed, 2013-06-05 at 07:30 -0600, Bjorn Helgaas wrote: >> On Tue, Jun 4, 2013 at 6:38 PM, Yanmin Zhang >> wrote: >> >

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-06-10 Thread Bjorn Helgaas
On Fri, Jun 7, 2013 at 2:46 AM, Takao Indoh wrote: > (2013/06/07 13:14), Bjorn Helgaas wrote: >> One thing I'm not sure about is that you are only resetting PCIe >> devices, but I don't think the problem is actually specific to PCIe, >> is it? I think the same

Re: [PATCH] dma-mapping: Add BUG_ON for uninitialized dma_ops

2013-06-10 Thread Bjorn Helgaas
[+cc Marek] On Mon, Jun 3, 2013 at 6:44 AM, Michal Simek wrote: > Check that dma_ops are initialized correctly. > > Signed-off-by: Michal Simek > --- > Functions dma_mmap_attrs(), dma_get_sgtable_attrs() > already have this checking. > > --- > include/asm-generic/dma-mapping-common.h | 12 +

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-06-11 Thread Bjorn Helgaas
[Your quoting is messed up below] >> This is Takao's text > This is Bill's text On Tue, Jun 11, 2013 at 5:19 PM, Sumner, William wrote: >>(2013/06/11 11:20), Bjorn Helgaas wrote: >>> On Fri, Jun 7, 2013 at 2:46 AM, Takao Indoh >>> wrote: >>

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-06-11 Thread Bjorn Helgaas
[+cc Vivek, Haren; sorry I didn't think to add you earlier] On Tue, Jun 11, 2013 at 12:08 AM, Takao Indoh wrote: > (2013/06/11 11:20), Bjorn Helgaas wrote: >> I'm not sure you need to reset legacy devices (or non-PCI devices) >> yet, but the current hook isn't anc

[GIT PULL] PCI changes for v3.11

2013-07-01 Thread Bjorn Helgaas
- Reset link below Root Port as well as Downstream Port (Betty Dall) - Fix "Firmware first" flag setting (Bjorn Helgaas) - Don't parse HEST for non-PCIe devices (Bjorn Helgaas) ASPM - Warn when we can't disable ASPM as driver requests (Bjorn Helgaas) Miscellaneo

Re: [PATCH 1/3] ACPI / dock: Rework the handling of notifications

2013-07-01 Thread Bjorn Helgaas
On Fri, Jun 28, 2013 at 4:53 PM, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > The ACPI dock driver uses register_acpi_bus_notifier() which > installs a notifier triggered globally for all system notifications. > That first of all is inefficient, because the dock driver is only > interes

Re: [PATCH 1/6] PCI: acpiphp: do not check for SLOT_ENABLED in enable_device()

2013-07-02 Thread Bjorn Helgaas
On Mon, Jul 1, 2013 at 7:29 PM, Rafael J. Wysocki wrote: > On Monday, July 01, 2013 09:36:13 PM Mika Westerberg wrote: >> On Mon, Jul 01, 2013 at 04:01:37PM +0200, Rafael J. Wysocki wrote: >> > > Given the fact that SLOT_ENABLED is only checked in acpiphp_enable_slot() >> > > (after this patch) an

Re: [PATCH 5/6] PCI: acpiphp: look _RMV method a bit deeper in the hierarhcy

2013-07-02 Thread Bjorn Helgaas
On Tue, Jul 2, 2013 at 4:44 AM, Kirill A. Shutemov wrote: > Mika Westerberg wrote: >> The acpiphp driver finds out whether the device is hotpluggable by checking >> whether it has _RMV method behind it (and if it returns 1). However, at >> least Acer Aspire S5 with Thunderbolt host router has this

Re: Build regressions/improvements in v3.10

2013-07-02 Thread Bjorn Helgaas
On Tue, Jul 2, 2013 at 11:12 AM, Geert Uytterhoeven wrote: > Below is the list of build error/warning regressions/improvements in > v3.10[1] compared to v3.9[2]. Thanks for doing this! > + warning: vmlinux.o(.text+0x1ad7a4): Section mismatch in reference from > the function pwmchip_add() to t

Re: [PATCH 0/8] PCI, ACPI, x86: Reserve fw allocated resource for hot-add root bus

2013-07-02 Thread Bjorn Helgaas
On Wed, Jan 9, 2013 at 11:39 AM, Bjorn Helgaas wrote: > On Wed, Jan 9, 2013 at 10:53 AM, Yinghai Lu wrote: >> the reason why we need to change those codes for x86, we want to make it >> support >> pci root bus hotplug. So it would be reasonable for us to align oth

Re: Build regressions/improvements in v3.10

2013-07-02 Thread Bjorn Helgaas
On Tue, Jul 2, 2013 at 3:29 PM, Geert Uytterhoeven wrote: > On Tue, Jul 2, 2013 at 8:34 PM, Bjorn Helgaas wrote: >>> + warning: vmlinux.o(.text+0x1ad7a4): Section mismatch in reference from >>> the function pwmchip_add() to the function .init.text:pcibios_fixu

Re: [PATCH 2/3] doc: add the description for pci=hide kernel parameter.

2013-07-03 Thread Bjorn Helgaas
On Wed, Jul 3, 2013 at 9:16 AM, Haicheng Li wrote: > Cc: Rob Landley > Cc: linux-...@vger.kernel.org > Cc: linux-...@vger.kernel.org > Signed-off-by: Haicheng Li > --- > Documentation/kernel-parameters.txt |2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/kernel-parame

Re: [PATCH 1/3] PCI: Add hide_device support to pci subsystem.

2013-07-03 Thread Bjorn Helgaas
firmware than to add kludges in the kernel. > To hide pci devices, just pass such parameters to kernel at boot stage: > pci=hide=[:]:.[; ...] > > Cc: Bjorn Helgaas > Cc: linux-...@vger.kernel.org > Signed-off-by: Haicheng Li > --- > drivers/pc

Re: [PATCH v2 6/8] PCI: acpiphp: workaround for Thunderbolt on Acer Aspire S5

2013-07-03 Thread Bjorn Helgaas
On Wed, Jul 3, 2013 at 8:04 AM, Mika Westerberg wrote: > From: "Kirill A. Shutemov" > > Correct ACPI PCI hotplug imeplementation should have _RMV method in a > PCI slot (device under pci bridge). In Acer Aspire S5 case we have it > deeper in hierarchy: > > Device (RP05) > { >// ... >Devic

Re: [PATCH 1/3] PCI: Add hide_device support to pci subsystem.

2013-07-05 Thread Bjorn Helgaas
On Wed, Jul 3, 2013 at 10:53 PM, Haicheng Li wrote: > On Wed, Jul 03, 2013 at 10:09:32AM -0600, Bjorn Helgaas wrote: >> On Wed, Jul 3, 2013 at 9:16 AM, Haicheng Li >> wrote: >> > With more and more SOCs having pci device integrated into chip (e.g. Intel >> > At

Re: [PATCH] pci: Avoid unnecessary calls to work_on_cpu

2013-07-05 Thread Bjorn Helgaas
[+cc Rusty] On Mon, Jun 24, 2013 at 2:05 PM, Alexander Duyck wrote: > This patch is meant to address the fact that we are making unnecessary calls > to work_on_cpu. To resolve this I have added a check to see if the current > node is the correct node for the device before we decide to assign the

Re: [PATCH] arch: frv: mb93090-mb00: remove '__init' for pci_fixup_umc_ide() which used by 'DECLARE_PCI_FIXUP_HEADER'

2013-06-26 Thread Bjorn Helgaas
t may be used outside an exit section. > > > Signed-off-by: Chen Gang Reviewed-by: Bjorn Helgaas > --- > arch/frv/mb93090-mb00/pci-vdk.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/frv/mb93090-mb00/pci-vdk.c b/arch/frv/mb93090-mb00/p

Re: [PATCH 7/8] pci: Add CircuitCo VENDOR ID and MinnowBoard DEVICE ID

2013-06-26 Thread Bjorn Helgaas
On Tue, Jun 25, 2013 at 06:53:27PM -0700, Darren Hart wrote: > Add CircuitCo's newly created VENDOR ID and their first board subsystem > ID for the MinnowBoard. > > Signed-off-by: Darren Hart > Cc: Bjorn Helgaas > Cc: David Anders > Cc: "H. Peter Anvin"

Re: [PATCH 7/8] pci: Add CircuitCo VENDOR ID and MinnowBoard DEVICE ID

2013-06-26 Thread Bjorn Helgaas
On Wed, Jun 26, 2013 at 11:15 AM, Darren Hart wrote: > On Wed, 2013-06-26 at 10:32 -0600, Bjorn Helgaas wrote: >> +#define PCI_VENDOR_ID_CIRCUITCO 0x1cc8 >> + >> #define PCI_VENDOR_ID_TEKRAM 0x1de1 >> #define PCI_DEVICE_ID_TEKRAM_DC290 0xdc29

Re: [PATCH 0/6] Thunderbolt workarounds take 2

2013-06-26 Thread Bjorn Helgaas
drivers/pci/pcie/portdrv_acpi.c drivers/pci/pci-acpi.c commit 961e3992849e18f9ed6cbcac5c54fb29925341b3 Author: Bjorn Helgaas Date: Wed Jun 26 13:38:37 2013 -0600 MAINTAINERS: Add ACPI folks for ACPI-related things under drivers/pci Add file patterns so get_maintainers.pl rep

Re: [PATCH 0/6] Thunderbolt workarounds take 2

2013-06-26 Thread Bjorn Helgaas
On Wed, Jun 26, 2013 at 2:01 PM, Rafael J. Wysocki wrote: > On Wednesday, June 26, 2013 01:48:39 PM Bjorn Helgaas wrote: >> On Wed, Jun 26, 2013 at 02:45:40PM +0200, Rafael J. Wysocki wrote: >> > On Wednesday, June 26, 2013 10:25:36 AM Mika Westerberg wrote: >> > >

Re: [PATCH 6/6] x86/PCI: quirk Thunderbolt PCI-to-PCI bridges

2013-06-26 Thread Bjorn Helgaas
[+cc Alex] On Wed, Jun 26, 2013 at 6:17 AM, Mika Westerberg wrote: > On Tue, Jun 25, 2013 at 02:15:56PM -0700, Jesse Barnes wrote: >> On Tue, 25 Jun 2013 19:22:10 +0300 >> Mika Westerberg wrote: >> >> > + if (!(pci_probe & PCI_NOASSIGN_ROMS)) { >> > + pr_info("Thunderbolt host router

Re: [PATCH 7/8] pci: Add CircuitCo VENDOR ID and MinnowBoard DEVICE ID

2013-06-26 Thread Bjorn Helgaas
On Wed, Jun 26, 2013 at 02:16:56PM -0700, Darren Hart wrote: > On Wed, 2013-06-26 at 13:37 -0600, Bjorn Helgaas wrote: > > On Wed, Jun 26, 2013 at 11:15 AM, Darren Hart > > wrote: > > > On Wed, 2013-06-26 at 10:32 -0600, Bjorn Helgaas wrote: > > > >

Re: [PATCH 7/8] pci: Add CircuitCo VENDOR ID and MinnowBoard DEVICE ID

2013-06-26 Thread Bjorn Helgaas
On Wed, Jun 26, 2013 at 3:30 PM, H. Peter Anvin wrote: > On 06/26/2013 12:37 PM, Bjorn Helgaas wrote: >> >> Yeah, that's what I was thinking. >> >> But Peter's comment makes more sense to me now. The spec refers to >> that config register as "Su

Re: [PATCH 6/6] x86/PCI: quirk Thunderbolt PCI-to-PCI bridges

2013-06-26 Thread Bjorn Helgaas
On Tue, Jun 25, 2013 at 10:22 AM, Mika Westerberg wrote: > Thunderbolt PCI-to-PCI bridges typically use BIOS "assisted" enumeration. > This means that the BIOS will allocate bridge resources based on some > assumptions of a maximum Thunderbolt chain. It also disables native PCIe > hotplug of the r

Re: [PATCH 6/6] x86/PCI: quirk Thunderbolt PCI-to-PCI bridges

2013-06-26 Thread Bjorn Helgaas
On Wed, Jun 26, 2013 at 4:31 PM, Yinghai Lu wrote: > On Wed, Jun 26, 2013 at 3:26 PM, Yinghai Lu wrote: >> On Wed, Jun 26, 2013 at 3:18 PM, Bjorn Helgaas wrote: >>> On Tue, Jun 25, 2013 at 10:22 AM, Mika Westerberg >>> wrote: >>>> Thunderbolt PCI-to-P

Re: [PATCH v2 7/9] ACPI: simplify dock driver with new interfaces

2013-06-26 Thread Bjorn Helgaas
On Wed, Jun 26, 2013 at 10:30 AM, Jiang Liu wrote: > From: Jiang Liu > > Use new helper functions to simpilify ACPI dock driver. s/simpilify/simplify/ I noticed this spelling error in other places, too, some in subject lines. Very nice cleanups overall. > Signed-off-by: Jiang Liu > Cc: Jiang

Re: [PATCH 1/6] PCI: acpiphp: do not check for SLOT_ENABLED in enable_device()

2013-06-26 Thread Bjorn Helgaas
On Tue, Jun 25, 2013 at 10:22 AM, Mika Westerberg wrote: > From: "Kirill A. Shutemov" > > With Thunderbolt you can chain devices: connect a new devices to plugged > one. In this case the slot is already enabled, but we still want to look > for new devices behind it. > > We're going to reuse enabl

Re: [PATCH 2/6] PCI: acpiphp: enable_device(): rescan even if no new devices on slot

2013-06-26 Thread Bjorn Helgaas
On Tue, Jun 25, 2013 at 10:22 AM, Mika Westerberg wrote: > From: "Kirill A. Shutemov" > > pci_scan_slot() returns number of new devices connected *directly* > connected to the slot. Current enable_device() checks the return value > and stops if it doesn't see a new device. > > In Thunderbolt chai

Re: [PATCH 6/6] x86/PCI: quirk Thunderbolt PCI-to-PCI bridges

2013-06-27 Thread Bjorn Helgaas
On Wed, Jun 26, 2013 at 5:56 PM, Yinghai Lu wrote: > On Wed, Jun 26, 2013 at 3:55 PM, Bjorn Helgaas wrote: >> On Wed, Jun 26, 2013 at 4:31 PM, Yinghai Lu wrote: >>> On Wed, Jun 26, 2013 at 3:26 PM, Yinghai Lu wrote: >>>> On Wed, Jun 26, 2013 at 3:18 PM, Bjorn Hel

Re: [PATCH 2/6] PCI: acpiphp: enable_device(): rescan even if no new devices on slot

2013-06-27 Thread Bjorn Helgaas
On Thu, Jun 27, 2013 at 10:32 AM, Mika Westerberg wrote: > On Thu, Jun 27, 2013 at 04:02:29PM +0300, Mika Westerberg wrote: >> On Wed, Jun 26, 2013 at 05:37:58PM -0600, Bjorn Helgaas wrote: >> > > @@ -707,8 +702,11 @@ static int __ref enable_device(struct acpip

Re: [PATCH 2/6] PCI: acpiphp: enable_device(): rescan even if no new devices on slot

2013-06-27 Thread Bjorn Helgaas
On Thu, Jun 27, 2013 at 10:32 AM, Mika Westerberg wrote: > On Thu, Jun 27, 2013 at 04:02:29PM +0300, Mika Westerberg wrote: >> On Wed, Jun 26, 2013 at 05:37:58PM -0600, Bjorn Helgaas wrote: >> > > @@ -707,8 +702,11 @@ static int __ref enable_device(struct acpip

Re: [PATCH 1/6] PCI: acpiphp: do not check for SLOT_ENABLED in enable_device()

2013-06-28 Thread Bjorn Helgaas
On Fri, Jun 28, 2013 at 3:51 AM, Kirill A. Shutemov wrote: > Bjorn Helgaas wrote: >> On Tue, Jun 25, 2013 at 10:22 AM, Mika Westerberg >> wrote: >> > From: "Kirill A. Shutemov" >> > >> > With Thunderbolt you can chain devices: connect a new d

Re: [PATCH v3 10/10] ACPI: simplify acpiphp driver with new helper functions

2013-06-28 Thread Bjorn Helgaas
On Fri, Jun 28, 2013 at 10:24 AM, Jiang Liu wrote: > From: Jiang Liu > > Use new helper functions to simplify acpiphp driver. > > Signed-off-by: Jiang Liu Acked-by: Bjorn Helgaas I assume this will be merged via linux-pm with the rest of the series. > Cc: Jiang Liu &

Re: [PATCH] pciehp: Add pciehp_surprise module option

2013-03-25 Thread Bjorn Helgaas
On Wed, Mar 20, 2013 at 8:02 AM, Takashi Iwai wrote: > We encountered a problem that on some HP machines the Realtek PCI-e > card reader device appears only when you inserted a card before the > cold boot. While debugging, it turned out that the device is actually > handled via PCI-e hotplug in s

Re: [PATCH] pci: Add probe functions for bus and slot reset

2013-08-14 Thread Bjorn Helgaas
On Wed, Aug 14, 2013 at 2:06 PM, Alex Williamson wrote: > Users of pci_reset_bus() and pci_reset_slot() need a way to probe > whether the bus or slot supports reset. Add trivial helper functions > and export them as vfio-pci will make use of these. > > Signed-off-by: Alex Williamson > --- > > Th

<    1   2   3   4   5   6   7   8   9   10   >