Re: [Resend][PATCH] pciehp: always implement resume

2012-09-07 Thread Bjorn Helgaas
+cc Mark & Kristen Commit cd2fe83a815 by Mark added the code we're changing here, so this is your chance to speak up if we're not doing the right thing :) On Fri, Sep 7, 2012 at 4:28 PM, Bjorn Helgaas wrote: > On Fri, Sep 7, 2012 at 2:28 PM, Rafael J. Wysocki wrote: >&

Re: [Resend][PATCH] pciehp: always implement resume

2012-09-07 Thread Bjorn Helgaas
[fix Kristen's email addr] On Fri, Sep 7, 2012 at 5:33 PM, Bjorn Helgaas wrote: > +cc Mark & Kristen > > Commit cd2fe83a815 by Mark added the code we're changing here, so this > is your chance to speak up if we're not doing the right thing :) > > On Fri,

Re: [PATCH 1/2] PCI: Use local parameter pci_device_id for pci_get_subsys/class()

2012-09-08 Thread Bjorn Helgaas
fix it and make it eligible for calling forom atomic context. Do the same change for the pci_get_class() as suggested by Bjorn Helgaas [bhelgaas: changelog, clear pci_device_id on stack with memset()] Bisected-by: Fengguang Wu Signed-off-by: Feng Tang Signed-o

Re: [PATCH 1/1] PCI: fix on-stack pci_device_id's

2012-09-10 Thread Bjorn Helgaas
w we could initialize members of a structure on the stack, but I didn't know C guaranteed that uninitialized members would be implicitly initialized also. But apparently it does: http://stackoverflow.com/questions/10828294/c-and-c-partial-initialization-of-automatic-structure > Signed-off-by

Re: [PATCH 3/5] PCI: hotplug: remove acpi_bus_generate_proc_event

2012-09-10 Thread Bjorn Helgaas
On Sun, Sep 2, 2012 at 6:03 PM, Davidlohr Bueso wrote: > Calling this function no longer makes sense as /proc/acpi/event > is being removed. > > Signed-off-by: Davidlohr Bueso Acked-by: Bjorn Helgaas I assume this series will be applied as a group somewhere other than the PCI t

Re: [PATCH 1/1] PCI: fix on-stack pci_device_id's

2012-09-10 Thread Bjorn Helgaas
On Mon, Sep 10, 2012 at 4:55 PM, Fengguang Wu wrote: > On Mon, Sep 10, 2012 at 02:44:32PM -0600, Bjorn Helgaas wrote: >> On Mon, Sep 10, 2012 at 1:36 PM, Jiri Slaby wrote: >> > Commit "PCI: Use pci_device_id on stack for pci_get_subsys/class() to >> > avoid kmal

Re: [PATCH] PCI: drop duplicate const in DECLARE_PCI_FIXUP_SECTION

2012-09-10 Thread Bjorn Helgaas
On Sun, Sep 9, 2012 at 10:54 AM, Mathias Krause wrote: > On Sun, Sep 2, 2012 at 11:37 PM, Mathias Krause > wrote: >> It's redundant and makes sparse complain about it. >> >> Signed-off-by: Mathias Krause >> --- >> include/linux/pci.h |2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH v2 RESEND] Add NumaChip remote PCI support

2012-11-30 Thread Bjorn Helgaas
On Thu, Nov 29, 2012 at 10:28 PM, Daniel J Blueman wrote: > Hi Bjorn, > > > On 29/11/2012 07:08, Bjorn Helgaas wrote: >> >> On Wed, Nov 21, 2012 at 1:39 AM, Daniel J Blueman >> wrote: >>> >>> Add NumaChip-specific PCI access mechanism via M

Re: [PATCH 3/5] xen-pcifront: handle backend CLOSED without CLOSING

2012-11-30 Thread Bjorn Helgaas
tion to CLOSED too soon then the >> frontend may not see the CLOSING state and will not properly shutdown. >> >> So, treat an unexpected backend CLOSED state the same as CLOSING. >> >> Signed-off-by: David Vrabel >> Acked-by: Konrad Rzeszutek Wilk >> --- >

Re: [PATCH 3/5] xen-pcifront: handle backend CLOSED without CLOSING

2012-11-30 Thread Bjorn Helgaas
On Fri, Nov 30, 2012 at 11:41 AM, Bjorn Helgaas wrote: > On Fri, Oct 19, 2012 at 6:59 AM, Konrad Rzeszutek Wilk > wrote: >> On Thu, Oct 18, 2012 at 11:03:36AM +0100, David Vrabel wrote: >>> From: David Vrabel >>> >>> Backend drivers shouldn't

Re: [PATCH] x86,AMD: Power driver support for AMD's family 16h processors

2012-12-04 Thread Bjorn Helgaas
On Tue, Dec 4, 2012 at 5:10 AM, Boris Ostrovsky wrote: > Add family 16h PCI ID to AMD's power driver to allow it report > power consumption on these processors. > > Signed-off-by: Boris Ostrovsky > --- > drivers/hwmon/fam15h_power.c |1 + > include/linux/pci_ids.h |1 + > 2 files ch

Re: [PATCH -next] tile/PCI: use for_each_pci_dev to simplify the code

2012-12-04 Thread Bjorn Helgaas
On Mon, Dec 3, 2012 at 6:28 AM, Wei Yongjun wrote: > From: Wei Yongjun > > Use for_each_pci_dev to simplify the code. > > Signed-off-by: Wei Yongjun > --- > arch/tile/kernel/pci.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/tile/kernel/pci.c b/arch/tile/ker

Re: [PATCH -next] tile/PCI: use for_each_pci_dev to simplify the code

2012-12-04 Thread Bjorn Helgaas
On Tue, Dec 4, 2012 at 1:05 PM, Chris Metcalf wrote: > On 12/4/2012 2:57 PM, Bjorn Helgaas wrote: >> On Mon, Dec 3, 2012 at 6:28 AM, Wei Yongjun wrote: >>> From: Wei Yongjun >>> >>> Use for_each_pci_dev to simplify the code. >>> >>> Sig

Re: [PATCH] PCI: add PCIe 8.0 GT/s supported link speed define

2012-12-04 Thread Bjorn Helgaas
On Tue, Nov 20, 2012 at 11:58 AM, Betty Dall wrote: > Add a new define for the 8.0 GT/s supported link speed added in the PCI > 3.0 specification. This is used to identify a device's current link speed > (PCI_EXP_CLS). > > Here is the section of the PCI 3.0 specification: > "Supported Link Speeds

Re: [PATCH] PCI/PM: Keep runtime PM enabled for unbound PCI devices

2012-12-04 Thread Bjorn Helgaas
On Wed, Nov 28, 2012 at 3:43 PM, Rafael J. Wysocki wrote: > On Wednesday, November 28, 2012 03:25:59 PM Bjorn Helgaas wrote: >> On Tue, Nov 20, 2012 at 1:08 AM, Huang Ying wrote: >> > For unbound PCI devices, what we need is: >> > >> > - Always in D0 state

Re: Use PCI ROMs from EFI boot services

2012-12-05 Thread Bjorn Helgaas
On Mon, Dec 3, 2012 at 1:02 PM, Seth Forshee wrote: > On Thu, Oct 25, 2012 at 11:35:57AM -0600, Bjorn Helgaas wrote: >> On Thu, Aug 23, 2012 at 10:36 AM, Matthew Garrett wrote: >> > V3 just fixes all the casting issues and incorporates David's change in >> >

Re: Use PCI ROMs from EFI boot services

2012-12-05 Thread Bjorn Helgaas
On Wed, Dec 5, 2012 at 1:22 PM, Matthew Garrett wrote: > On Wed, Dec 05, 2012 at 01:09:25PM -0700, Bjorn Helgaas wrote: > >> That's right; nobody stepped up to fix the section mismatch. I'm >> happy to fold in your fix, especially if Matthew acks it. > > Y

Re: [PATCH] Add PNP0A08 into acpi_pci_roots array.

2012-10-17 Thread Bjorn Helgaas
On Wed, Oct 17, 2012 at 8:22 PM, Tang Chen wrote: > acpi_pci_roots array doesn't include PNP0A08, which is PCI Express > Root Bridge. You need to explain why this change is necessary. PNP0A08 devices will have a PNP0A03 _CID, so the driver already claims PNP0A08 devices because the _CID matches.

Re: radeon: RFC speed cap detection on ppc64

2012-10-22 Thread Bjorn Helgaas
On Mon, Oct 22, 2012 at 9:44 AM, Alan Cox wrote: >> That (walking all parent nodes) is probably the safest thing to do. I'm >> not sure whether it's optimal. It would likely depend on whether you >> can meaningfully have a bridge that's faster on the downstream side than >> on the upstream. > >

Re: Use PCI ROMs from EFI boot services

2012-12-06 Thread Bjorn Helgaas
On Wed, Dec 5, 2012 at 5:52 PM, Yinghai Lu wrote: > On Wed, Dec 5, 2012 at 4:51 PM, Yinghai Lu wrote: >> On Wed, Dec 5, 2012 at 4:36 PM, H. Peter Anvin wrote: >>> On 12/05/2012 04:15 PM, Yinghai Lu wrote: >>> >>> I don't see why that isn't the right fix. We copy the data into >>> boot_para

Re: Sharing PCIE driver between Microblaze and Arm zynq

2012-12-06 Thread Bjorn Helgaas
[+cc linux-pci] On Thu, Dec 6, 2012 at 7:23 AM, Michal Simek wrote: > Hi guys, > > I have a question regarding to sharing generic OF pcie driver between > two architectures MB and ARM Zynq. > Is drivers/pci/pcie location good for it? > Make no sense to have the same driver in two locations. I th

Re: Use PCI ROMs from EFI boot services

2012-12-06 Thread Bjorn Helgaas
On Thu, Dec 6, 2012 at 11:54 AM, Matthew Garrett wrote: > On Thu, Dec 06, 2012 at 10:26:01AM -0800, H. Peter Anvin wrote: > >> NAK on this bit: >> >> + if (boot_params.hdr.version < 0x0209) >> + return 0; >> >> This field is kernel->bootloader documentation. If a nonmaching >>

Re: [PATCH 01/15] PCI, acpiphp: Separate out hot-add support of pci host bridge

2012-12-07 Thread Bjorn Helgaas
On Thu, Dec 6, 2012 at 11:25 PM, Myron Stowe wrote: > From: Yinghai Lu > > It causes confusion. I completely agree that acpiphp causes confusion :) > We may only need acpi hp for pci host bridge. > > Split host bridge hot-add support to pci_root_hp, and keep acpiphp simple. > > -v2: put back p

Re: [PATCH v3] Add NumaChip remote PCI support

2012-12-07 Thread Bjorn Helgaas
On Tue, Dec 4, 2012 at 2:56 AM, Daniel J Blueman wrote: > Add NumaChip-specific PCI access mechanism via MMCONFIG cycles, but > preventing access to AMD Northbridges which shouldn't respond. > > v2: Use PCI_DEVFN in precomputed constant limit; drop unneeded includes > v3: Express dependency on MMC

Re: [PATCH 01/15] PCI, acpiphp: Separate out hot-add support of pci host bridge

2012-12-07 Thread Bjorn Helgaas
On Fri, Dec 7, 2012 at 2:30 PM, Yinghai Lu wrote: > On Fri, Dec 7, 2012 at 11:32 AM, Bjorn Helgaas wrote: >> On Thu, Dec 6, 2012 at 11:25 PM, Myron Stowe wrote: >>> From: Yinghai Lu >>> >>> >> For example, as soon as you put this code in pci_root

Re: [RFC PATCH 01/10] s390/pci: base support

2012-12-10 Thread Bjorn Helgaas
On Wed, Nov 14, 2012 at 2:41 AM, Jan Glauber wrote: > Add PCI support for s390, (only 64 bit mode is supported by hardware): > - PCI facility tests > - PCI instructions: pcilg, pcistg, pcistb, stpcifc, mpcifc, rpcit > - map readb/w/l/q and writeb/w/l/q to pcilg and pcistg instructions > - pci_ioma

Re: linux-next: build warning after merge of the pci tree

2012-12-10 Thread Bjorn Helgaas
oon. commit dbd3fc3345390a989a033427aa915a0dfb62149f Author: Bjorn Helgaas Date: Mon Dec 10 11:24:42 2012 -0700 PCI: Use phys_addr_t for physical ROM address Use phys_addr_t rather than "void *" for physical memory address. This removes casts and fixes a "cast

Re: linux-next: build warning after merge of the pci tree

2012-12-10 Thread Bjorn Helgaas
On Mon, Dec 10, 2012 at 2:25 PM, Bjorn Helgaas wrote: > On Mon, Dec 10, 2012 at 08:03:21PM +1100, Stephen Rothwell wrote: >> Hi Bjorn, >> >> After merging the pci tree, today's linux-next build (powerpc >> ppc44x_defconfig) produced this warning: >> >>

Re: Serial8250 doesn't populate in /proc/iomem?

2012-12-10 Thread Bjorn Helgaas
[+cc linux-arm, linux-samsung-soc, linux-serial] On Sun, Dec 9, 2012 at 11:25 PM, Woody Wu wrote: > Hi, list > > I found some io memory information is lost from /dev/iomem and want to > find out why. > > I have a 2.6.16 kernel running on a ARM board (Samsung S3C2410). From > the kernel log, I see

Re: [PATCH V8 06/13] MIPS: Loongson 3: Add HT-linked PCI support

2012-11-12 Thread Bjorn Helgaas
On Mon, Nov 12, 2012 at 1:32 AM, Huacai Chen wrote: > Loongson family machines use Hyper-Transport bus for inter-core > connection and device connection. The PCI bus is a subordinate > linked at HT1. > > With UEFI-like firmware interface, We don't need fixup for PCI irq > routing. > > Signed-off-b

Re: Q: Kconfig option VIRT_TO_BUS

2012-11-12 Thread Bjorn Helgaas
On Mon, Nov 12, 2012 at 9:18 AM, H Hartley Sweeten wrote: > Hello all, > > Does anyone know what the Kconfig option VIRT_TO_BUS does? > There are a number of "depends on" that option but it does not > seem to directly enable any code in the kernel. virt_to_bus() is a deprecated interface for conv

Re: Q: Kconfig option VIRT_TO_BUS

2012-11-12 Thread Bjorn Helgaas
On Mon, Nov 12, 2012 at 4:13 PM, H Hartley Sweeten wrote: > On Monday, November 12, 2012 11:41 AM, Bjorn Helgaas wrote: >> On Mon, Nov 12, 2012 at 9:18 AM, H Hartley Sweeten wrote: >>> Does anyone know what the Kconfig option VIRT_TO_BUS does? >>> There are a number

Re: [PATCH -v2] ACPI/PCI: Make PCI devices notified when its power resource turned on

2012-11-13 Thread Bjorn Helgaas
urce will be turned on and all devices share it > will be powered on to D0uninitialized state. These devices should be > resumed, so that they can get opportunity to go to low power state > later. > > v2: > > - Fix build error > > Signed-off-by: Huang Ying > Acked-

Re: [PATCH] Add missing license for ioapic module.

2012-11-13 Thread Bjorn Helgaas
On Tue, Nov 13, 2012 at 12:33 AM, Jan Beulich wrote: On 13.11.12 at 05:39, Andrew Cooks wrote: >> config PCI_IOAPIC turned into a tristate in commit >> b95a7bd700466c10fda84acbd33f70cf66ec91ce, but no module license is specified. >> This adds the missing module license. >> >> Signed-off-by:

Re: [PATCH] Centralise CONFIG_ARCH_NO_VIRT_TO_BUS

2012-11-14 Thread Bjorn Helgaas
On Tue, Nov 13, 2012 at 3:32 AM, Geert Uytterhoeven wrote: > On Mon, Nov 12, 2012 at 10:26 PM, Stephen Rothwell > wrote: >> diff --git a/arch/Kconfig b/arch/Kconfig >> index 366ec06..9bc00e7 100644 >> --- a/arch/Kconfig >> +++ b/arch/Kconfig >> @@ -271,6 +271,13 @@ config ARCH_WANT_OLD_COMPAT_IP

Re: [ PATCH RESEND ] PCI-AER: Do not report successful error recovery for devices with AER-unaware drivers

2012-11-14 Thread Bjorn Helgaas
[+cc Lance, Huang, Hidetoshi, Andrew, Zhang] On Sat, Nov 10, 2012 at 07:41:04AM +, Pandarathil, Vijaymohan R wrote: > When an error is detected on a PCIe device which does not have an > AER-aware driver, prevent AER infrastructure from reporting > successful error recovery. > > This is becaus

Re: [PATCH RESEND] ACPI/PCI: Make PCI devices notified when its power resource turned on

2012-11-05 Thread Bjorn Helgaas
ortunity to go to low power state > later. > > Signed-off-by: Huang Ying > Acked-by: Rafael J. Wysocki > Cc: Bjorn Helgaas I had applied this to my for-linus branch, headed for v3.7, but had to drop it because it introduced these warnings: drivers/acpi/pci_bind.c: In function '

Re: linux-next: manual merge of the pm tree with the pci tree

2012-11-06 Thread Bjorn Helgaas
On Mon, Nov 5, 2012 at 7:48 PM, Stephen Rothwell wrote: > Hi Rafael, > > Today's linux-next merge of the pm tree got a conflict in > arch/x86/pci/acpi.c between commit 3f385fa9edce ("x86/PCI: Ignore _SEG on > HP xw9300") from the pci tree and commit 97a7108a3c00 ("ACPI / x86: Add > quirk for "Chec

Re: [PATCH 2/3] spi / ACPI: add ACPI enumeration support

2012-11-06 Thread Bjorn Helgaas
On Tue, Nov 6, 2012 at 6:43 AM, Rafael J. Wysocki wrote: > On Monday, November 05, 2012 09:54:42 AM Bjorn Helgaas wrote: >> On Mon, Nov 5, 2012 at 3:31 AM, Rafael J. Wysocki wrote: >> > On Saturday, November 03, 2012 09:59:28 PM Rafael J. Wysocki wrote: >> >> On Sat

Re: [PATCH 2/3] spi / ACPI: add ACPI enumeration support

2012-11-06 Thread Bjorn Helgaas
On Tue, Nov 6, 2012 at 6:16 AM, Rafael J. Wysocki wrote: > On Monday, November 05, 2012 09:54:37 AM Bjorn Helgaas wrote: >> On Sat, Nov 3, 2012 at 2:39 PM, Rafael J. Wysocki wrote: >> > On Saturday, November 03, 2012 01:42:02 PM Bjorn Helgaas wrote: >> >> On Sat

Re: linux-next: build failure after merge of the pci tree

2012-11-06 Thread Bjorn Helgaas
1:34: error: lvalue required as left operand of > assignment Here's what I think we should do about the GDT issue. I'll send this via the usual channels. commit c6156dd31228e608e0a820d2eed7403fd1fd620b Author: Bjorn Helgaas Date: Tue Nov 6 14:19:03 2012 -0700 [SCSI] gdth: R

Re: [PATCH] pci: Convert pci_resource_ macros to static inlines

2012-11-07 Thread Bjorn Helgaas
On Mon, Nov 5, 2012 at 3:28 PM, Bjorn Helgaas wrote: > On Tue, Sep 18, 2012 at 12:51 PM, Joe Perches wrote: >> Get the compiler to verify the argument type of struct pci_dev *. >> >> Signed-off-by: Joe Perches > > I applied this to my pci/misc branch as v3.8 materia

Re: [PATCH 2/3] spi / ACPI: add ACPI enumeration support

2012-11-08 Thread Bjorn Helgaas
On Wed, Nov 7, 2012 at 2:56 AM, Mika Westerberg wrote: > On Tue, Nov 06, 2012 at 11:18:11PM +0100, Rafael J. Wysocki wrote: >> > How is the SPI controller different than this? Is there some logical >> > difference that requires a different framework? Or are you proposing >> > that we get rid of

Re: [PATCH 2/3] spi / ACPI: add ACPI enumeration support

2012-11-09 Thread Bjorn Helgaas
[+cc Greg, Peter, Tony since they acked the original patch [1]] On Thu, Nov 8, 2012 at 1:04 PM, Mika Westerberg wrote: > On Thu, Nov 08, 2012 at 12:32:25PM -0700, Bjorn Helgaas wrote: >> Struct device_driver is a generic structure, so it seems strange to >> have to include non

Re: SR-IOV problem with Intel 82599EB (not enough MMIO resources for SR-IOV)

2012-11-09 Thread Bjorn Helgaas
[+ linux-pci, Yinghai] On Thu, Nov 8, 2012 at 8:59 PM, Jason Gao wrote: >> The BIOS in your machine doesn't support SR-IOV. You'll need to ask the >> manufacturer for a BIOS upgrade, if in fact one is available. Sometimes >> they're not. > > very thanks Greg,my server Dell R710 with latest BI

Re: [PATCH 2/3] spi / ACPI: add ACPI enumeration support

2012-11-09 Thread Bjorn Helgaas
On Fri, Nov 9, 2012 at 8:45 AM, Grant Likely wrote: > On Fri, Nov 9, 2012 at 3:11 PM, Bjorn Helgaas wrote: >> [+cc Greg, Peter, Tony since they acked the original patch [1]] >> >> On Thu, Nov 8, 2012 at 1:04 PM, Mika Westerberg >> wrote: >>> On Thu, Nov

Re: [PATCH 2/3] spi / ACPI: add ACPI enumeration support

2012-11-09 Thread Bjorn Helgaas
On Fri, Nov 9, 2012 at 9:43 AM, Grant Likely wrote: > On Fri, Nov 9, 2012 at 4:35 PM, Bjorn Helgaas wrote: >> On Fri, Nov 9, 2012 at 8:45 AM, Grant Likely >> wrote: >>> On Fri, Nov 9, 2012 at 3:11 PM, Bjorn Helgaas wrote: >>>> [+cc Greg, Peter, Tony si

Re: [PATCH] PCI: Fix bit definitions of PCI_EXP_LNKCAP2 register

2012-11-09 Thread Bjorn Helgaas
On Thu, Nov 8, 2012 at 11:56 PM, Jingoo Han wrote: > According to the PCIe 3.0 spec, PCI_EXP_LNKCAP2_SLS_2_5GB is > 1st bit of PCI_EXP_LNKCAP2 register, not 0th bit. So, the bit > definition of supported link speed vector should be fixed. > > Signed-off-by: Jingoo Han > --- > include/uapi/linux/

[GIT PULL] PCI updates for v3.7

2012-11-09 Thread Bjorn Helgaas
nt in D3cold Hotplug PCI/portdrv: Don't create hotplug slots unless port supports hotplug -------- Bjorn Helgaas (1): Merge branch 'pci/huang-d3cold-fixes' into for-linus Huang Ying (3): PCI/PM: Fix deadlock w

Re: [PATCH] PCI: Fix bit definitions of PCI_EXP_LNKCAP2 register

2012-11-09 Thread Bjorn Helgaas
On Fri, Nov 9, 2012 at 10:37 AM, Alex Deucher wrote: > On Fri, Nov 9, 2012 at 12:15 PM, Bjorn Helgaas wrote: >> On Thu, Nov 8, 2012 at 11:56 PM, Jingoo Han wrote: >>> According to the PCIe 3.0 spec, PCI_EXP_LNKCAP2_SLS_2_5GB is >>> 1st bit of PCI_EXP_LNKCAP2 registe

Re: [PATCH 2/3] spi / ACPI: add ACPI enumeration support

2012-11-10 Thread Bjorn Helgaas
On Sat, Nov 10, 2012 at 4:10 AM, Rafael J. Wysocki wrote: > On Friday, November 09, 2012 09:53:26 AM Bjorn Helgaas wrote: >> On Fri, Nov 9, 2012 at 9:43 AM, Grant Likely >> wrote: >> > On Fri, Nov 9, 2012 at 4:35 PM, Bjorn Helgaas wrote: >> >> On Fri,

Re: [PATCH 4/5] x86: acpi: Print warning for malformed host bridge resources

2012-11-10 Thread Bjorn Helgaas
t; PCI BAR; if not, emit a diagnostic warning. > > Cc: Bjorn Helgaas > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: H. Peter Anvin > Cc: x...@kernel.org > Signed-off-by: Peter Hurley > --- > arch/x86/pci/acpi.c | 4 > 1 file changed, 4 insertions(+) > > diff

Re: [Alternative][PATCH] ACPI / PCI: Set root bridge ACPI handle in advance

2012-12-26 Thread Bjorn Helgaas
ot;callback". > > I wonder what the maintainers of the architectures in question (Peter, Tony) > think. I like this one much better because it doesn't change any of the PCI interfaces (pci_create_root_bus()). I don't see __weak as a disadvantage. We need some way of havin

Re: [Alternative][PATCH] ACPI / PCI: Set root bridge ACPI handle in advance

2012-12-26 Thread Bjorn Helgaas
On Wed, Dec 26, 2012 at 1:04 PM, Yinghai Lu wrote: > On Tue, Dec 25, 2012 at 2:42 PM, Rafael J. Wysocki wrote: >> From: Rafael J. Wysocki >> Subject: PCI / ACPI: Set root bridge ACPI handle in advance >> >> The ACPI handles of PCI root bridges need to be known to >> acpi_bind_one(), so that it c

Re: [PATCH] drm: fixed access to PCI host bridges

2012-12-26 Thread Bjorn Helgaas
On Sat, Dec 22, 2012 at 12:01 PM, Lucas Kannebley Tavares wrote: > During the process of obtaining the speed cap for the device, it > attempts go get the PCI Host bus. However on architectures such as PPC > or IA64, those do not appear as devices. > > Signed-off-by: Lucas Kannebley Tavares > ---

Re: [Qemu-devel] [PATCH 0/4] AER-KVM: Error containment of PCI pass-thru devices assigned to KVM guests

2012-12-26 Thread Bjorn Helgaas
On Mon, Nov 26, 2012 at 11:46 PM, Gleb Natapov wrote: > On Mon, Nov 26, 2012 at 09:46:12PM -0200, Marcelo Tosatti wrote: >> On Tue, Nov 20, 2012 at 02:09:46PM +, Pandarathil, Vijaymohan R wrote: >> > >> > >> > > -Original Message- >> > > From: Stefan Hajnoczi [mailto:stefa...@gmail.com

Re: [PATCH 0/3] Thunderbolt workarounds

2012-12-26 Thread Bjorn Helgaas
On Thu, Dec 13, 2012 at 12:25 PM, Kirill A. Shutemov wrote: > From: "Kirill A. Shutemov" > > I had chance to test two PC setups with Thunderbolt: Acer Aspire S5 and > Intel DZ77RE-75K motherboard. Unfortunately, both of them are broken in > different ways. > > This patchset contains workarounds f

Re: [PATCH v7 2/3] aerdrv: Enhanced AER logging

2012-12-26 Thread Bjorn Helgaas
On Wed, Dec 5, 2012 at 9:30 AM, Borislav Petkov wrote: > On Wed, Dec 05, 2012 at 04:14:14PM +, Ortiz, Lance E wrote: >> I removed the prefix argument because it was never used by its caller >> and never set. The reason I added the prefix variable and set it to >> NULL was to help in breaking u

[GIT PULL] PCI updates for v3.8

2013-01-02 Thread Bjorn Helgaas
reader base clock frequency to 50MHz Bjorn Helgaas (2): PCI: Remove spurious error for sriov_numvfs store and simplify flow PCI: Add PCIe Link Capability link speed and width names Huang Ying (1): PCI/PM: Do not suspend port if any subordinate device needs PME polling Myron Stowe

Re: [Alternative 2][PATCH] ACPI / PCI: Set root bridge ACPI handle in advance

2013-01-02 Thread Bjorn Helgaas
XSYSTM:00/device:00/PNP0A08:00/pci:00/:00:00.0 because it puts the PCI root bus (pci:00) under the PNP0A08 device rather than at the top level. That seems like an improvement to me, but it *is* different. Bjorn commit 5dee5f2f4fefbe4888939871c2252299067123bf Author: Bjorn Helgaas

Re: [PATCH] checkpatch: prefer dev_( to dev_printk(KERN_

2013-01-02 Thread Bjorn Helgaas
On Wed, Jan 2, 2013 at 6:06 PM, Joe Perches wrote: > Add YA check to printk style. > > dev_ uses are functions and generate smaller > object code than dev_printk(KERN_. > > Signed-off-by: Joe Perches > --- > scripts/checkpatch.pl | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git

Re: [PATCH] PCI / ACPI: Rework ACPI device nodes lookup for the PCI bus type

2013-01-03 Thread Bjorn Helgaas
On Fri, Dec 28, 2012 at 2:29 PM, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > As the kernel Bugzilla report #42696 indicates, it generally is not > sufficient to use _ADR to get an ACPI device node corresponding to > the given PCI device, because there may be multiple objects with > mat

Re: [PATCH] PCI / ACPI: Rework ACPI device nodes lookup for the PCI bus type

2013-01-03 Thread Bjorn Helgaas
On Thu, Jan 3, 2013 at 1:17 PM, Rafael J. Wysocki wrote: > On Thursday, January 03, 2013 08:16:26 AM Bjorn Helgaas wrote: >> On Fri, Dec 28, 2012 at 2:29 PM, Rafael J. Wysocki wrote: >> > From: Rafael J. Wysocki >> > >> > As the kernel Bugzilla report #

Re: [Alternative 2][PATCH] ACPI / PCI: Set root bridge ACPI handle in advance

2013-01-03 Thread Bjorn Helgaas
On Thu, Jan 3, 2013 at 2:23 PM, Rafael J. Wysocki wrote: > On Thursday, January 03, 2013 01:11:30 PM Rafael J. Wysocki wrote: >> On Thursday, January 03, 2013 01:40:52 AM Rafael J. Wysocki wrote: >> > On Wednesday, January 02, 2013 04:07:32 PM Bjorn Helgaas wrote: >> >

Re: [PATCH] PCI / ACPI: Rework ACPI device nodes lookup for the PCI bus type

2013-01-03 Thread Bjorn Helgaas
On Thu, Jan 3, 2013 at 3:38 PM, Rafael J. Wysocki wrote: > On Thursday, January 03, 2013 02:44:32 PM Bjorn Helgaas wrote: >> On Thu, Jan 3, 2013 at 1:17 PM, Rafael J. Wysocki wrote: >> > On Thursday, January 03, 2013 08:16:26 AM Bjorn Helgaas wrote: >> >> On Fri, D

Re: [Alternative 2][PATCH] ACPI / PCI: Set root bridge ACPI handle in advance

2013-01-03 Thread Bjorn Helgaas
mory is faulty. My response to the first (https://lkml.org/lkml/2012/12/20/407) was "Thanks for cleaning this up, I have an interface concern, here's an outline of a possible alternative." My response to the second (https://lkml.org/lkml/2012/12/26/72) was "I like this much better

Re: 3.8-rc2: pciehp waitqueue hang...

2013-01-04 Thread Bjorn Helgaas
On Thu, Jan 3, 2013 at 8:41 AM, Jiang Liu wrote: > Hi Daniel, > It seems like an issue caused by recursive PCIe HPC. > Could you please help to try the patch from: > http://www.spinics.net/lists/linux-pci/msg18625.html Hi Gerry, I'm working on merging this patch. Seems like something th

Re: 3.8-rc2: pciehp waitqueue hang...

2013-01-04 Thread Bjorn Helgaas
[+to Yijing, +cc Kenji] On Fri, Jan 4, 2013 at 1:01 PM, Bjorn Helgaas wrote: > On Thu, Jan 3, 2013 at 8:41 AM, Jiang Liu wrote: >> Hi Daniel, >> It seems like an issue caused by recursive PCIe HPC. >> Could you please help to try the patch from: >> http://www.

Re: [PATCH v9 2/3] aerdrv: Enhanced AER logging

2013-01-04 Thread Bjorn Helgaas
y: Lance Ortiz > Acked-by: Mauro Carvalho Chehab > Acked-by: Tony Luck Acked-by: Bjorn Helgaas > --- > > drivers/acpi/apei/cper.c | 19 --- > drivers/pci/pcie/aer/aerdrv_errprint.c |9 - > include/linux/aer.h

Re: [PATCH v9 3/3] aerdrv: Cleanup log output for AER

2013-01-04 Thread Bjorn Helgaas
t; Signed-off-by: Lance Ortiz > Acked-by: Tony Luck Acked-by: Bjorn Helgaas Nits (no need to fix them unless you have other reasons to touch this patch): s/elimiating/eliminating/ above. I remove the "v1-v2" notes when I merge patches because I don't think they're usef

[PATCH] x86: Don't print extended CMOS year when reading RTC

2013-01-04 Thread Bjorn Helgaas
We shouldn't print the current century every time we read the RTC. Signed-off-by: Bjorn Helgaas --- arch/x86/kernel/rtc.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/arch/x86/kernel/rtc.c b/arch/x86/kernel/rtc.c index 801602b..2e8f3d3 100644 --- a/arch/x86/k

Re: [Alternative 2][PATCH] ACPI / PCI: Set root bridge ACPI handle in advance

2013-01-04 Thread Bjorn Helgaas
On Fri, Jan 4, 2013 at 5:19 PM, Yinghai Lu wrote: > On Fri, Jan 4, 2013 at 4:14 PM, Rafael J. Wysocki wrote: >> On Friday, January 04, 2013 04:03:01 PM Yinghai Lu wrote: >>> On Fri, Jan 4, 2013 at 3:38 AM, Rafael J. Wysocki wrote: >>> >> --- a/arch/x86/include/asm/pci.h >>> >> +++ b/arch/x86/inc

Re: [PATCH rev.2 1/6] ACPI: Separate adding ACPI device objects from probing ACPI drivers

2012-12-18 Thread Bjorn Helgaas
On Tue, Dec 18, 2012 at 4:00 PM, Rafael J. Wysocki wrote: > On Tuesday, December 18, 2012 03:15:12 PM Toshi Kani wrote: >> On Tue, 2012-12-18 at 22:57 +0100, Rafael J. Wysocki wrote: >> > On Tuesday, December 18, 2012 09:10:41 AM Toshi Kani wrote: >> > > On Tue, 2012-12-18 at 02:48 +0100, Rafael J

Re: [Update 2][PATCH] ACPI / PCI: Set root bridge ACPI handle in advance

2012-12-20 Thread Bjorn Helgaas
[+cc linux-pci, Myron] On Mon, Dec 17, 2012 at 4:30 PM, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > The ACPI handles of PCI root bridges need to be known to > acpi_bind_one(), so that it can create the appropriate > "firmware_node" and "physical_node" files for them, but currently > t

Re: [PATCH] PCIe/PM: Do not suspend port if any subordinate device need PME polling

2012-12-20 Thread Bjorn Helgaas
On Sun, Dec 16, 2012 at 6:11 AM, Richard Yang wrote: > On Sat, Dec 15, 2012 at 12:03:33AM +0100, Rafael J. Wysocki wrote: >>On Friday, December 14, 2012 01:11:31 PM Richard Yang wrote: >>> On Fri, Dec 14, 2012 at 10:52:11AM +0800, Huang Ying wrote: >>> >In >>> > >>> > http://www.mail-archive.com/

Re: [PATCH] PCI: Work around Stratus ftServer broken PCIe hierarchy

2012-12-20 Thread Bjorn Helgaas
On Wed, Dec 19, 2012 at 2:50 PM, Myron Stowe wrote: > Recently, another report surfaced indicating Stratus ftServer platforms > were exhibiting similar failures as has occurred in the past [1]. > > In late 2011 we started seeing issues with Stratus ftServer systems. > The typical failure was t

Re: [Update 2][PATCH] ACPI / PCI: Set root bridge ACPI handle in advance

2012-12-20 Thread Bjorn Helgaas
On Thu, Dec 20, 2012 at 3:56 PM, Rafael J. Wysocki wrote: > On Thursday, December 20, 2012 02:13:15 PM Bjorn Helgaas wrote: >> [+cc linux-pci, Myron] >> >> On Mon, Dec 17, 2012 at 4:30 PM, Rafael J. Wysocki wrote: >> > From: Rafael J. Wysocki >> > >>

Re: [ PATCH RESEND ] PCI-AER: Do not report successful error recovery for devices with AER-unaware drivers

2012-11-15 Thread Bjorn Helgaas
On Thu, Nov 15, 2012 at 12:09 AM, Pandarathil, Vijaymohan R wrote: > Thanks for the comments. See my response below. > >> -Original Message----- >> From: Bjorn Helgaas [mailto:bhelg...@google.com] >> Sent: Wednesday, November 14, 2012 4:51 PM >> To: Pandarat

Re: [PATCH v2 3/3 UPDATED] i2c / ACPI: add ACPI enumeration support

2012-11-16 Thread Bjorn Helgaas
On Fri, Nov 16, 2012 at 10:28 AM, Mika Westerberg wrote: > ... > From: Mika Westerberg > Date: Mon, 10 Sep 2012 12:12:32 +0300 > Subject: [PATCH] i2c / ACPI: add ACPI enumeration support > > ACPI 5 introduced I2cSerialBus resource that makes it possible to enumerate > and configure the I2C slave

Re: [PATCH v2 3/3 UPDATED] i2c / ACPI: add ACPI enumeration support

2012-11-19 Thread Bjorn Helgaas
On Sat, Nov 17, 2012 at 2:55 AM, Mika Westerberg wrote: > On Sat, Nov 17, 2012 at 10:03:54AM +0200, Mika Westerberg wrote: >> On Fri, Nov 16, 2012 at 11:46:40PM -0700, Bjorn Helgaas wrote: >> > On Fri, Nov 16, 2012 at 10:28 AM, Mika Westerberg >> > wrote: >> >

Re: [PATCH] PCI / PM: Fix fallback to PCI_D0 in pci_platform_power_transition()

2013-04-16 Thread Bjorn Helgaas
On Tue, Apr 16, 2013 at 12:01 PM, Rafael J. Wysocki wrote: > On Monday, April 15, 2013 02:18:18 PM Bjorn Helgaas wrote: >> On Fri, Apr 12, 2013 at 11:50 PM, Yinghai Lu wrote: >> > On Fri, Apr 12, 2013 at 4:58 PM, Rafael J. Wysocki wrote: >> >> From: Rafael J. Wysoc

Re: [PATCH v9 09/16] PCI, x86: implement pcibios_{add|remove}_bus() hooks

2013-04-16 Thread Bjorn Helgaas
On Tue, Apr 16, 2013 at 2:27 PM, David Rientjes wrote: > On Fri, 12 Apr 2013, Jiang Liu wrote: > >> diff --git a/arch/x86/pci/common.c b/arch/x86/pci/common.c >> index 901177d..305c68b 100644 >> --- a/arch/x86/pci/common.c >> +++ b/arch/x86/pci/common.c >> @@ -6,6 +6,7 @@ >> >> #include >> #inc

Re: [PATCH] PCI: pci_bus_add_device() should succeed even if creating sysfs files fails

2013-04-17 Thread Bjorn Helgaas
On Wed, Apr 17, 2013 at 5:06 AM, Artem Savkov wrote: > Introduced in cc8f7f9e4e79a0940af6b4b6fdfbcf18a03aa9f4 > ("PCI: Fix __must_check annotation on pci_create_sysfs_dev_files()") > > pci_bus_add_device() should not fail to add device if > pci_create_sysfs_dev_files() call fails, as sysfs files a

Re: [PATCH] PCI: pci_bus_add_device() should succeed even if creating sysfs files fails

2013-04-17 Thread Bjorn Helgaas
On Wed, Apr 17, 2013 at 9:54 AM, Bjorn Helgaas wrote: > On Wed, Apr 17, 2013 at 5:06 AM, Artem Savkov wrote: >> Introduced in cc8f7f9e4e79a0940af6b4b6fdfbcf18a03aa9f4 >> ("PCI: Fix __must_check annotation on pci_create_sysfs_dev_files()") >> >> pci_bus_add_d

Re: No serial since kernel 3.8

2013-04-17 Thread Bjorn Helgaas
[+cc Rafael & linux-acpi] On Tue, Apr 16, 2013 at 10:14 AM, Stephan von Krawczynski wrote: > On Tue, 16 Apr 2013 10:59:53 -0400 > Josh Boyer wrote: > >> On Tue, Apr 16, 2013 at 04:55:25PM +0200, richard -rw- weinberger wrote: >> >On Tue, Apr 16, 2013 at 4:20 PM, Stephan von Krawczynski >> > wrot

Re: PCI: Remove "extern" from function declarations

2013-04-17 Thread Bjorn Helgaas
On Wed, Apr 17, 2013 at 5:24 PM, Stephen Rothwell wrote: > Hi Bjorn, > > I just noticed this commit (f39d5b72913e "PCI: Remove "extern" from > function declarations") in the pci next branch. Just wondering why you > would do such a thing. It is a lot of churn in quite a few header files > and (i

Re: [PATCH 26/28] proc: Supply a function to remove a proc entry by PDE [RFC]

2013-04-18 Thread Bjorn Helgaas
11 +-- > drivers/pci/proc.c | 12 +++- For the drivers/pci part: Acked-by: Bjorn Helgaas I assume you'll merge this via something other than my tree. > fs/proc/generic.c |7 +++ > fs/proc/vmcore.c|

Re: [PATCH 04/28] proc: Supply PDE attribute setting accessor functions [RFC]

2013-04-18 Thread Bjorn Helgaas
arch/powerpc/platforms/pseries/reconfig.c |2 +- > drivers/media/pci/ttpci/av7110_ir.c |2 +- > drivers/net/irda/vlsi_ir.c|2 +- > drivers/net/wireless/airo.c | 34 > + > drivers/pci/proc.c

Re: Kernel bug: opensuse 12.3, lenovo 3000 n100 laptop

2013-04-19 Thread Bjorn Helgaas
[+cc Bryan, Zhang] On Fri, Apr 19, 2013 at 8:51 AM, Scott Simpson wrote: > Stack trace is here: http://www.flickr.com/photos/94373754@N06/8662259093/ > -- Hi Scott, This is an openSUSE bug, so you'll probably get more help there. I added a CC: for that,

Re: [PATCH] PCI: Remove not needed check in disable aspm link

2013-06-12 Thread Bjorn Helgaas
On Wed, Jun 12, 2013 at 12:20 AM, Yinghai Lu wrote: > On Tue, Apr 2, 2013 at 1:10 PM, Bjorn Helgaas wrote: >> On Mon, Apr 1, 2013 at 6:03 PM, Yinghai Lu wrote: >>>> commit 96e5d01cd536458435ef0678d9fa3dc542afb41f >>>> Author: Bjorn Helgaas >>&

Re: [PATCH] xen/pci: Deal with toolstack missing an 'XenbusStateClosing'.

2013-06-12 Thread Bjorn Helgaas
; >> >The testing I did was just with one PCI device. >> >> Ah, OK -- I see now. The problem is that the code in the Linux side >> didn't know about the whole "4->7->8->4" thing to unplug a device. >> In all likelihood, if you had used xm wi

Re: pcie aspm link setup, grandparent instead of parent?

2013-06-12 Thread Bjorn Helgaas
[+cc linux-pci, Myron, Joe] On Wed, Jun 12, 2013 at 11:21 AM, Radim Krčmář wrote: > Hello, > > as a consequence of hitting a NULL dereference bug[1] while downstream > aspm is setting up link_state, I started to wonder why is the code > skipping its parent bus in favour of grandparent's link_stat

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-06-12 Thread Bjorn Helgaas
On Wed, Jun 12, 2013 at 8:44 PM, Takao Indoh wrote: > (2013/06/12 13:45), Bjorn Helgaas wrote: >> [+cc Vivek, Haren; sorry I didn't think to add you earlier] >> >> On Tue, Jun 11, 2013 at 12:08 AM, Takao Indoh >> wrote: >>> (2013/06/11 11:20), Bjorn Hel

Re: [PATCH] PCI: Remove not needed check in disable aspm link

2013-06-12 Thread Bjorn Helgaas
On Wed, Jun 12, 2013 at 1:41 PM, Yinghai Lu wrote: > On Wed, Jun 12, 2013 at 10:05 AM, Bjorn Helgaas wrote: >>> current code from acpi_pci_root_add we have >>> 1. pci_acpi_scan_root >>> ==> pci devices enumeration and bus scanning. >>

Re: [PATCH] PCI: Remove not needed check in disable aspm link

2013-06-13 Thread Bjorn Helgaas
On Wed, Jun 12, 2013 at 10:11 PM, Jiang Liu (Gerry) wrote: > Hi Bjorn, > I'm working on several acpiphp related bugfixes, and feel some > are materials for 3.10 too. Actually we have identified four bugs > related to dock station support on Sony VAIO VPCZ23A4R laptop. > I will try to send out

Re: [PATCH] bio-integrity: Fix use of bs->bio_integrity_pool after free

2013-06-13 Thread Bjorn Helgaas
On Wed, May 29, 2013 at 4:29 PM, Bjorn Helgaas wrote: > This fixes a copy and paste error introduced by 9f060e2231 > ("block: Convert integrity to bvec_alloc_bs()"). > > Found by Coverity (CID 1020654). > > Signed-off-by: Bjorn Helgaas > --- > fs/bio-integrit

Re: [PATCH] PCI: Remove not needed check in disable aspm link

2013-06-14 Thread Bjorn Helgaas
On Wed, Jun 12, 2013 at 12:41:42PM -0700, Yinghai Lu wrote: > On Wed, Jun 12, 2013 at 10:05 AM, Bjorn Helgaas wrote: > >> current code from acpi_pci_root_add we have > >> 1. pci_acpi_scan_root > >> ==> pci devices enumeration and bus scanning. > >

Re: BUG: unable to handle kernel NULL pointer dereference at 0000000000000040

2013-06-14 Thread Bjorn Helgaas
[+cc Ming, Hayes, Francois, r8169 list] On Fri, Jun 14, 2013 at 6:49 AM, nirinA raseliarison wrote: > hello there, > i have this ethernet controler: > > Realtek Semiconductor Co., Ltd. RTL8101E/RTL8102E PCI Express Fast Ethernet > controller (rev 05) > > that uses the r8169 module. > it works fi

Re: [PATCH] PCI: Remove not needed check in disable aspm link

2013-06-14 Thread Bjorn Helgaas
On Fri, Jun 14, 2013 at 10:17 AM, Yinghai Lu wrote: > On Fri, Jun 14, 2013 at 7:11 AM, Bjorn Helgaas wrote: >> Here are some of my notes from trying to sort this out, in chronological >> order: >> >> 29594404 v3.7 >> Bus scanned before requesting _OSC c

Re: [PATCH] PCI / ACPI / PM: Use correct power state strings in messages

2013-06-14 Thread Bjorn Helgaas
On Thu, Jun 13, 2013 at 4:29 PM, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > Make acpi_pci_set_power_state() print the name of the ACPI device > power state the device has been actually put into instead of printing > the name of the requested PCI device power state, which need not be >

<    1   2   3   4   5   6   7   8   9   10   >