Re: [PATCH 4/6] IB/qib: Use pcie_set_mps() and pcie_get_mps() to simplify code

2013-10-04 Thread Bjorn Helgaas
pci_dev->pcie_mpss, >> so use that instead of pcie_capability_read_word(). Remove the unused >> val2fld() and fld2val(). >> >> Signed-off-by: Yijing Wang >> Signed-off-by: Bjorn Helgaas > > This works! > > Go ahead and queue it up. Applied to my

Re: [PATCH 4/6] IB/qib: Use pcie_set_mps() and pcie_get_mps() to simplify code

2013-10-04 Thread Bjorn Helgaas
[-cc extra folks] On Tue, Sep 24, 2013 at 2:39 PM, Bjorn Helgaas wrote: > On Mon, Sep 09, 2013 at 09:13:06PM +0800, Yijing Wang wrote: >> Refactor qib_tune_pcie_caps() function, use pcie_set_mps() >> and pcie_get_mps() to simply code. Because pci core caches >> the &q

Re: Commit 07f9b61 breaks systems that don't implement a _CBA method

2013-10-04 Thread Bjorn Helgaas
nlock() > cleanup path. > > [bhelgaas: drop warning printk] > Signed-off-by: ethan.zhao > Signed-off-by: Bjorn Helgaas > Acked-by: Yinghai Lu ... > So the question is should commit > > 07f9b61 x86/PCI: MMCONFIG: Check earlier for MMCONFIG regi

[GIT PULL] PCI updates for v3.12

2013-10-04 Thread Bjorn Helgaas
r MMCONFIG region at address zero" -------- Bjorn Helgaas (1): Revert "x86/PCI: MMCONFIG: Check earlier for MMCONFIG region at address zero" arch/x86/pci/mmconfig-shared.c | 7 ++- 1 file changed, 6 insertions(+), 1

Re: [PATCH] PCI: fix typo in iov.c

2013-07-08 Thread Bjorn Helgaas
[+cc linux-pci] On Sun, Jul 7, 2013 at 11:28 PM, Jonghwan Choi wrote: > Devic3 should be device. > > Signed-off-by: Jonghwan Choi Patch was corrupted and not sent to linux-pci, but I applied it to my pci/misc branch by hand. Thanks! Bjorn > --- > drivers/pci/iov.c |2 +- > 1 file change

Re: [PATCH 1/1] ia64/pci: set mmio decoding on for some host bridge

2013-07-08 Thread Bjorn Helgaas
On Sun, Jul 7, 2013 at 6:16 PM, Li, Zhen-Hua wrote: > On some IA64 platforms with intel PCI bridge, for example, HP BL890c i2 > with Intel Corporation 5520/5500/X58 I/O Hub PCI Express Root Port, > when kernel tries to disable the mmio decoding on the PCI bridge devices, > kernel may crash. > > A

Re: /sys/module/pcie_aspm/parameters/policy not writable?

2013-07-09 Thread Bjorn Helgaas
On Tue, Jul 9, 2013 at 4:10 AM, Pavel Machek wrote: > Hi! >> > > My thinkpad has rather high ping latencies... and perhaps it is due to >> > > PCIE ASPM. >> > >> > Why would that be the problem? The odds that the PCIE bus is the issue >> > seems strange to me. >> >> Aha: I guess that's why the fi

Re: [PATCH 1/1] ia64/pci: set mmio decoding on for some host bridge

2013-07-09 Thread Bjorn Helgaas
On Mon, Jul 8, 2013 at 11:42 PM, Li, Zhen-Hua wrote: > On some IA64 platforms with intel PCI bridge, for example, HP BL890c i2 > with Intel Corporation 5520/5500/X58 I/O Hub PCI Express Root Port, > when kernel tries to disable the mmio decoding on the PCI bridge devices, > kernel may crash. > >

Re: 3.8.0-rc4+ - Oops on removing WinTV-HVR-1400 expresscard TV Tuner

2013-07-09 Thread Bjorn Helgaas
On Tue, Jul 9, 2013 at 3:35 AM, Chris Clayton wrote: > Hello again, Bjorn. > > On 04/01/13 18:28, Bjorn Helgaas wrote: > > > > >>>> Hi Chris, >>>> >>>> The current Linux acpiphp driver doesn't do anything unless it finds >>>

Re: WARNING: at drivers/iommu/dmar.c:484 warn_invalid_dmar with Intel Motherboard

2013-07-09 Thread Bjorn Helgaas
[+cc Joerg, David, iommu list] On Tue, Jul 9, 2013 at 2:24 PM, Guenter Roeck wrote: > I started seeing this problem after updating the BIOS trying fix another > issue, > though I may have missed it earlier. > > I understand this is a BIOS bug. Would be great if someone can pass this on > to Inte

Re: [PATCH 2/2] PCI,pciehp: avoid add a device already exist during pciehp_resume

2013-07-09 Thread Bjorn Helgaas
On Tue, Jul 9, 2013 at 1:56 AM, Yijing Wang wrote: > Currently, pciehp_resume will call pciehp_enable_slot() to add > device if there is a device in the slot. But if the device was > present before suspend, it's no necessary to add again. Now in > such case, there is some uncomfortable message lik

Re: [PATCH 1/1] ia64/pci: set mmio decoding on for some host bridge

2013-07-10 Thread Bjorn Helgaas
LLP- Rollover- Timeout- > NonFatalErr+ > AERCap: First Error Pointer: 00, GenCap- CGenEn- ChkCap- > ChkEn- > Capabilities: [150] Access Control Services > ACSCap: SrcValid+ TransBlk+ ReqRedir+ CmpltRedir+ > UpstreamFwd+ EgressCtrl- DirectTrans- >

Re: /sys/module/pcie_aspm/parameters/policy not writable?

2013-07-10 Thread Bjorn Helgaas
[+cc Jeff, Jesse, et al, e1000-devel] Holy cow, you guys have a lot of folks listed in MAINTAINERS for Intel drivers :) This is an ASPM question, if that helps narrow down the folks interested. On Wed, Jul 10, 2013 at 7:29 AM, Pavel Machek wrote: > Hi! > >> >> But: >> >> 1) it should not list u

Re: [PATCH 2/2] PCI,pciehp: avoid add a device already exist during pciehp_resume

2013-07-10 Thread Bjorn Helgaas
On Tue, Jul 9, 2013 at 9:00 PM, Yijing Wang wrote: > Hi Bjorn, >Thanks for your review and comments! > >>> We can use PCIe Device Serial Number to identify the device if >>> device support DSN. >> >> I think I like the idea of this, especially because the Microsoft PCI >> Hardware Compliance T

Re: Abysmal HDD/USB write speed after sleep on a UEFI system

2013-07-10 Thread Bjorn Helgaas
[+cc previous cc list from lkml] On Wed, Jul 10, 2013 at 11:25 AM, hyphop wrote: > hello > i have same problem. low write speed after system sleep > > kernel 3.9.9 > > i can see it HDD SATA & USB disks to > > i try to make another test > > before sleep i make file /tmp/test ( /tmp mounted as tmp

Re: [PATCH 1/2] PCI: introduce PCIe Device Serial NUmber Capability support

2013-07-10 Thread Bjorn Helgaas
On Tue, Jul 9, 2013 at 1:55 AM, Yijing Wang wrote: > Introduce PCIe Ext Capability Device Serial Number support, > so we can use the unique device serial number to identify > the physical device. During system suspend, if the PCIe > device was removed and inserted a new same device, after > system

Re: /sys/module/pcie_aspm/parameters/policy not writable?

2013-07-10 Thread Bjorn Helgaas
[+cc linux-pci] On Wed, Jul 10, 2013 at 10:21:32PM +, Wyborny, Carolyn wrote: > > -Original Message- > > From: Bjorn Helgaas [mailto:bhelg...@google.com] > [..] > > > Pavel's ThinkPad X60 has two NICs: Intel 82573L and Intel PRO/Wireless > > 3945ABG

Re: [PATCH -v2 1/3] PCI: introduce PCIe Device Serial Number Capability support

2013-07-11 Thread Bjorn Helgaas
On Thu, Jul 11, 2013 at 3:51 AM, Don Dutile wrote: > On 07/11/2013 05:43 AM, Yijing Wang wrote: >> >> Introduce PCIe Ext Capability Device Serial Number support, >> so we can use the unique device serial number to identify >> the physical device. During system suspend, if the PCIe >> device was re

Re: is it desirable to improve the build system?

2013-07-11 Thread Bjorn Helgaas
On Thu, Jul 11, 2013 at 5:38 AM, Pavel Machek wrote: > Hi! >> >> Does the Linux-Kernel Community perceive that is the case? >> >> If so, do you think it is possible to improve? >> >> If so, would such an attempt be welcome, including and especially by, the >> current maintainer(s) of the build?

Re: [PATCH -v2 1/3] PCI: introduce PCIe Device Serial Number Capability support

2013-07-11 Thread Bjorn Helgaas
On Thu, Jul 11, 2013 at 12:18 PM, Don Dutile wrote: > On 07/11/2013 04:09 PM, Bjorn Helgaas wrote: >> >> On Thu, Jul 11, 2013 at 3:51 AM, Don Dutile wrote: >>> >>> On 07/11/2013 05:43 AM, Yijing Wang wrote: >>>> >>>> >>>> Intro

Re: [PATCH] bio-integrity: Fix use of bs->bio_integrity_pool after free

2013-09-16 Thread Bjorn Helgaas
On Thu, Jun 13, 2013 at 12:33 PM, Kent Overstreet wrote: > On Thu, Jun 13, 2013 at 12:14:54PM -0600, Bjorn Helgaas wrote: >> On Wed, May 29, 2013 at 4:29 PM, Bjorn Helgaas wrote: >> > This fixes a copy and paste error introduced by 9f060e2231 >> > ("block: Co

Re: [PATCH] bio-integrity: Fix use of bs->bio_integrity_pool after free

2013-09-16 Thread Bjorn Helgaas
[update Kent's email address] On Mon, Sep 16, 2013 at 7:40 AM, Bjorn Helgaas wrote: > On Thu, Jun 13, 2013 at 12:33 PM, Kent Overstreet > wrote: >> On Thu, Jun 13, 2013 at 12:14:54PM -0600, Bjorn Helgaas wrote: >>> On Wed, May 29, 2013 at 4:29 PM, Bjorn Helgaas wrot

Re: [PATCH] PCI / ACPI / PM: Clear pme_poll for devices in D3cold on wakeup

2013-09-19 Thread Bjorn Helgaas
ll not know that wakeup has been > signaled for the device and will poll its PME Status bit > unnecessarily. > > Fix the problem by moving the clearing of the pme_poll flag in > pci_acpi_wake_dev() before the code introduced by commit 448bd85. > > Reported-and-tested-by: David E. Box

Re: [PATCH] perf/x86/intel/uncore: don't use smp_processor_id() in validate_group()

2013-09-19 Thread Bjorn Helgaas
On Wed, Sep 18, 2013 at 5:31 AM, Peter Zijlstra wrote: > On Tue, Sep 17, 2013 at 02:48:13PM +0800, Yan, Zheng wrote: >> From: "Yan, Zheng" >> >> uncore_validate_group() can't call smp_processor_id() because it is >> in preemptible context. Pass NUMA_NO_NODE to the allocator instead. >> >> Signed-

Re: [PATCH 5/7] ixgbe: use pcie_capability_read_word() to simplify code

2013-09-04 Thread Bjorn Helgaas
[+cc Jacob, Jeff] On Tue, Sep 03, 2013 at 03:35:13PM +0800, Yijing Wang wrote: > use pcie_capability_read_word() to simplify code. > > Signed-off-by: Yijing Wang > Cc: e1000-de...@lists.sourceforge.net > Cc: net...@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > --- > drivers/net/ethernet/

Re: Excess dmesg output from ACPIPHP on boot (was: Re: [PATCH 25/30] ACPI / hotplug / PCI: Check for new devices on enabled slots)

2013-09-06 Thread Bjorn Helgaas
On Thu, Sep 5, 2013 at 5:36 PM, Rafael J. Wysocki wrote: > On Thursday, September 05, 2013 05:08:03 PM Alex Williamson wrote: >> On Fri, 2013-09-06 at 00:40 +0200, Rafael J. Wysocki wrote: >> > On Thursday, September 05, 2013 04:17:25 PM Alex Williamson wrote: >> > > On Thu, 2013-09-05 at 23:39 +0

Re: [RFC PATCH 4/4] X86/PCI/ACPI: Rework setup_resource() via functions ACPI resource functions

2013-09-06 Thread Bjorn Helgaas
[+cc Tony, linux-ia64] On Fri, Sep 6, 2013 at 8:24 AM, Lan Tianyu wrote: > Using ACPI resource functions to convert ACPI resource to generic resource > instead of resource_to_addr(). Remove resource_to_addr(). > > Signed-off-by: Lan Tianyu > --- > arch/x86/pci/acpi.c | 81 > ---

Re: [RFC PATCH 4/4] X86/PCI/ACPI: Rework setup_resource() via functions ACPI resource functions

2013-09-06 Thread Bjorn Helgaas
On Fri, Sep 6, 2013 at 10:01 AM, Lan Tianyu wrote: > On 09/06/2013 11:36 AM, Bjorn Helgaas wrote: >> Please make corresponding changes to arch/ia64/pci/pci.c so that these >> paths remain as similar as possible. There's quite a bit of >> similarity between this x86 a

Re: [PATCH v2 2/6] PCI/MSI: Factor out pci_get_msi_cap() interface

2013-09-06 Thread Bjorn Helgaas
On Thu, Sep 5, 2013 at 2:06 PM, Tejun Heo wrote: > Hello, Alexander. > > On Thu, Sep 05, 2013 at 08:54:40PM +0200, Alexander Gordeev wrote: >> I assume reasons for having this type of interface at the moment of >> taking design decision about pci_enable_msi_block() still hold true. >> I do not kno

Re: [PATCH v2 3/6] powerpc/pci: use pci_is_pcie() to simplify code

2013-09-06 Thread Bjorn Helgaas
his series, so you can take it through the POWERPC tree. If you don't want to do that, let me know and I can take it. If you want it: Acked-by: Bjorn Helgaas > diff --git a/arch/powerpc/kernel/eeh.c b/arch/powerpc/kernel/eeh.c > index 55593ee..6ebbe54 100644 > --- a/arch/powerpc/ke

Re: [PATCH v2 1/6] scsi/bfa: use pcie_set/get_readrq to simplify code

2013-09-06 Thread Bjorn Helgaas
On Thu, Sep 05, 2013 at 03:55:25PM +0800, Yijing Wang wrote: > v1->v2: use pcie_get/set_readrq to simplify code > a lot suggestd by Bjorn. > > Use pcie_get_readrq()/pcie_set_readrq() to simplify > code. > > Signed-off-by: Yijing Wang > Cc: Jiang Liu > Cc: Anil Gurumurthy > Cc: Vijaya Mohan Guv

Re: [PATCH] PCI: add quirk for 3ware 9650SE controller

2013-09-06 Thread Bjorn Helgaas
On Fri, Sep 6, 2013 at 3:51 AM, Jiri Kosina wrote: > On Wed, 28 Aug 2013, Bjorn Helgaas wrote: > >> [+cc another email addr for Adam from git logs] > > Thanks. Adam, would you happen to have any possible explanation / > background? > >> >> > Commit d5dea

Re: [PATCH v2 2/6] PCI/MSI: Factor out pci_get_msi_cap() interface

2013-09-06 Thread Bjorn Helgaas
On Fri, Sep 06, 2013 at 12:06:21PM -0400, Tejun Heo wrote: > Hello, Bjorn. > > On Fri, Sep 06, 2013 at 10:01:38AM -0600, Bjorn Helgaas wrote: > > Sorry, I haven't jumped in here yet because I saw your discussion and > > was hoping you guys would figure something out wit

Re: [Bug 60555] New: Some amount of ifconfig cause load average increase and system freeze

2013-09-10 Thread Bjorn Helgaas
[+cc Thomas, e1000e driver folks, linux-pci, lkml] On Mon, Jul 15, 2013 at 2:31 AM, wrote: > https://bugzilla.kernel.org/show_bug.cgi?id=60555 > > Bug ID: 60555 >Summary: Some amount of ifconfig cause load average increase > and system freeze >

Re: [PATCH] pci: do not try to assign irq 255

2013-09-10 Thread Bjorn Helgaas
On Tue, Mar 26, 2013 at 5:34 PM, Yinghai Lu wrote: > On Tue, Mar 26, 2013 at 2:54 PM, Bjorn Helgaas wrote: > >> Where are we at with this? I don't see Sarah's patch in the tree, and >> I haven't applied any changes, so my guess is this is still broken. >

Re: [E1000-devel] 3.11-rc4 ixgbevf: endless "Last Request of type 00 to PF Nacked" messages

2013-09-12 Thread Bjorn Helgaas
On Tue, Aug 27, 2013 at 5:01 PM, Bjorn Helgaas wrote: > I haven't been able to reproduce the problem with the 2.10.3 ixgbevf > driver from http://sourceforge.net/projects/e1000/files/ixgbevf%20stable/ > ... > Sorry for wasting so much time on something that appears to be alrea

Re: [PATCH 01/11] pci: convert bus code to use dev_groups

2013-10-07 Thread Bjorn Helgaas
[+cc Sachin] On Mon, Oct 7, 2013 at 12:55 AM, Greg Kroah-Hartman wrote: > The dev_attrs field of struct bus_type is going away soon, dev_groups > should be used instead. This converts the PCI bus code to use the > correct field. > > Cc: Bjorn Helgaas > Cc: > Signed-off-b

Re: [PATCH 6/6] radeon: Use pcie_get_readrq() and pcie_set_readrq() to simplify code

2013-10-07 Thread Bjorn Helgaas
On Mon, Oct 7, 2013 at 6:15 AM, Deucher, Alexander wrote: >> -Original Message- >> From: Bjorn Helgaas [mailto:bhelg...@google.com] >> Sent: Friday, October 04, 2013 4:45 PM >> To: Yijing Wang >> Cc: David Airlie; linux-kernel@vger.kernel.org; linux-...@

Re: [PATCH 01/11] pci: convert bus code to use dev_groups

2013-10-07 Thread Bjorn Helgaas
On Mon, Oct 7, 2013 at 2:41 PM, Greg Kroah-Hartman wrote: > On Mon, Oct 07, 2013 at 12:21:36PM -0600, Bjorn Helgaas wrote: >> [+cc Sachin] >> >> On Mon, Oct 7, 2013 at 12:55 AM, Greg Kroah-Hartman >> wrote: >> > The dev_attrs field of struct bus_type is going

Re: [PATCH 01/11] pci: convert bus code to use dev_groups

2013-10-07 Thread Bjorn Helgaas
On Mon, Oct 7, 2013 at 12:55 AM, Greg Kroah-Hartman wrote: > The dev_attrs field of struct bus_type is going away soon, dev_groups > should be used instead. This converts the PCI bus code to use the > correct field. > > Cc: Bjorn Helgaas > Cc: > Signed-off-b

Re: [PATCH] PCI/PM: Removing the function pci_pm_complete()

2013-10-07 Thread Bjorn Helgaas
On Tue, Sep 10, 2013 at 4:46 AM, Chuansheng Liu wrote: > > Commit(88d2613) removed the pm_runtime_put_sync() from pci_pm_complete() > to PM core code device_complete(). > > Here the pci_pm_complete() is doing the same work which can be done in > device_complete(), so we can remove it directly. > >

Re: [PATCH] checkpatch: Add check for sscanf without return use

2013-10-07 Thread Bjorn Helgaas
On Mon, Oct 7, 2013 at 6:03 PM, Joe Perches wrote: > On Mon, 2013-10-07 at 16:56 -0700, Andrew Morton wrote: >> On Mon, 07 Oct 2013 16:45:23 -0700 Joe Perches wrote: >> >> > Naked use sscanf can be troublesome. >> >> It would be helpful to expand on "troublesome"? > > Dunno, you either know or th

Re: [PATCH 1/7] powerpc: Add interface to get msi region information

2013-10-08 Thread Bjorn Helgaas
On Thu, Oct 3, 2013 at 11:19 PM, Bhushan Bharat-R65777 wrote: >> I don't know enough about VFIO to understand why these new interfaces are >> needed. Is this the first VFIO IOMMU driver? I see vfio_iommu_spapr_tce.c >> and >> vfio_iommu_type1.c but I don't know if they're comparable to the Fre

[PATCH 0/2] Remove ksets from sysfs eagerly

2013-10-08 Thread Bjorn Helgaas
ems clunky and other kset_unregister() users are likely to have similar problems. The idea of this patch is to make kset_unregister() unlink the kset from sysfs immediately, before dropping the kset reference. --- Bjorn Helgaas (2): kobject: remove kset from sysfs immediately in kset_unregi

[PATCH 1/2] kobject: remove kset from sysfs immediately in kset_unregister()

2013-10-08 Thread Bjorn Helgaas
ay create a new kset with the same name as soon as kset_unregister() returns. Signed-off-by: Bjorn Helgaas --- Documentation/kobject.txt |3 ++- lib/kobject.c |1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/Documentation/kobject.txt b/Documentation/kobject.tx

[PATCH 2/2] kobject: fix kset sample error path

2013-10-08 Thread Bjorn Helgaas
Previously, example_init() leaked a kset if any of the object creations failed. This fixes the leak by calling kset_unregister() in the error path. Signed-off-by: Bjorn Helgaas --- samples/kobject/kset-example.c |1 + 1 file changed, 1 insertion(+) diff --git a/samples/kobject/kset

Re: remove unneeded semicolons

2013-10-08 Thread Bjorn Helgaas
Thanks, Joe. I picked up the drivers/pci changes below and will merge them in the v3.13 merge window if nobody else does it first. Bjorn diff --git a/drivers/pci/proc.c b/drivers/pci/proc.c index cdc7836..46d1378 100644 --- a/drivers/pci/proc.c +++ b/drivers/pci/proc.c @@ -222,7 +222,7 @@ stati

Re: [PATCH 1/7] powerpc: Add interface to get msi region information

2013-10-08 Thread Bjorn Helgaas
>> - u32 msiir_offset; /* Offset of MSIIR, relative to start of CCSR */ >> + dma_addr_t msiir; /* MSIIR Address in CCSR */ > > Are you sure dma_addr_t is right here, versus phys_addr_t? It implies > that it's the output of the DMA API, but I don't think the DMA API is > used in the MSI dri

Re: [PATCH V2] PCI: designware: Add irq_create_mapping()

2013-10-09 Thread Bjorn Helgaas
On Wed, Oct 9, 2013 at 6:32 AM, Jingoo Han wrote: > From: Pratyush Anand > > Without irq_create_mapping(), the correct irq number cannot be > provided. In this case, it makes problems such as NULL deference. > Thus, irq_create_mapping() should be added for MSI. > > Signed-off-by: Pratyush Anand

[PATCH] MAINTAINERS: Add arch/x86/pci to PCI file patterns

2013-10-09 Thread Bjorn Helgaas
I handle many arch/x86/pci changes, so help those patches get to the PCI patchwork. Signed-off-by: Bjorn Helgaas --- MAINTAINERS |1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index e61c2e8..d1ab647 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -6338,6 +6338,7

Re: [PATCH] MAINTAINERS: Add arch/x86/pci to PCI file patterns

2013-10-09 Thread Bjorn Helgaas
On Wed, Oct 9, 2013 at 3:02 PM, Bjorn Helgaas wrote: > I handle many arch/x86/pci changes, so help those patches get to the > PCI patchwork. > > Signed-off-by: Bjorn Helgaas I'll merge this via the PCI tree unless anybody objects. > --- > MAINTAINERS |1 + > 1

Re: [PATCH] MAINTAINERS: Add arch/x86/pci to PCI file patterns

2013-10-09 Thread Bjorn Helgaas
On Wed, Oct 9, 2013 at 3:08 PM, H. Peter Anvin wrote: > On 10/09/2013 02:04 PM, Bjorn Helgaas wrote: >> On Wed, Oct 9, 2013 at 3:02 PM, Bjorn Helgaas wrote: >>> I handle many arch/x86/pci changes, so help those patches get to the >>> PCI patchwork. >>&

Re: [PATCH] MAINTAINERS: Add arch/x86/pci to PCI file patterns

2013-10-09 Thread Bjorn Helgaas
On Wed, Oct 9, 2013 at 3:11 PM, Joe Perches wrote: > Hey Bjorn > > On Wed, 2013-10-09 at 15:02 -0600, Bjorn Helgaas wrote: >> I handle many arch/x86/pci changes, so help those patches get to the >> PCI patchwork. > > [] >> diff --git a/MAINTAINERS b/MAINTAINERS

Re: [PATCH] Fix coalescing host bridge windows in arch/x86/pci/acpi.c

2013-10-09 Thread Bjorn Helgaas
which still overlap: [io 0x-0xdfff] // #0 [io 0x03e0-0x0cf7] // #1 The fix is to expand the *second* overlapping resource and ignore the first, so we get this instead with no overlaps: [io 0x-0xdfff] // #2 [bhelgaas: changelog] Reference: https://bugzilla.kernel.org/show_bug.cgi?id=62

Re: [ 3.8.y.z extended stable ] Linux 3.8.13.11 stable review

2013-10-10 Thread Bjorn Helgaas
On Thu, Oct 10, 2013 at 9:40 AM, Kamal Mostafa wrote: > This is the start of the review cycle for the Linux 3.8.13.11 stable kernel. Would anybody be interested in adding some sort of "stable" tag to the subject lines of stable backport patches, e.g., instead of: [PATCH 001/104] htb: fix sign

Re: [PATCH v8 6/6] PCI: update device mps when doing pci hotplug

2013-08-29 Thread Bjorn Helgaas
[+cc linux-kernel, since more folks might be interested] On Mon, Aug 26, 2013 at 6:39 PM, Yinghai Lu wrote: > On Mon, Aug 26, 2013 at 2:33 PM, Bjorn Helgaas wrote: >> The current Linux default is PCIE_BUS_TUNE_OFF, and given that I don't >> want to touch any MPS settings i

Re: [PATCH v8 6/6] PCI: update device mps when doing pci hotplug

2013-08-29 Thread Bjorn Helgaas
On Thu, Aug 29, 2013 at 3:47 PM, Yinghai Lu wrote: > On Thu, Aug 29, 2013 at 2:09 PM, Bjorn Helgaas wrote: >> [+cc linux-kernel, since more folks might be interested] > >> I don't know what the BIOS "auto" setting means, but it must mean >> something in cas

Re: [PATCH v4] ACPI: Fix osc flag setup ordering to allow pcie hotplug use when available

2013-08-29 Thread Bjorn Helgaas
2012 +0900 > > PCI/ACPI: Request _OSC control before scanning PCI root bus > > went in to allow us to query the pcie hotplug flags during the acpi bus scan. > It however caused problems with the disabling of pcie aspm, and so: > commit b8178f130e25c1bdac1c33e0996f1ff6e20ec08e

Re: [PATCH v8 6/6] PCI: update device mps when doing pci hotplug

2013-08-30 Thread Bjorn Helgaas
On Thu, Aug 29, 2013 at 4:46 PM, Yinghai Lu wrote: > On Thu, Aug 29, 2013 at 3:22 PM, Bjorn Helgaas wrote: >> >> Note that I think Linux *should* eventually actively manage MPS, and >> when it does, case 3 should "just work". I just don't understand what >

[GIT PULL] PCI changes for v3.12

2013-09-03 Thread Bjorn Helgaas
eil Horman) - Assign resources on per-host bridge basis (Yinghai Lu) MPS (Max Payload Size) - Allow larger MPS settings below hotplug-capable Root Port (Yijing Wang) - Add warnings about unsafe MPS settings (Yijing Wang) - Simplify interface and messages (Bjorn Helgaas) SR-IOV

Re: [Ksummit-2013-discuss] [PATCH] checkpatch: Add comment about updating Documentation/CodingStyle

2013-09-03 Thread Bjorn Helgaas
On Mon, Sep 2, 2013 at 6:39 PM, Fengguang Wu wrote: > Thanks! Yes I'm now running checkpatch these days because some people > suggested to me that some of the checkpatch warnings do help catch > real bugs. > > However I do try to avoid upsetting people with maybe-subjective > warnings. A checkpat

Re: [PATCH] pci.h: Fix typo, remove unnecessary !!

2013-09-03 Thread Bjorn Helgaas
On Tue, Sep 03, 2013 at 01:31:05PM -0700, Joe Perches wrote: > Use normal kernel-doc "Returns:" instead of retruns > Assignment to bool is always 1 or 0 so the !! isn't necessary. > > Signed-off-by: Joe Perches Applied to pci/misc, thanks. This branch will be rebased and will not appear in -nex

Re: [PATCH 1/7] scsi/bfa: use pcie_capability_xxx to simplify code

2013-09-03 Thread Bjorn Helgaas
On Tue, Sep 03, 2013 at 03:35:09PM +0800, Yijing Wang wrote: > Pcie_capability_xxx() interfaces were introudced to > simplify code to access PCIe Cap config space. And > because PCI core saves the PCIe Cap offset in > set_pcie_port_type() when device is enumerated. > So we can use pci_is_pcie() ins

Re: [PATCH 2/7] scsi/csiostor: use pcie_capability_xxx to simplify code

2013-09-03 Thread Bjorn Helgaas
On Tue, Sep 03, 2013 at 03:35:10PM +0800, Yijing Wang wrote: > Pcie_capability_xxx() interfaces were introudced to s/introudced/introduced/ > simplify code to access PCIe Cap config space. And > because PCI core saves the PCIe Cap offset in > set_pcie_port_type() when device is enumerated. > So w

Re: linux-next: build warning after merge of the pci tree

2013-09-03 Thread Bjorn Helgaas
On Tue, Sep 3, 2013 at 5:55 PM, Stephen Rothwell wrote: > Hi Bjorn, > > You have sent a pull request to Linus for the pci tree, but at the same > time you have reset the branch I pull into linux-next to be v3.11. So > you have effectively removed all that code from linux-next until Linus' > merge

Re: [PATCH 1/7] scsi/bfa: use pcie_capability_xxx to simplify code

2013-09-03 Thread Bjorn Helgaas
On Tue, Sep 3, 2013 at 5:34 PM, Bjorn Helgaas wrote: > On Tue, Sep 03, 2013 at 03:35:09PM +0800, Yijing Wang wrote: >> Pcie_capability_xxx() interfaces were introudced to >> simplify code to access PCIe Cap config space. And >> because PCI core saves the PCIe Cap offset in

Re: [PATCH 4/7] x86/pci: use pcie_cap to simplify code

2013-09-03 Thread Bjorn Helgaas
On Tue, Sep 03, 2013 at 03:35:12PM +0800, Yijing Wang wrote: > PCI core saves PCIe Cap offset in pcie_cap, > use pcie_cap to simplify code. > > Signed-off-by: Yijing Wang > --- > arch/x86/pci/fixup.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/x86/pci/fix

PCI host merge strategy and maintainers

2013-09-25 Thread Bjorn Helgaas
There are patches for exynos, imx6, mvebu, and tegra on the PCI list, and I want to sort out how people expect them to be merged. My current assumption is the following: drivers/pci/host/pcie-designware.c via PCI tree since I applied recent changes drivers/pci/host/pci-exynos.c via PCI tree

Re: [PATCH 1/3] msi: add forgotten pci_dev_put(pdev) to populate_msi_sysfs()

2013-09-25 Thread Bjorn Helgaas
On Wed, Sep 25, 2013 at 5:23 PM, Neil Horman wrote: > On Wed, Sep 25, 2013 at 03:08:05PM -0600, Bjorn Helgaas wrote: >> [+cc Neil (he added this code in da8d1c8ba4), Greg] >> >> On Mon, Sep 16, 2013 at 7:47 PM, Veaceslav Falico wrote: >> > Before trying to ko

Re: [PATCH V3] PCI: exynos: add support for MSI

2013-09-25 Thread Bjorn Helgaas
va Reddy Kallam >> Signed-off-by: Srikanth T Shivanand >> Signed-off-by: Jingoo Han >> Cc: Pratyush Anand >> Cc: Mohit KUMAR > > Hi Bjorn Helgaas, > > There is no comment for last 3 weeks. > Would you merge this patch to your tree? I worked on merging y

Re: [PATCH 1/3] msi: add forgotten pci_dev_put(pdev) to populate_msi_sysfs()

2013-09-26 Thread Bjorn Helgaas
[+cc Russell] On Thu, Sep 26, 2013 at 04:07:51PM +0200, Veaceslav Falico wrote: > On Thu, Sep 26, 2013 at 02:25:52PM +0200, Veaceslav Falico wrote: > >On Wed, Sep 25, 2013 at 05:35:54PM -0600, Bjorn Helgaas wrote: > >>On Wed, Sep 25, 2013 at 5:23 PM, Neil Horman wrote: > &g

Re: [PATCH] kernel: replace strict_strto*() with kstrto*()

2013-09-27 Thread Bjorn Helgaas
[+cc Jean] On Mon, Jul 22, 2013 at 2:39 AM, Jingoo Han wrote: > The usage of strict_strto*() is not preferred, because > strict_strto*() is obsolete. Thus, kstrto*() should be > used. > > Signed-off-by: Jingoo Han > --- > kernel/gcov/fs.c |2 +- > kernel/ksysfs.c |2 +- > kernel/params

Re: kobject_add_internal failed for msi_irqs with -EEXIST

2013-09-27 Thread Bjorn Helgaas
[+cc Veaceslav, linux-pci] On Fri, Sep 27, 2013 at 7:34 AM, Zdenek Kabelac wrote: > Hi > > With recent build of 3.12-rc2 I'm getting this warning report from kernel: > (hw Lenovo T61, C2D, 4GB Ram) > (repost since linux-kernel@ rejected my gmail email) This looks related to the MSI/kobject i

Re: Crash of 3.12-rc2 BUG: unable to handle kernel NULL pointer dereference

2013-09-27 Thread Bjorn Helgaas
[+cc Thomas, Russell] On Fri, Sep 27, 2013 at 7:13 AM, Zdenek Kabelac wrote: > Dne 27.9.2013 13:57, Zdenek Kabelac napsal(a): > >> Hi >> >> >> I'm trying to use -rc2 kernel however I'm getting quite often regular >> kernel >> panic: >> >> Here is a BUG trace from kvm running this kernel: >> (I'm

Re: PCI host merge strategy and maintainers

2013-09-27 Thread Bjorn Helgaas
On Thu, Sep 26, 2013 at 9:02 AM, Jason Cooper wrote: > On Wed, Sep 25, 2013 at 05:28:28PM -0600, Bjorn Helgaas wrote: >> There are patches for exynos, imx6, mvebu, and tegra on the PCI list, >> and I want to sort out how people expect them to be merged. >> >> M

Re: [PATCH V3] PCI: exynos: add support for MSI

2013-09-27 Thread Bjorn Helgaas
On Fri, Sep 6, 2013 at 12:54 AM, Jingoo Han wrote: > This patch adds support for Message Signaled Interrupt in the > Exynos PCIe diver using Synopsys designware PCIe core IP. > > Signed-off-by: Siva Reddy Kallam > Signed-off-by: Srikanth T Shivanand > Signed-off-by: Jingoo Han > Cc: Pratyush An

Re: [PATCHSET] sysfs: use seq_file and unify regular and bin file handling

2013-09-30 Thread Bjorn Helgaas
On Sat, Sep 28, 2013 at 4:15 PM, Tejun Heo wrote: > Hey, again. > > On Sat, Sep 28, 2013 at 05:49:30PM -0400, Tejun Heo wrote: >> 0001-sysfs-remove-unused-sysfs_buffer-pos.patch >> 0002-sysfs-remove-sysfs_buffer-needs_read_fill.patch >> 0003-sysfs-remove-sysfs_buffer-ops.patch >> 0004-sysfs-ad

Re: [PATCH v2] msi: free msi_desc entry only after we've released the kobject

2013-09-30 Thread Bjorn Helgaas
[+cc Russell] On Sat, Sep 28, 2013 at 11:37:27PM +0200, Veaceslav Falico wrote: > On Thu, Sep 26, 2013 at 11:59:51AM +0200, Veaceslav Falico wrote: > >Currently, we first do kobject_put(&entry->kobj) and the kfree(entry), > >however kobject_put() doesn't guarantee us that it was the last reference

Re: [Bug 61811] New: kms mode breaks and using radeon.agpmode=-1

2013-09-23 Thread Bjorn Helgaas
[+cc linux-pci, linux-kernel, dri-devel] On Sat, Sep 21, 2013 at 11:39 AM, wrote: > https://bugzilla.kernel.org/show_bug.cgi?id=61811 > > Bug ID: 61811 >Summary: kms mode breaks and using radeon.agpmode=-1 >Product: Drivers >Version: 2.5 > Kern

Re: checkpatch guide for newbies

2013-09-24 Thread Bjorn Helgaas
On Mon, Sep 23, 2013 at 3:01 AM, Dan Carpenter wrote: > I've written a checkpatch guide for newbies because it seems like they > make the same mistakes over and over. I intend to put it under > Documentation/. Could you look it over? I think this is great. > Introduction > > Th

Re: [Bug 61811] New: kms mode breaks and using radeon.agpmode=-1

2013-09-24 Thread Bjorn Helgaas
[+cc Dave] On Mon, Sep 23, 2013 at 12:33 PM, Bjorn Helgaas wrote: > [+cc linux-pci, linux-kernel, dri-devel] > > On Sat, Sep 21, 2013 at 11:39 AM, > wrote: >> https://bugzilla.kernel.org/show_bug.cgi?id=61811 >> >> Bug ID: 61811 >>

Re: checkpatch guide for newbies

2013-09-24 Thread Bjorn Helgaas
On Tue, Sep 24, 2013 at 1:29 PM, Peter Senna Tschudin wrote: > On Tue, Sep 24, 2013 at 7:26 PM, Alexander Holler > wrote: >>> On Mon, Sep 23, 2013 at 3:01 AM, Dan Carpenter >>> wrote: Long Lines Historically screens were 80 characters wide and it was annoyin

Re: [PATCH 4/6] IB/qib: Use pcie_set_mps() and pcie_get_mps() to simplify code

2013-09-24 Thread Bjorn Helgaas
pported" in pci_dev->pcie_mpss, so use that instead of pcie_capability_read_word(). Remove the unused val2fld() and fld2val(). Signed-off-by: Yijing Wang Signed-off-by: Bjorn Helgaas --- drivers/infiniband/hw/qib/qib_pcie.c | 96 +++--- 1 file changed, 30 inserti

Re: [PATCH 4/6] IB/qib: Use pcie_set_mps() and pcie_get_mps() to simplify code

2013-09-24 Thread Bjorn Helgaas
pcie_capability_read_word(). Remove > the unused val2fld() and fld2val(). I propose the following patch on top of this one: IB/qib: Drop qib_tune_pcie_caps() and qib_tune_pcie_coalesce() return values From: Bjorn Helgaas The callers of qib_tune_pcie_caps() and qib_tune_pcie_coalesce() don&#

Re: [PATCH] PCI: add quirk for 3ware 9650SE controller

2013-09-24 Thread Bjorn Helgaas
On Fri, Sep 6, 2013 at 4:47 PM, Bjorn Helgaas wrote: > On Fri, Sep 6, 2013 at 3:51 AM, Jiri Kosina wrote: >>> >> > Commit d5dea7d95 ("PCI: msi: Disable msi interrupts when we initialize >>> >> > a >>> >> > pci device") makes

Re: [PATCH 1/7] powerpc: Add interface to get msi region information

2013-09-24 Thread Bjorn Helgaas
On Thu, Sep 19, 2013 at 12:59:17PM +0530, Bharat Bhushan wrote: > This patch adds interface to get following information > - Number of MSI regions (which is number of MSI banks for powerpc). > - Get the region address range: Physical page which have the > address/addresses used for generat

Re: [PATCH 2/2] PCI/ACPI: Convert ACPI PCI Hot Plug core debug fuction to dynamic debug function

2013-09-24 Thread Bjorn Helgaas
On Mon, Sep 09, 2013 at 11:17:15PM -0400, tianyu@intel.com wrote: > From: Lan Tianyu > > This patch is to use pr_debug/info/warn/err to replace acpiphp debug > functions and remove module's debug param. > ... > /* local variables */ > @@ -61,9 +60,7 @@ static struct acpiphp_attention_info *

Re: [PATCH 2/2] PCI/ACPI: Convert ACPI PCI Hot Plug core debug fuction to dynamic debug function

2013-09-25 Thread Bjorn Helgaas
On Wed, Sep 25, 2013 at 7:37 AM, Lan Tianyu wrote: > On 09/25/2013 08:19 AM, Bjorn Helgaas wrote: >> >> On Mon, Sep 09, 2013 at 11:17:15PM -0400, tianyu@intel.com wrote: >>> >>> From: Lan Tianyu >>> >>> This patch is to use pr_debug/info/

Re: [PATCH v2 2/6] PCI/MSI: Factor out pci_get_msi_cap() interface

2013-09-25 Thread Bjorn Helgaas
On Fri, Sep 20, 2013 at 07:27:36AM -0500, Tejun Heo wrote: > On Fri, Sep 20, 2013 at 10:24:59AM +0200, Alexander Gordeev wrote: > > * Make pci_enable_msix() return 0/-errno > > My choice would be this one. I agree; it sounds like you've identified several bugs related to the current confusing int

Re: [PATCH 1/3] msi: add forgotten pci_dev_put(pdev) to populate_msi_sysfs()

2013-09-25 Thread Bjorn Helgaas
back - even on out_unroll. > > Fix this by adding pci_dev_put(pdev) before going to unrolling section. > > CC: Bjorn Helgaas > CC: linux-...@vger.kernel.org > CC: linux-kernel@vger.kernel.org > Signed-off-by: Veaceslav Falico > --- > drivers/pci/msi.c | 4 +++- >

Re: [PATCH 1/3] msi: add forgotten pci_dev_put(pdev) to populate_msi_sysfs()

2013-09-25 Thread Bjorn Helgaas
On Wed, Sep 25, 2013 at 3:08 PM, Bjorn Helgaas wrote: > Also, I think it is incorrect that free_msi_irqs() does this: > > if (entry->kobj.parent) { > kobject_del(&entry->kobj); >

Re: [PATCH 3/3] msi: free msi_desc entry only after we've released the kobject

2013-09-25 Thread Bjorn Helgaas
. > > Also, remove the same functionality from populate_msi_sysfs(), cause on > failure we anyway call free_msi_irqs(), which will take care of all the > kobjects properly. I agree; it looks like populate_msi_sysfs() doesn't need to have the cleanup in it. Can you split that int

Re: [PATCH 2/3 v3] Refactor MSI restore call-chain to drop unnecessary argument

2013-09-25 Thread Bjorn Helgaas
On Wed, Aug 28, 2013 at 8:52 PM, Zhenzhong Duan wrote: > ... > -v3: Update patch description per Konrad suggestion, thanks. > > Tested-by: Sucheta Chakraborty > Signed-off-by: Zhenzhong Duan Zhenzhong, would you mind reposting the entire series as a v4 with all updates and acks? I'm not sure I

Re: [PATCH V3 1/4] EFI: Stash ROMs if they're not in the PCI BAR

2012-09-06 Thread Bjorn Helgaas
On Tue, Sep 4, 2012 at 6:45 AM, Matthew Garrett wrote: > On Thu, Aug 23, 2012 at 05:44:22PM -0600, Bjorn Helgaas wrote: >> On Thu, Aug 23, 2012 at 10:36 AM, Matthew Garrett wrote: >> > EFI provides support for providing PCI ROMs via means other than the ROM >> > BAR.

Re: [PATCH] x86: Fix build warning on 32-bit

2012-09-06 Thread Bjorn Helgaas
On Thu, Sep 6, 2012 at 10:36 AM, Matthew Garrett wrote: > Fix up the cast so it doesn't cause issues on 32-bit systems. Thanks! I folded this into the original patch and pushed the updated pci/mjg-pci-roms-from-efi branch. > Signed-off-by: Matthew Garrett > --- > arch/x86/pci/common.c | 2 +-

[GIT PULL] PCI updates for v3.6

2012-09-06 Thread Bjorn Helgaas
decoding is disabled -------- Bjorn Helgaas (1): PCI: Don't print anything while decoding is disabled Huang Ying (4): PCI/PM: Enable D3/D3cold by default for most devices PCI/PM: Keep parent bridge active when probing device PCI/PM: Fix config reg access for D3c

Re: [PATCH v2 -tip 4/5] PCI, MSI: Enable multiple MSIs with pci_enable_msi_block_auto()

2012-09-07 Thread Bjorn Helgaas
Signed-off-by: Alexander Gordeev Acked-by: Bjorn Helgaas I haven't looked at the other patches in this series, but if the x86/IRQ folks like them, I'm OK with this part. Since the series is mostly non-PCI, I think it makes the most sense to keep it all together and merge it through s

Re: [PATCH 0/4] PCI error handler const

2012-09-07 Thread Bjorn Helgaas
On Fri, Sep 7, 2012 at 9:33 AM, Stephen Hemminger wrote: > This is a trivial patch to make PCI error handler function > tables const. Split into pieces so that core changes are first. I put all four of these on this branch: http://git.kernel.org/?p=linux/kernel/git/helgaas/pci.git;a=shortlog;h=r

Re: Question about failure in PCI power-state change

2012-09-07 Thread Bjorn Helgaas
+cc Rafael, Huang, linux-pm On Fri, Sep 7, 2012 at 3:44 PM, Larry Finger wrote: > Hi, > > On occasion when I unload and reload driver rtl8192ce, I get the message > > "Refused to change power state, currently in D3" > > I added additional info to the printk and discovered that it was trying to >

Re: [Resend][PATCH] pciehp: always implement resume

2012-09-07 Thread Bjorn Helgaas
On Fri, Sep 7, 2012 at 2:28 PM, Rafael J. Wysocki wrote: > From: Oliver Neukum > Subject: pciehp: always implement resume > > The driver by default ignores resume. On some laptops > that means that interrupts are not delivered after S3. > So card removals and insertions will not be handled. Requi

<    1   2   3   4   5   6   7   8   9   10   >