Re: [PATCH v6 2/2] mmc: sdhci-msm: Initial support for MSM chipsets

2013-10-05 Thread Bjorn Andersson
Hi Georgi, Thanks for working on this, unfortunately it seems like I need to port the rpm regulators to be able to test this. But I did find that... On Fri, Sep 27, 2013 at 9:57 AM, Georgi Djakov wrote: > ... > +static irqreturn_t sdhci_msm_pwr_irq(int irq, void *data) > +{ > + struct sdhc

Re: [PATCH RFC v2 3/5] spmi: add generic SPMI controller binding documentation

2013-10-05 Thread Bjorn Andersson
On Tue, Aug 27, 2013 at 2:55 PM, Stephen Warren wrote: > On 08/27/2013 11:01 AM, Josh Cartwright wrote: > ... > cell 0 - address type (0: master, 1: unique ID, 2: group ID, ...) I think it would make sense to have the master id as a property of the bus, as you could consider this to indicate diff

Re: [PATCH] mmc: sdhci-msm: Add support for MSM chipsets

2013-07-30 Thread Bjorn Andersson
On Tue, Jul 30, 2013 at 8:22 AM, Georgi Djakov wrote: > This platform driver adds the support of Secure Digital Host > Controller Interface compliant controller in MSM chipsets. > > [snip] > + > + sdhc_1: qcom,sdhc@f9824900 { > + compatible = "qcom,sdhci-msm"; > +

[PATCH] staging: android: logger: Correct write offset reset on error

2013-07-22 Thread Bjorn Andersson
mutex. Cc: Android Kernel Team Signed-off-by: Bjorn Andersson --- drivers/staging/android/logger.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/android/logger.c b/drivers/staging/android/logger.c index 080abf2..a8c3444 100644 --- a/drivers/staging/android

Re: [PATCH 3/4] msm_serial: Make baud_code detection more dynamic

2013-07-25 Thread Bjorn Andersson
On Wed, Jul 24, 2013 at 10:37 AM, Stephen Boyd wrote: > [snip] > + unsigned int i, divisor; > + const struct msm_baud_map *entry; > + static const struct msm_baud_map table[] = { > + { 1536, 0x00, 1 }, > + { 768, 0x11, 1 }, > + { 384,

Re: [PATCH v2 1/4] remoteproc: Introduce auto-boot flag

2016-09-19 Thread Bjorn Andersson
On Fri 16 Sep 16:58 PDT 2016, Suman Anna wrote: > Hi Bjorn, > > On 09/08/2016 05:27 PM, Bjorn Andersson wrote: > > On Wed 31 Aug 11:27 PDT 2016, Suman Anna wrote: > > > >> Hi Bjorn, > >> > >> On 08/11/2016 04:52 PM, Bjorn Andersson wrote: > >

[PATCH 1/6] wcn36xx: Fold indication payload into message header

2016-06-19 Thread Bjorn Andersson
From: Bjorn Andersson Merge the two allocation instead of separately allocating room for the indication payload. Signed-off-by: Bjorn Andersson Signed-off-by: Bjorn Andersson --- drivers/net/wireless/ath/wcn36xx/smd.c | 15 ++- drivers/net/wireless/ath/wcn36xx/smd.h | 2 +- 2

[PATCH 3/6] wcn36xx: Split mmio space into explicit regions

2016-06-19 Thread Bjorn Andersson
Split the wcnss mmio space into explicit regions for ccu and dxe and acquire these from the node referenced by the qcom,mmio phandle. Signed-off-by: Bjorn Andersson --- drivers/net/wireless/ath/wcn36xx/dxe.c | 26 --- drivers/net/wireless/ath/wcn36xx/dxe.h | 6 ++-- drivers

[PATCH 4/6] wcn36xx: Correct DXE chip version differentiation

2016-06-19 Thread Bjorn Andersson
The CCU block in WCNSS is configured for appropriate routing of interrupts from the DXE to the application cpu, this is not dependant on the iris version (wcn3660 vs wcn3680), but rather if the SoC has a riva or pronto built in. Signed-off-by: Bjorn Andersson --- drivers/net/wireless/ath

[PATCH 2/6] wcn36xx: Change indication list lock to spinlock

2016-06-19 Thread Bjorn Andersson
From: Bjorn Andersson In preparation for handling incoming messages from IRQ context, change the indication list lock to a spinlock Signed-off-by: Bjorn Andersson Signed-off-by: Bjorn Andersson --- drivers/net/wireless/ath/wcn36xx/smd.c | 12 ++-- drivers/net/wireless/ath/wcn36xx

[PATCH 5/6] wcn36xx: Transition driver to SMD client

2016-06-19 Thread Bjorn Andersson
The wcn36xx wifi driver follows the life cycle of the WLAN_CTRL SMD channel, as such it should be a SMD client. This patch makes this transition, now that we have the necessary frameworks available. Signed-off-by: Bjorn Andersson --- This patch depends on the devicetree binding approved by Rob

[PATCH 6/6] wcn36xx: Fix up wcn36xx_smd_update_scan_params()

2016-06-19 Thread Bjorn Andersson
Fix up the wcn36xx_smd_update_scan_params() to work with non-ancient versions of the firmware and support actually specifying the list of channels. Signed-off-by: Bjorn Andersson --- drivers/net/wireless/ath/wcn36xx/hal.h | 4 ++-- drivers/net/wireless/ath/wcn36xx/smd.c | 15

Re: [PATCH v2 1/2] remoteproc: qcom: Driver for the self-authenticating Hexagon v5

2016-06-20 Thread Bjorn Andersson
On Mon 20 Jun 07:48 PDT 2016, Srinivas Kandagatla wrote: > Thanks Bjorn for this patch, > > I will start playing with patch soon, but here are few comments. > > On 17/06/16 18:17, Bjorn Andersson wrote: > >From: Bjorn Andersson > > > >This initial hack powers

[PATCH v3 2/2] dt-binding: remoteproc: Introduce Hexagon loader binding

2016-06-20 Thread Bjorn Andersson
This document defines the binding for a component that loads firmware and control the life cycle of a self-authenticating Qualcomm Hexagon core. Acked-by: Rob Herring Signed-off-by: Bjorn Andersson --- Changes since v2: - None Changes since v1: - Corrected reg-names in the example

[PATCH v3 1/2] remoteproc: qcom: Driver for the self-authenticating Hexagon v5

2016-06-20 Thread Bjorn Andersson
From: Bjorn Andersson This initial hack powers the q6v5, boots and authenticate the mba and use that to load the mdt and subsequent bXX files. Signed-off-by: Bjorn Andersson Signed-off-by: Bjorn Andersson --- Changes since v2: - Balancing the rom_clk calls - Moved reset wait to the reset

Re: [PATCH v9 3/4] ARM: dts: rockchip: add syscon-reboot-mode DT node

2016-06-20 Thread Bjorn Andersson
On Sun 19 Jun 23:39 PDT 2016, Andy Yan wrote: > Rockchip platform use a SYSCON mapped register store > the reboot mode magic value for bootloader to use when > system reboot. So add syscon-reboot-mode driver DT node > for rk3xxx/rk3036/rk3288 based platform > > Reviewed-by: Matthias Brugger > Si

Re: [PATCH v2 1/8] arm64: dts: db820c: add basic board support

2016-06-21 Thread Bjorn Andersson
On Tue 21 Jun 10:22 PDT 2016, Srinivas Kandagatla wrote: [..] > diff --git a/arch/arm64/boot/dts/qcom/apq8096-db820c.dts > b/arch/arm64/boot/dts/qcom/apq8096-db820c.dts [..] > + > +/ { > + model = "Qualcomm Technologies, Inc. DB820c"; > + compatible = "qcom,apq8096-sbc"; I'm still not bu

Re: [PATCH 1/5] mfd: pm8921: Add support for pm8018

2016-06-21 Thread Bjorn Andersson
On Fri 17 Jun 03:22 PDT 2016, Neil Armstrong wrote: > In order to support the Qualcomm MDM9615 PMIC, add support for the > pm8018 in pm8921 mfd driver. > > Signed-off-by: Neil Armstrong Reviewed-by: Bjorn Andersson Regards, Bjorn

Re: [PATCH 3/5] rtc: rtc-pm8xxx: Add support for pm8018 rtc

2016-06-21 Thread Bjorn Andersson
"qcom,pm8941-rtc" > + "qcom,pm8018-rtc" Would be nice if we kept this sorted, but the patch looks good. Reviewed-by: Bjorn Andersson Regards, Bjorn

Re: [PATCH 2/5] input: pmic8xxx-pwrkey: Add support for pm8018 pwrkey

2016-06-21 Thread Bjorn Andersson
On Fri 17 Jun 03:22 PDT 2016, Neil Armstrong wrote: > In order to support pwrkey for Qualcomm MDM9615 SoC, add support > for the pm8018 pwrkey in pmic8xxx-pwrkey. > > Signed-off-by: Neil Armstrong Reviewed-by: Bjorn Andersson Regards, Bjorn

Re: [PATCH 4/5] mfd: qcom-rpm: Add support for pm8018 RPM Regulator

2016-06-21 Thread Bjorn Andersson
218 > +#define QCOM_RPM_PM8018_LVS1 219 > +#define QCOM_RPM_NCP 220 We already have PM8921_NCP and PM8058_NCP, so better make this QCOM_RPM_PM8018_NCP for consistency. > +#define QCOM_RPM_VOLTAGE_CORNER 221 > + Other then these details Acked-by: Bjorn Andersson Regards, Bjorn

Re: [PATCH] pinctrl: qcom: fix masking of pinmux functions

2016-09-26 Thread Bjorn Andersson
unction selection bits") Please use the format: Fixes: %h (\"%s\") > > > > Signed-off-by: John Crispin > > Now I'm confused how it ever worked but agreed, the code looks wrong. I agree, we should have seen some issues based on this, I presume we

Re: [PATCH v9 17/19] drm/virtio: kconfig: Fix recursive dependency issue.

2016-09-27 Thread Bjorn Andersson
On Wed 21 Sep 05:09 PDT 2016, Emil Velikov wrote: > On 20 September 2016 at 09:32, Peter Griffin wrote: > > Hi Emil, > > > > On Tue, 20 Sep 2016, Emil Velikov wrote: > > > >> On 5 September 2016 at 14:16, Peter Griffin > >> wrote: > >> > ST_SLIM_REMOTEPROC must select REMOTEPROC, which exposes

Re: Ongoing remoteproc discussions

2016-07-28 Thread Bjorn Andersson
On Mon 25 Jul 05:26 PDT 2016, Peter Griffin wrote: > Hi Bjorn, > > On Mon, 18 Jul 2016, Bjorn Andersson wrote: > > > During discussions with various people interested in moving their > > remoteproc-related out-of-tree patches towards mainline I have come > > acros

Re: [RFC v0 7/8] Input: ims-pcu: use firmware_stat instead of completion

2016-07-28 Thread Bjorn Andersson
On Thu 28 Jul 11:33 PDT 2016, Dmitry Torokhov wrote: > On Thu, Jul 28, 2016 at 09:55:11AM +0200, Daniel Wagner wrote: > > From: Daniel Wagner > > [..] > > Do not quite like it... I'd rather asynchronous request give out a > firmware status pointer that could be used later on. > > pcu->fw

Re: [Regression] "irqdomain: Don't set type when mapping an IRQ" breaks nexus7 gpio buttons

2016-07-29 Thread Bjorn Andersson
On Fri 29 Jul 21:39 PDT 2016, John Stultz wrote: > Hey Jon, > So after rebasing my nexus7 patch stack onto pre-4.8-rc1 tree, I > noticed the power/volume buttons stopped working. > +Linus, as that's gpio-keys on top of two fairly standard gpio/pinctrl drivers (8064 TLMM and SSBI). Regards, Bj

Re: [RFC v0 7/8] Input: ims-pcu: use firmware_stat instead of completion

2016-08-01 Thread Bjorn Andersson
On Sat 30 Jul 09:58 PDT 2016, Luis R. Rodriguez wrote: > On Sat, Jul 30, 2016 at 02:42:41PM +0200, Arend van Spriel wrote: > > + Luis (again) ;-) > > > > On 29-07-16 08:13, Daniel Wagner wrote: > > > On 07/28/2016 09:01 PM, Bjorn Andersson wrote: > > >

[PATCH 3/4] remoteproc: Move vdev handling to boot/shutdown

2016-08-01 Thread Bjorn Andersson
y a client driver. Cc: Lee Jones Cc: Loic Pallardy Signed-off-by: Bjorn Andersson --- drivers/remoteproc/remoteproc_core.c | 34 ++ 1 file changed, 14 insertions(+), 20 deletions(-) diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remotep

[PATCH 1/4] remoteproc: Introduce always-on flag

2016-08-01 Thread Bjorn Andersson
Introduce an "always-on" flag on rprocs to make it possible to flag remote processors without vdevs to automatically boot once the firmware is found. Cc: Lee Jones Cc: Loic Pallardy Signed-off-by: Bjorn Andersson --- drivers/remoteproc/remoteproc_cor

[PATCH 4/4] remoteproc: Move handling of cached table to boot/shutdown

2016-08-01 Thread Bjorn Andersson
-off-by: Bjorn Andersson --- drivers/remoteproc/remoteproc_core.c | 55 include/linux/remoteproc.h | 2 -- 2 files changed, 18 insertions(+), 39 deletions(-) diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c

[PATCH 2/4] remoteproc: Calculate max_notifyid during load

2016-08-01 Thread Bjorn Andersson
The calculation of max_notifyid must only be done before we call start() on the remoteproc drivers, so move the calculation to be part of the loading steps. Cc: Lee Jones Cc: Loic Pallardy Signed-off-by: Bjorn Andersson --- drivers/remoteproc/remoteproc_core.c | 16 1 file

Re: [RFC] fs: add userspace critical mounts event support

2016-09-06 Thread Bjorn Andersson
On Fri 02 Sep 21:11 PDT 2016, Linus Torvalds wrote: Linus, I reversed the order of your questions/answers to fit my answer better. > On Fri, Sep 2, 2016 at 5:20 PM, Luis R. Rodriguez wrote: > > > > Thoughts ? > What are the drivers that need this, and why can't those drivers just > be fixed to n

Re: [PATCH v2 1/3] remoteproc: Modify FW_RSC_ADDR_ANY definition

2016-09-06 Thread Bjorn Andersson
On Tue 06 Sep 00:39 PDT 2016, Loic Pallardy wrote: > Replace 0x by -1 to fit any type. > > Signed-off-by: Loic Pallardy Applied, thanks > --- > include/linux/remoteproc.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/remoteproc.h b/inc

Re: [PATCH v2 2/3] remoteproc: core: transform struct fw_rsc_vdev_vring reserved field in pa

2016-09-06 Thread Bjorn Andersson
On Tue 06 Sep 00:39 PDT 2016, Loic Pallardy wrote: > In current implementation, struct fw_rsc_vdev_vring which describes > vring resource in firmware resource table owns only device address, > because it assumes that host is responsible of vring allocation and > only device address is needed by co

Re: [RFC] fs: add userspace critical mounts event support

2016-09-06 Thread Bjorn Andersson
On Tue 06 Sep 11:32 PDT 2016, Linus Torvalds wrote: > On Tue, Sep 6, 2016 at 10:46 AM, Bjorn Andersson > wrote: > > > > Linus, I reversed the order of your questions/answers to fit my answer > > better. > > Nobody has actually answered the "why don'

[PATCH v4 1/4] soc: qcom: wcnss_ctrl: Stub wcnss_ctrl API

2016-09-06 Thread Bjorn Andersson
Stub the wcnss_ctrl API to allow compile testing wcnss function drivers. Cc: Marcel Holtmann Signed-off-by: Bjorn Andersson --- There are no other pending changes colliding with this, so if Andy is okay with this it could be merged through Kalle's tree - together with the other pa

[PATCH v4 3/4] wcn36xx: Implement firmware assisted scan

2016-09-06 Thread Bjorn Andersson
Using the software based channel scan mechanism from mac80211 keeps us offline for 10-15 second, we should instead issue a start_scan/end_scan on each channel reducing this time. Signed-off-by: Bjorn Andersson --- Changes since v3: - None Changes since v2: - Match prototype change of

[PATCH v4 2/4] wcn36xx: Transition driver to SMD client

2016-09-06 Thread Bjorn Andersson
The wcn36xx wifi driver follows the life cycle of the WLAN_CTRL SMD channel, as such it should be a SMD client. This patch makes this transition, now that we have the necessary frameworks available. Signed-off-by: Bjorn Andersson --- Changes since v3: - Made msg_header const in

[PATCH v4 4/4] wcn36xx: Implement print_reg indication

2016-09-06 Thread Bjorn Andersson
Some firmware versions sends a "print register indication", handle this by printing out the content. Cc: Nicolas Dechesne Signed-off-by: Bjorn Andersson --- Changes since v3: - Rebased separate patch onto this series drivers/net/wireless/ath/wcn36xx/hal.h | 16 d

Re: [RFC] fs: add userspace critical mounts event support

2016-09-06 Thread Bjorn Andersson
On Tue 06 Sep 14:52 PDT 2016, Luis R. Rodriguez wrote: > We already have MODULE_FIRMWARE(), we could have MODULE_FIRMWARE_REQ() or > something like it to help annotate the the driver was only functional with the > firmware, punt things to kmod to deal with the requirements. That implies that a si

Re: [PATCH v4 2/4] wcn36xx: Transition driver to SMD client

2016-09-08 Thread Bjorn Andersson
On Thu, Sep 8, 2016 at 5:16 AM, Kalle Valo wrote: > Bjorn Andersson writes: > >> The wcn36xx wifi driver follows the life cycle of the WLAN_CTRL SMD >> channel, as such it should be a SMD client. This patch makes this >> transition, now that we have the necess

Re: [PATCH v2 1/4] remoteproc: Introduce auto-boot flag

2016-09-08 Thread Bjorn Andersson
On Wed 31 Aug 11:27 PDT 2016, Suman Anna wrote: > Hi Bjorn, > > On 08/11/2016 04:52 PM, Bjorn Andersson wrote: > > Introduce an "auto-boot" flag on rprocs to make it possible to flag > > remote processors without vdevs to automatically boot once the firmware

Re: [PATCH] dt-binding: remoteproc: Document generic properties

2016-09-08 Thread Bjorn Andersson
On Thu 08 Sep 19:33 PDT 2016, Rob Herring wrote: > On Thu, Sep 8, 2016 at 1:32 PM, Suman Anna wrote: > > Hi Rob, > > > > On 09/08/2016 11:50 AM, Rob Herring wrote: > >> On Fri, Sep 02, 2016 at 04:45:45PM -0500, Suman Anna wrote: > >>> On 08/12/2016 05:4

Re: [PATCH v4 2/4] wcn36xx: Transition driver to SMD client

2016-09-08 Thread Bjorn Andersson
On Thu 08 Sep 10:35 PDT 2016, Kalle Valo wrote: > Bjorn Andersson writes: > > > On Thu, Sep 8, 2016 at 5:16 AM, Kalle Valo wrote: > >> Bjorn Andersson writes: > >> > >>> The wcn36xx wifi driver follows the life cycle of the WLAN_CTRL SMD > >>

Re: [PATCH v2 01/17] rpmsg: Enable matching devices with drivers based on DT

2016-09-08 Thread Bjorn Andersson
On Wed 07 Sep 18:46 PDT 2016, spjo...@codeaurora.org wrote: > On 2016-09-01 15:27, Bjorn Andersson wrote: > >Make it possible to match rpmsg devices based on device tree node, in > >addition to the id table. In some of these cases the rpmsg driver would > >not have a i

Re: [PATCH] ARM: dts: msm8974: Add definitions for QCE & cryptobam

2016-09-12 Thread Bjorn Andersson
On Tue 30 Aug 08:37 PDT 2016, Iaroslav Gridin wrote: > From: Voker57 > > Add device tree definitions for Qualcomm Cryptography engine and its BAM > Signed-off-by: Iaroslav Gridin > --- > arch/arm/boot/dts/qcom-msm8974.dtsi | 42 > + > 1 file changed, 42 ins

Re: [PATCH] crypto: qce: Initialize core src clock @100Mhz

2016-09-12 Thread Bjorn Andersson
On Sat 03 Sep 09:45 PDT 2016, Iaroslav Gridin wrote: > Without that, QCE performance is about 2x less. > > Signed-off-by: Iaroslav Gridin > --- > drivers/crypto/qce/core.c | 18 +- > drivers/crypto/qce/core.h | 2 +- > 2 files changed, 18 insertions(+), 2 deletions(-) > > diff

Re: [PATCH v9 01/19] remoteproc: st_slim_rproc: add a slimcore rproc driver

2016-09-13 Thread Bjorn Andersson
uccessfully with fdma driver. > > Signed-off-by: Peter Griffin Acked-by: Bjorn Andersson Regards, Bjorn > --- > drivers/remoteproc/Kconfig | 4 + > drivers/remoteproc/Makefile | 1 + > drivers/remoteproc/st_slim_rproc.c | 364 > +++

Re: [PATCH v9 00/19] Add support for FDMA DMA controller and slim core rproc found on STi chipsets

2016-09-13 Thread Bjorn Andersson
On Tue 13 Sep 02:31 PDT 2016, Peter Griffin wrote: > Hi Vinod & Bjorn, > > [..] > > On Mon, 05 Sep 2016, Peter Griffin wrote: > > > v8 actions some review feedback from Bjorn to the slim rproc driver, and > > also includes > > a patch which fixes a recursive Kconfig error which is triggered wh

[PATCH] remoteproc: Drop unnecessary NULL check

2016-09-13 Thread Bjorn Andersson
rproc_alloc() will make sure that the "firmware" pointer is either a driver supplied value or pointing to a generated firmware filename, it can't be NULL. So drop the extra check in the rproc_boot() path. Signed-off-by: Bjorn Andersson --- drivers/remoteproc/remoteproc_core.c

Re: [PATCH v2 3/3] remoteproc: core: add rproc ops for memory allocation

2016-09-15 Thread Bjorn Andersson
On Tue 06 Sep 00:39 PDT 2016, Loic Pallardy wrote: > Remoteproc core is currently using dma_alloc_coherent for > carveout and vring allocation. > It doesn't allow to support specific use cases like fixed memory > region or internal RAM support. > > Two new rproc ops (alloc and free) is added to p

Re: [PATCH v2 07/19] remoteproc: Add new resource type for resource table spare bytes

2016-09-15 Thread Bjorn Andersson
On Wed 31 Aug 13:50 PDT 2016, Loic Pallardy wrote: > To allow resource appending to an existing resource table, > remoteproc framework should get information about resource > table spare area. With current resource table construction, > remoteproc is not able to identify by itself any free locatio

Re: [PATCH v2 18/19] remoteproc: core: Add function to create remoteproc local resource table

2016-09-15 Thread Bjorn Andersson
On Wed 31 Aug 13:50 PDT 2016, Loic Pallardy wrote: > Rproc driver has now the capability to add resources dynamically > thanks to rproc_request_resource API. > Depending on associated action, resource request could impact > firmware resource table or define new local resource. > > In order to pre

Re: [PATCH 2/2] remoteproc: core: Add fixed memory region support

2016-08-31 Thread Bjorn Andersson
On Tue 30 Aug 16:13 PDT 2016, Suman Anna wrote: > >>> +if (rsc->vring[i].da != 0 && rsc->vring[i].da != FW_RSC_ADDR_ANY) { [..] > >> @Suman, do you have any input on this? > Thanks Suman > I was thinking about this as well, and the way I actually envisioned > this is to add additional rproc

[PATCH v3 2/2] wcn36xx: Implement firmware assisted scan

2016-09-01 Thread Bjorn Andersson
Using the software based channel scan mechanism from mac80211 keeps us offline for 10-15 second, we should instead issue a start_scan/end_scan on each channel reducing this time. Signed-off-by: Bjorn Andersson --- Changes since v2: - None drivers/net/wireless/ath/wcn36xx/main.c| 64

[PATCH v3 1/2] wcn36xx: Transition driver to SMD client

2016-09-01 Thread Bjorn Andersson
The wcn36xx wifi driver follows the life cycle of the WLAN_CTRL SMD channel, as such it should be a SMD client. This patch makes this transition, now that we have the necessary frameworks available. Signed-off-by: Bjorn Andersson --- Changes since v2: - Correct the call to the new

[PATCH v2 03/17] rpmsg: rpmsg_send() operations takes rpmsg_endpoint

2016-09-01 Thread Bjorn Andersson
rpmsg_sendto() to respond to messages, even on secondary endpoints. In addition this would allow us to support operations on multiple channels in future backends that does not support off-channel operations. Signed-off-by: Bjorn Andersson --- Changes since v1: - Announcing the primary endpoint&#

[PATCH v2 00/17] Make rpmsg a framework

2016-09-01 Thread Bjorn Andersson
o rpmsg_core into several commits - Dropped the wrapping struct in rpmsg_core and just added the ops to the public API (but hid the implementation details) - Reordered things to reduce the size of the later patches Bjorn Andersson (17): rpmsg: Enable matching devices with drivers based on DT rpmsg:

[PATCH v2 08/17] rpmsg: Indirection table for rpmsg_endpoint operations

2016-09-01 Thread Bjorn Andersson
Add indirection table for rpmsg_endpoint related operations and move virtio implementation behind this, this finishes of the decoupling of the virtio implementation from the public API. Signed-off-by: Bjorn Andersson --- Per Loic's comment I did consider adding parameter validation t

[PATCH v2 13/17] rpmsg: Hide rpmsg indirection tables

2016-09-01 Thread Bjorn Andersson
Move the device and endpoint indirection tables to the rpmsg internal header file, to hide them from the public API. Signed-off-by: Bjorn Andersson --- Changes since v1: - None drivers/rpmsg/rpmsg_core.c | 3 +++ drivers/rpmsg/rpmsg_internal.h | 47

[PATCH v2 07/17] rpmsg: Move rpmsg_device API to new file

2016-09-01 Thread Bjorn Andersson
Extract the now indirect rpmsg_create_ept() interface to a separate file and start building up a rpmsg core. Signed-off-by: Bjorn Andersson --- Changes since v1: - Extracted the big move into several smaller patches drivers/remoteproc/Kconfig | 4 +-- drivers/rpmsg/Kconfig

[PATCH v2 17/17] rpmsg: Introduce Qualcomm SMD backend

2016-09-01 Thread Bjorn Andersson
original work by Sricharan R Cc: Sricharan R Signed-off-by: Bjorn Andersson --- Changes since v1: - Rebased from latest linux-next version of SMD drivers/rpmsg/Kconfig| 10 + drivers/rpmsg/Makefile |1 + drivers/rpmsg/qcom_smd.c | 1434

[PATCH v2 14/17] rpmsg: virtio: Hide vrp pointer from the public API

2016-09-01 Thread Bjorn Andersson
Create a container struct virtio_rpmsg_channel around the rpmsg_channel to keep virtio backend information separate from the rpmsg and public API. This makes the public structures independant of virtio. Signed-off-by: Bjorn Andersson --- Changes since v1: - Reduced complexity from the move of

[PATCH v2 12/17] rpmsg: Split rpmsg core and virtio backend

2016-09-01 Thread Bjorn Andersson
Extract the generic rpmsg core functionality from the virtio rpmsg implementation, splitting the implementation in a rpmsg core and a virtio backend. Based on initial work by Sricharan R Cc: Sricharan R Signed-off-by: Bjorn Andersson --- Changes since v1: - Split out part of this move to

[PATCH v2 15/17] rpmsg: Move virtio specifics from public header

2016-09-01 Thread Bjorn Andersson
Move virtio rpmsg implementation details from the public header file to the virtio rpmsg implementation. Signed-off-by: Bjorn Andersson --- Changes since v1: - None drivers/rpmsg/virtio_rpmsg_bus.c | 52 include/linux/rpmsg.h| 52

[PATCH v2 16/17] rpmsg: Allow callback to return errors

2016-09-01 Thread Bjorn Andersson
Some rpmsg backends support holding on to and redelivering messages upon failed handling of them, so provide a way for the callback to report and error and allow the backends to handle this. Signed-off-by: Bjorn Andersson --- Changes since v1: - None drivers/rpmsg/virtio_rpmsg_bus.c| 10

[PATCH v2 10/17] rpmsg: Move helper for finding rpmsg devices to core

2016-09-01 Thread Bjorn Andersson
Extract and move the helper function for finding rpmsg child devices to the core. Signed-off-by: Bjorn Andersson --- Changes since v1: - Extracted this from the big move to rpmsg_core.c in v1 drivers/rpmsg/rpmsg_core.c | 33 + drivers/rpmsg

[PATCH v2 11/17] rpmsg: Split off generic tail of create_channel()

2016-09-01 Thread Bjorn Andersson
The tail of create_channel() is common among all rpmsg backends, so split it off from the virtio specific part to allow it to be extracted to the rpmsg core. Signed-off-by: Bjorn Andersson --- Changes since v1: - None drivers/rpmsg/virtio_rpmsg_bus.c | 18 +++--- 1 file changed

[PATCH v2 06/17] rpmsg: Introduce indirection table for rpmsg_device operations

2016-09-01 Thread Bjorn Andersson
To allow for multiple backend implementations add an indireection table for rpmsg_device related operations and move the virtio implementation behind this table. Signed-off-by: Bjorn Andersson --- Per Loic's comment I did consider adding parameter validation to the exposed functions in

[PATCH v2 09/17] rpmsg: Move endpoint related interface to rpmsg core

2016-09-01 Thread Bjorn Andersson
Move the rpmsg_send() and rpmsg_destroy_ept() interface to the rpmsg core, so that we eventually can hide the rpmsg_endpoint ops from the public API. Signed-off-by: Bjorn Andersson --- Changes since v1: - None drivers/rpmsg/rpmsg_core.c | 160

[PATCH v2 04/17] rpmsg: Make rpmsg_create_ept() take channel_info struct

2016-09-01 Thread Bjorn Andersson
identifier. Signed-off-by: Bjorn Andersson --- Changes since v1: - None drivers/rpmsg/virtio_rpmsg_bus.c | 26 ++ include/linux/rpmsg.h| 15 ++- 2 files changed, 24 insertions(+), 17 deletions(-) diff --git a/drivers/rpmsg/virtio_rpmsg_bus.c b/dri

[PATCH v2 05/17] rpmsg: Clean up rpmsg device vs channel naming

2016-09-01 Thread Bjorn Andersson
The rpmsg device representing struct is called rpmsg_channel and the variable name used throughout is rpdev, with the communication happening on endpoints it's clearer to just call this a "device" in a public API. Signed-off-by: Bjorn Andersson --- Changes since v1: - None

[PATCH v2 01/17] rpmsg: Enable matching devices with drivers based on DT

2016-09-01 Thread Bjorn Andersson
Make it possible to match rpmsg devices based on device tree node, in addition to the id table. In some of these cases the rpmsg driver would not have a id_table, so make this optional. Signed-off-by: Bjorn Andersson --- Changes since v1: - None drivers/rpmsg/virtio_rpmsg_bus.c | 10

[PATCH v2 02/17] rpmsg: Name rpmsg devices based on channel id

2016-09-01 Thread Bjorn Andersson
By basing rpmsg device names on channel id we end up with human readable device names in sysfs and debug logs. Signed-off-by: Bjorn Andersson --- Changes since v1: - None drivers/rpmsg/virtio_rpmsg_bus.c | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/drivers

Re: [PATCH v3 1/2] wcn36xx: Transition driver to SMD client

2016-09-02 Thread Bjorn Andersson
On Fri 02 Sep 09:24 PDT 2016, Kalle Valo wrote: > Bjorn Andersson writes: > > > The wcn36xx wifi driver follows the life cycle of the WLAN_CTRL SMD > > channel, as such it should be a SMD client. This patch makes this > > transition, now that we have the necess

Re: [PATCH 3/4] dt-binding: remoteproc: venus rproc dt binding document

2016-09-02 Thread Bjorn Andersson
On Fri 02 Sep 04:52 PDT 2016, Marek Szyprowski wrote: > Hi, > > > On 2016-09-01 16:58, Stanimir Varbanov wrote: > >Hi, > > > >Cc: Marek > > > > ... > > But I presume we have the implementation issue of dma_alloc_coherent() > failing in either case with the 5MB size. I think we need to

Re: [PATCH 1/4] remoteproc: Introduce always-on flag

2016-08-04 Thread Bjorn Andersson
On Thu 04 Aug 02:44 PDT 2016, loic pallardy wrote: > >>>diff --git a/drivers/remoteproc/remoteproc_core.c > >>>b/drivers/remoteproc/remoteproc_core.c [..] > >>>@@ -993,7 +1002,17 @@ int rproc_trigger_recovery(struct rproc *rproc) > >>> /* Free the copy of the resource table */ > >>> kfree(rpr

Re: [PATCH 3/4] dt-binding: remoteproc: venus rproc dt binding document

2016-08-23 Thread Bjorn Andersson
On Tue 23 Aug 10:32 PDT 2016, Rob Herring wrote: > On Fri, Aug 19, 2016 at 06:53:19PM +0300, Stanimir Varbanov wrote: > > Add devicetree binding document for Venus remote processor. > > > > Signed-off-by: Stanimir Varbanov > > --- > > .../devicetree/bindings/remoteproc/qcom,venus.txt | 33 > >

Re: [PATCH v2 1/4] dt-binding: remoteproc: Introduce ADSP loader binding

2016-08-23 Thread Bjorn Andersson
On Tue 23 Aug 11:31 PDT 2016, Rob Herring wrote: > On Mon, Aug 22, 2016 at 10:57:43PM -0700, Bjorn Andersson wrote: > > This document defines the binding for a component that loads firmware > > and control the life cycle of the Qualcomm ADSP core. > > > > Sig

[PATCH 1/4] arm64: dts: qcom: msm8916: Fixup smp2p nodes

2016-08-23 Thread Bjorn Andersson
The correct property is #qcom,smem-state-cells = <1>; Signed-off-by: Bjorn Andersson --- arch/arm64/boot/dts/qcom/msm8916.dtsi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi

[PATCH 2/4] arm64: dts: qcom: msm8916: Add Hexagon SMD edge

2016-08-23 Thread Bjorn Andersson
Add the Hexagon SMD edge, so that QRTR is probed when the Hexagon is booted. Signed-off-by: Bjorn Andersson --- arch/arm64/boot/dts/qcom/msm8916.dtsi | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi index

[PATCH 3/4] arm64: dts: qcom: msm8916: Add tcsr syscon node

2016-08-23 Thread Bjorn Andersson
Signed-off-by: Bjorn Andersson --- arch/arm64/boot/dts/qcom/msm8916.dtsi | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi index 3f3ef20865cd..6e599b75525a 100644 --- a/arch/arm64/boot/dts/qcom/msm8916.dtsi

[PATCH 4/4] arm64: dts: qcom: msm8916: Add Hexagon PIL node

2016-08-23 Thread Bjorn Andersson
crashes gracefully. Signed-off-by: Bjorn Andersson --- arch/arm64/boot/dts/qcom/msm8916.dtsi | 49 ++- 1 file changed, 48 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi index 6e599b75525a

Re: [PATCH 1/2] arm64: kernel: Add SMC Session ID to results

2016-08-24 Thread Bjorn Andersson
be used when resuming the interrupted SMC call. > > Signed-off-by: Andy Gross This fixes the spurious remoteproc firmware authentication failures I've seen lately. Tested-by: Bjorn Andersson Regards, Bjorn > --- > arch/arm64/kernel/asm-offsets.c | 1 + > arch/arm64/kerne

Re: [PATCH v3 0/5] dts patches for qcom tsens support

2016-08-24 Thread Bjorn Andersson
On Wed 24 Aug 03:22 PDT 2016, Paolo Pisati wrote: > On Wed, Aug 17, 2016 at 02:33:40PM -0500, Andy Gross wrote: > > On Wed, Aug 17, 2016 at 10:48:43AM +0530, Rajendra Nayak wrote: > > > Hey Andy, > > > > > > This is a respin of v2 with some minor fixes pointed out by Rob. > > > Please pull these

Re: [PATCH 3/4] dt-binding: remoteproc: venus rproc dt binding document

2016-08-24 Thread Bjorn Andersson
On Wed 24 Aug 08:36 PDT 2016, Stanimir Varbanov wrote: > Hi Rob, > > On 08/23/2016 08:32 PM, Rob Herring wrote: > > On Fri, Aug 19, 2016 at 06:53:19PM +0300, Stanimir Varbanov wrote: > >> Add devicetree binding document for Venus remote processor. > >> > >> Signed-off-by: Stanimir Varbanov > >>

Re: [PATCH 2/8] media: vidc: adding core part and helper functions

2016-08-25 Thread Bjorn Andersson
On Thu 25 Aug 05:59 PDT 2016, Stanimir Varbanov wrote: > Hi Bjorn, > > Thanks for the review and comments! > > On 08/23/2016 05:50 AM, Bjorn Andersson wrote: > > On Mon 22 Aug 06:13 PDT 2016, Stanimir Varbanov wrote: > > > > Hi Stan, > > > >&g

[PATCH] MAINTAINERS: Add Qualcomm pinctrl drivers section

2017-06-20 Thread Bjorn Andersson
Document the maintainership of the Qualcomm pinctrl drivers to improve the hitrate. Signed-off-by: Bjorn Andersson --- MAINTAINERS | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 75cd0dc8e93f..c2e3a349ca7c 100644 --- a/MAINTAINERS +++ b

Re: [PATCH v2 4/4] mmc: sdhci-msm: Add sdhci msm register write APIs which wait for pwr irq

2017-10-14 Thread Bjorn Andersson
On Tue 26 Sep 22:34 PDT 2017, Vijay Viswanath wrote: > diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c [..] > + if (!done) { > + if (!wait_event_timeout(msm_host->pwr_irq_wait, > + msm_host->pwr_irq_flag, > +

Re: [PATCH v7 4/4] remoteproc: qcom: Add support for mss remoteproc on msm8996

2017-10-16 Thread Bjorn Andersson
On Mon 16 Oct 06:19 PDT 2017, Dwivedi, Avaneesh Kumar (avani) wrote: > On 10/12/2017 11:50 PM, Bjorn Andersson wrote: [..] > > Please fix this and add my Acked-by > Sure will do, just want to ask, when i am sending updated patches, should i > sent all the 4 patches in series or sh

Re: [PATCH] arm64: defconfig: re-enable Qualcomm DB410c USB

2017-10-16 Thread Bjorn Andersson
4 "defconfig". As a result, USB > on that board stopped working during the v4.13-rc1 merge window. > > Re-enable this functionality by setting the needed config options > in the arm64 "defconfig" file. > Acked-by: Bjorn Andersson Regards, Bjorn > Sign

Re: [PATCH V1 1/2] pinctrl: qcom: spmi-gpio: Read REG_EN_CTL to get initial enable state

2017-10-16 Thread Bjorn Andersson
IG_BIAS_HIGH_IMPEDANCE */ > - pad->is_enabled = true; > + val = pmic_gpio_read(state, pad, PMIC_GPIO_REG_EN_CTL); > + if (val < 0) > + return val; > + > + pad->is_enabled = val & PMIC_GPIO_REG_MASTER_EN; Please be more explicit here: is_enable = !!(val & ...) > + other than that, Acked-by: Bjorn Andersson Regards, Bjorn

Re: [PATCH V1 2/2] pinctrl: qcom: spmi-gpio: Set is_enabled flag in set_mux()

2017-10-16 Thread Bjorn Andersson
On Thu 12 Oct 23:15 PDT 2017, fengl...@codeaurora.org wrote: > From: Fenglin Wu > > The initial value of is_enabled flag is read out from hardware in > pmic_gpio_populate(), and it will be set in pmic_gpio_config_set() if > pinconf is defined. For any GPIOs disabled initially in hardware which >

Re: [PATCH 2/4] i2c: Add Qualcomm Camera Control Interface driver

2017-10-16 Thread Bjorn Andersson
On Thu 12 Oct 07:47 PDT 2017, Todor Tomov wrote: > Hi Bjorn, > > Thank you for the review. There are a lot of important suggestions. > > On 6.10.2017 08:20, Bjorn Andersson wrote: > > On Mon 02 Oct 07:13 PDT 2017, Todor Tomov wrote: > >> diff --git a/drivers/i2c

Re: [Patch v6 1/7] slimbus: Device management on SLIMbus

2017-10-16 Thread Bjorn Andersson
On Fri 06 Oct 08:51 PDT 2017, srinivas.kandaga...@linaro.org wrote: [..] > diff --git a/drivers/slimbus/slim-core.c b/drivers/slimbus/slim-core.c [..] > +/** > + * Report callbacks(device_up, device_down) are implemented by > slimbus-devices. > + * The calls are scheduled into a workqueue to avoid

Re: [RESEND: PATCH v4 3/4] remoteproc: qcom: Make secure world call for mem ownership switch

2017-05-25 Thread Bjorn Andersson
On Tue 16 May 11:02 PDT 2017, Avaneesh Kumar Dwivedi wrote: > +static int q6v5_assign_mem_to_subsys(struct q6v5 *qproc, > + phys_addr_t addr, size_t size) > +{ > + struct qcom_scm_destVmPerm next[] = {{ QCOM_SCM_VMID_MSS_MSA, > + (QCOM_SCM_PERM_READ | QCOM_SCM_PERM_WRIT

Re: [RESEND: PATCH v4 1/4] firmware: scm: Add new SCM call for switching memory ownership

2017-05-25 Thread Bjorn Andersson
On Tue 16 May 11:01 PDT 2017, Avaneesh Kumar Dwivedi wrote: > diff --git a/drivers/firmware/qcom_scm-32.c b/drivers/firmware/qcom_scm-32.c > index 93e3b96..4eb7d59 100644 > --- a/drivers/firmware/qcom_scm-32.c > +++ b/drivers/firmware/qcom_scm-32.c > @@ -596,3 +596,9 @@ int __qcom_scm_iommu_secure

Re: [RESEND: PATCH v4 4/4] remoteproc: qcom: Add support for mss boot on msm8996

2017-05-25 Thread Bjorn Andersson
On Tue 16 May 11:02 PDT 2017, Avaneesh Kumar Dwivedi wrote: > diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt > b/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt > index 92347fe..f9dfb6c 100644 > --- a/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt >

Re: [RESEND: PATCH v4 3/4] remoteproc: qcom: Make secure world call for mem ownership switch

2017-05-26 Thread Bjorn Andersson
On Fri 26 May 06:19 PDT 2017, Dwivedi, Avaneesh Kumar (avani) wrote: > > > On 5/26/2017 7:46 AM, Bjorn Andersson wrote: > > On Tue 16 May 11:02 PDT 2017, Avaneesh Kumar Dwivedi wrote: > > > @@ -471,6 +517,11 @@ static int q6v5_mpss_init_image(struct q6v5 *qproc, > &g

Re: [RESEND: PATCH v4 1/4] firmware: scm: Add new SCM call for switching memory ownership

2017-05-26 Thread Bjorn Andersson
On Fri 26 May 06:01 PDT 2017, Dwivedi, Avaneesh Kumar (avani) wrote: > On 5/26/2017 11:33 AM, Bjorn Andersson wrote: > > On Tue 16 May 11:01 PDT 2017, Avaneesh Kumar Dwivedi wrote: [..] > > > diff --git a/include/linux/qcom_scm.h b/include/linux/qcom_scm.h [..] > > >

  1   2   3   4   5   6   7   8   9   10   >