[PATCH] mei: reseting -> resetting

2013-04-18 Thread Bill Nottingham
This enum leaks out to userspace via error messages, so fix the spelling. Signed-off-by: Bill Nottingham --- drivers/misc/mei/hbm.c | 8 drivers/misc/mei/hw-me.c | 2 +- drivers/misc/mei/init.c| 4 ++-- drivers/misc/mei/mei_dev.h | 2 +- 4 files changed, 8 insertions(+), 8

Re: ac10 ide-cd oopses on boot

2001-04-19 Thread Bill Nottingham
J . A . Magallon ([EMAIL PROTECTED]) said: > > Can you back out the ide-cd changes Jens did and see if that fixes it ? > > Reverted the changes in ide-cd.[hc], and same result. You want to back out the stuff from drivers/cdrom/cdrom.c; I backed out the parts of the patch new there to ac10, and

Re: Problem with "su -" and kernels 2.4.3-ac11 and higher

2001-04-23 Thread Bill Nottingham
Alan Cox ([EMAIL PROTECTED]) said: > > > Did you try nesting more than one "su -"? The first one after a boot > > > works for me - every other one fails. > > > > Same here: the first "su -" works OK, but a second nested one hangs: > > It appears to be a bug in PAM. Someone seems to reply on par

Re: Will the IBM OMNI printer driver be making its way into the kernel tree?

2001-02-13 Thread Bill Nottingham
Miles Lane ([EMAIL PROTECTED]) said: > http://oss.software.ibm.com/developer/opensource/linux/projects/omni/ Considering it's a ghostscript driver, I severely doubt it. :) Bill - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED

Re: isapnp , 2.2.14 vs. 2.4.1 and awe_wave

2001-02-16 Thread Bill Nottingham
Alan Cox ([EMAIL PROTECTED]) said: > > Probing around with test code in awe_wave.c, it become clear to me > > that the card was not being initialized properly by my isapnptools. > > Even more alarming was the fact that pnpdump would not see the SB card > > at all under 2.4.1, unless I used the

[PATCH] change awe_wave initialization to match 2.2 better

2001-02-19 Thread Bill Nottingham
The awe_wave driver in 2.2 looked at the common I/O ports for the card if no parameters were specified. The 2.4 driver currently does an ISAPnP probe, but doesn't fall back to the previous probing behavior, which means that users with working module configurations will have theirs broken on upgrad

Re: unresloved symbols in 2.4.1

2001-02-19 Thread Bill Nottingham
Eugene Danilchenko ([EMAIL PROTECTED]) said: > cd /lib/modules/2.4.1; \ > mkdir -p pcmcia; \ > find kernel -path '*/pcmcia/*' -name '*.o' | xargs -i -r ln -sf ../{} pcmcia > if [ -r System.map ]; then /sbin/depmod -ae -F System.map 2.4.1; fi > depmod: *** Unresolved symbols in /lib/modules/2.4.1

[PATCH] MODULE_DEVICE_TABLE support for opl3sa2 driver

2001-02-25 Thread Bill Nottingham
The attached adds MODULE_DEVICE_TABLE support to the ISAPnP support in the opl3sa2 driver, so it can get picked up by modutils and the like. Bill --- linux/drivers/sound/opl3sa2.c.foo Mon Feb 26 00:19:33 2001 +++ linux/drivers/sound/opl3sa2.c Mon Feb 26 00:25:53 2001 @@ -806,6 +806,16 @

Re: prerelease-ac6 compile problem in serial.c

2001-01-04 Thread Bill Nottingham
Meelis Roos ([EMAIL PROTECTED]) said: > 2.4.0-prerelease-ac6 doesn't compile serial on x86 with pnp enabled: > > serial.c: In function `probe_serial_pnp': > serial.c:5187: structure has no member named `device' > serial.c:5192: structure has no member named `device' Doh. I swear this did build

Re: linux-2.4.0-prerelease-ac6 compile errors

2001-01-04 Thread Bill Nottingham
Ignacio Monge ([EMAIL PROTECTED]) said: > Problem: compile error in linux-2.4.0-prerelease-ac6 --- linux/drivers/char/serial.c.foo Thu Jan 4 17:31:43 2001 +++ linux/drivers/char/serial.c Thu Jan 4 17:32:38 2001 @@ -5184,12 +5184,12 @@ for (pnp_board = pnp_dev

Re: DRI doesn't work on 2.4.0 but does on prerelease-ac5

2001-01-08 Thread Bill Nottingham
Michael D. Crawford ([EMAIL PROTECTED]) said: > This makes me suspect it's not really working, or else my build of the Mesa-3.4 > library wasn't configured right - but note that if I disable DRI, one of the > Mesa demos will comment that it's not available. It sounds as if you're using a Mesa li

Re: 2.4.0 umount problem

2001-01-10 Thread Bill Nottingham
M T ([EMAIL PROTECTED]) said: > I'm running redhat 6.2 halt scripts and strange problem appears when > shutting system down with kernel-2.4.0. I get message that "/ device is > busy". I've updated util-linux (kill,mount,umount) according to > documentation without any success. I've got no prob

Re: 2.4.0 release and ia64

2001-01-10 Thread Bill Nottingham
[EMAIL PROTECTED] ([EMAIL PROTECTED]) said: > Now that 2.4.0 kernel is officially released, does it run > or ia64 as it is or do we need to apply any patches to make > it run on ia64 ? There's a patch for it in ports/ia64 on your favorite linux kernel mirror. Bill - To unsubscribe from this lis

Re: 2.4.0 release and ia64

2001-01-10 Thread Bill Nottingham
[EMAIL PROTECTED] ([EMAIL PROTECTED]) said: > It looks like, those patches are for the test kernels. There *should* be a patch for 2.4 final: linux-2.4.0-ia64-010109.diff.(bz2|gz) If not, your mirror isn't up to date. Bill - To unsubscribe from this list: send the line "unsubscribe linux-kern

Re: Compile error: DRM without AGP in 2.4.0

2001-01-11 Thread Bill Nottingham
Alan Cox ([EMAIL PROTECTED]) said: > > What if your motherboard doesn't have an AGP slot? I'm running an older > > Micro Star pentium with a ATI All-in-Wonder with the Rage 128 chipset. > > Then I believe you cant use direct render right now In 4.0.1 r128 DRM sort of worked with a PCI card in a

Re: Is there a Crystal 4299 sound driver?

2001-01-18 Thread Bill Nottingham
Torrey Hoffman ([EMAIL PROTECTED]) said: > Does anyone know of a driver for the Crystal 4299 sound chip? It's not something there's one particular sound driver for (it's just an ac97 codec chip, as you saw). Most likely you want to use something like the i810_audio or via82cxxx_audio drivers. Wh

Re: Is there a Crystal 4299 sound driver?

2001-01-19 Thread Bill Nottingham
Torrey Hoffman ([EMAIL PROTECTED]) said: > Here's an lspci -v dump. The machine is a set top box, pretty much a > standard PC, but with hardware parts that are rarely seen in normal > desktops. (The graphics card, ethernet card, and MPEG decoder chip > all required non-standard Linux and X 4.0

Re: Where did kgcc go in 2.4.0-test10 ?

2000-11-01 Thread Bill Nottingham
H. Peter Anvin ([EMAIL PROTECTED]) said: > I think at least supporting a "kgcc" compiler makes sense, > conceptually (although it probably should have been called "kcc", but > it's too late now.) There was already some userland package named kcc, with a kcc binary. A Kanji converter of some sort

PATCH: fix FAT32 filesystems on 64-bit platforms

2000-12-14 Thread Bill Nottingham
This fixes FAT32 on 64-bit platforms (notably, IA-64 and Alpha); without this you can't mount any FAT32 filesystems. A similar patch is already in 2.2.18. Bill --- linux/fs/fat/cache.c.fooSat Nov 25 16:30:47 2000 +++ linux/fs/fat/cache.cSat Nov 25 16:32:29 2000 @@ -70,7 +70,7 @@

Re: opl3sa2 in 2.4.2 on Toshiba Tecra 8000

2001-03-29 Thread Bill Nottingham
Klaus Reimer ([EMAIL PROTECTED]) said: > 2001-03-29 10:02:50.054774500 {kern|info} kernel: ad1848/cs4248 codec driver > Copyright (C) by Hannu Savolainen 1993-1996 > 2001-03-29 10:02:50.070692500 {kern|notice} kernel: opl3sa2: No cards found > 2001-03-29 10:02:50.070703500 {kern|notice} kernel:

Re: opl3sa2 in 2.4.2 on Toshiba Tecra 8000

2001-03-29 Thread Bill Nottingham
Klaus Reimer ([EMAIL PROTECTED]) said: > If I am doing this, I can't even load the module and I get the following > message in syslog: > > 2001-03-29 18:13:14.184156500 {kern|err} kernel: opl3sa2: Control I/O port > 0x0 not free > > What is that "control i/o port"? Is this normally 0x100? I

Re: opl3sa2 in 2.4.2 on Toshiba Tecra 8000

2001-03-29 Thread Bill Nottingham
Klaus Reimer ([EMAIL PROTECTED]) said: > Hi, > > > > modprobe opl3sa2 io=0x538 mss_io=0x530 mpu_io=0x330 irq=5 dma=1 dma2=0 > > > isapnp=0 > > It would be what you put in the io= parameter. 0x538 does *not* look > > right. > > These are the sound-settings in the BIOS: > > WSS I/O: 0x530 > SBPr

[PATCH] vgacon: set vc_hi_font_mask correctly

2005-04-14 Thread Bill Nottingham
When allocating a new VC with vgacon_init(), the font is shared across all the VGA consoles. However, the font mask was always set to the default value of zero in visual_init(), even if we were using 512 character fonts at the time. Moreover, code in vgacon.c:vga_do_font_op() didn't reset the mask

Re: [patch] IBM HDAPS accelerometer driver.

2005-08-26 Thread Bill Nottingham
Robert Love ([EMAIL PROTECTED]) said: > Of late I have been working on a driver for the IBM Hard Drive Active > Protection System (HDAPS), which provides a two-axis accelerometer and > some other misc. data. The hardware is found on recent IBM ThinkPad > laptops. How does this relate to the hdap

[PATCH] module-init-tools: don't do '-' substitutions in depmod

2005-09-08 Thread Bill Nottingham
The attached patch removes the '-' for '_' substitution from depmod - this makes the names printed for modules in module.alias match the actual names of the module files. Bill diff -ru depmod.c.old depmod.c --- depmod.c2005-04-30 08:38:46.0 -0400 +++ depmod.c2005-09-08 15:52:26.000

Re: [ANNOUNCE] hotplug-ng 001 release

2005-02-10 Thread Bill Nottingham
Greg KH ([EMAIL PROTECTED]) said: > I'd like to announce, yet-another-hotplug based userspace project: > linux-ng. This collection of code replaces the existing linux-hotplug > package with very tiny, compiled executable programs, instead of the > existing bash scripts. > > It currently provides

Re: Hotplug blacklist and video devices

2005-02-18 Thread Bill Nottingham
Jon Smirl ([EMAIL PROTECTED]) said: > Why are all of the framebuffer drivers on the hotplug blacklist? Well, that probably depends on your distribution. :) Under Fedora (and RHEL), they're there because we generally don't want to load them unless the user asked for them. Bill - To unsubscribe f

slab BUG in FC devel kernel, x86-64

2005-01-28 Thread Bill Nottingham
The kernel in question is based on 2.6.11-rc2-bk4, FWIW. Transcribed by hand. Happened when rsyncing data onto a LVM-on-RAID1, sata_via controller. (root FS is on generic VIA IDE). slab: double free detected in cache 'size-128', objp 81000340bba8. Kernel BUG at slab:2188 invalid operand:

Re: Hotplug blacklist and video devices

2005-02-21 Thread Bill Nottingham
Jon Smirl ([EMAIL PROTECTED]) said: > Is there a specific reason why they are blocked? > > For example I'm looking at making changes to DRM such that DRM will > require the corresponding framebuffer driver to be loaded. If you back > up further this is part of fixing X so that it won't mess with

Re: RFD: Kernel release numbering

2005-03-03 Thread Bill Nottingham
Dave Jones ([EMAIL PROTECTED]) said: > > [*] I don't know any details of the /proc incompatibility which davej > > mentions, and I'd like to. That sounds like a screw-up. > > We changed the format of /proc/slabinfo. Running slabtop threw up > an error message complaining that the format h

Re: Linux Kernel Debuggers, KDB or KGDB?

2001-05-02 Thread Bill Nottingham
Jeff Dike ([EMAIL PROTECTED]) said: > > > Is this sufficient to do driver development? TUN/TAP doesn't let me > > > write > > > ethernet drivers inside UML. > > For ISDN not really. For SCSI yes - scsi generic would let you write a > > virtual scsi adapter 'owning' some physical devices > > F

[PATCH] make Xircom cardbus modems work

2001-05-09 Thread Bill Nottingham
The attached allows serial.c to work with my Xircom cardbus ethernet+modem combo card. It doesn't get autodetected, because the serial driver explicitly doesn't recognize anything with more than one iomem region (the Xircom modem has two.) If the serial driver is linked in statically, the delay on

Re: [PATCH] make Xircom cardbus modems work

2001-05-09 Thread Bill Nottingham
Jeff Garzik ([EMAIL PROTECTED]) said: > Bill, > > Does the attached patch work for you? Yup, works fine for me (compiled in.) Bill - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.

Re: [PATCH] missing return value from pci_xircom_fn() in drivers/char/serial.c

2001-05-14 Thread Bill Nottingham
Jesper Juhl ([EMAIL PROTECTED]) said: > I have made a patch against 2.4.4-ac8 that makes the change, it is > below. I guess someone more knowledgeable than me can probably see if > this is correct. If this is completely bogus, then please just disregard > this email. Yup, it's right. My bad.

Re: Linux 2.4.4-ac11

2001-05-17 Thread Bill Nottingham
(catching up...) Alan Cox ([EMAIL PROTECTED]) said: > 2.4.4-ac9 ... > o Further tulip updates (Jeff Garzik) ... > 2.4.4-ac8 > o Tulip driver updates(Jeff Garzik) These updates (sorry, haven't tracked down which of the two) conspire t

bad caching behavior in 2.6.12rc1

2005-03-24 Thread Bill Nottingham
When I upgraded from 2.6.11 to 2.6.12rc1, the VM started behaving really badly with respect to caching. Test box is a 1.5GB laptop. In typical use, I would open a mailbox A, and then switch to mailbox B. Immediately switching back to mailbox A, I would find out it was no longer cached. (Using mai

Re: bad caching behavior in 2.6.12rc1

2005-03-25 Thread Bill Nottingham
Andrew Morton ([EMAIL PROTECTED]) said: > > Test box is a 1.5GB laptop. > > > > In typical use, I would open a mailbox A, and then switch > > to mailbox B. Immediately switching back to mailbox A, I > > would find out it was no longer cached. (Using maildirs, > > FWIW.) > > > > Looking at /proc/

[PATCH] add CONFIG_VT_UNICODE

2007-08-31 Thread Bill Nottingham
rtual terminal and the keyboard driver. Signed-off-by: Bill Nottingham <[EMAIL PROTECTED]> diff -up linux-2.6.22.noarch/drivers/char/keyboard.c.foo linux-2.6.22.noarch/drivers/char/keyboard.c --- linux-2.6.22.noarch/drivers/char/keyboard.c.foo 2007-08-30 17:18:54.0 -0400 +++ l

Re: [PATCH] add CONFIG_VT_UNICODE

2007-08-31 Thread Bill Nottingham
Randy Dunlap ([EMAIL PROTECTED]) said: > A diffstat would be nice. Sure. linux-2.6.22.noarch/drivers/char/Kconfig| 17 + linux-2.6.22.noarch/drivers/char/keyboard.c |2 +- linux-2.6.22.noarch/drivers/char/sysrq.c|4 ++-- linux-2.6.22.noarch/drivers/char/vt.c

Re: origin of __tmp1930643048 network device name: kernel-space or user-space

2007-09-06 Thread Bill Nottingham
Jan Engelhardt ([EMAIL PROTECTED]) said: > >dear all, > >I'm trying to track down a problem on a Sun V40Z server with 4 network > >devices grabbing random ethX device names. now, trying to force the > >device names to what I want, I got a __tmpX form of device name, > >which I think is a half-

Re: [PATCH] add CONFIG_VT_UNICODE

2007-09-06 Thread Bill Nottingham
H. Peter Anvin ([EMAIL PROTECTED]) said: > Hmmm... > > Personally I'd suggest making it the default unless overridden in > /etc/sysctl.conf. My second preference would be a command-line option, not > a compile-time default. > > This is 2007, after all, and it seems Unicode should be the default

Re: 2.6.22: pcspkr driver no longer loads automatically

2007-08-08 Thread Bill Nottingham
Kay Sievers ([EMAIL PROTECTED]) said: > It doesn't have any aliases, so seems it was never autoloaded. It was - prior kernels loaded it via the uevent generated from /devices/platform/pcspkr. Newer kernels seem to never actually trigger a uevent from that (tested with a combination of udevmonito

Re: 2.6.22: pcspkr driver no longer loads automatically

2007-08-08 Thread Bill Nottingham
Kay Sievers ([EMAIL PROTECTED]) said: > Ah, ok, makes sense. Yeah, that weird "platform devices loads itself by > the name" thing got disabled in the platform subsystem. It caused > modprobe loops for other devices. > > The whole idea of issuing MODALIAS with plain module names instead of > alias

[PATCH] remove gratuitous space in airo module description

2007-07-27 Thread Bill Nottingham
for PCMCIA when used with airo_cs."); +cards. Direct support for ISA/PCI/MPI cards and support \ +for PCMCIA when used with airo_cs."); MODULE_LICENSE("Dual BSD/GPL"); MODULE_SUPPORTED_DEVICE("Aironet 4500, 4800 and Cisco 340/350"); module_param_array(io, i

Re: [PATCH/RFC] Delete JFFS (version 1)

2006-12-12 Thread Bill Nottingham
Jeff Garzik ([EMAIL PROTECTED]) said: > It's always been the case that we remove Linux kernel code when the > number of users (and more importantly, developers) drops to near-nil. So, drivers/net/3c501.c? Bill - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body

Re: GPL only modules [was Re: [GIT PATCH] more Driver core patches for 2.6.19]

2006-12-13 Thread Bill Nottingham
Greg KH ([EMAIL PROTECTED]) said: > An updated version is below. If you're adding this, you should probably schedule EXPORT_SYMBOL_GPL for removal at the same time, as this essentially renders that irrelevant. That being said... First, this is adding the measure at module load time. Any copyri

Re: GPL only modules [was Re: [GIT PATCH] more Driver core patches for 2.6.19]

2006-12-14 Thread Bill Nottingham
Rik van Riel ([EMAIL PROTECTED]) said: > Maybe we should just educate users and teach them to > avoid crazy unsupportable configurations and simply buy > the hardware that has open drivers available? Educating the users may help, but it's hard to do the education once they've already bought the h

Re: libata-pata with ICH4, rootfs

2006-12-14 Thread Bill Nottingham
Alistair John Strachan ([EMAIL PROTECTED]) said: > > > Is it possible to use pata_mpiix (or pata_oldpiix) with an ICH4 IDE > > > controller and boot off it? > > > > ata_piix (the SATA/PATA driver) deals with the ICH4. pata_mpiix is > > specifically for the Intel MPIIX laptop chipset and pata_oldpi

Re: GPL only modules [was Re: [GIT PATCH] more Driver core patches for 2.6.19]

2006-12-19 Thread Bill Nottingham
Gene Heskett ([EMAIL PROTECTED]) said: > FWIW: > [EMAIL PROTECTED] src]# python list-kernel-hardware.py > Traceback (most recent call last): > File "list-kernel-hardware.py", line 70, in ? > ret = pciids_to_names(data) > File "list-kernel-hardware.py", line 11, in pciids_to_names > pci

Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3

2007-06-14 Thread Bill Nottingham
Alexandre Oliva ([EMAIL PROTECTED]) said: > > Sure, if they make any changes or fixes to Linux. Other than that, > > only the same benefit that Microsoft get from Windows piracy - TiVo > > employees become familiar with Linux and are more likely to use it > > and maybe contribute more in another

Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3

2007-06-14 Thread Bill Nottingham
Neshama Parhoti ([EMAIL PROTECTED]) said: > But many of FSF's GNU projects are similar - for example GCC has > contributors > from many many companies and individuals, from which I presume there > are who might object to GPLv3. FSF requires copyright assignment to the FSF on things like the comp

Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3

2007-06-14 Thread Bill Nottingham
Alexandre Oliva ([EMAIL PROTECTED]) said: > But how about inside the TiVO, so as to use Linux and the rest of the > GNU/Linux distro put in there for an even better DVR experience? > > Sure, this might still be accomplished on another hardware platform. > But the TiVO already has all the hardware

Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3

2007-06-14 Thread Bill Nottingham
Alexandre Oliva ([EMAIL PROTECTED]) said: > And since the specific implementation involves creating a derived work > of the GPLed kernel (the signature, or the signed image, or what have > you) Wait, a signed filesystem image that happens to contain GPL code is now a derived work? Under what sort

Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3

2007-06-14 Thread Bill Nottingham
Alexandre Oliva ([EMAIL PROTECTED]) said: > > Wait, a signed filesystem image that happens to contain GPL code > > is now a derived work? Under what sort of interpretation does *that* > > occur? > > Is the signature not derived from the bits in the GPLed component, as > much as it is derived from

[PATCH] alsa: fix comparison of unsigned < 0

2007-05-30 Thread Bill Nottingham
Recent gccs emit warnings when unsigned variables are compared < 0 or >= 0. Signed-off-by: Bill Nottingham <[EMAIL PROTECTED]> ac97/ac97_patch.c|3 +-- ali5451/ali5451.c|6 ++ ca0106/ca0106_proc.c |4 ++-- rme9652/rme9652.c|2 -- 4 files changed,

[PATCH] mm: fix comparisons against unsigned

2007-05-30 Thread Bill Nottingham
Recent gcc versions emit warnings when unsigned variables are compared < 0 or >= 0. Signed-off-by: Bill Nottingham <[EMAIL PROTECTED]> --- filemap.c | 34 -- slub.c|2 -- 2 files changed, 16 insertions(+), 20 deletions(-) Patch is

[PATCH] net: fix comparisons of unsigned < 0

2007-05-30 Thread Bill Nottingham
Recent gcc versions emit warnings when unsigned variables are compared < 0 or >= 0. Signed-off-by: Bill Nottingham <[EMAIL PROTECTED]> --- 8021q/vlan.c |3 +-- dccp/probe.c |2 +- ipv6/netfilter/nf_conntrack_l3

[PATCH] drivers/net: fix comparisons of unsigned < 0

2007-05-30 Thread Bill Nottingham
Recent gcc versions emit warnings when unsigned variables are compared < 0 or >= 0. Signed-off-by: Bill Nottingham <[EMAIL PROTECTED]> --- mlx4/qp.c |3 +-- netxen/netxen_nic_niu.c |6 +++--- tulip/de2104x.c |1 - 3 files changed, 4 insertions(+),

[PATCH] drivers/video: Fix comparisons between negative and unsigned

2007-05-30 Thread Bill Nottingham
Recent gcc versions emit warnings when unsigned variables are compared < 0 or >= 0. Signed-off-by: Bill Nottingham <[EMAIL PROTECTED]> --- aty/aty128fb.c |3 --- aty/radeon_base.c|5 - cirrusfb.c |5 - fbmem.c |8 -

[PATCH] drivers/infiniband: fix comparsion between unsigned and negative

2007-05-30 Thread Bill Nottingham
Recent gcc versions emit warnings when unsigned variables are compared < 0 or >= 0. Signed-off-by: Bill Nottingham <[EMAIL PROTECTED]> --- core/sysfs.c |2 +- core/ucm.c |2 +- core/ucma.c|2 +- core/user_mad.c|5 ++--- core/uverbs_m

[PATCH RFC] qla2xxx: fix timeout in qla2x00_down_timeout

2007-05-30 Thread Bill Nottingham
iterations is unsigned, so it is impossible to get out of the loop and return -ETIMEDOUT. Signed-off-by: Bill Nottingham <[EMAIL PROTECTED]> --- If the intention *is* to never fall out of the end of the loop, ignore this, and just replace it with do {} while (1);. --- drivers/scsi/q

Re: dealing with gcc 'comparison is always false' warnings (was: [PATCH] drivers/infiniband: fix comparsion between unsigned and negative)

2007-05-30 Thread Bill Nottingham
Satyam Sharma ([EMAIL PROTECTED]) said: > But yes, the kind of "fixes" you pointed out that _remove_ these conditions > are definitely *not* what we would want to do. I can see that - but I think it should be at least be brought up for each warning, to determine either: 1) if it should be ignore

Re: 2.6.22-rc4-mm1

2007-06-07 Thread Bill Nottingham
Greg KH ([EMAIL PROTECTED]) said: > There are a number of distros out there right now who can support that > option disabled. I'm pretty sure they are the following right now: > Gentoo unstable (actually stable works now for me, but I'm not >going to guarantee it jus

new sysfs layout and ethernet device names

2007-03-20 Thread Bill Nottingham
I was fiddling with the 'new' (no CONFIG_SYSFS_DEPRECATED) layout and ethernet device names, and noticed that the new layout effectively restricts the availability of certain device names. By making a directory for the ethernet device name in the parent device, you no longer can use any name that

Re: new sysfs layout and ethernet device names

2007-03-27 Thread Bill Nottingham
Kay Sievers ([EMAIL PROTECTED]) said: > >If you *do* try to use one of these names, the rename will succeed... > >partway. The link in /sys/class/net is renamed, the directory is > >not (as it obviously can't rename on top of whatever is already there.) > >Various networking tools then break in as

Re: new sysfs layout and ethernet device names

2007-03-28 Thread Bill Nottingham
Greg KH ([EMAIL PROTECTED]) said: > If you follow the rules in Documentation/ABI/testing/sysfs-class your > program will not have any problems. Oh, of *course*. We add interfaces and then claim years later, after code has been written, "Oh, you shouldn't be using that!" in documentation. Meanwhil

Re: new sysfs layout and ethernet device names

2007-03-29 Thread Bill Nottingham
Greg KH ([EMAIL PROTECTED]) said: > > If interfaces have to change, so be it. But changing the rules for > > using them years after it's implemented and then claiming "you didn't > > read the instructions" is pretty lame. > > That documentation has been in the kernel tree for almost a full year:

Re: [PATCH] make unicode default

2007-10-01 Thread Bill Nottingham
Jan Engelhardt ([EMAIL PROTECTED]) said: > > Make the vt return to the system default when it is reset. > Also make UTF-8 the system default. > Derived from http://lkml.org/lkml/2007/8/31/246 > > Tested and works as expected. Fine with me. I believe the original patch I sent went to -mm, so you