ordering is unnecessary when
there's only one work item.
Explicit concurrency limit is unnecessary here since there are only a
fixed number of work items.
Signed-off-by: Bhaktipriya Shridhar
---
drivers/net/ethernet/mellanox/mlx5/core/pagealloc.c | 3 ++-
1 file changed, 2 insertions(+), 1 del
s not been set.
Signed-off-by: Bhaktipriya Shridhar
---
drivers/usb/dwc2/hcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c
index 2df3d04..df5a065 100644
--- a/drivers/usb/dwc2/hcd.c
+++ b/drivers/usb/dwc2/hcd.c
@@ -5040
sks while disconnecting the driver.
Signed-off-by: Bhaktipriya Shridhar
---
drivers/usb/misc/lvstest.c | 17 +++--
1 file changed, 3 insertions(+), 14 deletions(-)
diff --git a/drivers/usb/misc/lvstest.c b/drivers/usb/misc/lvstest.c
index 86b4e4b..a985cad 100644
--- a/drivers/usb/misc/
On Thu, Sep 1, 2016 at 2:47 AM, Tejun Heo wrote:
> On Wed, Aug 31, 2016 at 09:24:40PM +0100, David Howells wrote:
>> Concurrently is fine.
>
> I see. Bhaktpriya, can you please update the patch description? The
> code itself should be fine, I think.
>
Sure. Will update it in v2.
Thanks,
Bhaktip
Fixed coding style issue "warning line over 80 characters"
detected by checkpatch.pl in dgnc_mgmt.c
---
drivers/staging/dgnc/dgnc_mgmt.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/dgnc/dgnc_mgmt.c b/drivers/staging/dgnc/dgnc_mgmt.c
index b13318a..e8fd3da
Fixed coding style issue "warning line over 80 characters"
detected by checkpatch.pl in dgnc_mgmt.c
Signed-off-by: Bhaktipriya Shridhar
---
drivers/staging/dgnc/dgnc_mgmt.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/dgnc/dgnc_mgmt.c b/drive
Fixed coding style issue "warning line over 80 characters"
detected by checkpatch.pl in dgnc_mgmt.c
Signed-off-by: Bhaktipriya Shridhar
---
drivers/staging/dgnc/dgnc_mgmt.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/dgnc/dgnc_mgmt.c b/drive
This patch fixes checkpatch.pl warnings in the file dgnc/dgnc_neo.c
WARNING : line over 80 characters
Signed-off-by: Bhaktipriya Shridhar
---
drivers/staging/dgnc/dgnc_neo.c | 175 ++--
1 file changed, 115 insertions(+), 60 deletions(-)
diff --git a/drivers
- Removed the comment "Which I dont care about" (1 place)
2.Fixes code lines that are over 80-characters by
-breaking up long math lines
-breaking up long function calls
2.Spelling errors in comments.
-tho -> though
-baudrate -> baud rate
finished before the module is removed.
flush_workqueue is unnecessary since destroy_workqueue() itself calls
drain_workqueue() which flushes repeatedly till the workqueue becomes empty.
Hence flush_workqueue has been removed.
Signed-off-by: Bhaktipriya Shridhar
---
drivers/gpu/drm/amd/amdkfd
.
flush_workqueue is unnecessary since destroy_workqueue() itself calls
drain_workqueue() which flushes repeatedly till the workqueue becomes empty.
Hence flush_workqueue has been removed.
Signed-off-by: Bhaktipriya Shridhar
---
Changes in v2:
- added explanation for setting concurrency value to
to ensure that work is not pending by the time
exit path runs.
Signed-off-by: Bhaktipriya Shridhar
---
drivers/gpu/host1x/dev.h| 1 -
drivers/gpu/host1x/hw/intr_hw.c | 8 ++--
drivers/gpu/host1x/intr.c | 4
3 files changed, 6 insertions(+), 7 deletions(-)
diff --git a/driv
sed in xen_pcibk_disconnect() to ensure that
work item is not pending or executing by the time exit path runs.
Signed-off-by: Bhaktipriya Shridhar
---
drivers/xen/xen-pciback/pciback.h | 1 -
drivers/xen/xen-pciback/pciback_ops.c | 2 +-
drivers/xen/xen-pciback/xenbus.c | 10 +-
pending and the code expects it to run
once scheduled, flush_work() has been used in xenbus_dev_suspend()
Signed-off-by: Bhaktipriya Shridhar
---
drivers/xen/xenbus/xenbus_probe.c | 2 ++
drivers/xen/xenbus/xenbus_probe_frontend.c | 15 +--
2 files changed, 3 insertions
.
flush_workqueue is unnecessary since destroy_workqueue() itself calls
drain_workqueue() which flushes repeatedly till the workqueue
becomes empty.
Hence flush_workqueue has been removed.
Signed-off-by: Bhaktipriya Shridhar
---
Changes in v3:
- Corrected space between arguments.
drivers/gpu/drm/amd
Thanks Oded. Sending v3 right away :)
On Sun, May 29, 2016 at 8:31 PM, Oded Gabbay wrote:
> On Thu, May 26, 2016 at 10:37 PM, Bhaktipriya Shridhar
> wrote:
>> alloc_workqueue replaces deprecated create_workqueue().
>>
>> create_workqueue has been replaced with alloc_w
This patch fixes checkpatch.pl check:
CHECK: Comparison to NULL could be written "!rx_p"
+ if (*rx_p == NULL) {
Signed-off-by: Bhaktipriya Shridhar
---
drivers/staging/iio/accel/sca3000_ring.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging
rx_p == NULL) {
Signed-off-by: Bhaktipriya Shridhar
---
Changes in v2:
-Replaced "if (!rx_p)" with "if (!*rx_p)"
drivers/staging/iio/accel/sca3000_ring.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/iio/accel/sca3000_ring.c
b/driv
rx_p == NULL) {
Signed-off-by: Bhaktipriya Shridhar
---
Changes in v3:
- Replaced "if (!rx_p)" with "if (!*rx_p)"
- Changes are made on the original code
drivers/staging/iio/accel/sca3000_ring.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/d
This patch fixes checkpatch.pl warning for visorchipset.c
CHECK: spaces preferred around that '*' (ctx:VxV)
+#define MAX_CONTROLVM_PAYLOAD_BYTES (1024*128)
Signed-off-by: Bhaktipriya Shridhar
---
drivers/staging/unisys/visorbus/visorchipset.c | 2 +-
1 file changed, 1 insertion(+),
Fix the following checkpatch.pl warning:
WARNING: void function return statements are not generally useful
Signed-off-by: Bhaktipriya Shridhar
---
drivers/staging/lustre/lustre/obdclass/llog_swab.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/obdclass
NULL check before the debugfs_remove_recursive function is not needed.
This was detected using scripts/coccinelle/free/ifnullfree.cocci
Signed-off-by: Bhaktipriya Shridhar
---
drivers/staging/lustre/lustre/obdclass/linux/linux-module.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions
ordered. Hence, concurrency
can be increased by switching to system_wq.
All work items are sync canceled in cvm_oct_remove() so it
is guaranteed that no work is in flight by the time exit path runs.
Signed-off-by: Bhaktipriya Shridhar
---
drivers/staging/octeon/ethernet.c| 21
explicitly specified and thus the
increase of local concurrency shouldn't make any difference.
Work item has been flushed in mlx5_health_cleanup() to ensure that
there are no pending tasks while disconnecting the driver.
Signed-off-by: Bhaktipriya Shridhar
---
drivers/net/ethernet/m
ing the driver.
Signed-off-by: Bhaktipriya Shridhar
---
drivers/spi/spi-sh.c | 16 +++-
1 file changed, 3 insertions(+), 13 deletions(-)
diff --git a/drivers/spi/spi-sh.c b/drivers/spi/spi-sh.c
index 5025011..2bf53f0 100644
--- a/drivers/spi/spi-sh.c
+++ b/drivers/spi/spi-sh
Please ignore this mail. I have already sent a patch for this driver
Thanks,
Bhaktipriya
On Sat, Jul 16, 2016 at 1:35 PM, Bhaktipriya Shridhar
wrote:
> The workqueue has a single workitem(&ss->ws) and hence doesn't require
> ordering. Also, it is not being used on a memory r
emory reclaim in
any way, system_long_wq has been used.
Work item has been flushed in ttm_mem_global_release() to ensure that
nothing is pending when the driver is disconnected.
Signed-off-by: Bhaktipriya Shridhar
---
drivers/gpu/drm/ttm/ttm_memory.c | 7 ++-
1 file changed, 2 insertions(
ice can be used during memory reclaim, the
workqueue needs forward progress guarantee under memory pressure.
WQ_MEM_RECLAIM has been set to ensure this.
Since there is only a single work item, explicit concurrency limit is
unnecessary here.
Signed-off-by: Bhaktipriya Shridhar
---
drivers/net/ether
g the driver.
Signed-off-by: Bhaktipriya Shridhar
---
drivers/media/platform/s5p-mfc/s5p_mfc.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc.c
b/drivers/media/platform/s5p-mfc/s5p_mfc.c
index b16466f..1bc27ec 100644
--- a/d
s been flushed in pvr2_hdw_destroy to ensure that there are no
pending tasks while disconnecting the driver.
Signed-off-by: Bhaktipriya Shridhar
---
drivers/media/usb/pvrusb2/pvrusb2-hdw-internal.h | 1 -
drivers/media/usb/pvrusb2/pvrusb2-hdw.c | 23 +++
2 files c
lows multiple
work items to overlap executions even on the same CPU; however, a
per-cpu workqueue doesn't have any CPU locality or global ordering
guarantee unless the target CPU is explicitly specified and thus the
increase of local concurrency shouldn't make any difference.
S
been flushed in sd_stop0() to ensure that there are no
pending tasks while disconnecting the driver.
Signed-off-by: Bhaktipriya Shridhar
---
drivers/media/usb/gspca/sonixj.c | 13 -
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/drivers/media/usb/gspca/sonixj.c b/d
ed in sd_stop0() to ensure that there are no
pending tasks while disconnecting the driver.
Signed-off-by: Bhaktipriya Shridhar
---
drivers/media/usb/gspca/vicam.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/media/usb/gspca/vicam.c b/drivers/media/usb/gspca/
ed in sd_stop0() to ensure that there are no
pending tasks while disconnecting the driver.
Signed-off-by: Bhaktipriya Shridhar
---
drivers/media/usb/gspca/jl2005bcd.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/media/usb/gspca/jl2005bcd.c
b/drivers/medi
ed in sd_stop0() to ensure that there are no
pending tasks while disconnecting the driver.
Signed-off-by: Bhaktipriya Shridhar
---
drivers/media/usb/gspca/finepix.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/media/usb/gspca/finepix.c
b/drivers/media/usb/g
This patch set fixes the improper usage of the workqueue API.
This includes dropping the freeing of workqueue and removing the deprecated
create_singlethread_workqueue instance.
Bhaktipriya Shridhar (2):
[media] cx25821: Drop Freeing of Workqueue
[media] cx25821: Remove deprecated
Workqueues shouldn't be freed. destroy_workqueue should be used instead.
destroy_workqueue safely destroys a workqueue and ensures that all pending
work items are done before destroying the workqueue.
Signed-off-by: Bhaktipriya Shridhar
---
drivers/media/pci/cx25821/cx25821-audio-upstream.
tiple
work items to overlap executions even on the same CPU; however, a
per-cpu workqueue doesn't have any CPU locality or global ordering
guarantee unless the target CPU is explicitly specified and thus the
increase of local concurrency shouldn't make any difference.
Signed-off-by: Bha
h
the use of system_wq.
&state->edid_handler is a self requeueing work item and it has been
been sync cancelled in ad9389b_remove() to ensure that nothing is
pending when the driver is disconnected.
Signed-off-by: Bhaktipriya Shridhar
---
drivers/media/i2c/ad9389b.c | 20
h
the use of system_wq.
&state->edid_handler is a self requeueing work item and it has been
been sync cancelled in ad9389b_remove() to ensure that nothing is
pending when the driver is disconnected.
The unused label err_unreg has also been dropped.
Signed-off-by: Bhaktipriya Shridhar
workqueue with WQ_HIGHPRI set, has been used here
since a delay can cause the outcome to miss the refresh cycle.
Since there are only a fixed number of work items, explicit concurrency
limit is unnecessary here.
Signed-off-by: Bhaktipriya Shridhar
---
Changes in v2:
-Used a dedicated work
Sure. Will make the changes in v2.
Thanks,
Bhaktipriya
On Sun, Jul 17, 2016 at 10:43 AM, Leon Romanovsky wrote:
> On Sat, Jul 16, 2016 at 01:29:20PM +0530, Bhaktipriya Shridhar wrote:
>> The workqueue health->wq was used as per device private health thread.
>> This was d
workitems &cfhsi->wake_up_work
and &cfhsi->wake_down_work cannot be run concurrently.
Calls to flush_workqueue() before destroy_workqueue() have been dropped
since destroy_workqueue() itself calls drain_workqueue() which flushes
repeatedly till the workqueue becomes empty.
Signed-off-b
This patch set fixes the improper usage of the workqueue API.
This includes dropping the freeing of workqueue and removing the
deprecated create_singlethread_workqueue instance.
Bhaktipriya Shridhar (2):
[media] cx25821: Drop Freeing of Workqueue
[media] cx25821: Remove deprecated
Workqueues shouldn't be freed. destroy_workqueue should be used instead.
destroy_workqueue safely destroys a workqueue and ensures that all pending
work items are done before destroying the workqueue.
Signed-off-by: Bhaktipriya Shridhar
---
Changes in v2: None
drivers/media/pci/cx
e.
The work item has been flushed in cx25821_stop_upstream_audio() to ensure
that nothing is pending when the driver is disconnected.
Signed-off-by: Bhaktipriya Shridhar
---
Changes in v2:
-Flushed work item and updated the commit description to reflect
the same.
drivers/media/pci/
tus_cancel_work(), ftdi_command_cancel_work() and
ftdi_response_cancel_work(). These functions are called in
ftdi_elan_exit() to ensure that there are no pending work items while
disconnecting the driver.
Signed-off-by: Bhaktipriya Shridhar
---
drivers/usb/misc/f
ake any difference.
The work item is self-requeueing and needs to wait for the in-flight
work item to finish before proceeding with destruction.
Hence, it has been sync cancelled in appledisplay_disconnect().
This also ensures that there are no pending tasks while disconnecting the
driver.
ake any difference.
The work item is self-requeueing and needs to wait for the in-flight
work item to finish before proceeding with destruction.
Hence, it has been sync cancelled in appledisplay_disconnect().
This also ensures that there are no pending tasks while disconnecting
the driver.
while disconnecting the driver.
Signed-off-by: Bhaktipriya Shridhar
---
drivers/auxdisplay/cfag12864b.c | 12 +---
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/auxdisplay/cfag12864b.c b/drivers/auxdisplay/cfag12864b.c
index 41ce4bd..46f380e 100644
--- a/drivers/auxdi
e of local concurrency shouldn't make any difference.
Work item has been flushed in rtsx_pci_sdmmc_drv_remove() to ensure that
there are no pending tasks while disconnecting the driver.
Signed-off-by: Bhaktipriya Shridhar
---
drivers/mmc/host/rtsx_pci_sdmmc.c | 12 ++--
1 file c
ry reclaim path.
Hence, the singlethreaded workqueue has been replaced with the use of
system_wq.
Work item has been flushed in mlx5_health_cleanup() to ensure that
there are no pending tasks while disconnecting the driver.
Signed-off-by: Bhaktipriya Shridhar
---
Changes in v2:
workqueue in order to schedule port add/remove operations.
WQ_MEM_RECLAIM has been set to guarantee forward progress under memory
pressure.
Can the workitems be executed concurrently?
Are the workitems being used on a memory reclaim path?
Signed-off-by: Bhaktipriya Shridhar
---
drivers/net/ethernet
IM has not been set.
Can the workitems run concurrently? Is the ordering among work items necessary?
Thanks.
Signed-off-by: Bhaktipriya Shridhar
---
drivers/usb/host/whci/init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/whci/init.c b/drivers/usb/host/w
IM has not been set.
Can the workitems run concurrently? Is the ordering among work items
necessary?
Thanks.
Signed-off-by: Bhaktipriya Shridhar
---
drivers/usb/host/u132-hcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/u132-hcd.c b/drivers/usb/host/u132-h
item has been sync cancelled in omapfb_stop_auto_update() which gets
called in omapfb_free_resources() to ensure that nothing is pending when
the driver is disconnected.
Signed-off-by: Bhaktipriya Shridhar
---
drivers/video/fbdev/omap2/omapfb/omapfb-main.c | 23 +--
drivers/
)
to ensure that there are no pending tasks while disconnecting the driver.
Signed-off-by: Bhaktipriya Shridhar
---
drivers/video/fbdev/omap/lcd_mipid.c | 9 +
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/drivers/video/fbdev/omap/lcd_mipid.c
b/drivers/video/fbdev/omap/lcd_
in bfin_spi_destroy_queue() to ensure that there
are no pending tasks while disconnecting the driver.
Signed-off-by: Bhaktipriya Shridhar
---
drivers/spi/spi-bfin5xx.c | 15 ---
1 file changed, 4 insertions(+), 11 deletions(-)
diff --git a/drivers/spi/spi-bfin5xx.c b/drivers/spi
ing the driver.
Signed-off-by: Bhaktipriya Shridhar
---
drivers/spi/spi-sh.c | 16 +++-
1 file changed, 3 insertions(+), 13 deletions(-)
diff --git a/drivers/spi/spi-sh.c b/drivers/spi/spi-sh.c
index 5025011..32ee81c 100644
--- a/drivers/spi/spi-sh.c
+++ b/drivers/spi/spi-sh
ending while disconnecting the driver.
Signed-off-by: Bhaktipriya Shridhar
---
drivers/spi/spi-txx9.c | 11 ++-
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/drivers/spi/spi-txx9.c b/drivers/spi/spi-txx9.c
index d69f8f8..7492ea3 100644
--- a/drivers/spi/spi-txx9.c
+++ b/
ending while disconnecting the driver.
Signed-off-by: Bhaktipriya Shridhar
---
drivers/spi/spi-mpc52xx-psc.c | 17 +++--
1 file changed, 3 insertions(+), 14 deletions(-)
diff --git a/drivers/spi/spi-mpc52xx-psc.c b/drivers/spi/spi-mpc52xx-psc.c
index 72d11eb..42a8b85 100644
--- a/driver
in bfin_sport_spi_destroy_queue() to ensure
that there are no pending tasks while disconnecting the driver.
Signed-off-by: Bhaktipriya Shridhar
---
drivers/spi/spi-bfin-sport.c | 15 ---
1 file changed, 4 insertions(+), 11 deletions(-)
diff --git a/drivers/spi/spi-bfin-sport.c
een removed because with the
usage of system_wq, calls to destroy_workqueue() have been dropped,
which makes the label unnecessary.
Workitem is sync cancelled in dsicm_cancel_ulps_work() which is called
in dsicm_remove() to ensure that there are no workitems pending when the
driver is disconnected.
ncelled in adv7842_remove() to ensure
that there are no pending tasks while disconnecting the driver.
Signed-off-by: Bhaktipriya Shridhar
---
drivers/media/i2c/adv7842.c | 16 ++--
1 file changed, 2 insertions(+), 14 deletions(-)
diff --git a/drivers/media/i2c/adv7842.c b/driv
celled in tc358743_remove() to ensure
that there are no pending tasks while disconnecting the driver.
Signed-off-by: Bhaktipriya Shridhar
---
drivers/media/i2c/tc358743.c | 15 +--
1 file changed, 1 insertion(+), 14 deletions(-)
diff --git a/drivers/media/i2c/tc358743.c b/drive
ncelled in adv76xx_remove() to ensure
that there are no pending tasks while disconnecting the driver.
Signed-off-by: Bhaktipriya Shridhar
---
drivers/media/i2c/adv7604.c | 14 +-
1 file changed, 1 insertion(+), 13 deletions(-)
diff --git a/drivers/media/i2c/adv7604.c b/drivers/media
hdpvr_device_release() to ensure
that there are no pending tasks while disconnecting the driver.
Signed-off-by: Bhaktipriya Shridhar
---
drivers/media/usb/hdpvr/hdpvr-core.c | 10 ++
drivers/media/usb/hdpvr/hdpvr-video.c | 6 +++---
drivers/media/usb/hdpvr/hdpvr.h | 2 --
d_stop0() to ensure that there are no
pending tasks while disconnecting the driver.
Signed-off-by: Bhaktipriya Shridhar
---
drivers/media/usb/gspca/sn9c20x.c | 14 --
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/drivers/media/usb/gspca/sn9c20x.c
b/drivers/media/usb/g
ed in sd_stop0() to ensure that there are no
pending tasks while disconnecting the driver.
Signed-off-by: Bhaktipriya Shridhar
---
drivers/media/usb/gspca/zc3xx.c | 13 -
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/drivers/media/usb/gspca/zc3xx.c b/drivers/
) to ensure that there
are no pending tasks while disconnecting the driver.
Signed-off-by: Bhaktipriya Shridhar
---
drivers/gpu/drm/qxl/qxl_cmd.c | 2 +-
drivers/gpu/drm/qxl/qxl_drv.h | 1 -
drivers/gpu/drm/qxl/qxl_kms.c | 6 +-
3 files changed, 2 insertions(+), 7 deletions(-)
diff --git
, WQ_MEM_RECLAIM has not been set.
Since there are only a fixed number of work items, explicit concurrency
limit is unnecessary here.
Signed-off-by: Bhaktipriya Shridhar
---
drivers/gpu/drm/radeon/radeon_display.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/radeon
een flushed in pch_spi_free_resources() to ensure that
there are no pending tasks while disconnecting the driver.
Signed-off-by: Bhaktipriya Shridhar
---
drivers/spi/spi-topcliff-pch.c | 25 +++--
1 file changed, 3 insertions(+), 22 deletions(-)
diff --git a/drivers/spi/spi-topc
nce.
Since the work items could be pending, flush_work() has been used in
xen_pcibk_disconnect(). xen_pcibk_xenbus_remove() calls free_pdev()
which in turn calls xen_pcibk_disconnect() for every pdev to ensure that
there is no pending task while disconnecting the driver.
Signed-off-by: Bhakt
() itself calls
drain_workqueue() which flushes repeatedly till the workqueue
becomes empty. Hence the call to flush_workqueue() has been dropped.
Signed-off-by: Bhaktipriya Shridhar
---
drivers/net/ethernet/intel/fm10k/fm10k_main.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a
CLAIM has been set to guarantee forward progress.
flush_workqueue is unnecessary since destroy_workqueue() itself calls
drain_workqueue() which flushes repeatedly till the workqueue
becomes empty. Hence the call to flush_workqueue() has been dropped.
Signed-off-by: Bhaktipriya Shridhar
---
driver
ive
as 0 since there is no need for throttling the number of active work
items.
Lastly, WQ_MEM_RECLAIM flag has been added to guarantee forward progress
in memory reclaim path.
Signed-off-by: Bhaktipriya Shridhar
---
drivers/scsi/device_handler/scsi_dh_alua.c | 2 +-
1 file changed, 1 insertion(
been set to guarantee forward progress.
Signed-off-by: Bhaktipriya Shridhar
---
drivers/net/fjes/fjes_main.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/fjes/fjes_main.c b/drivers/net/fjes/fjes_main.c
index 86c331b..9006877 100644
--- a/drivers/net/fjes
Sorry about that. Will make the corrections in v2.
Thanks,
Bhaktipriya
On Tue, May 31, 2016 at 9:48 PM, David Vrabel wrote:
> On 27/05/16 19:50, Bhaktipriya Shridhar wrote:
>> With concurrency managed workqueues, use of dedicated workqueues can be
>> replaced by using
rence.
In this case, there is only a single work item, increase of concurrency
level by switching to system_wq should not make any difference.
Signed-off-by: Bhaktipriya Shridhar
---
drivers/xen/xenbus/xenbus_probe_frontend.c | 15 +--
1 file changed, 1 insertion(+), 14 deletions(-
.
Signed-off-by: Bhaktipriya Shridhar
---
drivers/block/mtip32xx/mtip32xx.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/block/mtip32xx/mtip32xx.c
b/drivers/block/mtip32xx/mtip32xx.c
index 6053e46..4bfb75b 100644
--- a/drivers/block/mtip32xx/mtip32xx.c
+++ b/drivers
ere are only a fixed number of work items, explicit concurrency
limit is unnecessary.
Signed-off-by: Bhaktipriya Shridhar
---
drivers/iommu/amd_iommu_v2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iommu/amd_iommu_v2.c b/drivers/iommu/amd_iommu_v2.c
index 56999d2f..
een set to guarantee forward progress under
memory pressure, which is a requirement in this case.
Since there are only a fixed number of work items, explicit concurrency
limit is unnecessary here.
Signed-off-by: Bhaktipriya Shridhar
---
drivers/hv/connection.c | 3 ++-
1 file changed, 2 insertion
cality or global ordering guarantees unless the target CPU is
explicitly specified and thus the increase of local concurrency
shouldn't make any difference.
cancel_work_sync() has been used in _host1x_free_syncpt_irq() to ensure
that no work is pending by the time exit path runs.
Signed-off-by:
amp;bond->alb_work, &bond->mii_work, &bond->ad_work, &bond->slave_arr_work
which require strict execution ordering. Hence, an ordered dedicated
workqueue has been used.
Since, it is a network driver, WQ_MEM_RECLAIM has been set to
ensure forward progress under memory pressu
orward progress under
memory pressure since it's a network driver.
Since there are fixed number of work items, explicit concurrency
limit is unnecessary here.
Signed-off-by: Bhaktipriya Shridhar
---
drivers/net/usb/pegasus.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --g
d_halt to ensure that
there are no pending tasks while disconnecting the driver.
Signed-off-by: Bhaktipriya Shridhar
---
drivers/parisc/led.c | 23 ++-
1 file changed, 6 insertions(+), 17 deletions(-)
diff --git a/drivers/parisc/led.c b/drivers/parisc/led.c
index b482431..8
pressure.
Since there are a fixed number of work items, explicit concurrency
limit is unnecessary here.
Signed-off-by: Bhaktipriya Shridhar
---
drivers/block/rsxx/core.c | 3 ++-
drivers/block/rsxx/cregs.c | 4 ++--
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/block/r
re block multi disk
drivers and require forward progress under memory pressure.
Since there are fixed number of work items, explicit concurrency
limit is unnecessary here.
Signed-off-by: Bhaktipriya Shridhar
---
drivers/md/dm-bufio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --
create_singlethread_workqueue
instance.
WQ_MEM_RECLAIM has not been set since the driver is not being used on a
memory reclaim path.
Signed-off-by: Bhaktipriya Shridhar
---
drivers/bluetooth/hci_qca.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/bluetooth/hci_qca
d in ps3av_remove to ensure that
there are no pending tasks while disconnecting the driver.
Signed-off-by: Bhaktipriya Shridhar
---
drivers/ps3/ps3av.c | 11 ++-
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/drivers/ps3/ps3av.c b/drivers/ps3/ps3av.c
index 437fc35..e293606 1
t
there are no pending tasks while disconnecting the driver.
Signed-off-by: Bhaktipriya Shridhar
---
drivers/base/dd.c | 12 +++-
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/drivers/base/dd.c b/drivers/base/dd.c
index 16688f5..3f5a867 100644
--- a/drivers/base/dd.c
+++
on a memory reclaim path, WQ_MEM_RECLAIM
flag has been set to ensure forward progress under memory pressure.
Since there are fixed number of work items, explicit concurrency
limit is unnecessary here.
Signed-off-by: Bhaktipriya Shridhar
---
fs/afs/vlocation.c | 4 ++--
1 file changed, 2 inserti
This patch set removes deprecated create_singlethread_workqueue
usages in fs/.
Bhaktipriya Shridhar (9):
fs/afs/vlocation: Remove deprecated create_singlethread_workqueue
fs/afs/rxrpc: Remove deprecated create_singlethread_workqueue
fs/afs/callback: Remove deprecated
nsure forward progress under
memory pressure because the workqueue is being used on a memory reclaim
path.
Since there are fixed number of work items, explicit concurrency
limit is unnecessary here.
Signed-off-by: Bhaktipriya Shridhar
---
fs/afs/flock.c | 4 ++--
1 file changed, 2 insertions(+)
progress under memory
pressure.
Signed-off-by: Bhaktipriya Shridhar
---
fs/ocfs2/cluster/tcp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ocfs2/cluster/tcp.c b/fs/ocfs2/cluster/tcp.c
index 4238eb2..47afe9c 100644
--- a/fs/ocfs2/cluster/tcp.c
+++ b/fs/ocfs2/cluster/
RECLAIM has been set to ensure forward progress under memory
pressure because the workqueue is being used on a memory reclaim path.
Signed-off-by: Bhaktipriya Shridhar
---
fs/ocfs2/super.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ocfs2/super.c b/fs/ocfs2/super.c
index
M flag has been set to ensure forward progress under
memory pressure.
Since there are fixed number of work items, explicit concurrency
limit is unnecessary here.
Signed-off-by: Bhaktipriya Shridhar
---
fs/ocfs2/dlmfs/dlmfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/oc
path, WQ_MEM_RECLAIM
has been set to ensure forward progress under memory pressure.
Signed-off-by: Bhaktipriya Shridhar
---
fs/afs/callback.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/afs/callback.c b/fs/afs/callback.c
index 7ef637d..1e9d2f8 100644
--- a/fs/afs
nsure forward progress under
memory pressure because the workqueue is being used on a memory reclaim
path.
Since there are fixed number of work items, explicit concurrency
limit is unnecessary here.
Signed-off-by: Bhaktipriya Shridhar
---
fs/afs/rxrpc.c | 2 +-
1 file changed, 1 insertion(+), 1 d
forward progress under
memory pressure.
Since there are fixed number of work items, explicit concurrency
limit is unnecessary here.
Signed-off-by: Bhaktipriya Shridhar
---
fs/ocfs2/dlm/dlmdomain.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ocfs2/dlm/dlmdomain.c b/fs
1 - 100 of 214 matches
Mail list logo